[01:11:59] <georgebarnick>	 hey so I'm trying to install wikibase (without composer, before you ask), and I'm getting an error that makes no sense
[01:12:01] <georgebarnick>	 PHP Fatal error:  Class 'Wikibase\TemplateRegistry' not found in /home2/georgfd9/public_html/wikibase/extensions/Wikibase/lib/WikibaseLib.php on line 95
[01:12:13] <georgebarnick>	 I just cloned it, so idk how there's a missing class
[01:12:29] <georgebarnick>	 Unless I'm using some incorrect branch or something
[01:20:52] <georgebarnick>	 JeroenDeDauw: ping because you'd probably know
[10:00:24] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 25/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135304 
[10:09:11] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135304 (owner: 10WikidataBuilder)
[11:17:27] <grrrit-wm>	 (03CR) 10Aude: [C: 032] New Wikidata Build - 25/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135304 (owner: 10WikidataBuilder)
[11:20:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: New Wikidata Build - 25/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135304 (owner: 10WikidataBuilder)
[11:37:12] <grrrit-wm>	 (03PS1) 10Aude: Fix typos in comments [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135306 
[11:43:49] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135306 (owner: 10Aude)
[12:34:03] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135304 (owner: 10WikidataBuilder)
[13:35:07] <lazowik>	 hi :)
[15:31:44] <Reedy>	 We're just under 60k from 17M
[15:42:22] <SPF|Cloud>	 17:31:45 <Reedy> We're just under 60k from 17M <- 17M what?
[15:44:36] <sjoerddebruin>	 All the pages plus users?
[15:44:51] <sjoerddebruin>	 Oh wait, still need some things then
[15:45:08] <Reedy>	 Q
[16:05:06] <addshore>	 JeroenDeDauw: around? :)
[16:05:30] <Jianhui67>	 addshore: yo
[16:05:36] <addshore>	 yo Jianhui67 !
[16:06:22] <JohnLewis>	 addshore :o
[16:06:45] <JohnLewis>	 urg Lydia is still not here. Why did it have to be this weekend >.>
[16:06:56] <addshore>	 hows JohnLewis :P
[16:07:00] <addshore>	 *howdy
[16:07:03] <JohnLewis>	 addshore: Hey
[16:07:07] <JohnLewis>	 aude: There? :p
[16:07:13] <Jianhui67>	 hi JohnLewis
[16:07:25] * JohnLewis looks at something quickly
[16:08:18] <JohnLewis>	 Why are you guys so bad at making Lydia's work easy with the development updates?
[16:10:41] <addshore>	 :P
[16:11:08] <JohnLewis>	 Thiemo_WMDE: Are you here by any chance? Mind pulling off what you did last week? :p
[16:12:00] * addshore should finish his php lib for interacting with wikibase today
[16:33:02] <benestar>	 JohnLewis: hi :)
[16:33:36] <JohnLewis>	 Hey benestar
[16:36:51] <benestar_>	 JohnLewis: is Lydia_WMDE still on the WMDE meeting?
[16:37:05] <GerardM->	 hey JohnLewis the Dutch have ranks for their civil servants.. How do I say this ?
[16:37:25] <JohnLewis>	 benestar: She's still away from IRC. I just emailed her about some stuff.
[16:37:36] <JohnLewis>	 GerardM-: I have no idea.
[16:38:45] <GerardM->	 .. this channel does not really function for these kind of questions... it is very much about WIkidata development
[16:39:36] <benestar_>	 GerardM-: hehe, that's right ;)
[16:40:03] <benestar_>	 these kind of questions are rather to be discussed on project chat
[16:40:24] <benestar_>	 or I misunderstood your question...
[16:42:46] <GerardM->	 no you do not
[16:42:51] <GerardM->	 we do not have a project chat
[16:43:14] <GerardM->	 or should I say a place where we can chat on IRC
[16:43:39] <JohnLewis>	 This is meant to be the community-dev channel :p
[16:43:58] <GerardM->	 yes
[16:44:14] <GerardM->	 and consequently we lack a channel
[16:44:22] <JohnLewis>	 We do not lack a channel.
[16:44:56] <GerardM->	 With due respect I have suffered from the breakdown and lack of communication
[16:45:01] <GerardM->	 so I beg to differ
[16:45:32] <JohnLewis>	 Well that's the community's issue.
[16:46:07] <GerardM->	 right .. so where do you go for such questions?
[16:46:25] <JohnLewis>	 WD:PC, Wikidata-l or #wikidata
[16:47:41] <GerardM->	 what is the first ?
[16:47:54] <JohnLewis>	 https://wikidata.org/wiki/WD:PC
[16:47:55] <benestar_>	 GerardM-: the issue is not the channel but that the Wikidata community does not seem to use IRC a lot
[16:48:12] <benestar_>	 so by project chat I meant [[WD:PC]]
[16:48:20] * benestar_ agrees to JohnLewis
[16:49:14] <GerardM->	 what I find is that when I ask a question, there is hardly ever an answer
[16:49:31] <GerardM->	 so at that this channel does not really work
[16:49:52] <benestar_>	 GerardM-: yes, and this is because Wikidata's community members do not use IRC a lot
[16:49:53] <JohnLewis>	 It's the community which doesn't active use IRC
[16:50:09] <GerardM->	 chicken and egg perhaps ?
[16:50:19] <JohnLewis>	 No
[16:50:36] <benestar_>	 just go to https://wikidata.org/wiki/WD:PC as JohnLewis pointed out
[16:53:08] <benestar_>	 by the way, is really no dev around?
[16:53:34] <benestar_>	 eg aude or addshore might be available...
[16:53:50] <GerardM->	 <grin> it is weekend
[16:53:50] <JohnLewis>	 benestar_: Define dev :p
[16:54:14] <benestar_>	 JohnLewis: somebody who knows why I cannot remove any labels through wbeditentity api module anymore :P
[16:54:31] <JohnLewis>	 benestar_: API stuff addshore knows but he is no longer a 'dev' :p
[16:54:48] <benestar_>	 JohnLewis: he is not a WMDE dev
[16:55:00] <JohnLewis>	 benestar_: That's what I meant :p
[16:55:54] * benestar_ will look into the source code
[16:56:37] <addshore>	 whats up?
[16:56:58] <addshore>	 benestar_: you cant? :O
[16:57:50] <benestar_>	 addshore: yes, it gives me {"servedby":"mw1017","error":{"code":"modification-failed","info":"Must be at least {{PLURAL:1|one character|1 characters}} long","messages":[{"name":"wikibase-validator-too-short","parameters":["1",""],"html":{"*":"Muss mindestens ein Zeichen lang sein"}}]}}
[16:58:05] <benestar_>	 for the data parameter set as {"labels":{"de":{"language":"de","value":""}},"descriptions":{"de":{"language":"de","value":""}},"aliases":{"de":[{"language":"de","value":""}]}}
[17:00:04] <addshore>	 hmmmm
[17:00:24] <addshore>	 sounds like one of daniels changes broke it
[17:01:04] <JohnLewis>	 addshore: Sure, blame Daniel.
[17:01:08] <benestar_>	 addshore: this line should catch it
[17:01:12] <addshore>	 I'm surprised there wernt any tests for that :P
[17:01:12] <benestar_>	 	if ( array_key_exists( 'remove', $arg ) || $newLabel === "" ) {
[17:01:14] <benestar_>	 $labelChangeOps[] = $this->termChangeOpFactory->newRemoveLabelOp( $language );
[17:01:15] <benestar_>	 }
[17:01:19] <benestar_>	 lol
[17:01:36] <benestar_>	 EditEntity.php line 281
[17:01:52] <addshore>	 will take a look in a sec :)
[17:10:28] <addshore>	 benestar_: looks like its the alises causing the problem not labels or descriptions
[17:11:04] <benestar_>	 addshore: oh, so how should it work then?
[17:11:32] <addshore>	 {"aliases":{"en-gb":[]}}
[17:11:45] <addshore>	 an empty array of aliases, rather and an array with an empty alis in it
[17:11:58] <addshore>	 [=
[17:12:06] <addshore>	 so nothing is broken :D
[17:12:15] <benestar_>	 hehe. ok
[17:12:30] <benestar_>	 addshore: by the way I just noticed that "remove":true instead of "value":"" does not work
[17:13:15] <addshore>	 really?
[17:14:01] <benestar_>	 maybe I did not understand the expected syntax as well
[17:14:13] <benestar_>	 but it tells me it wants a string for the value field
[17:15:05] <addshore>	 {"labels":{"en-gb":{"language":"en-gb","value":"BLUB","remove":true}}} works for me
[17:15:28] <benestar_>	 addshore: but I expect {"labels":{"en-gb":{"language":"en-gb","remove":true}}}
[17:15:30] <benestar_>	 to work
[17:15:40] <addshore>	 that should also work
[17:15:49] <benestar_>	 it does not work for me
[17:15:50] <addshore>	 file a bug? :D
[17:15:59] <benestar_>	 please try you before
[17:16:15] <benestar_>	 perhaps I am too stupid to understand the behaviour :P
[17:16:32] <addshore>	 yup A string was expected, but not found in the json for the langCode en-gb and argument 'value'
[17:16:36] <benestar_>	 thx
[17:20:09] <benestar_>	 addshore: "aliases":{"en-gb":[]} does nothing by the way...
[17:20:54] <addshore>	 really?
[17:21:18] <addshore>	 I would have expected that to set it to an empty array, but perhaps not, maybe another butg is needed :P
[17:25:11] <addshore>	 benestar|afk: what are you writing when your finding all of this out? :p
[17:32:08] <JeroenDeDauw>	 aude: what. y the js be failing? omg wow
[17:32:13] <JeroenDeDauw>	 It's an addshore 
[17:32:26] <addshore>	 its a JeroenDeDauw !
[17:33:13] <addshore>	 JeroenDeDauw: I have a design question :) specifically about https://github.com/addwiki/mediawiki-api/blob/master/src/Service/PageProtector.php and a few other classes like it
[17:34:00] <Lydia_WMDE>	 JohnLewis: sorry! thanks so much for getting the summary out. i am back now.
[17:34:12] <JohnLewis>	 \o/
[17:34:17] <JohnLewis>	 benestar|afk ^^
[17:34:23] <Lydia_WMDE>	 \o/ indeed
[17:34:32] <addshore>	 things like protection, deletion, revdeletion require extra params / options such as the level of protection for users, admins, or the expiry, Best to have a generic options object or specific objects for each type of action, ie. protect, delete etc.?
[17:36:06] <JeroenDeDauw>	 addshore: these are global options, per user options, or options per request to the service?
[17:36:17] <addshore>	 per request to the service
[17:37:19] <addshore>	 im guessing some sort of specific fluid options object for each type of action might be best
[17:37:20] <JeroenDeDauw>	 addshore: I'd be inclined to avoid binding those actions together in any way if what they do and the stuff they need is different
[17:37:42] <JeroenDeDauw>	 You could have them implement some common interface if you do event sourcing or whatever, though you probably cannot even do that here
[17:37:51] <addshore>	 yup, okay :)
[17:38:00] <JeroenDeDauw>	 addshore: you mean esentially a hash map?
[17:38:03] <aude>	 JeroenDeDauw: no idea how we missed the js bugs for so long
[17:38:24] <addshore>	 JeroenDeDauw: basically
[17:38:45] * aude needs to edit more regularly (although they shouldn't have made it into deployment)
[17:39:14] <JeroenDeDauw>	 addshore: sounds like a bad idea to me, though ofc I do not really know what options we are talking about
[17:39:18] * aude eats and back later
[17:39:58] <addshore>	 JeroenDeDauw: let me write something :)
[17:40:02] <JeroenDeDauw>	 aude: yeah, it's really sad this makes it into deployment :(
[17:40:41] <gh-wmde>	 [13ValueView] 15JeroenDeDauw closed pull request #54: Remove duplicate array key (06master...06duplicate-key) 02http://git.io/vJ09Qw
[17:40:54] <gh-wmde>	 [13ValueView] 15JeroenDeDauw 04deleted 06comma at 1422fefc3: 02http://git.io/jePx4A
[17:41:49] <addshore>	 JeroenDeDauw: to avoid having public function protect( Page $page, $protections, $expiry, $reason = '', $cascade = false ) {
[17:42:00] <addshore>	 instead I guess just $page and $options :/
[17:43:38] <addshore>	 with some ProtectionOptions object :P
[17:45:15] <JeroenDeDauw>	 addshore: sounds reasonable
[17:45:35] <JeroenDeDauw>	 addshore: though I wonder what the typical lifetime of this object will be
[17:45:40] <JeroenDeDauw>	 And what collaborators it will have
[17:45:44] <addshore>	 milliseconds
[17:45:50] <JeroenDeDauw>	 >_>
[17:46:08] <addshore>	 yeh :P
[17:46:15] <JeroenDeDauw>	 addshore: the scope in which it lives, not the cpu cycles before it gets garbadge collected! :D
[17:46:22] <addshore>	 :P
[17:47:11] <addshore>	 object created, options set, passed into the service method, and boom its gone. The only thing that would interact with it is the service it is designed for
[17:48:30] <JeroenDeDauw>	 addshore: so you expect only one call to the protect method during its lifetime?
[17:48:54] <addshore>	 during the lifetime of the options object? or the lifetime of the service?
[17:52:24] <addshore>	 different options could be used for each request so one call to the method in the options lifetime (probably). The service itself should be around for multiple requests in most cases
[19:11:13] <grrrit-wm>	 (03PS1) 10Bene: Fix removing a label through wbeditentity with "remove":true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135327 (https://bugzilla.wikimedia.org/65744) 
[19:17:26] <benestar>	 Lydia_WMDE: you closed the mobile wikidata bug as wontfix
[19:17:50] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135327 (https://bugzilla.wikimedia.org/65744) (owner: 10Bene)
[19:18:21] <benestar>	 Lydia_WMDE: does this mean that we do not actually need a mobile wikidata anymore?
[19:19:54] <aude>	 i think it will be considered in the new UI
[19:20:19] <Lydia_WMDE>	 benestar: what aude said
[19:20:39] <Lydia_WMDE>	 i am trying to get rid of as many bug reports we can't act on as possible
[19:20:45] <Lydia_WMDE>	 so we actually find the relevant ones
[19:21:14] <benestar>	 aude: so the new UI will be responsible?
[19:21:30] <benestar>	 I think it would make more sense to split the mobile view from the normal UI
[19:22:48] <aude>	 benestar: should be
[19:23:34] <aude>	 the normal UI should at least be made in a way that it's largely reusable in mobile
[19:23:50] <aude>	 maybe combined with css tweaks or whatnot
[19:25:43] <lazowik>	 hello again :)
[19:27:05] <aude>	 hi
[19:45:19] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135371 (owner: 10L10n-bot)
[19:45:52] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/fd1ac04 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26005808
[20:57:04] <benestar>	 Lydia_WMDE: did you read my question on https://bugzilla.wikimedia.org/show_bug.cgi?id=65397 ?
[20:57:26] <Krenair>	 I was looking at the wikidata game tool (someone mentioned it on labs-l and thought I'd take a look) and ran across https://www.wikidata.org/wiki/Q965116
[20:58:39] <Krenair>	 unfortunately I get 'undefined is not a function' errors on load and can't use the 'edit' link next to instanceof human (Cannot read property 'data' of undefined)
[20:59:10] <lazowik>	 hmm
[20:59:50] <JohnLewis>	 Seems fine for me Krenair.
[20:59:56] <Reedy>	 WFM
[21:00:24] <Krenair>	 hm. The errors apparently come from "VM2183"
[21:02:38] <Krenair>	 looks like my global JS is breaking things quite significantly
[21:03:31] <Krenair>	 weird. doesn't appear to affect other sites
[21:04:54] <Reedy>	 WikiData is pretty different
[21:05:03] <Reedy>	 God knows why i CamelCased it
[21:05:35] <Krenair>	 yeah, though I wasn't expecting to get such errors :/
[21:05:54] <Reedy>	 if wikidata return