[00:45:20] (03Draft1) 10Aude: Update lua tests for snak error formatting changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 [00:50:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [02:02:39] (03PS4) 10Aude: Cleanup in PropertyValueSnakFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 [02:04:45] (03PS5) 10Aude: Cleanup in PropertyValueSnakFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 [02:10:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 (owner: 10Aude) [02:14:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 (owner: 10Aude) [08:35:34] (03CR) 10Thiemo Mättig (WMDE): "Isn't there a way to first check the namespace and then do the parsing only for this namespace? Just curious. The current solution is a go" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [08:58:08] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Looks good for me, so it's almost a +1 from my side except for a tiny little detail (see comment). But I would like to hear what the other" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134945 (owner: 10Bene) [09:05:50] if I know page title in Xx Wikipedia, how do I get the Q number? [09:08:07] Just click "data item" on the article [09:11:29] Jurgen: programmatically I mean [09:12:16] by API? [09:13:44] yes? I do not want to screenscrape or anything [09:15:18] (03PS1) 10Christopher Johnson (WMDE): fix incorrect path to ui icon file Bug: 63363 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135006 (https://bugzilla.wikimedia.org/63363) [09:15:27] It's in here, but I think there is a easier way... https://www.wikidata.org/w/api.php?action=wbgetentities&sites=enwiki&titles=Berlin&languages=en [09:17:17] Hm. https://www.wikidata.org/wiki/Wikidata:Creating_a_bot#Example_1:_Get_Q_number [09:17:56] So yes, thats the way I think... [09:19:33] thanks [09:20:20] * Nikerabbit mumbles something about using regexp to parse json.. [09:21:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135006 (https://bugzilla.wikimedia.org/63363) (owner: 10Christopher Johnson (WMDE)) [09:24:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] fix incorrect path to ui icon file Bug: 63363 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135006 (https://bugzilla.wikimedia.org/63363) (owner: 10Christopher Johnson (WMDE)) [09:24:37] (03Merged) 10jenkins-bot: fix incorrect path to ui icon file Bug: 63363 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135006 (https://bugzilla.wikimedia.org/63363) (owner: 10Christopher Johnson (WMDE)) [09:33:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/bec8927 : Christopher Johnson The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25855866 [09:38:50] Nikerabbit: https://www.wikidata.org/wiki/Special:ItemByTitle [09:47:44] (03CR) 10Daniel Kinzler: Insert classes for badges on client (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [10:00:29] (03PS1) 10WikidataBuilder: New Wikidata Build - 23/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135009 [10:03:21] sjoerddebruin, thanks for replying to Nikerabbit. I wondered about the same thing a few days ago. [10:04:29] I looked for a way to do it directly in the Wikipedia and couldn't find it. It's not entirely intuitive to look for in wikidata.org, but now that I see it, it does what we need. [10:04:53] :) [10:07:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135009 (owner: 10WikidataBuilder) [10:15:33] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "1.23 is still a release candidate. The current code doesn't hurt. Let's wait a bit and merge this later, ok?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134815 (owner: 10Hoo man) [10:20:38] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "You may disagree with my comment. I set -1 to get your attention. ;-)" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134874 (https://bugzilla.wikimedia.org/65646) (owner: 10Aude) [10:47:26] [13WikibaseDataModel] 15thiemowmde 04deleted 06c at 14ee608a1: 02http://git.io/G4ak1Q [11:09:05] [travis-ci] wmde/WikibaseQueryEngine/equality-hash/90f5ed5 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25861756 [11:30:53] [13DataValues] 15thiemowmde created 06hash-length (+1 new commit): 02http://git.io/5AoxRQ [11:30:53] 13DataValues/06hash-length 140bebfe4 15Thiemo Mättig: Specify hash length [11:31:28] (03CR) 10Daniel Kinzler: [C: 04-1] Check for non-existing EntityRevision in MergeItems api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134874 (https://bugzilla.wikimedia.org/65646) (owner: 10Aude) [11:32:22] (03CR) 10Daniel Kinzler: [C: 031] "I'm all for having Lua tests for this, but I don't understand how they work..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [11:32:48] okay my next question: Why doesn't the titles parameter for wbgetentities accept canonical namespaces? [11:33:32] (03CR) 10Daniel Kinzler: [C: 032] Cleanup in PropertyValueSnakFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 (owner: 10Aude) [11:33:53] (03Merged) 10jenkins-bot: Cleanup in PropertyValueSnakFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 (owner: 10Aude) [11:34:54] (03CR) 10Daniel Kinzler: [C: 031] "seems fine, but i'll let a ui expert make that call :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134663 (owner: 10Aude) [11:38:46] @part ##NSS [11:38:51] @add ##NSS [11:39:11] (03CR) 10Daniel Kinzler: "@Thiemo: not without pulling in additional dependencies." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [11:39:47] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1: please just return null for non-entity titles." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [11:42:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9bea327 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25863492 [11:43:06] [13DataValues] 15thiemowmde opened pull request #6: Specify hash length (06master...06hash-length) 02http://git.io/eHRaag [12:06:27] (03CR) 10Daniel Kinzler: Refactoring ItemDisambiguation logic. (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [12:06:55] (03PS3) 10Daniel Kinzler: Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 [12:07:40] (03PS4) 10Daniel Kinzler: Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 [12:13:03] (03PS6) 10Daniel Kinzler: Minimize usage of EntityContent / ECFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 [12:14:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [12:20:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [12:23:01] [travis-ci] wmde/WikibaseQueryEngine/sort-array/1affc32 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25866199 [12:23:59] Tobi_WMDE, aude, hoo: any ideas? PHP Fatal error: Call to undefined method PHPUnit_Framework_TestSuite::isPublicTestMethod() in /var/www/daniel/wikidata/extensions/Scribunto/tests/engines/LuaCommon/LuaEngineTestBase.php on line 104 [12:24:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 (owner: 10Daniel Kinzler) [12:24:20] :O [12:24:31] DanielK_WMDE: is the test method public? ;p [12:24:32] DanielK_WMDE: see katies last daily email [12:24:43] scribuntu is missing on jenkins [12:24:56] need to merge the puppet change I guess [12:25:46] Tobi_WMDE: i don't think that's that issue [12:26:16] i read what she wrote as "scribunto isn't tested by jenkins" [12:26:19] my failrue is on jenkins. [12:26:35] and it's strange. it seems completely unrelated to the patch, but happens only for that patch (i think) [12:26:45] DanielK_WMDE: hm [12:26:54] ok, that's strange indeed [12:27:11] ok, more specifically: jenkins dies without an error message. when i run it locally, i get that error [12:27:15] with scribunto installed [12:27:48] Tobi_WMDE: getting that on master too, locally. [12:28:10] hm... maybe I'm hitting the problem katie mentioned locally, and the reason jenkins dies is something else still? [12:28:39] DanielK_WMDE: it sounds like the problems were independent [12:28:51] jenkins is fine with other changes [12:28:52] might be [12:29:03] as long as i have the one problem, i can't investigate the other [12:29:21] yea, looks like lua tests are broken on master [12:29:23] DanielK_WMDE: I'll install scribuntu on jenkins, then let's see [12:29:27] can't run unit tests locally. [12:29:53] Tobi_WMDE: atm, that would just cause all client tests to fail, since this is broken on master [12:29:55] [travis-ci] wmde/WikibaseQueryEngine/sort-array/159b3f1 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25866923 [12:30:30] DanielK_WMDE: I guess so. so should I NOT install it? [12:30:44] Tobi_WMDE: not until this issue is fixed. [12:31:01] hm.. will someone fix the issue as long as nobody sees it? :) [12:31:12] but... this means that the issue that blocks me locally isn't the issue that causes jenkins to fail... [12:31:45] DanielK_WMDE: yeah, means the silent failure on jenkins has to do with that particular change [12:31:45] * DanielK_WMDE disables Scribunto locally [12:35:33] Tobi_WMDE: new one (from core!): PHP Fatal error: Class MediaWikiPHPUnitTestListener contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPUnit_Framework_TestListener::addRiskyTest) in /var/www/daniel/wikidata/tests/phpunit/MediaWikiPHPUnitTestListener.php on line 128 [12:35:53] something seriously screwed up phpunit integration [12:37:58] [travis-ci] wmde/WikibaseQueryEngine/sort-array/6ebcf27 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25867042 [12:38:51] [13ValueView] 15tobijat pushed 1 new commit to 06monobook: 02http://git.io/0-_bTA [12:38:51] 13ValueView/06monobook 140bcb530 15Tobias Gritschacher: Updated release notes [12:39:11] [13ValueView] 15tobijat closed pull request #52: Make widgets visible in MonoBook (06master...06monobook) 02http://git.io/7K1hDA [12:44:32] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06dbal: 02http://git.io/LdnXgw [12:44:32] 13WikibaseQuery/06dbal 140b34b5a 15jeroendedauw: Ignore SQLite failures for now [12:44:56] DanielK_WMDE: I don't have that method in my version of phpunit [12:45:01] what version do you have? [12:46:28] Tobi_WMDE: 3.7.22 [12:46:46] Tobi_WMDE: i have a different error mow (on latest master of both core and wikibase): [12:46:53] Fatal error: Class MediaWikiPHPUnitTestListener contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPUnit_Framework_TestListener::addRiskyTest) in /var/www/daniel/wikidata/tests/phpunit/MediaWikiPHPUnitTestListener.php on line 128 [12:47:05] something must be *really* screwed up, and i do not understand how or why [12:48:08] [travis-ci] wmde/WikibaseQuery/dbal/0b34b5a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/25868214 [12:55:35] Tobi_WMDE: so, the current situation is: core is not compatible with the version of phpunit it installes via composer. [12:55:37] yay [12:58:48] :) [12:59:14] DanielK_WMDE: mind you, they broke extension installation and MW version checking as well - you need to list all achievements [12:59:23] (03CR) 10Tobias Gritschacher: [C: 032] Add css styles for wb-format-error for snak error display [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134663 (owner: 10Aude) [12:59:28] Thiemo_WMDE: https://github.com/wmde/WikibaseQuery/pull/20 [12:59:41] (03PS5) 10Daniel Kinzler: Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 [13:01:15] [13DataValues] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/g3GHnQ [13:01:15] 13DataValues/06master 14b35afed 15Jeroen De Dauw: Merge pull request #6 from DataValues/hash-length... [13:01:34] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/pull/87 [13:01:48] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Almost ready, yea!" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 (owner: 10Daniel Kinzler) [13:03:33] (03PS7) 10Daniel Kinzler: Minimize usage of EntityContent / ECFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 [13:04:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Minimize usage of EntityContent / ECFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 (owner: 10Daniel Kinzler) [13:07:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [13:10:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 (owner: 10Daniel Kinzler) [13:18:07] JeroenDeDauw: does the new serialization code now support Claims on properties? [13:19:09] DanielK_WMDE: no, and that is not something I think makes sense putting effort into until we made the initial release [13:19:57] JeroenDeDauw: hm? but the API supports it, and the UI supports it. so the serialization kind of needs to support it,no? [13:20:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/73c3b5b : Tobias Gritschacher The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25870215 [13:20:38] this is simply a feature missing from the new implementation [13:20:52] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I think the removal of the original "if labels are equal in both languages, don't show both" should not be part of this patch. But since t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [13:21:02] DanielK_WMDE: you know I disagree with that [13:21:35] JeroenDeDauw: so let's keep diagreeing and keep using the old code. [13:27:28] we have been holding back the roll-out of cliams on properties because of this. [13:28:09] JeroenDeDauw: but anyway: when we switch to the new serialization code, new revisions will be using the new serialization in export/dump, but old ones won't. To avoid that incompatibility, we'll need to fix bug 65256 first [13:28:24] and then make B/C transformation code for Wikibase [13:29:17] DanielK_WMDE: that is a blocker for using the new release in Wikibase, it is not a blocker for making that release [13:29:48] the B/C issue? Yes, true. [13:30:17] Though havign an official release that we won't deploy feels kind of odd... [13:34:50] (03PS6) 10Daniel Kinzler: Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 [13:37:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [13:37:31] (03PS3) 10Michał Łazowik: Add getting entity id from page title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) [13:37:46] DanielK_WMDE: Thiemo_WMDE ^ [13:42:47] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I like it. Daniel?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [13:42:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [13:44:06] (03PS4) 10Daniel Kinzler: Remove StoreFactory and related logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 [13:47:28] [13WikibaseDataModel] 15JeroenDeDauw created 06typelookup (+1 new commit): 02http://git.io/2tm0Zg [13:47:28] 13WikibaseDataModel/06typelookup 143f1cd4e 15jeroendedauw: Add PropertyDataTypeLookup (moved here from WikibaseLib) [13:48:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [13:48:11] (03CR) 10Daniel Kinzler: [C: 032] Add getting entity id from page title (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [13:48:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/eefd513 : Thiemo Mättig (WMDE) The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25872197 [13:48:54] yay [13:48:57] \o/ [13:49:16] ok, I'm off till ~21:00 [13:50:20] (03CR) 10Bene: "There is a patch to fix the performance issue in ClientSiteLinkLookup. https://gerrit.wikimedia.org/r/#/c/134945/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [13:50:42] [travis-ci] wmde/WikibaseDataModel/typelookup/3f1cd4e : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/25872803 [13:51:27] lazowik|afk: seems your change needs rebase [13:51:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [13:53:55] on this one I get an illegal invocation http://tools.wmflabs.org/toolscript/index.html?pastebin=guXqaGQE [13:53:58] (03CR) 10Bene: "Hi Thiemo, the ClientSiteLinkLookup will at least be used by the badges hook [1]. Daniel told me to implement some caching to avoid the mu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134945 (owner: 10Bene) [13:53:58] it works well normally [13:54:04] http://tools.wmflabs.org/reasonator/?&q=3630705 indicates its loading and does not [13:54:15] sorry wrong channel [13:56:19] Thiemo_WMDE , DanielK_WMDE : around? [13:57:10] (03CR) 10Daniel Kinzler: "@Thiemo: caching in the SiteLinkTable makes less sense, since the usage patterns for that class are a lot more diverse than the usage patt" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134945 (owner: 10Bene) [13:57:57] (03CR) 10Daniel Kinzler: [C: 031] "@bene: so rebase this on top of I0b7477aead57, so we don't accidentally end up merging and deploying this in the "inefficient" state that " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [13:59:06] DanielK_WMDE: how does "rebase on top of" work? [13:59:37] benestar: git rebase [13:59:57] ok, thanks :) [14:00:03] if you don't yet have that commit locally, just check out the branch that has it, then switch back to the branch you want to rebase [14:00:19] benestar: oh, and that's commit hash, not change id. [14:02:55] (03PS2) 10Bene: Cache items found in ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134945 [14:05:35] DanielK_WMDE: commit-hash is 42fc02d44c453eb29ebd2f28b9b3018fdbab0905 ? [14:07:12] (03PS6) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [14:08:00] benestar: something like that, yes. it's matched using prefix search, so giving the fires t7 or so charcters is sufficient [14:08:38] DanielK_WMDE: I did git rebase 42fc02d44c453eb29ebd2f28b9b3018fdbab0905 and now git review tells me I am about to submit multiple commits [14:08:42] what shall I do now? [14:08:51] just type yes or did I do something wrong? [14:09:18] just type yes [14:09:33] (03PS11) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) [14:09:39] I think it worked :) [14:09:42] (03PS5) 10Thiemo Mättig (WMDE): Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [14:09:47] you have multiple commits based on the master - it will try to push them all. but it will notice that the other commit is already there, and ignore it [14:10:22] (03CR) 10Thiemo Mättig (WMDE): "Mistakes I fixed in PS5." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [14:10:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134945 (owner: 10Bene) [14:11:25] (03CR) 10Daniel Kinzler: [C: 032] Cache items found in ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134945 (owner: 10Bene) [14:11:42] (03PS12) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) [14:11:59] (03PS1) 10Jeroen De Dauw: Remove unused imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135026 [14:13:44] (03CR) 10Daniel Kinzler: [C: 031] "@Thiemo: thanks for fixing!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [14:14:37] (03PS1) 10Jeroen De Dauw: Remove unused and broken code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135027 [14:15:31] (03PS1) 10Jeroen De Dauw: Fix type hint warnings in static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135028 [14:15:34] (03PS6) 10Daniel Kinzler: Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 [14:16:51] (03PS1) 10Jeroen De Dauw: Fix type hint after rename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135029 [14:18:05] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Fix type hint warnings in static code analysis (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135028 (owner: 10Jeroen De Dauw) [14:18:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [14:18:28] (03PS1) 10Jeroen De Dauw: Remove method that seems to be not used [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135030 [14:20:27] (03PS7) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [14:21:00] (03PS1) 10Jeroen De Dauw: Optimized repo imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135031 [14:21:48] (03PS1) 10Jeroen De Dauw: Remove unused field [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135032 [14:22:36] (03PS1) 10Jeroen De Dauw: Removed unused method makeItem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135033 [14:26:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [14:26:21] (03CR) 10Jeroen De Dauw: [C: 04-1] "Why are you moving code from repo into lib?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [14:27:52] (03CR) 10Daniel Kinzler: "@Jeroen: because this serialization code is needed by WikiPageEntityLookup, which is in lib." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [14:28:21] JeroenDeDauw: we could create a new component here and now, but I think that's nto a good idea. Better think properly about splitting up lib, no? [14:29:14] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "The (as far as I can tell) only usage of this method was removed in Ie55e2f126ba3c585a3f6719408460a7f3e2221f1." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135030 (owner: 10Jeroen De Dauw) [14:31:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 031] Fix type hint after rename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135029 (owner: 10Jeroen De Dauw) [14:31:35] (03Merged) 10jenkins-bot: Fix type hint after rename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135029 (owner: 10Jeroen De Dauw) [14:34:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [14:38:41] JeroenDeDauw: can you provide a way forward on that issue? [14:39:01] Reasonator works again and the other tools as well ... the space for log files was full [14:39:28] hehe, classic [14:39:41] logrotate to the rescue... [14:39:54] (03CR) 10Jeroen De Dauw: "I'd prefer if initiative and responsibility was taken in working towards resolving that problem, rather than deferring it to be fixed "at " (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [14:41:07] JeroenDeDauw: i agree that we should tackle the lib mess. is it on bugzilla? [14:41:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [14:41:27] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/859a3ea : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25876499 [14:42:07] (03CR) 10Jeroen De Dauw: "So you did -1 because I did not remove all unused methods from the codebase in one go?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135030 (owner: 10Jeroen De Dauw) [14:43:27] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/131964/ has a +2 but needs rebasing [14:43:59] lazowik|afk: https://gerrit.wikimedia.org/r/#/c/134727/ has a +2 but needs a rebase [14:46:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135026 (owner: 10Jeroen De Dauw) [14:49:31] (03PS1) 10Jeroen De Dauw: Add missing @return tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135039 [14:49:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ef5934e : Thiemo Mättig (WMDE) The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25876635 [14:50:14] (03PS1) 10Jeroen De Dauw: Optimize client imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135040 [14:51:13] (03PS1) 10Jeroen De Dauw: Add missing imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 [14:54:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135027 (owner: 10Jeroen De Dauw) [14:55:38] (03Abandoned) 10Jeroen De Dauw: Remove method that seems to be not used [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135030 (owner: 10Jeroen De Dauw) [14:57:39] (03CR) 10Daniel Kinzler: "Why is this abandoned? Is there a need for this method after all?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135030 (owner: 10Jeroen De Dauw) [14:59:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135028 (owner: 10Jeroen De Dauw) [15:04:37] Lydia_WMDE: hey, are you around? [15:05:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [15:05:41] benestar: Lydia_WMDE just went home [15:05:48] k [15:11:33] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135029 (owner: 10Jeroen De Dauw) [15:14:42] (03PS7) 10Daniel Kinzler: Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 [15:14:58] Thiemo_WMDE: could you hit the button again? ---^ [15:15:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135030 (owner: 10Jeroen De Dauw) [15:20:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [15:23:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135031 (owner: 10Jeroen De Dauw) [15:25:31] (03PS2) 10Aude: Check for non-existing EntityRevision in MergeItems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134874 (https://bugzilla.wikimedia.org/65646) [15:28:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135032 (owner: 10Jeroen De Dauw) [15:29:51] (03CR) 10Aude: Check for non-existing EntityRevision in MergeItems api module (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134874 (https://bugzilla.wikimedia.org/65646) (owner: 10Aude) [15:30:09] review! :) [15:31:15] (03CR) 10Daniel Kinzler: [C: 032] Check for non-existing EntityRevision in MergeItems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134874 (https://bugzilla.wikimedia.org/65646) (owner: 10Aude) [15:31:33] (03Merged) 10jenkins-bot: Check for non-existing EntityRevision in MergeItems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134874 (https://bugzilla.wikimedia.org/65646) (owner: 10Aude) [15:31:35] thanks [15:32:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135033 (owner: 10Jeroen De Dauw) [15:34:11] aude: yw [15:35:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135039 (owner: 10Jeroen De Dauw) [15:38:27] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix type hint warnings in static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135028 (owner: 10Jeroen De Dauw) [15:38:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135040 (owner: 10Jeroen De Dauw) [15:38:48] (03Merged) 10jenkins-bot: Fix type hint warnings in static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135028 (owner: 10Jeroen De Dauw) [15:39:13] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add missing @return tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135039 (owner: 10Jeroen De Dauw) [15:39:31] (03Merged) 10jenkins-bot: Add missing @return tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135039 (owner: 10Jeroen De Dauw) [15:39:52] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove unused field [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135032 (owner: 10Jeroen De Dauw) [15:40:13] (03Merged) 10jenkins-bot: Remove unused field [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135032 (owner: 10Jeroen De Dauw) [15:40:55] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add missing imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 (owner: 10Jeroen De Dauw) [15:42:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 (owner: 10Jeroen De Dauw) [15:42:52] Thiemo_WMDE: wanna look over https://gerrit.wikimedia.org/r/#/c/124605/ again? DanielK_WMDE already gave +1 [15:45:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [15:47:55] (03CR) 10Daniel Kinzler: [C: 032] Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [15:48:02] \o/ [15:48:12] :DDDD [15:48:14] (03Merged) 10jenkins-bot: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [15:48:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134874 (https://bugzilla.wikimedia.org/65646) (owner: 10Aude) [15:48:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f22d55c : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25881688 [15:49:09] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Oh, Bene*. The method was removed in" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135027 (owner: 10Jeroen De Dauw) [15:49:30] (03Merged) 10jenkins-bot: Remove unused and broken code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135027 (owner: 10Jeroen De Dauw) [15:49:35] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [15:49:54] (03Merged) 10jenkins-bot: Refactoring ItemDisambiguation logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [15:50:48] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 031] Removed unused method makeItem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135033 (owner: 10Jeroen De Dauw) [15:51:11] (03Merged) 10jenkins-bot: Removed unused method makeItem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135033 (owner: 10Jeroen De Dauw) [15:51:25] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [15:51:37] (03CR) 10jenkins-bot: [V: 04-1] Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [15:55:04] so, wikidata has reached the point where we now get vandalism. [15:55:25] saw earlier someone changed the description for Charles Darwin got changed to “gay boy”. [15:55:35] aww, it’s like a baby Wikipedia. :) [15:58:16] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c0e9594 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25882254 [16:09:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4c6bcb1 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25882303 [16:09:57] Thiemo_WMDE: so are you fine with having this merged now or not? https://github.com/wmde/WikibaseDataModel/pull/87 [16:10:08] I have some code that needs this thing [16:10:19] If it does not get merged I'll just copy it in there for now [16:10:22] (03CR) 10Thiemo Mättig (WMDE): "Resetting my +2 because of merge conflicts for now. Daniel, would be good if you can have a quick look, again." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [16:11:03] (03PS7) 10Thiemo Mättig (WMDE): Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [16:11:43] (03PS1) 10Bene: Fix WikibaseClient::getClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135053 [16:12:53] Thiemo_WMDE: one important fix... https://gerrit.wikimedia.org/r/#/c/124605/ [16:13:37] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "The merge conflicts happened in WikibaseClient.hooks.php and EntityContentFactory.php. I removed a now unused there." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [16:19:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [16:21:00] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5cf4e87 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25882351 [16:22:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135053 (owner: 10Bene) [16:26:58] Daniel broke Wikibase -.- [16:27:38] Damn it! [16:27:50] Catchable fatal error: Argument 1 passed to Wikibase\Hook\MakeGlobalVariablesScriptHandler::__construct() must be an instance of Wikibase\EntityContentFactory, instance of Wikibase\store\CachingEntityRevisionLookup given, called in ###\extensions\Wikibase\repo\Wikibase.hooks.php on line 1200 and defined in ###\extensions\Wikibase\repo\includes\Hook\MakeGlobalVariablesScriptHandler.php on line 42 [16:28:01] oh noes [16:28:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0efeaa7 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25883016 [16:29:28] aude: what to do now? [16:29:39] I cannot view any item now :P [16:29:57] (03CR) 10Aude: [C: 032] Fix WikibaseClient::getClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135053 (owner: 10Bene) [16:30:10] i can look [16:30:15] (03Merged) 10jenkins-bot: Fix WikibaseClient::getClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135053 (owner: 10Bene) [16:30:17] benestar: panic! [16:30:18] meh [16:30:26] how did we broke the tests again *sigh* [16:30:32] JeroenDeDauw: yey :D [16:30:43] hoo: oh dear -.- [16:31:02] oh... Lua?! [16:31:06] The DataModel tests are still green Nyan [16:31:45] Tobi_WMDE: Do we still not have Scribunto within Wikidata Jenkins? [16:32:03] That would be *very* bad... that's like the third time that breaks and nobody cared enough to really fix it [16:33:10] hoo: Tobi_WMDE: people should not merge unverified code [16:33:23] No merging of lua code unless someone ran the tests with lua... [16:33:33] WikidataJenkins is supposed to do that [16:33:48] JeroenDeDauw: and nobody merge hooks code without calling an item page... [16:33:58] we really need hook testing by the way [16:34:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ee17406 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25883178 [16:34:48] benestar: well sure [16:35:05] Though a big part of the problem there is that people keep putting things in hook handlers [16:36:09] (03CR) 10Hoo man: "Doesn't matter whether it's a RC or not... we don't support the old software version in other places (at all), so I don't see why we shoul" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134815 (owner: 10Hoo man) [16:40:29] JeroenDeDauw: you mean without creating own classes for them? [16:41:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7371c58 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25883219 [16:42:10] benestar: yes [16:42:28] * JohnLewis wants to tell travis-ci to focus on the good things in life [16:42:34] JeroenDeDauw: so you would be very happy if someone goes there and creates some hook handler classes? [16:42:51] benestar: after a hook handler is created its code should typically not change afterwards, there are exceptional cases of course [16:43:27] benestar: moving out this code was one of the things suggested to us in the external code review we got a year and a half back [16:43:57] JeroenDeDauw: is this something I can do? [16:44:04] I think code moving cannot be that hard [16:44:06] (03CR) 10Thiemo Mättig (WMDE): "Something is stuck. Lets try again." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 (owner: 10Jeroen De Dauw) [16:44:11] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Something is stuck. Lets try again." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 (owner: 10Jeroen De Dauw) [16:45:53] (03PS1) 10Aude: Fix fatal error in Wikibase.hooks.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135060 [16:46:56] too distracted to change the code more than that now [16:47:07] (03CR) 10Bene: [C: 031] Fix fatal error in Wikibase.hooks.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135060 (owner: 10Aude) [16:47:14] (03PS2) 10Thiemo Mättig (WMDE): Add missing imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 (owner: 10Jeroen De Dauw) [16:47:16] (03PS2) 10Thiemo Mättig (WMDE): Optimize client imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135040 (owner: 10Jeroen De Dauw) [16:48:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e3cb2f1 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25883291 [16:50:51] GerardM-: Kan je mij nog die monumenten mapping sturen? [16:51:34] (03PS3) 10Bene: DNM Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) [16:53:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135060 (owner: 10Aude) [16:54:23] aude: can you ask someone to merge this asap because it is quite annoying to not be able to test anything on my local repo... [16:57:57] JeroenDeDauw: hoo Thiemo_WMDE [16:58:25] looking [16:59:19] the easiest solution... nicer solution for daniel or someone with more time is to use entityrevision [17:00:06] (03CR) 10Hoo man: [C: 032] Fix fatal error in Wikibase.hooks.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135060 (owner: 10Aude) [17:00:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 (owner: 10Jeroen De Dauw) [17:00:25] (03Merged) 10jenkins-bot: Fix fatal error in Wikibase.hooks.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135060 (owner: 10Aude) [17:02:59] (03CR) 10Hoo man: [C: 032] "I don't really see the point in include only changes... but also doesn't harm" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135040 (owner: 10Jeroen De Dauw) [17:03:18] (03Merged) 10jenkins-bot: Optimize client imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135040 (owner: 10Jeroen De Dauw) [17:03:28] (03Merged) 10jenkins-bot: Add missing imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135041 (owner: 10Jeroen De Dauw) [17:04:03] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135040 (owner: 10Jeroen De Dauw) [17:04:26] hoo: thanks [17:05:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7dbf4f2 : Bene The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25885972 [17:07:03] https://gerrit.wikimedia.org/r/#/c/134981/ should fix travis [17:07:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [17:07:39] and then we need to get scribunto enabled on jenkins [17:08:07] aude: We tried to have Scribunto on Jenkins before, but it failed for some reason [17:08:23] hmmm [17:08:38] interesting that it works on travis [17:08:41] I think someone said we should migrate to the master branch before (from eqiad) or so [17:08:46] yeah [17:10:38] (03PS4) 10Thiemo Mättig (WMDE): Add getting entity id from page title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [17:11:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c223b01 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25888089 [17:13:05] (03PS5) 10Thiemo Mättig (WMDE): Add getting entity id from page title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [17:13:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [17:15:01] aude: Regarding the lua integration test change [17:15:13] what do you use the mismatch snak for? [17:15:19] I don't see it being used [17:15:45] https://gerrit.wikimedia.org/r/#/c/134981/1 [17:16:31] ah [17:16:36] it should be used [17:17:08] it's part of the test item [17:17:11] $statement1 [17:17:11] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I rebased the thing and replaces some duplicate comments with @see. Please have a quick look if I changed something you may not want in th" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [17:17:22] some more tests should be added that use it [17:17:42] aude: You shouldn't add it w/o making use of it [17:17:51] that's confusing at best [17:17:51] ok [17:17:57] let's see if i can use it :) [17:18:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [17:19:14] (03CR) 10Hoo man: [C: 04-1] "also per IRC" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [17:19:22] just for the record (also note missing docs) [17:21:10] (03CR) 10Jeroen De Dauw: [C: 04-1] Add getting entity id from page title (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [17:24:06] ok [17:37:48] Thiemo_WMDE: http://en.wikipedia.org/wiki/Package_Principles#Overview [17:41:19] hoo|away: i'll have to work on the test later or tomorrow [17:56:17] [13WikibaseDataModel] 15thiemowmde comment on pull request #87 14628f427: For the record: I'm not happy with this method name. What it really does is something like `getLastClaimPerMainSnak`. Which sounds like something domain-specific that shouldn't be part of the all-purpose data model in my opinion. 02http://git.io/oieWYA [17:58:38] [13WikibaseDataModel] 15thiemowmde comment on pull request #87 14628f427: For the record: I'm not happy with this method. In my opinion, the definition of what "best" means is domain-specific and should not be part of the all-purpose data model. 02http://git.io/puHY2Q [18:12:09] [13WikibaseDataModel] 15thiemowmde 04deleted 06claimlist at 14628f427: 02http://git.io/zFm8LQ [18:25:27] [13WikibaseDataModel] 15thiemowmde created 06claims-best (+1 new commit): 02http://git.io/VLkbGQ [18:25:27] 13WikibaseDataModel/06claims-best 14e293178 15Thiemo Mättig: Documentation of "best" [18:25:42] [13WikibaseDataModel] 15thiemowmde opened pull request #99: Documentation of "best" (06master...06claims-best) 02http://git.io/lRg3ZA [18:28:07] [travis-ci] wmde/WikibaseDataModel/claims-best/e293178 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/25894478 [18:43:09] JeroenDeDauw: I just today got mine clean code \o/ [18:43:52] benestar: I just told you like two days ago that I was going to split hooks [18:44:13] lazowik: I forgot [18:44:16] benestar: we can go by extension though :p [18:44:21] one Client one Repo [18:44:30] but I think this is enough work for at least two :P [18:44:36] yep [18:44:51] JeroenDeDauw: what with https://gerrit.wikimedia.org/r/#/c/134727 [18:45:00] make EntityIdLookup interface? [18:45:16] can it then be implemented in EntityContentFactory? [18:46:23] Thiemo_WMDE: if I'm to make EntityIdLookup I'd probably overwrite your changes [18:46:44] of course I'll replace dup comments with @see [18:46:52] but maybe you'll do the other stuff in separate commit? [18:47:18] ah, this other stuff is from rebase [18:47:21] ok [18:56:42] (03CR) 10Thiemo Mättig (WMDE): "Do we need to introduce an EntityIdLookup then? Maybe." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [19:00:09] (03PS6) 10Michał Łazowik: Introduce EntityIdLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) [19:00:29] Thiemo_WMDE: when you were writing "Maybe" I was getting ready to submit patch set [19:00:34] that's agile development :p [19:00:49] JeroenDeDauw: ^ [19:02:35] (03PS7) 10Michał Łazowik: Introduce EntityIdLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) [19:02:36] damn whitespace [19:07:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [19:11:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [19:14:01] (03CR) 10Michał Łazowik: "@JeroenDeDauw are you happy now? :p" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [19:16:47] lazowik: JeroenDeDauw is never happy unless there is a Nyan Cat [19:16:57] JohnLewis: ha [19:17:04] there _is_ a Nyan there! [19:17:07] in tests! [19:17:13] :D [19:17:25] JohnLewis: https://gerrit.wikimedia.org/r/#/c/134727/7/repo/tests/phpunit/includes/content/EntityContentFactoryTest.php [19:17:34] that's even a _special_ nyan! [19:17:59] I didn't see that xD [20:17:37] aude: Still here? [20:24:19] yes [20:24:26] JohnLewis: [20:24:41] aude: https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-Preview.js&diff=132897859&oldid=118026450 - Is that alright? [20:24:54] checking [20:25:37] looks ok [20:25:55] I c&p'd what you put so, better be :p [20:26:00] we can wait for feedback on my other comments [20:26:10] it works for me [20:26:39] suppose we'll need to check the other gadgets to make sure they work with new jquery etc [20:30:00] looks like '.toggle' is deprecated (for one thing) [20:34:56] btw [20:35:02] benestar: need any help with badges? [20:40:22] bug! [20:40:33] http://nooooooooooooooo.com/ [20:40:51] aude: ^ [20:40:54] heh [20:40:55] benestar: need/want [20:41:12] just started editing an item and foudn a bug :( [20:41:13] lazowik: hi, sorry, was afk [20:41:27] yes, the ui on repo is a bit tricky [20:41:28] probably jquery problem [20:41:36] especially because we do not have any mockups yet [20:41:46] maybe I should ping Lydia_WMDE again for them... [20:41:52] hmm [20:42:04] but how can I help? [20:42:13] benestar: probably something henning is working on [20:42:19] idk [20:42:35] do that part? [20:42:41] aude: Henning is working on the mockups :) [20:42:54] ok, then we just have to wait a bit until he is ready [20:42:55] idk if it would be possible to work on one patch together :p [20:45:52] i'll work on the bug probably tomorrow [20:47:34] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "That was easy. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [20:54:16] another bug [20:54:58] and another bug [20:55:10] * aude will be working on javascripts [20:59:39] aude: wat? [20:59:43] 3 bugs? [20:59:50] where what? [21:11:31] 3 bugs, 1 feature request [21:11:47] all js-related things [21:11:58] jquery upgrade could be a reason [21:12:05] * aude off [21:33:25] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06claims-best at 14e293178: 02http://git.io/r48Oiw [21:33:29] Thiemo_WMDE: you merged it o_O [21:33:45] as i said. [21:33:47] Thiemo_WMDE: http://www.cedarcountyvet.com/uploads/1/8/9/6/18960869/3441522_orig.jpg [21:34:17] plus some new discussion items. [21:37:14] (03CR) 10Jeroen De Dauw: "Why is this in in Lib and not in Repo? Also, what is the interface intended for? I don't see any usage of it so far." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [21:37:59] JeroenDeDauw: read the commit message please. "Needed for things like bug 64515." [21:39:14] Thiemo_WMDE: I did [21:39:21] Thiemo_WMDE: that does not answe my question [21:39:41] JeroenDeDauw: I'm on a page [21:39:50] oh noez? [21:39:51] I need to get the canonical uri [21:39:55] JeroenDeDauw: :p [21:39:58] for entity [21:40:04] no no [21:40:05] and uris for entity data [21:40:15] I mean in which code will the interface be polymrophically used? [21:40:38] * lazowik googles the hard word [21:40:51] It's probably full of spelling errors :D [21:41:11] in some wikibase repo hook that hooks into the action=info "special" page. [21:41:13] lazowik: where will you type hint against this interface? [21:41:53] you mean it doesn't need to be an interface at all? maybe. [21:42:34] ah [21:43:52] hmm [21:44:00] The goal is a simple hook in Wikibase.hooks.php. This things really doesn't need an interface. It's all global anyway, right? [21:44:22] Thiemo_WMDE: not that simple [21:44:27] it'd have its own class [21:44:31] called from hook [21:44:35] sure. [21:44:50] why is EntityTitleLookup an interface? [21:45:10] "The mapping could be programmatic, or it could be based on database lookups." [21:45:12] this? [21:45:38] (because of this) [21:45:43] ? [21:46:25] if title lookup would be done by database lookups [21:46:33] that'd be in a different factory [21:46:43] hence it is an interface [21:46:45] right? [21:46:55] I'm not into these things yet [21:47:11] interface, factory etc. [21:47:20] i think i know what you mean. answer is yes then. [21:47:33] (03CR) 10Jeroen De Dauw: [C: 04-1] Introduce EntityIdLookup (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [21:47:37] these things confuse me too. ;) [21:47:51] lazowik: so why is this in lib? [21:48:21] JeroenDeDauw: well, I'm going around a bit blind here [21:48:26] not having knowledge [21:48:50] JeroenDeDauw: I followed Daniel's comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=65507 [21:48:52] lazowik: well, don't put stuff in lib unless you have very good reason to [21:48:55] This thing needs to die [21:49:09] Yeah, Daniel is quite happy putting more stuff in there [21:49:11] >_> [21:49:19] JeroenDeDauw: so a class in repo is the right thing? [21:49:51] JeroenDeDauw: you wanna kill lib? [21:49:56] lazowik: are you working on repo or client now? [21:50:05] Daniel said in the very begining "EntityPerPage should provide a function for looking up the ID for a given Title; and/or there should be an inverse of the EntityTitleLookup interface." [21:50:17] (03CR) 10Thiemo Mättig (WMDE): Introduce EntityIdLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [21:50:23] benestar: repo [21:50:34] lazowik: also with the hooks? [21:50:40] benestar: yep [21:50:43] because then I will start refactoring on client [21:50:44] :) [21:50:50] nah, I'm not refactoring now [21:50:54] adding new [21:50:57] * benestar and lazowik are a dreamteam \o/ [21:51:01] :p [21:51:11] ^^ [21:51:13] benestar: but ok, you can start on client [21:51:20] when I have this I'll start doing repo [21:51:20] benestar: yes [21:51:34] ok, it's also less work I think :P [21:51:54] lazowik: yes [21:51:59] JeroenDeDauw: and what about all the store interfaces and implementations? [21:52:40] benestar: dreamteam in troubling Lydia_WMDE team? :p [21:53:14] lol [21:53:16] yes :P [21:54:15] JeroenDeDauw: where should that class go? [21:55:02] and still as EntityIdLookup ? [21:55:53] lazowik JeroenDeDauw : is there already a bug for the hook refactoring? [21:56:10] I don't think so, haven't searched yet though [21:58:53] benestar: there are some very old silly interfaces I added in Wikibase.git [21:59:00] And people have added more silly ones since then [21:59:36] lazowik: so this code has two dependencies [21:59:41] 1. an EntityIdParser [21:59:47] I for one still don't know why repo client and lib are in one git repo [21:59:52] 2. a thing that can look up the NS for an entity type [22:00:18] yep [22:00:22] lazowik: because we did not think about having multiple repos when we started the project [22:00:34] The whole notion made quite some people upset when we did push it [22:00:55] lazowik: we do want to split this now [22:00:57] into multiple repos [22:01:01] mhm [22:01:05] Will take time [22:01:09] Lib is not easy to kill [22:01:14] Sort of the legacy code end boss [22:02:01] lazowik: here, you can help with killing lib ;p https://github.com/wmde/WikibaseDataModel/pull/98 [22:02:12] Thiemo_WMDE: grats on getting issue #100 ;p [22:02:31] JeroenDeDauw: is there other way than getNamespaceForType from EntityTitleLookup? [22:03:04] and getNamespaceForType is in a bad place… [22:03:17] maybe I'll fix that first? [22:05:20] lazowik: yes, fixing that would be great [22:05:30] yay [22:05:37] And then you can have the new object as dependency for the one you are creating afterwards [22:05:41] * lazowik feels like being in recurency [22:05:46] JeroenDeDauw: mhm [22:06:11] JeroenDeDauw: make a bug for that? [22:06:31] and abandon https://gerrit.wikimedia.org/r/#/c/134727 ? [22:06:41] lazowik: your call [22:06:42] I think it's too messy already [22:06:47] lazowik: I'd just do the stuff [22:06:59] mhm [22:11:19] JeroenDeDauw: can this go into NamespaceUtils ? [22:12:12] oh, wait, that's not so easy [22:13:20] Lydia_WMDE: sooo, you gave me small and easy bug? :p [22:14:17] now I'm in a recursion of bad/missing things [22:15:10] lazowik_: :D i'm sorry [22:15:11] lazowik_: see bug 65700 and 65701 [22:16:13] * lazowik_ sees [22:18:32] lazowik_: not namespace utils no [22:18:36] lazowik_: that class should also die [22:18:59] JeroenDeDauw: shall I try that also? :p [22:19:05] lazowik_: feel free [22:19:31] not sure if I'd be able to [22:19:40] Meh, why are people not fixing this stuff :@ [22:21:09] JeroenDeDauw: reading clean code before all that will help me? [22:28:59] lazowik_: ofc it will [22:31:01] ok [22:31:10] 'night!