[03:03:39] (03Draft1) 10Aude: Add inner snak value valueview div in non-JS html [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 [03:09:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 (owner: 10Aude) [05:20:32] http://magnusmanske.de/wordpress/?p=203 THIS IS AWESOME [05:24:28] haha, that is awesome [05:31:28] GerardM-, yeah, great! [05:45:33] GerardM-, stats do not load though [05:45:44] yannf [05:45:51] I send a mail to Magnus [05:46:02] I already noticed [05:50:28] he nearly got wrong for a Hungarian football player [05:51:03] then I checked hu.wp, and there is a picture [06:48:32] (03CR) 10Adrian Lang: Introducing MonolingualTextParser (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133108 (https://bugzilla.wikimedia.org/64291) (owner: 10Daniel Kinzler) [06:48:54] (03CR) 10Adrian Lang: "The DataValue's type is written without a dash, the DataType with a dash. I don't know why it is like that. My comment in I07d2e56d2f6dfc0" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134332 (owner: 10Adrian Lang) [06:58:14] (03CR) 10Adrian Lang: [C: 04-2] "I'm strictly against this change. Using the ValueView is an implementation detail. If we actually need this, I would prefer to have a wb-p" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 (owner: 10Aude) [07:51:41] (03PS1) 10Adrian Lang: Fix monolingual-text parser registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134570 [07:52:45] (03PS1) 10Adrian Lang: Get DataTypeFactory from Wikibase{Client,Repo} directly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134571 [07:53:23] (03PS1) 10Adrian Lang: Move DataTypeBuilder test for quantity out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134572 [07:55:07] (03PS1) 10Adrian Lang: Fix MonolingualText DataType building and add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 [07:59:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134570 (owner: 10Adrian Lang) [08:06:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134571 (owner: 10Adrian Lang) [08:09:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134572 (owner: 10Adrian Lang) [08:12:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [08:27:07] yannf the statistics now work [08:27:18] thanks [08:36:47] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "Uh. I'm afraid Adrian is right. :-( Sorry. Gadgets just shouldn't depend on this. Do you have an example of a gadget that does this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 (owner: 10Aude) [09:11:10] (03CR) 10Daniel Kinzler: [C: 032] Move DataTypeBuilder test for quantity out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134572 (owner: 10Adrian Lang) [09:11:32] (03Merged) 10jenkins-bot: Move DataTypeBuilder test for quantity out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134572 (owner: 10Adrian Lang) [09:11:48] (03CR) 10Daniel Kinzler: [C: 032] Fix MonolingualText DataType building and add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [09:11:58] (03CR) 10jenkins-bot: [V: 04-1] Fix MonolingualText DataType building and add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [09:14:46] [13DataTypes] 15adrianlang created 06renameTextTypes (+1 new commit): 02http://git.io/LkgxwQ [09:14:46] 13DataTypes/06renameTextTypes 146942541 15Adrian Lang: Make DataType consistent with DataValue's type for texts [09:14:53] (03Abandoned) 10Daniel Kinzler: Fix type name of DataValue in MonolingualTextDataType building [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134332 (owner: 10Adrian Lang) [09:16:04] (03CR) 10Daniel Kinzler: [C: 032] Get DataTypeFactory from Wikibase{Client,Repo} directly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134571 (owner: 10Adrian Lang) [09:16:07] (03PS1) 10Thiemo Mättig (WMDE): [DNM] Documentation for Data Type to Data Value Type mapping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134579 [09:16:28] (03Merged) 10jenkins-bot: Get DataTypeFactory from Wikibase{Client,Repo} directly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134571 (owner: 10Adrian Lang) [09:16:36] [13DataTypes] 15adrianlang opened pull request #17: Make DataType consistent with DataValue's type for texts (06master...06renameTextTypes) 02http://git.io/L0pI6w [09:17:01] [travis-ci] wmde/DataTypes/renameTextTypes/6942541 : Adrian Lang The build passed. http://travis-ci.org/wmde/DataTypes/builds/25677043 [09:18:07] (03CR) 10Daniel Kinzler: [C: 032] Fix monolingual-text parser registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134570 (owner: 10Adrian Lang) [09:18:25] (03Merged) 10jenkins-bot: Fix monolingual-text parser registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134570 (owner: 10Adrian Lang) [09:22:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134579 (owner: 10Thiemo Mättig (WMDE)) [09:30:51] (03PS1) 10Adrian Lang: Adapt to changes in DataTypes 0.3 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 [09:31:04] (03CR) 10Adrian Lang: [C: 04-1] "Needs https://github.com/wmde/DataTypes/pull/17" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 (owner: 10Adrian Lang) [09:33:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 (owner: 10Adrian Lang) [09:36:38] (03PS2) 10Adrian Lang: Fix MonolingualText DataType building and add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 [09:38:01] I somehow lost my mach_kernel on os x… [09:38:04] backups ftw! [09:38:51] (03CR) 10Adrian Lang: "Shouldn't go in before Ie0b40e317202e19f7f9941fc4d2b09452c5257bf because I already used the dash-free DataType name." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [09:39:36] [13DataTypes] 15brightbyte closed pull request #17: Make DataType consistent with DataValue's type for texts (06master...06renameTextTypes) 02http://git.io/L0pI6w [09:41:19] [13DataTypes] 15brightbyte 04deleted 06renameTextTypes at 146942541: 02http://git.io/n0-6rw [09:42:03] [13DataTypes] 15adrianlang tagged 060.3 at 06master: 02http://git.io/ASL4vQ [09:42:07] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [09:42:09] (03CR) 10Daniel Kinzler: [C: 031] "ready to be merged as soon as DataTypes 0.3 is out" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 (owner: 10Adrian Lang) [09:44:33] [travis-ci] wmde/DataTypes/0.3/040ed6d : Daniel Kinzler The build passed. http://travis-ci.org/wmde/DataTypes/builds/25678618 [09:47:21] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 (owner: 10Adrian Lang) [09:48:03] (03CR) 10Daniel Kinzler: [C: 032] ChangeOps performance and style clean-up [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133068 (owner: 10Thiemo Mättig (WMDE)) [09:48:23] (03Merged) 10jenkins-bot: ChangeOps performance and style clean-up [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133068 (owner: 10Thiemo Mättig (WMDE)) [10:00:25] (03PS1) 10WikidataBuilder: New Wikidata Build - 21/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/134586 [10:07:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/134586 (owner: 10WikidataBuilder) [10:09:50] GerardM-, https://www.wikidata.org/wiki/Q16012008 [10:10:34] yeah [10:10:42] I "fixed it" [10:11:30] they are both notable and deserve their own item [10:11:38] Wikipedia can be stupid like this [10:11:45] (it is allowed to) [10:18:08] yannf in this item they are a "group of humans" it consists of their item [10:18:20] on their item they are spouse [10:18:27] ok [10:19:12] he have 2 cases of French writers (brothers) who have a common article [10:19:27] do a similar thing [10:25:06] yeah, i did [10:26:12] the merge game is pretty difficult compare with the other 2 [10:31:24] :) [10:32:01] the problem is that it has probably some 20% of all items as a target [10:33:02] (based on a paper about pt en missing links) [10:37:54] mpfh [10:38:18] ah, nvm [10:39:37] I almost how to run phpunit for Wikibase :p [10:53:16] lazowik what does that imply ? [10:56:31] GerardM-: after that mpfh I was going to ask Jeroen how to do that [10:57:20] but then I remembered [10:59:48] it seems find but I get no clue [10:59:52] fine [11:01:49] GerardM-: that's coding stuff [11:05:13] (03PS2) 10Thiemo Mättig (WMDE): [DNM] Documentation for Data Type to Data Value Type mapping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134579 [11:05:35] (03PS2) 10Adrian Lang: Adapt to changes in DataTypes 0.3 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 [11:12:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134579 (owner: 10Thiemo Mättig (WMDE)) [11:16:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 (owner: 10Adrian Lang) [11:16:32] [13DataTypes] 15thiemowmde created 06wgDataTypes (+1 new commit): 02http://git.io/FDE7QQ [11:16:32] 13DataTypes/06wgDataTypes 14e3ae801 15Thiemo Mättig: Remove unused wgDataTypes... [11:17:22] [13DataTypes] 15thiemowmde opened pull request #18: Remove unused wgDataTypes (06master...06wgDataTypes) 02http://git.io/i_1CFw [11:18:43] [travis-ci] wmde/DataTypes/wgDataTypes/e3ae801 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/DataTypes/builds/25684822 [11:20:42] [13DataTypes] 15thiemowmde 04force-pushed 06wgDataTypes from 14e3ae801 to 149dd1189: 02http://git.io/a8zzRQ [11:20:42] 13DataTypes/06wgDataTypes 149dd1189 15Thiemo Mättig: Remove unused wgDataTypes... [11:23:00] (03CR) 10Daniel Kinzler: [C: 032] Adapt to changes in DataTypes 0.3 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 (owner: 10Adrian Lang) [11:23:27] (03Merged) 10jenkins-bot: Adapt to changes in DataTypes 0.3 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134584 (owner: 10Adrian Lang) [11:26:23] [13DataTypes] 15thiemowmde 04force-pushed 06wgDataTypes from 149dd1189 to 14c073f16: 02http://git.io/a8zzRQ [11:26:23] 13DataTypes/06wgDataTypes 14c073f16 15Thiemo Mättig: Remove unused wgDataTypes... [11:27:31] (03PS3) 10Adrian Lang: Fix MonolingualText DataType building and add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 [11:33:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [11:33:38] ^^ DanielK_WMDE [11:43:16] (03CR) 10Daniel Kinzler: [C: 04-1] "performance issue in hook handler" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [12:05:01] (03PS4) 10Daniel Kinzler: Introducing EntityContentCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [12:07:16] (03PS5) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [12:12:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [12:16:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [12:24:01] (03CR) 10Aude: "@adrian would you be ok if we got rid of the valueview div then? not sure how easy that is?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 (owner: 10Aude) [12:24:36] Adrian_WMDE: ping [12:26:52] mh [12:27:11] jQuery UI widgets always net a DOM element to be initialized on [12:28:41] *need [12:28:53] how do we make non-js and js consistent here? [12:29:32] people want to extract the formatted value and are using .valueview [12:30:23] As I wrote: Adding a wikibase-specific class around the actual formatted value [12:30:27] can it initialize on .wb-snak-value? [12:30:41] Maybe even dropping the valueview class altogether. We don't actually need that anywhere. [12:30:54] ok, and then value view can use that instead of it adding an additional div [12:31:18] Use what? [12:31:43] use the wikibase specific div? [12:32:08] I didn't write wikibase-specific div [12:32:13] I meant wikibase-specific className [12:32:29] ok [12:33:01] wb-snak-value is owned by the snakview variation if I understand that DOM correctly [12:33:47] yes [12:35:44] making yet another div inside wb-snak-value then valueview making yet another is not the answer [12:35:57] if if can reuse one [12:39:34] (03PS2) 10Aude: Add inner snak value valueview div in non-JS html [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 [12:40:01] (03CR) 10Aude: "only want this if valueview can reuse this instead of add yet another div" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 (owner: 10Aude) [12:42:55] (03PS3) 10Aude: Add inner snak value valueview div in non-JS html [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 [12:45:16] Adrian_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=65580 [12:45:37] * aude back later [12:46:00] Adrian_WMDE: Thiemo_WMDE: DanielK_WMDE: Somewhat silly you already tagged 0.3, could have waited for https://github.com/wmde/DataTypes/pulls to be merged as well [12:46:40] Also, the version that will show up on Special:Version is wrong [12:46:41] https://github.com/wmde/DataTypes/blob/master/DataTypes.php [12:47:11] [13DataTypes] 15JeroenDeDauw closed pull request #18: Remove unused wgDataTypes (06master...06wgDataTypes) 02http://git.io/i_1CFw [12:47:15] JeroenDeDauw: is new ItemId( 'Q1337' ) ok? [12:47:23] or is that bad cause of "Q" ? [12:47:26] lazowik: that is how to do it [12:47:29] ko [12:47:31] *ok [12:47:42] lazowik: the Q is perfectly fine, that is what item ids look like [12:47:45] JeroenDeDauw: That came after the release [12:48:02] JeroenDeDauw: I indeed messed up the version number, though :/ [12:48:04] Well, still some fail in communication ;p [12:48:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 (owner: 10Aude) [12:48:17] I'll submit a PR to fix the verison now [12:48:31] JeroenDeDauw: Thanks [12:51:28] Adrian_WMDE: Thiemo_WMDE ^ [12:51:31] [13DataTypes] 15JeroenDeDauw created 06u (+1 new commit): 02http://git.io/1x39bA [12:51:31] 13DataTypes/06u 1436ff588 15jeroendedauw: Update version number and release notes [12:51:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134549 (owner: 10Aude) [12:53:33] DanielK_WMDE: should I check against namespaces? [12:53:47] i.e. what to do if I get Property:Q42 [12:53:56] [travis-ci] wmde/DataTypes/u/36ff588 : jeroendedauw The build passed. http://travis-ci.org/wmde/DataTypes/builds/25691241 [12:53:56] or P12 in main namespace [12:56:12] (03PS1) 10Jeroen De Dauw: Run tests against MW 1.23 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134597 [12:58:19] [travis-ci] wmde/WikibaseQueryEngine/stringhasher/566bc60 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25691266 [13:01:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134597 (owner: 10Jeroen De Dauw) [13:02:15] [13DataTypes] 15thiemowmde comment on pull request #19 1436ff588: Can't we just squeeze this in 0.3 below? It's just a few minutes between the two. 02http://git.io/_c9vkA [13:08:11] [13DataTypes] 15JeroenDeDauw comment on pull request #19 1436ff588: The tag has already been created, and one cannot un-create a tag. Which is why I complained about this on IRC. Care should be taken with creating tags. 02http://git.io/pYXzPw [13:11:50] [13DataTypes] 15thiemowmde 04deleted 06u at 1436ff588: 02http://git.io/k40jXw [13:15:43] (03PS7) 10Daniel Kinzler: Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) [13:15:57] (03CR) 10jenkins-bot: [V: 04-1] Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [13:17:14] [13ValueView] 15adrianlang 04force-pushed 06refactorExperts from 142c69180 to 1451f76e0: 02http://git.io/XLBMGw [13:17:14] 13ValueView/06refactorExperts 1451f76e0 15Adrian Lang: Factor inputextender and content out of time and globecoordinate experts... [13:17:51] (03PS8) 10Daniel Kinzler: Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) [13:18:49] (03CR) 10jenkins-bot: [V: 04-1] Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [13:20:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [13:22:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [13:29:14] (03CR) 10Tobias Gritschacher: [C: 04-1] Handle DVs that mismatch a prop's expected type (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [13:30:51] (03CR) 10Aude: [C: 032] Run tests against MW 1.23 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134597 (owner: 10Jeroen De Dauw) [13:31:14] (03Merged) 10jenkins-bot: Run tests against MW 1.23 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134597 (owner: 10Jeroen De Dauw) [13:42:05] (03PS9) 10Daniel Kinzler: Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) [13:42:47] (03CR) 10Daniel Kinzler: [C: 032] Fix MonolingualText DataType building and add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [13:43:06] (03Merged) 10jenkins-bot: Fix MonolingualText DataType building and add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134573 (owner: 10Adrian Lang) [13:46:28] (03CR) 10Aude: [C: 04-1] "i assume this is because of the patch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [13:46:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [13:53:17] (03PS3) 10Thiemo Mättig (WMDE): Documentation for Data Type to Data Value Type mapping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134579 [13:58:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134579 (owner: 10Thiemo Mättig (WMDE)) [14:22:54] Has everybody tried the Wikidata-game? http://tools.wmflabs.org/wikidata-game/ [14:32:27] Josve05a: Nice! [14:47:36] DanielK_WMDE: poke [14:48:23] aude: hey [14:48:39] can i up load new patch of property value snak formatter [14:48:42] that fixes the fatal [14:48:52] would be nice to be able to review [14:48:54] (03PS10) 10Daniel Kinzler: Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) [14:48:58] ok [14:48:59] :) [14:49:03] :P [14:49:08] sorry fro that one [14:49:13] it happens [14:49:25] it's getting closer [14:54:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [15:18:11] (03PS1) 10Daniel Kinzler: Remove the empty ItemContentDiffView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134613 [15:21:59] Josve05a: nice game :) [15:23:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134613 (owner: 10Daniel Kinzler) [15:25:15] (03CR) 10Hoo man: [C: 032] Remove the empty ItemContentDiffView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134613 (owner: 10Daniel Kinzler) [15:25:59] [13Time] 15thiemowmde created 06calculator (+1 new commit): 02http://git.io/6Z6SoQ [15:25:59] 13Time/06calculator 1434e5417 15Thiemo Mättig: [WIP] Add TimeValueCalculator [15:26:33] [13Time] 15thiemowmde opened pull request #18: [WIP] Add TimeValueCalculator (06master...06calculator) 02http://git.io/Wdi67A [15:27:00] [13Time] 15thiemowmde comment on pull request #18 1434e5417: @JeroenDeDauw Is the directory and namespace ok? 02http://git.io/NB2eCA [15:28:34] (03Merged) 10jenkins-bot: Remove the empty ItemContentDiffView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134613 (owner: 10Daniel Kinzler) [15:35:08] (03PS10) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) [15:40:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (https://bugzilla.wikimedia.org/60717) (owner: 10Bene) [15:56:01] (03CR) 10Aude: "generally looks good now and something we can work with. (although PropertyValueSnakFormatter is getting complex)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [15:56:32] hoo: around? [15:56:39] yes [15:57:45] would you look at https://gerrit.wikimedia.org/r/#/c/133286/ [15:57:53] is that ok for lua? [15:59:14] aude: if we used Status object, we could have an intnerformater that would just add warnings to the status object, and an outer formatter that would throw exceptions or attach warnings, as needed [15:59:40] too complex in my opinion [15:59:49] but maybe it would be good for lua [16:00:15] aude: well, it reduces the code complexity of each class. usign the decorator pattern to get rid of options is a standard approach. [16:00:24] but for now, we can just keep the option [16:00:41] for snak view, we can just apply some css [16:04:24] aude: i think that'S what we want for lua, yes. [16:04:28] how do we go on? [16:09:39] DanielK_WMDE: if you can really use Status to make it less complex and do what we want, then suppose ok [16:14:34] aude: it [16:14:53] it's just an idea. i'd prefer to just go with the code as I submitted it for now [16:15:09] are there any issues left to address? [16:15:09] i defer to hoo regarding lua [16:15:16] right [16:15:30] if it's acceptable as a formatted value, then ok [16:15:37] if we want to use an option there, ok [16:16:08] aude: Will probably have to test that per hand... [16:16:55] for parser function, i get "

The value is invalid and cannot be displayed. is the location. [16:16:55]

" [16:17:04] that's bad [16:17:06] all mixed together, no indication it's an error (with current code) [16:17:09] it should either work in some way [16:17:18] with daniel's patch, it will get class='error' [16:17:20] or have the error class on it so that iferror can detect [16:17:23] I see [16:17:43] so it will display something with css or with #iferror, then whatever the template specified [16:17:46] s* [16:18:17] lua would work same way with formatPropertyValues [16:18:22] mh... might be worht adding intergration tests for Lua/ ParserFunctions? [16:19:04] yes :) [16:19:12] * aude doesn't object to more tests [16:21:10] DanielK_WMDE: if undeserializable value had formatters for each type that used appropriate code, we might be able to move code out of propertyvaluesnak formatter [16:21:46] seems less than ideal workaround for the fact that UnDeserializableValueFormatter does just one format [16:22:01] the way you work around it in the patch [16:22:51] aude: UnDeserializableValueFormatter is for the case where the value itself is corrupt and cannot be deserialize. it doesn't really have a type, and there is no way to show it. [16:23:16] or do you mean UnDeserializableValueFormatter should have different output modes for the different output formats? could do, but that would have been a lot more pain. [16:25:44] might be less hacky [16:46:47] aude: is the current code good enough for a +1? would it be ok for hoo to give +2 if it works fine with Lua? [17:03:09] DanielK_WMDE: can't +1 because of lua [17:04:13] also not great to leave inconsistency in formatting of 'bad' values but that can be done in follow up [17:11:04] aude: i don't see a big problem there. We should check where we are still using the UnDeserializableValueFormatter at all. In diffs, I guess [17:11:19] then remove it [17:40:21] (03CR) 10Aude: [C: 04-1] "nitpicks" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [18:01:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf6/64463f5 : daniel The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25709191 [18:11:38] (03CR) 10Aude: "ok with some cleanup in followup" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [18:17:20] aude: Shall I try to do Lua integration tests in a follow up dependent change? [18:20:24] sure [18:21:06] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=65527 can you remember where we took these pencil icons from? [18:21:18] Weren't they originally svg or am I mixing up stuff? [18:24:08] from something jorm made in a design proposal or audit or somthing [18:24:24] must be derived from same source as https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Agora_icon_set [18:24:35] only that one is black [18:26:10] aude: mh... can't find the svg belonging to it [18:26:24] if I could, it would be as easy as replacing colors in it [18:26:39] like via a text edits... svg :) [18:26:43] * editor [18:27:56] i can't find the page on mediawiki [18:28:22] there is/was a page that had proposed designs [18:28:22] https://www.mediawiki.org/wiki/File:Edit_icon.svg [18:28:28] that's a slightly different one [18:28:32] can't find the original now [18:28:41] yeah slightly different [18:28:46] * aude looking [18:32:37] there also is https://github.com/wikimedia/mediawiki-extensions-Interlanguage/tree/master/modules [18:32:57] but think those still came from something jorm proposed [18:33:06] those are not useful [18:34:32] mh, that's bad [18:34:51] we could use another one from commons which is freely licensed and looks similar [18:34:55] gah https://www.mediawiki.org/wiki/Extension:Interlanguage/WMF_Design_Pass [18:35:02] Lydia_WMDE would have to sign of, of course [18:35:30] it would be fairly easy to make svg version or use similar is ok too [18:36:03] I could make svg versions of course... would take me a bit in inkscape, though (aven't done taht in a while) [18:37:32] or maybe jorm has the original? [18:37:56] We could drop him an email? [18:38:14] sure [18:38:46] pencil is one of the first things we did at the beginning [18:38:49] sooooo long ago [18:39:02] It was there before I was AFAIR :P [18:39:13] in Interlanguage [18:40:10] according to git log Nikola actually added them first [18:40:54] 1c52ebc90a896f729797e1eb7dbca5fe809b07a0 [18:40:58] could be [18:41:03] gerrit can't find that revision?! [18:41:07] svn? [18:41:17] Date: Tue May 1 06:26:51 2012 +0200 [18:41:23] no, we were on git back then [18:41:26] at least core was [18:51:55] (03PS1) 10Aude: Add css styles for wb-format-error for snak error display [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134663 [18:52:24] maybe he started the extension on github or something? [18:52:37] oh right [18:52:38] no [18:52:47] they were seperate repos first, right? [18:52:52] * separate [18:52:53] maybe [18:55:15] really... alt text as title is so 2003 :P [18:55:24] (on some random website) [18:57:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134663 (owner: 10Aude) [19:08:29] (03PS3) 10Aude: Cleanup in PropertyValueSnakFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 [19:09:38] I'm writing a function that returns EntityId for given Title [19:09:57] what exception should it throw when provided Title is not a Title of Entity? [19:10:11] can i leave Wikibase\DataModel\Entity\EntityIdParsingException [19:10:21] or should I catch that and throw InvalidArgument? [19:10:26] aude: ^ ? [19:10:59] back in ~20 mins [19:11:24] not EntityIdParsingException in my opinion [19:12:18] maybe a question for daniel [19:14:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134659 (owner: 10Aude) [19:34:00] aude: yeah, Daniel… [19:36:56] JeroenDeDauw: maybe you know? [19:37:11] ^ up up up [19:51:06] ouf.... redémarrage après plantage à répétition... j'espère que je vais pouvoir travailler maintenant… ça ramait terriblement… [19:51:16] oups, wrong channel - sorry :s [20:12:11] Lydia_WMDE: "Wikidata the Game" huh? [20:12:59] hoo: http://tools.wmflabs.org/wikidata-game/ [20:13:07] see also contact the dev team page [20:16:52] Lydia_WMDE: that looks addicting... must not get distracted (now) [20:16:58] :D [20:16:59] yes [20:17:01] it is [20:21:20] Lydia_WMDE: https://www.wikidata.org/w/index.php?diff=132046564&oldid=132043238&rcid=132441745 ... [20:21:23] when com ereirects? [20:21:29] *come [20:21:34] *redirects [20:22:01] benestar: daniel is working on them atm. i think they'll need another sprint or maybe two [20:22:20] Lydia_WMDE: maybe I can help anyhow? [20:22:33] I will have more time the next few months [20:22:44] hopefully... ;) [20:23:03] benestar: *nod* cool! I think we should get badges finished first [20:23:13] hehe, yes [20:23:14] but i will ask daniel if there is anything that can be split up sensibly [20:23:20] (03CR) 10Thiemo Mättig (WMDE): "Under what circumstances does this happen? Is there a bug reported?" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134392 (owner: 10Hoo man) [20:23:28] Lydia_WMDE: do you have mockups for the badges ui already? [20:24:10] henning is working on general mockups atm [20:24:13] they include badges [20:25:13] ok, nice [20:25:24] Lydia_WMDE: does it make sense to investigate into badges before the ui redesign? [20:26:32] (03CR) 10Hoo man: "@Thiemo: This can be seen if you run mw.hook( 'wikibase.domready' ).fire() on Wikidata." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134392 (owner: 10Hoo man) [20:26:33] benestar: what's left from your side? i am not up-to-date :( [20:27:09] Lydia_WMDE: one patch for the client [20:27:14] imho UI should be high priority for the dev team - but if badges haven't got much to go, I guess :p [say the guy who is not associated with anything :p] [20:27:35] which now also Thiemo_WMDE likes it hopefully [20:28:00] JohnLewis: ;-) [20:28:15] benestar: ok cool [20:28:32] Lydia_WMDE: and I played a bit with the ui and there are two patches with DNM on gerrit [20:28:39] but they perhaps do not make much sense... [20:28:43] ah nice [20:29:08] is this something Thiemo_WMDE can show me tomorrow? [20:29:17] or nothing to look at yet? [20:30:56] Lydia_WMDE: what do you mean? [20:31:01] the client thing? [20:31:48] no on the repo [20:31:59] Lydia_WMDE: no, it does not work yet [20:32:05] ok [20:32:07] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134719 (owner: 10L10n-bot) [20:33:09] benestar: another thing people have been asking for is a new datatype for mathml [20:33:16] i have not talked this through with daniel yet though [20:33:20] mathml? [20:33:32] markup for math that's used on wikipedia [20:33:38] formulas and stuff [20:33:45] ah, I see [20:34:01] in case that's something you'd be interested in [20:34:40] sounds interesting :) [20:35:21] let me get the bug - sec [20:35:50] just add me to CC [20:36:05] k [20:39:40] (03PS1) 10Michał Łazowik: Add getting entity id from page title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) [20:39:43] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Hm. I think this is poking the wrong code. It seems the problem is somewhere else." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134392 (owner: 10Hoo man) [20:40:03] \o/ first patch in looong time [20:40:57] (03CR) 10Michał Łazowik: Add getting entity id from page title (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [20:41:19] Thiemo_WMDE: ^ here you go :) [20:41:52] hey DanielK_WMDE [20:42:17] https://gerrit.wikimedia.org/r/#/c/134727/ [20:42:28] yay lazowik :D [20:42:32] DanielK_WMDE: I wasn't sure what exception to throw if title is not title of entity [20:42:37] so I went with InvalidArgument [20:42:41] Lydia_WMDE: :) [20:44:26] Lydia_WMDE: how is wikidata represented in the database [20:44:33] e.g. https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2Ftables.sql [20:45:10] I want to look for all items containing only one sitelink [20:45:11] Withoutaname: what exactly do you mean? [20:45:19] ah [20:45:27] then you want the page props table iirc [20:45:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [20:47:05] Withoutaname: https://tools.wmflabs.org/bene/lonelyitems/ [20:48:41] Lydia_WMDE: do you know how to make the interwiki links visible in the left toolbar? [20:48:49] it does not work on my local mediawiki installation [20:49:43] benestar: uff no sorry [20:49:51] maybe a cinfig missing? [20:49:52] do you know who knows it? [20:49:53] *config [20:49:58] aude would know [20:49:59] or hoo [20:50:01] yes, I think so [20:50:32] benestar: what's the name of the wikidata database? [20:50:41] wikidata_p? [20:50:48] Withoutaname: wikidatawiki [20:51:07] benestar: I know :) [20:51:13] it isn't documented [20:51:20] _at all_ [20:51:33] benestar: the best thing is to look at actual wmf setup [20:51:56] benestar: though I haven't set up dispatching [20:52:06] so I have to purge manually [20:53:06] benestar: https://github.com/wikimedia/operations-mediawiki-config/blob/6315d5e303ee813c895faa77d77a6b081e9f4f1e/wmf-config/Wikibase.php [20:53:38] lazowik: it isn't a Wikibase config [20:53:40] because Wikibase also only makes use of the [[en:Foo bar]] syntax [20:53:54] SELECT page_title FROM page WHERE page_latest=0; [20:54:13] benestar: but you want interwiki links from wikitext to show up? [20:54:20] or what? [20:54:32] I thought you meant on local client from local repo [20:54:41] ERROR 1142 (42000): SELECT command denied to user u'4607' for table 'page' [20:54:45] ^ hoo [20:55:01] lazowik: yes, but Wikibase kinda inserts interwikilinks from wikitext [20:55:06] that's somehow weird [20:55:25] benestar: so you have things like $wgWBRepoSettings['changesDatabase'] [20:55:35] or $wgWBRepoSettings['localClientDatabases'] [20:55:40] s/or/and [20:56:21] benestar: that's my config: http://wklej.org/id/1368865/ [20:56:24] Withoutaname: huh? [20:56:28] tool labs? [20:57:27] yeah [20:57:34] oh nvm I restarted connection and it works now [20:59:18] lazowik: it works now \o/ [20:59:26] :) [20:59:27] just needed to fill the interwiki table [20:59:44] mhm [21:00:19] for further reference: https://www.mediawiki.org/wiki/Manual:Guide_to_setting_up_interwiki_linking#Maintenance_script [21:03:22] aude: Around? [21:15:46] hoo: ? [21:16:37] aude: Lydia wanted us to consider a backport.... but that's not really bearable [21:16:43] will wait for the normal train on Tuesday [21:17:17] for what? [21:17:23] * aude reluctant [21:17:32] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=65215 [21:17:40] don't waste your time on it :P I already did [21:18:28] we can wait [21:18:54] yep, changes are to big to backport [21:19:03] even though the bug has high impact [21:22:08] speaking of which, i need to make the new build [21:23:24] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Good idea. I like simple solutions. But I'm afraid it's a bit to simple at the moment." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik) [21:25:44] Thiemo_WMDE: I asked DanielK_WMDE if I should do this [21:25:48] so go argue with him :p [21:26:40] hoo: a special reason you are switching the duplicate flags on the two bugs around? [21:26:41] https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FWikidata.git/510ff273a87a5b80b6ff4d989746968a5bea70e4 [21:26:57] diff of everything changed vs. currently deployed branch [21:27:21] Thiemo_WMDE: Yes, the non-duplicate one has the changes linked [21:27:33] lazowik: a simple fix for my problem is to check the namespaces first. [21:27:46] Thiemo_WMDE: yeah, I know [21:27:46] I asked about that alo [21:27:49] *also [21:27:53] (asked Daniel) [21:27:58] didn't get anwser [21:28:13] I'll add that [21:28:25] Thiemo_WMDE: and not first [21:28:28] after actually [21:28:43] to exclude things like Property:Q13 [21:28:56] oh, this is not possible probably… [21:29:12] Thiemo_WMDE: and what exception to use? [21:31:07] (03PS1) 10Aude: add .gitreview (to trigger jenkins) [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/134735 [21:32:11] aude: Wont that file disappear again soonish? [21:32:22] Like all the other files which someone added manually at some point [21:32:35] lazowik: UnexpectedValueException may be a bit better, but I'm not sure. [21:33:08] Thiemo_WMDE: http://stackoverflow.com/questions/12483667/invalidargumentexception-vs-unexpectedvalueexception [21:33:25] "From this, we can conclude that InvalidArgumentException is intended for values passed to a function via arguments, while UnexpectedValueException is intended for values that arise during the internal computations of a function." [21:33:28] found that earlier today :) [21:33:34] hoo: doesn't matter [21:33:36] ah [21:33:49] found & misread :p [21:33:55] that'd be it probably [21:33:55] i'll just want to see jenkins pass, then merge, and then selenium tests run [21:34:32] or not [21:34:34] idk [21:35:22] lazowik: you can also keep the exception. doesn't really matter. ;) [21:35:54] lazowik: adding tests for User:Q1 as well as Property:Q1 is more important. [21:36:02] yep [21:37:29] Magnus Manske/missing props.js seems to be broken... I've got a nice pyramid of tables here. :) [21:37:40] https://www.dropbox.com/s/r80h802hys8397e/Screenshot%202014-05-21%2023.37.39.png [21:38:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/134735 (owner: 10Aude) [21:39:11] (03PS2) 10Aude: add .gitreview [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/134735 [21:39:18] (03CR) 10Aude: [C: 032] add .gitreview [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/134735 (owner: 10Aude) [21:45:02] (03Merged) 10jenkins-bot: add .gitreview [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/134735 (owner: 10Aude) [21:46:43] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/134735 (owner: 10Aude) [21:49:56] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Some ideas, possible problems and things to discuss." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [21:50:29] (03CR) 10Aude: Refactoring ItemDisambiguation logic. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131964 (owner: 10Daniel Kinzler) [22:00:26] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See comments." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 (owner: 10Daniel Kinzler) [22:04:53] (03CR) 10Daniel Kinzler: Minimize usage of EntityContent / ECFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 (owner: 10Daniel Kinzler) [22:09:45] how are sitelinks stored in wikidata's schema [22:10:39] Thiemo_WMDE: per http://stackoverflow.com/questions/1102979/when-would-you-throw-a-domainexception-in-php InvalidArgument seems right [22:11:14] benestar can you show the source code for your tool? [22:17:09] how do I use pywikibot or the API to get a list of all items containing only one sitelink to commons [22:42:55] (03PS2) 10Michał Łazowik: Add getting entity id from page title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) [22:46:00] Thiemo_WMDE: ^ added [22:46:26] but maybe DanielK_WMDE_ will know what exception to use [22:48:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134727 (https://bugzilla.wikimedia.org/65507) (owner: 10Michał Łazowik)