[02:34:44] (03CR) 10Legoktm: [C: 04-1] "Sorry, why does this need its own API module? If it's just a configuration setting, it should be in meta=siteinfo." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (https://bugzilla.wikimedia.org/63486) (owner: 10Bene) [07:58:09] Does anyone know how I can fix this error? Error while "Moving site links...": failed-save, Must be no more than {{PLURAL:250|one character|250 characters}} long [08:02:26] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133940 (owner: 10Danmichaelo) [08:02:37] (03PS2) 10Tobias Gritschacher: Update API doc: replace deprecated language code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133940 (owner: 10Danmichaelo) [08:03:56] Jurgen: where it's happening? [08:04:25] https://www.wikidata.org/wiki/Q7314727 [08:04:30] I try to merge with Q6046445 [08:05:26] You get the error message because the Turkish description is too long at https://www.wikidata.org/wiki/Q6046445 [08:05:51] it should be shortened [08:06:17] Ah I see [08:08:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133940 (owner: 10Danmichaelo) [09:48:09] DanielK_WMDE: hey [09:48:19] are you on the way? [09:48:35] The Way To Wikidata (TM) [09:48:55] DanielK_WMDE: or hangouts? [09:52:25] Tobi_WMDE: sorry, at the train station [09:52:50] Tobi_WMDE: got a sctrewed up connection and now have to wait for an hour. will be at the office around 13:30 [10:21:00] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I may be wrong but it looks like the class is on the wrong element now. It should be on the inner div but is on the outer. Is this intende" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134104 (https://bugzilla.wikimedia.org/65492) (owner: 10Aude) [10:23:21] Thiemo_WMDE: merge https://github.com/wmde/WikibaseDataModel/pull/86 ? [10:28:43] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Aude, you are right, but that's not part of this patch. Let's Bene fix this in an other patch, ok?" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134260 (https://bugzilla.wikimedia.org/63036) (owner: 10Bene) [11:05:02] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06claimlist: 02http://git.io/QlCciQ [11:05:02] 13WikibaseDataModel/06claimlist 14628f427 15jeroendedauw: Add addClaim method and allow construction with Traversable [11:37:08] (03CR) 10Adrian Lang: Introducing MonolingualTextParser (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133108 (https://bugzilla.wikimedia.org/64291) (owner: 10Daniel Kinzler) [11:54:24] (03PS1) 10Adrian Lang: Fix type name of DataValue in MonolingualTextDataType building [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134332 [11:58:57] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks ok. Any objections?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119989 (owner: 10Adrian Lang) [11:59:13] (03CR) 10Aude: "it is intended." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134104 (https://bugzilla.wikimedia.org/65492) (owner: 10Aude) [12:00:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134332 (owner: 10Adrian Lang) [12:02:16] (03CR) 10Thiemo Mättig (WMDE): "Didn't you wanted this the other way around in your comments in I07d2e56d2f6dfc0bf329dfdca99c76fe69836402? Add the dash everywhere?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134332 (owner: 10Adrian Lang) [12:02:39] [13WikibaseDataModel] 15JeroenDeDauw created 06claim (+1 new commit): 02http://git.io/PwqzYg [12:02:39] 13WikibaseDataModel/06claim 1487b98e9 15jeroendedauw: [WIP] Make Statement composite Claim [12:03:17] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #93: [WIP] Make Statement composite Claim (06master...06claim) 02http://git.io/hk1dnA [12:04:23] [travis-ci] wmde/WikibaseDataModel/claim/87b98e9 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/25595834 [12:05:02] (03CR) 10Aude: "@thiemo if you leave a comment (or say nothing) then merge, bene* probably won't see it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134260 (https://bugzilla.wikimedia.org/63036) (owner: 10Bene) [12:11:04] (03PS6) 10Thiemo Mättig (WMDE): [WIP] Attempt to clean-up and refactor ChangeOp and Validators code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 [12:17:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [12:20:49] (03PS2) 10Thiemo Mättig (WMDE): ChangeOps performance and style clean-up [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133068 [12:23:55] hello [12:26:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133068 (owner: 10Thiemo Mättig (WMDE)) [12:26:34] DanielK_WMDE: hey [12:34:10] EntityPerPage has this 2 todos [12:34:18] @todo: Combine with the EntityTitleLookup interface? [12:34:23] @todo: At least add a way to get page IDs! [12:36:17] Tobi_WMDE, Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=65256 [12:37:09] DanielK_WMDE: so what's the best thing to do? [12:38:02] (regarding https://bugzilla.wikimedia.org/show_bug.cgi?id=65507) [12:49:14] (03PS1) 10Daniel Kinzler: Remove StoreFactory and related logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 [12:49:42] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=64651 [12:52:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [12:54:39] (03CR) 10Jeroen De Dauw: "Conceptual +1" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [12:58:22] (03PS3) 10Thiemo Mättig (WMDE): ChangeOps performance and style clean-up [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133068 [13:03:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133068 (owner: 10Thiemo Mättig (WMDE)) [13:16:16] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "> it's better to have both fixed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134260 (https://bugzilla.wikimedia.org/63036) (owner: 10Bene) [13:16:26] (03Merged) 10jenkins-bot: Fix the exception caught in Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134260 (https://bugzilla.wikimedia.org/63036) (owner: 10Bene) [13:17:02] Thiemo_WMDE: will you ensure bene* knows [13:17:18] aude: yes, sure. [13:17:26] really, who ever looks at comments on merged patches? [13:17:28] sorry. [13:17:57] thats why this should be merged and the other problem communicated on an other way. [13:18:09] disagree, but oh well [13:18:53] https://gerrit.wikimedia.org/r/#/c/94939/ introduces both issues [13:18:56] the question is, are the two problems connected in a way or not? [13:18:56] they are related, imho [13:18:59] yep [13:19:16] i supose wikibase-setentity-invalid-id got changed later thoug [13:19:17] h [13:19:26] hm... [13:20:00] anyway, please file a new bug and tell him [13:23:17] (03PS1) 10Thiemo Mättig (WMDE): Fix messages in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 [13:23:19] (03CR) 10jenkins-bot: [V: 04-1] Fix messages in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 (owner: 10Thiemo Mättig (WMDE)) [13:26:50] (03PS2) 10Thiemo Mättig (WMDE): Fix non-existing messages in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 [13:28:46] aude: i see that the fix made the wrong message visible. so yes, it was part of the patch. sorry. [13:30:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 (owner: 10Thiemo Mättig (WMDE)) [13:31:18] lazowik: daniel is in a meeting. sorry [13:31:39] Lydia_WMDE: ok, I'm off now untill ~21:00 [13:31:41] so no hurry [13:32:16] ok [13:33:12] but I'd better ask that on bugzilla [13:33:34] Hi [13:33:37] I am https://www.wikidata.org/wiki/Q16184496 [13:34:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 (owner: 10Thiemo Mättig (WMDE)) [13:36:55] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06plane-termtext: 02http://git.io/qlFFUA [13:36:55] 13WikibaseDataModel/06plane-termtext 146f9385c 15thiemowmde: Fixed copy and paste mistake [13:37:15] [13WikibaseDataModel] 15thiemowmde 04deleted 06plane-termtext at 146f9385c: 02http://git.io/rukDeg [13:37:39] Thiemo_WMDE: did you consider 'wikibase-wikibaserepopage-not-itemid' instead of 'not-badge'? [13:38:34] aude: yes, i did. but both checks look for a badge that could not be found with that ID. [13:38:34] (03CR) 10Aude: Fix non-existing messages in SpecialSetSiteLink (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 (owner: 10Thiemo Mättig (WMDE)) [13:39:13] i guess both messages would be ok in these cases. [13:39:28] i wouldn't put too much effort into this though [13:39:36] exactly. ;) [13:39:52] the code is probably moved / gone soonish [13:40:05] (03CR) 10Aude: [C: 032] Fix non-existing messages in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 (owner: 10Thiemo Mättig (WMDE)) [13:40:07] ack [13:40:14] no ok [13:40:23] (03Merged) 10jenkins-bot: Fix non-existing messages in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134352 (owner: 10Thiemo Mättig (WMDE)) [13:40:54] Thiemo_WMDE: would you please review https://gerrit.wikimedia.org/r/#/c/134104/ again? [13:42:58] uh, so there is no CSS connected with the wb-error-... classes? hm, ok. [13:45:51] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/0yiPsw [13:45:51] 13WikibaseDataModel/06master 142b3cad3 15jeroendedauw: Add missing doc [13:46:50] no, .wikibase-wbtooltip-tip.wb-error .tipsy-inner is used though [13:46:59] appears unrelated [13:50:09] that moment where you wonder why the tests did not run and then notice they did in 37ms [13:52:09] i wonder if we could append the things to tipsy-inner [13:52:16] dont' think so [13:56:45] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Ok. I would have preffered append() instead of appendTo() but this is a matter of taste and doesn't change anything." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134104 (https://bugzilla.wikimedia.org/65492) (owner: 10Aude) [13:57:09] thanks [13:57:13] (03Merged) 10jenkins-bot: Make tooltip details compatible with jquery 1.9 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134104 (https://bugzilla.wikimedia.org/65492) (owner: 10Aude) [13:57:47] the only thing i notice difference and i think unrelated, it max width is 300px for .tipsy-inner [13:57:53] before it was 15em [13:59:44] huh? looks like this max-width details are from 2011 and not related. ;) [14:00:05] both 15em and 300px is fine. depends on the skin. [14:00:09] agree [14:07:59] (03PS2) 10Thiemo Mättig (WMDE): Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [14:09:15] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I removed some more lines from Wikibase.hooks.php that made the tests fail." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [14:11:34] [13Serialization] 15JeroenDeDauw created 06nonabs (+1 new commit): 02http://git.io/ah20xQ [14:11:34] 13Serialization/06nonabs 146856550 15jeroendedauw: Made SerializationException non-abstract [14:11:55] [13Serialization] 15JeroenDeDauw opened pull request #8: Made SerializationException non-abstract (06master...06nonabs) 02http://git.io/KRxcLw [14:13:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [14:14:34] [travis-ci] wmde/Serialization/nonabs/6856550 : jeroendedauw The build passed. http://travis-ci.org/wmde/Serialization/builds/25606317 [14:25:52] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=65507 [14:35:20] Thiemo_WMDE: please kick Lydia [14:35:23] to close the door [14:44:06] (03PS3) 10Daniel Kinzler: Remove StoreFactory and related logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 [14:49:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [15:00:21] Hoi, when I click on "English" (the default language I use in Wikidata) nothing happens.. It should trigger ULS ... right ? [15:01:04] GerardM-: The "English" in your personal toolbar (top right), yes [15:01:25] it does not [15:01:49] wanted to see if I could get tcy and if fonts were available [15:04:57] it works on en.wp ... not Wikidata ... [15:05:31] [13Serialization] 15thiemowmde comment on pull request #8 146856550: I don't know but shouldn't this be something like `3.2 alpha`? 02http://git.io/S2XGrA [15:06:22] (03CR) 10Bene: "@Legoktm: We will need this to create an autosuggester as noted in a todo." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (https://bugzilla.wikimedia.org/63486) (owner: 10Bene) [15:07:45] GerardM-: Can't reproduce atm [15:07:57] aude: have you been able to fix the gadget cache thing? [15:08:18] (03PS9) 10Bene: Create api module 'wbavailablebadges' to query all available badge items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (https://bugzilla.wikimedia.org/63486) [15:08:54] hoo: can be merged now? --^ [15:09:24] (03CR) 10Hoo man: [C: 032] Create api module 'wbavailablebadges' to query all available badge items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (https://bugzilla.wikimedia.org/63486) (owner: 10Bene) [15:09:30] benestar: Indeed :) [15:09:33] thx [15:09:43] (03Merged) 10jenkins-bot: Create api module 'wbavailablebadges' to query all available badge items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (https://bugzilla.wikimedia.org/63486) (owner: 10Bene) [15:10:13] hoo: i'm trying [15:10:42] seems to be getting stuff from local storage and not getting a new hash / timestamp [15:11:29] is there some other trick? [15:11:49] aude: Only gadgets are stale atm? [15:12:22] no idea, but that's what is broken [15:12:53] https://gist.github.com/filbertkm/710fa2d8426d89c84afb [15:13:12] oh, looks like it has a new hash 1400571348 [15:13:50] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (https://bugzilla.wikimedia.org/63486) (owner: 10Bene) [15:13:53] think i see the reason maybe [15:14:07] those are timestamps, not hashes ;) [15:16:27] yeah [15:17:04] * hoo kicks his PC [15:18:08] also note that AuthorityControl has no depencencies specified, although think that's not needed [15:23:40] https://gist.github.com/filbertkm/50eeaadfa6112b9d514a contents of the local storage [15:23:44] minified [15:26:36] appears to match https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-AuthorityControl.js&oldid=129617150 [15:27:09] mh [15:28:39] timestamp is from today [15:29:02] contents, unless i'm blind are from yesterday, so maybe stuck in memcached or some place [15:29:18] * aude doesn't completely know  [15:29:58] and it also doesn't work, even though version from yesterday should work except for coordinates [15:30:32] it's a purged page, so the dom looks correct [15:32:22] hoo: isn't there also a gadget that linkifies commons media? [15:32:27] yep [15:32:38] different gadget [15:32:43] https://www.wikidata.org/wiki/MediaWiki:Gadget-CommonsMedia.js [15:32:48] https://www.wikidata.org/wiki/Q2552417 [15:32:51] not linked in firefox [15:32:54] linked in chrome [15:33:19] i am logged in on both [15:34:08] i edited gadget definitions with hopes that would purge things [15:34:25] nah, that only purges the gadget extension cache [15:34:33] yah, i see [15:34:34] the actual gadget timestamps are page_touched [15:34:53] well, we edited those [15:34:56] of the script/CSS files, I mean [15:34:58] yeah :/ [15:35:12] that page works for me (logged in) [15:35:16] in firefox [15:35:19] wow [15:35:49] no wait, I'm debug=true [15:35:55] ah [15:36:07] debug=true, it works [15:39:38] (03PS1) 10Daniel Kinzler: Introducing EntityContentCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [15:41:58] [13Serialization] 15JeroenDeDauw comment on pull request #8 146856550: No, because I want to release this now. 02http://git.io/K78-tw [15:43:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [15:50:39] (03CR) 10Aude: [C: 04-1] "seems odd to have EntityContentCodec in lib while EntityContent is repo only" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [15:52:18] (03CR) 10Daniel Kinzler: "@aude: yes, that's the point. This is a serialization helper for entity content, so we can reliable unserialize entity content on the clie" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [15:53:48] aude: EntityContentCode factors the encoding/decoding out of the EntityCodec class, so we can use it on the client, too, to read entities. [15:55:03] so it only decodes to an array? [15:55:06] not EntityContent? [15:55:27] aude: yes. [15:55:36] the name is not clear then, imho [15:55:43] * aude hates naming but pick something else [15:55:53] aude: give me somethign else to pick :) [15:55:58] hah [15:56:12] EntityContentArrayCodec would be wrong (it'S not about arrays of EntityContent) [15:56:16] (03CR) 10Aude: Introducing EntityContentCodec (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [15:56:24] EntityContentStructureCodec isn't much better [15:56:53] this is actualyl the code that encodes and decodes EntityContent. It's the codec *for* EntityContent, not *of* EntityContent [15:57:18] it handles the json / arrays [15:57:46] aude: yes. and it will contain the knowledge how redirects are encoded. [15:58:09] [13Serialization] 15thiemowmde 04deleted 06nonabs at 146856550: 02http://git.io/3u1u9Q [15:58:18] we need to be able to handle that stuff on the client, without EntityContent [15:58:25] EntityContent[insert something]Codec [15:58:39] would be better than EntityContentCodec, even if not an awesome name [16:00:13] (03CR) 10Aude: Introducing EntityContentCodec (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [16:02:24] aude: I couldn't come up with [someting] good to insert there [16:03:27] EntityContentCodec tells me at a glance it handles EntityContent objects [16:05:10] aude: Regarding the gadget thing: I don't think this is a caching problem at all... probably it's a loader order issue rather [16:05:10] maybe the class is doing too much then? [16:05:25] hoo: thats' what i was thinking [16:05:33] although odd it happens in firefox only for me [16:06:08] aude: look at it. it isn't. [16:06:10] huh https://www.wikidata.org/wiki/Q2552417 links the commons media [16:06:40] aude: currently, it's little more than a wrapper around json_encode/json_decode. a little bit of knowledge about the array structure will be added. that's it. [16:06:52] i wondered about the name too, but I can't think of anything better [16:07:16] The only alternative is see is EntityContentStructureCodec, which isn't really much better [16:07:17] EntityContentStructureCodec would then be ok (not perfect [16:07:21] it is better [16:07:30] it's less misleading [16:07:53] EntityDataCodec? But the data structure is not for entities. It may represent a redirect (eventually), which belongs to the EntityContent, not the Entity... [16:08:03] EntityContentDataCodec [16:08:06] aude: i'll rename it to whatever :P [16:08:11] please [16:08:17] and look at the nitpicks also [16:08:38] i'll actually want to try the patch / run tests myself before approving or anything [16:11:42] hoo: we do mw.hook( 'wikibase.domready' ) [16:11:56] maybe we need to add entityview startup thing [16:12:54] (03PS2) 10Daniel Kinzler: Introducing EntityContentCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [16:14:57] aude: Hacking on that right now [16:15:12] i put it in gadget definitions [16:15:30] other gadgets might need it if they use the hook [16:17:18] aude: You don't want to add the entityview startup as dependency [16:17:20] please don't [16:17:52] ok [16:18:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [16:19:25] aude: mw.hook should be able to tell whether it has already been fired or even just instant fire after it has been fired first [16:19:50] hmmm [16:22:06] https://www.wikidata.org/wiki/Q1523127 is broken in firefox if i only use the gadget [16:22:14] if i use my script instead, it works [16:22:43] aude: Your script has another load order than the gadget [16:23:03] ok [16:23:22] fixed now, just wait for the caches to clear :) [16:23:38] https://www.wikidata.org/w/index.php?title=MediaWiki%3AGadget-AuthorityControl.js&diff=131636908&oldid=131627065 [16:24:00] getting some food, will be back later [16:25:46] :/ [16:26:13] if it works, ok, but wonder if that's the best solution? [16:26:25] and needs to be done for all gadgets [16:29:16] hoo|away: also seeing stuff like http://snag.gy/byrDL.jpg [16:36:25] (03PS3) 10Daniel Kinzler: Introducing EntityContentCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [16:41:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [16:43:43] (03CR) 10Aude: [C: 04-1] "nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [16:44:35] aude: Certainly not the best solution, not even a good one... but it works [16:44:49] (03CR) 10Aude: Introducing EntityContentCodec (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [16:45:04] there are several ways we can do this nicer [16:45:17] hoo: the hook also has // TODO ... remove when dom adjustments are no longer needed [16:45:50] we could probably just listen to mw.hook( 'wikipage.content' ) [16:46:02] but that also probably only fires once [16:47:13] Krinkle: ping [16:47:19] pong [16:47:53] mw.hook( 'wikipage.content' ) fires async and retro actively for the last wikipage load if you attach too late (just liek dom ready) [16:47:59] it will fire again if the page has been swapped [16:48:14] e.g. when doing a live preview submission or after VE edit is saved with ajax [16:48:46] Krinkle: Ok, but custom hooks don't fire when you attach to later, right? [16:48:53] (03PS1) 10Aude: Make tooltip details compatible with jquery 1.9 [extensions/Wikibase] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134383 (https://bugzilla.wikimedia.org/65492) [16:48:57] They do [16:49:00] That is their purpose [16:49:06] wtf [16:49:16] the firing is done by the hook, how else could it be [16:49:29] You can't force a function to run without access to it [16:49:29] I just had to work around that [16:49:35] Then you're doing it wrong [16:49:36] :) [16:51:35] * the documentation is wrong [16:51:56] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.hook [16:52:32] Yes, but it doesn't work like that [16:52:36] Which documentation? [16:52:38] Test case [16:52:42] mw.hook( 'wikibase.domready' ).fire(); [16:52:52] mw.hook( 'wikibase.domready' ).add( function() { ... } [16:53:00] the second one just doesn't fire in many cases [16:53:09] Then you're doing it wrong [16:53:12] it most certainly does [16:53:26] Try an isolated test case, console. [16:53:55] it's a very simple interface, perfect unit test for it. It's not broken. [16:54:17] Happy debugging :) [16:54:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134383 (https://bugzilla.wikimedia.org/65492) (owner: 10Aude) [16:55:57] if i do "mw.hook( 'wikibase.domready' ).add( function() { alert( 'hi' ) });" in console [16:56:00] it fires [16:56:51] No, it was already fired. You're just getting the last fire data. [16:57:10] ok [16:57:27] mw.hook( 'wikibase.domready' ).fire() [16:57:28] TypeError: obj is null [16:57:29] wtf [16:57:37] try again [16:57:40] i got that [16:57:44] second time it worked [16:58:00] errr no [16:58:34] That TypeError presumably comes from one of the add() listeners [16:58:51] which is probaly expecting an parameter to be passed [16:58:52] I hate gadgets [16:59:01] a parameter* [16:59:15] even if I call it with {} it's doing that [16:59:30] so then the listener is just broken in general [16:59:42] got a trace? [16:59:50] Is this in production? [17:00:08] https://www.wikidata.org/w/index.php?title=Special:Search&search=wikibase.domready&fulltext=Search&profile=all [17:00:58] https://www.wikidata.org/wiki/MediaWiki:Gadget-CommonsMedia.js [17:01:00] that's the cause [17:01:10] but it only listens to wikipage.content [17:01:40] wikipage.content has a $content parameter [17:01:50] you're not firing that from wikbase without content, are you? [17:02:05] If we do, I'll going to kill it asap [17:02:07] let me grep [17:02:14] cool [17:02:39] nope, we only add [17:03:03] (03PS1) 10Thiemo Mättig (WMDE): Right-to-left rendering for site links in diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) [17:08:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) (owner: 10Thiemo Mättig (WMDE)) [17:09:50] aude: disabled commons media gadget now [17:09:57] hmmm [17:10:12] * removed [17:29:39] (03PS1) 10Hoo man: Don't try to iterate over non-objects using jQuery.each [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134392 [17:29:45] aude: ^ [17:30:01] that will fix the error we got after firing mw.hook(...) [17:30:11] untested [17:30:44] if this is the root cause, we might want to backport [17:34:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134392 (owner: 10Hoo man) [17:35:17] hoo|away: please explain more [17:36:16] i see gadget does $content.find( '.valueview' ).each( function() [17:37:53] (03CR) 10Aude: [C: 032] Make tooltip details compatible with jquery 1.9 [extensions/Wikibase] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134383 (https://bugzilla.wikimedia.org/65492) (owner: 10Aude) [17:39:08] (03Merged) 10jenkins-bot: Make tooltip details compatible with jquery 1.9 [extensions/Wikibase] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134383 (https://bugzilla.wikimedia.org/65492) (owner: 10Aude) [17:49:49] DanielK_WMDE: https://github.com/wmde/WikibaseQueryEngine/pull/21 [17:50:51] (03PS1) 10Aude: New build, fix jquery 1.9 issue with error tooltip [extensions/Wikidata] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134398 [17:57:34] aude: mh [17:57:34] typeof this._items === 'object' [17:57:40] that should *always* be true [17:58:30] i think henning, adrian etc needs to review that [17:58:39] unless someone destroys and then still calls getState [17:58:46] which is very bad [17:58:53] when does that happen? [17:59:45] aude: When I fire mw.hook( 'wikibase.domready' ).fire(); per hand [17:59:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134398 (owner: 10Aude) [18:00:29] ok [18:00:38] i'll still let someone more qualified review [18:01:01] yeah [18:01:10] (03CR) 10Aude: [C: 032] New build, fix jquery 1.9 issue with error tooltip [extensions/Wikidata] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134398 (owner: 10Aude) [18:01:30] i'm not sure i understand the gadgets either [18:03:24] aude: mh... this is one big mess [18:03:35] just bin on Q112 ... authority control didn't work [18:03:44] then ran mw.hook( 'wikibase.domready' ).fire(); and it worked [18:04:06] i don't think it's specific to firefox either [18:04:14] shall I restore my mw.hook workaround maybe? [18:04:16] with bigger items, like https://www.wikidata.org/wiki/Q33 authority control does not work [18:04:22] it at least worked for me back then [18:04:50] (03CR) 10Legoktm: "I assume the autosuggester is client-side. If so, you should add it to mw.config rather than requiring an extra API request." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (https://bugzilla.wikimedia.org/63486) (owner: 10Bene) [18:05:17] aude: run mw.hook( 'wikibase.domready' ).fire(); per hand [18:05:21] it works for me after I did that [18:05:26] (on Q33) [18:05:45] trying [18:06:06] (03Merged) 10jenkins-bot: New build, fix jquery 1.9 issue with error tooltip [extensions/Wikidata] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/134398 (owner: 10Aude) [18:06:49] that's why i wonder if entityview init needs to be loaded first [18:07:02] although i don't completely know [18:07:13] seems backwards to do that way [18:07:26] aude: It will wait until entityview fires that hook in the current version [18:07:27] but then we fire add or fire the hook and it works [18:07:39] mmm [18:07:51] I think I'll restore my mw.hook workaround... or do you have a better idea for now? [18:08:02] no, but the workaround is needed for all gadgets [18:08:23] that sucks indeed [18:09:54] aude: We could have a loop on common.js which run .fire a couple of times after it has been fired initially [18:09:59] sounds very nasty, though [18:10:10] yeah [18:10:45] i don't have better idea and don't fully understand the issue [18:13:45] hah [18:16:34] i see commons media is back [18:16:59] TypeError: obj is null is back [18:17:21] [13Serialization] 15JeroenDeDauw tagged 063.2 at 06master: 02http://git.io/NaFntw [18:17:25] mw.hook fire doesn't do anything :( [18:19:00] aude: Where? With which browser? [18:19:08] And no, commons media is still gone, nobody reverted /me [18:21:02] oh [18:21:17] caching [18:21:28] https://www.wikidata.org/wiki/Q32333 [18:21:52] firefox, although doesn't seem to matter that much [18:23:46] that item also works for me after I run mw.hook( 'wikibase.domready' ).fire(); [18:24:53] I think we just need to fire mw.hook( 'wikibase.domready' ).fire(); later than we do now [18:25:11] wonder if we can reproduce on test.wikidata [18:25:33] anyway, need to finish the other backport first [18:25:40] shall we maybe just add a new wikibase.gadget.ready or so hook which fires after Wikibase is fully done [18:26:01] sure [18:26:14] domready is supposed to be a temp hack anyway [18:26:27] to be removed, and then someone will forget that it's used in all the gadgets [18:26:48] Yes... [18:26:57] that's the problem with the JS things... [19:09:00] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#126 (master - dd20823 : Translation updater bot): The build has errored. [19:09:00] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/96190db51bcb...dd20823ed5b5 [19:09:00] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/25631047 [19:11:33] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134460 (owner: 10L10n-bot) [20:21:34] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #94: Remove composer update from PHPUnit bootstrap (06master...06boot) 02http://git.io/DMSw4Q [20:26:17] [13WikibaseDataModel] 15addshore closed pull request #94: Remove composer update from PHPUnit bootstrap (06master...06boot) 02http://git.io/DMSw4Q [20:41:17] (03CR) 10Jeroen De Dauw: Introducing EntityContentCodec (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [22:53:50] aude: FYI: Just reinstated my authority control workaround... will try to introduce a decent hook tomorrow [22:54:00] (after talking to Tobi/ Adrian) [23:13:45] hoo: ok