[04:23:24] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/cCCj5Q [04:23:24] 13WikibaseDataModel/06master 14d1a1a39 15jeroendedauw: Add alias needed to not break internal serialization [07:49:08] [13WikibaseQuery] 15adrianlang created 06fixTests (+1 new commit): 02http://git.io/AOuwQQ [07:49:08] 13WikibaseQuery/06fixTests 141a01504 15Adrian Lang: Fix various failing test cases [07:50:28] [13WikibaseQuery] 15adrianlang opened pull request #23: Fix various failing test cases (06master...06fixTests) 02http://git.io/wBjqIg [07:52:39] [travis-ci] wmde/WikibaseQuery/fixTests/1a01504 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/25221559 [08:08:27] [13WikibaseQuery] 15adrianlang comment on pull request #20 14047375e: For me this does not work either. `ctype_digit` does not accept `int`s. 02http://git.io/waCBWw [08:21:17] JeroenDeDauw: How should I pass in $GLOBALS to the WikibaseQueryBuilder? In the constructor? [08:25:20] Adrian_WMDE: so did you fix the ctype_digit issue? [08:25:35] I wonder how that was not found before... It was broken from the start [08:25:47] * JeroenDeDauw slaps himself for not properly testing the check [08:26:35] JeroenDeDauw: No, I just replaced the PARAM_DFLT with strings, which is not so great propably [08:27:11] Adrian_WMDE: in https://github.com/wmde/WikibaseQuery/pull/23/files [08:27:20] you added if ( !defined( 'MW_PHPUNIT_TEST' ) ) { [08:27:29] That makes no sense - this code only runs in test context [08:27:35] It's a test helper after all [08:27:40] Or am I missing somrthing? [08:27:53] Yeah, but MW_PHPUNIT_TEST is not set if tests are run standalone, I guess? [08:28:38] Adrian_WMDE: the Query tests cannot run standalone AFAIK [08:28:48] Ah okay [08:29:11] Then we might just completely remove those two lines [08:29:17] This helper is only used by API and SpecialPage tests, which are inherently bound to MW [08:29:40] Right now they mess with MW's DB setup [08:34:21] Adrian_WMDE: this nicely describes my reaction to that stuff https://dl.dropboxusercontent.com/u/7313450/entropy/getitof.jpg [08:34:53] :D [08:35:10] Cats never get that kind of fun [08:40:20] Adrian_WMDE: if you submit a fixed version of #23 I'd be happy to merge it [08:40:37] I'll do that [08:41:52] JeroenDeDauw: Currently you assert that 10 (int) is not a valid limit; I'll move that to the valid limits, since it is the default value, and the default value should always be valid [08:44:14] Adrian_WMDE: Yeah... if the default does not get casted to the parameter type... [08:55:37] [13WikibaseQuery] 15adrianlang pushed 2 new commits to 06fixTests: 02http://git.io/z4tpwQ [08:55:37] 13WikibaseQuery/06fixTests 145e042d5 15Adrian Lang: Better validation of int params, added tests for those [08:55:37] 13WikibaseQuery/06fixTests 146c47cf6 15Adrian Lang: Remove dead code [08:58:11] [travis-ci] wmde/WikibaseQuery/fixTests/6c47cf6 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/25225473 [09:01:19] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vAp-_A [09:01:19] 13WikibaseQuery/06master 14167bd3f 15Jeroen De Dauw: Merge pull request #23 from wmde/fixTests... [09:03:17] oh-oh [09:04:03] [travis-ci] wmde/WikibaseQuery/master/167bd3f : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/25225837 [09:04:15] Adrian_WMDE: it was a trap? [09:05:02] [13WikibaseQuery] 15adrianlang created 06removeTearDown (+1 new commit): 02http://git.io/IETQKQ [09:05:02] 13WikibaseQuery/06removeTearDown 14b9b2978 15Adrian Lang: Remove calls to removed APITestSetup::tearDown [09:05:07] ^ JeroenDeDauw [09:05:42] Apparently I failed to actually run the tests before pushing [09:06:41] Adrian_WMDE: so now teardown is not run at all?? [09:07:02] APITestSetup has no tearDown anymore [09:07:20] Do you think there is something to tear down there? [09:07:42] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/J16Vtg [09:07:42] 13WikibaseQuery/06master 1486a2d7c 15Jeroen De Dauw: Merge pull request #24 from wmde/removeTearDown... [09:08:00] [travis-ci] wmde/WikibaseQuery/removeTearDown/b9b2978 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/25226100 [09:11:32] JeroenDeDauw: I'll push the wgDBprefix handling and a merge with master to dbal, ok? [09:11:54] [travis-ci] wmde/WikibaseQuery/master/86a2d7c : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/25226289 [09:12:23] Adrian_WMDE: sounds good [09:13:03] [13WikibaseQuery] 15adrianlang pushed 2 new commits to 06dbal: 02http://git.io/AidOZA [09:13:03] 13WikibaseQuery/06dbal 14e0bfd40 15Adrian Lang: Correctly handle MW's db table prefixes [09:13:03] 13WikibaseQuery/06dbal 146e42f19 15Adrian Lang: Merge branch 'master' into dbal... [09:13:08] There you are [09:13:17] Let's see what travis thinks about that [09:17:38] [travis-ci] wmde/WikibaseQuery/dbal/6e42f19 : Adrian Lang The build is still failing. http://travis-ci.org/wmde/WikibaseQuery/builds/25226734 [09:18:35] Damn [09:19:04] PHP Fatal error: Call to undefined method Wikibase\PropertyContent::save() in /home/travis/build/wmde/phase3/extensions/WikibaseQuery/tests/System/Api/ApiTestSetup.php on line 50 [09:19:06] hahaha [09:19:42] I should pull Wikibase more often [09:20:15] This thing is now esentially running against master of WB [09:20:18] Also not good [09:20:30] Not that it can do anything else, since we are not versioning WB [09:20:42] Yeah [09:20:47] Not good [09:21:06] But as we (you) break out bits of Wikibase.git, more and more stuff will be versioned [09:21:44] Sure [09:21:56] I hope it will not just be me doing effort in that department though [09:26:28] Damn now I need to instantiate WikiPageEntityStore [09:27:13] Adrian_WMDE: you should be able to get an instance via the repo factory [09:27:16] WikibaseRepo [09:27:24] There should already be an instance of the factory available [09:27:38] Or perhaps not... anyway, it's a global thing after all [09:28:00] (should be able to... idk if it actually has a method for that) [09:29:07] getEntityStore should return what I need [09:36:31] [13WikibaseQuery] 15adrianlang created 06entityContentSave (+1 new commit): 02http://git.io/ULMZag [09:36:31] 13WikibaseQuery/06entityContentSave 14be6ddaf 15Adrian Lang: Adapt to removal of EntityContent::save [09:36:47] ^ JeroenDeDauw [09:38:38] Adrian_WMDE: why did you not put this on the dbal branch> [09:38:40] > [09:38:42] ? [09:38:50] [travis-ci] wmde/WikibaseQuery/entityContentSave/be6ddaf : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/25228143 [09:39:08] Adrian_WMDE: is there now [09:39:13] ok [09:39:15] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06dbal: 02http://git.io/xrOHLw [09:39:15] 13WikibaseQuery/06dbal 149f089b4 15Jeroen De Dauw: Merge pull request #25 from wmde/entityContentSave... [09:39:31] [13WikibaseQuery] 15JeroenDeDauw 04deleted 06entityContentSave at 14be6ddaf: 02http://git.io/rtqHfQ [09:45:26] [travis-ci] wmde/WikibaseQuery/dbal/9f089b4 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wmde/WikibaseQuery/builds/25228385 [09:45:43] Only sqlite failing [09:46:10] Table prefix lalala [09:46:14] uuuughggggggggggggggggggggggggggggg [09:46:23] Adrian_WMDE: yeah, MW does not do table prefix for SQLite [09:46:39] Now I actually wonder why it does not... [10:00:24] (03PS1) 10WikidataBuilder: New Wikidata Build - 15/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133437 [10:07:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133437 (owner: 10WikidataBuilder) [10:09:35] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 15/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133437 (owner: 10WikidataBuilder) [10:10:47] (03CR) 10Tobias Gritschacher: [C: 032] update links in release notes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133287 (owner: 10Christopher Johnson (WMDE)) [10:11:12] (03Merged) 10jenkins-bot: update links in release notes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133287 (owner: 10Christopher Johnson (WMDE)) [10:12:34] (03Merged) 10jenkins-bot: New Wikidata Build - 15/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133437 (owner: 10WikidataBuilder) [10:39:19] (03PS4) 10Tobias Gritschacher: Converted Ruby pageObjects to modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125172 [10:44:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125172 (owner: 10Tobias Gritschacher) [11:02:00] (03PS1) 10Amire80: Localize the number in the quantity counter message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133443 [11:02:50] JeroenDeDauw, aude - hi [11:02:58] can you please take a look at https://gerrit.wikimedia.org/r/#/c/133443/ ? [11:03:17] it should be simple, but I cannot test it myself [11:07:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133443 (owner: 10Amire80) [11:27:51] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133437 (owner: 10WikidataBuilder) [11:31:58] Adrian_WMDE: ^ [11:40:05] Lydia_WMDE: are you around .... [11:40:18] GerardM-: kind of [11:40:18] wasup? [11:40:24] I need your attention ... am talking with DBpedia people at the Dutch chapter [11:40:38] ok [11:40:41] they can update Wikidata whenever there is a change in nl.wp [11:40:46] ok [11:40:49] seconds after the safe [11:41:32] we are going to show a mapping for two specific fields [11:41:47] and when that mapping is good, we want to import and keep up to date [11:41:59] this is INCLUSIVE reporting of differences [11:42:34] ok [11:42:43] ... nl.dbpedia is able to do this this is not true for all dbpedias [11:43:04] your first reaction ? [11:43:41] heh well it is really not my decision. i think it is worth an experiment personally [11:44:19] Dutch authors and Dutch monuments [11:44:49] sounds like a good fit [11:51:38] Thiemo_WMDE: in case you're fed up with PHP. ;) https://gerrit.wikimedia.org/r/#/c/125172/ [11:51:52] ;) [11:57:55] (03CR) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (https://bugzilla.wikimedia.org/53846) (owner: 10Aude) [12:06:47] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133437 (owner: 10WikidataBuilder) [12:22:20] Lydia_WMDE: ? [12:22:46] Adrian_WMDE: the patch aharoni posted - maybe you can have a look [12:23:17] yes, Lydia_WMDE & Adrian_WMDE , that would be nice. I don't have w [12:23:40] I don't have Wikibase properly installed, and I'm a bit to busy to set the whole thing up just for this small patch, [12:23:46] so it may have embarrassing errors :) [12:42:04] (03CR) 10Adrian Lang: [C: 032] Localize the number in the quantity counter message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133443 (owner: 10Amire80) [12:42:37] (03Merged) 10jenkins-bot: Localize the number in the quantity counter message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133443 (owner: 10Amire80) [12:43:32] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133437 (owner: 10WikidataBuilder) [12:48:41] DanielK_WMDE: can you confirm that anything related to https://bugzilla.wikimedia.org/show_bug.cgi?id=62493 is merged now? [12:49:23] and close the bug if so [12:50:31] Tobi_WMDE: well... not quite, but all the improtant stuff is done. the rest is consmetics/cleanup, no longer blocking redirects [12:50:50] i'd like to get a few more patches merged before closing this. will do that together with timo today [12:55:11] DanielK_WMDE: allright then [12:57:15] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c7159ae : Amir E. Aharoni The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25239696 [13:02:36] (03PS3) 10Daniel Kinzler: Introducing EntityConstraintProvider [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 [13:02:40] Thiemo_WMDE: --^ [13:09:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 (owner: 10Daniel Kinzler) [13:11:20] Adrian_WMDE++ Thank you for the review! [13:12:19] [13WikibaseDataModel] 15thiemowmde created 06claims-complexity (+1 new commit): 02http://git.io/I4zhXQ [13:12:19] 13WikibaseDataModel/06claims-complexity 14b60eeab 15Thiemo Mättig: Reduce complexity of Claims class [13:13:56] aharoni: was there a bug for localizing the counter message? [13:14:07] if so, can you please close it then? [13:15:00] Tobi_WMDE: No. A Persian-speaking editor who doesn't like using Bugzilla for some reason reported it to me in an email. [13:15:00] He does such things almost every day. [13:15:13] Sometimes it takes less time to fix it than to report a bug. [13:15:17] aharoni: ok. fine then. :) thx [13:15:26] [travis-ci] wmde/WikibaseDataModel/claims-complexity/b60eeab : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/25242096 [13:31:53] [13WikibaseDataModel] 15thiemowmde opened pull request #91: Reduce complexity of Claims class (06master...06claims-complexity) 02http://git.io/RtDHug [13:35:14] [13WikibaseDataModel] 15thiemowmde comment on pull request #90 14847ee00: The `@see` is misplaced now. 02http://git.io/BOP0MQ [13:37:17] [13WikibaseDataModel] 15thiemowmde comment on pull request #86 14830a047: No, because a `Term` object knows it's language. `setTerm( Term )` is correct. 02http://git.io/LHy3FQ [13:52:08] [13WikibaseDataModel] 15thiemowmde comment on pull request #86 14830a047: Sure, I will submit a patch for the things that are not part of this change. But since this method is new it would be nice to decide on a naming scheme and use it. So we don't need to rename the method later.... 02http://git.io/OIZDpw [14:09:12] (03PS3) 10Daniel Kinzler: Prevent import of entities to avoid ID conflicts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133227 (https://bugzilla.wikimedia.org/63228) [14:14:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133227 (https://bugzilla.wikimedia.org/63228) (owner: 10Daniel Kinzler) [14:32:56] (03PS5) 10Daniel Kinzler: Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) [14:38:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [14:47:10] hoo: deplyment was fine, right? [14:47:23] can you update https://www.mediawiki.org/wiki/Wikidata_deployment#mw1.24wmf4 ? [14:47:32] Tobi_WMDE: forget the page [14:47:41] it went fine, yes [14:47:58] great [14:49:07] Lydia_WMDE: DanielK_WMDE: I've started running the rebuildItemsPerSite script yesterday for Wikidata [14:49:19] it's at almost 9 million items now [14:49:31] hoo: yay [14:49:32] hoo: 9 million wrong ones? [14:49:35] :P [14:49:41] or 9 million done [14:49:48] Lydia_WMDE: No... those so far were mostly fine [14:49:58] excellent [14:50:01] There are still 804105 items w/o sitelinks according to the secondary storage [14:50:26] well we will have quite a few without sitelinks [14:50:26] I guess the script still has to hit the time frames where we had large problems with the secondary storage [14:50:26] but that might be too many [14:50:31] yeah [14:56:51] (03PS4) 10Daniel Kinzler: Prevent import of entities to avoid ID conflicts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133227 (https://bugzilla.wikimedia.org/63228) [14:57:11] Lydia_WMDE: The script just hit such a spot [14:57:28] hah [14:57:30] my screen is full of "Savings sitelinks for Item Q9742521 failed" :/ [14:57:34] meh [14:59:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Prevent import of entities to avoid ID conflicts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133227 (https://bugzilla.wikimedia.org/63228) (owner: 10Daniel Kinzler) [15:00:00] hoo: uh.... why does it fail? because of conflicts? does it log a lit of items with conflicting sitelinks? [15:00:10] (03Merged) 10jenkins-bot: Prevent import of entities to avoid ID conflicts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133227 (https://bugzilla.wikimedia.org/63228) (owner: 10Daniel Kinzler) [15:00:39] moin [15:01:04] DanielK_WMDE: Yes conflicts... and no, I only log the Entity Ids... getting what actually conflicted would have needed more logic, I guess the community can fix this [15:01:16] if they can't, I guess we can still amend the script for that [15:01:19] hi aude :) [15:02:39] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133227 (https://bugzilla.wikimedia.org/63228) (owner: 10Daniel Kinzler) [15:03:45] Number of items w/o sitelinks is already down to 799881 [15:08:32] (03CR) 10Daniel Kinzler: "The ValueValidator interface is generic, it's not defined to apply to any specific kind of subject type. So, using it for strings is not a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [15:16:44] (03CR) 10Aude: [C: 04-1] "see comments" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [15:18:42] (03PS1) 10Hoo man: Fix a typo in ItemsPerSiteBuilder's output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133479 [15:18:53] ^-- just noticed that... and it bugs me :P [15:19:22] aude: i'm looking at the comments, and find very little I can do. I'll follow up in a minute, but I disagree with most. [15:20:05] aude: oh, i was talking about the validator patch, not the DV mistmatch patch. will look at that next [15:20:21] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Introducing EntityConstraintProvider [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 (owner: 10Daniel Kinzler) [15:20:52] (03Merged) 10jenkins-bot: Introducing EntityConstraintProvider [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 (owner: 10Daniel Kinzler) [15:21:44] (03CR) 10Daniel Kinzler: Move term validation into ChangeOps (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [15:22:16] (03PS17) 10Daniel Kinzler: Move term validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) [15:22:30] (03PS18) 10Daniel Kinzler: Move term validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) [15:22:32] (03CR) 10jenkins-bot: [V: 04-1] Move term validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [15:22:40] DanielK_WMDE: probabaly ask jeroen if he has ideas for term validation [15:23:00] aude: we can do that, we this patch shouldn't be blocked on that discussion [15:23:06] i just think it's a big mistake to go further down this road and will only cost us a lot of time to refactor later [15:23:35] i'm afraid that it gets merged, then discussion and fixing the issue will not happen [15:23:38] then it will bite us later [15:24:02] i don't think so. even if we decide to use a different interface for primitive types, or even a specific one for strings, it'll not need structural changes. it just means changing the interfaces used in method declarations [15:24:05] i wonder what jeroen really intends for ValueValidators since he wrote it [15:24:33] I actually think that mixing the output types of formatters is a far worse problem than the broad validator interface [15:24:42] it's all bad [15:24:53] horrible. on noes :P [15:25:03] there should be some generic validator interface [15:25:08] value validators can use that [15:25:16] non-value validators can use it [15:25:47] "value" means DataValue to you? It doesn't to me. As far as I can see, it doesn't mean that in the definition and usage of ValueValidator at all. [15:25:53] i do [15:25:55] it's in data values [15:26:18] we should move it out of datavalues if it's not intended to be specific [15:26:56] aude: but even in the data-values package, there [15:27:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133479 (owner: 10Hoo man) [15:27:11] there's a StringValidator, a ListValidator, a TitleValidator, etc. [15:27:18] gah [15:27:21] these do not take DataValues as a parameter [15:27:26] horrible [15:27:36] so, I have been using that interface as intended. [15:27:50] we can discuss whether that should be improved, but this is how it's currently defiend and used. [15:28:11] as i said, i care more about fixing my own design mistake regarding formatters [15:28:21] anyway. let me look at the DV patch again [15:29:24] DanielK_WMDE: is lydia there? [15:29:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5410d46 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25251483 [15:30:08] please have her put a discussion item on the board about value validators [15:30:09] aude: no [15:30:19] :( [15:30:23] i'll put one up [15:30:36] if a discussion item is on the board, then i am willing to remove my -1 [15:31:06] aude: i'm at home today. discussion item is good [15:31:16] with the formatters, we have the issue that "hey maybe this is not a data value, then we can't do anything datavalue specific in formatters" [15:31:28] like $value->getType() or what not [15:31:40] Lydia_WMDE: Get to work :p [actual work] [15:31:44] it might be EntityId instead of EntityIdValue [15:31:51] JohnLewis: :) [15:32:05] I bet aude is at work :p [15:32:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [15:32:14] aude: no, with formatters, we have the issue of "oh, i got a formatter, i really hope it returns html and takes care of escaping" .... "ooops, it returned raw strings, well, crap". [15:32:18] JohnLewis: i am not [15:32:18] that's the problem [15:32:30] aude: {{sogettoworkthen}} :p [15:32:30] DanielK_WMDE: that too [15:32:35] that's the main issue [15:32:36] :) [15:32:58] i care way mroe about assertions about the return values than i care about the method signatures [15:33:15] JohnLewis: i have a much deserved lazy day today doing kde work -.- [15:33:26] like travel reimbursements and stuff [15:33:38] we can enforce assumptions in the method implementation easily. we cannot easily enforce assumptions made about return values of methods we call on injected objects. we need interfaces to make those guarantees checkable [15:33:41] with those formatters, depends on the format desired [15:33:55] if it's an html formatter, yes [15:33:55] exactly. the defisred format needs to be part of the interface [15:33:58] oh, well [15:33:59] yes [15:34:11] Lydia_WMDE: {{thisonetimeok}} [15:34:23] * aude office is not in berlin now :) [15:34:34] JohnLewis: \o/ [15:34:53] i am at the DC wikidata office :) [15:34:53] haha [15:34:53] aude: pics! [15:34:53] :p [15:34:56] heh [15:35:20] probably will sit outside some today [15:35:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [15:35:56] DanielK_WMDE: ok, the -1 is off (since you rebased) [15:37:11] (03CR) 10Aude: [C: 032] Fix a typo in ItemsPerSiteBuilder's output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133479 (owner: 10Hoo man) [15:37:30] (03Merged) 10jenkins-bot: Fix a typo in ItemsPerSiteBuilder's output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133479 (owner: 10Hoo man) [15:49:36] (03CR) 10Daniel Kinzler: Handle DVs that mismatch a prop's expected type (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [15:49:54] (03PS6) 10Daniel Kinzler: Handle DVs that mismatch a prop's expected type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) [15:54:07] hoi [15:54:17] does Reasonator work for you ? [15:54:28] it shows a blank page for me [15:54:42] http://tools.wmflabs.org/reasonator/?q=Q5622486 [15:55:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [16:17:28] (03PS7) 10Daniel Kinzler: (bug 64309) Introducing ChangeOp::validate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 [16:23:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [16:26:16] GerardM-: same here. blank. [16:27:08] meh... since MediaWiki core started to use travis it takes ages until travis comes to running our tests [16:28:18] rage [16:28:30] GerardM-: ReferenceError: mw is not defined [16:28:31] http://en.wikipedia.org/w/index.php?title=MediaWiki:Wdsearch-autodesc.js&action=raw&ctype=text/javascript Line 54 [16:28:55] TypeError: wd_auto_desc_wd is undefined [16:28:57] http://tools.wmflabs.org/reasonator/main.js Line 2791 [16:29:38] GerardM-: seems like reasonator is using some JS that expects a mediawiki to be there [16:32:37] woah, what happened to the table of contents? [16:33:30] wikibase looks odd w/o js [16:39:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/79609b3 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/25253089 [16:55:04] hyia [17:25:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Definitely needs more love, see comments." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [17:25:54] (03Merged) 10jenkins-bot: Move term validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [17:26:11] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Restoring my previous +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [17:26:31] (03Merged) 10jenkins-bot: (bug 64309) Introducing ChangeOp::validate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [17:33:49] * aude sigh [17:51:54] (03PS1) 10Aude: Remove reference to 'calendar' for globe data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133510 [17:58:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133510 (owner: 10Aude) [18:55:37] (03PS1) 10Thiemo Mättig (WMDE): Attempt to clean-up and refactor ChangeOp and Validators code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 [18:59:52] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [19:03:00] (03CR) 10Thiemo Mättig (WMDE): Attempt to clean-up and refactor ChangeOp and Validators code (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [19:08:53] (03PS2) 10Thiemo Mättig (WMDE): Attempt to clean-up and refactor ChangeOp and Validators code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 [19:14:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [19:29:03] (03CR) 10Thiemo Mättig (WMDE): "I wonder why you are passing so many Title objects around? It's better than passing a Content object around, sure. But this also adds Titl" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131965 (owner: 10Daniel Kinzler) [20:39:28] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133585 (owner: 10L10n-bot) [21:04:09] (03CR) 10Thiemo Mättig (WMDE): Handle DVs that mismatch a prop's expected type (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [21:34:44] (03CR) 10Aude: [C: 04-1] Handle DVs that mismatch a prop's expected type (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [21:35:56] (03CR) 10Aude: Handle DVs that mismatch a prop's expected type (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133286 (https://bugzilla.wikimedia.org/63299) (owner: 10Daniel Kinzler) [22:09:39] (03PS1) 10Aude: Fix ApiErrorReporterTest, avoid use $wgLang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 [22:09:59] (03PS2) 10Aude: Fix ApiErrorReporterTest, avoid use of $wgLang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 [22:11:09] (03PS3) 10Aude: Fix ApiErrorReporterTest, avoid use of $wgLang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 [22:11:17] (03CR) 10jenkins-bot: [V: 04-1] Fix ApiErrorReporterTest, avoid use of $wgLang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 (owner: 10Aude) [22:12:06] (03PS4) 10Aude: Fix ApiErrorReporterTest, avoid use of $wgLang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 [22:18:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 (owner: 10Aude) [22:24:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 (owner: 10Aude) [22:28:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 (owner: 10Aude) [22:31:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133624 (owner: 10Aude)