[00:02:10] [travis-ci] wmde/WikibaseQuery/dbal/ed4f0dd : jeroendedauw The build is still failing. http://travis-ci.org/wmde/WikibaseQuery/builds/25024239 [00:04:57] [13WikibaseQuery] 15JeroenDeDauw 04force-pushed 06dbal from 14ed4f0dd to 14047375e: 02http://git.io/pHkd7g [00:04:57] 13WikibaseQuery/06dbal 14047375e 15jeroendedauw: Update construction of QueryEngine services after DBAL migration [00:07:46] [travis-ci] wmde/WikibaseQuery/dbal/047375e : jeroendedauw The build is still failing. http://travis-ci.org/wmde/WikibaseQuery/builds/25024483 [01:26:21] [travis-ci] wmde/WikibaseQueryEngine/cli/3505fe0 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25028598 [07:02:39] Thiemo_WMDE: you up already? [07:02:52] mad person [08:49:20] [13WikibaseDataModel] 15thiemowmde comment on pull request #86 14830a047: Approved. :-) 02http://git.io/K0b7cA [08:59:35] [13WikibaseDataModel] 15thiemowmde comment on pull request #86 14830a047: I know this is a bit older. That's why I asked for a follow up. The naming is just inconsistent:... 02http://git.io/lurmJw [09:28:47] [13WikibaseQuery] 15thiemowmde comment on pull request #20 14047375e: Uh, what? Is this meant to be a quick workaround that is supposed to go away in later patches? At least mark it with a FIXME then, please. 02http://git.io/vXFyiw [10:00:28] (03PS1) 10WikidataBuilder: New Wikidata Build - 13/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133055 [10:09:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133055 (owner: 10WikidataBuilder) [10:09:44] (03Abandoned) 10Addshore: New Wikidata Build - 11/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/132787 (owner: 10WikidataBuilder) [10:09:48] (03CR) 10Addshore: [C: 032] New Wikidata Build - 13/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133055 (owner: 10WikidataBuilder) [10:25:39] Hi ! I'm trying to install wikibase. I've downloaded the 1.22 release, and install the dependencies using composer. When running php maintenance/update.php, I get "PHP Fatal error: Uncaught exception 'Exception' with message 'WikibaseLib depends on the DataValuesInterfaces extension." [11:00:00] DanielK_WMDE: Around? There's some minor things about the JSON dump stuff I want to discuss [11:20:33] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/133055 (owner: 10WikidataBuilder) [11:33:07] DanielK_WMDE: How should we handle the fact that we get on json dump per shard... provide them separately or merge them into one big file? [13:17:52] Lydia_WMDE: https://github.com/wmde/WikibaseQueryEngine/pull/21 [13:18:48] hoo: in story time meeting atm [13:18:52] sorry [13:19:22] I see [14:08:05] hoo: are you working on https://bugzilla.wikimedia.org/show_bug.cgi?id=64600? [14:08:28] is aude 's answer sufficient for you? [14:10:54] It is, yes... but I'm not entirely sure how to implement that [14:11:35] DataUpdate has no get name on it, so it might be hard to filter the DataUpdate array [14:11:53] s/get name/getName()/ [14:22:13] hoo: filter by class name [14:22:19] it's a hack, but should work well enough [14:22:53] hoo: i actually envirion the script to (eventually) have a couple of different modes. I'll comment on the bug. [14:23:40] Yeah... filtering on class name sounds a little evil, but I guess it's ok for a solely manually run script [14:29:55] Hallo. [14:30:44] Did anybody notice the duplicate pencil in the "Add links" element on article without interlanguage links? [14:30:57] Such as here: https://de.wikipedia.org/wiki/2102 [14:31:06] Or here: https://en.wikipedia.org/wiki/%22Awesome%22 [14:31:07] aharoni: Yes, fixed on master [14:31:13] hoo: thanks. [14:31:21] Yeeeha, I managed to install wikibase in the end ;) [14:32:25] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=64600#c5 [14:32:55] looking [14:33:33] DanielK_WMDE__: partly that would be a re implementation of core's refreshLinks AFAIS [14:35:37] hoo: yes, but saner :) [14:36:06] but actually - refreshLinks already calls getSecondaryDataUpdates, and runs all the updates. it should cover most of what we need, I guess. [14:36:15] it's just not very flexible. [14:36:56] and it does things I don't envision the new script doing, such as deleting links for non-existing pages (which requires knowledge of all the link tables in question) [14:37:09] I have several questions about how to administer a wikibase site (list/create/edit properties, export rdf data, etc...), is there a centralized source where I can read about it ? I only see the link to the wikidata help page, which is more aimed at end users it seems.... [14:38:18] olivd: there is some information on mediawiki.org on Extension:Wikibase. But I'm afraid we don't have very good documentation for this yet. [14:39:01] we are working on it... for now, I recommend asking here or on the wikidata-tech mailing list [14:42:37] olivd: also, in extension/wikibase/docs, you'll find a file called settings.wiki, which should contain the canonical documentation for all the options.wiki [16:20:52] (03PS1) 10Daniel Kinzler: Remove EntityContent::getWikiPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133086 (https://bugzilla.wikimedia.org/62439) [16:20:57] (03PS1) 10Daniel Kinzler: Stop using EntityContent::getTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133087 (https://bugzilla.wikimedia.org/62493) [16:28:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133086 (https://bugzilla.wikimedia.org/62439) (owner: 10Daniel Kinzler) [16:30:10] (03CR) 10Daniel Kinzler: [C: 032] "bah, merging this for now, will address my nitpicks in a follow-up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130337 (owner: 10Adrian Lang) [16:30:31] (03Merged) 10jenkins-bot: Add monolingual-text data type to experimental features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130337 (owner: 10Adrian Lang) [16:31:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133087 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [16:39:31] (03CR) 10Hoo man: [C: 032] "I just hope that we wont see the new exception bubbling up..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131978 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [16:39:50] (03Merged) 10jenkins-bot: Move ID assignment to EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131978 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [16:52:30] Hello. I found something funny when trying to access data in JSON: https://www.wikidata.org/wiki/Special:EntityData/Q84.json gives an error (it was already the case last week so not a temporary thing) [16:53:06] fguillier: We already fixed that within Wikibase, but the change is not yet live [16:54:09] ok thanks. Do you know (roughly) when it will be updated on wikidata? [16:55:23] fguillier: On Thursday it will ;) [16:55:47] Smashing! Thanks a lot for the reply. Have a nice day! [16:59:17] (03CR) 10Hoo man: [C: 032] Removing EntityContent::save (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131989 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [16:59:43] (03Merged) 10jenkins-bot: Removing EntityContent::save [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131989 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [16:59:45] (03CR) 10Hoo man: [C: 032] Remove EntityContent::getWikiPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133086 (https://bugzilla.wikimedia.org/62439) (owner: 10Daniel Kinzler) [17:00:08] (03Merged) 10jenkins-bot: Remove EntityContent::getWikiPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133086 (https://bugzilla.wikimedia.org/62439) (owner: 10Daniel Kinzler) [17:07:41] Thiemo_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=65267 [17:08:03] (03CR) 10Hoo man: [C: 032] Stop using EntityContent::getTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133087 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [17:08:22] (03Merged) 10jenkins-bot: Stop using EntityContent::getTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133087 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [17:34:17] DanielK_WMDE: thx I'll look that ! and probably come back soon ;) [18:09:52] (03PS1) 10Daniel Kinzler: Introducing formatters for monolingual text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) [18:15:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [18:26:07] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #90: Soft deprecate the EntityId::getPrefixedId alias (06master...06master) 02http://git.io/t2fkjA [18:27:49] (03PS2) 10Daniel Kinzler: Introducing formatters for monolingual text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) [18:29:32] [13WikibaseQuery] 15JeroenDeDauw comment on pull request #20 14047375e: This is not a workaround. This is how one accesses MediaWiki config, not a lot the code can do about that. The one thing that minimizes the evil and is done here is not accessing the globals from the class itself but requiring an array, and having the user pass in the globals. That at least makes testing less insane. 02http://git.io/l9pGGA [18:33:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [18:35:29] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #86 14830a047: I'd be very happy if you could submit a PR that addresses that after this one got merged. Though keep in mind that some of these methods have been added in 0.7.x already, and that if we simply rename them, they are breaking changes. (Perhaps that is not to bad in this case since they are rather new and not used much yet) 02http://git.io/XlP0nw [18:36:08] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #86 14830a047: Then we should also have the other one be `setTermForLanguage` 02http://git.io/grYU9Q [18:40:51] [travis-ci] wmde/WikibaseQueryEngine/timeHandler/825d1a7 : Thiemo Mättig The build was broken. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25093825 [18:52:32] (03PS1) 10Daniel Kinzler: Introducing MonolingualTextParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133108 (https://bugzilla.wikimedia.org/64291) [18:58:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133108 (https://bugzilla.wikimedia.org/64291) (owner: 10Daniel Kinzler) [19:00:34] (03PS3) 10Daniel Kinzler: Introducing formatters for monolingual text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) [19:06:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [19:11:21] (03CR) 10Hoo man: [C: 04-1] Introducing formatters for monolingual text (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [19:16:03] [travis-ci] wmde/WikibaseQueryEngine/timeHandler/c2cad3b : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/25095652 [19:16:06] hoo: that's not HTML :) [19:17:21] $1 [19:17:28] what else? mh? [19:17:29] hoo: that's wikitext [19:17:46] (03CR) 10Daniel Kinzler: Introducing formatters for monolingual text (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [19:17:46] Oh, yes, I see [19:18:17] hoo: you are right about the constructors, of course [19:18:19] fixing [19:18:20] DanielK_WMDE: It's not about evil html (local sysops can do that anyway) [19:18:35] but?... [19:18:40] the pattern needs to be localizable [19:18:48] it's about them changing that for some reason and later on it's 1) no longer following our format 2) They don't get our changes on it [19:18:50] and we need at least the lang attribute [19:18:54] i see no better way [19:19:10] hoo: that'S true for any system message :) [19:19:25] note that the plain text formatter doesn't use the message, and should thus be round-trip safe [19:19:42] DanielK_WMDE: Usually it doesn't matter... but here we're putting classes etc. on things, so we set some semantical properties [19:19:45] (03PS4) 10Daniel Kinzler: Introducing formatters for monolingual text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) [19:20:15] hoo: but i can't hardcode this. the parantecies etc are language dependant [19:20:19] they need localization [19:20:25] can't we make a html template out of it and only have the parameters localizable? [19:20:40] including the parentheses [19:21:12] i don't see how that would make things better [19:21:18] it's just a lot more complicated [19:21:23] it wouldn't allow people to override the spans [19:21:29] i really don't see the problem with this being changed locally [19:21:56] if people want to override the spans, they can. i don't care. we don't use them. [19:21:58] well, people did very nasty things with the wikitext/ html stuff Cite uses and that once broke very horribly when I changed cite [19:22:42] they can do lots of horrible thing with any message that supports wikitext or html. [19:22:45] that's nearly all of them [19:22:57] we don't rely on the span. so let them change it. i don't care. [19:23:50] I'm not happy with that... but as long as nothing depends on that span being present or sane or whatever I'm kind of ok [19:25:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [19:25:41] hoo: does "kind of ok" translate to CR+2?.... [19:26:12] (03CR) 10Hoo man: [C: 032] Introducing formatters for monolingual text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [19:26:16] Yep ;) [19:26:21] \o/ [19:26:23] thanks [19:26:27] now the parser, too. [19:26:30] it's trivial [19:26:38] (03Merged) 10jenkins-bot: Introducing formatters for monolingual text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133096 (https://bugzilla.wikimedia.org/64293) (owner: 10Daniel Kinzler) [19:27:05] looking [19:27:49] hoo: oh, you merged a lot more of my patches today than i realized! cool! [19:28:02] * DanielK_WMDE does a happy dance and shifts things around on the borad [19:28:10] board even [19:30:40] (03CR) 10Hoo man: [C: 032] Introducing MonolingualTextParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133108 (https://bugzilla.wikimedia.org/64291) (owner: 10Daniel Kinzler) [19:31:05] (03Merged) 10jenkins-bot: Introducing MonolingualTextParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133108 (https://bugzilla.wikimedia.org/64291) (owner: 10Daniel Kinzler) [19:31:12] (03CR) 10Daniel Kinzler: "@aude: ValueValidators are used routinely for primitive values like strings etc during snak validation. I agree that that's icky, but that" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [19:31:49] I like how StringValueParser does the type validation for it's childs :) [19:32:55] DanielK_WMDE: Back home? [19:33:15] hoo: I find it quite silly that the ValueParser interface accepts input other than strings. A parser is defined to operate on strings, no? [19:33:26] multichill: back in berlin, actually [19:33:31] Almost home [19:33:42] i guess :P [19:34:13] multichill: how about you? [19:34:26] DanielK_WMDE: In PHP everything can work with everything, right? :P But actually you're right... don't see why one should eg. put an integer there [19:34:57] Got home yesterday with the sleeper train and went straight to work [19:35:41] multichill: yea... didn't really take a break either. actually, coding feels good now, my head is so full. lots of things to wrap up. [19:35:58] multichill: i really want this to go in soon: https://gerrit.wikimedia.org/r/#/c/132710/ [19:36:07] grew a lot though, so it might take a while... [19:36:13] Already quite a few follow ups. One of the things we're considering is to do a localish hackathon again in the Netherlands. Probably somewhere in November [19:36:39] i just might come :P [19:37:04] Would be nice to combine it with some of the product team meet ups [19:37:15] And of course you guys would be invited [20:17:18] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133155 (owner: 10L10n-bot) [20:19:07] (03PS1) 10Hoo man: Catch EntityIdParsingExceptions in wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) [20:24:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) (owner: 10Hoo man) [20:26:51] (03CR) 10Aude: "abuse of ValueValidators *is* related, as we're only making the situation worse." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [20:28:12] aude: Easy-peasy code review: https://gerrit.wikimedia.org/r/133160 [20:28:18] :) [20:33:16] how difficult would it be to have tests cover that? [20:38:11] (03CR) 10Aude: "how did we miss this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) (owner: 10Hoo man) [22:09:39] (03PS1) 10Hoo man: Avoid SiteSQLStore::newInstance and the deprecated Sites class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133179 (https://bugzilla.wikimedia.org/64743) [22:14:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133179 (https://bugzilla.wikimedia.org/64743) (owner: 10Hoo man) [22:16:44] (03PS2) 10Hoo man: Avoid SiteSQLStore::newInstance and the deprecated Sites class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133179 (https://bugzilla.wikimedia.org/64743) [22:22:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133179 (https://bugzilla.wikimedia.org/64743) (owner: 10Hoo man) [22:44:56] (03PS2) 10Hoo man: Catch EntityIdParsingExceptions in wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) [22:48:08] (03CR) 10Hoo man: "Added tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) (owner: 10Hoo man) [22:50:39] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) (owner: 10Hoo man) [22:57:21] (03PS3) 10Hoo man: Catch EntityIdParsingExceptions in wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) [23:03:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) (owner: 10Hoo man) [23:15:30] (03PS4) 10Hoo man: Catch EntityIdParsingExceptions in wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) [23:21:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) (owner: 10Hoo man) [23:22:47] (03PS5) 10Hoo man: Catch EntityIdParsingExceptions in wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) [23:28:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133160 (https://bugzilla.wikimedia.org/65095) (owner: 10Hoo man)