[05:39:09] [13WikibaseDatabase] 15nemobis opened pull request #47: Make deprecation a header (06master...06patch-1) 02http://git.io/x_0seQ [08:17:04] (03CR) 10Aude: [C: 032] "looks ok and per wishes of Lydia" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131692 (owner: 10Thiemo Mättig (WMDE)) [08:17:25] (03Merged) 10jenkins-bot: Remove non-working help URLs from all Wikibase API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131692 (owner: 10Thiemo Mättig (WMDE)) [08:44:15] Lydia_WMDE: hey! I just looked over the new sprint... not much new things there for me. probably a good thing, since i'm busy fianlly getting EntityContent ready for redirects. however, there are quite a few small things that would really help if we could address them soonish. [08:44:46] Lydia_WMDE: it's like paper cuts from the programmer's side. Look at the bugs I files, which are still "NEW": https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&list_id=312227&namedcmd=open%20filed [08:45:06] quite a few of the recent ones are like that. [09:25:13] DanielK_WMDE: maybe the rdf stuff? [09:25:42] now that we have more people interested in using it [09:27:24] Hi ! I try to install wikibase, but am stuck at the step "Then run php maintenance/update.php" [09:27:43] I get "PHP Fatal error: Class 'Wikibase\TemplateRegistry' not found" [09:27:52] olivd: you need to run composer install [09:28:48] ok I tried from the repo, I'll try again then [09:28:55] ok [09:29:07] I don't like this line in the suggested composer.json : "prefer-stable": false [09:29:19] is it ok to set to false ? [09:29:24] *true [09:29:32] hmmm, well everything is very much under development [09:29:56] where do you see the line? [09:30:13] http://www.mediawiki.org/wiki/Wikibase/Installation [09:30:36] ok [09:30:49] i don't know if it needs to be false [09:30:54] try with true [09:31:11] (I'm a bit onfused about the installation process, my goal is to install the same version that runs wikidata [09:32:58] we make a branch of wikibase every ~2 weeks [09:34:32] then run compsoer install [09:34:38] if you dont want to use master, you can use latest deployment branch 'mw1.24-wmf2' [09:34:41] err [09:34:57] or you can use the WikidataBuild which has composer stuff pre-installed [09:42:07] ok, and I guess I have to install client as well ? Or what is client good for ? [09:42:55] you don't, unless you want to connect additional wikis to the repo or want the lua / parser function to access data on wiki pages [09:43:28] to "connect additional wikis", that means installing wikibase client on those wikis and then some configuration [09:44:31] ok [09:44:38] (thanks for helping me out ;) ) [09:51:35] ok it seems it has installed, but I don't see anything changed on the mediawiki main page, I guess I must run some script [10:00:26] (03PS1) 10WikidataBuilder: New Wikidata Build - 07/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131948 [10:09:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131948 (owner: 10WikidataBuilder) [10:09:33] olivd: you need to configure the namespaces (e.g. wher eitems go) [10:09:36] where* [10:10:23] https://www.mediawiki.org/wiki/Extension:Wikibase_Repo#Setting_up_items_in_the_main_namespace [10:14:30] ok does this go into localSettings.php ? [10:14:36] yes [10:14:43] you choose where you want items to be [10:15:13] if you choose main namespace, then you might want to move the main page to "Project:Main Page" or somewhere [10:15:39] then set MediaWiki:mainpage to Project:Main Page so that clicking on the logo etc. takes you there [10:15:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf4/b88e7ae : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24611996 [10:16:02] e.g. https://www.wikidata.org/wiki/MediaWiki:Mainpage [10:16:30] also, take a look at example settings (in repo/config) [10:19:22] :( i don't get it at all [10:19:27] :( [10:19:33] maybe I'll have to find something simpler [10:19:53] probably using the example settings will work for most, if not everything [10:20:16] we use them when running tests etc. [10:24:01] (03PS1) 10Aude: Add .gitreview file [extensions/Wikidata] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/131950 [10:25:18] I must go, I'll have to investigate further another time [10:25:33] ok [10:25:37] Maybe it would be a nice idea to have a "getting started" tutorial or something [10:25:44] yeah [10:25:49] I feel completely lost despite your help :( [10:26:01] i realize our documentation lacks and it's something we want to improve [10:26:26] it helps to see where it's confusing [10:28:03] I dont get what to do with the ExampleSettings.php file (which anyway I wouldn't have found without looking for it) [10:28:43] https://github.com/wikimedia/mediawiki-extensions-Wikidata talks only about adding lines to LocalSettings.php [10:29:17] then only says what won't work about maintenance scripts, but not what to do to make them work nor what scripts actually must be run (and how) [10:30:18] ok now i must go [10:30:25] thanks for your help anyways ! [10:30:26] ok [10:31:27] see you [10:32:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf4) - 10https://gerrit.wikimedia.org/r/131950 (owner: 10Aude) [10:33:20] (03CR) 10Aude: [C: 032] New Wikidata Build - 07/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131948 (owner: 10WikidataBuilder) [10:38:19] (03Merged) 10jenkins-bot: New Wikidata Build - 07/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131948 (owner: 10WikidataBuilder) [10:40:01] [13WikibaseDatabase] 15addshore pushed 2 new commits to 06master: 02http://git.io/eS7lww [10:40:01] 13WikibaseDatabase/06master 142197a71 15nemobis: Make deprecation a header... [10:40:01] 13WikibaseDatabase/06master 14e5d6778 15addshore: Merge pull request #47 from nemobis/patch-1... [10:40:48] [13Diff] 15addshore pushed 1 new commit to 06master: 02http://git.io/C0H50g [10:40:48] 13Diff/06master 148e5f866 15addshore: Merge pull request #10 from wmde/evili18n... [10:46:03] evil [10:58:05] (03CR) 10Tobias Gritschacher: [C: 032] Fix typo in WikibaseRepo::getMessageParameterFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131906 (owner: 10Aude) [10:58:24] (03Merged) 10jenkins-bot: Fix typo in WikibaseRepo::getMessageParameterFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131906 (owner: 10Aude) [11:04:52] [13WikibaseDataModel] 15thiemowmde comment on pull request #85 145fbf563: I find this name very strange. What "fields"? Should be something like `equalsProperty`. But since this is private this is no reason to block this pull request. 02http://git.io/W1b7gw [11:21:18] (03Draft3) 10Aude: Rename namespace (i18n -> Internationalisation) for ExceptionLocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 [11:26:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [11:33:59] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Hm. Is this worth the trouble? Lib is going to die anyway, right? "i18n" is a very common abreviation. No other code uses "Internationaliz" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [11:36:36] (03CR) 10Aude: "it's technically allowed to have lowercase namespaces but normally are uppercase (and better to be consistent, imho)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [11:38:32] (03CR) 10Aude: "it was a mistake to merge the ExceptionLocalizer code like this and regret not -1 for this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [11:39:52] [13WikibaseDataModel] 15thiemowmde comment on pull request #84 141fd8c15: All other `...Differ` classes we have in the code base extend the `Differ` interface. Shouldn't this class do the same? Or have a slightly other name? 02http://git.io/cM7pMA [11:44:37] (03CR) 10Aude: Handle mismatching data type / values in snak formatter (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 (https://bugzilla.wikimedia.org/63299) (owner: 10Aude) [11:45:15] (03Abandoned) 10Aude: Handle mismatching data type / values in snak formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131665 (https://bugzilla.wikimedia.org/63299) (owner: 10Aude) [11:50:58] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131948 (owner: 10WikidataBuilder) [11:54:04] DanielK_WMDE: can you answer hooman's question on https://bugzilla.wikimedia.org/show_bug.cgi?id=64600 ? [11:56:55] (03PS1) 10Aude: Add WikibaseRepoExceptionLocalizer for repo-specific handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131955 [11:58:41] * aude thinks only secondary updates need to be done  [11:59:25] would make more comfortable to run such script (as well as with option to specify which updates to do, if we don't want to do all) [12:00:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131955 (owner: 10Aude) [12:01:26] aude: can you comment on the bug? [12:01:31] so hoo knows [12:01:36] did [12:01:51] things like null edits mean bazillion CirrusSearch updates [12:02:38] making it more fine grained to do just secondary updates and if possible, which ones (or maybe exclude specific ones) is best [12:04:45] (03PS2) 10Aude: Add WikibaseRepoExceptionLocalizer for repo-specific handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131955 (https://bugzilla.wikimedia.org/64995) [12:05:33] DanielK_WMDE: sorry - only now getting to read irc backlog - crazy day... Yes didn't add anything to the sprint on purpose. If there is free time left we can surely add some of those [12:08:16] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131955 (https://bugzilla.wikimedia.org/64995) (owner: 10Aude) [12:10:22] (03PS3) 10Aude: Add WikibaseRepoExceptionLocalizer for repo-specific handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131955 (https://bugzilla.wikimedia.org/64995) [12:13:13] Lydia_WMDE: ok... should i just trust that the bugs i filed will get triaged, or should we look at them together some time? [12:14:12] DanielK_WMDE: let's take a look at them together [12:15:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131955 (https://bugzilla.wikimedia.org/64995) (owner: 10Aude) [12:32:51] bah. there is so much crap code related to EntityContent, I keep getting side tracked. [12:33:29] will now try top down (remove functionality, fix breakage) instead of bottom up (reduce usage until bad stuff is gone). [12:34:31] DanielK_WMDE: there is a mess in the formatters, using EntityTitleLookup [12:34:45] and in turn, mess in ExceptionLocalizer because that uses formatters [12:35:03] [13DataTypes] 15tobijat pushed 1 new commit to 06master: 02http://git.io/7rOekw [12:35:03] 13DataTypes/06master 14fe0520c 15Tobi Gritschacher: Bump version 0.2.1 [12:35:07] https://gerrit.wikimedia.org/r/#/c/131955/ is one step to sort the mess [12:35:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=64965 [12:36:09] and then odd that MessageParameterFormatter is a ValueFormatter [12:36:55] [13DataTypes] 15tobijat pushed 1 new commit to 06master: 02http://git.io/6p5bTg [12:36:55] 13DataTypes/06master 14fced7ce 15Tobi Gritschacher: Bump version 0.2.1 [12:37:12] aude: the title lookup is only needed to generate HTML links from entity IDs. [12:37:27] i was poking at making use titlevalue [12:37:28] [13DataTypes] 15tobijat tagged 060.2.1 at 06master: 02http://git.io/74kiNw [12:37:41] aude: the localizer should probably use a "dumber" formatter to generate HTML for entities. [12:37:57] yea, TitleValue would be nice, but that's a pretty big change. [12:38:01] it is! [12:38:08] and probably not currently completely doable [12:38:21] using titlevalue one the client doesn't work, though [12:38:29] controlling which html formatter is used for entity ids in error parameters is probably easier. [12:39:41] no, it doesn't work, because MediaWikiTitleCodec still relies on Linker, and thus Title, internally [12:39:47] right [12:40:14] we should have entityid formatter implementation for the client [12:40:39] and not base this stuff so much on ValueFormatters (EntityId !instanceof ValueFormatter) [12:40:46] err DataValue [12:41:30] aude: the ValueFormatter interface does *not* specify that it is for DataValue only. it'S agnostic. [12:41:34] but yea, it's a bit messy [12:41:46] aude: look at MessageParameterFormatter [12:41:49] wrong [12:41:55] valueformatter is wrong [12:41:59] there you have an opportunity to control/override formatting of entity IDs. [12:42:25] [travis-ci] wmde/DataTypes/0.2.1/fced7ce : Tobi Gritschacher The build passed. http://travis-ci.org/wmde/DataTypes/builds/24620955 [12:42:30] then there should be an interface and then repo / client implementations [12:42:32] either by special cases in the class, or by controlling the DispatchingValueFormatter that is provided to its constructor [12:43:14] needs a bit of sorting out [12:43:20] it'S true that the formatter factory should return different things on the client in some cases [12:43:29] mostly, we only render to wikitext on the client, then there is no problem [12:43:46] only if we try to generate html directly, and rely on Title for doing so, things break. [12:43:57] if we are misusing valueformatters for EntityId objects, then we do more formatting in the client [12:44:14] actually, you could implement EntityTitleLookup for the client, returning Title objects with the appropriate interwiki component [12:44:16] more potential use of EntityIdFormatters [12:44:23] not the worst solution eith [12:44:50] and namespace ids? [12:45:10] ignore for interwiki links [12:45:16] you just need the namespace names [12:45:20] ok [12:45:27] icky, but an option [12:45:33] but... [12:46:02] aude: can you tell me when exactly the EntityTitleLookup gets used via the ExceptionLocalizer? [12:46:37] because it seems that he ExceptionLocalizer is actually returning wikitext [12:46:49] so no titles used [12:46:58] it gets used twice [12:47:09] how/where exactly? what'S the stack trace? [12:47:22] $this->getValueFormatterBuilders(); [12:47:23] hm, the wikitext isn't valid on the client, sicne it uses local links... [12:47:33] we need the builders to make valueFormattesr [12:47:42] then new DispatchingValueFormatter( $valueFormatters ), [12:47:55] entitytitlelookup is used for valueformatterbuilders [12:48:00] I guess we just need different builders for the client [12:48:02] that's it. [12:48:10] in addition to passing $this->getEntityTitleLookup(), directly [12:48:16] (03CR) 10Thiemo Mättig (WMDE): "Sorry, but I don't think this is more consistent than keeping the "i18n":" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [12:48:18] and additional formatters [12:49:18] oh right, it's being used directly. [12:49:35] as a quick fix, just remove the link. output the id unlinked. [12:49:37] done. [12:49:47] gag [12:49:48] gah [12:49:50] there should be a big TODO there & a bug filed for finding a better way to do this [12:49:54] but for now, that should fix it [12:50:13] hm... actually... much better... [12:50:24] i prefer to move it to the repo [12:50:41] but we need it on the client [12:50:46] we need to localize errors [12:50:47] formatters are only used for ChangeOpException [12:50:53] no we don't [12:51:20] ...then how are you even encountering the problem? [12:51:29] * aude rage [12:51:39] Actually, MessageParameterFormatter sahould take an EntityIdFormatter, not an EntityTitleLookup in the constructor. [12:51:53] (and EntityIdFormatter should be an interface) [12:51:57] why are we handling ChangeOpException in Lib? [12:51:59] that would give us full control [12:52:18] aude: because lib is a mess [12:52:24] wrong [12:52:27] wrong place [12:52:33] no excuse [12:53:13] hehe [12:53:27] initial step is to sort out what is repo specific and what is not [12:53:44] then step by step, the other things [12:54:04] aude: in the ExceptionLocalizer? yea. I suggest to use a handler/register mechanism instead of sublcassing, though. [12:54:19] hmmm [12:54:23] Basically, the "master" localizer would delegate to specialized localizers based on exception type [12:54:36] repo and client can then register the handlers relevant to them [12:54:56] then we have ChangeOpExceptionLocalizer? [12:55:07] and colony of such classes? [12:55:17] yes. [12:55:19] ok [12:55:27] well, doesn't have to be one class per exception class [12:55:49] (03CR) 10Aude: [C: 04-1] Move term validation into ChangeOps (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [12:56:33] aude: ExceptionLocalizer::hasExceptionMessage allows us to just ask all the localizers if they can handle a given exception. a single localizer could handle any number of exceptions, if it makes sense to group them like this. [12:57:08] splitting the ExceptionLocalizer, together with passing a formatter into the MessageParameterLocalizer, should help a lot, and it'S not a terrible lot of work [12:57:09] (03CR) 10Aude: "all those namings are legacy, not how we do things now, and should be moved to be uppercase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [12:57:12] it'S pretty self-contained [12:58:24] DanielK_WMDE: shall try [13:02:32] I wonder what's better tomorrow... leave early and hang out in Zürich, or hang out at home a bit and then arrive in Zürich later on [13:02:49] will the weather be nice? [13:03:20] aude: No, ok at best, it seems [13:03:23] if ( $weather = nice ) then early (and walk around) [13:03:29] else late :) [13:03:47] pretty mixed. sun, cloud, a little rain... [13:03:58] not hot, not cold... [13:04:09] it's rarely hot [13:04:16] esp. in may [13:04:55] I think I'll leave at 11:30, and then I'll be in Zürich at 4pm [13:05:11] i'm sure lots of people will already arrive then [13:05:26] * aude staying for the boat ride on sunday [13:05:35] Yeah, probably... I could also go much earlier, but I'm not good at getting up early :P [13:05:53] heh [13:05:54] aude: Oh... when is that? Couldn't find a real schedule on mediawiki.org [13:05:59] sunday evening [13:06:06] May 11: [13:06:07] tba. [13:06:07] Closing [13:06:11] not that helpful [13:06:19] note that your transportation pass includes the ferry on lake [13:06:24] if you want boat ride another time [13:07:14] ah https://www.mediawiki.org/wiki/Z%C3%BCrich_Hackathon_2014/Schedule [13:07:21] oh, till 20:35 [13:08:17] I don't have a hostel room for Sunday -> Monday, so I have to leave on Sunday :( [13:08:23] :( [13:09:19] If I leave from Zürich main station at 5pm, I'll be at home around 10pm [13:09:55] hopefully I wont miss the group photo this time... like I did last year (cause I also left early) [13:46:17] my return flight is at 20:45 on sunday. so i also won't make the boat ride i think. [13:47:06] I guess hardly anyone leaving on Sunday will :/ [13:47:33] hoo: i'll arrive at 4 as well. Was thinking of leaving my stuff at the trainstation and biking around a bit of zurich. then go to hostel at 9'ish or something [13:48:29] mh, depends on the wheather [13:48:32] * weather [13:48:35] not sure if their trainstation locker fare is manageable. otherwise i'll have to drop stuff at the hostel first [13:48:39] that too :) [13:50:00] google says it will be decent [13:50:09] weather that is [13:50:59] nice :) I think about going around the town also, but not alone [13:52:10] * aude loves zurich but it's so expensive [13:52:19] free stuff like walking around and boat ride is what i do [13:54:35] aude: bike rental is also free in zurich apparently [13:54:40] free? [13:54:45] impossible :P [13:55:01] it is [13:55:05] https://www.stadt-zuerich.ch/aoz/de/index/shop/veloverleih/standorte.html [13:55:38] but yeah .ch is so expensive... [13:55:40] things like doner kebab are like 12 euros [13:55:46] in berlin, 2 euros [13:56:19] 12€ oO [13:56:29] I knew it was expensive... but that expensive, wow [13:56:36] 20 euros for a restaurant is cheap [13:57:01] * aude shall eat at hostel [13:57:08] yup, me too. [13:58:04] aude: 20€ in the hostel? [13:58:15] That sounds decent, if even a Döner is 12€ [13:58:18] hostel is included for us [13:58:25] \o/ [13:58:44] but normally i think costs about that much or maybe 15 euros (thus is good) [13:59:41] * thedj looks for his label printer [14:06:02] thedj: Do you know the time you'll arrive in Zurich? [14:07:42] On the train station, i mean [14:16:18] flight arrives at 14:40, so should be at the trains station no later than about 15:30 i guess [14:16:59] (03PS1) 10Daniel Kinzler: Move ID assignment to EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131978 (https://bugzilla.wikimedia.org/62493) [14:18:38] earlier than, me, probably... I guess I'll first head to the hostel and see who's around there [14:19:20] sure there will be lots of folks [14:19:59] if coming from the US, flights always arrive early in the morning [14:20:03] usually* [14:21:08] i'll be online once in a while anyway, i have my EU discount bundle activated. /me anticipates a big google hangout [14:21:59] mh, I'll no longer have internet once I've crossed the border :/ [14:22:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131978 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [14:22:28] rage [14:23:06] aude: ? [14:23:20] no internet [14:23:29] evil mobile companies [14:23:45] they are supposed to eliminate the nonsense at end of the year [14:24:13] will that also be the case for data flat rates? [14:24:19] think so [14:24:39] it's not enough but i now get 25 mb free / day [14:24:45] that would be great... always a bummer to loose connectivity once leaving Germany [14:24:49] then can buy more or get sim card [14:25:06] mh... I don't think I get that... is that mandatory for the ISP? [14:25:13] and my french sim card continued to work all day in spain [14:25:20] no idea [14:25:22] but I haven't been in another EU contry than Germany since October [14:25:30] might have changed [14:25:37] 25 mb is newish [14:25:45] i used to have to pay for the first 25 mb [14:26:45] i have 30mb free a day, then 30mb for 2 euro a day and then € 0.54 /MB [14:27:00] i can keep buying another 25 mb [14:27:07] that used to not be possible [14:27:41] so depends how many days i am in ch (and fact we have wifi at the venue), on if it makes sense to get local sim [14:28:09] I hope that the Wifi is stable this year... unlike last year [14:28:16] hope so [14:28:26] Just send an email to Manuel... maybe I can stay until Monday [14:28:34] yay [14:34:29] i am not convinced my mobile company is charging even when i agree to buy more megabytes [14:34:41] they might be included [14:35:14] hard to tell [14:54:41] (03PS4) 10Aude: Rename namespace (i18n -> Internationalisation) for ExceptionLocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 [14:55:43] (03PS5) 10Aude: Rename namespace (i18n -> Localizer) for ExceptionLocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 [15:01:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [15:04:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [15:08:53] (03Abandoned) 10Aude: Add WikibaseRepoExceptionLocalizer for repo-specific handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131955 (https://bugzilla.wikimedia.org/64995) (owner: 10Aude) [15:18:03] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Only small stuff and a few questions. Almost ready to merge, yea!" (0321 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [15:25:26] (03CR) 10Aude: Move term validation into ChangeOps (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [15:26:55] (03CR) 10Aude: [C: 032] Remove no longer needed b/c from UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131313 (owner: 10Hoo man) [15:28:04] (03Merged) 10jenkins-bot: Remove no longer needed b/c from UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131313 (owner: 10Hoo man) [15:34:11] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "This looks good overall. It's just a bit confusing, for example some applyChangeOp() calls are replaced with apply() and some apply() call" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [15:37:27] (03CR) 10Daniel Kinzler: "@Thiemo: apply() should be called on instances of ChangeOp or ChangeOps, while applyChangeOp(s) would take such an object as the first par" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [15:53:44] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Thanks, this feels better. You know there is a reason everybody uses i18n instead of internaitonalisaizon. ;-)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131903 (owner: 10Aude) [15:59:02] (03CR) 10Daniel Kinzler: Move term validation into ChangeOps (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [16:14:51] (03PS1) 10Daniel Kinzler: Removing EntityContent::save [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131989 (https://bugzilla.wikimedia.org/62493) [16:19:03] (03PS2) 10Daniel Kinzler: Removing EntityContent::save [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131989 (https://bugzilla.wikimedia.org/62493) [16:21:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131989 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [16:23:58] aude: You're not leaving on Sunday with the others from WMDE or do you have a very late flight? :P [16:25:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131989 (https://bugzilla.wikimedia.org/62493) (owner: 10Daniel Kinzler) [16:30:34] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #84 141fd8c15: It diffs two things, so Differ seems like the obvious name. If you have a better suggestion...... 02http://git.io/QWAH2g [16:31:31] (03CR) 10Thiemo Mättig (WMDE): "> apply() should be called on instances of ChangeOp or ChangeOps, while applyChangeOp(s) would take such an object as the first parameter." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [16:33:39] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #85 145fbf563: The `equals` method does a full equality check, and this method does the field comparison part of that task. This naming is driven by that division, where `equalsProperty` is based more on the method signature difference. Both are fine IMO, though since this is private, and only there to split the `equals` method, I prefer the current name. 02http://git.io/BkEt_Q [16:33:59] [13Diff] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_5enmg [16:33:59] 13Diff/06master 1470a1ca3 15Jeroen De Dauw: Update RELEASE-NOTES.md [16:36:08] [13Diff] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/9ZpmCg [16:36:08] 13Diff/06master 1407f23a7 15jeroendedauw: 1.0.1 release [16:37:18] [13Diff] 15JeroenDeDauw tagged 061.0.1 at 06master: 02http://git.io/KdvUZQ [16:40:54] (03CR) 10Daniel Kinzler: "if you call apply() directly, you bypass validation. I'm not sure how that can be avoided." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [16:46:55] aude: Got the room until Monday :) So I can stick around as long as I want on Sunday (and don't have to leave at 3pm) [17:05:57] Lydia_WMDE: haha, so jQuery can't follow semver apparently, doing the same versioning schema as MW :) [17:06:44] JeroenDeDauw: There's a jQuery 2, but it breaks IE8 compat. [17:10:57] aude: mergeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee [17:13:18] Lydia_WMDE: well, I have to go now ;p [17:13:31] JeroenDeDauw: sorry :/ still in call [20:03:41] (03CR) 10Daniel Kinzler: (bug 64309) Introducing ChangeOp::validate (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [20:08:20] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132094 (owner: 10L10n-bot) [20:16:56] (03PS16) 10Daniel Kinzler: Move term validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) [20:17:29] (03PS6) 10Daniel Kinzler: (bug 64309) Introducing ChangeOp::validate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 [20:23:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (https://bugzilla.wikimedia.org/62643) (owner: 10Daniel Kinzler) [20:28:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [21:48:26] (03PS1) 10Hoo man: Fix selector for linkitem init [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132116 (https://bugzilla.wikimedia.org/65001) [21:55:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132116 (https://bugzilla.wikimedia.org/65001) (owner: 10Hoo man)