[01:14:41] * jeremyb goes to hit up the FAQ [01:18:37] ok, FAQ didn't answer [01:18:58] * jeremyb moves on to https://www.wikidata.org/wiki/Wikidata:Status_updates [01:22:49] so... phase 2 == infoboxes [01:23:11] which means essentially i can ask for property X for the current page? [01:24:41] * jeremyb has been thinking about how damn many different places we have birth / death // date / place duplicated [01:25:58] maybe some langs are more sane. the cases i was looking at are enwiki for hurricane carter and a commons cat for a person (which includes that person into cats for people born in year X, died in year X) [01:26:22] anyway, bbl :) [02:06:27] hey, anybody around who knows things about contenthandler? [02:06:31] aude, perhaps? [06:35:18] werdna: you want to email i think. too early [06:35:24] wikitech-l [08:13:48] (03PS10) 10Aude: Improve badge handling in SpecialSetSiteLink, using ExceptionLocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131023 (https://bugzilla.wikimedia.org/63391) [08:14:17] (03CR) 10jenkins-bot: [V: 04-1] Improve badge handling in SpecialSetSiteLink, using ExceptionLocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131023 (https://bugzilla.wikimedia.org/63391) (owner: 10Aude) [08:17:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131023 (https://bugzilla.wikimedia.org/63391) (owner: 10Aude) [08:22:50] (03PS11) 10Aude: Improve badge handling in SpecialSetSiteLink, using ExceptionLocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131023 (https://bugzilla.wikimedia.org/63391) [08:28:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131023 (https://bugzilla.wikimedia.org/63391) (owner: 10Aude) [08:59:40] (03CR) 10Daniel Kinzler: Handle JobQueueGroup::push throwing MWException (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [09:17:48] (03CR) 10Hoo man: "I didn't want to catch \Exception, as that seemed to generic. If you want, I can of course do that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [09:19:30] (03CR) 10Daniel Kinzler: [C: 04-1] "potential double escaping issue" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [09:21:45] aude: Could you please have a quick look at https://gerrit.wikimedia.org/r/131410 and say, whether the approach is ok to you? [09:23:11] (03CR) 10Daniel Kinzler: "or catch RuntimeException and MWException." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [09:25:06] Lydia_WMDE: aude is not around today, is she? [09:25:13] hoo: She is [09:25:36] mh ok... because he IRC is idle for 43 hours [09:26:03] hoo: she is sitting on the other side of my table ;-) [09:26:11] want me to ping her? [09:26:19] Lydia_WMDE: Would be nice :) [09:26:26] k [09:26:47] * aude waves :) [09:26:54] hi aude :) [09:27:49] aude: https://gerrit.wikimedia.org/r/131410 is the approach here ok? I wondered why the error output was deferred, but couldn't find a reason [09:29:57] it would be good to do something with the error messages, but agree the existing approach is not good [09:30:40] * aude doesn't know the best approach [09:31:23] (03CR) 10Daniel Kinzler: Introducing EntityConstraintProvider (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 (owner: 10Daniel Kinzler) [09:31:36] (03CR) 10Aude: [WIP] Don't defer error reporting in the parser functions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [09:32:29] aude: Wondered about that also... the class is only used there and could easily be killed. [09:32:41] agree [09:32:45] hoo: the reason was to return "" from the hook in the error case, so it could be used with {{#if:...}} [09:33:02] if you return the error message inline, it would be handled as "we have a value there". [09:33:22] but i have come around to preferring that over the deferred approach. [09:34:16] hoo, aude: returning "" kind of makes sense for the original error cases: no such property, can't load entity, no entity connected. [09:34:27] for "bad" values, etc, it doesn't really make sense [09:34:34] so... let's always return it inline. as wikitext [09:35:17] DanielK_WMDE__: The bug I'm trying to handle is about {{#iferror which needs that inline error [09:36:40] hoo: i didn't even know iferror existed :P how does it even detect an error? [09:36:47] it's in ParserFunctions [09:37:02] DanielK_WMDE__: greps for an element with class="error" [09:37:04] yes, really [09:37:04] oh, gah [09:37:10] * aude looks at the code :o [09:37:10] yay :P [09:37:38] if ( preg_match( '/<(?:strong|span|p|div)\s(?:[^\s>]*\s+)*?class="(?:[^"\s>]*\s+)*?error(?:\s[^">]*)?"/', $test ) ) { [09:37:41] i suppose if that's the preferred way of handling errors, then ok [09:37:45] * aude cringes [09:38:13] would be nice if the preprocessor had a notion of parser functiosn throwing exceptions. [09:38:18] wouldn't that be pretty?... [09:38:58] I thought it was done that way... but after looking at the actual code, I was mercilessly thrown back into reality [09:42:41] (03CR) 10Aude: Improve badge handling in SpecialSetSiteLink, using ExceptionLocalizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131023 (https://bugzilla.wikimedia.org/63391) (owner: 10Aude) [09:44:08] Lydia_WMDE: When will you all arrive in Zürich? On Thursday afternoon? [09:44:28] Lydia_WMDE, Tobi_WMDE, aude: i'm online for the daily [09:44:50] DanielK_WMDE__: coming :) [09:44:50] hoo: night [09:45:15] Ok, I'll be there by 9 or 10pm I guess... [09:45:25] not leaving early [10:00:23] (03PS1) 10WikidataBuilder: New Wikidata Build - 05/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131440 [10:05:04] Lydia_WMDE: stream froze again. i guess we were about done anyway, right? [10:06:15] DanielK_WMDE__: bah yes [10:06:16] reconnecting [10:07:30] (03PS3) 10Hoo man: Handle JobQueueGroup::push throwing MWException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 [10:08:24] (03PS4) 10Hoo man: Handle JobQueueGroup::push throwing MWException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 [10:09:03] (03CR) 10Hoo man: "Catch both MWException and RuntimeException now (per Daniel)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [10:09:15] DanielK_WMDE__: we really need to use another computer for next time... -.- [10:15:07] (03PS1) 10Aude: Specify phpunit version 3.7 for travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131442 [10:15:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131440 (owner: 10WikidataBuilder) [10:15:54] aude: did you test that? (The phpunit patch)? [10:15:58] oh my, your all at work! Its a bank holiday over here :P [10:16:05] :P [10:16:12] (03CR) 10Aude: "I would prefer to fix mediawiki to support 4.0 and not have to do this, but this allows us not to be blocked" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131442 (owner: 10Aude) [10:16:16] hoo: yes on my github [10:16:37] https://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase [10:16:46] :) [10:16:54] (03CR) 10Hoo man: [C: 032] Specify phpunit version 3.7 for travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131442 (owner: 10Aude) [10:17:01] so we still have ClientSiteLinkLookupTest failing there [10:17:08] the lua ones seem fixed [10:17:10] (03Abandoned) 10Addshore: New Wikidata Build - 02/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131037 (owner: 10WikidataBuilder) [10:17:12] (03Merged) 10jenkins-bot: Specify phpunit version 3.7 for travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131442 (owner: 10Aude) [10:17:26] (03Abandoned) 10Addshore: New Wikidata Build - 04/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131332 (owner: 10WikidataBuilder) [10:17:27] i think it's SiteSQLStore::newInstance() being used some place [10:17:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [10:18:40] hmmm, not sure about that [10:18:43] (03CR) 10Addshore: [C: 032] New Wikidata Build - 05/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131440 (owner: 10WikidataBuilder) [10:23:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [10:25:01] (03PS2) 10Hoo man: Don't defer error reporting in the parser functions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) [10:25:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b67f323 : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24441434 [10:25:59] (03CR) 10Hoo man: "Amended per Katie and Daniel" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [10:28:32] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=64873 and https://bugzilla.wikimedia.org/show_bug.cgi?id=64874 [10:29:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131442 (owner: 10Aude) [10:32:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [10:41:57] (03CR) 10Daniel Kinzler: [C: 04-1] "please add a test case that checks for the error being returned in the right form." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [10:43:07] (03CR) 10Daniel Kinzler: [C: 032] Handle JobQueueGroup::push throwing MWException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [10:43:25] (03Merged) 10jenkins-bot: Handle JobQueueGroup::push throwing MWException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131314 (owner: 10Hoo man) [10:51:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/3855b87 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24442508 [11:22:05] https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions - admins, 500+ RFDs.... [11:31:07] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/131440 (owner: 10WikidataBuilder) [11:37:34] (03PS2) 10Aude: i18n: consistency tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131340 (owner: 10Shirayuki) [11:40:26] DanielK_WMDE__: thx [11:42:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131340 (owner: 10Shirayuki) [11:43:03] (03CR) 10Aude: [C: 032] i18n: consistency tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131340 (owner: 10Shirayuki) [11:44:11] fyi AutoList understands bots and it edits as a bot when it knows that a user is a bit [11:44:12] bot [11:44:15] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131340 (owner: 10Shirayuki) [11:55:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/dcc2e68 : Yuki Shira The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24445740 [15:37:32] Hey dear wikidata-friends! [15:49:30] Who broke my workflow :-( [15:49:35] * twkozlowski cries [15:54:39] help :-( [16:02:52] Sorry! This site is experiencing technical difficulties. [16:03:14] Try waiting a few minutes and reloading. [16:03:15] (Cannot contact the database server: Too many connections (10.64.16.10)) [16:03:38] what??? [16:04:50] aude: ? [16:10:30] now [16:10:31] ? [16:10:43] looks good to me [16:10:55] probably the same thing we saw some time back [16:16:19] wee! [16:16:28] * twkozlowski just broke 5,000 edits on Wikidata [16:17:02] On this happy occasion, how do I /un/break https://www.wikidata.org/w/index.php?title=Q55678&diff=121175552&oldid=121174550 ? [16:19:54] twkozlowski: < 9000 [16:20:08] ? [16:20:23] 5000 is not over 9000 :( [16:20:51] I didn't say it is... [16:21:05] twkozlowski: guess you are not getting the joke :) [16:21:29] Not really, no... [16:22:22] twkozlowski: http://knowyourmeme.com/memes/its-over-9000 [16:22:28] yay! I got rid of the evil MediaWikiPHPUnitCommand class :D [16:23:34] addshore: rm -rf MediaWiki* [16:24:17] JeroenDeDauw: Never watched DragonBall, though many people in my grammar school did [16:24:28] That was before the era of satellite TV, so :-( [16:25:09] twkozlowski: well, it started as a DargonBall thing, now it's one of those interwebs memes that won't die [16:25:42] Well, it does seem funny :) [16:25:49] Lydia_WMDE: re https://bugzilla.wikimedia.org/show_bug.cgi?id=64895 I could do that right now if my commit had gotten merged! Looks like no one even reviewed it? :( [16:26:29] JeroenDeDauw: i did mention it several times in the daily today [16:26:34] will again tomorrow [16:41:08] (03PS3) 10Hoo man: Don't defer error reporting in the parser functions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) [16:42:14] (03PS4) 10Hoo man: Don't defer error reporting in the parser functions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) [16:42:33] (03CR) 10Hoo man: "Added a test for the error reporting" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [16:48:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [16:51:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131410 (https://bugzilla.wikimedia.org/55347) (owner: 10Hoo man) [17:03:37] [13WikibaseDataModel] 15JeroenDeDauw created 06rmd (+1 new commit): 02http://git.io/FkV2jw [17:03:37] 13WikibaseDataModel/06rmd 140bb18b0 15jeroendedauw: Remove long deprecated Entity::getIdFromClaimGuid [17:03:47] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #81: Remove long deprecated Entity::getIdFromClaimGuid (06master...06rmd) 02http://git.io/VEkzOg [17:06:05] [13WikibaseDataModel] 15JeroenDeDauw created 06entityid (+1 new commit): 02http://git.io/94_KTA [17:06:05] 13WikibaseDataModel/06entityid 141865ffe 15jeroendedauw: Removed long deprecated EntityId::newFromPrefixedId [17:06:13] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #82: Removed long deprecated EntityId::newFromPrefixedId (06master...06entityid) 02http://git.io/0rusfg [17:07:42] [13WikibaseDataModel] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/9BKTgQ [17:07:42] 13WikibaseDataModel/06master 141865ffe 15jeroendedauw: Removed long deprecated EntityId::newFromPrefixedId [17:07:42] 13WikibaseDataModel/06master 14f6a18c3 15Marius Hoch: Merge pull request #82 from wmde/entityid... [17:08:35] [travis-ci] wmde/WikibaseDataModel/rmd/0bb18b0 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/24469009 [17:09:53] what... [17:10:47] JeroenDeDauw: ^ looks like I merged before travis ran through, doh [17:12:17] https://www.wikidata.org/w/index.php?title=Q1999&curid=2910&diff=125807664&oldid=125362901 <- is this correct? [17:16:37] [13WikibaseDataModel] 15JeroenDeDauw created 06entityidc (+1 new commit): 02http://git.io/rfrp6w [17:16:37] 13WikibaseDataModel/06entityidc 1402ee145 15jeroendedauw: Make EntityId constructor non-public [17:16:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/rmd/dcc2e68 : Yuki Shira The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24468964 [17:17:27] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rmd from 140bb18b0 to 14e85359b: 02http://git.io/xkgyUg [17:17:27] 13WikibaseDataModel/06rmd 14e85359b 15jeroendedauw: Remove long deprecated Entity::getIdFromClaimGuid [17:17:38] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #83: Make EntityId constructor non-public (06master...06entityidc) 02http://git.io/B0e8Mw [17:19:32] [travis-ci] wmde/WikibaseDataModel/entityid/1865ffe : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/24469245 [17:19:48] aude: hoo: y u no review https://github.com/wmde/WikibaseQueryEngine/pull/29 ? [17:22:11] that's a huge diff... will have a look later... messing with some messy JS first [17:29:58] addshore: easy merges are easy https://github.com/wmde/WikibaseDataModel/pulls [17:31:18] *waits for travis* [17:31:30] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ysuQgA [17:31:30] 13WikibaseDataModel/06master 1441c445a 15Jeroen De Dauw: Update RELEASE-NOTES.md [17:32:04] addshore: I verified both already [17:32:07] So not need to wait [17:32:21] slow travis is slow [17:32:48] [13WikibaseDataModel] 15addshore closed pull request #81: Remove long deprecated Entity::getIdFromClaimGuid (06master...06rmd) 02http://git.io/VEkzOg [17:33:18] [13WikibaseDataModel] 15addshore closed pull request #83: Make EntityId constructor non-public (06master...06entityidc) 02http://git.io/B0e8Mw [17:34:01] [travis-ci] wmde/WikibaseDataModel/entityidc/02ee145 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/24469996 [17:38:53] [travis-ci] wmde/WikibaseDataModel/rmd/e85359b : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/24470065 [17:58:11] addshore: \o/ [18:10:38] * hoo wonders why EntityViewPlaceholderExpander is so insane [19:13:04] aude: Aroundß [19:13:06] * ? [19:13:32] yes but going home soonish [19:14:14] aude: Is the revision id EntityRevision holds supposed to work with EntityLookup ? [19:14:32] really a question for daniel [19:14:37] Cause for I always seem to get 128 as revision id locally which is pretty weird [19:14:43] huh [19:16:25] yep, I have no idea where that comes from [19:17:56] hyia [19:25:43] hoo: 2**7 :) [19:26:54] jeremyb: 2<<6 :P But I don't see how this makes more sense... [19:27:18] the default is 0 AFAIS (and 128 as default would be pretty f*cked) [19:29:30] heh [19:29:39] oh, my test article has the id 128 :P But still I don't see how that can leak into a revision id [19:30:03] JeroenDeDauw: here? [19:30:11] or not here, that is the question [19:33:20] wow, I found a pretty fucked core bug [19:34:41] !nyan | lazowik [19:34:41] lazowik: ~=[,,_,,]:3 [19:34:46] :D [19:34:51] :) [19:35:20] JeroenDeDauw: Clean Code. A Handbook of Agile Software Craftsmanship [19:35:25] that's THE book? [19:35:35] Ok, I fixed one problem, but my original one is still there, yay :P [19:35:47] after reading of which I'll become an allmighty programmer? [19:36:12] lazowik: It's on THE list http://www.bn2vs.com/blog/craftsmanship/ [19:36:23] lazowik: You'll be as good as JeroenDeDauw, wouldn't say allmighty ;) [19:36:29] :p [19:36:48] JeroenDeDauw: oh, I haven't seen THE list [19:36:49] thanks [19:36:50] JohnLewis: Yeah, omnipotent is a better term [19:37:08] :D [19:37:14] ;p [19:37:18] * lazowik is learning new words here [19:38:14] JeroenDeDauw: btw. I love the comments under THE list [19:38:58] some guy writing in unknown to me language (native of yours I presume?) [19:39:03] 3 paragraphs [19:39:08] and your anwser "I don’t know. Better ask on the user list" [19:39:19] * lazowik finds that amusing [19:39:34] lazowik: it's more polite than writing "RTFM you lazy fuck" [19:39:49] :p [19:40:04] And I actually don't know - not because I maintain SMW that I know all user facing functionality... [19:40:55] lazowik: you also need to review https://github.com/wmde/WikibaseQueryEngine/pull/29 if you want to become a certified 1337 developer [19:41:38] damn [19:41:42] be a programmer, they said [19:41:48] It'll be easy, they said [19:42:09] no one will expect you to do a review, they said [19:43:10] DanielK_WMDE__: ping [19:43:12] lazowik: big difference between "programmer" and "not totally bad programmer" [19:44:07] DanielK_WMDE__: I got some pretty weird things going on... [19:44:32] DanielK_WMDE__: hoo's up to some 1<<7 etc. [19:45:09] 128 as page id also is confusing in this case [19:50:30] trying on another page now [19:51:44] hoo: around but slightly drunk. what's up? [19:52:59] DanielK_WMDE__: Stuff is mixing up revision ids and page ids apparently and I'm pretty much clueless [19:53:05] s/pretty much/totally [19:54:05] (03PS5) 10Thiemo Mättig (WMDE): [WIP] Refcatoring MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 [19:54:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refcatoring MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [19:55:49] ah, got it now [19:58:54] (03PS1) 10Hoo man: Don't mix up revision ids with page ids in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131536 [19:58:59] DanielK_WMDE__: ^ [19:59:00] aude: ^ [19:59:52] really need a break now... already found a similar weirdness in core... this is frustrating [20:00:59] * jeremyb hands hoo|away a stroopwafel [20:01:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [20:04:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131536 (owner: 10Hoo man) [20:11:49] (03CR) 10Addshore: [C: 04-1] "still needs a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [20:11:53] How to fix outdated interwiki after page is moved [20:11:55] ? [20:12:02] in *.wikisource? [20:16:49] it's and addshore! [20:16:52] *an [20:16:53] grr [20:16:56] =o [20:19:55] ankry: wydaje mi się, że powinno zaktualizować [20:19:59] samo [20:20:03] ale nie jestem na bieżąco [20:21:07] Lydia_WMDE: wikidata should autoupdate on page move in wikisource? [20:21:57] lazowik: Yes, it should [20:22:04] ankry: ^ [20:22:05] but that was broken for some time [20:22:10] *should* :p [20:22:15] hehe [20:22:19] in programming [20:22:24] many thinks *should* [20:22:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=62779 [20:23:00] if it doesn't work, please point me to the log entries [20:23:34] addshore: https://gerrit.wikimedia.org/r/131536 [20:23:58] hoo: ankry asked ~10 mins ago [20:24:02] I don't know the case [20:25:21] after at max 24h my bot should also do all page moves that haven't been done by the software [20:26:12] (03CR) 10Addshore: [C: 032] Don't mix up revision ids with page ids in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131536 (owner: 10Hoo man) [20:26:42] ankry: ^ again [20:26:53] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131580 (owner: 10L10n-bot) [20:26:54] thanks, addshore :) Still didn't solve what I was working on, though :P [20:27:04] haha, but nice spot! [20:29:49] (03PS1) 10Thiemo Mättig (WMDE): Reduce expensive tests in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131587 [20:33:39] (03CR) 10Addshore: "They only seems to take 49 seconds for me locally, are you sure they were taking minutes on the latest master of everything?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131587 (owner: 10Thiemo Mättig (WMDE)) [20:33:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/455aaa2 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24483127 [20:33:48] Thiemo_WMDE: ^^ [20:34:01] addshore: hi. [20:34:10] seems a bit odd for them to be taking that long [20:35:10] this thingy initializes all ~400 languages and reads and parses everything. oh, i have all caches turned off, thats a reason. [20:35:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131587 (owner: 10Thiemo Mättig (WMDE)) [20:35:23] 49 seconds are also way to much for such a simple formatter test. [20:41:47] (03PS1) 10Thiemo Mättig (WMDE): Fix round trip tests in MwTimeIsoFormatter tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131593 [20:47:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131593 (owner: 10Thiemo Mättig (WMDE)) [20:47:15] (03CR) 10Thiemo Mättig (WMDE): "Even 49 seconds is way to much for such a simple thing like a time formatter. The problem is that this initializes all ~400 languages. The" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131587 (owner: 10Thiemo Mättig (WMDE)) [20:49:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1ed7394 : Addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/24483497 [20:54:27] hoo: eek! thanks. [20:54:41] my bad, i gues [21:00:36] (03PS1) 10Thiemo Mättig (WMDE): Rearange array of test cases in MwTimeIsoFormatter tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131606 [21:06:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131606 (owner: 10Thiemo Mättig (WMDE)) [21:11:25] (03CR) 10Addshore: Rearange array of test cases in MwTimeIsoFormatter tests (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131606 (owner: 10Thiemo Mättig (WMDE)) [21:22:15] (03PS6) 10Thiemo Mättig (WMDE): Refacatoring MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 [21:24:57] (03CR) 10Thiemo Mättig (WMDE): Rearange array of test cases in MwTimeIsoFormatter tests (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131606 (owner: 10Thiemo Mättig (WMDE)) [21:27:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [21:33:10] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] Refacatoring MwTimeIsoFormatter (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [21:35:31] DanielK_WMDE__: around still? [22:03:45] DanielK_WMDE__: should a content object know it's Revision id / object? That's like the only way I see to pass the revision id belonging to a content object on [22:10:08] * hoo slaps himself for being stupid as ... [22:24:40] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think I found a real problem: You forgot to change the EntityValidator interface. I wonder why PHPStorm doesn't report this." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131055 (owner: 10Daniel Kinzler) [22:54:27] (03PS1) 10Hoo man: Fix viewing older Entity revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) [22:57:38] (03PS2) 10Hoo man: Fix viewing older Entity revisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) [23:01:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [23:04:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131621 (https://bugzilla.wikimedia.org/63309) (owner: 10Hoo man) [23:52:33] (03PS1) 10Hoo man: Fix ClientSiteLinkLookupTest for contentlang != en [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131633 [23:52:47] that will finally fix our travis tests :) [23:53:55] Is it possible to run both the Wikidata Repository and the Wikidata Client on the same mediawiki instance? [23:54:05] Wikibase* [23:54:17] warriorwiki: yes, that works ;) [23:57:20] excellent. Just getting started out and got scared having to choose. [23:57:36] Just starting out* [23:58:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/131633 (owner: 10Hoo man) [23:58:16] ah, it passed :P Good moment to leave