[07:26:16] DanielK_WMDE__: https://www.wikidata.org/wiki/Q42 <-- LOL [08:57:50] (03CR) 10Henning Snater: [C: 032] Replace fade that doesn't fade with more flexible CSS class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 (owner: 10Thiemo Mättig (WMDE)) [08:58:11] (03Merged) 10jenkins-bot: Replace fade that doesn't fade with more flexible CSS class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 (owner: 10Thiemo Mättig (WMDE)) [09:10:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/8034f99 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23916043 [09:24:34] (03CR) 10Henning Snater: "Currently, the spinner has no use after page initialization. Therefore, either the hack in EntityView.php should continue to be resolved i" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 (owner: 10Thiemo Mättig (WMDE)) [09:43:35] (03PS1) 10Daniel Kinzler: (bug XXXX) ChangeOpFactory to depend on entity type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [09:44:26] (03PS2) 10Daniel Kinzler: (bug XXXX) ChangeOpFactory to depend on entity type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [09:44:47] (03PS3) 10Daniel Kinzler: (bug 62643) ChangeOpFactory to depend on entity type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [09:50:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [09:55:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [09:56:00] [13WikibaseQuery] 15snaterlicious comment on pull request #13 14174b522: Missing jquery.json plugin dependency. 02http://git.io/iGsfaw [09:56:20] [13WikibaseQuery] 15snaterlicious comment on pull request #13 14174b522: Please document $form attribute. 02http://git.io/UmKaPg [09:56:30] [13WikibaseQuery] 15snaterlicious comment on pull request #13 14174b522: Please use... 02http://git.io/00xPwg [09:56:40] [13WikibaseQuery] 15snaterlicious comment on pull request #13 14174b522: How about a destroy method? 02http://git.io/6j54QQ [09:58:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [10:00:24] (03PS1) 10WikidataBuilder: New Wikidata Build - 28/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/130053 [10:09:33] Tobi_WMDE: https://github.com/wmde/WikibaseDatabase/pull/46 [10:09:38] revieeew [10:09:41] !review [10:09:41] https://bit.ly/wbreview [10:09:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/130053 (owner: 10WikidataBuilder) [10:10:07] !del review [10:10:12] !review del [10:10:13] Successfully removed review [10:10:58] !review is https://bit.ly/wdrieview [10:10:58] Key was added [10:27:27] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "> resolved in a clean way (removing the node)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 (owner: 10Thiemo Mättig (WMDE)) [11:03:37] (03PS3) 10Thiemo Mättig (WMDE): Reduce loading spinner toggle to a single 'loading' CSS class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 [11:09:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 (owner: 10Thiemo Mättig (WMDE)) [11:27:39] (03CR) 10Adrian Lang: [C: 04-1] "See inline comments. Also:" (035 comments) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [12:07:54] [13WikibaseQuery] 15adrianlang comment on pull request #13 14174b522: I prefer the more explicit style. 02http://git.io/NTEwdQ [12:11:24] [13WikibaseQuery] 15adrianlang 04force-pushed 06snakview from 14174b522 to 14be1e7ee: 02http://git.io/29CD-Q [12:11:24] 13WikibaseQuery/06snakview 14ab11cb7 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page... [12:11:24] 13WikibaseQuery/06snakview 14335a3fd 15Adrian Lang: Move phpunit tests to tests/phpunit [12:11:24] 13WikibaseQuery/06snakview 1400a1264 15Adrian Lang: Add qunit tests for JavaScript [12:43:17] [13WikibaseDatabase] 15tobijat pushed 1 new commit to 06master: 02http://git.io/6_ZKNA [12:43:17] 13WikibaseDatabase/06master 149d76252 15Tobi Gritschacher: Merge pull request #46 from wmde/PDOSchemaModifier... [12:52:27] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "It's a lot of comments but I hope all of them can be fixed very easily. Looks really good overall." (0318 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [12:58:36] Thiemo_WMDE: what's your vote on https://gerrit.wikimedia.org/r/#/c/124800/16 ? [12:58:45] i'm just now starting to look at the comments [12:59:05] DanielK_WMDE__: looking at it right now. please wait 5min and lets talk then. [12:59:17] ok [13:03:03] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I think it's easier to merge this as it is and I will do a follow-up for my comments. Ok?" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [13:03:22] DanielK_WMDE__: here you go. [13:05:31] DanielK_WMDE__: looks like we are causing a lot of merge trouble. 3 childs in https://gerrit.wikimedia.org/r/#/c/128938/ [13:07:22] (03PS6) 10Daniel Kinzler: (bug 62643) Move term validation into ChangeOps [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 [13:07:44] Thiemo_WMDE: only two now :P [13:08:05] (03CR) 10jenkins-bot: [V: 04-1] (bug 62643) Move term validation into ChangeOps [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler) [13:08:56] what do you think? merge https://gerrit.wikimedia.org/r/#/c/124800/ and i will put a follow-up on top of https://gerrit.wikimedia.org/r/#/c/124835/ ? [13:09:12] [13Time] 15filbertkm created 06precision from 06master (+0 new commits): 02http://git.io/FpBcHw [13:10:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler) [13:10:45] Thiemo_WMDE: sure! [13:10:48] thanks [13:10:54] [13Time] 15filbertkm pushed 1 new commit to 06precision: 02http://git.io/fQYYJQ [13:10:54] 13Time/06precision 140eb8a99 15aude: Fix parsing of years ending in zero... [13:11:19] [13Time] 15filbertkm opened pull request #16: Fix parsing of years ending in zero (06master...06precision) 02http://git.io/y_Ifbg [13:11:32] DanielK_WMDE__: even if i did not actually tested all change ops in my local wiki? [13:13:20] Thiemo_WMDE: if you trust our tests, sure :) [13:13:29] i do. :) [13:14:37] Thiemo_WMDE: hm... i disagree about the exceptions in PreSaveChecks. I was using the if ( !$result->isValid() ) approach before. it sucked, because we want to abort if the result is invalid, nto continue checking. it makes for very messy code. [13:14:49] using an exception is much easier and cleaner. i don't see the problem with it [13:14:54] exceptions are for, well, exceptions :P [13:15:10] (03PS1) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [13:15:16] jenkins will fail! [13:15:27] because code is broken and we were missing test cases [13:15:31] (03PS1) 10Adrian Lang: Introduce some more specific parser error localizations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130064 [13:15:51] Tobi_WMDE: Adrian_WMDE want to review https://github.com/DataValues/Time/pull/16 [13:15:57] Thiemo_WMDE: i also disagree about the private methods. they give names pt complex operations. [13:16:03] that makes the coer readable+ [13:16:05] why travis! [13:16:59] no revieiw yet [13:20:58] DanielK_WMDE__: i wrote so many comment, i don't know what you are refferring to. [13:21:11] Thiemo_WMDE: replying inline now, will send you a link [13:21:30] (03PS1) 10Adrian Lang: Don't register trivial, unused parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130065 [13:21:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [13:21:40] DanielK_WMDE__: are you commenting on 124800? then i will wait. [13:21:44] [13Time] 15filbertkm pushed 1 new commit to 06precision: 02http://git.io/1W43tg [13:21:44] 13Time/06precision 143931e13 15aude: Update test cases to use year precision, unless otherwise specified [13:23:03] Thiemo_WMDE: yes [13:23:07] Thiemo_WMDE: sounds good to work with the range of years [13:26:19] * aude cringe to see "namespace valueformatters\test; " in code [13:26:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130064 (owner: 10Adrian Lang) [13:27:29] (03CR) 10Daniel Kinzler: (bug 49583) refactoring term validation (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [13:27:34] Thiemo_WMDE: --^ [13:28:05] (03PS17) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [13:28:44] (03PS6) 10Daniel Kinzler: (bug 64308) Localize error parameters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 [13:29:09] (03PS2) 10Daniel Kinzler: Cleanup mockups and docs related to localized error parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [13:29:30] (03PS4) 10Daniel Kinzler: (bug 62643) ChangeOpFactory to depend on entity type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [13:31:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130065 (owner: 10Adrian Lang) [13:33:29] (03PS18) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [13:35:51] [13Time] 15filbertkm pushed 1 new commit to 06precision: 02http://git.io/QI4gjQ [13:35:51] 13Time/06precision 14ac6c98a 15aude: Default to year precision date in range 4000 BC to 4000 [13:39:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [13:43:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [13:44:45] Thiemo_WMDE: Tobi_WMDE Adrian_WMDE https://github.com/DataValues/Time/pull/16 [13:48:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [13:50:56] [13Time] 15tobijat closed pull request #16: Fix parsing of years ending in zero (06master...06precision) 02http://git.io/y_Ifbg [13:51:34] aude: I'm basically fine with it. see my comment. [13:51:48] the "close" was unintended [13:52:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [13:52:51] Tobi_WMDE: what version? [13:53:34] we'll need to update wikbiase to use it [13:53:55] right now it uses ~0.5.1 [13:54:16] aude: hmm.. we probably need to make a patch version then [13:54:49] so this goes into master? added to release notes for 0.6 alpha [13:54:59] and then cherry pick this into 0.5.2? [13:55:02] or we make a 0.5.2 but have to make sure the changes from 0.6 (dev) don't get in there [13:55:42] aude: I would branch off 0.5.1 and add it there [13:55:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [13:55:52] and then create a 0.5.2 release from it [13:56:17] in addition to master? [13:56:24] 0.6 has breaking changes ant should not be released yet [13:56:51] aude: yes [13:56:59] ok [13:58:06] updated release notes [13:58:20] [13Time] 15filbertkm pushed 1 new commit to 06precision: 02http://git.io/Jn6mBw [13:58:20] 13Time/06precision 14a356507 15aude: Update release notes [13:58:26] once merged, i can cherrypick and make 0.5.2 tag [13:58:44] aude: let me try it again [13:58:47] ok [14:10:12] Lydia_WMDE: https://github.com/Wikidata-lib/PropertySuggester-Python/pull/7#issuecomment-41562085 [14:10:27] hoo: thx [14:12:54] [13Time] 15thiemowmde closed pull request #16: Fix parsing of years ending in zero (06master...06precision) 02http://git.io/y_Ifbg [14:13:02] [13Time] 15thiemowmde 04deleted 06precision at 14a356507: 02http://git.io/eF2tyQ [14:15:34] aude: ^^ [14:25:07] (03CR) 10Thiemo Mättig (WMDE): [C: 032] (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:25:32] (03Merged) 10jenkins-bot: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:25:33] Tobi_WMDE: Thiemo_WMDE thanks [14:26:34] Thiemo_WMDE: wohoo [14:26:40] tons of code [14:26:57] Tobi_WMDE: the +2? [14:27:02] yeajh [14:27:13] blame daniel. [14:27:39] (03PS7) 10Daniel Kinzler: (bug 64308) Localize error parameters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 [14:27:53] Thiemo_WMDE: yay! this one too, please? https://gerrit.wikimedia.org/r/#/c/128938/6 [14:28:01] it already had CR+2 from you before the rebase [14:28:06] DanielK_WMDE__: ItemChangeOpFactory extends ChangeOpFactory [14:28:12] DanielK_WMDE__: how about using composition instead? [14:28:49] DanielK_WMDE__: looks like you are mirroring the Entity hirarchy there, which I hope we've established already is not good [14:29:19] JeroenDeDauw: ItemChangeOpFactory actually *is* a ChangeOpFactory. All operations valid on an entity are valid on an item. [14:29:57] they would have to at least share an interface. and then all the calls would have to be delegated. ick. [14:30:13] (03CR) 10Jeroen De Dauw: "This inheritance approach is going to lead to pain. Composition is a better fit." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [14:30:28] [13Time] 15filbertkm created 060.5.2 (+5 new commits): 02http://git.io/-jqbSw [14:30:28] 13Time/060.5.2 144e27e38 15aude: Fix parsing of years ending in zero... [14:30:28] 13Time/060.5.2 142ba8877 15aude: Update test cases to use year precision, unless otherwise specified [14:30:28] 13Time/060.5.2 14843f264 15aude: Default to year precision date in range 4000 BC to 4000 [14:31:16] Tobi_WMDE: how do i tag? [14:31:35] nevermind [14:31:36] aude: https://github.com/DataValues/Time/releases [14:32:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [14:33:31] do i mark pre-release? [14:33:45] Tobi_WMDE: [14:34:50] * aude thinks not [14:35:10] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/cb73ba9 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23936863 [14:35:18] [13Time] 15filbertkm tagged 060.5.2 at 060.5.2: 02http://git.io/bvX93A [14:36:26] aude: no [14:36:32] good :) [14:37:06] (03PS3) 10Thiemo Mättig (WMDE): Cleanup mockups and docs related to localized error parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 [14:39:50] [13Time] 15filbertkm 04deleted 060.5.2 at 142001ff6: 02http://git.io/_8Qufw [14:40:22] aude: retriggered tests of https://gerrit.wikimedia.org/r/#/c/130063/ [14:40:25] should pass now [14:40:29] right? [14:41:21] shall amend that [14:41:25] [13Time] 15filbertkm created 06releasenotes (+1 new commit): 02http://git.io/vw0bbw [14:41:25] 13Time/06releasenotes 14e25b638 15aude: Update release notes for 0.5.2 tag [14:42:19] [13Time] 15filbertkm opened pull request #17: Update release notes for 0.5.2 tag (06master...06releasenotes) 02http://git.io/HotIzA [14:42:36] (03PS2) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [14:42:38] (03PS1) 10Aude: Use data-values/time 0.5.2, fix for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130080 [14:43:01] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [14:43:53] aude: guess there is no need to update composer.json [14:44:06] but nevermind [14:45:02] ~0.5.1 already ensures the latest 0.5.x version is pulled [14:46:20] Tobi_WMDE: ok, whatever [14:46:32] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [14:46:39] whaat [14:46:44] hmm [14:47:20] oh, [14:47:21] ok [14:47:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [14:48:31] (03PS3) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [14:48:39] and then assume it's not getting the latest from packagist [14:48:57] Installing data-values/time (0.5.1) [14:48:59] (03CR) 10Daniel Kinzler: (bug 62643) ChangeOpFactory to depend on entity type (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [14:49:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [14:49:06] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/15fdcc3 : daniel The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23937777 [14:49:08] aude: should be updated now [14:50:33] [13Time] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/_FIe-w [14:50:33] 13Time/06master 1407ef5b4 15thiemowmde: Merge pull request #17 from DataValues/releasenotes... [14:51:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130080 (owner: 10Aude) [14:53:50] Thiemo_WMDE: close https://bugzilla.wikimedia.org/show_bug.cgi?id=64308? [14:54:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [14:55:05] (03PS5) 10Daniel Kinzler: (bug 62643) ChangeOpFactory to depend on entity type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [14:55:19] (03CR) 10jenkins-bot: [V: 04-1] (bug 62643) ChangeOpFactory to depend on entity type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [14:55:37] aude: tests are failing [14:55:55] also for me locally with 0.5.2 [14:55:58] works locally to update from packagist [14:55:59] (03CR) 10Daniel Kinzler: "PS5 addresses comments from PS3, and rebases on top of master (sorry, coudn't figure out how to avoid this after dependencies got merged)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [14:56:14] aude: they fail even with 0.5.2 [14:56:30] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 per Jeroen and Thiemo: the entity type dependant factory thing in the API and special pages is just broken. Will refactor." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [14:56:30] not the ones you added I think. but others [14:56:55] looking [14:58:33] (03PS6) 10Daniel Kinzler: (bug 62643) ChangeOpFactory to depend on entity type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [14:58:51] (03CR) 10Daniel Kinzler: [C: 04-1] "PS6 is yet another rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [15:01:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [15:05:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [15:06:35] (03PS4) 10Thiemo Mättig (WMDE): Cleanup mockups and docs related to localized error parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 [15:11:47] (03CR) 10Thiemo Mättig (WMDE): "Note to reviewer: Since the mocks don't need to output anything they don't need escaping. The tests can happily compare unescaped strings." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [15:11:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [16:00:58] [travis-ci] wmde/WikibaseQueryEngine/standalonetest/1b3eecd : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/23944270 [16:01:36] (03CR) 10Jeroen De Dauw: [C: 032] Don't register trivial, unused parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130065 (owner: 10Adrian Lang) [16:02:21] (03CR) 10Jeroen De Dauw: [C: 031] Introduce some more specific parser error localizations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130064 (owner: 10Adrian Lang) [16:03:47] Thiemo_WMDE: did you look at the serialization stuff yet? [16:11:11] (03CR) 10Jeroen De Dauw: "Generally looks good, though I think the whole entity status calculation is misplaced. "entity status calculation" already hints at this: " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [16:12:05] (03CR) 10Jeroen De Dauw: [C: 032] correct example in EditEntity API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129825 (owner: 10Ricordisamoa) [16:16:58] (03PS4) 10Thiemo Mättig (WMDE): Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [16:18:16] (03CR) 10Aude: [C: 04-1] "due to failing tests and issues with dates like '10s BC'" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [16:18:24] (03PS2) 10Thiemo Mättig (WMDE): Use data-values/time 0.5.2, fix for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130080 (owner: 10Aude) [16:19:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Use data-values/time 0.5.2, fix for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130080 (owner: 10Aude) [16:19:47] Thiemo_WMDE: please wait on time parsing [16:19:49] (03Merged) 10jenkins-bot: Use data-values/time 0.5.2, fix for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130080 (owner: 10Aude) [16:19:57] (03CR) 10Aude: [C: 04-2] Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [16:20:23] aude: everything fails, i cant do anything. [16:20:32] ok [16:21:28] you are right, "10s" should not be year precision. [16:21:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/62253f2 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23945063 [16:21:46] but at least all other patches dont fail any more. [16:22:39] almost have solution [16:23:12] (03PS5) 10Thiemo Mättig (WMDE): Cleanup mockups and docs related to localized error parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 [16:23:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [16:25:40] aude: i wonder. i understand what "10s" means. like "1990s". but whats "12s"? this isn't a thing. [16:26:33] Thiemo_WMDE: yes, 6s and 10s and 27s should be errors. [16:26:37] how about 640s? [16:26:42] that should be fine, right? [16:26:51] 1987s should be an error, though [16:27:10] there is indeed an issue [16:27:33] enter anything on test wikidata with a string appended (single char) [16:27:55] ...and not "s" :) [16:28:09] err, "2000 s" [16:28:20] "2000e" [16:28:34] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130080 (owner: 10Aude) [16:29:55] [travis-ci] wmde/WikibaseQueryEngine/standalonetest/4f32d3a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/23944395 [16:32:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [16:46:09] (03CR) 10Tobias Gritschacher: "-2??" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [16:46:24] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/8bcb5eb : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23945938 [16:47:03] Tobi_WMDE: tests are broken [16:47:10] thiemo didn't quite fix them [16:47:20] patch is coming [16:47:37] [travis-ci] wmde/WikibaseQueryEngine/standalonetest/a5cefed : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/23946316 [16:53:21] Tobi_WMDE: i force-fixed the tests by making them succeed when they shouldn't. ;) [16:59:39] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/75b78e8 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23946754 [16:59:40] Thiemo_WMDE: can't you mark these as incomplete instead of makign them succede? [16:59:51] to late. :( [17:00:00] got the patno [17:00:02] go [17:00:04] gah [17:00:06] no! [17:00:20] the tests are broken, not incomplete [17:00:24] how to mark a test in an array? [17:00:53] (03CR) 10Thiemo Mättig (WMDE): "I should probably not look at this yet. ;-)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler) [17:01:31] (03PS5) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [17:01:33] (03PS1) 10Aude: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 [17:04:32] (03PS2) 10Aude: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 [17:04:34] (03PS6) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [17:07:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [17:09:17] rage [17:09:24] hi aude! [17:09:31] it's harej ! [17:09:44] i'm in costa mesa, california [17:09:49] \o/ [17:11:14] (03PS7) 10Daniel Kinzler: (bug 62643) Split up ChangeOpFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [17:13:39] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [17:16:11] Thiemo_WMDE: would you have another look at https://gerrit.wikimedia.org/r/#/c/130051/ ? [17:16:18] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Set precision in MWTimeIsoParser (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [17:16:31] JeroenDeDauw: you too, maybe? ---^^ [17:16:55] The patch now has even more lines (ugh), but the logic in the API modules should be a lot cleaner now. [17:17:05] I split up the ChangeOpFactory as Jeroen suggested [17:17:16] DanielK_WMDE__: processing... [17:18:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [17:19:24] DanielK_WMDE__: revieeew https://github.com/wmde/WikibaseQueryEngine/pull/25 [17:21:40] JeroenDeDauw: trying to wrap my head around what is happening there. not succeeeding so far. [17:21:50] tooo much... meta stuff. [17:21:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [17:23:02] DanielK_WMDE__: It now instantiates the QueryEngine thing in the tests using a PDO implementation of the WikibaseDatabase objects rathar than the MW one [17:23:16] And kills cruft no longer needed [17:23:39] JeroenDeDauw: can it also be tested with the MW database astuff as a backend? [17:24:38] (03PS3) 10Aude: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 [17:24:40] (03PS7) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [17:25:11] JeroenDeDauw: and yea, i got the purpose of this, but i'm not quite getting the details. [17:25:15] what's SQLStoreWithDependencies? [17:25:34] And how does it get the credentials needed for testing on a "real" mysql database? [17:25:57] does it use temp tables? a tempt database? [17:26:11] i'm confused (and getting a head cold - that doesn't help) [17:26:29] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [17:26:44] orr [17:27:22] (03PS8) 10Daniel Kinzler: (bug 62643) Split up ChangeOpFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 [17:30:57] (03PS4) 10Aude: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 [17:30:59] (03PS8) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [17:32:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [17:35:25] (03CR) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [17:38:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [17:43:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [17:43:11] \o/ [17:43:31] * aude thinks something is weird with jenkins [17:44:18] (03CR) 10Aude: [C: 04-1] Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [17:44:40] (03CR) 10Aude: "suspicious of WikidataJenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [17:45:57] (03CR) 10Thiemo Mättig (WMDE): "That's an intresting way to deal with review comments: you simply removed all the code I complained about. ;-)))" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [17:46:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [17:48:49] (03CR) 10Daniel Kinzler: "@thiemo: well, you complained about oddities which I also found annoying, but which coudn't be fixed with small changes. And jeroen compla" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [17:49:39] Thiemo_WMDE: i fixed the small stuff in PS5 [17:49:52] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [18:01:07] (03CR) 10Daniel Kinzler: [C: 032] Cleanup mockups and docs related to localized error parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [18:06:44] (03CR) 10Daniel Kinzler: [C: 032] Check the content model of pages in EntityPerPageBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [18:14:29] (03CR) 10Daniel Kinzler: [C: 032] Introduce some more specific parser error localizations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130064 (owner: 10Adrian Lang) [18:17:54] (03PS5) 10Aude: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 [18:19:04] (03PS6) 10Aude: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 [18:20:21] (03PS9) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [18:24:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [18:29:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [18:30:04] (03PS2) 10Daniel Kinzler: (bug 64309) Introducing ChangeOp::validate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 [18:34:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [18:38:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [18:41:38] (03Merged) 10jenkins-bot: Cleanup mockups and docs related to localized error parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129652 (owner: 10Thiemo Mättig (WMDE)) [18:41:40] (03CR) 10jenkins-bot: [V: 04-1] Check the content model of pages in EntityPerPageBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [18:41:42] (03Merged) 10jenkins-bot: Introduce some more specific parser error localizations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130064 (owner: 10Adrian Lang) [18:56:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d486375 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23957016 [19:03:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "The broken "10s" test cases are not part of this patch, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [19:04:47] (03CR) 10Aude: "@thiemo fixing those separately, as it's different bug" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [19:11:25] * hoo eyes aude ... around? [19:11:34] about to go home, but yes [19:12:08] aude: Well, rather go home then, not urgent... will ask that sometime else [19:12:18] if it's quick, ask [19:12:36] * aude fixing time parsing [19:12:46] Nah, it's more complicated... the legacy MediaWiki code for importing revisions [19:13:12] that's totally weird and almost impossible to adopt a more fine grained permission system to it [19:14:12] (03CR) 10Thiemo Mättig (WMDE): Set precision in MWTimeIsoParser (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [19:22:49] (03CR) 10Aude: Set precision in MWTimeIsoParser (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [19:22:57] (03PS7) 10Aude: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 [19:22:59] (03PS10) 10Aude: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) [19:23:01] (03PS1) 10Aude: Fix handling of dates in format such as 1980x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) [19:23:09] enough for now [19:30:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [19:31:39] (03CR) 10Thiemo Mättig (WMDE): "getEntityStatus is part of getEntityPageProperties which is part of applyEntityPageProperties which is part of getParserOutput (which is a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [19:35:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [19:38:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [19:50:14] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "This is all legacy code that should die, right? ("@todo move me to DataValues-time") Ah, whatever. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [19:51:15] (03Merged) 10jenkins-bot: Set precision in MWTimeIsoParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130097 (owner: 10Aude) [19:51:17] (03Merged) 10jenkins-bot: Add test cases for year time parsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130063 (https://bugzilla.wikimedia.org/64537) (owner: 10Aude) [20:11:17] (03PS6) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityContent::STATUS_UNTITLED [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 [20:16:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [20:21:10] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130199 (owner: 10L10n-bot) [20:24:04] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#121 (master - eded539 : Translation updater bot): The build has errored. [20:24:05] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/edfbe9a0b167...eded5394c80b [20:24:05] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/23963862 [20:35:27] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/72d2524 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23963868 [20:47:25] (03PS3) 10Daniel Kinzler: (bug 64309) Introducing ChangeOp::validate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 [20:50:46] (03CR) 10Daniel Kinzler: [C: 04-1] "I want to re-think when and where knowledge about the concrete entity type is brought into the information flow. Perhaps it would be bette" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [20:51:33] (03PS1) 10Thiemo Mättig (WMDE): Fix non-existing SettingsArray::get calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130217 [20:53:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [20:57:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130217 (owner: 10Thiemo Mättig (WMDE)) [20:58:41] (03PS7) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityContent::STATUS_UNTITLED [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 [21:04:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [21:07:31] Thiemo_WMDE: > echo get_class( \Wikibase\Client\WikibaseClient::getDefaultInstance()->getSettings() ); [21:07:31] Wikibase\Settings [21:07:44] hm? [21:08:02] Thiemo_WMDE: regarding https://gerrit.wikimedia.org/r/130217 [21:08:15] I wondered why it still worked and the tests didn't fail... and that's why [21:08:17] my phpstorm says SettingsArray [21:08:52] The documentation says taht, but it's obviously wrong here [21:10:04] (03CR) 10Hoo man: [C: 032] "As Settings extends SettingsArray, it's probably better to have this more generic... but it works like this (at least atm, so this is *not" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130217 (owner: 10Thiemo Mättig (WMDE)) [21:10:14] it's the base class in the documentation. i dont think thats an error. [21:10:35] (03Merged) 10jenkins-bot: Fix non-existing SettingsArray::get calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130217 (owner: 10Thiemo Mättig (WMDE)) [21:11:03] I was mostly confused because you said dead code and it's broken (because it's not) [21:11:32] oh, now i understand. get() is static. [21:11:53] calling Settings::get() is ok but ...->get() is plain wrong. [21:12:54] ... php is to lazy. ;-) [21:14:00] do you guys start to work now when we are all going to bed? ;))) [21:14:02] :P Everything is ok in PHP... [21:14:27] Thiemo_WMDE: Deploy tonight between 1 and 2 am, so I stick around... maybe will do some stuff also :D [21:14:53] calling statics in non-static context shouldn't be allowed. but you are right, even java allowed this (but eclipse warned). [21:16:11] sometimes I just hate PHP... I mean you can do $doesntExist[blah][foo][bar] = 1; and it will work [21:16:23] even without using strings, and also if the array doesn't exist -.- [21:18:07] hoo: has Lydia_WMDE approved of the languages? [21:18:25] aude: Yep, she told me on friday that we're good to go [21:18:30] seems generally ok, but i wonder about things like being able to pick them in uls [21:18:33] hoo: ok [21:19:08] I guess we will do that in a follow up, or Amir will or so... but works well enough for now (on our side) [21:19:37] do we have bugs for the issues? [21:20:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/6654053 : Thiemo Mättig The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23967913 [21:20:10] aude: Don't think so, but Amir is aware of the ULS stuff and will probably handle it [21:20:16] might be worth a reply on the bug [21:20:19] ok [21:20:33] already replied but if it gets closed, then we need new bugs [21:20:38] yep [21:21:01] also, ota is a rtl language [21:21:23] of course, better to have them (even if imperfect), then we cna work to fix the issues [21:22:19] hoo: https://twitter.com/maettig/status/460891701872427009 [21:23:20] Thiemo_WMDE: You can even do that without quoting the strings... PHP will make $a[PHP] => $a['PHP'] and only throw a notic [21:23:21] e [21:23:39] that's like super obscure black magic [21:23:50] i know, but i wanted an example that looks sane but isn't. ;) [21:24:34] heh... sane and PHP :P [21:32:26] (03CR) 10Thiemo Mättig (WMDE): "For the record: My description was wrong. The truth is, Settings::get() is static and getSetting() is not. Calling $var->get() works but i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130217 (owner: 10Thiemo Mättig (WMDE)) [21:35:00] Lydia_WMDE: are the interns on list already? [21:36:51] lazowik: i think so. [21:47:18] (03PS2) 10Aude: Fix handling of dates in format such as 1980x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) [21:47:31] (03PS3) 10Aude: Fix handling of dates in format such as 1980x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) [21:47:43] (03CR) 10jenkins-bot: [V: 04-1] Fix handling of dates in format such as 1980x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [21:51:17] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think the current code is very easy to read. It's really enjoyable! Much, much better than before. I almost hit +2 but found some oopsie" (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [21:53:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [21:54:20] (03CR) 10Aude: (bug 62643) Split up ChangeOpFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [21:54:37] wow, that touches a lot of files [21:55:26] (03CR) 10Aude: (bug 62643) Split up ChangeOpFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130051 (owner: 10Daniel Kinzler) [21:57:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [22:00:00] (03PS4) 10Aude: Fix handling of dates in format such as 1980x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) [22:00:53] Lydia_WMDE: really nice to see someone interested in improving docs [22:01:37] do you have any eta for the ui redesign? [22:01:59] it would be nice to land that before this all popularization thing [22:02:17] but probably this isn't doable :( [22:05:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [22:10:03] 'night [22:24:28] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Sorry, maybe it's that I don't really understand the problem. But as far as I can tell this approach focuses very much on the en.json tran" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [22:41:40] (03PS1) 10Aude: Handle localised dates (e.g. 'century') more consistently [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130236 (https://bugzilla.wikimedia.org/64558) [22:46:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130236 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [23:25:34] (03CR) 10Thiemo Mättig (WMDE): "I played around with PHP's DateTime and found a few things." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [23:30:24] (03CR) 10Thiemo Mättig (WMDE): "... I forgot "1 January 1970". And Farsi numbers. I'm going to bed now. :-(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [23:33:25] (03PS5) 10Aude: Fix handling of dates in format such as 1980x or 1980UTC [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) [23:38:10] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Yea, I like this! I will merge this tomorrow. It's just to late today. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130236 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [23:38:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [23:39:05] (03CR) 10Aude: "@thiemo I agree generally about requiring three parts to the value, so we have month, date and year." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude) [23:53:41] (03CR) 10Thiemo Mättig (WMDE): Fix handling of dates in format such as 1980x or 1980UTC (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130138 (https://bugzilla.wikimedia.org/64558) (owner: 10Aude)