[03:10:28] (03PS1) 10Aude: Remove skip tests in MwTimeIsoFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129370 [06:44:24] (03PS12) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [06:44:26] (03PS13) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [06:53:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [06:55:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [07:19:58] [13WikibaseQuery] 15adrianlang pushed 2 new commits to 06snakview: 02http://git.io/geWXkA [07:19:58] 13WikibaseQuery/06snakview 1440a9d11 15Adrian Lang: Move phpunit tests to tests/phpunit [07:19:58] 13WikibaseQuery/06snakview 14d91b918 15Adrian Lang: Add qunit tests for JavaScript [07:22:05] [13Number] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/IpNCOg [07:22:05] 13Number/06master 1452e236b 15Adrian Lang: Release 0.4 [07:22:30] [13Number] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/Ays2ig [07:22:30] 13Number/06master 1497f8180 15Adrian Lang: Bump version in Number.php [07:22:46] [travis-ci] wmde/WikibaseQuery/snakview/d91b918 : Adrian Lang The build was broken. http://travis-ci.org/wmde/WikibaseQuery/builds/23653199 [07:22:55] [13Number] 15adrianlang tagged 060.4 at 06master: 02http://git.io/sZHDYw [07:24:14] [13Number] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/SS_T0A [07:24:14] 13Number/06master 14f626cab 15Adrian Lang: Bump version in Number.php to next alpha version... [07:27:30] [13WikibaseQuery] 15adrianlang 04force-pushed 06snakview from 14d91b918 to 14174b522: 02http://git.io/29CD-Q [07:27:30] 13WikibaseQuery/06snakview 14acea803 15Adrian Lang: Move phpunit tests to tests/phpunit [07:27:30] 13WikibaseQuery/06snakview 14174b522 15Adrian Lang: Add qunit tests for JavaScript [07:30:20] [travis-ci] wmde/WikibaseQuery/snakview/174b522 : Adrian Lang The build was fixed. http://travis-ci.org/wmde/WikibaseQuery/builds/23653692 [08:49:18] (03CR) 10Siebrand: (bug 64308) Localize error parameters. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [08:50:22] (03CR) 10Siebrand: (bug 64308) Localize error parameters. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [08:53:06] Adrian_WMDE: can you have a look at https://gerrit.wikimedia.org/r/#/c/129314/? This is a blocker for the deployment branch. Should be easy to verify.. [08:53:24] hmk [09:05:33] Adrian_WMDE: if you don't have time at the moment, Thiemo_WMDE could probably also have a look [09:06:38] na, I'll do it [09:14:59] (03CR) 10Adrian Lang: [C: 032] Fix handling of parse error in JS widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129314 (owner: 10Aude) [09:15:24] (03Merged) 10jenkins-bot: Fix handling of parse error in JS widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129314 (owner: 10Aude) [09:27:24] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/155273c : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23659915 [09:41:51] Hello [09:43:40] Veery happy to annonce here first my new project based on Wikidata : http://zone47.com/crotos/ [09:44:34] It's a search engine for visual artworks and a tool for help and inspire contribution on this domain [09:45:43] Hope you will enjoy it [10:00:19] (03PS1) 10WikidataBuilder: New Wikidata Build - 24/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129391 [10:12:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129391 (owner: 10WikidataBuilder) [11:07:53] Tobi_WMDE: Could you poke https://packagist.org/packages/data-values/number [11:09:46] Adrian_WMDE: done [11:09:55] awesome [11:11:43] (03PS13) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [11:11:45] (03PS14) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [11:19:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [11:24:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [11:36:06] * YuviPanda waves [11:37:06] how do I get the id for a wiki article via the API? [11:37:16] I have the link to the enwiki page, need to find the id [11:40:27] (03PS2) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [11:40:46] (03CR) 10Adrian Lang: Factor out generation of site links HTML into own class (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [11:42:17] found it, nevermind [11:46:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [12:03:31] aude: Around? [12:08:36] (03PS3) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [12:13:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [12:22:21] Lydia_WMDE: JeroenDeDauw: Why am I not member of DataValues on github? And why is it not just part of WMDE? [12:22:51] hoo: i can add you [12:22:55] what's your nick? [12:23:17] Lydia_WMDE: mariushoch [12:23:27] k [12:23:40] I'm just removing some old cruft as maintenance from stuff [12:24:51] hoo: done [12:25:10] thanks :) [12:26:42] [13DataValues] 15mariushoch created 06noI18nCompat (+1 new commit): 02http://git.io/3FlSYw [12:26:42] 13DataValues/06noI18nCompat 142287a31 15Marius Hoch: Remove i18n compatibility shim [12:26:48] very easy CR ^ [12:26:57] [13DataValues] 15mariushoch opened pull request #5: Remove i18n compatibility shim (06master...06noI18nCompat) 02http://git.io/wWl-7Q [12:29:02] [13DataTypes] 15mariushoch created 06noI18nCompat (+1 new commit): 02http://git.io/kxlABQ [12:29:02] 13DataTypes/06noI18nCompat 141e19791 15Marius Hoch: Remove i18n compatibility shim [12:29:25] JeroenDeDauw: ^ [12:29:32] what we talked about yesterday [12:29:33] [13DataTypes] 15mariushoch opened pull request #16: Remove i18n compatibility shim (06master...06noI18nCompat) 02http://git.io/gWbqJA [12:31:41] [travis-ci] wmde/DataTypes/noI18nCompat/1e19791 : Marius Hoch The build passed. http://travis-ci.org/wmde/DataTypes/builds/23670308 [12:32:13] [13ValueView] 15mariushoch created 06noI18nCompat (+1 new commit): 02http://git.io/9UixtA [12:32:13] 13ValueView/06noI18nCompat 1495b9a17 15Marius Hoch: Remove i18n compatibility shim [12:32:38] [13ValueView] 15mariushoch opened pull request #49: Remove i18n compatibility shim (06master...06noI18nCompat) 02http://git.io/IvTJnA [12:32:53] ok, I think I got them all, except of Diff which should stay compatible with MW 1.22 [12:37:53] DanielK_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=59905 do you have any further concerns here (eg. anything to test before we go live)? [12:38:27] I think I tested it decently, but once it's in, we can't just rmeove it without harm [12:42:37] hoo: can't think of anything. if it Just Works, it Just Works. Let's get this on test.wikidata.org [12:42:54] Yep, test first is a good idea [12:43:01] hoo: best talk to aude about the details. She isn't at the office though, not sure how reactive she is [12:43:06] Do we have a list of languages we want to extra support? [12:43:24] If not, I'm just going to add the one example from the bug which I also used locally [12:46:55] hoo: ask Amir [12:47:06] or GerardM [12:47:16] GerardM-: ^ [12:47:55] I can probably have that pushed out with tonight's deploy [12:48:01] (for test) [12:50:56] hoi [12:51:02] what language is that [12:51:11] and how often can new languages be pushed ? [12:51:22] ota is the one that i want personally [12:51:28] (03PS2) 10Hoo man: Implement a rebuildItemsPerSite maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 [12:51:43] (03CR) 10Hoo man: Implement a rebuildItemsPerSite maintenance script (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man) [12:51:51] and, you do me a favour when it gets pushed out tonight [12:51:57] (03CR) 10Hoo man: "Addressed Daniel's style comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man) [12:52:01] ... when it works I will blog about it [12:52:11] GerardM-: Only to testwikidata tonight [12:52:56] GerardM-: Ok, so I guess I'm going to push ora (which you want) and rwr (which Amir wanted) [12:53:00] to testwikidata [12:53:13] if it works well, we can go for the real one early next week, I guess [12:53:24] (03PS1) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityContent::STATUS_UNTITLED [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 [12:56:06] hoo: there is no MW compar requirement difference between DataModel and Diff AFAIK [12:56:42] I want both [12:56:52] rwr will be happily received in India [12:56:57] hoo: and for the commit you self merged into DM, it seems like this will now end up having a message key displayed on Special:Version [12:56:57] JeroenDeDauw: Ok... I can also remove the shim from Diff... not sure if there are any 3rd party users using it's master on 1.22 [12:57:21] hoo: eh, nvm [12:57:46] hoo: these things should really be agnostic of MW version [12:57:57] And always work esentially [12:58:09] hoo: do they now break when included with MW or whatever?> [12:58:50] JeroenDeDauw: Their i18n will break if included in old MediaWiki version [12:58:51] hoo: gracefull degradation should be easy - only adding the i18n part when compatible [12:58:54] * versions [12:58:59] hoo: what's the remainig issues with the failing LUA tests on travis? [12:59:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man) [12:59:24] Tobi_WMDE: mh? From Wikibase point of view the tests should be fine [12:59:29] hoo: can you please fix that than? Else the docs need to be updated as well... [12:59:46] hoo: they are constantly failing https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/23659916 [12:59:48] JeroenDeDauw: Fix what? The compat? [13:00:25] Tobi_WMDE: Oh well... damn [13:01:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [13:02:24] Tobi_WMDE: Looks like for some reason that's not using our store mock, which is very weird [13:05:27] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #70 149cad4ca: This test violates arrange act assert in a rather bad way. You construct an object, do some tests, further modify the object, do more tests... That makes it hard to determine what the real object state is, esp if you are not sure where the error is coming from. Better split this up into tests that each verify a specification. 02http://git.io/2K2aiw [13:05:42] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #70 149cad4ca: Please do not introduce new usages of deprecated methods. 02http://git.io/8B4Q-A [13:08:34] (03PS5) 10Thiemo Mättig (WMDE): Partial support for thousands separators in DateTimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 [13:09:26] I need some article on a wikipedia using wikidata in an infobox [13:09:32] ideally lots of it [13:09:44] good links please? [13:11:38] uh, mh... aude had good examples from enwiki and there are quite some on plwiki [13:12:11] GerardM-: ora => Ottoman Turkish ? [13:13:58] Hoo indeed [13:14:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 (owner: 10Thiemo Mättig (WMDE)) [13:16:21] (03CR) 10Thiemo Mättig (WMDE): "I started working on a follow-up here: I9523656af1effab76965572c4382e863b88c1d0c" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [13:21:58] [13WikibaseDataModel] 15thiemowmde comment on pull request #70 149cad4ca: You realize I just copied the `testIsEmpty` test you wrote? Sure, I can make this new test better than the others. Just saying. 02http://git.io/F38pIw [13:33:07] Lydia_WMDE: https://fr.wikipedia.org/wiki/Marion_Vernoux [13:33:28] Pyb: thanks! :) [13:35:27] (03CR) 10Daniel Kinzler: "re comments, preparing next patchset." (0317 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [13:35:47] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 1428fd2e8 to 144348b19: 02http://git.io/ahYWpg [13:35:47] 13WikibaseDataModel/06rem 144348b19 15jeroendedauw: [WIP] Legacy code removal... [13:38:58] [travis-ci] wmde/WikibaseDataModel/rem/4348b19 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23675294 [13:42:30] (03PS6) 10Thiemo Mättig (WMDE): Partial support for thousands separators in DateTimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 [13:42:56] (03PS13) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [13:43:14] (03PS1) 10Hoo man: Fix handling of parse error in JS widgets [extensions/Wikibase] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129415 [13:43:31] (03PS14) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [13:43:51] (03CR) 10Hoo man: [C: 032] "per master" [extensions/Wikibase] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129415 (owner: 10Hoo man) [13:44:15] (03Merged) 10jenkins-bot: Fix handling of parse error in JS widgets [extensions/Wikibase] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129415 (owner: 10Hoo man) [13:49:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 (owner: 10Thiemo Mättig (WMDE)) [13:53:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf2/05e1cef : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23675765 [13:55:37] mh, can't tell where these failures come from [13:56:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:02:10] (03PS1) 10Hoo man: Update Wikibase to fix handling of parse error in JS widgets [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129422 [14:04:00] (03PS1) 10Hoo man: Update Wikibase to fix handling of parse error in JS widgets [extensions/Wikidata] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129423 [14:04:09] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129415 (owner: 10Hoo man) [14:04:13] (03Abandoned) 10Hoo man: Update Wikibase to fix handling of parse error in JS widgets [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129422 (owner: 10Hoo man) [14:12:24] https://gerrit.wikimedia.org/r/129423 needs to be merged soonish [14:13:10] Tobi_WMDE: ^ [14:20:36] (03CR) 10Tobias Gritschacher: [C: 032] Update Wikibase to fix handling of parse error in JS widgets [extensions/Wikidata] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129423 (owner: 10Hoo man) [14:20:43] thx [14:22:14] (03CR) 10Tobias Gritschacher: [V: 032] Update Wikibase to fix handling of parse error in JS widgets [extensions/Wikidata] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129423 (owner: 10Hoo man) [14:24:07] off for food for a moment [14:26:32] (03PS15) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [14:29:17] (03PS3) 10Daniel Kinzler: (bug 64308) Localize error parameters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 [14:29:50] (03CR) 10Daniel Kinzler: [C: 04-1] "PS3 is a rebase, will fix comments on previous patches now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [14:36:21] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #70 149cad4ca: That test was written long ago, by someone who at the time had very little experience with testing 02http://git.io/1b0cIA [14:41:55] (03CR) 10Daniel Kinzler: (bug 64308) Localize error parameters. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [14:49:50] Thiemo_WMDE: btw, I think I removed isEmpty from Entity on the 1.0.x branch [14:50:04] It was not used in a sensible way anywhere [14:56:26] [13WikibaseDataModel] 15JeroenDeDauw created 06ismepty (+1 new commit): 02http://git.io/-1JfhA [14:56:26] 13WikibaseDataModel/06ismepty 14e17a159 15jeroendedauw: Add isEmpty to Fingerprint [15:05:26] [travis-ci] wmde/WikibaseDataModel/ismepty/e17a159 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23681627 [15:09:52] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/yDfTig [15:09:52] 13WikibaseDataModel/06master 1411b4c31 15thiemowmde: Merge pull request #71 from wmde/ismepty... [15:10:00] [13WikibaseDataModel] 15thiemowmde 04deleted 06ismepty at 14e17a159: 02http://git.io/xB0vMA [15:13:58] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/v_b8eQ [15:13:58] 13WikibaseDataModel/06master 14012cc9c 15thiemowmde: Merge pull request #72 from wmde/dep... [15:14:05] [13WikibaseDataModel] 15thiemowmde 04deleted 06dep at 14c97ada9: 02http://git.io/M_W4fQ [15:14:24] (03CR) 10Daniel Kinzler: "re comments, will upload the new patch set soon." (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [15:15:32] Thiemo_WMDE: any concerns with tagging 0.7.4? [15:15:55] JeroenDeDauw: I didn't get what you wanted from me about the shims earlier? Do you want them or not? [15:16:25] hoo: what I want is these components to not die when they are included with an older MW version [15:16:40] hm. we are not perfectly happy with some details of the fingerprint stuff. like the name. should such concerns block this version or can this be changed later? [15:17:08] hoo: if the i18n stuff cannot work with older versions, or we don't care to make it so, then we need to make sure it does not get used [15:17:22] hoo: a simple if ( MW_VERSION >= foo ) ought to do it [15:17:49] Thiemo_WMDE: the name of Fingerprint? [15:17:50] but why would anyone use any of these extensions on a (in our dimensions) ancient MW version? [15:18:07] Thiemo_WMDE: that no longer matters for this release, since it was added in 0.7.3 [15:18:33] Thiemo_WMDE: we can always rename it later - that's not nice, and is preferrably avoided. Already to late though [15:18:55] hoo: thats not the point. the point is, if somebody does this it should not horribly die. [15:19:26] hoo: what if someone creates an extension that interacts with a Wikibase API somehow and uses DataModel for that, and they want it to be compat with MW 1.22? [15:19:49] hoo: breaking that compat greatly reduces the utility of our compoents for third party usage [15:20:10] JeroenDeDauw: Well, then let's not do it [15:20:15] JeroenDeDauw: whats with https://github.com/wmde/WikibaseDataModel/pull/32 ? [15:20:23] Data model will work just fine with 1.22 if it did before [15:20:30] just Special:version will look awry [15:21:02] Thiemo_WMDE: needs rebase [15:21:33] hoo: well, that's not good. Can you just put the check in so this is fixed? [15:22:14] [travis-ci] wmde/WikibaseDataModel/dep/c97ada9 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23682047 [15:22:17] I'd actually rather have a non i18n'd string description than the compat being messed up [15:23:19] mh... maybe we should completely remove the MW bindings from these extensions? [15:23:32] Thiemo_WMDE: if you rebase I'll merge the thing [15:23:35] Are they doing anything for the actual extension functionality? [15:23:44] processing... [15:25:01] hoo: they are not extensions, and they actually do not bind to MediaWiki. They are PHP libraries that come with a MW plugin that provides information about the component to MW in case MW is laoded [15:25:05] hoo: we could drop that plugin yes [15:25:17] hoo: though than we end up with not knowing what is being used where [15:25:31] That's bad... [15:26:05] hoo: idially we'd just be able to access the composer.lock info [15:26:14] Rather than have to deal with Special:Version at all [15:26:33] If MW supported that, we'd not have to bother with all this stuff [15:27:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [15:28:08] (03PS4) 10Daniel Kinzler: (bug 64308) Localize error parameters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 [15:29:11] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06arrayobject from 14f02c44b to 14351f37e: 02http://git.io/kLOYOQ [15:29:11] 13WikibaseDataModel/06arrayobject 14737eb4b 15Thiemo Mättig: Avoid constructing nested ArrayObjects... [15:29:11] 13WikibaseDataModel/06arrayobject 1418fb567 15Thiemo Mättig: Simplified overcomplicated constructor [15:29:11] 13WikibaseDataModel/06arrayobject 14ac94e4b 15Thiemo Mättig: Updated tests as requested in the comments [15:30:47] (03CR) 10Daniel Kinzler: [C: 032] "Please add localization for specific expected formats soon." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [15:32:31] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/F4DpIA [15:32:31] 13WikibaseDataModel/06master 14a2aded2 15Jeroen De Dauw: Merge pull request #32 from wmde/arrayobject... [15:33:17] (03CR) 10Daniel Kinzler: [C: 032] Implement a rebuildItemsPerSite maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man) [15:35:52] DanielK_WMDE_: Want to give a quick +1 onto https://gerrit.wikimedia.org/r/129408 ? [15:44:13] (03PS5) 10Daniel Kinzler: (bug 62643) Move term validation into ChangeOps. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 [15:50:48] GerardM-: The two new languages should be live on testwikidata... please test :) [15:51:34] also Lydia_WMDE fyi ^ [15:52:46] hoo: \o/ [15:56:10] (03Merged) 10jenkins-bot: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [15:56:14] (03Merged) 10jenkins-bot: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [15:56:17] (03Merged) 10jenkins-bot: Implement a rebuildItemsPerSite maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125725 (owner: 10Hoo man) [15:57:02] :) [15:57:43] (03CR) 10jenkins-bot: [V: 04-1] (bug 62643) Move term validation into ChangeOps. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler) [16:04:47] mh, this is super awry [16:05:32] We have various places in factories where we cache stuff, which is good in production, but very bad for tests :( [16:06:19] JeroenDeDauw: Do you think it's acceptable to test if ! defined( 'MW_PHPUNIT...' ) in WikibaseClient? [16:06:40] no way we can do proper dependency injection for the Lua integration tests [16:08:21] hoo: we should never have put caching in the factory - construction and caching are two different things [16:08:55] Hallo. [16:08:58] JeroenDeDauw: I mean caching like "if ( $this->propertyDataTypeLookup === null ) {" [16:09:04] Shall I just remove it where it hurts? [16:09:14] hi aharoni :) I just deployed the configuration patch [16:09:18] hoo: I know you mean that, this is what I am talking about [16:09:28] aharoni: Works: https://test.wikidata.org/w/index.php?title=Q22&action=history&uselang=rwr [16:09:34] hoo: please talk to DanielK, he added it [16:10:12] hoo : on https://test.wikidata.org , am I supposed to see the input boxes for writing labels in languages that I have in my babel box? [16:10:33] aharoni: I think so, yes [16:10:38] I don't [16:10:39] I used ?uselang get parameter [16:10:42] yikes [16:10:54] I don't see it in https://test.wikidata.org/wiki/Q42 . [16:10:56] JeroenDeDauw: Will catch him [16:12:02] aharoni: Will have a look [16:12:39] also, hoo, I went to https://test.wikidata.org/wiki/Q42?uselang=rwr and tried to add a label , and got [16:12:42] "An error occurred while trying to perform save and because of this, your changes could not be completed." [16:12:47] Details: Internal Server Error [16:12:54] wtf [16:13:38] ok, can reproduce now [16:14:06] aharoni: For Q22 it works [16:14:49] Q22 seems completely broken [16:14:53] don't use it [16:15:35] q22 is broken? or q42? [16:15:47] aharoni: Q42 is broken [16:15:52] Q22 works... sorry :P [16:15:54] oh [16:16:00] https://test.wikidata.org/wiki/Q22 [16:16:07] aude's kitten test item :) [16:16:20] Everything works for me with it [16:16:33] hoo : works for q55 [16:16:39] it's curious that q42 is broken [16:16:49] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/443e10a : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23686952 [16:16:58] [2014-04-24 16:14:37] Fatal error: Call to a member function getEntity() on a non-object at /usr/local/apache/common-local/php-1.24wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php on line 488 [16:17:13] [13WikibaseDataModel] 15thiemowmde closed pull request #70: Refactor isEmpty a bit and add isEntitled (06master...06isEntitled) 02http://git.io/AKmA3Q [16:18:24] (03PS2) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityContent::STATUS_UNTITLED [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 [16:18:30] didn't I patch that *thinks* [16:20:13] ah https://gerrit.wikimedia.org/r/#/c/120529/2/repo/includes/EditEntity.php [16:21:14] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129422 (owner: 10Hoo man) [16:24:08] aharoni: Ignore those errors, they will be gone after the next deploy [16:24:14] just test on Q22 :P [16:24:33] thanks hoo [16:25:08] I guess that now we should make it possible to also select it in ULS, so we wouldn't need ?uselang and Babel tricks. [16:25:35] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06isEntitled at 149cad4ca: 02http://git.io/T6tFbw [16:25:47] mh... isn't that confusing if we have no interface localization? [16:25:49] But I'll have to define well what does it mean to "select Ottoman Turkish", because it doesn't make sense to select Ottoman Turkish as a user interface language :) [16:25:56] yeah, exactly. [16:26:16] so some functionality is needed for Ottoman Turkish, but some other functionality is not needed. [16:26:44] Putting the right codes in Babel should help as a start, but we may have to think how to use ULS in a smart way for that. [16:27:06] yeah, I guess the babel box is good enough for now... it's quite handy actually IMO :) [16:30:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [16:38:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [16:40:02] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] (mw1.24-wmf2) - 10https://gerrit.wikimedia.org/r/129423 (owner: 10Hoo man) [16:42:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [16:43:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler) [16:44:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [16:44:43] (03PS1) 10Hoo man: Don't cache PropertyDataTypeLookup in WikibaseClient [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129457 [16:45:11] JeroenDeDauw: ^ [16:50:12] JeroenDeDauw: Or maybe shall I allow to like "recreate" the default instance? So that I can just purge it before the integration tests (and after) [16:50:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129457 (owner: 10Hoo man) [17:04:11] [13WikibaseDataModel] 15JeroenDeDauw created 06gs (+1 new commit): 02http://git.io/dVbg4Q [17:04:11] 13WikibaseDataModel/06gs 14001e83f 15jeroendedauw: Add group setters to Fingerprint and rename getAliases [17:04:26] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #74: Add group setters to Fingerprint and rename getAliases (06master...06gs) 02http://git.io/Ge6Gmg [17:04:40] Thiemo_WMDE: I thought you had already made this rename... https://github.com/wmde/WikibaseDataModel/pull/74 [17:06:05] JeroenDeDauw: yes. where did it go? [17:06:26] Thiemo_WMDE: perhaps you wrongly put it in the 1.0.x branch? [17:06:36] If so, I'll soon find out with a merge conflict :) [17:06:37] https://github.com/wmde/WikibaseDataModel/pull/61 [17:06:51] yup [17:07:07] Which means I'll have to do some resolving before I can use the new stuff I added [17:07:49] [travis-ci] wmde/WikibaseDataModel/rem/a514e2a : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23691078 [17:09:37] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/H7_1RQ [17:09:37] 13WikibaseDataModel/06master 146460688 15thiemowmde: Merge pull request #74 from wmde/gs... [17:11:32] JeroenDeDauw: did i merged to fast? [17:11:52] Thiemo_WMDE: ?? [17:12:19] i wonder where the merge conflict will happen [17:12:30] Thiemo_WMDE: on the 1.0.x branch [17:12:41] Thiemo_WMDE: don't worry about it, I will fix that in a sec [17:12:49] ok. [17:13:31] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 061.0.x: 02http://git.io/CkPwpg [17:13:31] 13WikibaseDataModel/061.0.x 143c61341 15jeroendedauw: Merge branch 'master' into 1.0.x [17:21:46] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 061.0.x: 02http://git.io/oRhCog [17:21:46] 13WikibaseDataModel/061.0.x 1422d6795 15jeroendedauw: Fix rename issue [17:21:56] [travis-ci] wmde/WikibaseDataModel/gs/001e83f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23692010 [17:28:44] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14a514e2a to 145a64991: 02http://git.io/ahYWpg [17:28:44] 13WikibaseDataModel/06rem 145a64991 15jeroendedauw: Legacy code removal... [17:34:59] hoo: https://github.com/wmde/WikibaseDataModel/pull/75 [17:35:02] [13WikibaseDataModel] 15JeroenDeDauw created 06i18n (+1 new commit): 02http://git.io/LQu3hw [17:35:02] 13WikibaseDataModel/06i18n 141d6f2bd 15jeroendedauw: Remove i18n stuff [17:35:25] hoo: please either merge this or provide an alternate solution; DataModel 0.7.4 release is now blocked by this stupid stuff [17:35:54] good enough imo... merged [17:35:57] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/BxGZeQ [17:35:57] 13WikibaseDataModel/06master 14bcf23d3 15Marius Hoch: Merge pull request #75 from wmde/i18n... [17:36:22] [13WikibaseDataModel] 15mariushoch 04deleted 06i18n at 141d6f2bd: 02http://git.io/idUJHA [17:38:49] hoo: can you do me a favour and verify this does not mess up Special:Version now? [17:39:02] hoo: I do not have a MediaWiki install, so this is rather hard for me [17:39:29] JeroenDeDauw: Sure, one second [17:40:22] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/eFsmUA [17:40:22] 13WikibaseDataModel/06master 148aa12ed 15jeroendedauw: 0.7.4 release [17:41:32] JeroenDeDauw: Looks good, description is just empty [17:43:18] hoo: fantastic [17:43:50] [13WikibaseDataModel] 15JeroenDeDauw tagged 060.7.4 at 06master: 02http://git.io/uKjygA [17:49:23] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 145a64991 to 14a37badf: 02http://git.io/ahYWpg [17:49:23] 13WikibaseDataModel/06rem 14a37badf 15jeroendedauw: Legacy code removal... [17:53:03] [travis-ci] wmde/WikibaseDataModel/rem/5a64991 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23693378 [18:05:03] [travis-ci] wmde/WikibaseDataModel/i18n/1d6f2bd : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23693703 [18:27:59] [travis-ci] wmde/WikibaseDataModel/0.7.4/8aa12ed : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23694427 [18:32:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler) [18:33:04] (03CR) 10Siebrand: [C: 031] New Wikidata Build - 24/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/129391 (owner: 10WikidataBuilder) [18:35:06] [travis-ci] wmde/WikibaseDataModel/rem/a37badf : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23694908 [18:46:52] (03CR) 10Hoo man: [C: 04-1] "Don't merge (yet)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129457 (owner: 10Hoo man) [19:36:11] (03CR) 10Hoo man: [C: 04-1] "Mostly style nitpicks... I hope you really caught all instances, so that we really validate everywhere" (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [19:37:07] (03PS1) 10Aude: Remove rc_cur_time attribute in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129523 [19:43:38] aude: Is $wgContentHandlerUseDB = true a req. for using Wikbiase? [19:43:41] * Wikibase [19:44:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129523 (owner: 10Aude) [19:44:55] (03CR) 10Hoo man: [C: 032] Remove rc_cur_time attribute in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129523 (owner: 10Aude) [19:45:20] (03Merged) 10jenkins-bot: Remove rc_cur_time attribute in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129523 (owner: 10Aude) [19:47:56] hoo: for client, no. for repo, not entirely sure but at least strongly advised or is needed [19:48:26] * aude thinks it should be true for wmf wikis now [19:49:04] aude: mh... Daniel complained as I assume it to be true in https://gerrit.wikimedia.org/r/#/c/120857/6 [19:49:17] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129535 (owner: 10L10n-bot) [19:50:35] "This field only exists $wgContentHandlerUseDB is true. On many Wikimedia wikis, it does not exist and would cause an SQL error." [19:50:41] :P On a repo class [19:51:11] ah, yes.... [19:51:34] Still going to build in the switch, but I'm not sure it's needed... also globals :( [19:51:36] if we want $wgContentHandlerUseDB = true on wmf wikis, then that requires schema change [19:51:51] in many places [19:52:17] I know [19:52:28] but that script should only affect wikidata (and testwikidata= [19:52:30] what about commons, for example [19:52:31] * ) [19:52:41] when it gets wikibase repo? will we do schema changes? [19:52:45] well, if we want it to have a repo, we should probably do the changes IMO [19:53:07] agree, but not convinced it's totally required [19:54:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/23437a2 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23703075 [19:55:45] hoo: i would ask daniel to clarify [19:56:04] it it required to be true for repo [19:56:31] mh... going to upload a new PS and see what Daniel says tomorrow [20:02:36] ok [20:04:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/bcc1547 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23703591 [20:16:24] (03CR) 10Hoo man: Check the content model of pages in EntityPerPageBuilder (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [20:16:47] (03PS7) 10Hoo man: Check the content model of pages in EntityPerPageBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 [20:18:27] (03CR) 10Hoo man: "Addressed Daniel's comments (this makes EntityContentFactory a bit nicer :) )" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [20:22:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [22:09:45] (03CR) 10Jeroen De Dauw: "I'm still unsure what the responsibility of these things is, and am just observing something that definitely looks like feature creep" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129244 (owner: 10Daniel Kinzler) [23:21:43] hiho [23:32:16] m [23:43:15] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/cSaflg [23:43:15] 13WikibaseDataModel/06master 1486deae2 15Jeroen De Dauw: Update RELEASE-NOTES.md