[08:20:21] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Browsertests: move creation of new properties to property_page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123861 (owner: 10Tobias Gritschacher)
[08:20:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Browsertests: move creation of new properties to property_page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123861 (owner: 10Tobias Gritschacher)
[08:21:51] <grrrit-wm>	 (03PS3) 10Tobias Gritschacher: Converted Ruby pageObjects to modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125172 
[08:28:34] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125172 (owner: 10Tobias Gritschacher)
[08:33:07] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/6947a43 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23490007
[09:46:26] <jem->	 !status
[09:47:04] <jem->	 Ooops, wrong channel :)
[09:54:18] <addshore>	 :D
[10:00:24] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 22/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/127892 
[10:13:15] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/127892 (owner: 10WikidataBuilder)
[10:32:06] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "For the record, this fixes Bug 64046." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 (owner: 10Daniel Kinzler)
[10:34:46] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] "Lets see if this passes the browser tests!" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/127892 (owner: 10WikidataBuilder)
[10:49:19] <addshore>	 oh no >.> my laptop charger has broken ...
[11:16:38] <hoo>	 DanielK_WMDE: aude: Y u no review https://gerrit.wikimedia.org/r/125725 ?
[11:17:11] <DanielK_WMDE>	 hoo: 'cause i'm stuck in a refactoring tangle, and can't find my way out :/
[11:17:26] <DanielK_WMDE>	 also, maintenance scripts are a pain to test
[11:17:47] <DanielK_WMDE>	 but i'll try to get to it later this afternoon. but first i'm getting my heair cut :)
[11:18:10] <hoo>	 Yeah, they are... I did a lot of manual evilness to my database to have a testable state :D
[11:18:21] <DanielK_WMDE>	 hmhm :P
[11:18:27] <DanielK_WMDE>	 ok, bbl
[11:46:23] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/127892 (owner: 10WikidataBuilder)
[11:48:48] <hoo>	 Tobi_WMDE: "      WikibaseAPI::APIError: API error: code 'error', info 'API error: You do not have sufficient permissions' (WikibaseAPI::APIError)" ^
[11:49:58] <addshore>	 this happened on friday also
[11:50:06] <addshore>	 hence I reverted the buil commit on friday :)
[11:50:27] <addshore>	 and abandoned all over the weekend
[11:51:25] <Tobi_WMDE>	 hoo: addshore I'll look into it tomorrow when I'm back in the office.. It's hard to reproduce while on the train.. 
[11:51:33] <addshore>	 :D
[11:51:59] <Tobi_WMDE>	 Probably some permissions changed? 
[11:52:49] <Tobi_WMDE>	 Probably WikidataTester user is not allowed to create new items or properties on beta? 
[11:53:24] <hoo>	 very possible
[11:54:24] <Tobi_WMDE>	 Of someone could try tests locally and they pass then it's most likely a problem with beta.. 
[11:55:39] <hoo>	 would probably take ages for me to only get stuff to run, so I rather not :P
[11:56:06] <Tobi_WMDE>	 hoo: too pessimistic.. ;) 
[11:56:24] <Tobi_WMDE>	 It's a matter of one or two minutes.. 
[11:56:35] <Tobi_WMDE>	 But I'll check tomorrow.. 
[11:56:43] <hoo>	 I'm doing Lua stuffs atm, so rather big change :P
[11:59:53] <addshore>	 right
[12:00:00] <addshore>	 im just about to run out of laptop battery.....
[12:00:18] <addshore>	 time to go and buy a charger with next day delivery! :D
[12:16:33] <grrrit-wm>	 (03CR) 10Hoo man: New Lua interface for creating infoboxes (0317 comments) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man)
[12:17:12] <grrrit-wm>	 (03PS11) 10Hoo man: New Lua interface for creating infoboxes [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 
[12:17:45] <grrrit-wm>	 (03CR) 10Hoo man: "Addressed Daniel's comments" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man)
[13:18:00] <grrrit-wm>	 (03PS3) 10Daniel Kinzler: (bug 62643) Move term validation into ChangeOps. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 
[13:18:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] (bug 62643) Move term validation into ChangeOps. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler)
[13:23:55] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler)
[13:32:40] <lazowik>	 \o/
[13:32:53] <lazowik>	 three requests make an office hour!
[13:33:19] <lazowik>	 :p
[13:33:43] <lazowik>	 hmm
[13:34:04] <Lydia_WMDE>	 lazowik: that's what i promised johnlewis and i keep my promises ;-)
[13:34:13] <lazowik>	 hehe
[13:34:20] <lazowik>	 I just noticed
[13:34:26] <lazowik>	 JohnFlightLevelewis
[13:34:27] <lazowik>	 :D
[13:34:35] <lazowik>	 ("JohnFLewis set the topic at: 8 kwi 2014 20:46")
[13:55:16] <grrrit-wm>	 (03CR) 10Siebrand: "The changes in vendor should make it into the correct modules upstream. I'll see if I can get that done, too." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/128412 (owner: 10L10n-bot)
[13:56:44] <tuxnani>	 GerardM: Hi there
[13:57:42] <GerardM>	 hoi tuxnani 
[13:59:02] <tuxnani>	 GerardM, I needed your help in motivating me more towards Wikidata
[13:59:39] <GerardM>	 <grin> do I do not enough
[14:01:25] <tuxnani>	 As you are aware I have been doing outreach activities in colleges, among enthusiasts and existing wikipedians now and then
[14:01:34] <Stryn>	 Lydia_WMDE: do you mind if I add Wikidata office hour to https://meta.wikimedia.org/wiki/IRC_office_hours or do you want to do it?
[14:01:44] <tuxnani>	 I am aware that wikidata helps improve article quality at wikipedia
[14:01:50] <Lydia_WMDE>	 Stryn: oh shoot. please do. i forgot that
[14:02:08] <Stryn>	 {{done}} :)
[14:02:11] <Lydia_WMDE>	 \o/
[14:02:13] <Lydia_WMDE>	 thx
[14:02:42] <tuxnani>	 and also, I started using reasonator
[14:04:17] <GerardM>	 good for you
[14:05:10] <GerardM>	 what is your Wikidata profile ?
[14:05:40] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/128412 (owner: 10L10n-bot)
[14:06:00] <tuxnani>	 https://www.wikidata.org/wiki/Special:Contributions/%E0%B0%B0%E0%B0%B9%E0%B1%8D%E0%B0%AE%E0%B0%BE%E0%B0%A8%E0%B1%81%E0%B0%A6%E0%B1%8D%E0%B0%A6%E0%B1%80%E0%B0%A8%E0%B1%8D
[14:06:37] <tuxnani>	 But am unable to tell people on  how wikidata training for volunteers will improve the quality of articles.
[14:07:01] <GerardM>	 right
[14:32:43] <DanielK_WMDE>	 tuxnani: i think the main thing to consider is that it will mainly improve the quality of articles on "small languages", i.e. wikis with a smal editor base. For enwiki, wikidata is sure nice and saves some work, but won't make that much of a difference.
[14:35:10] <grrrit-wm>	 (03PS4) 10Aude: Adjust check for failed job queue push in dispatch changes and update move [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 
[14:35:35] <aude>	 not a blocker but would be good to have, so we are not suprised again ^
[14:37:34] <grrrit-wm>	 (03CR) 10Aude: "this makes our job handling more robust." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude)
[14:41:46] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude)
[15:07:21] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/128412 (owner: 10L10n-bot)
[15:38:01] <gh-wmde>	 [13Diff] 15siebrand opened pull request #9: Update i18n shim (06master...06shim-update) 02http://git.io/Qwa1VA
[15:38:11] <gh-datavalues>	 [13DataValues] 15siebrand opened pull request #4: Update i18n shim (06master...06shim-update) 02http://git.io/xHVeCA
[15:38:16] <gh-wmde>	 [13ValueView] 15siebrand opened pull request #48: Update i18n shim (06master...06shim-update) 02http://git.io/bW4zMw
[15:48:14] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#120 (REL1_23 - eb36cb4 : Translation updater bot): The build has errored.
[15:48:14] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/b1f589595502...eb36cb4b3b19
[15:48:14] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/23520045
[15:53:04] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: Localize error parameters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 
[15:58:54] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler)
[16:36:22] <Schisma______>	 hi
[16:36:47] <Schisma______>	 can I get json results from the search api somehow?
[16:37:08] <DanielK_WMDE>	 Schisma______: format=json?
[16:37:44] <Schisma______>	 http://musicbrainz.org/ws/2/recording/?query=artist:%22Red%20Hot%20Chili%20Peppers%22%20AND%20release:%22Suck%20My%20Kiss%22&format=json 
[16:37:59] <Schisma______>	 like this?
[16:38:15] <DanielK_WMDE>	 Schisma______: that's a musicbrainz url, can't help you with that :)
[16:38:55] <Schisma______>	 like, it doesn't work with this api?
[16:39:39] <nikki>	 for musicbrainz you want fmt=json, but this is #wikidata :P
[16:39:53] <Schisma______>	 arg
[16:39:54] <Schisma______>	 thanks
[16:40:12] <Schisma______>	 stupid client ^^
[16:40:25] <lazowik>	 :D
[16:49:58] <nikki>	 hmm, where's the best place to request undeletion? administrators' noticeboard?
[16:50:07] <ajr>	 probably
[16:50:14] <ajr>	 or you could just link me to whatever you want undeleted :P
[16:50:23] <ajr>	 that might be faster
[16:51:21] <nikki>	 haha ok, https://www.wikidata.org/wiki/Q15099024 I believe was a place called muttonville before it deleted, which is the place of death of https://www.wikidata.org/wiki/Q1707526
[16:52:24] <ajr>	 Done!
[16:52:33] <nikki>	 thanks :D
[16:52:39] <ajr>	 no problem
[17:10:50] <legoktm>	 DanielK_WMDE: ping? do you have time to look at https://gerrit.wikimedia.org/r/#/c/109850/ ?
[17:19:44] <DanielK_WMDE>	 legoktm: briefly. i'd like to better understand Parent5446's criticism.
[17:19:56] <legoktm>	 same...
[17:20:35] <DanielK_WMDE>	 legoktm: from a first look: there is no a factory, which is using builders, so the caller doesn't have to know the implementation. sounds good to me.
[17:20:40] <DanielK_WMDE>	 the rest is details :)
[17:20:52] <DanielK_WMDE>	 * "there is now"
[17:22:34] <DanielK_WMDE>	 legoktm: one thing though... ideally, i would ask for a config *for* something, not of a specific *type*.
[17:23:12] <legoktm>	 what do you mean by "something"? 
[17:23:14] <DanielK_WMDE>	 i want to say "give me a config object for the file storage", not "give me a db based config object".
[17:23:21] <legoktm>	 ah
[17:23:22] <legoktm>	 hmm
[17:23:30] <DanielK_WMDE>	 works exactly the same
[17:23:37] <DanielK_WMDE>	 just rename "type" to "name" or "target".
[17:23:48] <DanielK_WMDE>	 or whatever you fance - just not "type".
[17:24:22] <DanielK_WMDE>	 legoktm: think about it this way: maybe you have two extensions using a db based config, with different key prefixes. or two modules that use config files, with different pathes.
[17:24:46] <legoktm>	 yeah, I see what you're getting at
[17:24:50] <legoktm>	 $name sounds good to me
[17:24:54] <DanielK_WMDE>	 you really want the same "type" of config several times, with different parameters (the parameters are provided by the builders)
[17:25:16] <DanielK_WMDE>	 hm... i'll copy&past some of this into the review
[17:27:20] <legoktm>	 thanks :)
[17:27:58] <DanielK_WMDE>	 there
[17:30:39] <legoktm>	 DanielK_WMDE: done :)
[17:56:12] <gh-wmde>	 [13Diff] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/Nq242g
[17:56:12] <gh-wmde>	 13Diff/06master 14b748217 15Siebrand Mazeland: Update i18n shim...
[17:56:12] <gh-wmde>	 13Diff/06master 144f9f946 15Marius Hoch: Merge pull request #9 from siebrand/shim-update...
[17:58:32] <hoo|away>	 Lydia_WMDE: JeroenDeDauw: In which extensions do we care about pre-1.23 compat?
[17:58:39] <hoo|away>	 Probably only Diff, right?
[18:24:55] <grrrit-wm>	 (03PS4) 10Daniel Kinzler: (bug 62643) Move term validation into ChangeOps. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 
[18:28:59] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler)
[18:36:23] <JeroenDeDauw>	 hoo|away: Diff is not an extension
[18:36:32] <JeroenDeDauw>	 hoo|away: most of our components do not depend on MediaWiki
[18:36:37] <JeroenDeDauw>	 That includes Diff
[18:37:45] <JeroenDeDauw>	 hoo|away: https://github.com/wmde/Diff/commit/b748217e2454ef0c159f16fd339ef5f42a782701
[18:37:59] <JeroenDeDauw>	 Does that mean it will now break when included together with MW < 1.23?
[18:39:11] <gh-wmde>	 [13DataTypes] 15JeroenDeDauw closed pull request #15: Update i18n shim (06master...06shim-update) 02http://git.io/SBKNiQ
[18:39:26] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/6rRHZA
[18:39:26] <gh-wmde>	 13WikibaseDataModel/06master 14a765fd7 15Siebrand Mazeland: Update i18n shim...
[18:39:26] <gh-wmde>	 13WikibaseDataModel/06master 14e9da7a8 15Jeroen De Dauw: Merge pull request #69 from siebrand/shim-update...
[19:05:54] <hoo>	 JeroenDeDauw: If diff is not an extension, why does it even need the l10n shim stuff?
[19:06:29] <hoo>	 and: Do we really care about b/c with 1.22 for the other extensions?
[19:06:43] <hoo>	 (does that even work at all?)
[19:07:47] <JeroenDeDauw>	 hoo: for our extensions we do not
[19:07:52] <JeroenDeDauw>	 hoo: they need 1.23 anyway
[19:08:10] <JeroenDeDauw>	 hoo: Diff "needs" it because of Special:Version
[19:08:14] <JeroenDeDauw>	 Somewhat silly
[19:08:18] <JeroenDeDauw>	 Might just kill that
[19:09:22] <hoo>	 JeroenDeDauw: Ok, so rather remove the shims than update them
[19:09:36] <JeroenDeDauw>	 hoo: sounds good
[19:21:57] <hoo>	 aude: http://demos.filbertkm.com/wikistats/wikidata.php :'-(
[19:26:45] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler)
[19:29:06] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129009 (owner: 10L10n-bot)
[19:39:30] * hoo  kicks the wikidata job queue for being rather long and not going down

[19:39:34] <hoo>	 can't test like that *sigh*
[19:47:39] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f97ff93 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23536835
[19:49:30] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Looks very good overall. Just a few nitpicks and questions." (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler)
[19:57:21] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "One side note is done. :-)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/128938 (owner: 10Daniel Kinzler)
[20:44:02] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14ae53bbe to 1428fd2e8: 02http://git.io/ahYWpg
[20:44:02] <gh-wmde>	 13WikibaseDataModel/06rem 1428fd2e8 15jeroendedauw: [WIP] Legacy code removal...
[20:49:00] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/rem/28fd2e8 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23542642
[20:53:21] <gh-wmde>	 [13ValueView] 15addshore closed pull request #48: Update i18n shim (06master...06shim-update) 02http://git.io/bW4zMw
[20:54:01] <gh-wmde>	 [13Ask] 15addshore pushed 2 new commits to 06master: 02http://git.io/ipKQng
[20:54:01] <gh-wmde>	 13Ask/06master 14f6cf6e6 15Siebrand Mazeland: Update i18n shim...
[20:54:01] <gh-wmde>	 13Ask/06master 142f8b434 15addshore: Merge pull request #5 from siebrand/shim-update...
[20:54:15] <gh-datavalues>	 [13DataValues] 15addshore closed pull request #4: Update i18n shim (06master...06shim-update) 02http://git.io/xHVeCA
[20:55:20] <gh-wmde>	 [13WikibaseQuery] 15addshore pushed 2 new commits to 06master: 02http://git.io/Nd6-sA
[20:55:21] <gh-wmde>	 13WikibaseQuery/06master 1494ae95f 15Siebrand Mazeland: Update i18n shim...
[20:55:21] <gh-wmde>	 13WikibaseQuery/06master 14c9b2236 15addshore: Merge pull request #17 from siebrand/shim-update...
[21:00:29] <travis-ci>	 [travis-ci] wmde/WikibaseQuery/master/c9b2236 : addshore The build was broken. http://travis-ci.org/wmde/WikibaseQuery/builds/23543670
[22:02:01] <hoo>	 wtf
[22:04:26] <hoo>	 wtf
[22:04:27] <hoo>	 wtf
[22:04:46] <dennyvrandecic>	 ?
[22:04:49] <aude>	 wtf!
[22:04:54] <aude>	 :)
[22:05:02] <hoo>	 Is nobody ever looking at unit test results these days?
[22:05:08] * aude  holiday

[22:05:22] <aude>	 travis?
[22:05:58] <hoo>	 aude: The Lua tests are completely broken
[22:06:02] <hoo>	 and so is travis
[22:06:03] <aude>	 oh no
[22:06:06] <hoo>	 but nobody cared
[22:07:44] <aude>	 client sitelink lookup broken
[22:08:06] <aude>	 seems to be related to sites table
[22:08:43] <hoo>	 how on earth can that ever happen?
[22:09:00] <hoo>	 and why does no one notice
[22:09:39] <aude>	 no idea
[22:09:56] <aude>	 suppose first question is can anyone reproduce test failures?
[22:10:03] <aude>	 why do they not fail on jenkins, also?
[22:10:12] <hoo>	 the tests are totally failing for me, but are passing on jenkins and nobody seems to watch travis anymore
[22:10:29] <hoo>	 also those pass on travis, only unrelated failures there
[22:10:35] <hoo>	 very weird
[22:10:46] <hoo>	 maybe the Scribunto setup on those isn't correct?
[22:11:56] <hoo>	 that's it
[22:12:01] <aude>	 probably
[22:12:09] <hoo>	 whoever updated the travis stuff last forgot to include scribunto
[22:12:15] <hoo>	 we're still cloning it, but not loading
[22:12:15] <aude>	 :(
[22:12:26] <aude>	 easy enough to fix
[22:14:02] <grrrit-wm>	 (03PS1) 10Hoo man: Include Scribunto on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129050 
[22:14:06] <hoo>	 aude: ^ :)
[22:14:16] <hoo>	 Will fix the stuff afterwards
[22:14:54] <hoo>	 (travis is broken anyway, so nothing to lose)
[22:15:59] <aude>	 include scribunto for repo also? (see no harm)
[22:16:17] <hoo>	 aude: Yep... doesn't matter after all
[22:16:26] <hoo>	 but more extension -> more realistic
[22:16:33] <aude>	 sure
[22:17:39] <grrrit-wm>	 (03CR) 10Aude: [C: 032] "looks ok... no harm having on all setups" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129050 (owner: 10Hoo man)
[22:18:03] <hoo>	 Thanks :)
[22:18:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Include Scribunto on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129050 (owner: 10Hoo man)
[22:19:03] <aude>	 scribunto tests are failing for me
[22:19:20] <aude>	 don't know if configuration changed or what
[22:19:35] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129050 (owner: 10Hoo man)
[22:19:52] <hoo>	 aude: will bisect or so... something broke them
[22:20:14] <aude>	 ok
[22:20:37] <aude>	 is scribunto also not enabled on jenkins?
[22:21:38] <hoo>	 aude: Not sure, but I don't think our jenkins has it
[22:21:50] <aude>	 i pretty much copied the setup scripts to travis
[22:21:57] * aude  checks

[22:21:58] <hoo>	 The broken ones?
[22:22:11] <aude>	 the apply settings thing
[22:23:05] <hoo>	 ah, that makes sense :/
[22:23:12] <hoo>	 Luckily I have my own tests scripts
[22:23:29] <aude>	 and i've not run tests in a week or so
[22:23:51] <hoo>	 I only ran them after I tried to work on another bug
[22:24:16] <aude>	 jenkins should be able to reuse the travis scripts since they are part of wikibase
[22:24:25] <hoo>	 I just couldn't get the Lua stuff to work so I at some point went to run the tests... and booooom :/
[22:24:32] <aude>	 though not investing time into that now
[22:24:40] <aude>	 :(
[22:27:12] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b1d9b42 : Marius Hoch The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23549606
[22:35:42] <pawczu>	 hi
[22:42:50] <hoo>	 aude: got it...
[22:43:29] <hoo>	 almost
[22:47:49] <grrrit-wm>	 (03PS1) 10Hoo man: Fix WikibaseLuaBindings after SiteLinkLookup change [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129057 
[22:48:38] <hoo>	 aude: ^
[22:48:44] <aude>	 ok
[22:48:51] <hoo>	 wait, damn
[22:48:57] <hoo>	 forgot to git add a file
[22:49:38] <grrrit-wm>	 (03PS2) 10Hoo man: Fix WikibaseLuaBindings after SiteLinkLookup change [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129057 
[22:51:45] <aude>	 is that all the failures?
[22:52:06] <hoo>	 aude: No, but all that block me from continuing right now
[22:52:15] <hoo>	 at least I hope :/
[22:52:37] <aude>	 ok
[22:52:41] * aude  gets http://pastie.org/9101935

[22:53:08] <hoo>	 ok... with the above patch?
[22:53:27] <hoo>	 With the patch that works for me
[22:54:37] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129057 (owner: 10Hoo man)
[22:54:47] <hoo>	 wtf
[22:55:23] <hoo>	 oh, that's PS1, doh
[22:55:59] <hoo>	 but apparently jenkins is running (at least some of) the Lua tests?!
[22:56:38] <aude>	 is it?
[22:57:06] <hoo>	 http://wdjenkins.wmflabs.org/ci/job/wikibase-client-tests/911/consoleFull
[22:57:14] <hoo>	 1) Wikibase\Client\Scribunto\Test\WikibaseLuaBindingsTest::testGetEntityId
[22:57:42] <hoo>	 ah, but I think those are the real unit tests that don't need Scribunto (the integration tests need Scribunto)
[22:58:06] <aude>	 based on --group ?
[22:58:14] <hoo>	 aude: No, based on black magic
[22:58:36] <hoo>	 The unit tests never failed because they used a mock which still had the old SiteLinkLookup behaviour... weird
[22:58:52] <aude>	 InvalidArgumentException: Data value type mismatch. Expected an EntityId.
[22:58:56] * aude  rage

[22:59:00] <aude>	 EntityId is not a DataValue
[22:59:04] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129057 (owner: 10Hoo man)
[22:59:07] <hoo>	 aude: https://gerrit.wikimedia.org/r/#/c/129057/2/client/tests/phpunit/includes/scribunto/WikibaseLuaBindingsTest.php
[22:59:10] * aude  supposed to sort that out

[22:59:33] <hoo>	 They should ahve updated the mock(s) along with the real classes
[22:59:41] <hoo>	 in that case that would have never went in broken :(
[22:59:54] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Fix WikibaseLuaBindings after SiteLinkLookup change [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129057 (owner: 10Hoo man)
[23:00:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix WikibaseLuaBindings after SiteLinkLookup change [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129057 (owner: 10Hoo man)
[23:00:41] <hoo>	 I'll ping Tobi(?) tomorrow to have Scribunto on wikidatajenkins
[23:02:44] <aude>	 got it
[23:02:53] <hoo>	 mh?
[23:03:13] <aude>	 doing pull request
[23:03:20] <hoo>	 ah
[23:03:27] <aude>	 then he needs to be pinged to merge and ensure it's deployed
[23:07:23] <hoo>	 will ping him tomorrow
[23:08:25] <aude>	 ok
[23:09:02] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/bd534b3 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23551919
[23:29:25] <grrrit-wm>	 (03PS1) 10Hoo man: Move the messages to describe novalue and somevalue Snaks to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129072 
[23:31:11] <grrrit-wm>	 (03PS2) 10Hoo man: Move the messages to describe novalue and somevalue Snaks to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129072 
[23:36:23] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129072 (owner: 10Hoo man)
[23:41:28] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129072 (owner: 10Hoo man)