[07:40:53] (03CR) 10Siebrand: Rename somewhat confusing variable names in ApiErrorReporter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 (owner: 10Thiemo Mättig (WMDE)) [09:07:28] [13WikibaseDataModel] 15addshore 04deleted 06from_numeric_id at 14b066021: 02http://git.io/tr1VZA [09:07:31] la la la [09:10:37] (03CR) 10Addshore: [C: 031] "looks okay" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126720 (owner: 10Thiemo Mättig (WMDE)) [09:12:26] (03Abandoned) 10Addshore: Special:MergeItems error message should be improved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 (owner: 10Karan) [09:19:03] (03CR) 10Thiemo Mättig (WMDE): (bug 62824) ParseValue api to return localized errors (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120007 (owner: 10Daniel Kinzler) [09:29:53] DanielK_WMDE: Thiemo_WMDE: can one of you open the hangout later? i'll call in. kitchen work still in progress -.- [09:30:12] sure [09:30:40] there'S just the two of us here. do you really want to do a daily? [09:30:54] addshore: ? D [09:30:57] :D even [09:31:14] if he's not joining we can skip it [09:42:22] oh hi Lydia_WMDE [09:42:36] oh hi addshore :P [09:42:48] I'm not going to say anythign different to what I said yesterday :P [09:43:10] hehe alright. then let's skipt the daily for today [09:45:32] so we are not in a sprint right now? [09:45:37] Thiemo_WMDE: is finding lots of nasty little bugzezzz... [09:45:57] addshore: sprintbreak [09:46:06] new sprint on thuesday [09:46:09] and springbreak too [09:46:13] :D [09:46:16] well, thats my final sprint over then :P I guess Im going to go and find lots of annoying bugs to fix too :P [09:46:35] final working day for me is wednesday [09:46:43] *sob* [09:46:46] :P [09:47:47] * addshore loads up the bug list [09:49:29] I noticed that globecoordinatevalue.precision is allowed to be null, float or int but is validated just as float or integer in WikibaseDataTypeBuilders::buildCoordinateType. That might be another bug? [09:52:34] xchrdw: sounds like it. can you file one please? [09:52:40] ok [09:53:16] thx [10:00:24] (03PS1) 10WikidataBuilder: New Wikidata Build - 17/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126944 [10:08:46] Thiemo_WMDE: merged the api sandbox thing, in my opinion thats almost worthy of a backport :O [10:09:18] yes. it's blocked on wikidata.org. on the other hand its only the sandbox. [10:09:22] ask lydia. [10:09:33] Lydia_WMDE: ping? [10:09:59] by the way, who was responsible for the daily today? ;-) [10:10:03] addshore: Thiemo_WMDE: if we can get someone to do it yes [10:10:15] no idea who is around, might just leave it till later [10:10:18] Thiemo_WMDE: me. see above. canceled ;-) [10:14:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126944 (owner: 10WikidataBuilder) [10:26:30] (03CR) 10Addshore: [C: 032] New Wikidata Build - 17/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126944 (owner: 10WikidataBuilder) [10:30:13] (03PS1) 10Daniel Kinzler: Fix error handling in ParseValue. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 [10:30:46] addshore: would you review ---^ [10:30:53] already am ;p [10:31:14] \o/ [10:37:04] (03PS12) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [10:37:19] (03CR) 10Daniel Kinzler: "PS12 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [10:40:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 (owner: 10Daniel Kinzler) [10:42:41] (03CR) 10Daniel Kinzler: [C: 032] Rename somewhat confusing variable names in ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 (owner: 10Thiemo Mättig (WMDE)) [10:43:05] (03Merged) 10jenkins-bot: Rename somewhat confusing variable names in ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 (owner: 10Thiemo Mättig (WMDE)) [10:45:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [10:46:48] (03CR) 10Daniel Kinzler: "Agree with Thiemo." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [10:47:54] (03CR) 10Addshore: [C: 032] Fix error handling in ParseValue. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 (owner: 10Daniel Kinzler) [10:48:06] these new errors and stuff look interesting :p [10:48:50] (03CR) 10jenkins-bot: [V: 04-1] Fix error handling in ParseValue. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 (owner: 10Daniel Kinzler) [10:52:27] (03PS2) 10Daniel Kinzler: Fix error handling in ParseValue. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 [10:53:10] addshore: want to approve again? i rebased [10:53:41] will wait for jnekins :) [10:53:44] [13Number] 15thiemowmde created 06parse-exceptions (+1 new commit): 02http://git.io/j-FzWA [10:53:44] 13Number/06parse-exceptions 1411327ce 15Thiemo Mättig: More user-friendly API error messages... [10:55:48] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/00e8718 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23195093 [10:59:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 (owner: 10Daniel Kinzler) [10:59:45] [13Number] 15thiemowmde opened pull request #7: More user-friendly API error messages (06master...06parse-exceptions) 02http://git.io/Ku_NKg [11:00:11] (03CR) 10Addshore: [C: 032] Fix error handling in ParseValue. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 (owner: 10Daniel Kinzler) [11:00:28] (03Merged) 10jenkins-bot: Fix error handling in ParseValue. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126951 (owner: 10Daniel Kinzler) [11:00:50] [13Number] 15thiemowmde 04force-pushed 06parse-exceptions from 1411327ce to 14789f86c: 02http://git.io/_F4dAQ [11:00:50] 13Number/06parse-exceptions 14789f86c 15Thiemo Mättig: More user-friendly API error messages... [11:10:35] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/44b067c : daniel The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23196144 [11:10:41] [13Number] 15thiemowmde created 06quantity-exception (+1 new commit): 02http://git.io/HIDdvw [11:10:41] 13Number/06quantity-exception 145272a3f 15Thiemo Mättig: Don't repeat user input in error message... [11:15:46] Are we still using mw1.23-wmf19 with todays branch? [11:15:52] aude: ^^ [11:16:51] Reedy: no deployment from our side today [11:17:03] since aude is on vacation as is most of the rest of the team [11:17:17] so i guess tick with what we have [11:17:33] Fair enough [11:17:44] *stick [11:24:35] [13Number] 15thiemowmde opened pull request #8: Don't repeat user input in error message (06master...06quantity-exception) 02http://git.io/mL34ZA [11:32:14] (03CR) 10Thiemo Mättig (WMDE): Rename somewhat confusing variable names in ApiErrorReporter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 (owner: 10Thiemo Mättig (WMDE)) [11:46:12] how do I set sitelinks on an item object with this new fad datamodel stuff? O_o [11:47:40] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126944 (owner: 10WikidataBuilder) [12:01:31] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06code-smell from 1495cea39 to 14ebdd8ac: 02http://git.io/zlyA2w [12:01:31] 13WikibaseDataModel/06code-smell 14ebdd8ac 15Thiemo Mättig: Avoid code smell warnings by adding LogicExceptions... [12:13:36] Thiemo_WMDE: http://brightbyte.de/page/Git_CR [12:27:44] DanielK_WMDE: still around? :) [12:28:11] looks at mocking stuff for api tests to increase speed, what was your suggestion for 'TODO: provide a mechanism to override the services' again? [12:28:48] addshore: each api module should have a method called overrideServices that takes as parameters exactly the services used by the APi module. [12:29:14] the test then calls that. the signature of the method makes sure we don't forget to mock a service, especially when more services are added [12:29:33] right then, lets see if Ic ant try and get a first draft done today! [12:29:51] just finished rewriting the test data in EntityTestHelper to use the datamodel objects :P [12:29:52] addshore: the downside is that this doesn't work well with subclassing, because you'd need to change the method signature when overriding it for any subclass that needs additional services [12:30:26] addshore: EntityTestHelper can just die once we can inject a MockRepo into the API modules :) [12:30:34] DanielK_WMDE: I guess it could be a overrideServices method that takes and array with key = service name and value = mock service [12:30:42] then have a list of required services and check [12:30:55] yes, but that's less natural and more work. [12:31:01] but yea, it's an option. [12:31:34] really the only 'service' we need is a WikibaseRepo object/ [12:32:07] addshore: ah, but that's the kitchen sink fallacy. makes Demeter cry. [12:32:15] :P [12:32:37] addshore: think about it: to mak that, you have to mock everything anything could ever get from WikibaseRepo. You can't know what that module actually need. [12:32:43] that sucks. [12:32:53] (and that'S why Context is evil) [12:32:57] :D [12:32:58] it's tempting, but going to bite you [12:38:51] heh, its not even that easy to call the method we make on the api module object xD [12:41:39] addshore: well, the api test would work completely differently. it would not use core's API testing facility at all, but simply instantiate the module directly, without all the fluff. [12:41:47] could even mock ApiMain [12:48:52] DanielK_WMDE: im trying that now :P lets see how hard it ends up being ;p [12:49:06] oh, dont, just need to also mock Context and Language [12:49:08] *done [12:49:09] good luck :) [12:49:38] not sure these need to be mocked. but go ahead :) [12:50:19] now to work out how to shove params into the module :P [12:52:32] addshore: you give a FauxRequest to the Context? [12:52:37] just a guess [12:52:40] :P [12:52:43] yup :D [12:52:55] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06arrayobject from 140f58a44 to 141ea9777: 02http://git.io/kLOYOQ [12:52:55] 13WikibaseDataModel/06arrayobject 141ea9777 15Thiemo Mättig: Simplified overcomplicated constructor [13:01:30] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06arrayobject: 02http://git.io/HSVXgA [13:01:30] 13WikibaseDataModel/06arrayobject 14f02c44b 15Thiemo Mättig: Updated tests as requested in the comments [13:22:11] DanielK_WMDE: this looks pretty :> [13:24:33] addshore: \o/ [13:24:49] addshore: are you putting the helper functionality int oa separate class? [13:25:06] maybe somethign that wraps around the api module under test [13:25:14] well, right now Im just trying to figure everything out nicely with the getentities test module [13:25:31] ha, you started with the worst we have! [13:25:38] hehe :P [13:25:43] its fine, I wrote it :D [13:26:11] if I manage this the others should be easy right ;p [14:42:11] DanielK_WMDE: so close :P [15:26:32] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06fingerprint-convenience: 02http://git.io/Cdo-_g [15:26:32] 13WikibaseDataModel/06fingerprint-convenience 1428a3eb8 15Thiemo Mättig: Language magic removed and tests added [15:35:38] [13WikibaseDataModel] 15thiemowmde comment on pull request #59 1428a3eb8: When I look at the network graph this is on the 0.8.x branch. 02http://git.io/AnMu_Q [15:46:38] [13WikibaseDataModel] 15thiemowmde created 06getAliasGroups (+1 new commit): 02http://git.io/SiWwNw [15:46:38] 13WikibaseDataModel/06getAliasGroups 147753808 15Thiemo Mättig: Rename getAliases to getAliasGroups [15:48:38] [13WikibaseDataModel] 15thiemowmde opened pull request #60: Rename getAliases to getAliasGroups (06master...06getAliasGroups) 02http://git.io/Bs-m8A [15:53:36] [travis-ci] wmde/WikibaseDataModel/getAliasGroups/7753808 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23215762 [15:53:47] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06fingerprint-convenience: 02http://git.io/8qQUug [15:53:47] 13WikibaseDataModel/06fingerprint-convenience 14396ee29 15Thiemo Mättig: Moved setAliases to setAliasGroups rename to other pull request [16:08:56] (03PS1) 10Addshore: DNM WIP Refactor GetEntitiesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 [16:09:04] WOOO 127000 :D [16:10:09] (03PS2) 10Addshore: DNM WIP Refactor GetEntitiesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 [16:18:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [16:20:13] DanielK_WMDE: https://scrutinizer-ci.com/g/wmde/WikibaseDataModel/inspections/bff4fd23-b045-4b20-b5e9-787f19119007 [16:23:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [16:42:01] (03PS2) 10Daniel Kinzler: (bug 62643) Move term validation into ChangeOps. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 [16:43:54] (03PS1) 10Denny Vrandecic: Changed UI text "source" to "reference" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 [16:45:55] (03CR) 10Lydia Pintscher: [C: 031] "Good from PM side." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 (owner: 10Denny Vrandecic) [16:51:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124835 (owner: 10Daniel Kinzler) [16:57:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 (owner: 10Denny Vrandecic) [17:06:13] (03PS2) 10Denny Vrandecic: Changed UI text "source" to "reference" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 [17:12:38] (03CR) 10Lydia Pintscher: [C: 031] Changed UI text "source" to "reference" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 (owner: 10Denny Vrandecic) [17:13:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 (owner: 10Denny Vrandecic) [17:14:15] (03CR) 10Addshore: "In its current state this changes the running time of the getentities tests from 1.48 mins to just 44 seconds :)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [17:14:31] there is no one here to cheer with me :/ [17:14:34] Thiemo_WMDE! :P [17:14:55] addshore: \o/ [17:14:56] :D [17:15:04] that was a day well spent :) [17:15:13] :) [17:15:20] now to do it for ALLL OF THE TESTSTSSS [17:30:45] (03PS1) 10Addshore: Add method to override services in ApiWikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127008 [17:30:47] (03PS1) 10Addshore: Add method to override services in GetEntities API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 [17:35:51] (03PS1) 10Addshore: Store API test data in objects rather than an array [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127012 [17:39:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127008 (owner: 10Addshore) [17:42:46] (03PS1) 10Addshore: Introduce IndependentWikibaseApiTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127013 [17:48:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 (owner: 10Addshore) [17:48:54] sad bacon [17:50:14] (03PS3) 10Addshore: DNM WIP Refactor GetEntitiesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 [17:53:52] silly php [17:55:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127012 (owner: 10Addshore) [18:00:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127013 (owner: 10Addshore) [18:02:34] (03CR) 10Siebrand: [C: 032] Changed UI text "source" to "reference" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 (owner: 10Denny Vrandecic) [18:02:59] (03Merged) 10jenkins-bot: Changed UI text "source" to "reference" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127005 (owner: 10Denny Vrandecic) [18:04:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [18:13:12] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b42e7f9 : Denny Vrandecic The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23225730 [18:29:10] (03PS4) 10Addshore: Refactor GetEntitiesTest to override services [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 [18:29:12] (03PS2) 10Addshore: Store API test data in objects rather than an array [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127012 [18:29:14] (03PS2) 10Addshore: Introduce IndependentWikibaseApiTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127013 [18:29:16] (03PS2) 10Addshore: Tidy up ApiWikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127008 [18:29:18] (03PS2) 10Addshore: Add method to override services in GetEntities API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 [18:30:55] * addshore cheers [18:37:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [18:46:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127012 (owner: 10Addshore) [18:46:49] * Lydia_WMDE hands addshore some chocolate [18:49:00] (03CR) 10Thiemo Mättig (WMDE): "The change is back in core. I think the comments are helpful and we should merge this now. I also agree to the strict check now, after loo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [18:52:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127013 (owner: 10Addshore) [18:53:48] why thankyou Lydia_WMDE :) [18:53:59] shame I know the last patch is going to fail, time to pop out, see yall tommororw! [18:55:55] cya [18:56:00] also: holiday tomorrow [18:56:02] ;-) [18:56:26] not that it'd keep anyone of us from being here of course [18:57:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127008 (owner: 10Addshore) [18:59:30] ahh, do we get a day of tommorw and monday Lydia_WMDE ? :P [18:59:40] yes [19:00:27] nice :> [19:02:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 (owner: 10Addshore) [19:10:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127112 (owner: 10L10n-bot) [19:45:02] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/tdGRyg [19:45:02] 13WikibaseDataModel/06master 141181a54 15Jeroen De Dauw: Merge pull request #59 from wmde/fingerprint-convenience... [19:45:32] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/bhP6fg [19:45:32] 13WikibaseDataModel/06master 148f96a1f 15Jeroen De Dauw: Update WikibaseDataModel.php [19:55:08] (03CR) 10Jeroen De Dauw: [C: 032] "lol, this class got a million fields now, even when not counting the ones it inherits" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127008 (owner: 10Addshore) [19:56:31] (03CR) 10Jeroen De Dauw: [C: 032] Store API test data in objects rather than an array [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127012 (owner: 10Addshore) [19:57:56] (03CR) 10Jeroen De Dauw: [C: 032] Introduce IndependentWikibaseApiTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127013 (owner: 10Addshore) [19:58:10] (03PS3) 10Jeroen De Dauw: Add method to override services in GetEntities API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 (owner: 10Addshore) [20:03:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2597ff9 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23233383 [20:05:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127009 (owner: 10Addshore) [20:07:05] (03PS5) 10Jeroen De Dauw: Refactor GetEntitiesTest to override services [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [20:09:25] (03CR) 10Jeroen De Dauw: [C: 04-1] Use expectedFormat for more specific ParseException localizing (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [20:12:52] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e980b07 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23233490 [20:13:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/127000 (owner: 10Addshore) [20:18:16] [13WikibaseDataModel] 15thiemowmde opened pull request #61: Rename getAliases to getAliasGroups (060.8.x...06getAliasGroups) 02http://git.io/8Y2rVw [20:18:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/63155c0 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23233605 [20:22:24] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #61: Rename getAliases to getAliasGroups (060.8.x...06getAliasGroups) 02http://git.io/8Y2rVw [20:22:24] <7JTAAGIOA> [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 060.8.x: 02http://git.io/o7aaeA [20:22:24] <7JTAAGIOA> 13WikibaseDataModel/060.8.x 149e9e90a 15Jeroen De Dauw: Merge pull request #61 from wmde/getAliasGroups... [20:26:11] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_Zy4Jw [20:26:11] 13WikibaseDataModel/06master 14fc9c9ff 15Jeroen De Dauw: Update RELEASE-NOTES.md [20:28:28] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #60: Rename getAliases to getAliasGroups (06master...06getAliasGroups) 02http://git.io/Bs-m8A [20:29:48] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #54: Make classes generic and remove duplication [DO NOT MERGE] (06master...06allofthegenerics) 02http://git.io/AgN2dA [20:38:33] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 060.8.x: 02http://git.io/AyT4Sg [20:38:33] 13WikibaseDataModel/060.8.x 14b6a56c5 15Thiemo Mättig: Rename getAliases to getAliasGroups [20:38:33] 13WikibaseDataModel/060.8.x 143824ad6 15jeroendedauw: Merge in master [21:15:32] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14b04872a to 1472d7c1a: 02http://git.io/ahYWpg [21:15:32] 13WikibaseDataModel/06rem 1472d7c1a 15jeroendedauw: [WIP] Legacy code removal... [21:15:47] [13WikibaseDataModel] 15JeroenDeDauw created 061.0.x from 060.8.x (+0 new commits): 02http://git.io/an7R_Q [21:16:07] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #57: [WIP] Legacy code removal (060.8.x...06rem) 02http://git.io/kVr19Q [21:18:23] [travis-ci] wmde/WikibaseDataModel/rem/72d7c1a : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23238949 [21:18:41] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 061.0.x: 02http://git.io/7YYk_w [21:18:41] 13WikibaseDataModel/061.0.x 14724d029 15jeroendedauw: Update branch alias [21:19:26] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/s4g8Cg [21:19:26] 13WikibaseInternalSerialization/06master 140c3e1ef 15Jeroen De Dauw: Update composer.json [21:19:45] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_dYMzg [21:19:45] 13WikibaseDataModelSerialization/06master 141e709de 15Jeroen De Dauw: Update composer.json [21:21:03] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 1472d7c1a to 140bfe035: 02http://git.io/ahYWpg [21:21:03] 13WikibaseDataModel/06rem 140bfe035 15jeroendedauw: [WIP] Legacy code removal... [21:23:33] [travis-ci] wmde/WikibaseDataModel/1.0.x/3824ad6 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23239014 [21:24:53] [travis-ci] wmde/WikibaseDataModel/1.0.x/724d029 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23239152 [21:24:58] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #62: [WIP] Legacy code removal (061.0.x...06rem) 02http://git.io/8ZwYXw [21:26:20] [travis-ci] wmde/WikibaseInternalSerialization/master/0c3e1ef : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/23239239 [21:28:48] [travis-ci] wmde/WikibaseDataModelSerialization/master/1e709de : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/23239270 [21:31:00] [travis-ci] wmde/WikibaseDataModel/rem/0bfe035 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23239331 [21:39:23] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 140bfe035 to 1429c7deb: 02http://git.io/ahYWpg [21:39:23] 13WikibaseDataModel/06rem 1429c7deb 15jeroendedauw: [WIP] Legacy code removal... [21:42:17] [travis-ci] wmde/WikibaseDataModel/rem/29c7deb : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23240440 [22:50:17] cheers for the reviews JeroenDeDauw! [22:50:33] should be able to convert all of the other api tests in a day or so! [22:52:02] night all ! [23:54:58] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 1429c7deb to 142caf67d: 02http://git.io/ahYWpg [23:54:58] 13WikibaseDataModel/06rem 142caf67d 15jeroendedauw: [WIP] Legacy code removal... [23:56:49] [travis-ci] wmde/WikibaseDataModel/rem/2caf67d : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/23248154