[02:43:19] So, I'm a bit dense and can't figure out from https://www.mediawiki.org/wiki/Wikibase/DataModel#Numbers whether a given property with datatype "number" will be able to have different units [02:44:33] For example, if Wikidata has a "length" property, can that have units of "meters" and "base pairs"? Can the same property be used to describe the length of roads and genes? [07:13:22] [13ValueView] 15snaterlicious created 06suggesterrefactoring (+3 new commits): 02http://git.io/NJ0fjw [07:13:22] 13ValueView/06suggesterrefactoring 14c35d749 15snaterlicious: Extracted highlightMatchingCharacters functionality from suggester... [07:13:22] 13ValueView/06suggesterrefactoring 14e3fc2c3 15snaterlicious: Implemented $.ui.ooMenu... [07:13:22] 13ValueView/06suggesterrefactoring 140475815 15snaterlicious: Re-created $.ui.suggester... [07:18:41] (03PS4) 10Adrian Lang: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 [07:18:43] (03PS5) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [07:18:45] (03PS6) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [07:21:08] [13ValueView] 15snaterlicious 04force-pushed 06suggesterrefactoring from 140475815 to 140946000: 02http://git.io/e2K38g [07:21:08] 13ValueView/06suggesterrefactoring 140946000 15snaterlicious: Re-created $.ui.suggester... [07:22:43] [13ValueView] 15snaterlicious opened pull request #47: Re-created $.ui.suggester (06master...06suggesterrefactoring) 02http://git.io/lovIbQ [07:27:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [07:28:39] [13Time] 15adrianlang 04force-pushed 06augmentParseException from 1400fce67 to 147221363: 02http://git.io/0IQddQ [07:28:39] 13Time/06augmentParseException 147221363 15Adrian Lang: Pass rawValue and expectedFormat arguments to ParseExceptions... [07:31:55] (03PS5) 10Adrian Lang: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 [07:31:57] (03PS6) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [07:31:59] (03PS7) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [07:39:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [07:41:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [07:47:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [07:52:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [07:52:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [08:26:36] (03CR) 10Lydia Pintscher: "Hey Karan :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 (owner: 10Karan) [08:45:57] (03PS1) 10Adrian Lang: Fix quotation marks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126211 [08:47:48] (03CR) 10Siebrand: [C: 032] Fix quotation marks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126211 (owner: 10Adrian Lang) [08:48:12] (03Merged) 10jenkins-bot: Fix quotation marks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126211 (owner: 10Adrian Lang) [08:49:28] (03PS1) 10Adrian Lang: Fix debug log format, expand var in debug log entry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126212 [08:53:35] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126211 (owner: 10Adrian Lang) [08:58:06] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/37740bc : Adrian Lang The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23104293 [08:58:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126212 (owner: 10Adrian Lang) [09:14:37] (03CR) 10Addshore: [C: 032] Optimize time parsers regular expressions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126018 (owner: 10Thiemo Mättig (WMDE)) [09:15:02] (03Merged) 10jenkins-bot: Optimize time parsers regular expressions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126018 (owner: 10Thiemo Mättig (WMDE)) [09:15:21] (03CR) 10Addshore: [C: 032] Use EraParser constants instead of repeating the +/- characters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126022 (owner: 10Thiemo Mättig (WMDE)) [09:16:51] (03CR) 10Addshore: [C: 04-1] Support B.C. with dot at the end as well as B. C. with spaces (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126021 (owner: 10Thiemo Mättig (WMDE)) [09:17:02] Thiemo_WMDE: ^^ [09:17:16] uh? [09:17:53] addshore: ah, ok, valid reason for a -1. :-) [09:18:22] [= [09:22:53] [13ValueView] 15thiemowmde comment on pull request #47 140946000: The check is case insensitive but the replacement is not. Suggestions:... 02http://git.io/KL8Ufw [09:24:57] (03CR) 10Addshore: [C: 032] Rename PropertyInfo to more generic EntityInfo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126139 (owner: 10Thiemo Mättig (WMDE)) [09:26:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/72566ac : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23105727 [09:28:33] (03CR) 10Addshore: [C: 04-1] "I have a feeling this has now already been done in https://gerrit.wikimedia.org/r/#/c/120327/3" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 (owner: 10Karan) [09:30:55] (03CR) 10Addshore: Fix debug log format, expand var in debug log entry (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126212 (owner: 10Adrian Lang) [09:31:00] Adrian_WMDE: ^^ [09:32:43] (03CR) 10Adrian Lang: Fix debug log format, expand var in debug log entry (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126212 (owner: 10Adrian Lang) [09:32:54] addshore: ^^ [09:33:31] (03CR) 10Addshore: [C: 032] Fix debug log format, expand var in debug log entry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126212 (owner: 10Adrian Lang) [09:34:30] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1a17657 : Addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23105742 [09:35:03] [13ValueView] 15thiemowmde comment on pull request #47 140946000: This looks overcomplicated. Such complicated bracket nesting can cause measurable performance problems in some regex engines (especially Firefox). Also it seems it doesn't fit the description of the method.... 02http://git.io/l5AEvA [09:37:45] [13ValueView] 15thiemowmde comment on pull request #47 140946000: Just curious, why `-1`? 02http://git.io/0HbqBQ [09:37:56] (03CR) 10Addshore: [C: 032] Clean-up ItemContentTest and Wikibase.hooks.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 (owner: 10Thiemo Mättig (WMDE)) [09:38:52] (03Abandoned) 10Addshore: Fallback to en formatting of dates on failure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [09:41:24] addshore: mh, null echoes as an empty string [09:41:55] [13ValueView] 15thiemowmde comment on pull request #47 140946000: I didn't tested this but this looks like the element can collapse to 0. Shouldn't this be restricted and the element move to the left instead? 02http://git.io/AXJLcw [09:42:29] Adrian_WMDE: feel free to make a followup, youll still be able to tell its null ;p [09:42:50] [13ValueView] 15thiemowmde comment on pull request #47 140946000: Indention. 02http://git.io/xQflUw [09:43:20] [13ValueView] 15thiemowmde comment on pull request #47 140946000: Space missing. Same two line below. 02http://git.io/wO6qtA [09:44:47] addshore: How about ( $itemId === null ? 'null' : get_class( $itemId ) ) [09:46:20] [13ValueView] 15thiemowmde comment on pull request #47 140946000: You are using simple `if( length )` below. Why not doing the same for the inverse and using `if( !length )` instead of `=== 0`? This applies to multiple places, use search & replace. 02http://git.io/QxLo1Q [09:47:22] Adrian_WMDE: what is $itemId isnt null or a class? :P [09:47:26] [13ValueView] 15thiemowmde comment on pull request #47 140946000: `instanceof jQuery` please, this looks a bit confusing. 02http://git.io/Hai3dA [09:47:47] addshore: Shouldn't be a class, but an object :P Anyway, no idea [09:48:10] Maybe I'll leave it as it is? [09:48:22] 'but $itemId "' . $entityId . '" is not an EntityId object.' might be better [09:48:23] addshore: DAILY! [09:48:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/33c9de3 : Addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23106756 [09:52:55] (03CR) 10Karan10: "I asked for help, but no response received. Now It has already been merged in the link provided by Addshore." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118557 (owner: 10Karan) [09:56:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/74a51b0 : Addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23107047 [10:00:24] (03PS1) 10WikidataBuilder: New Wikidata Build - 16/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126218 [10:08:32] [13ValueView] 15thiemowmde comment on pull request #47 140946000: How many copies of this line exist in the code? Can't this be reused? I know we do have `$.escapeRE()`. 02http://git.io/5aazIQ [10:11:25] (03PS1) 10Addshore: Rename MwTimeIsoFormatter to TimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 [10:11:27] (03CR) 10jenkins-bot: [V: 04-1] Rename MwTimeIsoFormatter to TimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 (owner: 10Addshore) [10:14:34] (03PS1) 10Adrian Lang: Use CacheOutput::unsetProperty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 [10:16:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126218 (owner: 10WikidataBuilder) [10:16:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 (owner: 10Addshore) [10:23:00] (03PS2) 10Addshore: Rename MwTimeIsoFormatter to TimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 [10:23:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126220 (owner: 10Adrian Lang) [10:27:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 (owner: 10Addshore) [10:30:26] (03PS3) 10Addshore: Rename MwTimeIsoFormatter to TimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 [10:34:05] (03CR) 10Addshore: [C: 032] New Wikidata Build - 16/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126218 (owner: 10WikidataBuilder) [10:35:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 (owner: 10Addshore) [10:36:21] (03Abandoned) 10Addshore: Rename MwTimeIsoFormatter to TimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126219 (owner: 10Addshore) [10:40:11] [13ValueView] 15snaterlicious 04force-pushed 06suggesterrefactoring from 140946000 to 1457ef9c7: 02http://git.io/e2K38g [10:40:11] 13ValueView/06suggesterrefactoring 1457ef9c7 15snaterlicious: Re-created $.ui.suggester... [12:00:47] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/126218 (owner: 10WikidataBuilder) [12:04:15] Adrian_WMDE: http://www.php.net/manual/de/apc.configuration.php [12:50:51] (03PS2) 10Thiemo Mättig (WMDE): Support B.C. with dot at the end as well as B. C. with spaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126021 [12:55:05] (03PS1) 10Adrian Lang: Remove slow array_unique from ReferencedEntitesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126235 [12:59:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126021 (owner: 10Thiemo Mättig (WMDE)) [13:04:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126235 (owner: 10Adrian Lang) [13:13:06] (03CR) 10Addshore: [C: 032] Support B.C. with dot at the end as well as B. C. with spaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126021 (owner: 10Thiemo Mättig (WMDE)) [13:25:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/8c8178d : Thiemo Mättig The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23119494 [13:59:49] (03PS8) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [14:00:24] (03CR) 10jenkins-bot: [V: 04-1] (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:08:24] (03PS9) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [14:08:37] (03CR) 10Daniel Kinzler: "PS9 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:11:10] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=46910 <- is that the relevant one for decreasing edit speed? [14:11:22] or did you have something else in mind? [14:11:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:13:17] Lydia_WMDE: yea, that one. [14:13:45] k thx [14:16:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:29:53] (03CR) 10Siebrand: (bug 45277) Introducing ApiErrorReporter (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [14:38:14] (03PS10) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [14:40:43] (03CR) 10Daniel Kinzler: Insert classes for badges on client (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [14:42:16] (03CR) 10Daniel Kinzler: [C: 032] Rename formatter option RESOLVE_ID to LOOKUP_LABEL [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126055 (owner: 10Thiemo Mättig (WMDE)) [14:42:34] (03Merged) 10jenkins-bot: Rename formatter option RESOLVE_ID to LOOKUP_LABEL [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126055 (owner: 10Thiemo Mättig (WMDE)) [14:45:20] (03CR) 10Daniel Kinzler: [C: 032] Use EntityTitleLookup in EntityIdHtmlLinkFormatter on Repo (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126070 (owner: 10Thiemo Mättig (WMDE)) [14:45:39] (03Merged) 10jenkins-bot: Use EntityTitleLookup in EntityIdHtmlLinkFormatter on Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126070 (owner: 10Thiemo Mättig (WMDE)) [14:45:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [14:49:00] (03CR) 10Daniel Kinzler: [C: 032] Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [14:49:26] (03Merged) 10jenkins-bot: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [14:50:21] (03PS1) 10Thiemo Mättig (WMDE): Rename somewhat confusing variable names in ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 [14:51:15] (03CR) 10Daniel Kinzler: [C: 04-1] Use expectedFormat for more specific ParseException localizing (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [14:53:59] (03CR) 10Siebrand: Rename somewhat confusing variable names in ApiErrorReporter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 (owner: 10Thiemo Mättig (WMDE)) [14:57:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 (owner: 10Thiemo Mättig (WMDE)) [15:02:40] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/dcef515 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23127341 [15:19:51] Reedy: around? [15:21:13] JA [15:22:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/3619ffa : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23127573 [15:25:28] Reedy: we're having issues with change dispatching [15:25:41] can you tell me which version is currently running on the live site? [15:26:09] Version of what exactly? [15:26:32] wikibase [15:26:39] or wikidata build [15:30:23] reedy@tin:/a/common/php-1.23wmf22$ git submodule status extensions/Wikidata/ [15:30:23] 91d2cc9fe5c795123c2545719ecfb4f368491307 extensions/Wikidata (remotes/origin/mw1.23-wmf19) [15:30:45] reedy@tin:/a/common/php-1.23wmf21$ git submodule status extensions/Wikidata/ [15:30:45] 91d2cc9fe5c795123c2545719ecfb4f368491307 extensions/Wikidata (remotes/origin/mw1.23-wmf19) [15:30:46] Reedy: thx [15:31:18] hmm [15:31:23] shouldn't we be using mw1.23-wmf21 ? [15:31:31] Reedy: so, i'm trying to understand the failure. can you help me investiagte? i feel a bit blind... [15:32:09] Don't we have a dispatacher log? [15:32:11] * Reedy checkers [15:32:21] dispatcher [15:32:24] checks [15:32:59] Reedy: yes, we do. https://gist.github.com/nik9000/10890632 [15:33:10] Reedy: it sais ERROR: exception 'MWException' with message 'Failed to push to job queue for suwikiquote' in /usr/local/apache/common-local/php-1.23wmf22/extensions/Wikidata/extensions/Wikibase/lib/maintenance/dispatchChanges.php:966 [15:34:34] Reedy: this is thrown if JobQueueGroup::push returns false. which happens when JobQueue::push() returns false, which in turn happens when batchPush() returns false. [15:34:51] Is it happening everywhere? [15:35:57] batchPush() returns false if doBatchPush() returns false. which, for redis, returns false if $failed is > 0, which happens if $added is not an int - basically, if pushBlobs returns somethign that is not an int. [15:36:29] Reedy: according to Nik, every attempt fails. I'll try to log into terbuim to look at the log myself later [15:36:56] Reedy: basically, it seems that the error is triggered when JobQueueRedis::pushBlobs returns a non-int. [15:37:18] * aude panics [15:37:22] dispatching broken? [15:37:24] the value it returns comes directly from $conn->luaEval, and is documented as @return int Number of jobs inserted (duplicates are ignored) [15:37:27] that's very encouraging [15:37:30] aude: yes [15:37:42] redis no liky. [15:37:45] for 20 hours now [15:37:50] we thought it was just overload. [15:37:56] aude: https://gist.github.com/nik9000/10890632 [15:38:04] Reedy: mw1.23-wmf19 is correct for wikidata /base [15:38:49] let's have a look at the redis logs then [15:38:56] aude: is there a *good* way to see which version of Wikibase we are running? I think WikidataBuilder should dump a file with all the relevant version info for all modules... [15:38:59] Lydia_WMDE: ---^ [15:39:14] DanielK_WMDE: it does [15:39:31] well, we have which version of wikidata [15:39:34] wikidata/base ! [15:39:35] aude: where? and should we make Special:Version show info from there? [15:39:54] special version [15:40:07] 2014-04-16 15:24:41 mw1090 dewiki: Redis exception connecting to 10.64.0.184: read error on connection [15:40:07] 2014-04-16 15:26:40 mw1103 enwiki: Could not connect to server 10.64.0.191 [15:40:07] 2014-04-16 15:33:45 mw1055 zhwiki: Could not connect to server 10.64.0.194 [15:40:07] 2014-04-16 15:36:58 mw1115 frwiki: Could not connect to server 10.64.0.188 [15:40:18] That's almost like all 4 redis servers have given errors [15:40:28] aude: can you tell me how to log into terbium? i didn't get around to reading up on the shell access yet [15:40:50] Reedy: for 20 hours streight??? and only for wikidata? [15:41:08] don't panic [15:41:20] Nik mentioned high load on redis caused by parsoid... but it shouldn't be that bad, should it? [15:41:23] redis jobqueue logs are also non existant [15:41:38] * DanielK_WMDE suspects a mundane disk full [15:41:38] Ganglia looks like they're almost idling [15:41:45] https://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&s=by+name&c=Redis%2520eqiad&tab=m&vn=&hide-hf=false [15:42:25] hmmm, no idea why https://www.wikidata.org/wiki/Special:Version does not give hash [15:42:30] thought it did for "Wikidata" [15:42:47] anyway, can fix that later [15:42:49] Most of them are only 6% disk space use [15:42:57] 2 are increasing frequently, but still well under 10% [15:44:49] aude: DanielK_WMDE: made a note for version number [15:45:04] Lydia_WMDE: thanks [15:45:38] Reedy: so... it still looks like our maintenance script can't post to the redis job queues at all - or at least, often fails. [15:45:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5170ee4 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23127897 [15:45:57] i'm currently looking at the relevant core code. it could report more useful info. [15:46:05] dispatch changes badly needs refactoring and tests [15:46:15] though not sure where the issue is [15:47:02] aude: aas far as I can see, it's nto in our code [15:47:15] We don't seem to have a way of testing redis like we do for memcached [15:47:18] aude: well, dispatching shouldn't use a cron job. but that's not the issue here. [15:47:42] DanielK_WMDE: it should have tests1 [15:47:43] ! [15:48:18] aude: sure :) [15:48:33] but that wouldn't help with the current issue [15:50:25] addshore: Where are you? We need tests! [15:53:58] Reedy: https://gerrit.wikimedia.org/r/#/c/126611/ [15:54:45] There's no target log file for 'JobQueueRedis'... I'm waiting for ops to touch the file for me [15:55:24] Reedy: well, the debug log wouldn't give much useful info. we need the $conn->getLastError() [15:55:31] Right [15:55:32] Reedy: wfLogWarning will write to the fatal error logs. [15:55:39] But I'm also wondering if your addition should go in said log too [15:55:52] yea, maybe [15:56:05] But of course, if it goes nowhere currently, it's not so useful [15:56:21] though it's in the wrong place. could remove the debug log after the loop, and just log to the debug log at the same time as the error log [15:56:49] Reedy: Nik said Anomie may be able to deploy hot patches... [15:56:57] * DanielK_WMDE has to go in about 10 minutes. [15:57:13] If there's a good enough reason to do it... [15:58:05] well, finding out why we can't dispatch any changes to any client wiki is a good reason to me... [15:58:17] yup [15:58:25] so, get it in :) [15:58:27] very yeah ;-) [15:59:36] question, is redis broken or how we are interacting with the job queue? [16:00:49] is update repo on move broken also? [16:01:11] aude: are you around to handle this? or should i call hoo? [16:01:16] (do you have his number?) [16:01:28] as daniel has to leave [16:01:48] 2014-04-16 16:01:34 mw1015 lvwiki: ChangeNotification Special:ChangeNotificationJob repo= changeIds=array(200) STARTING [16:02:03] Lydia_WMDE: i can look but no promise how quick i find solution [16:02:09] sure [16:02:11] cool [16:02:14] so i see some of our stuff in the runJobs logs [16:02:24] no idea how much compared to normal [16:03:08] aude: dispatchign seems to be stuck at 119399351 [16:03:20] it desn't seem to go past that [16:03:21] ok [16:03:28] * aude looks [16:03:35] reedy found redis connection errors in some log. [16:03:44] Nik found lots of exceptions reported from our cron job [16:04:17] aude: the location in the code that seems to be losing any information about the cause of the issue is what i wrote the patch for. [16:04:27] i hope that it would tell us what is going wrong [16:05:44] aude: i first suspected that there is a bad entry in the db, that we can't read for soem reason [16:05:53] Want to amend it to put it to the redis-jobqueue log? [16:05:59] but judging by the exception, we can read it find, we just can't post the job. [16:06:15] It now exists, but not gaining any entries yet... [16:07:17] it seems kind of redundant, bot oh, well. [16:07:45] Reedy: it should get at least the old message... [16:07:57] Indeed [16:08:10] aude, Reedy: nick also said he saw lots of instances of dispatchChanges. That'S odd, there should not be multiple instances... [16:08:13] anyway, gtg now [16:09:34] DanielK_WMDE: ok [16:09:43] reedy@terbium:~$ ps aux | grep dispatch | wc -l [16:09:43] 19 [16:09:50] whoa [16:10:06] http://p.defau.lt/?fTVo_X_2OUmZrdd957Px4w [16:10:27] Seemingly some to logs, some not [16:10:48] 1.6G of logs [16:10:49] heh [16:16:58] nom [16:17:47] it's an addshore! [16:17:58] iv been here all da ;p [16:18:00] day ;p [16:18:56] there are 2 cron jobs [16:25:51] https://gerrit.wikimedia.org/r/#/c/126611 is completely the wrong branch [16:28:09] i'm trying to push 119399351 to a job queue [16:28:28] obviously, $ok = false in dispatchChanges ( $jobqueuegroup->push( $job ) ) [16:28:38] see if i can find moreo details [16:29:02] then we can try the patch ( i can amend) [16:34:00] hmmm, JobQueue::push returns no status or anything [16:35:05] Damn it [16:35:11] Just cherry picked and merged to 1.23wmf21 [16:35:52] grrrr [16:35:57] we're on wmf22, right? [16:36:02] yup [16:36:12] Deploying logging change [16:36:19] i have to go home now. will be back in 45 mins hopefully. thiemo is still in the office [16:37:13] Lydia_WMDE: ok [16:38:04] aude: ping me if i can help. [16:38:04] pile of "2014-04-16 16:23:18 mw1219 enwiki: Redis exception connecting to 10.64.0.194: read error on connection" [16:38:15] really don't know how to fix that [16:38:50] aude: It's almost like it's not hitting the code we think [16:39:08] hmmm [16:39:22] Just ran mwscript extensions/Wikidata/extensions/Wikibase/lib/maintenance/dispatchChanges.php --wiki=wikidatawiki manually [16:39:23] are those sort of redis errors normal? [16:40:14] Sounds very much like the intermittant issues we had with memcached [16:40:18] ok [16:40:21] * aude ignores [16:41:03] doing "$jqueue->push( $job );" produces no kind of information [16:41:04] I think if we're getting a lot for a long period it's something to investigate/deal with [16:41:18] ok [16:41:26] no idea what's normal for those redis errors [16:41:35] assume it's in nagios [16:42:42] 2014-04-16 16:37:01 mw1140 wikidatawiki: [b884ca48] /w/api.php?action=wbgetclaims&format=xml&entity=&property=p380 Exception from line 64 of /usr/local/apache/common-local/php-1.23wmf22/extensions/Wikidata/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php: The provided id serialization "" is not valid [16:42:42] #0 /usr/local/apache/common-local/php-1.23wmf22/extensions/Wikidata/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php(45): Wikibase\DataModel\Entity\DispatchingEntityIdParser->throwInvalidId('') [16:43:49] :o [16:44:10] oh [16:44:24] unrelated [16:44:28] xml! [16:44:48] There's quite a bit in the exception logs [16:45:10] anyway, where doBatchPush returns false, we already have debug log [16:45:57] or it throws JobQueueError [16:46:03] assume is logged [16:47:32] still also getting pile of Exception from line 98 of /usr/local/apache/common-local/php-1.23wmf22/extensions/Wikidata/extensions/Wikibase/lib/includes/store/sql/WikiPageEntityLookup.php [16:47:37] annoying [16:50:18] can you post a stack trace of such an exception in WikiPageEntityLookup somewhere? [16:50:30] it's in bugzilla [16:50:38] i guess not in sprint? [16:50:55] and still happened in wmf21 of wikibase, btw [16:51:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=62547 [16:51:37] oh, i remember. no, not in sprint. [16:52:02] think it would be worthwhile... not sure how we forgot to put it in [16:52:36] yes. but it sounds like this is unrelated to the current issue. what do you think? [16:52:37] believe https://bugzilla.wikimedia.org/show_bug.cgi?id=62904 also still happens [16:52:55] they are unrelated but cause a lot of extra noise that we don't need [16:53:17] btw, post additional stack traces to these reports if you find one. [16:55:00] grep -v [16:55:09] aude: ^ here's your noise filter :p [16:55:14] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#118 (master - 824a186 : Translation updater bot): The build has errored. [16:55:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/b1f589595502...824a18686655 [16:55:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/23135523 [16:55:52] Thiemo_WMDE: ok [16:57:18] aha... trying dispatch changes on my own wiki also fails [16:57:27] i don't have redis, at the moment [16:57:40] could be incompatibility between core and version of wikibase deployed [16:58:01] 'MWException' with message 'Failed to push to job queue for testclient' [16:58:14] i think i can figure it out from here [16:59:38] changes are null [17:02:02] 1 Fatal error: Call to a member function getPartialURL() on a non-object in /usr/local/apache/common-local/php-1.23wmf22/extensions/Wikidata/extensions/Wikibase/lib/includes/formatters/CommonsLinkFormatter.php on line 58 [17:07:55] as of 9ffd4f085d71116f0a643dd0cbd10f1008fa4ace in core, dispatch changes works on my wiki [17:08:01] getting closer [17:10:09] oh, return $ok is no more [17:11:30] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126716 (owner: 10L10n-bot) [17:11:39] patch coming! [17:16:23] suppose need to check also for update move job [17:16:32] (03PS1) 10Aude: Adjust check for failed job queue push in dispatch changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 [17:16:39] Thiemo_WMDE: ^ Reedy ^ [17:17:10] re [17:17:13] aude: you're a hero [17:18:02] (03PS1) 10Thiemo Mättig (WMDE): Stop throwing fatal errors in CommonsLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126720 [17:18:03] tryign to keep b/w compat but admit it might get difficult [17:18:08] can do it here [17:19:56] That simple? [17:20:37] is this $ok null in 1.23? [17:20:45] Thiemo_WMDE: it's boolean [17:20:57] if it's bool then !$ok should work. [17:21:12] in master core, it's null [17:21:22] we strict compare, if we care about 1.23 [17:21:32] we ditch the check entirely if we don't care [17:21:40] btw, patch coming for update move [17:21:46] Ugh [17:21:51] PhpStorm sees another bug in core [17:22:49] $ok looks like it'll always become false in JobQueueGroup::push [17:22:55] if ( $this->get( $type )->push( $jobs ) ) { [17:22:55] JobQueueAggregator::singleton()->notifyQueueNonEmpty( $this->wiki, $type ); [17:22:55] } else { [17:22:55] $ok = false; [17:22:55] } [17:23:02] push is a void [17:25:13] the change from !$ok to $ok === false doesn't change anything, not in 1.23 and not in master. sorry. [17:25:43] what is $ok in master? [17:26:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [17:26:44] $ok where in which function? [17:27:03] it's never null. always a bool. [17:27:13] i see [17:28:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=64007 [17:28:39] dispatch changes, line 961 [17:29:51] might be different place in the code then [17:31:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126720 (owner: 10Thiemo Mättig (WMDE)) [17:31:04] https://github.com/wikimedia/mediawiki-core/commit/bc8c89d2df39d64f15770d29874904ebcff2f131 [17:31:08] Bad Aaron [17:31:08] doBatchPush returns true [17:34:05] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "This changes the code so it does not throw an exception if JobQueueGroup::push() returns a non-bool value." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [17:36:46] dafuq?i see the bug. it's in JobQueueGroup in core. [17:37:45] the problem is in jobqueuegroup [17:37:47] indeed [17:37:58] somebody already working on it? should i submit a patch? [17:38:01] Feel free [17:38:18] The JobQueueGroup::push() return value is widely used [17:38:45] So the alternation to $ok = false probably wants dropping [17:38:49] And then just return true; at the bottom [17:39:23] agree [17:39:29] Thiemo_WMDE: go ahead [17:40:07] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=64007 [17:40:30] That push return value looks pretty useless [17:40:42] then it should never return false, except in mw1.23 [17:41:10] god. who merged this? this is wrong. [17:41:18] just revert https://github.com/wikimedia/mediawiki-core/commit/bc8c89d2df39d64f15770d29874904ebcff2f131 [17:41:20] it's wrong. [17:41:35] also an option [17:42:05] Revert in https://gerrit.wikimedia.org/r/#/c/126731/ [17:42:15] * aude merging [17:42:33] it goes down to \JobQueueRedis::doBatchPush which DOES return false on error. [17:43:41] Thiemo_WMDE: ah, ok [17:43:57] we should consistently use exceptions in jobqueue group and redis [17:44:17] sure. [17:45:11] but not by removing the return value from methods that are still used in if(). [17:45:29] Reedy: did anything end up in the error log? and why did you amandon the patch against wmf19? [17:45:45] DanielK_WMDE: wmf19 of core isn't in used anywhere [17:45:45] (03CR) 10Aude: [C: 04-2] "unless bc8c89d2 is resubmitted, with throwing exceptions more consistently" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [17:45:57] We're on 21 and 22 [17:46:00] ah, i thought we reverted to that for wikidata [17:46:03] wmf19 of Wikidata/Wikidata [17:46:11] We did at one point [17:46:11] Reedy: that's right [17:46:14] ah, ok, that confused me [17:46:26] Scapping and testing and aude and I shifted it back again last week or before [17:46:53] because time localisation is terribly broken for non-english [17:46:59] in mw1.23-wmf21 [17:47:54] DanielK_WMDE: the exception did not happened where aude changed the if(). [17:48:16] basically jobqueuegroup was always returning false [17:48:34] because jobqueue push returned void [17:48:38] / null [17:48:44] * Reedy waits for Jenkins [17:49:13] JobQueryGroup, line 128 was basically: if ( void ) fail. [17:49:44] aude: ah, ok [17:49:45] if it gets changed to use exceptions consistently, then we'll want to change dispatch changes [17:49:50] but the fix is not live yet, is it? [17:49:50] accordingly, but not needed now [17:49:54] https://www.wikidata.org/wiki/Special:DispatchStats is not improving [17:49:57] DanielK_WMDE: momentarily [17:50:01] k [17:50:06] * aude impatiently waits for jenkins [17:50:29] so, why did that only have impact on us? [17:50:47] oh, let me guess: the return value is routinely ignored by other code [17:50:47] and would be nice to have integration tests that somehow cover this [17:50:54] probably [17:51:04] we check $ok in dispatch changes and update move [17:51:14] !$ok then throw exception [17:51:22] should probably just ignore it [17:51:42] DanielK_WMDE: agree, except if we want compatibility with mw1.23 [17:52:15] hm? why? what does mw1.23 change? [17:52:25] (03PS2) 10Aude: Adjust check for failed job queue push in dispatch changes and update move [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 [17:52:26] i mean, does the return value somehow become actually meaningful? [17:52:36] in case we need it at some point [17:53:11] perhaps not [17:53:21] ok [17:53:32] we do $this->trace( "Posted notification job for site $siteID with [17:53:36] if we care [17:54:05] dispatchTo goes on to do more othings [17:54:26] well, yea, if an exception is thrown, it will essentially tra again from the same position next time [17:55:12] Deployed [17:55:17] certainly can use more thought in dispatch changes how to handle this [17:55:20] Reedy: thanks [17:55:22] aude: we don't need to do anythink in our dispatchChanges. it will work with both boolean returns and thrown exceptions. [17:55:34] Reedy: aude: Thiemo_WMDE: DanielK_WMDE: stats are moving \o/ [17:55:37] * Reedy dispatch some chnges [17:55:44] 17:55:33 Posted 1000 changes to jbowiki, up to ID 119400545, timestamp 20140415185909. Lag is 82584 seconds. Next ID is 119400545. [17:55:58] 24 hours? [17:56:00] thanks folks for fixing this! [17:56:03] Reedy: yeah... [17:56:05] pretty bad [17:56:18] people have been editing super fast over the last days [17:56:25] and we migrated wikiquote interwiki links [17:56:28] Do we need to do anything to help try and catch up? [17:56:28] so a lot has piled up [17:56:31] Thiemo_WMDE: true [17:56:54] Reedy: not sure if there is anything we can do but wait. aude? DanielK_WMDE? [17:56:56] This patch was just incomplete. A lot! https://gerrit.wikimedia.org/r/#/c/123498/ [17:56:59] wait and wait [17:57:01] (03CR) 10Daniel Kinzler: "detection of property label duplicates fails on sqlite (the test is skipped for mysql)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [17:57:47] Is it worth spawning more dispatchers? [17:58:03] there can only be one [17:58:11] but would be good to have strict comparison, imho if the change is done again [17:58:25] along with the comments noting to remove it when we don't support 1.23 anymore [17:58:39] Reedy: Lydia_WMDE it will catch up [17:58:51] fairly quick, i think [17:58:56] hopefully [17:59:07] i'll send notes out to mailing list and project chat [17:59:10] ok [17:59:45] * aude somehow would like tests to catch this sort of thing, btw [18:00:18] i *know* dispatch changes worked last week, though as i tried it but would like automated tests for this [18:00:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [18:02:09] aude: yeah. i have a note for a nagios plugin at least so we're notified earlier [18:02:11] Lydia_WMDE: we could add more cron jobs. that will empty our side of the queue more quickly. but it will potentially swamp the client wikis with page purges. [18:02:22] +1 for nagios [18:02:24] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e637a51 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23138520 [18:02:31] DanielK_WMDE: yeah. let's see how fast it is catching up [18:02:43] just be patient [18:02:59] i think it's quick enough, though let's see [18:03:07] been broken for 24 hours [18:03:47] (03CR) 10Aude: "not needed unless bc8c89d2 is resubmitted, with throwing exceptions more consistently" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [18:04:24] DanielK_WMDE: aude: it seems to be going pretty fast [18:04:47] yay [18:04:57] * aude off to get food :) [18:05:01] :) [18:05:05] thanks again aude [18:05:08] sure! [18:05:13] and sorry for emergency during your vacation [18:05:38] it's ok and ok to do some coding during vacation [18:06:15] aude: That's what you live for, to be the one people come to in emergencies :D [18:06:21] vacation just means spending very slightly less time doing your work [18:06:28] exactly :) [18:06:53] later [18:07:47] Lydia_WMDE: we can also use smaller update intervals or increase the batch size. all has the same effect: we push to clients faster. we need to make sure the clients can keep up. [18:08:02] Reedy: ^ what do you say? [18:10:36] Ouch, oldest is like 3 days old [18:10:58] Do we know how long it may take to catch up? [18:13:08] Makingn the changes isn't an issue, just need to get opsen to deploy it [18:13:33] when you deployed the fix it was at 23:10 [18:13:39] now it is at 22:40 [18:13:44] for average [18:14:01] * Lydia_WMDE checks timestamps [18:14:11] this illustrates the error: https://gerrit.wikimedia.org/r/#/c/126746/1/includes/jobqueue/JobQueueGroup.php [18:14:27] Reedy: roughly realtime it seems [18:14:45] so assuming it goes lineary we should be caught up in 22h and some [18:14:51] That seems a bit long to me [18:15:14] Reedy: try doubeling the batch size and then keep an eye on the job queue size of enwiki [18:15:17] *nod* [18:15:25] let's see how big enwiki job queue is now [18:15:27] if enwiki's queue grows too long, reduce the batch size again [18:15:37] ^Creedy@tin:/a/common$ mwscript showJobs.php enwiki [18:15:37] 125276 [18:15:38] sounds good to me [18:18:05] * Lydia_WMDE has no idea if that is big or small :D [18:18:51] Lydia_WMDE, Reedy: also keep an eye on the jq of enwikiquote. many of the edits relate to wq, and may not get pushed to enwiki at all [18:19:06] true [18:20:01] reedy@tin:/a/common$ mwscript showJobs.php enwikiquote [18:20:01] 1 [18:20:04] That's alright [18:20:07] enwiki not so much ;) [18:20:49] DanielK_WMDE: Reedy: enwiki still gets notified if a link to wikiquote is added, right? [18:21:03] in that case a lot on enwiki will be in the queue [18:21:25] or is that filtered? [18:22:41] Lydia_WMDE: enwiki gets notified if it's linked from the item, but if the change isn't relevant to the page, it doesn't trigger re-rendering [18:22:52] not sure how that optimization is currently implemented [18:22:59] ok [18:35:54] (03PS3) 10Thiemo Mättig (WMDE): Adjust check for failed job queue push in dispatch changes and update move [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [18:37:02] aude: not sure if my patch set is better. feel free to revert back to yours. if it's ok for you please +1 and i will +2. [18:42:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [18:46:38] DanielK_WMDE: Oh, btw [18:46:38] http://p.defau.lt/?O_tu6OPhZlZxPgYpkksK9w [18:47:43] Some spawned via bash, some not [18:48:01] Some logging, some not.. [18:48:38] But apparent duplicates writing to the same files [19:46:49] Ahh [19:47:02] down to just under 13 hours for enwiki being stalest [19:50:09] (03PS2) 10Thiemo Mättig (WMDE): Stop throwing fatal errors in CommonsLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126720 [19:52:01] gerrit dies again ... [19:57:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126720 (owner: 10Thiemo Mättig (WMDE)) [20:17:45] (03CR) 10Thiemo Mättig (WMDE): Rename somewhat confusing variable names in ApiErrorReporter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126259 (owner: 10Thiemo Mättig (WMDE)) [20:18:37] (03PS11) 10Daniel Kinzler: (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 [20:18:50] (03CR) 10jenkins-bot: [V: 04-1] (bug 49583) refactoring term validation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [20:25:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124800 (owner: 10Daniel Kinzler) [20:28:04] 10 hour 10 [20:47:21] [13WikibaseDataModel] 15thiemowmde created 06fingerprint-convenience (+1 new commit): 02http://git.io/JHXMzw [20:47:21] 13WikibaseDataModel/06fingerprint-convenience 1419fa351 15Thiemo Mättig: Add convenience methods to Fingerprint... [20:49:31] (03CR) 10Bene: Insert classes for badges on client (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [20:53:44] [13WikibaseDataModel] 15thiemowmde opened pull request #59: Add convenience methods to Fingerprint (06master...06fingerprint-convenience) 02http://git.io/neUHxA [20:55:16] [travis-ci] wmde/WikibaseDataModel/fingerprint-convenience/19fa351 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23154816 [20:59:27] (03CR) 10Aude: "thiemo: see comments" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [21:12:32] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06arrayobject: 02http://git.io/pXbUXw [21:12:32] 13WikibaseDataModel/06arrayobject 140f58a44 15Thiemo Mättig: Simplified overcomplicated constructor [21:24:42] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06fingerprint-convenience from 1419fa351 to 142007b0c: 02http://git.io/RLGhmA [21:24:42] 13WikibaseDataModel/06fingerprint-convenience 142007b0c 15Thiemo Mättig: Add convenience methods to Fingerprint... [21:33:57] [13WikibaseDataModel] 15thiemowmde comment on pull request #59 142007b0c: Reasons for this rename:... 02http://git.io/mzQ05g [21:34:17] [travis-ci] wmde/WikibaseDataModel/fingerprint-convenience/2007b0c : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseDataModel/builds/23157888 [21:36:59] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06fingerprint-convenience from 142007b0c to 1422fff59: 02http://git.io/RLGhmA [21:36:59] 13WikibaseDataModel/06fingerprint-convenience 1422fff59 15Thiemo Mättig: Add convenience methods to Fingerprint... [21:43:05] (03CR) 10Thiemo Mättig (WMDE): "You are commenting my rebase. These lines belong to Id40bf9c49f782a374d329fd3d43500417571b33e. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [21:47:09] [travis-ci] wmde/WikibaseDataModel/fingerprint-convenience/22fff59 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23158900 [22:02:14] (03CR) 10Thiemo Mättig (WMDE): "We discussed this and decided to render all badges:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [22:16:25] (03CR) 10Aude: "since it's a rebase, then ignore my comments :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126719 (owner: 10Aude) [22:33:05] * addshore sleeps [22:42:04] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #59 1422fff59: I'd not have this magic handling in the method. if the caller has a Term, they can just call getLanguageCode on it. And if this happens at a million different placed, I'd simply add a dedicated helper method for it here (though it does not happen that often). 02http://git.io/i5oTwA [22:44:12] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #59 1422fff59: Will need a note in the release notes as breaking change. Which means this cannot be done in 0.7.x (while the additions can happen there). So perhaps you want to separate this into a commit onto the 0.8.x branch? 02http://git.io/DXKnHg [22:45:52] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/8hy4GQ [22:45:52] 13WikibaseDataModel/06master 149872d67 15Jeroen De Dauw: Merge pull request #30 from wmde/from_numeric_id... [22:48:09] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #32 140f58a44: Is this the error message you got before? It's a lot clearer if you describe what the test checks. 02http://git.io/rzsSKA [22:48:19] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #32 140f58a44: assertCount 02http://git.io/YjkdCg [22:51:09] omfg [22:51:10] no lag [22:51:12] all caught up [23:03:04] Reedy: Yeah :D [23:03:22] Also otherprojects will soon be available on itwikisource :D