[00:52:29] hi [00:52:40] hi [01:07:42] JeroenDeDauw: http://masterninja.com/wp-content/uploads/meme-engineer.jpg is that you? [03:16:48] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#117 (REL1_23 - b1f5895 : Translation updater bot): The build has errored. [03:16:48] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/REL1_23 [03:16:48] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/23006703 [03:25:15] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/REL1_23/d2ed0cc : jenkins-bot The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23006707 [07:16:15] (03PS2) 10Henning Snater: Removed AutocompleteInterface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124619 [07:22:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124619 (owner: 10Henning Snater) [07:44:26] (03PS16) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [07:51:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [08:19:39] (03PS1) 10Thiemo Mättig (WMDE): Make EntityInfoBuilder method return entity info arrays instead of labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 [08:26:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 (owner: 10Thiemo Mättig (WMDE)) [08:42:14] (03PS2) 10Thiemo Mättig (WMDE): Make EntityInfoBuilder method return entity info arrays instead of labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 [08:49:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 (owner: 10Thiemo Mättig (WMDE)) [08:51:11] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Oh no, this renders everything with no label in red." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE)) [09:02:02] I received https://www.wikidata.org/wiki/Wikidata:Property_proposal/Authority_control in қазақша (ka?) while my language is set to en [09:08:37] (03PS3) 10Thiemo Mättig (WMDE): Render links to deleted items in red [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 [09:09:25] jayvdb: no problems here [09:15:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE)) [09:22:53] (03CR) 10Addshore: [C: 032] Make Link Formatter regular expressions more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125877 (owner: 10Thiemo Mättig (WMDE)) [09:23:17] (03Merged) 10jenkins-bot: Make Link Formatter regular expressions more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125877 (owner: 10Thiemo Mättig (WMDE)) [09:25:47] * addshore wonders who is here today [09:27:23] addshore: me! :D [09:27:30] addshore: please to add points: https://bugzilla.wikimedia.org/show_bug.cgi?id=63723 [09:27:50] under p? :P [09:27:55] what are my options? :D [09:27:56] yes [09:28:19] 1,2,5,8,13,20,40 [09:28:29] {{done}} [09:28:55] oh 3 also is an option [09:28:56] ;-) [09:28:58] thx [09:29:02] not a very good sprint? :O http://sb.wmflabs.org/t/wikidata-developers/2014-04-01/ [09:29:07] no... [09:29:16] good we have a sprint break now [09:29:21] haha :P [09:30:32] addshore: here too please: https://bugzilla.wikimedia.org/show_bug.cgi?id=63733 [09:31:35] (03CR) 10Addshore: [C: 04-1] Create api module 'wbavailablebadges' to query all available badges (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (owner: 10Bene) [09:32:42] Lydia_WMDE: done [09:32:46] \o/ [09:32:54] sprint should look a bit better now after refresh [09:33:24] hehe, no, as I just reoponed that last one as patch to review ;p [09:33:39] nooooooooooooooooooooooooooooooooooo! [09:33:41] :D [09:33:41] D. [09:33:45] surprise! [09:33:47] evil addshore! [09:33:50] :P [09:37:33] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ce3e7e2 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23022866 [09:46:19] addshore: joining the daily? [09:46:33] yes, give me 2 secs [09:46:40] k [09:48:18] :/ [10:00:22] (03PS1) 10WikidataBuilder: New Wikidata Build - 15/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125965 [10:11:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125965 (owner: 10WikidataBuilder) [10:12:32] (03CR) 10Addshore: [C: 032] New Wikidata Build - 15/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125965 (owner: 10WikidataBuilder) [10:35:06] Henning_WMDE: http://www.jointhebest-blog.de/wp-content/uploads/2012/12/BASF-Logo.jpg [10:36:27] Henning_WMDE: mit den konzentrischen kreisen von dem alten logo:_ http://boingboing.net/images/_wp-content_uploads_2011_03_basf-standard.jpg [10:53:56] (03PS1) 10Addshore: MwTimeIsoFormatter should allow 16 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125968 [11:01:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125968 (owner: 10Addshore) [11:24:10] (03PS1) 10Addshore: Add basic roundtrip testing for MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 [11:30:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [11:36:40] meegegrgrgeeeee [11:37:24] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125965 (owner: 10WikidataBuilder) [11:41:05] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add comment to wgHooks stash in MwTimeIsoFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125713 (owner: 10Addshore) [11:41:29] (03Merged) 10jenkins-bot: Add comment to wgHooks stash in MwTimeIsoFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125713 (owner: 10Addshore) [11:42:17] addshore: I'm not reading IRC all the time. you need to call my name. ;) [11:55:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f224a08 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23030325 [11:56:19] Thiemo_WMDE: Thiemo_WMDE Thiemo_WMDE Thiemo_WMDE Thiemo_WMDE :D [11:56:38] processing [11:57:43] added you too a bunch of stuff [12:03:36] [13WikibaseDataModel] 15thiemowmde created 06term-mock (+1 new commit): 02http://git.io/E52NDA [12:03:36] 13WikibaseDataModel/06term-mock 14742eee4 15Thiemo Mättig: Disable original constructor whem mocking Term [12:05:21] [13WikibaseDataModel] 15thiemowmde opened pull request #58: Disable original constructor whem mocking Term (06master...06term-mock) 02http://git.io/rZJVFQ [12:05:51] [travis-ci] wmde/WikibaseDataModel/term-mock/742eee4 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/23031527 [12:10:04] (03CR) 10Thiemo Mättig (WMDE): "Not sure about this change. Isn't it better to fall back to international ISO instead of national English?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [12:11:52] (03CR) 10Thiemo Mättig (WMDE): Fallback to en formatting of dates on failure (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [12:14:20] (03CR) 10Addshore: "I dont mind either way," [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [12:15:45] (03CR) 10Addshore: Fallback to en formatting of dates on failure (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [12:18:56] [13WikibaseDataModel] 15addshore 04deleted 06term-mock at 14742eee4: 02http://git.io/CE9tjg [12:29:19] (03PS1) 10Adrian Lang: Remove WikibaseEntityInsertionUpdate hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 [12:36:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 (owner: 10Adrian Lang) [12:38:35] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Add basic roundtrip testing for MwTimeIsoFormatter (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [12:42:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] MwTimeIsoFormatter should allow 16 digit years (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125968 (owner: 10Addshore) [12:44:34] [13WikibaseQuery] 15adrianlang created 06alterHooks (+1 new commit): 02http://git.io/1KbKcQ [12:44:34] 13WikibaseQuery/06alterHooks 14e434e24 15Adrian Lang: Only handle WikibaseEntityModificationUpdate [12:45:24] [13WikibaseQuery] 15adrianlang opened pull request #16: Only handle WikibaseEntityModificationUpdate (06master...06alterHooks) 02http://git.io/8BKxrg [12:46:20] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Stop using TimeIsoFormatter interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 (owner: 10Addshore) [12:47:09] [travis-ci] wmde/WikibaseQuery/alterHooks/e434e24 : Adrian Lang The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/23034194 [12:47:13] (03CR) 10Addshore: Stop using TimeIsoFormatter interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 (owner: 10Addshore) [12:48:20] Thiemo_WMDE: ^^ [12:49:50] (03CR) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [12:50:23] (03PS6) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 [12:51:53] Thiemo_WMDE: how about the start @ https://gerrit.wikimedia.org/r/#/c/124836/ :) [12:52:35] oh, ... [12:52:41] :D [12:55:15] (03CR) 10Daniel Kinzler: [C: 031] "It would be great to have unit tests to check that the hook is actually called. Otherwise, this looks fine. But the lack of unit tests mak" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 (owner: 10Adrian Lang) [12:57:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [13:01:33] Adrian_WMDE: so, you call $this->stashMwGlobas( 'wgHook' ); The you register $wgHooks['whatever'][] = array( $object, 'whatever' ); [13:01:34] addshore: i would like to understand the patch. seems it will now strip all H:M:S. And always return English format. Why? [13:01:55] Adrian_WMDE: you can then record the statue in $object. [13:02:23] would be nicer to do this with a closure, but i'm not sure how to get the call count (state) out of the closure later for verification [13:02:24] we have never displayed / dont support H M or S [13:02:45] addshore: we do want to have this at some point in the future though [13:03:05] no need to implement it now, but don't assume we'll never have HMS [13:03:17] Always return the English format? Currently the supported format is DayNumber TranslatedMonthName(orAbreviation) Year [13:03:22] this is all the parse [13:03:41] DanielK_WMDE: indeed, and when we introduce it naturally we will need to work it into the formatters and parsers [13:03:51] DanielK_WMDE: $called = false; function () use ($called) { $called = true; } ? [13:04:40] Adrian_WMDE: i'm actually unsure abotu the semantics of use( ... ) here. [13:04:50] if it's liek a parameter list, it [13:04:57] '...it'll make a copy, not use a reference. [13:05:05] &$called [13:05:09] maybe use ( &$called ) works :) [13:05:21] yea, not sure this is legal in use clauses [13:05:24] try it [13:05:26] closures are fun [13:09:10] (03CR) 10Daniel Kinzler: "looks good, but what addshore said :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125886 (owner: 10Bene) [13:19:17] (03CR) 10Daniel Kinzler: [C: 04-1] "Please fix the way the Title is constructed. Seems like this never worked correctly - so please also fix the test case :)" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE)) [13:20:11] (03PS2) 10Adrian Lang: Remove WikibaseEntityInsertionUpdate hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 [13:24:49] (03CR) 10Daniel Kinzler: [C: 04-1] Make EntityInfoBuilder method return entity info arrays instead of labels (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 (owner: 10Thiemo Mättig (WMDE)) [13:26:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 (owner: 10Adrian Lang) [13:28:43] (03CR) 10Daniel Kinzler: Insert classes for badges on client (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [13:33:37] (03CR) 10Thiemo Mättig (WMDE): Render links to deleted items in red (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE)) [13:34:37] (03PS3) 10Adrian Lang: Remove WikibaseEntityInsertionUpdate hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 [13:37:24] [13Interfaces] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/y_ZFrg [13:37:24] 13Interfaces/06master 14d919732 15Adrian Lang: Update README.md [13:41:02] (03CR) 10Thiemo Mättig (WMDE): "This patch is not supposed to be a perfect, final solution. It's a step on the way. It makes the code more flexible and following patches " (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 (owner: 10Thiemo Mättig (WMDE)) [13:41:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 (owner: 10Adrian Lang) [14:01:17] (03CR) 10Daniel Kinzler: [C: 032] Remove WikibaseEntityInsertionUpdate hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 (owner: 10Adrian Lang) [14:01:45] (03Merged) 10jenkins-bot: Remove WikibaseEntityInsertionUpdate hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125976 (owner: 10Adrian Lang) [14:14:27] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/393116e : Adrian Lang The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23039896 [14:21:08] (03CR) 10Daniel Kinzler: [C: 032] Make EntityInfoBuilder method return entity info arrays instead of labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 (owner: 10Thiemo Mättig (WMDE)) [14:21:32] (03Merged) 10jenkins-bot: Make EntityInfoBuilder method return entity info arrays instead of labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125958 (owner: 10Thiemo Mättig (WMDE)) [14:24:16] (03CR) 10Daniel Kinzler: [C: 032] "as discussed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE)) [14:24:35] (03Merged) 10jenkins-bot: Render links to deleted items in red [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125874 (owner: 10Thiemo Mättig (WMDE)) [14:32:31] (03CR) 10Lydia Pintscher: [C: 04-2] "I think it is time to abandon this one. Sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80778 (owner: 10Burthsceh) [14:32:53] (03PS7) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 [14:33:03] (03PS8) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 [14:33:42] Lydia_WMDE: I thought you let things die, not kill them :p [14:33:56] JohnLewis: sometimes i have an urge to kill [14:33:56] :P [14:34:29] JeroenDeDauw: I think you should start running :p [14:34:42] he is lucky [14:34:44] not in the office [14:34:46] :D [14:34:47] (03Abandoned) 10Hoo man: Add option to disable updating Repo on moving page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80778 (owner: 10Burthsceh) [14:34:57] only thiemo daniel henning and christopher [14:35:07] Ah. [14:35:20] Then Adam is in a different country :D [14:37:07] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/53e9137 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23041329 [14:42:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [14:46:21] I received https://www.wikidata.org/wiki/Wikidata:Property_proposal/Authority_control in қазақша (ka?) while my language is set to en , again, after reading it several times today in English [14:47:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [14:48:02] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/408312f : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23041529 [14:48:04] (03CR) 10Thiemo Mättig (WMDE): (bug 45277) Introducing ApiErrorReporter (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [14:50:01] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Stop using TimeIsoFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 (owner: 10Addshore) [14:50:04] jayvdb: sounds like a caching issue [14:50:35] Thiemo_WMDE: DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=63068 <- what's the status on this one? unclear to me with the merge and revert [14:51:32] [13WikibaseQuery] 15thiemowmde pushed 1 new commit to 06alterHooks: 02http://git.io/r4835g [14:51:32] 13WikibaseQuery/06alterHooks 141bcefff 15thiemowmde: Update HookSetup.php [14:52:02] jayvdb: Was the whole interface in that language or only the content? [14:54:13] Lydia_WMDE: DanielK_WMDE: I think this was reverted in a specific branch only. [14:54:30] Lydia_WMDE: On master, this feature is now experimental. The revert was on the branch (that should probably not be logged in bugzilla, btw). I think the frontend functionality of that is now done. we should verify & make it enabled for production. [14:54:37] k [14:54:51] Henning_WMDE: the frontend code for claims on property pages works now, right? [14:54:54] marking as fixed then and we will demo in demo time [14:58:00] (03CR) 10Daniel Kinzler: "the regex change needs testing. It also seems pointless." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 (owner: 10Thiemo Mättig (WMDE)) [14:58:31] Lydia_WMDE: we just shouldn't forget to remove it from experimental... [14:58:40] yeah [14:58:46] hoo: the section names [14:59:31] [travis-ci] wmde/WikibaseQuery/alterHooks/1bcefff : thiemowmde The build is still failing. http://travis-ci.org/wmde/WikibaseQuery/builds/23043762 [15:00:55] (03CR) 10Thiemo Mättig (WMDE): "Sorry, I'm still not convinced this should be done. The fallback should be ISO in my opinion, not English." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [15:01:00] hoo: which probably means the bug is something to do with {{int:lang}} in https://www.wikidata.org/wiki/Module:TranslateThis [15:01:32] (03CR) 10Addshore: "Thats fine, I will take this out of the chain once https://gerrit.wikimedia.org/r/#/c/124836/16 is merged" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [15:11:43] (03CR) 10Thiemo Mättig (WMDE): "This keeps confusing me. This removes all localization. Why? Is this supposed to stay unlocalized? Or do we want this localized and this p" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [15:13:24] (03CR) 10Addshore: "This is not always English, as said in IRC." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [15:18:43] (03CR) 10Thiemo Mättig (WMDE): Clean-up ItemContentTest and Wikibase.hooks.php (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 (owner: 10Thiemo Mättig (WMDE)) [15:35:11] addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=37227 <- is this still valid? [15:38:11] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Please avoid confusing constructs like foreach ( $apples as $banana ). But it would be stupid to block this because of such nitpicks. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:38:51] (03Merged) 10jenkins-bot: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:40:15] addshore: around? [15:40:21] yup [15:40:56] oh, sorry missed your ping Lydia_WMDE ! [15:41:00] the "forces the format to be j F Y" patch. am I right and this is just for now and will change in the future to be localized again? [15:41:14] addshore: how dare you!!!!1111eleven [15:41:16] mhhhm Lydia_WMDE I dont think so! [15:41:30] addshore: ok will close then [15:41:37] Thiemo_WMDE: I might change, if we can parse further localization [15:41:46] *it might change [15:41:54] likely hood is that we have other things to concentrate on [15:42:34] it already goes beyond what the frontend was doing, and the aim was merely to match that in the first place [15:43:04] we have stuff like 'Feb 11 1930' in the tests. [15:43:13] Thiemo_WMDE: yes thats parsing [15:43:23] but that will then be formatted as 11 Feburary 1930 [15:45:19] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [15:45:40] (03Merged) 10jenkins-bot: Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [15:46:16] Thiemo_WMDE: I will reorder the chain of stuff now :) [15:46:20] and get rid of that -1 patch [15:46:34] if the current solution blocks users in so many languages it sure is a good step. next step should be to make the parser aware of more localizations. then the formatter can output these localizations. right? [15:46:53] (03PS8) 10Addshore: Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [15:47:54] (03PS2) 10Addshore: Stop using TimeIsoFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 [15:48:30] (03PS2) 10Addshore: MwTimeIsoFormatter should allow 16 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125968 [15:50:31] (03PS2) 10Addshore: Add basic roundtrip testing for MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 [15:50:43] (03CR) 10Addshore: "Comments have been addressed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [15:51:09] Thiemo_WMDE: Im faily sure that whole chain is ready now then :) [15:51:21] once jenkins catches up [15:53:14] *twiddles thumbs* [15:56:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [15:57:30] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1ca9cee : daniel The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23048043 [15:58:34] (03CR) 10Addshore: "I just read your comment Aude:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [15:59:35] (03CR) 10Addshore: "Which I see you fixed in a follow up Aude!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [16:00:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Factor hard constraints out of EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124984 (owner: 10Daniel Kinzler) [16:00:06] (03CR) 10Addshore: [C: 032] Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [16:00:25] (03Merged) 10jenkins-bot: Factor hard constraints out of EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124984 (owner: 10Daniel Kinzler) [16:04:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Patch set 2 was only a rebase, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 (owner: 10Addshore) [16:04:22] (03Merged) 10jenkins-bot: Stop using TimeIsoFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 (owner: 10Addshore) [16:05:09] (03CR) 10Thiemo Mättig (WMDE): [C: 032] MwTimeIsoFormatter should allow 16 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125968 (owner: 10Addshore) [16:05:30] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125709 (owner: 10Addshore) [16:05:32] (03Merged) 10jenkins-bot: MwTimeIsoFormatter should allow 16 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125968 (owner: 10Addshore) [16:07:37] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1 V: 04-1] Add basic roundtrip testing for MwTimeIsoFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [16:11:18] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125968 (owner: 10Addshore) [16:15:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [16:27:42] (03CR) 10Addshore: Add basic roundtrip testing for MwTimeIsoFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [16:28:50] (03PS3) 10Addshore: Add basic roundtrip testing for MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 [16:29:04] Thiemo_WMDE: ^^ :) [16:33:12] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4e99b57 : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23049881 [16:33:26] (03CR) 10Daniel Kinzler: Clean-up ItemContentTest and Wikibase.hooks.php (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 (owner: 10Thiemo Mättig (WMDE)) [16:35:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [16:50:39] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/67d75c7 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23049918 [16:57:22] (03PS1) 10Thiemo Mättig (WMDE): Optimize time parsers regular expressions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126018 [17:02:03] (03PS1) 10Thiemo Mättig (WMDE): Support B.C. with dot at the end as well as B. C. with spaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126021 [17:05:14] (03PS1) 10Thiemo Mättig (WMDE): Use EraParser constants instead of repeating the +/- characters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126022 [17:06:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126018 (owner: 10Thiemo Mättig (WMDE)) [17:07:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add basic roundtrip testing for MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [17:07:48] (03Merged) 10jenkins-bot: Add basic roundtrip testing for MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125972 (owner: 10Addshore) [17:12:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/61f9da3 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23050143 [17:14:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126021 (owner: 10Thiemo Mättig (WMDE)) [17:17:47] (03CR) 10Bene: Insert classes for badges on client (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [17:19:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126022 (owner: 10Thiemo Mättig (WMDE)) [17:32:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e71ffec : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23050263 [17:36:50] Thiemo_WMDE: http://www.php.net/manual/en/regexp.reference.onlyonce.php [18:06:55] (03PS2) 10Thiemo Mättig (WMDE): Clean-up ItemContentTest and Wikibase.hooks.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 [18:16:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125855 (owner: 10Thiemo Mättig (WMDE)) [18:20:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/3e23723 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/23054697 [18:23:20] (03PS2) 10Thiemo Mättig (WMDE): Use EraParser constants instead of repeating the +/- characters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126022 [18:29:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126022 (owner: 10Thiemo Mättig (WMDE)) [18:34:48] hello [18:35:12] anyone from India [18:53:55] https://www.wikidata.org/wiki/Special:Contributions/Shrees1234 I have done few editing these days, please if anyone can review dem [19:13:35] (03PS1) 10Thiemo Mättig (WMDE): Rename formatter option RESOLVE_ID to LOOKUP_LABEL [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126055 [19:20:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126055 (owner: 10Thiemo Mättig (WMDE)) [19:35:09] 1 Warning: Failed to push job to job queue [Called from Wikibase\ClientHooks::onTitleMoveComplete in /usr/local/apache/common-local/php-1.23wmf22/extensions/Wiki [19:35:09] data/extensions/Wikibase/client/WikibaseClient.hooks.php at line 843] in /usr/local/apache/common-local/php-1.23wmf22/includes/debug/Debug.php on line 303 [20:03:21] (03PS1) 10Thiemo Mättig (WMDE): Use EntityTitleLookup in EntityIdHtmlLinkFormatter on Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126070 [20:04:10] hoo|away: ^ see Reedy's post [20:05:01] ok, that's awry [20:05:24] Reedy: Urgent or can wait? [20:10:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126070 (owner: 10Thiemo Mättig (WMDE)) [20:20:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126107 (owner: 10L10n-bot) [20:44:38] JohnFLewis: Lydia_WMDE what is this evil plot? [20:49:33] JeroenDeDauw: Lydia_WMDE just saying she has the urge to kill, so I told you run because you're too awesome to be killed :p [21:37:56] (03PS17) 10Thiemo Mättig (WMDE): [WIP] Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [21:44:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [21:45:14] (03PS1) 10Thiemo Mättig (WMDE): Rename PropertyInfo to more generic EntityInfo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126139 [21:51:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126139 (owner: 10Thiemo Mättig (WMDE)) [21:51:54] (03PS2) 10Thiemo Mättig (WMDE): Rename PropertyInfo to more generic EntityInfo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126139 [21:57:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/126139 (owner: 10Thiemo Mättig (WMDE))