[00:30:22] (03CR) 10Jeroen De Dauw: Factor hard constraints out of EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124984 (owner: 10Daniel Kinzler) [05:05:05] [13WikibaseDataModel] 15Benestar comment on pull request #57 14fc0b351: Label description confusion? 02http://git.io/S_vy9Q [05:06:35] [13WikibaseDataModel] 15Benestar comment on pull request #57 14fc0b351: Label description confusion? 02http://git.io/vEBqZg [06:53:35] (03CR) 10Tobias Gritschacher: [C: 032] Rename option 'displayBadges' to 'badgeClassNames' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [06:54:03] (03Merged) 10jenkins-bot: Rename option 'displayBadges' to 'badgeClassNames' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [07:01:19] <23LAACW83> [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/bb4f3ca : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22750729 [08:05:25] Adrian_WMDE: https://meta.wikimedia.org/wiki/Wikidata/Development/Testing#Run_tests_in_parallel [08:05:36] thanks [08:12:02] Adrian_WMDE: and something else you might want: https://meta.wikimedia.org/wiki/Wikidata/Development/Testing#Run_tests_headless [08:12:11] Doing that for quite some time [08:12:18] ok [08:12:20] cool [08:17:20] Tobi_WMDE: Pretty fast, but also pretty broken :/ [08:20:49] But that's probably due to the brokenness of my instance [08:36:52] [13Interfaces] 15adrianlang 04force-pushed 06augmentParseException from 1415fd8b3 to 140fa5b3e: 02http://git.io/KSONmg [08:36:52] 13Interfaces/06augmentParseException 140fa5b3e 15Adrian Lang: Add rawValue and expectedFormat arguments to ValueParsers\ParseException... [08:37:52] [13Interfaces] 15adrianlang 04force-pushed 06augmentParseException from 140fa5b3e to 14f957c28: 02http://git.io/KSONmg [08:37:52] 13Interfaces/06augmentParseException 14f957c28 15Adrian Lang: Add rawValue and expectedFormat arguments to ValueParsers\ParseException... [08:44:28] [13Time] 15adrianlang 04force-pushed 06augmentParseException from 140460e77 to 1400fce67: 02http://git.io/0IQddQ [08:44:28] 13Time/06augmentParseException 1400fce67 15Adrian Lang: Pass rawValue and expectedFormat arguments to ParseExceptions... [08:58:20] Tobi_WMDE: My instance is clean now, but the tests are pretty flaky [09:04:39] (03PS1) 10Adrian Lang: Introduce explit data-values/interfaces dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 [09:04:41] (03PS1) 10Adrian Lang: Don't catch ParseException in order to just rethrow it wrapped [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125378 [09:04:43] (03PS1) 10Adrian Lang: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 [09:04:45] (03PS1) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [09:04:47] (03PS1) 10Adrian Lang: Bump data-values/time dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [09:12:37] DanielK_WMDE: JeroenDeDauw: Do Wikibase\Lib\FormattingException and ValueParsers\FormattingException serve different purposes? [09:13:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125377 (owner: 10Adrian Lang) [09:20:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125378 (owner: 10Adrian Lang) [09:21:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [09:22:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [09:23:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [09:29:24] anyone alive in here? [09:30:12] we have a user in #wikipedia-en-help seeking help about Wikidata.. i'm not familiar enough with it to help, can someone help? [09:32:30] OlEnglish: sure. can you send them here? [09:34:41] sigh, now they're not responding.. oh well [09:34:55] thanks anyway Lydia_WMDE :) [09:35:02] heh [09:35:03] sure [09:35:24] (03PS2) 10Adrian Lang: Pass rawValue and expectedFormat to ParseExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 [09:35:26] (03PS2) 10Adrian Lang: Use expectedFormat for more specific ParseException localizing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 [09:35:28] (03PS2) 10Adrian Lang: Bump data-values/time dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [09:37:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125379 (owner: 10Adrian Lang) [09:38:48] (03Abandoned) 10Adrian Lang: Don't catch ParseException in order to just rethrow it wrapped [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125378 (owner: 10Adrian Lang) [09:39:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [09:41:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [09:44:50] Lydia_WMDE, Tobi_WMDE: daily? [09:45:02] DanielK_WMDE: jep :) [09:45:03] coming [09:45:21] DanielK_WMDE: one mom [09:57:23] addshore: [09:57:28] ping [10:00:23] (03PS1) 10WikidataBuilder: New Wikidata Build - 11/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 [10:06:26] [13WikibaseQuery] 15adrianlang 04force-pushed 06snakview from 14d97e297 to 144f2840d: 02http://git.io/29CD-Q [10:06:26] 13WikibaseQuery/06snakview 144f2840d 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page... [10:08:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [10:09:32] Tobi_WMDE: Failed with two parallel jobs, too, just a bit later. [10:11:29] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 11/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [10:14:32] (03Merged) 10jenkins-bot: New Wikidata Build - 11/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [10:17:29] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/i329Dg [10:17:29] 13WikibaseDataModel/06master 14113afc2 15thiemowmde: Merge pull request #55 from wmde/dep... [10:18:18] Adrian_WMDE: same set of strange errors? [10:18:49] did you update your roby version? [10:18:54] *ruby [10:19:13] Same set [10:19:16] Still on 2.0 [10:19:19] I could try 2.1 [10:19:57] Adrian_WMDE: I don't expect that this fixes it.. but you should update nevertheless [10:24:02] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Overall this change is very good. Please let me know if I can help you. If it's ok for you I can do some of the fixes I mentioned in the c" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [10:42:12] Tobi_WMDE: Not fixed with 2.1 :/ [10:56:01] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I'm sorry but I will not merge this change. All it does (now) is removing something that's unused and does no harm. There was a reason arr" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [11:05:15] Tobi_WMDE: pong [11:07:03] addshore: lunch [11:14:43] addshore: missed the daily :/ [11:15:06] indeed, I need to just get into my mind its 10:45 not 11:45! [11:15:12] heh [11:15:36] addshore: Where the hell are you right now? [11:15:57] the UK :P [11:16:11] UTC+1 [11:16:16] addshore: I thought it's 12:16 here O_o [11:16:34] yes, but what is 11:45 in berlin is 10:45 here JohnLewis ;p [11:16:46] addshore: Oh :p [11:16:58] Tell them to change their time to suit you then :D [11:17:12] * aude be ok with that [11:35:23] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/125385 (owner: 10WikidataBuilder) [11:41:08] Tobi_WMDE: Issues are headless-related; have a look at https://github.com/leonid-shevtsov/headless#running-tests-in-parallel [11:42:00] I tried to follow https://gist.github.com/rosskevin/5937888#file-features-support-javascript-rb-L44 and http://makandracards.com/makandra/1241-how-to-run-your-tests-in-parallel-to-speed-up-test-execution#using-paralleltests-with-selenium, but that did not work [12:14:44] (03CR) 10Adrian Lang: [C: 032] Fix site links group filtering in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124332 (owner: 10Aude) [12:15:15] (03Merged) 10jenkins-bot: Fix site links group filtering in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124332 (owner: 10Aude) [12:24:20] (03CR) 10Adrian Lang: [C: 032] "Had a short talk with Lydia; she is pretty sure we want it like that and she is aware of the technical implications." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121361 (owner: 10Daniel Kinzler) [12:24:39] (03Merged) 10jenkins-bot: (bug 57693) supply id for claim group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121361 (owner: 10Daniel Kinzler) [12:26:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e35fc3d : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22768560 [12:27:17] (03CR) 10Adrian Lang: [C: 032] Have travis test variety of setups (client-only, repo-only and both) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123864 (owner: 10Aude) [12:27:33] yay [12:27:41] (03Merged) 10jenkins-bot: Have travis test variety of setups (client-only, repo-only and both) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123864 (owner: 10Aude) [12:29:39] addshore: what's the deal with https://gerrit.wikimedia.org/r/#/c/124833/ ? [12:29:46] (03CR) 10Aude: [C: 04-1] "given bug 63710 deals with similar issues, we might want to rethink this some and come up with a solution that works for both places where" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [12:30:15] "Things are being re thought" doesn't give anyone a good explanation.. :) [12:30:36] Adrian_WMDE: Tobi_WMDE we should review https://gerrit.wikimedia.org/r/#/c/124773/ [12:30:41] (03CR) 10Adrian Lang: [C: 032] Add tests for formatting dates in different langs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 (owner: 10Addshore) [12:31:08] (03Merged) 10jenkins-bot: Add tests for formatting dates in different langs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 (owner: 10Addshore) [12:31:13] and then adjust my patch https://gerrit.wikimedia.org/r/121678 to handle both that case and snak html generator [12:32:11] (03Abandoned) 10Aude: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/124761 (owner: 10Aude) [12:35:26] (03Abandoned) 10Aude: Pass Message object as param in MessageException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121123 (owner: 10Aude) [12:36:04] (03Abandoned) 10Aude: Improve TermPropertyLabelResolver and test, including more cache scenarios [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100192 (owner: 10Aude) [12:38:35] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d173fcf : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22769256 [12:39:32] Tobi_WMDE: I am going to write a different patch doing it in a different way [12:39:52] addshore: ok. can we also do something against the slow tests? [12:40:01] and the tests eating up all my RAM? [12:40:10] Adrian_WMDE: just merged the first change [12:40:13] Not really :/ its because they load all of the language objects [12:40:25] I'll have a look at the performance [12:40:29] addshore: but there is something really wrong going on [12:40:33] And currently the code depends on them [12:40:47] language objects are horribly huge and slow [12:41:03] ideally date handlign code is separated from Language [12:41:14] addshore: when running those tests, in the end php is requiring more memory than phpstorm and rubymine together.. [12:41:28] be warned about using Language objects in your code! [12:41:33] and they take like 30 minutes for me [12:41:56] Yup_ again_ because it loads I'll of the language objects :p only take about 5\10 for me [12:42:07] addshore: what about only testing for the 20 most used languages? [12:42:10] They take 2 min for me and slowly eat RAM [12:42:15] Also, get much slower over time [12:42:29] that would probably cover way over 90% of the users [12:43:12] I'd prefer to have the issue fixed first [12:43:15] Tobi_WMDE: the 20 most used languages probably arent even broken [12:43:19] addshore: can't we just load it once [12:43:20] ? [12:43:30] addshore: german is [12:43:43] german I can fix with a 1 character fix [12:43:47] actually 2 characters ;p [12:44:04] great but we're talking about the tests [12:44:24] if core were ever to change its likely this code would break, the only way we would notice that is the tests [12:45:01] the chain of patches as they are could be merged, them fix many things and languages but Im thinking of poking it in a different direction now anyway [12:45:12] and then maybe managing to stay away from the MW language objects more [12:45:28] but atm they are needed in the formatter and thus are loaded in the tests [12:48:08] addshore: that also means waiting ~10 mins for jenkins every time [12:48:20] or probably we should split them off [12:48:45] even with the other way I am going to do it, there is no way to get away from the language object right now [12:48:49] unless I write some hack [12:48:55] might even be worth it [12:49:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0cc3aeb : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22769415 [12:50:10] If I comment out the passing of the language option to the Formatter, tests pass in 0.5s [12:50:39] defeats the point of the tests [12:50:46] Yeah, I know [12:50:50] :P [12:50:57] hence the bugggs! [12:50:58] This is just about finding out where the leak is [12:51:04] thats because they will load the en object each time [12:51:22] Adrian_WMDE: its not a leak, it loads and i presume caches 350+ language objects [12:51:48] language object should be split up.... not easy but who knows [12:52:12] addshore: Well, there is something going wrong, because the first 20 cases run like hell and the last 20 crawl [12:52:38] And yeah, that might be in \Language [12:52:42] https://en.wiktionary.org/wiki/not_touch_something_with_a_ten_foot_pole ;) [12:52:45] But it should not be like that [12:52:59] Adrian_WMDE: the first 20 cases all use 1 language object [12:53:07] and from then on they create a language object for every test [12:53:30] as all of the first set of tests all test the EN language and formatting (which is the default) [12:53:32] Ok, so the first 120 run fast [12:53:48] It gets massively slower towards the end. [12:55:42] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/568c9d1 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22769695 [12:58:47] after the first 120ish mine runs at a constant speed [12:58:55] but I will do some digging [13:00:28] (03PS4) 10Addshore: Normalise digits in time formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124868 (owner: 10Aude) [13:01:06] (03CR) 10Tobias Gritschacher: [C: 032] "Fine with that as an improvement over the '?'." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:01:31] (03Merged) 10jenkins-bot: Handle exceptions in ClaimDifferenceVisualizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:01:51] (03CR) 10Adrian Lang: Handle exceptions in ClaimDifferenceVisualizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:03:18] (03CR) 10Aude: Handle exceptions in ClaimDifferenceVisualizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124773 (owner: 10Aude) [13:03:31] (03CR) 10Tobias Gritschacher: "@aude can't we use the MismatchingDataValueTypeException for the other cases too?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:04:25] (03CR) 10Aude: "maybe do in snak formatter, although might not work because we then want to be able to apply css classes for the error styling and such" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:05:36] (03CR) 10Aude: "this is okay as an improvement, though further work is needed to use mismatch exception in more places (including EntityIdValue formatters" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:05:49] Tobi_WMDE: Adrian_WMDE [13:05:59] (03CR) 10Tobias Gritschacher: "Is this blocked on something specific in going further as DanielK suggested? Also this needs rebasing. This is likely to get stale, so I w" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [13:06:10] suppose we shouldn't block on making the patch more perfect and handle all the things [13:06:28] but needs to specify the right versoin of data values in composer [13:06:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124868 (owner: 10Aude) [13:06:47] (03CR) 10Addshore: [C: 032 V: 031] Normalise digits in time formatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124868 (owner: 10Aude) [13:07:04] (03CR) 10Addshore: [C: 04-2] Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:07:27] aude: I'm going to make a new tag for data-values/common then.. [13:07:33] ok [13:07:44] (03PS19) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [13:08:19] (03PS20) 10Aude: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [13:09:12] There is another pull request from me on commons :/ [13:09:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:09:55] Adrian_WMDE: that depends on one in interfaces.. right [13:10:07] Yeah [13:10:09] Just go ahead :) [13:10:53] so if someone feels eligible to merge https://github.com/DataValues/Interfaces/pull/4 [13:10:57] :) [13:11:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:15:00] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/52b681e : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22771773 [13:15:22] (03PS13) 10Addshore: Fix formatting dates in all languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 [13:15:51] aude: Tobi_WMDE after looking at core more, ^^ should be what we actually want for now [13:16:09] (03CR) 10Addshore: Fix formatting dates in all languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:16:18] (03PS5) 10Addshore: Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [13:16:30] (03CR) 10Addshore: [C: 04-2] When precision is a <= year use 'Y' dateformat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125177 (owner: 10Addshore) [13:16:54] letting the tests run on jenkins, there may still be 1 or 2 languages failing apparently [13:19:06] [13Common] 15tobijat pushed 1 new commit to 06master: 02http://git.io/HirtwQ [13:19:06] 13Common/06master 1483ee907 15Tobi Gritschacher: Update README.md [13:19:33] [13Common] 15tobijat pushed 1 new commit to 06master: 02http://git.io/gBZBLg [13:19:33] 13Common/06master 14406663b 15Tobi Gritschacher: Update Common.php [13:19:53] [13Common] 15tobijat tagged 060.2.2 at 06master: 02http://git.io/7qlKBw [13:20:26] (03PS21) 10Tobias Gritschacher: Use MismatchingDataValueTypeException for Snak formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:21:57] think I will just go on holiday during jenkins is running tests [13:22:46] :P [13:23:13] Tobi_WMDE: did you see 2 patches I just added you to (they are drafts) for doing composer installs on extensions for wmf jenkins [13:23:19] not tested but they should work out of the box [13:23:30] The hooks seem to be the problem [13:23:40] Every language adds hooks [13:23:52] if they do we can just turn the old tests straight back on as they are still configured in jenkins-job-builder-config thingy I think [13:24:04] Adrian_WMDE: which line are you looking at? [13:24:25] addshore: I did a cachegrind dump [13:24:36] addshore: nice [13:24:38] 80% of the run time are spent in Hooks::run [13:24:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:24:49] And I've seen hooks added in Language_* classes [13:25:27] addshore: I think the config of setting wikibase up changed slightly so I doubt the old jenkins-jobs will work [13:26:50] (03PS14) 10Addshore: Fix formatting dates in most languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 [13:27:09] [13Interfaces] 15JeroenDeDauw comment on pull request #4 14f957c28: We do not align stuff in comments like this. 02http://git.io/_X07pQ [13:28:02] (03PS2) 10Addshore: Fallback to en formatting of dates on failure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 [13:28:16] (03Abandoned) 10Addshore: When precision is a <= year use 'Y' dateformat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125177 (owner: 10Addshore) [13:28:19] [13Interfaces] 15JeroenDeDauw closed pull request #4: Add rawValue and expectedFormat arguments to ValueParsers\ParseException (06master...06augmentParseException) 02http://git.io/44E0ug [13:28:26] (03CR) 10Addshore: "See https://gerrit.wikimedia.org/r/124836" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125177 (owner: 10Addshore) [13:28:39] (03Abandoned) 10Addshore: Stop ALWAYS using regex to fix dateFormats [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124833 (owner: 10Addshore) [13:29:18] [13Interfaces] 15adrianlang 04deleted 06augmentParseException at 14241e547: 02http://git.io/nfq0-w [13:29:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/859981d : Addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22772293 [13:30:04] (03PS6) 10Addshore: Add initial test for MwTimeIsoFormatter::format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [13:30:28] right Tobi_WMDE aude Adrian_WMDE, once all the tests finish on those patches everything should be sorted [13:31:03] addshore: looks like 2 langs are left broken.. [13:31:18] Tobi_WMDE: (PS2) Addshore: Fallback to en formatting of dates on failure [extensions/Wikibase] - https://gerrit.wikimedia.org/r/125182 [13:31:24] [13Time] 15JeroenDeDauw comment on pull request #14 1400fce67: Do you intend to publicly access this? Guess not. I'm quite annoyed by PHP not allowing to have non-public constants and would be tempted to do this instead:... 02http://git.io/2ZpcYg [13:31:46] so there is a fallback to EN now before a final fallback to just the timestamp [13:32:24] will try and get a patch up moving away from the language object so much if possible [13:32:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [13:33:12] [13Time] 15adrianlang comment on pull request #14 1400fce67: I'm not too sure, I think initially I planned to access them publicly, but as they are we might just as well append them to a base string for language keys as they are. @brightbyte what do you think? 02http://git.io/CHfWmg [13:38:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [13:38:20] (03PS11) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [13:38:53] Found it [13:39:22] Every test case adds 5 handlers to LocalisationCacheRecache [13:40:37] Adrian_WMDE: LocalisationCacheRecache? where is that? [13:40:41] oh, the hook? [13:40:46] Yes [13:41:01] (03CR) 10Jeroen De Dauw: [C: 04-1] "it bumps number, not time" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [13:41:27] That's probably data-values/data-values, wikibase/data-model, Query, Cldr and ValueView in my setup [13:41:51] (03CR) 10Jeroen De Dauw: [C: 031] "Generally looks good to me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125380 (owner: 10Adrian Lang) [13:41:58] Yes, it's them [13:43:23] (03PS1) 10Addshore: Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 [13:43:26] Adrian_WMDE: ^^ [13:43:33] (03CR) 10jenkins-bot: [V: 04-1] Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [13:43:33] that speeds it up dramatically then :) [13:44:05] ill base it at the end of my chain :P [13:44:09] and we can see [13:45:03] (03PS2) 10Addshore: Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 [13:45:23] I think it's a bug in the json i18n compatibility shim, though [13:46:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [13:49:21] 22 seconds :D [13:52:29] Adrian_WMDE: sped up by 22 seconds or now they only take 22? :P [13:52:35] Take 22s [13:52:39] good good :) [13:53:00] I wrapped all the i18n files in my setup in constants [13:53:07] right, well I think all of those patches are now in a mergeable state once the tests pass. *needs a nap* [13:55:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125182 (owner: 10Addshore) [13:59:18] (03PS3) 10Adrian Lang: Bump data-values/number dependency and adjust to new version [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 [14:02:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124830 (owner: 10Aude) [14:04:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [14:07:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [14:10:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [14:11:01] so may 2s!!! [14:13:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [14:14:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125381 (owner: 10Adrian Lang) [14:33:33] addshore: is the code somewhere that generates this fancy wikidata-geo-map? [14:33:45] it used t be in one of out githubs, right? [14:37:27] its there Tobi_WMDE [14:37:32] wikidata-analysis I think [14:37:35] or -analytics [15:02:39] (03PS2) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 [15:03:40] (03PS3) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 [15:04:56] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/mkj3Tg [15:04:56] 13jenkins-job-builder-config/06master 14be95561 15Tobias Gritschacher: Adding job for running browsertests in parallel [15:07:44] (03PS3) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 [15:07:48] (03PS12) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [15:08:14] (03CR) 10jenkins-bot: [V: 04-1] (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:09:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:09:35] (03PS4) 10Bene: Insert classes for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 [15:11:19] bah. old version of php. screw it. [15:11:31] DanielK_WMDE__: what? [15:11:33] (03CR) 10Bene: Insert classes for badges on client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:11:35] You have a 5.2? [15:11:56] 5.3 is also old really... [15:12:22] (03PS4) 10Daniel Kinzler: (bug 45277) Introducing ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 [15:12:47] Tobi_WMDE: https://travis-ci.org/DataValues/Interfaces/jobs/22755593 [15:12:51] JeroenDeDauw: no, I have 5.4.9, which allows me to do ( new Foo() )->bar(). [15:12:56] but 5.3 chokes on that [15:13:52] Tobi_WMDE: quick heads up before I'm gone for the day: bug 45277 will cause changes to the way the api reports errors. [15:14:14] DanielK_WMDE__: be happy our CI now catches that :) [15:14:21] Tobi_WMDE: technically, it's a breaking change, though I doubt anything is really depending on the messy/inconsistent way we currently use. [15:14:49] JeroenDeDauw: i you call "jenkins dies" as "catching that", yea :) [15:14:57] anyway, off nor now. [15:15:03] DanielK_WMDE__: ok [15:15:42] Check out this bug report - he pasted his whole Special:Version! https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/271#issuecomment-40162302 [15:16:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:18:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:19:06] (03CR) 10Tobias Gritschacher: [C: 032] Stash wgHooks in MwTimeIsoFormatterTest for speed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125399 (owner: 10Addshore) [15:19:50] [= [15:22:12] [13WikibaseDataModel] 15JeroenDeDauw tagged 060.7.3 at 144a51649: 02http://git.io/mFOTCA [15:22:12] 13WikibaseDataModel/060.7.3 144a51649 15jeroendedauw: 0.7.3 release [15:23:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [15:24:53] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #56: [DNM] Work on version 0.8.x (06master...060.8.x) 02http://git.io/eviwqQ [15:25:03] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14fc0b351 to 145c342d6: 02http://git.io/ahYWpg [15:25:03] 13WikibaseDataModel/06rem 145c342d6 15jeroendedauw: [WIP] remove toArray and newFromArray [15:27:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124605 (owner: 10Bene) [15:31:24] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124323 (owner: 10Daniel Kinzler) [15:31:38] (03PS1) 10Jeroen De Dauw: Update used Diff and DM versions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125408 [15:32:52] meeeeeeeeeeeeergeeeeeeeeeee ^ [15:39:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125408 (owner: 10Jeroen De Dauw) [15:46:43] addshore: you still alive? [15:56:25] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #57 145c342d6: Good catch 02http://git.io/0dwj9A [16:07:57] [travis-ci] wmde/WikibaseDataModel/rem/5c342d6 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22782550 [16:11:44] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 145c342d6 to 14fac52e8: 02http://git.io/ahYWpg [16:11:45] 13WikibaseDataModel/06rem 14fac52e8 15jeroendedauw: [WIP] remove toArray and newFromArray [16:12:31] Thiemo_WMDE: meeergeee https://gerrit.wikimedia.org/r/#/c/125408/ :) [16:17:02] JeroenDeDauw: Your e-key is a little bit stuck sometimes. :D [16:24:22] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14fac52e8 to 14959702d: 02http://git.io/ahYWpg [16:24:22] 13WikibaseDataModel/06rem 14959702d 15jeroendedauw: [WIP] remove toArray and newFromArray [16:27:10] [travis-ci] wmde/WikibaseDataModel/rem/fac52e8 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22785594 [16:27:30] Thiemo_WMDE: It now has a list of the breaking changes: https://github.com/wmde/WikibaseDataModel/pull/57/files [16:27:52] I might undo a few of those [16:27:57] Anyway, commit far from done [16:34:22] @seen Amir [16:34:25] :p [16:34:31] Ah, not here... [16:45:33] [travis-ci] wmde/WikibaseDataModel/rem/959702d : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22786354 [16:49:01] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14959702d to 14bcb366e: 02http://git.io/ahYWpg [16:49:01] 13WikibaseDataModel/06rem 14bcb366e 15jeroendedauw: [WIP] remove toArray and newFromArray [17:03:38] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06dm073 (+1 new commit): 02http://git.io/jkd4MA [17:03:38] 13WikibaseInternalSerialization/06dm073 1473c0d63 15jeroendedauw: Match changes in DataModel [17:04:21] [travis-ci] wmde/WikibaseDataModel/rem/bcb366e : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22788089 [17:05:04] JeroenDeDauw: I am [17:05:23] Thiemo_WMDE: I can has review of https://github.com/wmde/WikibaseInternalSerialization/pull/27 ? [17:05:35] addshore: easy review is easy https://gerrit.wikimedia.org/r/#/c/125408/1 [17:06:05] sjoerddebruin: someeeeeeeeetimeeeeees? [17:06:13] (03CR) 10Addshore: [C: 032] Update used Diff and DM versions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125408 (owner: 10Jeroen De Dauw) [17:06:18] Ugh. :P [17:10:40] [13WikibaseInternalSerialization] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/Mib9lA [17:10:40] 13WikibaseInternalSerialization/06master 140807a19 15thiemowmde: Merge pull request #27 from wmde/dm073... [17:22:14] [travis-ci] wmde/WikibaseInternalSerialization/dm073/73c0d63 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/22789067 [17:30:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/de65b49 : jeroendedauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22789287 [17:36:42] (03PS11) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [17:39:19] [travis-ci] wmde/WikibaseInternalSerialization/master/0807a19 : thiemowmde The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/22789564 [17:42:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [17:47:27] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06remdep (+1 new commit): 02http://git.io/p072-A [17:47:27] 13WikibaseDataModelSerialization/06remdep 14d5386d8 15jeroendedauw: Stop using deprecated Property::newEmpty [17:47:47] [13WikibaseDataModelSerialization] 15JeroenDeDauw opened pull request #63: Stop using deprecated Property::newEmpty (06master...06remdep) 02http://git.io/HeVFDA [17:47:51] sjoerddebruin: are you reeeeeeeeeeady? [17:47:58] For what? :O [17:47:59] Thiemo_WMDE: revieeeeeeeew https://github.com/wmde/WikibaseDataModelSerialization/pull/63 [17:48:09] :O [17:55:16] [travis-ci] wmde/WikibaseDataModelSerialization/remdep/d5386d8 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/22791764 [18:01:58] addshore: https://github.com/wmde/WikibaseDataModelSerialization/pull/63 [18:12:48] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14bcb366e to 14083bd7d: 02http://git.io/ahYWpg [18:12:48] 13WikibaseDataModel/06rem 14083bd7d 15jeroendedauw: [WIP] remove toArray and newFromArray [18:16:17] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rem from 14083bd7d to 14b04872a: 02http://git.io/ahYWpg [18:16:17] 13WikibaseDataModel/06rem 14b04872a 15jeroendedauw: [WIP] Legacy code removal... [18:19:00] [travis-ci] wmde/WikibaseDataModel/rem/083bd7d : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22793484 [18:23:54] Tpt_: revieeeeew https://github.com/wmde/WikibaseDataModelSerialization/pull/63 :) [18:24:28] Tpt_: I'd like to switch us over to use the new serialization components soon [18:24:49] Tpt_: That is however blocked by a few remaining tickets. Any help with those is much appriciated https://github.com/wmde/WikibaseDataModelSerialization/issues?milestone=2&state=open [18:25:23] [13WikibaseDataModelSerialization] 15Tpt closed pull request #63: Stop using deprecated Property::newEmpty (06master...06remdep) 02http://git.io/HeVFDA [18:25:30] JeroenDeDauw: Hi! Merge done. [18:25:35] [13WikibaseDataModelSerialization] 15Tpt 04deleted 06remdep at 14d5386d8: 02http://git.io/MkTkng [18:27:17] JeroenDeDauw: Do you have any idea on how ws should inject options to serializers? [18:28:07] (03CR) 10Tobias Gritschacher: [C: 04-1] Fix formatting dates in most languages (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124836 (owner: 10Addshore) [18:28:19] Tpt_: first off, we should try to avoid having options [18:28:33] And if we do really need them, then having them in the constructor is good [18:28:51] JeroenDeDauw: So boolean parameters in the constructors? [18:28:53] Tpt_: also, we might want to make use of https://en.wikipedia.org/wiki/Strategy_pattern in places for such things [18:29:09] Tpt_: perhaps in some cases [18:29:27] Though one should consider if using a strategy is not more appropriate [18:30:39] Tpt_: I'm going off now, though will be back later today [18:31:00] JeroenDeDauw: Ok [18:33:24] [travis-ci] wmde/WikibaseDataModel/rem/b04872a : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/22793676 [18:37:08] (03PS12) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [18:43:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [18:48:32] [travis-ci] wmde/WikibaseDataModelSerialization/master/7cfa729 : Thomas PT The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/22794386 [19:29:00] (03CR) 10Tobias Gritschacher: [C: 04-1] Reuse Entity info array whenever possible in Entity formatters (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [19:58:27] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125492 (owner: 10L10n-bot) [20:12:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a028b6e : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22800575 [20:33:05] (03CR) 10Odder: "See https://gerrit.wikimedia.org/r/#/c/124475/ as a follow-up to the patch mention in commit message." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124598 (owner: 10Thiemo Mättig (WMDE)) [21:57:42] (03PS13) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [22:02:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [22:04:39] (03PS1) 10Thiemo Mättig (WMDE): Revert font stack to be just sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 [22:12:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 (owner: 10Thiemo Mättig (WMDE)) [22:28:13] (03CR) 10Bartosz Dziewoński: [C: 032] "So many changes :o" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 (owner: 10Thiemo Mättig (WMDE)) [22:28:30] (03Merged) 10jenkins-bot: Revert font stack to be just sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/125520 (owner: 10Thiemo Mättig (WMDE))