[05:59:43] aude: I can't add years to P585, it will automatically change to January xxxx. [06:00:25] https://www.dropbox.com/s/loze6n9s919hffe/Screenshot%202014-04-09%2008.00.24.png [06:02:50] :/ [06:51:48] i cant add claims to https://www.wikidata.org/wiki/Q16666 - the [edit] and [add] links are not working [06:52:53] ive noticed it happening on a few other items too, but wasnt trying to edit so I ignored it hoping it would voodoo fix itself ;-) [07:04:36] (03CR) 10Tobias Gritschacher: "Just some further suggestions for the name of the setting. What about:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124650 (owner: 10Thiemo Mättig (WMDE)) [07:06:40] jayvdb: there is a JS error there. we will look into it [07:14:40] Thx Lydia_WMDE [07:16:39] btw, a use case for qualifiers. I use a Wikidata clone in a business setting. If one of the claims on the property (and their effect) are not desirable in my setting, it would be nice to be able to add a qualifier in my local environment to effectively disable the undesirable effect [07:16:47] qualifiers on properties [07:21:07] im guessing bots using wikidata clone instances as caches will also benefit from being able to add qualifiers to their clone to assist their bots [07:21:53] but those use cases are not likely to be a high priority for your team ;-) [07:42:09] GerardM: You're flooding the recent changes... [07:43:01] Avoiding such a flood is kind of the entire reason the flood flag/bot flag exists. [07:43:19] ...and you don't seem to be using it [07:47:01] YairRand: I have a bot and I found that it behaves differently from my usual profile [07:47:07] edits were discarded [07:47:16] the point is to make those edits and all of them [07:48:22] GerardM: The edits don't go through? the server rejects them? [07:48:50] that happened [07:48:52] yes [07:48:55] are you using a separate account, and does it have the necessary user rights? [07:49:05] there's a cap for ordinary accounts [07:49:07] I think [07:51:32] * YairRand looks at the user rights list... [07:53:14] GerardM: The autoconfirmed user right makes the user exempt from the base rate limits. if you were trying bot edits from a non-autoconfirmed account, that could be why the edits weren't all being accepted. [07:54:18] RobotGMwikt has been running for ages [07:55:07] has millions of edits [07:55:17] oh [07:55:28] okay, then I don't know why that happened. sorry. [07:56:05] also I now have a project of adding items that will be done by the end of the day [07:56:20] I will blog about it as well [07:56:33] the next point is that automated tools are there for everyone [07:56:54] so makes using automated tools for being a bot ? [07:58:02] such automated tools should really only be used from accounts with flood or bot flags, when making so many edits [07:58:40] I kind of wish we had a special recent changes setup for wikidata to allow large groups of edits to be monitored as groups... [07:59:01] [13WikibaseInternalSerialization] 15tobijat pushed 4 new commits to 06master: 02http://git.io/4Sgi5w [07:59:01] 13WikibaseInternalSerialization/06master 14fad763c 15jeroendedauw: Make use of new setFingerprint method in DataModel [07:59:01] 13WikibaseInternalSerialization/06master 14598226c 15jeroendedauw: Rename terms to fingerprint [07:59:01] 13WikibaseInternalSerialization/06master 14ea19eb6 15jeroendedauw: Optimized imports [07:59:01] (and undone, for that matter.) [08:00:29] but for the moment, we don't, so we must make do. so, could you request a flood flag for your account before continuing the edits? [08:01:01] [13WikibaseQuery] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/nVqxyA [08:01:01] 13WikibaseQuery/06master 14d951df9 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page [08:01:01] [travis-ci] wmde/WikibaseInternalSerialization/master/b89a307 : Tobi Gritschacher The build was broken. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/22589800 [08:01:21] [13WikibaseQuery] 15adrianlang 04force-pushed 06master from 14d951df9 to 14d2d4e5f: 02http://git.io/8VNLwQ [08:01:54] [13WikibaseQuery] 15adrianlang 04force-pushed 06snakview from 146a20a9c to 14d951df9: 02http://git.io/29CD-Q [08:01:54] 13WikibaseQuery/06snakview 14d951df9 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page [08:13:12] Yair, I am not a bot [08:13:14] Adrian_WMDE: /var/www/daniel/wikidata/extensions/Wikibase/vendor/data-values/interfaces/src/ValueValidators/Error.php [08:14:03] I have a bot as well [08:14:20] GerardM: I am aware of that. The flood flag is for non-bots doing quick automated edits from a main accoint. [08:14:50] though, theoretically, it's not much of a stretch to call Widar edits "bot edits", I would think [08:16:15] either way, a very large number of edits in quick succession need to be properly flagged. [08:17:06] otherwise, monitoring things becomes effectively impossible. [08:22:11] "Users may be granted a "flood flag" when doing repetitive, non-controversial edits or actions to avoid flooding Special:RecentChanges and related pages." [08:23:28] You can request the flag at [[Wikidata:Bureaucrats' noticeboard]], and remove the flag from yourself once the edits are done. Doesn't need to be a long process. [08:27:21] i'd disagree with that though, if it's stuff that could be controversial i dunno if it should be bot flagged [08:27:37] but still, you shouldn't run like 10 widar tabs at a time [08:41:07] YairRand it would make more sense for it to be a toggle [08:41:15] something that I can set at will [08:41:55] rschen7754 at this moment I have one session open and that is it [08:44:24] rschen7754 either I have the flood flag or I do not [08:44:32] you cannot have it both ways [08:45:59] is it stuff that could be controversial? [08:46:08] also what is uncontroversial ... that is very much dependend on people's perceptions [08:46:22] and largely I know why I do my edits [08:46:52] I have a consistent view on what brings quality to Wikidata [08:47:14] some people have contrary opinions.. that is fine with me [08:47:27] they do not have the same perspective [08:48:24] they often do not have arguments [08:49:07] this is straying from the topic somewhat, but if other people think your edits are damaging, you probably shouldn't be doing them without consensus, imo. [08:49:49] I have the opinion that what some people opine IS damaging in its own right [08:50:30] I disagree that just because some people have a negative opinion, they get their way [08:52:19] ...and that is why we have discussions, consensus, and admins that are capable of blocking upon achieving such consensus to block. I recommend against having a "If it doesn't make sense to be, I'm not going to listen to it" attitude. [08:52:41] s/to be/to me/ [08:56:56] when I notice that a request for a new property does not get acted upon because one negative voice, I find that there is no real discussion. I find mostly frustration [08:57:35] there is no consistent view on how we gain usability for Wikipedia [08:57:49] it's problematic. there aren't enough voices in those discussions. not much that can be done when only two people participate. [08:58:00] there are people who insist on sources at every stage making it impossible [08:58:33] Yair, I am happy to discuss anything as long as it is clear what the objective is [08:58:37] some people would consider unsourced data to be itself useless and making things impossible [08:58:51] they do not understand the concept of a wiki [08:59:00] wikidata has several objectives, not all of which have to do with wikimedia, btw [08:59:05] they are firmly in the Nupedia state of mind [08:59:26] and some objectives are mutually exclusive [08:59:39] quite. [08:59:50] you can not become usable for use in Wikipedia and insist on sources for everything [09:00:17] from my point of view that is a very restricted point of view [09:00:23] but it is a practical start [09:01:01] given that it is WIKI data, the nupedia mindset cannot prevail [09:01:45] (03CR) 10Thiemo Mättig (WMDE): [C: 032] (bug 62644) No snak val in ClaimModificationHelper (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124317 (owner: 10Daniel Kinzler) [09:02:07] I don't think anyone here has a nupedia mindset exactly. wanting more statements to have sources, or requiring consensus for very large changes, doesn't make it not a wiki, imo [09:02:37] wanting more sources and thereby excluding unsourced statements is [09:02:55] I think this discussion will have to continue another time, sorry. gtg. [09:03:07] have fun and thanks :) [09:04:34] nb there are moments when sources are important [09:05:00] for instance when you compare differences between the values from sources [09:14:52] (03PS17) 10Daniel Kinzler: (bug 62644) move snak validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [09:18:50] (03PS5) 10Daniel Kinzler: (bug 62644) snak validation in ChangeOpMainSnak. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 [09:21:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [09:22:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 (owner: 10Daniel Kinzler) [09:28:56] I take it it is known that editing is not possible from within Wikidata ? [09:29:09] I can edit using Widar [09:40:57] (03CR) 10Tobias Gritschacher: [C: 04-1] (bug 62644) snak validation in ChangeOpMainSnak. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 (owner: 10Daniel Kinzler) [09:45:31] GerardM: did you try purging the page? [09:45:39] what page? [10:00:21] (03PS1) 10WikidataBuilder: New Wikidata Build - 09/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124811 [10:03:55] aude: Did you see my message? [10:04:10] yes [10:04:20] what page did that happen on? [10:04:35] * aude can't reproduce on test.wikidata [10:04:43] GerardM: can you link to an example where this was happening please? [10:04:45] https://www.wikidata.org/wiki/Q15879883 [10:04:49] ok [10:06:03] The date format has also changed, so might have to something with that. [10:06:23] And the keyboardbug has been fixed. :DS [10:06:27] sjoerddebruin: some of the dates code changed [10:06:39] but shouldn't be any noticable difference [10:06:49] Ah. [10:07:00] sjoerddebruin: don't see any issue with that item [10:07:12] sjoerddebruin: does it still happen? [10:07:19] Going to try it again [10:07:26] https://www.dropbox.com/s/loze6n9s919hffe/Screenshot%202014-04-09%2008.00.24.png [10:07:31] what happened for sjoerddebruin [10:07:47] Still happens [10:07:58] what browser? [10:08:19] Safari on OS X. [10:08:24] ok [10:08:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124811 (owner: 10WikidataBuilder) [10:08:41] Going to test in Chrome now [10:08:46] can reproduce js issues on https://www.wikidata.org/wiki/Q60 [10:09:10] (which i edited after wikiquote and before wikidata got switched to new code) [10:09:27] we bumped parser cache for wikiquote, so the issue could be with pages touched between that time [10:09:30] or viewd [10:09:33] viewed* [10:09:43] I get the same in Chrome [10:10:33] aude: could be [10:10:59] i think the number of pages might be small and tehy can be purged [10:11:03] they* [10:11:11] hoping [10:11:37] let's just see how it goes then [10:11:51] if necessary, we can bump again but normally should avoid that [10:11:59] (03PS1) 10Thiemo Mättig (WMDE): Fix "@param null $param" documentations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124816 [10:12:28] (03CR) 10jenkins-bot: [V: 04-1] Fix "@param null $param" documentations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124816 (owner: 10Thiemo Mättig (WMDE)) [10:14:01] (03CR) 10Addshore: [C: 032] New Wikidata Build - 09/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124811 (owner: 10WikidataBuilder) [10:14:02] [13WikibaseQuery] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/hOzvFg [10:14:02] 13WikibaseQuery/06master 14d97e297 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page [10:14:37] [13WikibaseQuery] 15adrianlang 04force-pushed 06master from 14d97e297 to 14d2d4e5f: 02http://git.io/8VNLwQ [10:14:47] [13WikibaseQuery] 15adrianlang 04force-pushed 06snakview from 14d951df9 to 14d97e297: 02http://git.io/29CD-Q [10:14:47] 13WikibaseQuery/06snakview 14d97e297 15Adrian Lang: Use Wikibase's snakview for the SimpleQuery special page [10:14:55] sjoerddebruin: i can reproduce if i change my language to nl [10:15:03] Tobi_WMDE: ^ [10:15:09] Hm, I still have the bug in English so that's weird [10:15:16] hmmm [10:15:17] (03CR) 10Addshore: [C: 04-1] "Guessing the lib/includes/store/EntityLabelLookup.php files isnt meant to be here...?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124816 (owner: 10Thiemo Mättig (WMDE)) [10:15:41] [travis-ci] wmde/WikibaseQuery/master/d97e297 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22597668 [10:16:16] german shows ". 1935" [10:16:35] This is again something that leads to adding incorrect stuff. [10:16:55] addshore: ^ [10:16:58] ?? [10:17:04] problems with dates [10:17:07] what am I looking at? I think I came in half way through [10:17:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124816 (owner: 10Thiemo Mättig (WMDE)) [10:17:15] https://www.wikidata.org/wiki/Q15879883 [10:17:30] especially if i edit in de or nl (but also happens in en) [10:17:38] i enter 1935 and for german i get ". 1935" [10:17:47] in nl, i enter 1935 and get jan 1935" [10:18:13] addshore: seems that entering only a year in nl language will be parsed as january [10:18:21] Tobi_WMDE: really? O_o [10:18:28] but precision says "year" though [10:18:38] will play around in the sandbox [10:20:18] Tobi_WMDE: which language is that occouring in? [10:20:25] nl [10:20:29] german and nl [10:20:33] dutch [10:20:36] german? really? [10:20:40] different behaviors, neither i expect [10:20:48] tobi: "1935" becomes ". 1935" [10:20:53] hmmm [10:21:02] hehe [10:21:04] yes [10:21:05] true [10:21:06] its parsed at the year but then displayed with the month Jan [10:21:09] yikes!!! [10:21:14] *as [10:21:24] if you enter the year 999999 in EN it is displayed as 999999 [10:21:27] https://www.wikidata.org/wiki/Q76?uselang=ar [10:21:33] then view it in nl and its displayed as Jan 999999 [10:21:43] addshore: yes [10:21:43] shows timestamps! [10:21:45] [13Interfaces] 15adrianlang created 06augmentParseException (+1 new commit): 02http://git.io/3w69qA [10:21:45] 13Interfaces/06augmentParseException 1415fd8b3 15Adrian Lang: Add rawValue and expectedFormat arguments to ValueParsers\ParseException... [10:21:53] bad [10:21:57] precision [10:22:15] +00000002005-01-03T00:00:00Z [10:22:34] aude: the only reason if should show a timestamp is if it fails to format the value in any other way [10:22:37] its the final fallback [10:22:42] [13Interfaces] 15adrianlang opened pull request #4: Add rawValue and expectedFormat arguments to ValueParsers\ParseException (06master...06augmentParseException) 02http://git.io/44E0ug [10:22:42] ugh [10:22:47] en dates should be final fallback [10:23:05] aude: en dates already come before the fallback [10:23:12] so it should be formatted before doing the timestamp [10:23:19] super yikes [10:23:20] generally the only time I saw the timestamp when testing is with an invalid date [10:23:33] hence nothing can format it [10:23:46] obama has invalid dates? [10:23:52] * aude doubts [10:24:12] indeed I doubt [10:24:22] and if it formats with the lang en but not with another lang then something is wrong [10:24:27] * sjoerddebruin is just a user and finds the largest bugs. [10:24:40] in german, i see "Endzeitpunkt .1979" [10:24:47] err ". 1979" [10:25:07] Endzeitpunkt [10:25:15] sjoerddebruin: definitely helpful [10:25:32] * aude wasn't expecting the new code to be deployed last night (since wmf was working on localisation cache bugs) [10:25:39] aude: all of the translate keys should still be marked as DO NOT TRANSLATE [10:26:02] only month names should currently be localised, unless someone has changed that without me noticing :O [10:27:48] Guys: keep me up, if you make a bug send me the link pl0x. :) [10:28:05] ok [10:28:06] WikibaseValueFormatterBuilders::newHtmlTimeFormatter O_o [10:28:22] That's me [10:28:25] right? [10:28:28] Calendar model hint [10:28:53] (03PS1) 10Addshore: Remove unused WikibaseValueFormatterBuilders::newHtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124819 [10:29:16] you must be getting it from somewhere else [10:29:26] https://www.wikidata.org/wiki/Q60?uselang=ar also has timestamps [10:29:30] timestamps everywhere [10:29:57] addshore: line 85 [10:30:26] oh, dam text usages! [10:30:35] right well that could be the problem [10:30:48] these two methods to get the html formatters are only using one of the parsers [10:31:00] they should be using the TimeParser (dispatching) [10:31:06] hmmm [10:31:09] 8formatter [10:31:32] addshore: That's exactly why I said that this kind of stuff does not need unit tests, but API endpoint tests [10:31:49] both [10:31:52] Or tests by me. :P [10:32:05] aude: "need" as in "desperately need" [10:32:11] normally we would have had time to test on test.wikidata [10:32:25] Adrian_WMDE: yeah [10:32:25] wait, no as this is only formatting [10:32:27] not parsing [10:32:45] (03CR) 10Addshore: [C: 04-1] Remove unused WikibaseValueFormatterBuilders::newHtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124819 (owner: 10Addshore) [10:33:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124819 (owner: 10Addshore) [10:33:22] mhhm, I need a coffee , will brb [10:33:27] i can reproduce ". 1935" and ar timestamps on my wiki [10:35:54] (03PS2) 10Thiemo Mättig (WMDE): Fix "@param null $param" documentations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124816 [10:38:40] right, the call to wbformatvalue returns the correct year, i.e. 3332... [10:38:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] (bug 62644) snak validation in more change ops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123872 (owner: 10Daniel Kinzler) [10:40:24] i can reproduce "1935" => "jan 1935" [10:40:34] Hoi I can edit again [10:40:50] aude indeed, but if you click edit while in NL and watch the calls to the API through the console wbformatvalue will return only 1935 [10:40:53] which is correct [10:40:58] oh [10:41:13] the php formatted snak values come from SnakHtmlGenerator right? [10:41:31] i dont' think that's in the branch, but yes [10:41:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124816 (owner: 10Thiemo Mättig (WMDE)) [10:41:44] hah :P [10:41:45] claimhtmlgenerator otherwise [10:42:01] shoudl be same code, only moved to snak generator [10:44:44] * addshore wonders where the entitiy / itemview is actually constructed [10:46:06] https://test.wikidata.org/w/api.php?action=wbformatvalue&format=json&datavalue=%7B%22value%22%3A%7B%22time%22%3A%22%2B00000001944-01-01T00%3A00%3A00Z%22%2C%22timezone%22%3A0%2C%22before%22%3A0%2C%22after%22%3A0%2C%22precision%22%3A9%2C%22calendarmodel%22%3A%22http%3A%2F%2Fwww%2Ewikidata%2Eorg%2Fentity%2FQ1985727%22%7D%2C%22type%22%3A%22time%22%7D&options=%7B%7D&datatype=time&generate=text%2Fplain [10:46:12] sorry for the long link :p [10:46:26] that's what is requested, with 1944-01-01 [10:46:58] const PRECISION_YEAR = 9; [10:47:06] aude: thats fine, as there is on 1944-00-00 [10:47:18] precision 9 means it will be formatted with only the year taken into account [10:47:38] ok [10:47:57] Im digging through and got to OutputFormatSnakFormatterFactory::getSnakFormatter [10:48:06] this is where the snak formatters come from for itemview [10:48:20] (03CR) 10Thiemo Mättig (WMDE): [C: 032] (bug 62644) snak validation in ChangeOpMainSnak. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 (owner: 10Daniel Kinzler) [10:48:21] ok [10:48:32] with SnakFormatter::FORMAT_HTML_WIDGET which is 'text/html; disposition=widget' [10:50:00] the builders come from WikibaseSnakFormatterBuilders::getSnakFormatterBuildersForFormats [10:50:28] and then buildDispatchingSnakFormatter, oh so many layers [10:50:32] :o [10:51:31] WikibaseValueFormatterBuilders::buildDispatchingValueFormatter [10:52:39] where do the options come from? [10:52:53] god knows :P [10:53:25] , so at the top of WikibaseValueFormatterBuilders both a html and plain formatter are registered [10:54:10] Wikibase\Lib\WikibaseValueFormatterBuilders->newFromSpec [10:55:07] (03PS7) 10Thiemo Mättig (WMDE): (bug 62644) Snak validation in more ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123872 (owner: 10Daniel Kinzler) [10:55:59] mhhhm, im getting lost in code I hanvt looked at much :p [10:56:09] wo ist daniel? :) [10:56:22] :D [10:58:05] So, its not the Api, it is im some part of the code that generates the initial html ItemView ;p [10:58:25] well also happens in formatvalue api module [10:58:32] really? O_o [10:58:36] I cant reproduce that [10:58:38] see the link [10:58:55] aude: {"result":"1944"} [10:59:02] result: "jan 1944" [10:59:03] } [10:59:11] thats what it should be.... [10:59:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123872 (owner: 10Daniel Kinzler) [11:00:26] we can't just enter "1944"? [11:00:36] im confused [11:00:42] why do you get result jan 1944? [11:00:47] I dont.... [11:00:52] looking at the api calls [11:01:11] what call gives result: "jan 1944" } : [11:01:12] ? [11:01:14] https://test.wikidata.org/wiki/Q22?setlang=nl [11:01:29] i assume de give ". 1944" [11:01:35] what the actual .... [11:01:55] probably ar give timestamp [11:02:05] $timestamp = wfTimestamp( TS_MW, $fourDigitYearTimestamp ); [11:02:05] $localisedDate = $this->language->sprintfDate( [11:02:05] $this->getDateFormat( $precision ), [11:02:05] $timestamp [11:02:05] ); [11:02:08] got to be here then [11:02:22] https://test.wikidata.org/w/api.php?action=wbformatvalue&format=json&datavalue=%7B%22value%22%3A%7B%22time%22%3A%22%2B00000001941-01-01T00%3A00%3A00Z%22%2C%22timezone%22%3A0%2C%22before%22%3A0%2C%22after%22%3A0%2C%22precision%22%3A9%2C%22calendarmodel%22%3A%22http%3A%2F%2Fwww%2Ewikidata%2Eorg%2Fentity%2FQ1985727%22%7D%2C%22type%22%3A%22time%22%7D&options=%7B%7D&datatype=time&generate=text%2Fplain [11:02:32] .https://test.wikidata.org/w/api.php?action=wbformatvalue&format=json&datavalue=%7B%22value%22%3A%7B%22time%22%3A%22%2B00000001941-01-01T00%3A00%3A00Z%22%2C%22timezone%22%3A0%2C%22before%22%3A0%2C%22after%22%3A0%2C%22precision%22%3A9%2C%22calendarmodel%22%3A%22http%3A%2F%2Fwww%2Ewikidata%2Eorg%2Fentity%2FQ1985727%22%7D%2C%22type%22%3A%22time%22%7D&options=%7B%7D&datatype=time&generate=text%2Fplain [11:02:38] gah [11:02:39] result: ". 1941" [11:03:48] https://test.wikidata.org/w/api.php?action=wbformatvalue&format=json&datavalue=%7B%22value%22%3A%7B%22time%22%3A%22%2B00000001941-01-01T00%3A00%3A00Z%22%2C%22timezone%22%3A0%2C%22before%22%3A0%2C%22after%22%3A0%2C%22precision%22%3A9%2C%22calendarmodel%22%3A%22http%3A%2F%2Fwww%2Ewikidata%2Eorg%2Fentity%2FQ1985727%22%7D%2C%22type%22%3A%22time%22%7D&options=%7B%7D&datatype=time&generate=text%2Fplain (in arabic) [11:03:55] result: "+00000001941-01-01T00:00:00Z" [11:04:05] * addshore keeps digging [11:04:34] i assume formatting is done same way, same options in entity view / claim view [11:05:05] mhhhm, got to fix my ULS first.. [11:05:23] ok [11:05:35] * aude looks at formatvalue [11:06:37] $this->getDateFormat( $precision ) [11:06:54] when passed with a precision of 9 we get back string 'M Y' (length=3) [11:06:56] which be wrong [11:07:15] getting lunch [11:07:22] can look when get back [11:07:23] kk :) [11:16:12] (03PS1) 10Addshore: Correctly format dates for lang=nl [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124823 [11:16:39] sjoerddebruin: looks like I have found where the problem lies [11:16:59] did you open a bug? [11:17:26] No. [11:17:31] okay :) [11:17:33] the problems lies? [11:17:40] :P [11:17:55] well, a month ago we only ever formatted dates in englaish [11:17:57] *english [11:18:27] and when the new formatters and stuff were brought in there is actually 1 bit of the old code that remains, and amusingly thats where the problem is :D [11:19:23] guess I will go through and write tests for ALL of the languages now :D [11:19:31] :O [11:21:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124823 (owner: 10Addshore) [11:26:18] addshore: Are you creating a bug now? [11:28:22] sjoerddebruin: I will do :) [11:31:14] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124811 (owner: 10WikidataBuilder) [11:33:02] (03CR) 10Addshore: "browser tests passed right??" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/124811 (owner: 10WikidataBuilder) [11:39:04] sjoerddebruin: aude https://bugzilla.wikimedia.org/show_bug.cgi?id=63723 [11:39:33] (03PS2) 10Addshore: Correctly format dates for lang=nl [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124823 [11:39:37] Thanks. :) [11:41:12] (03PS1) 10Addshore: Add basic tests for formatting dates in different langs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 [11:43:19] Is critical the highest importance? [11:44:25] yup [11:44:42] just establishing a list of languages its currently broken for [11:46:56] Okay. [11:46:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124823 (owner: 10Addshore) [11:47:02] * sjoerddebruin removes this from his bucket list [11:47:12] :) [11:50:33] "Report a critical bug" ;) [11:50:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 (owner: 10Addshore) [11:53:11] haha :P [11:53:25] looks like im going to have a busy day :D [11:55:16] [13Common] 15adrianlang created 06augmentParseException from 06master (+0 new commits): 02http://git.io/5VI0Uw [11:56:25] sjoerddebruin: 164 languagesaffected [11:56:30] Auch [11:56:34] [13Common] 15adrianlang pushed 1 new commit to 06augmentParseException: 02http://git.io/gceZGQ [11:56:34] 13Common/06augmentParseException 146e7e061 15Adrian Lang: Pass rawValue and expectedFormat arguments to ParseExceptions [11:56:57] out of 397 [11:56:59] [13Common] 15adrianlang opened pull request #8: Pass rawValue and expectedFormat arguments to ParseExceptions (06master...06augmentParseException) 02http://git.io/YJE_7g [11:57:16] :O [11:58:42] (03PS20) 10Daniel Kinzler: (bug 40157) store entity status in page_props [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [11:59:57] addshore: how's it going? [12:00:12] aude: found where the problem is, there is a patch up for NL [12:00:22] one patch for each lang? [12:00:25] just writing tests for everything then I can go through fixing them all [12:00:28] (03CR) 10Daniel Kinzler: [C: 04-1] "If the parameter defaults to null, it should be declared as foo|null, not just as foo." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124816 (owner: 10Thiemo Mättig (WMDE)) [12:00:39] ok [12:00:49] (03CR) 10Addshore: [C: 04-1] "done merge me, followup coming" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 (owner: 10Addshore) [12:00:57] (03CR) 10Addshore: "dont..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124824 (owner: 10Addshore) [12:01:06] DONE MERGE ME° [12:02:55] :D [12:03:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [12:04:09] :D [12:04:24] addshore: i can merge that one? [12:04:32] looks good and works good [12:04:48] which? :P [12:04:50] NL or tests? [12:04:54] although we might not deploy just yet since we needm ore fixes [12:04:56] nl [12:05:01] yee, nl is fine [12:05:04] ok [12:05:07] Can i test addshore? [12:05:17] sjoerddebruin: not easily [12:05:20] :P [12:05:23] unless you have wikibase installed [12:05:26] Okay, I trust you. :D [12:05:38] we could deploy on beta wikidata [12:05:50] (03CR) 10Aude: [C: 032] Correctly format dates for lang=nl [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124823 (owner: 10Addshore) [12:06:14] (03Merged) 10jenkins-bot: Correctly format dates for lang=nl [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124823 (owner: 10Addshore) [12:08:58] [13Number] 15adrianlang created 06augmentParseException (+1 new commit): 02http://git.io/qAAavQ [12:08:58] 13Number/06augmentParseException 14175b374 15Adrian Lang: Pass rawValue and expectedFormat arguments to ParseExceptions... [12:09:37] [13Number] 15adrianlang opened pull request #5: Pass rawValue and expectedFormat arguments to ParseExceptions (06master...06augmentParseException) 02http://git.io/7ddvZw [12:09:52] (03CR) 10Daniel Kinzler: (bug 62644) snak validation in ChangeOpMainSnak. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 (owner: 10Daniel Kinzler) [12:10:37] [13Common] 15adrianlang 04force-pushed 06augmentParseException from 146e7e061 to 14f0f6ca3: 02http://git.io/5VI0Uw [12:10:37] 13Common/06augmentParseException 14f0f6ca3 15Adrian Lang: Pass rawValue and expectedFormat arguments to ParseExceptions... [12:12:52] (03CR) 10Daniel Kinzler: [C: 04-1] "ClaimTestHelper was renamed. This needs a manual rebase. Waiting for the base patch to be merged before i do that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 (owner: 10Daniel Kinzler) [12:18:15] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Oh noes. I almost hit +2 but found a new issue. :-(" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [12:21:08] addshore: so no test coverage of public function format( $value ) in MwTimeIsoFormatter? am i blind or right about that? [12:21:26]