[01:10:23] (03Abandoned) 10Addshore: New Wikidata Build - 03/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123568 (owner: 10WikidataBuilder) [02:17:21] (03PS1) 10Aude: Use SimpleSiteLink (for now) in UpdateRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 [02:17:25] (03PS1) 10Aude: Remove usage of Wikibase\SiteLink in SiteLinkSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123827 [02:17:27] (03PS1) 10Aude: Remove usage of Wikibase\SiteLink in MockRepository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123828 [02:17:29] (03PS1) 10Aude: Remove obsolete Wikibase\SiteLink class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 [02:17:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [02:18:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123827 (owner: 10Aude) [02:20:37] looks like gerrit died! [02:21:03] nooooooooooooooo [02:23:24] Seems to load, but very slowly. [02:24:31] it's been having issues. [02:25:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123828 (owner: 10Aude) [02:26:00] http://lists.wikimedia.org/pipermail/labs-l/2014-April/002302.html or maybe another issue this time [02:32:46] (03PS2) 10Aude: Remove usage of Wikibase\SiteLink in SiteLinkSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123827 [02:32:48] (03PS2) 10Aude: Use SimpleSiteLink (for now) in UpdateRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 [02:32:50] (03PS2) 10Aude: Remove obsolete Wikibase\SiteLink class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 [02:32:52] (03PS2) 10Aude: Remove usage of Wikibase\SiteLink in MockRepository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123828 [02:34:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [02:39:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123827 (owner: 10Aude) [02:46:14] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [02:50:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [02:53:24] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123828 (owner: 10Aude) [07:10:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123828 (owner: 10Aude) [07:23:02] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [08:15:07] (03CR) 10Siebrand: [C: 04-1] "I think there may be an issue with text going through unescaped. See inline." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123587 (owner: 10Henning Snater) [08:19:09] (03CR) 10Tobias Gritschacher: [C: 032] Set font of the wb-firstHeading toolbar back to sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 (owner: 10Thiemo Mättig (WMDE)) [08:19:36] (03Merged) 10jenkins-bot: Set font of the wb-firstHeading toolbar back to sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 (owner: 10Thiemo Mättig (WMDE)) [08:24:08] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [08:30:58] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [08:41:09] jenkins / gerrit seems like pile of fail :/ [08:43:49] aude: since a few minutes our jenkins is not reachable anymore.. [08:44:13] accessing the instance is possible but accessing jenkins is not [08:44:15] :( [08:44:27] since last puppet run [08:44:32] which was at 10:34 [08:44:33] and i had all sorts of problems with gerrit [08:44:46] so jenkins not able to get wikibase etc [08:44:49] dont know what it did [08:44:58] aude: not sure [08:45:08] well, https://gerrit.wikimedia.org/r/#/c/123828/ [08:45:34] if it was able to get wikibase and do tests, they passed [08:45:51] can look when i come to office [08:46:11] aude: this was long before [08:46:28] as I said since 12 minutes it's dead [08:46:38] since the last automatic puppet run [08:46:48] yeah [08:46:57] gerrit's been broken [08:47:13] aude: wmf is broken [08:47:17] seems each time i submitted 4 patch chain, then gerrit died for a few minutes [08:47:39] and then jenkins couldn't get wikibase sometimes [08:48:22] aude: sometimes it was just not able to get master because git.wikimedia.org was dead [08:48:22] anyway, off foro ~20 min [08:48:25] is dead [08:48:27] for* [08:48:37] that too, that was dead also [09:12:07] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [09:17:39] (03PS2) 10Henning Snater: Altered property page layout [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123587 [09:21:50] (03PS8) 10Addshore: Stop calling newFromNumber using an object in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [09:22:45] it's an addshore!! \o/ [09:22:49] :> [09:26:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123587 (owner: 10Henning Snater) [09:28:53] (03PS3) 10Addshore: Added sitefilter param to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:29:44] (03CR) 10Addshore: "PS3 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:30:36] (03CR) 10Addshore: [C: 032] Added sitefilter param to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:30:48] balls, need to wait for the friggin tests [09:30:49] bah! [09:30:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [09:35:20] jenkins is alive! [09:35:32] was it meant to be dead ?:P [09:35:42] it was dead 1/2 hour ago [09:35:46] :O [09:36:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [09:37:03] (03PS9) 10Addshore: Stop calling newFromNumber using an EntityId in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [09:37:11] http://wdjenkins.wmflabs.org/ci/job/wikibase-repo-tests/505/console is something wrong with git.wikimedia or something [09:37:50] {{worksforme}} [09:39:24] Tobi_WMDE: can https://bugzilla.wikimedia.org/show_bug.cgi?id=63407 be added to the sprint [09:39:27] addshore: want to join the daily? [09:39:35] you would be 25% today.. [09:39:35] (3 points? since especially annoying to debug this) [09:39:36] oh god, thats in 5 mins [09:39:42] yes I will try again :P [09:40:14] aude: yea, we should tackle that [09:40:35] but 3 points? didn't you invest a lot of time already? [09:40:37] that's what my patch does, but then we probably want to eliminate usage of SimpleSiteLink [09:40:44] yeah, 3 points for my time [09:40:54] aude: oh, so it's fixed? [09:41:06] i think so [09:41:08] I see [09:41:29] okay... if I click attending I still cant join.... [09:41:29] not ideal fix. ideal fix is no more SimpleSiteLink uses in wikibase, including UpdateRepo [09:41:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:41:45] but changing it there was breakign things sometimes [09:41:54] (03CR) 10Addshore: [C: 04-1] "just get rid of use Wikibase\DataModel\SiteLink; ?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [09:42:27] aude: once this is done, we should change our jobs to run wikibase group on client instead of just wikibaseclient [09:42:28] addshore: is Wikibase\SiteLink an alias for Wikibase\DataModel\SiteLInk? [09:42:34] yes [09:42:39] gah, even worse [09:42:45] I think, otherwise it woudlnt be complaining right? [09:42:48] then we have two Wikibase\SiteLink [09:42:53] O_o [09:42:59] one in data model, one in wikibase! [09:43:22] ahhhhhhh [09:43:24] let me see [09:43:31] i'd rather that one be SimpleSiteLink (consistent with what site link lookup asks for) and then [09:44:02] go through and fix wikibase in follow up to change references to SimpleSiteLink [09:44:21] Tobi_WMDE: no idea whats messed up with hangouts :/ [09:44:32] addshore: click "yes i'm going" [09:44:40] I did,a nd it still wont let me in [09:44:47] :( [09:44:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [09:44:53] I even invited my personal account and it wouldnt let me in [09:45:05] addshore: the calendar sais you did not accept the invitation yet [09:45:16] addshore class_alias( 'Wikibase\DataModel\SiteLink', 'Wikibase\DataModel\SimpleSiteLink' ); [09:45:21] aude: /Wikibase/SiteLink isnt an aliase in data model :) [09:45:34] i don't think we have two [09:46:15] addshore: reinvited you [09:46:17] (03CR) 10Addshore: "use Wikibase\DataModel\SiteLink as DataModelSiteLink ?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [09:46:49] Tobi_WMDE: looks like its worked straight after youve done that :) [09:53:04] (03PS4) 10Addshore: Added sitefilter param to wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:53:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:53:53] (03PS5) 10Addshore: Added sitefilter param to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:58:27] addshore: :) [09:58:32] :O [09:58:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:59:10] just wanted to ask about next week and your availability there.. [09:59:17] (03CR) 10Addshore: [C: 032] Added sitefilter param to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [10:00:03] should be available all week [10:00:22] (03PS1) 10WikidataBuilder: New Wikidata Build - 04/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123840 [10:01:24] addshore: great! :-D [10:03:15] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 04/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123840 (owner: 10WikidataBuilder) [10:04:24] (03CR) 10Tobias Gritschacher: [C: 04-1] "This seems to have a "real" jenkins failure.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [10:04:57] oh noes [10:07:31] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [10:08:04] probably need to add use statements to the classes that were previously using wikibase\wistelink [10:08:25] yeah yeah [10:10:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123840 (owner: 10WikidataBuilder) [10:11:44] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 04/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123840 (owner: 10WikidataBuilder) [10:15:25] addshore: if you're going to work on something let me know so I can update the board.. [10:15:39] Tobi_WMDE: doing the TimeHandler now [10:15:50] addshore: ok. [10:16:23] DanielK_WMDE_: sure https://www.mediawiki.org/wiki/Extension:Wikibase_QueryEngine/SQL_schema_proposal#wbq_.3Crole.3E_time is good enough? [10:16:30] we dont need precision or anything at this stage? [10:18:28] wait, of course we dont,we have min max [10:32:27] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "I'm very sorry but I don't think this is how this should be done. That was also one of the reasons why I asked you to split the patch. Tha" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 (owner: 10Bene) [10:34:26] addshore: exactly [10:34:46] heh, next question is now to get from our time value to epoche value nicely ;p [10:35:16] addshore: the schena still only handles min/max, not the actual value. this means we can't sort properly (didn't think of that when designing the schema). we might want to change that in the future. [10:35:36] otoh, we are aiming for smallish resutl sets anyway ~1000 items, so we can just sort in memory. [10:37:02] well the schema has a value_epoche in it [10:37:07] so we can sort on that ;p [10:37:56] ah, right, it's globe that is missing the actual value [10:39:49] addshore: i guess DateTime will work for 4 digit years. for larger years, i'd probably use DateTime on with year 0001, and then multiply the remainign years by 31556926 (seconds per year), and add that [10:40:21] this should probably be in TImeValue rather than QueryEngine? [10:40:42] this is going to be off a little in some cases, but should be good enough - I don't think we need second or even day precision for dates beyond the year 9999 [10:41:45] addshore: hm, tough. generally, calculating the index value should be left to QE, because it knows which corners to cut [10:42:11] but if it makes sense, the DV object can already support some basic conversion, and the QE can use that- [10:42:38] in this case... oh, i dunno. whatever :P [10:42:45] xD [10:46:15] addshore: huh, apparently, the number of seconds in a year is roughly pi*10^7... [10:50:33] addshore: playing a bit with strtotime and DateTime, it seems like PHP actually thinks there is a year zero. So it's off by a year for any BC date. [10:50:35] awesome. [10:50:47] :D [10:55:47] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I don't think the icons belong in any PHP settings file, see change I818dbb3433b6618c4e1967018765d44f02e9970c. At the moment the values of" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [11:01:59] Thiemo_WMDE: I'd still simply use the Q-numbers as (suffixes of) CSS class names [11:02:13] why not? they are not human readable, but easy enough to look up, and universal [11:02:36] if you want to css to be readable, jsut add a comment [11:03:00] ...? not sure if you understood what I wrote. [11:03:21] yes, should result in class="badge-Q123" by default. [11:03:37] but result in class="badge-Q123 FA" if the setting is present. [11:03:52] ah, those are to be used as *additional* classes [11:03:58] i see. that makes sense, yes [11:04:04] i though you wanted to use them instead [11:04:13] hi liangent [11:05:15] oh gah [11:05:38] did i accidently push a branch to gerrit instead of github? [11:05:57] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Support getting single sitelinks with ClientSiteLinkLookup (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [11:06:46] i feel so sorry for bene. i even gave him a -2. my first one ever. :-( [11:09:44] (03PS9) 10Daniel Kinzler: (bug 62644) move snak validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [11:10:02] addshore: can you have a look at https://travis-ci.org/wmde/WikibaseQuery/jobs/22200935 ? [11:10:26] JeroenDeDauw: will do in a mo! [11:10:55] mo = month? [11:11:01] yup ;p [11:14:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [11:22:59] addshore: in https://github.com/filbertkm/mediawiki-extensions-Wikibase/blob/master/.travis.yml why does LANG=de have a colon after and DBTYPE and MW do not? [11:23:56] aude: the colon isnt needed as far as I know [11:24:01] ok [11:26:36] [travis-ci] wmde/WikibaseQueryEngine/timeHandler/8d31a68 : addshore The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/22260631 [11:27:19] (03CR) 10Jeroen De Dauw: [C: 032] Stop calling newFromNumber using an EntityId in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [11:27:27] :D [11:29:35] (03CR) 10Jeroen De Dauw: "Using the local alias approach seems to be the way to go till we got rid of the one in the same NS of the class and can switch to the real" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [11:30:20] (03CR) 10Jeroen De Dauw: "Though in the end it does not really matter much. You can simply come back after the old SiteLink class ws killed and update the name here" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123826 (owner: 10Aude) [11:31:55] (03CR) 10Jeroen De Dauw: "Missed the usage that has caused the old clss to remain so far: EntityView. The functionality that is in the old SiteLink needs to be move" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [11:32:46] (03PS10) 10Daniel Kinzler: (bug 62644) move snak validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [11:32:56] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123840 (owner: 10WikidataBuilder) [11:37:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Thanks for checking, Henning." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123587 (owner: 10Henning Snater) [11:38:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [11:38:57] (03Abandoned) 10Daniel Kinzler: Don't use the API when setting up test entities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123697 (owner: 10Daniel Kinzler) [11:41:29] addshore: can you link your time DVhandle patch to the bug please? [11:44:42] Tobi_WMDE: done [11:44:47] thx [11:45:05] (03PS6) 10Daniel Kinzler: Make ClaimGuidGenerator behave like a service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 [11:47:15] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/2yocnw [11:47:15] 13jenkins-job-builder-config/06master 148d89e97 15Tobias Gritschacher: Also run Wikibase-group phpunit tests on client for the build [11:48:13] w00t [11:48:20] =o [11:48:26] addshore: do you know how I can access wbjenkins on localhost on the instance? [11:48:36] wbjenkins? :P [11:48:41] (03PS8) 10Daniel Kinzler: Introduce ChangeOpFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 [11:48:41] jenkins [11:48:51] i dont undertsand what you mean :P [11:48:51] i am somehow failing at travis [11:48:53] https://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/builds/22260493 [11:49:00] I want to access jenkins from withing wdjenkins [11:49:17] it's only building 1 of the 3 things i put in config, but if we can make it work, [11:49:26] then travis can run client or repo or both [11:49:33] addshore: I tried http://127.0.0.1/ci [11:49:35] Tobi_WMDE: as in jenkins webpages? [11:49:38] ahhh [11:49:55] does localhost not just work? or the actuall domain? [11:50:26] probably the domain [11:50:33] since we have proxy stuff [11:50:38] addshore: the domain does not work (timeout) guess it just can't access [11:50:55] oh, within jenkins [11:50:55] localhost:8080/ci should work [11:51:04] addshore: and localhost does not give me access to jenkins.. [11:51:06] the domain directs to port 8080 ;p nothing is on port 80 [11:51:54] all the stuff that makes https://integration.wikimedia.org/ is in one of the puppet repos but is separate from jenkins [11:52:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 (owner: 10Daniel Kinzler) [11:52:23] addshore: hmmm.. I'll try [11:52:25] if we want stuff on port 80, then we have to do likewise [11:52:41] and it's in addition to jenkins [11:53:26] (03CR) 10Addshore: [C: 04-1] Make ClaimGuidGenerator behave like a service (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 (owner: 10Daniel Kinzler) [11:53:55] wikidata admins and users do it again [11:53:57] * sDrewth sighs [11:54:02] :/ [11:54:39] addshore: ha! [11:54:43] worked? [11:54:44] http://localhost:8080/ci/? seems to work [11:54:49] :> [11:55:18] addshore: now we can make jaenkins auto-update its own jobs [11:55:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 (owner: 10Daniel Kinzler) [11:55:58] addshore: aude: http://wdjenkins.wmflabs.org/ci/job/jenkins-job-builder/18/console [11:56:17] :> [11:56:24] (03PS9) 10Daniel Kinzler: Introduce ChangeOpFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 [11:56:32] yay! [11:56:58] we could trigger the job whenever something is merged into the job-builder-config repo on github [12:00:03] (03PS1) 10Tobias Gritschacher: Get rid of term "handle" in the context of properties in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 [12:03:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 (owner: 10Daniel Kinzler) [12:05:37] (03PS11) 10Daniel Kinzler: bug 62644) move snak validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [12:09:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 (owner: 10Tobias Gritschacher) [12:12:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [12:23:49] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/Xe1M0g [12:23:49] 13jenkins-job-builder-config/06master 14ad12c15 15Tobias Gritschacher: Testing the webhook [12:25:55] JeroenDeDauw: I get different issues while trying to run update.php with WikibaseQuery [12:26:10] sqlite [12:26:14] A database query error has occurred. [12:26:14] Query: ALTER TABLE "wbq_valueless_snaks" ADD COLUMN "row_id" INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT [12:26:14] Function: Wikibase\Database\MediaWiki\MediaWikiSchemaModifier::addField [12:26:14] Error: 1 Cannot add a PRIMARY KEY column [12:26:29] also cant run update.php with mysql [12:28:22] ahh, my DB is just totally messed up :D [12:30:47] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/bV609g [12:30:47] 13jenkins-job-builder-config/06master 1497d0728 15Tobias Gritschacher: testing webhook [12:34:10] JeroenDeDauw: cant reproduce https://travis-ci.org/wmde/WikibaseQuery/jobs/22200935 :/ [12:41:32] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/QGEVPw [12:41:32] 13jenkins-job-builder-config/06master 1415667fa 15Tobias Gritschacher: Still testing webhooks [12:42:37] (03PS3) 10Aude: Remove obsolete Wikibase\SiteLink class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 [12:42:39] (03PS1) 10Aude: Remove usage of Wikibase\SiteLink in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123854 [12:42:45] let's see if this kills gerrit [12:42:53] oh, only 2 patches [12:44:28] [13WikibaseDatabase] 15addshore created 06catchNoMatch (+1 new commit): 02http://git.io/b7DKcw [12:44:29] 13WikibaseDatabase/06catchNoMatch 14a0a50a7 15addshore: Throw exception if getIndex regex fails to match [12:44:37] JeroenDeDauw: ^^ this should help [12:44:42] [13WikibaseDatabase] 15addshore opened pull request #35: Throw exception if getIndex regex fails to match (06master...06catchNoMatch) 02http://git.io/W9bHQQ [12:47:02] [travis-ci] wmde/WikibaseDatabase/catchNoMatch/a0a50a7 : addshore The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/22265317 [12:49:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [12:49:42] :O [12:49:44] [13Common] 15filbertkm pushed 1 new commit to 06mismatch: 02http://git.io/RrJGTg [12:49:44] 13Common/06mismatch 14315bf6e 15aude: Rename exception to MismatchingDataValueTypeException [12:49:48] waht [12:52:26] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/-S-VEw [12:52:26] 13jenkins-job-builder-config/06master 140a021ae 15Tobi Gritschacher: Update wikibase.yaml [12:53:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123854 (owner: 10Aude) [12:54:01] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/wRalnQ [12:54:01] 13jenkins-job-builder-config/06master 1426b63e5 15Tobias Gritschacher: Update README [13:08:02] [13WikibaseDatabase] 15thiemowmde comment on pull request #35 14a0a50a7: '/CREATE\s+((?:UNIQUE\s+)?INDEX)\s+(\S+)\s+ON\s+(\S+)\s+\((.+)\)\z/i' 02http://git.io/J9tqjw [13:09:12] [13WikibaseDatabase] 15addshore comment on pull request #35 14a0a50a7: This should be done in a separate change 02http://git.io/QnmiZg [13:16:22] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Adding pageobjects and step definitions for common special page browsertests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123663 (owner: 10Tobias Gritschacher) [13:17:12] (03PS1) 10Addshore: Markdown Readme and Release files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123859 [13:18:28] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Browsertests: move creation of new entities to entity_steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123646 (owner: 10Tobias Gritschacher) [13:19:03] (03PS1) 10Daniel Kinzler: (bug 62644) snak validation in ChangeOpMainSnak. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 [13:19:05] (03Merged) 10jenkins-bot: Browsertests: move creation of new entities to entity_steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123646 (owner: 10Tobias Gritschacher) [13:19:07] (03Merged) 10jenkins-bot: Adding pageobjects and step definitions for common special page browsertests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123663 (owner: 10Tobias Gritschacher) [13:22:47] (03CR) 10Thiemo Mättig (WMDE): "Be consistent, use Special:SetSiteLink everywhere." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [13:23:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Get rid of term "handle" in the context of properties in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 (owner: 10Tobias Gritschacher) [13:23:39] (03CR) 10jenkins-bot: [V: 04-1] Get rid of term "handle" in the context of properties in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 (owner: 10Tobias Gritschacher) [13:24:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123859 (owner: 10Addshore) [13:26:42] any end user support there? I am playing with wikidata for the first time and wondering how I can get an item to use some template that would add all the statement for me [13:26:53] crazy test case is creating an item for me as a person: https://www.wikidata.org/wiki/Q16036125 [13:27:12] (03PS2) 10Henning Snater: Apply claimview instead of statementview to property page output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123562 [13:27:16] was expecting some field describing that it is a person and thus get a bunch of statements added to the item [13:27:24] (03PS2) 10Henning Snater: Adjust statementview's edit toolbar definition to capture claimviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 [13:27:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123860 (owner: 10Daniel Kinzler) [13:27:40] hashar: importScript( 'User:Magnus Manske/missing props.js' ); [13:27:45] hehe [13:27:48] (03PS2) 10Tobias Gritschacher: Get rid of term "handle" in the context of properties in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 [13:28:04] (03CR) 10Tobias Gritschacher: "PS2 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 (owner: 10Tobias Gritschacher) [13:28:06] hashar: there is no such things. no templates, no schemas. [13:28:26] Thiemo_WMDE: I've had to rebase https://gerrit.wikimedia.org/r/#/c/123851 [13:28:29] hashar: we will provide "smart" suggestions of properties based on the properties (and possibel values) already on the item [13:28:29] but, bring on the property suggestor :D [13:28:34] just found out "instance of" => person [13:28:51] hashar: so, if you already have a date of brith, wikidata would suggest place of birth, gender, etc [13:29:07] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Get rid of term "handle" in the context of properties in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 (owner: 10Tobias Gritschacher) [13:29:17] hashar: yes, using insteanceof is good, but it's just a convention. the software doesn't know about it [13:29:32] (03Merged) 10jenkins-bot: Get rid of term "handle" in the context of properties in browsertest features [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 (owner: 10Tobias Gritschacher) [13:29:39] DanielK_WMDE_: okkk [13:29:40] we may consider that value when suggesting properties, though [13:30:00] DanielK_WMDE_: when I created the item I was expecting wikidata to ask me what instance of it would be and then add all the statements [13:30:07] much like copy pasting the infobxoes example :-] [13:30:20] hashar: that's not how it works, no. [13:30:20] newbie mistake hehe [13:30:39] well, lots of people expect that. and it could be made to work for some very common cases (city, person, etc) [13:31:06] but it's hard to make somethign like this generic. gadgets are probably best, because they can encode conventions and domain knowledge [13:31:27] (03PS16) 10Tobias Gritschacher: Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [13:31:36] (03PS7) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [13:31:41] DanielK_WMDE_: my expectation probably comes from http://www.freebase.com/ [13:34:26] hashar: yea... never played with freebase much. they do have schemas, right? [13:34:31] yup [13:34:44] something we actually wanted to avoid [13:34:56] Freebase is some creative common license but I don't think their backend engine is open source [13:35:03] probably why we have wikidata now :-] [13:35:03] it's convenient for some common cases, and very annoying for uncommon cases. [13:35:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123562 (owner: 10Henning Snater) [13:35:17] yes, indeed [13:35:25] well, also their data model doesn't quite fit our needs [13:35:32] even though it's pretty close [13:36:16] oh and addshore welcome my user account @ wikidata.org \O/ [13:36:23] :P [13:38:51] no I got to figure out how to use a Person info box to load my Person object Q16036125 hehe [13:40:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 (owner: 10Henning Snater) [13:41:57] hashar: property by property. Using the {{#property:date of birth}} parser function (or lua). [13:42:30] * hashar looks for {{Q16036125}} :D [13:42:32] hashar: infoboxes that are constructed completely from wikidata are not yet available. we hope to showcase that at the hackathon. [13:42:41] can't wait for that! [13:43:01] play with the property parser function for now... [13:43:03] since my item is an instance of Person, I guess Person can be linked to some wikitext template [13:43:11] then fetch all my instance statements and feed them to the wikitext [13:43:21] and the lua interface. hm, i wonder where the documentation for that is now. [13:43:27] ash hoo when you catch him online :) [13:43:28] don't waste your time [13:43:45] that is my first ever time using wikidata . Gotta read the doc [13:44:39] hashar: the idea is actually the other way around: you would do {{Personbox}}, with no parameters. Wikipedia "knows" which item is linked to the page (via sitelinks). It will then pull in all the properties relevant to the personbox, and show them. [13:45:00] probably fine :-] [13:45:03] automatically assignign a template to an arbitrary item would be much more complex (and less useful, I think). [13:45:52] so you would invoke the wikitext template and somem system figure out it is applied on the Antoine Musso article and thus load the appropriate person item from wikidata? [13:45:58] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123851 (owner: 10Tobias Gritschacher) [13:47:07] hashar: yes. [13:47:13] thanks :-] [13:47:21] the same system that figires out which language links to show [13:49:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [13:50:59] (03PS8) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [13:51:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [13:52:17] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [14:02:39] (03PS4) 10Aude: Remove obsolete Wikibase\SiteLink class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 [14:02:42] (03PS2) 10Aude: Remove usage of Wikibase\SiteLink in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123854 [14:03:32] (03CR) 10Aude: [C: 04-1] "worth double checking this SiteLink class is not used in any special pages, hooks or other untested places" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [14:06:07] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123829 (owner: 10Aude) [14:08:16] (03PS1) 10Tobias Gritschacher: Browsertests: move creation of new properties to property_page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123861 [14:09:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123854 (owner: 10Aude) [14:12:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123861 (owner: 10Tobias Gritschacher) [14:13:53] so, it's not actually failing or don't know :/ [14:14:49] aude: failed to get master from git.wikimedia.org. [14:14:57] err core [14:15:22] curl https://git.wikimedia.org/zip/?r=mediawiki/core.git&format=gz&h=master [14:15:25] no can haz [14:16:01] somebody pulled the plug again it seems [14:16:26] think we should all just have weekend now. :-P [14:17:24] for travis, wonder why https://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/builds/22260493 only does one build [14:17:37] https://github.com/filbertkm/mediawiki-extensions-Wikibase/blob/travis/.travis.yml [14:17:39] Tobi_WMDE: https://github.com/wmde/WikibaseQueryEngine/pull/21 [14:17:46] vs https://github.com/filbertkm/mediawiki-extensions-Wikibase/blob/master/.travis.yml [14:18:06] i'm trying to make it where it can test client and/or repo [14:19:01] disregard! [14:20:32] DanielK_WMDE_: ping [14:23:03] Tobi_WMDE: https://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/jobs/22272188 same as wmf jenkins and what i get [14:23:08] it runs with --group Wikibase [14:24:06] aude: we're currently only running --group WikibaseClient on our jenkins [14:24:17] that might pass actually [14:24:25] JeroenDeDauw: yea? [14:24:26] I've changed that for the build's jobs today. [14:24:35] * DanielK_WMDE_ is trying to finish another patch in the next 30 minutes [14:24:42] did not change it for the other ones yet [14:24:49] ok [14:25:07] aude: should I change it? that might cause all changes to fail.. or is your fix merged? [14:25:28] not yet, but would first like to see it on travis ( i guess), before / after my patch [14:25:35] DanielK_WMDE_: well? [14:25:44] i can verify locally but would be nice for others to see [14:25:55] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/121317/9 [14:26:00] and the one it depends on [14:26:17] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/121317/9 [14:26:34] err. sorry; if you like, also https://gerrit.wikimedia.org/r/#/c/121689/ [14:26:34] (03CR) 10Jeroen De Dauw: Introduce ChangeOpFactory. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 (owner: 10Daniel Kinzler) [14:26:48]