[00:01:02] huh: It used to return a completely blank page. [00:01:06] Which is the worst. [00:02:28] Gloria: do you get asked a lot about it? [00:02:39] Rarely. [00:02:42] Very rarely. [00:02:50] (03PS4) 10Addshore: Fix ItemId initialization in ChangeOpsMerge::getConflictStringForTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [00:03:05] poked it again, guess it will still fail but then i think its a problem with the test and will poke it in the morning [00:03:10] A blank page is an issue because that's what an internal server error will also sometimes produce. [00:03:18] And some APIs, actually. [00:03:25] Will return a blank page. [00:03:31] Not internal server errors, we hope. [00:03:33] I have to go. [00:04:08] addshore: Not a good idea [00:04:10] huh: There is/was a maxmademputthishere.com. [00:04:15] hoo: ? :P [00:04:17] But spelled correctly. [00:04:56] addshore: Some callers might assume an ItemId/ PropertyId instead of the generic thing [00:05:21] callers to which? Term::getEntityId? [00:05:50] yeah [00:06:13] and you still don't handle null [00:06:23] that ewwy code will disappear anyway once Terms actually used entityids properly rather than using type / numeric id cobinations [00:06:34] if( !$this->fromItem->getId()->equals( $itemId ) ) [00:06:54] oh wait, so if its null it calls $itemId->getSerialization() below [00:06:57] bah! [00:07:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [00:15:24] addshore: That's what I meant with big mess... we have to figure out what null means in the context and then act according to that [00:15:31] but tomorrow (at least for /me) [00:15:54] :P [00:17:27] (03PS5) 10Addshore: Fix ItemId initialization in ChangeOpsMerge::getConflictStringForTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [00:17:40] hoo: done fixed ;p [00:17:42] sleep time :D [00:18:18] Oh wait... in PHP we can really do null . ' => ' ... [00:18:57] I believe so ;p [00:19:02] I keep forgetting that PHP is treating everything as valid where it can make some sense of... [00:19:06] :> [00:19:37] night! [00:19:43] If MediaWiki was written in a more low level language we would see Segfaults all the time :P [00:19:44] Good night [00:19:58] hehe, indeed :P [00:22:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [00:22:43] yo [00:22:45] night! [00:22:51] @info [00:22:51] http://bots.wmflabs.org/~wm-bot/dump/%23wikidata.htm [00:23:06] !night |HBD_DangSunM [00:23:06] HBD_DangSunM: Good night, sweet dreams and dream of Wikidata (admins)! [00:25:06] (03CR) 10Hoo man: [C: 04-1] "This (mostly Term) is totally insane stuff :P" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [00:25:25] (03PS6) 10Addshore: Fix ItemId initialization in ChangeOpsMerge::getConflictStringForTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [00:26:46] (03PS7) 10Addshore: Stop calling newFromNumber using an object in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [00:26:50] really night this time xD [00:32:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [00:36:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [01:29:37] Hi, is anyone here? [01:30:10] Can someone please make items for every ISO 639 language? [01:34:28] rschen7754: ^ [01:35:04] probably best to just do it yourself [01:35:09] similar to the WD:RTF pages [01:35:36] Do you need to seek approval for bots? [01:35:44] I know the answer is yes, but where [01:36:23] WD:RFP [01:39:48] rschen7754: https://www.wikidata.org/wiki/Wikidata:Flooders#Flood_flag_or_bot_flag.3F <- this is confusing [01:39:58] are you going to do a bot bot? [01:40:08] Not sure. [01:40:36] at least 7704 items [01:40:41] but many exist already [01:41:47] http://wdq.wmflabs.org/wdq/?q=claim%5B220%5D existing with ISO 639-3 code [01:55:55] there also might be some without the ISO 639 property ... no idea how to check for those [02:45:27] rschen7754: can https://www.ethnologue.com/subgroups/north-central-1 be used as a source? [02:45:47] I guess I'll do them by hand, since nobody wants to bot it [02:47:27] what i did is i used {{I| [02:47:32] err, the template {{I}} [02:47:53] and if you do some clever find and replaces, you get links that let you create the pages [02:49:03] good idea [02:51:28] How do we indicate marcolanguages ? [02:51:32] macro [02:52:47] wow, works for redirects too [07:22:43] JeroenDeDauw / Lydia_WMDE : I'm trying to get all Gerrit extension repos to use the JSON i18n format. I'm at the point where I'm left with a short list. [07:23:01] JeroenDeDauw / Lydia_WMDE: What's the status of the Gerrit extension repo DataTypes ? [07:23:47] aude: ^ [07:34:05] (03CR) 10Tobias Gritschacher: [C: 032] Using new "afterdraw" event to set focus on value variation input box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123181 (owner: 10Henning Snater) [07:34:25] (03Merged) 10jenkins-bot: Using new "afterdraw" event to set focus on value variation input box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123181 (owner: 10Henning Snater) [07:39:50] (03CR) 10Tobias Gritschacher: [C: 032] Fixed tabbing to valueView's input from property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123182 (owner: 10Henning Snater) [07:40:24] (03Merged) 10jenkins-bot: Fixed tabbing to valueView's input from property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123182 (owner: 10Henning Snater) [07:48:50] [13ValueView] 15snaterlicious created 06enterkey (+1 new commit): 02http://git.io/hCKtGg [07:48:50] 13ValueView/06enterkey 14855e265 15snaterlicious: Prevent Enter key from adding new line character in String expert [07:50:55] [13ValueView] 15snaterlicious opened pull request #45: Prevent Enter key from adding new line character in String expert (06master...06enterkey) 02http://git.io/9xXf4g [07:52:33] (03PS1) 10Addshore: Code Cleanup of ResultBuilder.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123534 [07:58:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123534 (owner: 10Addshore) [08:07:08] JeroenDeDauw / Lydia_WMDE : I'm trying to get all Gerrit extension repos to use the JSON i18n format. I'm at the point where I'm left with a short list. [08:07:18] JeroenDeDauw / Lydia_WMDE: What's the status of the Gerrit extension repo DataTypes ? [08:32:25] (03PS4) 10Tobias Gritschacher: Refactoring of basic Cucumber steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [08:34:31] (03PS9) 10Tobias Gritschacher: [WIP] Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [08:34:33] (03PS5) 10Tobias Gritschacher: Refactoring of basic Cucumber steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [08:40:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [08:44:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [08:48:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [09:04:01] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/123553 [09:04:01] [13WikibaseQuery] 15adrianlang created 06moveSerialization (+1 new commit): 02http://git.io/w1m2GQ [09:04:01] 13WikibaseQuery/06moveSerialization 144454385 15Adrian Lang: Move serialization of result set into API... [09:04:06] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/123553 (owner: 10Siebrand) [09:07:16] (03PS6) 10Tobias Gritschacher: Refactoring of basic Cucumber steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [09:07:16] [travis-ci] wmde/WikibaseQuery/moveSerialization/4454385 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22170244 [09:07:47] (03CR) 10Tobias Gritschacher: [C: 032] Refactoring of basic Cucumber steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [09:08:12] (03Merged) 10jenkins-bot: Refactoring of basic Cucumber steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [09:12:26] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121408 (owner: 10Thiemo Mättig (WMDE)) [09:12:57] (03PS1) 10WikidataBuilder: New Wikidata Build - 03/04/2014 09:12 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123557 [09:13:26] siebrand: data types is in github, although it has non-trivial amount of i18n so we might want to set up to have a mirror in the gerrit repo [09:13:37] to facilitate i18n updates [09:15:54] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 03/04/2014 09:12 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123557 (owner: 10WikidataBuilder) [09:20:21] (03PS1) 10Tarrow: Added sitefilter param to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 [09:21:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123557 (owner: 10WikidataBuilder) [09:25:42] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [09:26:23] (03CR) 10Addshore: [C: 032] New Wikidata Build - 03/04/2014 09:12 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123557 (owner: 10WikidataBuilder) [09:45:42] (03PS10) 10Tobias Gritschacher: [WIP] Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [09:45:49] (03PS1) 10Henning Snater: Apply claimview instead of statementview to property page output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123562 [09:45:51] (03PS1) 10Henning Snater: Adjust statementview's edit toolbar definition to capture claimviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 [09:46:55] (03CR) 10Thiemo Mättig (WMDE): Set font of the wb-firstHeading toolbar back to sans-serif (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 (owner: 10Thiemo Mättig (WMDE)) [09:47:29] (03PS2) 10Tarrow: Added sitefilter param to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 [09:47:58] Hoi, when an items gets changed that is connected to an article on a watchlist, that watchlist will be triggered right ? [09:52:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [09:56:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123562 (owner: 10Henning Snater) [10:00:18] (03PS1) 10WikidataBuilder: New Wikidata Build - 03/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123568 [10:03:17] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 03/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123568 (owner: 10WikidataBuilder) [10:04:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123563 (owner: 10Henning Snater) [10:08:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [10:11:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123568 (owner: 10WikidataBuilder) [10:21:32] (03CR) 10Thiemo Mättig (WMDE): (bug 62644) validate snaks in ChangeOpClaim (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [10:22:10] (03PS1) 10Aude: Revert "Simplify CSS needed to display Properties Data type" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123575 [10:22:11] (03PS1) 10Aude: Revert "(bug 63068) Show claims on property pages" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123576 [10:22:28] (03CR) 10Aude: [C: 032] Revert "Simplify CSS needed to display Properties Data type" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123575 (owner: 10Aude) [10:22:48] (03Merged) 10jenkins-bot: Revert "Simplify CSS needed to display Properties Data type" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123575 (owner: 10Aude) [10:24:29] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move WikibaseExceptionLocalizer messages to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123335 (owner: 10Aude) [10:24:46] (03Merged) 10jenkins-bot: Move WikibaseExceptionLocalizer messages to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123335 (owner: 10Aude) [10:29:26] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123575 (owner: 10Aude) [10:32:06] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Add documentation or badgeItems setting (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [10:33:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123576 (owner: 10Aude) [10:33:32] (03CR) 10Aude: [C: 032] Revert "(bug 63068) Show claims on property pages" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123576 (owner: 10Aude) [10:33:49] (03Merged) 10jenkins-bot: Revert "(bug 63068) Show claims on property pages" [extensions/Wikibase] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123576 (owner: 10Aude) [10:45:47] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123557 (owner: 10WikidataBuilder) [11:11:20] (03PS1) 10Henning Snater: Altered property page layout [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123587 [11:16:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123587 (owner: 10Henning Snater) [11:41:54] [travis-ci] wmde/WikibaseQueryEngine/removeSnakRole/6594b67 : Adrian Lang The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/22179381 [11:45:54] [travis-ci] wmde/WikibaseQueryEngine/typo/5eceeb0 : Adrian Lang The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/22179469 [11:50:03] siebrand: I will have a look [11:59:35] [13WikibaseQuery] 15adrianlang created 06htmlForm (+1 new commit): 02http://git.io/FG_HyQ [11:59:35] 13WikibaseQuery/06htmlForm 144dae2d0 15Adrian Lang: Rewrite SimpleQuery special page's search form using HTMLForm [12:00:15] [13WikibaseQuery] 15adrianlang opened pull request #8: Rewrite SimpleQuery special page's search form using HTMLForm (06master...06htmlForm) 02http://git.io/k8TYBw [12:01:16] [travis-ci] wmde/WikibaseQuery/htmlForm/4dae2d0 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22180674 [12:03:48] (03CR) 10Raimond Spekking: [C: 032 V: 032] Migrate to JSON i18n [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/123553 (owner: 10Siebrand) [12:03:55] (03CR) 10jenkins-bot: [V: 04-1] Migrate to JSON i18n [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/123553 (owner: 10Siebrand) [12:49:18] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/2uL4hg [12:49:18] 13jenkins-job-builder-config/06master 14bdfa8ed 15Tobias Gritschacher: Added job for PubSubHubbub & restructured yaml file layout [13:08:53] [13WikibaseQuery] 15JeroenDeDauw 04deleted 06moveSerialization at 144454385: 02http://git.io/15qeHQ [13:12:02] Adrian_WMDE: ugh, you did not fix the CI before submitting stuff ;p Now it's hard to review [13:12:33] [travis-ci] wmde/WikibaseQuery/master/b7055b4 : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22185126 [13:13:12] [13WikibaseQuery] 15JeroenDeDauw created 06rem (+1 new commit): 02http://git.io/99Qs9A [13:13:12] 13WikibaseQuery/06rem 14a0d3c33 15jeroendedauw: Remove deprecated file [13:19:01] [travis-ci] wmde/WikibaseQuery/rem/a0d3c33 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22185400 [13:19:05] I get an error on trying to install Wikibase Repo?! [13:19:45] (03PS1) 10Adrian Lang: Add missing wikibase.utilities dependency to snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123631 [13:19:47] (03PS1) 10Adrian Lang: Reorder snakview dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123632 [13:22:52] JeroenDeDauw: http://wdjenkins.wmflabs.org/ci/job/wikibase-build-repo-tests/39/consoleFull [13:23:26] Adrian_WMDE: just filed https://bugzilla.wikimedia.org/show_bug.cgi?id=63481 [13:24:26] Tobi_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=63482 [13:25:51] DanielK_WMDE_: ^^ [13:26:07] does that have to do with some changes we did recently? [13:26:32] using BIGINT for wb_terms [13:27:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123631 (owner: 10Adrian Lang) [13:29:21] table prefix is my guess [13:29:35] ALTER TABLE /*:*/wb_terms doesn't look right [13:29:50] /*_*/ is what is done elsewhere [13:30:21] aude: sounds plausable - please to commit? ;p [13:30:30] DanielK_WMDE_ is making a patch [13:30:48] Tobi_WMDE: the patch for that has a typo which will case a db error if you are using table prefixes [13:31:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123632 (owner: 10Adrian Lang) [13:31:30] DanielK_WMDE_: allright [13:32:46] (03PS5) 10Daniel Kinzler: Make ClaimGuidGenerator behave like a service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 [13:38:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 (owner: 10Daniel Kinzler) [13:39:13] (03PS1) 10Daniel Kinzler: (bug 63482) Fix table prefix in MakeRowIDsBig.sql [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123637 [13:40:21] JeroenDeDauw: --^ [13:42:00] ugh... getting MediaWiki to correctly use PHPUnit... [13:45:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123637 (owner: 10Daniel Kinzler) [13:49:05] (03PS7) 10Daniel Kinzler: Introduce ChangeOpFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 [13:54:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 (owner: 10Daniel Kinzler) [13:56:16] [travis-ci] wmde/WikibaseQuery/fixme/fc1abdf : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22188496 [13:59:20] Haha, creating a fake Verison.php at usr/share/php/PHPUnit/Runner that includes the PHPUnit phar makes MW not fail [14:02:01] [13WikibaseQuery] 15JeroenDeDauw 04deleted 06fixme at 14fc1abdf: 02http://git.io/XygU3A [14:12:55] [13WikibaseQuery] 15JeroenDeDauw created 06ci (+1 new commit): 02http://git.io/DkJTYw [14:12:55] 13WikibaseQuery/06ci 14fdfd289 15jeroendedauw: Fix issues to make CI pass again [14:18:25] Thiemo_WMDE: https://github.com/wmde/WikibaseQuery/pull/11 [14:19:14] JeroenDeDauw: looks suspicious for many reasons. can i trust you? ;-) [14:19:46] [13WikibaseQuery] 15thiemowmde closed pull request #11: Fix issues to make CI pass again (06master...06ci) 02http://git.io/Zzl4LA [14:21:36] (03PS7) 10Daniel Kinzler: (bug 62644) move snak validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [14:21:44] [13WikibaseQuery] 15JeroenDeDauw 04force-pushed 06rem from 14a0d3c33 to 1448e4132: 02http://git.io/YOSjmw [14:21:44] 13WikibaseQuery/06rem 1448e4132 15jeroendedauw: Remove deprecated file [14:22:24] [13WikibaseQuery] 15JeroenDeDauw 04force-pushed 06htmlForm from 144dae2d0 to 14bdc970c: 02http://git.io/eLeGRA [14:22:24] 13WikibaseQuery/06htmlForm 14bdc970c 15Adrian Lang: Rewrite SimpleQuery special page's search form using HTMLForm [14:24:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [14:29:08] [travis-ci] wmde/WikibaseQuery/master/4b35c50 : thiemowmde The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/22191085 [14:30:13] [travis-ci] wmde/WikibaseQuery/ci/fdfd289 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/22190336 [14:32:58] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/5n1bzw [14:32:58] 13WikibaseQuery/06master 1412c440d 15Jeroen De Dauw: Update README.md [14:33:42] (03CR) 10Bartosz Dziewoński: [C: 031] Set font of the wb-firstHeading toolbar back to sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 (owner: 10Thiemo Mättig (WMDE)) [14:33:55] [travis-ci] wmde/WikibaseQuery/rem/48e4132 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/22191248 [14:35:10] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/3mlTiA [14:35:10] 13WikibaseQuery/06master 14cf6c95a 15Jeroen De Dauw: Update README.md [14:36:56] (03CR) 10Daniel Kinzler: [C: 04-1] "this version is fubar" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [14:54:20] [travis-ci] wmde/WikibaseQuery/htmlForm/bdc970c : Adrian Lang The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/22191305 [14:55:05] (03PS11) 10Tobias Gritschacher: Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [15:00:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [15:00:56] [13WikibaseQuery] 15JeroenDeDauw created 06json-i18n-rebased (+1 new commit): 02http://git.io/eTWWbA [15:00:56] 13WikibaseQuery/06json-i18n-rebased 1441b3693 15Siebrand Mazeland: Migrate to JSON i18n... [15:01:11] [13WikibaseQuery] 15JeroenDeDauw opened pull request #12: Migrate to JSON i18n (06master...06json-i18n-rebased) 02http://git.io/DI9NwQ [15:01:36] [13WikibaseQuery] 15JeroenDeDauw closed pull request #4: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/D2G6QQ [15:03:11] (03PS12) 10Tobias Gritschacher: Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [15:05:22] (03CR) 10Jeroen De Dauw: [C: 032] (bug 63482) Fix table prefix in MakeRowIDsBig.sql [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123637 (owner: 10Daniel Kinzler) [15:05:24] (03PS1) 10Tobias Gritschacher: Browsertests: move creation of new entities to entity_steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123646 [15:08:13] (03CR) 10Jeroen De Dauw: [C: 04-1] "Think the interface does not add value, see inline comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 (owner: 10Daniel Kinzler) [15:09:32] (03PS13) 10Tobias Gritschacher: Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [15:10:16] [13DataTypes] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/cdGYfw [15:10:16] 13DataTypes/06master 14f20cddc 15Jeroen De Dauw: Update DataTypes.php [15:10:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [15:21:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [15:21:51] [travis-ci] wmde/WikibaseQuery/json-i18n-rebased/41b3693 : Siebrand Mazeland The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/22194355 [15:22:17] (03CR) 10Daniel Kinzler: [C: 032] Split Snak html formatting code from ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122852 (owner: 10Aude) [15:22:41] (03Merged) 10jenkins-bot: Split Snak html formatting code from ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122852 (owner: 10Aude) [15:23:43] (03PS8) 10Daniel Kinzler: (bug 62644) move snak validation into ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [15:24:34] (03CR) 10Daniel Kinzler: [C: 04-1] "The way test entities for API tests are initialized needs to change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [15:29:51] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [15:36:18] (03PS5) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [15:38:20] aude: I amended [15:38:24] arg [15:38:36] ok [15:38:40] aude: I amended your and thiemo's changes for the special page changes [15:38:53] I mean special page browsertests [15:39:10] shall take a look to base off of thiemo's refactoring [15:39:14] and based them upun each other and one additional base change I've made [15:39:42] aude: I made a lot of things reusable in thiemos patch and use it in your patch [15:40:13] hmmm [15:40:31] so there is a change of 3 patches where yours is on the top now.. :P [15:40:37] i'll wait then [15:40:39] *chain of 3 patches [15:40:43] should go home now.. [15:40:45] too much [15:41:22] i would split the stuff from thiemo's patch that is generic [15:41:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [15:43:03] (03CR) 10Aude: "think it would be better to split the generic, reusable parts of this patch into another changeset" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [15:43:21] aude: could do [15:43:35] so we have modify term etc [15:43:41] don't need [15:43:58] modify entity would be reusable [15:44:40] aude: probably not worth splitting it. think it is less effort to review and merge thiemos patch [15:44:50] if you think it can be done soon [15:45:01] it's almost finished [15:45:11] I almost completed it [15:45:20] but want him to have a look at it [15:46:00] aude: we could do plenty of more tests.. almost infinite.. but think we have the basic ones [15:46:12] ok [15:46:54] aude: one thing we could still add is something you did for the sitelinks test, that is, navigating to special:setlabel with the id of an item [15:47:12] another patch [15:47:22] yeah [15:47:32] small patches are easier for us to understand waht is changing and why [15:48:47] anyway, think i'm done for today / at off [15:48:48] ice* [16:04:44] How is everybody? [16:07:57] Cow comes that some articles on enwp isn't on Wikidata yet? Som are as old as 2007 ever... [16:08:25] Aren't they moved automaticly by a bot? [16:09:33] (03CR) 10Jeroen De Dauw: "-0.5, please remove the not needed injection" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 (owner: 10Daniel Kinzler) [16:09:39] (03CR) 10Jeroen De Dauw: Make ClaimGuidGenerator behave like a service (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 (owner: 10Daniel Kinzler) [16:14:11] Josve05a: They were supposed to be - I'm not sure on the status of it though. [16:14:18] (03PS14) 10Tobias Gritschacher: Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [16:15:29] Tobi_WMDE: is https://gerrit.wikimedia.org/r/#/c/123558/2/repo/includes/api/GetEntities.php a sensible parameter in your opinion? [16:15:41] well, not sensibble parameter, but sensible name for the param? [16:19:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [16:19:53] (03PS1) 10Tobias Gritschacher: Adding pageobjects and step definitions for common special page browsertests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123663 [16:24:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123663 (owner: 10Tobias Gritschacher) [16:25:19] (03CR) 10Addshore: [C: 031] Added sitefilter param to wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123558 (owner: 10Tarrow) [16:26:35] (03PS2) 10Tobias Gritschacher: Adding pageobjects and step definitions for common special page browsertests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123663 [16:26:37] (03PS2) 10Tobias Gritschacher: Browsertests: move creation of new entities to entity_steps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123646 [16:27:55] [13WikibaseQuery] 15addshore 04deleted 06rem at 1448e4132: 02http://git.io/5TcCVg [16:28:36] (03PS15) 10Tobias Gritschacher: Add Cucumber test for Special:SetLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [16:32:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123663 (owner: 10Tobias Gritschacher) [16:35:43] (03PS6) 10Tobias Gritschacher: Cucumber tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [16:37:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123646 (owner: 10Tobias Gritschacher) [16:43:27] (03PS1) 10Aude: New build, removing changes to PropertyView not ready for deployment [extensions/Wikidata] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123667 [16:43:58] i'll let the tests run etc. and finish this when i get home [16:46:25] (03CR) 10jenkins-bot: [V: 04-1] New build, removing changes to PropertyView not ready for deployment [extensions/Wikidata] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123667 (owner: 10Aude) [16:46:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121390 (owner: 10Thiemo Mättig (WMDE)) [16:51:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (owner: 10Aude) [16:52:01] (03CR) 10Tobias Gritschacher: [C: 032] Store shortcut to references listview in statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123176 (owner: 10Adrian Lang) [16:52:05] (03CR) 10Tobias Gritschacher: [C: 032] Correctly initialize index for new references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [16:52:22] (03Merged) 10jenkins-bot: Store shortcut to references listview in statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123176 (owner: 10Adrian Lang) [16:52:29] (03Merged) 10jenkins-bot: Correctly initialize index for new references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [16:53:39] (03CR) 10Bene: "@Thiemo: Good point, need to ask Lydia for that." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [16:53:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123667 (owner: 10Aude) [16:54:43] Lydia_WMDE: ping :) [16:58:41] (03CR) 10Tobias Gritschacher: "@bene in general it depends on the UI design we choose for the repo but it would be nice to have the icons there. however if this is causi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [16:59:18] Tobi_WMDE: hmm [16:59:27] of course items would be nice [16:59:41] however, the clients will use their own icons anyway [16:59:55] so this migh cause some confusing [17:00:06] benestar: true [17:00:15] additionally, not all badges probably will have icons [17:00:27] so it would be no problem to implement icons [17:00:34] however, I am not sure if it makes sense [17:00:39] Tobi_WMDE: what do you think? [17:00:42] benestar: what I mean, the UI design should not depend or hard require icons [17:01:09] yes, the labels will still be visible, also with icons [17:01:22] benestar: yes [17:01:26] Tobi_WMDE: so for now just ban the icons from the setting? [17:01:38] benestar: fine with that [17:01:40] k [17:03:35] (03PS2) 10Bene: Add documentation or badgeItems setting and fix the code accordingly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 [17:03:46] Tobi_WMDE: --^ [17:03:46] (03CR) 10jenkins-bot: [V: 04-1] Add documentation or badgeItems setting and fix the code accordingly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [17:03:52] :O [17:08:12] Tobi_WMDE: ok, rebased the change to that it should probably be ok now [17:08:52] (03PS3) 10Bene: Add documentation or badgeItems setting and fix the code accordingly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 [17:08:58] here you go [17:09:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [17:09:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [17:15:16] (03PS4) 10Bene: Add documentation or badgeItems setting and fix the code accordingly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 [17:17:41] (03CR) 10Bene: "Created a new patch set to start Jenkins again as it failed hard before." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [17:17:47] Tobi_WMDE: do you know why jenkins failed so hard for the last patch set? [17:18:06] see http://wdjenkins.wmflabs.org/ci/job/wikibase-repo-tests/484/ [17:19:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [17:25:28] aude: still around (no worries if you aren't)? [17:27:03] greg-g: aude is on her way home, but will come back online later, for deployment [17:27:11] coolio [17:27:21] :P [17:27:40] just curious about the "Wikiquote gets language links via Wikidata " thing, does that need anything manual like a config change still or will it "just happen" with the train? [17:28:30] that'S tonight? i'm a bit out of the loop deployment wise... [17:29:05] yes, that needs (minor) config changes. might be that we have this prepared to the point where we just need to add a wiki group to a list somewhere, and the rest just happens. [17:29:08] aude will know [17:29:30] DanielK_WMDE_: do you know what's the problem here? http://wdjenkins.wmflabs.org/ci/job/wikibase-repo-tests/485/ [17:29:36] DanielK_WMDE_: no, next week, sorry :) [17:29:42] seems a bit weired to me... [17:29:47] greg-g: *phew* [17:29:48] * greg-g is doing his deploy calendar updating/planning thing [17:29:50] :) [17:30:16] oh, right, that would be in a wikipedia deployment window, not a wikidata deployment window [17:30:25] * greg-g nods [17:30:55] benestar: that looks odd. no idea! [17:31:02] -.- [17:31:14] DanielK_WMDE_: who might know what's going on there? [17:34:56] benestar: hey :) [17:35:00] still need me? [17:35:19] Lydia_WMDE: Tobi_WMDE and I just decided not to show any icons for badges on repo [17:35:41] Lydia_WMDE: do you know why Jenkins is broken? :P [17:35:41] benestar: but instead? [17:35:57] Lydia_WMDE: see https://gerrit.wikimedia.org/r/#/c/123441/ [17:36:01] katie is investigating jenkins since yesterday - we don't know why it is broken yet [17:36:06] ok will have a look [17:36:55] greg-g: that will need a config change [17:37:09] katie will prepare that [17:37:55] gah [17:37:58] gerrit... [17:38:00] pita [17:38:07] Lydia_WMDE: kk, thankya [17:38:09] and :) [17:38:15] * greg-g chants Phabricator [17:38:18] heh [17:39:27] greg-g: I've been looking at Phabricator a bit, lovely design of it :p [17:41:35] benestar: ok looked at it. i agree with Tobi_WMDE that icons shouldn't block for now. i wonder how we want to show them then though [17:41:44] as in where to add the text [17:41:58] do you have an idea? [17:42:03] Lydia_WMDE: the main problem is that clients will perhaps use different icons [17:42:09] for the same badge [17:42:23] at least they may do so which might confuse lots of editors [17:42:52] is that an actual issue? if it is then fine. [17:43:05] greg-g: minor config changes and make sure wikiquote has sites table (and populated) [17:43:08] i just don't want us to make our life harder for ourself if it isn't actually an issue [17:43:48] we can check the sites table ourselves and probably even populate it :) [17:43:48] Lydia_WMDE: do you think icons would improve the user interface? [17:44:17] aude: cool, add the config change to the deploy wiki when you have it, thankya! [17:44:18] reedy can add it, if needed [17:44:23] ok [17:44:49] aude: what's going on with Jenkins? [17:44:55] benestar: it makes things easier imho in the interface because we can just add the icon after the sitelink in the sitelink tables. for text i am not sure how that'd work [17:45:08] benestar: but there are probably ways to make it work [17:45:11] benestar: can't look right now, need to make sure we're ready to deploy to test wikidata [17:45:36] testwikidata deploy? :D [17:45:36] Lydia_WMDE: but how would the icons handle multiple badges? [17:45:41] just add lots of icons? [17:45:45] JohnLewis: yes [17:45:50] benestar: yes [17:45:53] aude: nice :p [17:46:00] i don't think much new from user perspective [17:46:24] Well, any deploy is a deploy, regardless of what it does :p [17:46:31] Lydia_WMDE: hmm, so we maybe shouldn't drop the icons then? [17:46:42] aude: some speed improvements will surely make JohnLewis happy ;-) [17:46:52] ^^ [17:46:54] #like [17:47:10] benestar: as Tobi_WMDE said it shouldn't block but in the long run i think we need them. can be convinced otherwise though [17:47:27] Lydia_WMDE: what about badges not having any icons [17:47:34] Lydia_WMDE: Making me the supreme overlord would make me happier :p [17:47:36] good point [17:47:40] we would have to enforce icons for every badge [17:47:46] JohnLewis: shush! :P [17:47:57] benestar: mpfh. yeah [17:48:02] also not good [17:48:05] which might also become a problem as icons do not make sense for some badges [17:48:11] yeah [17:48:15] (03CR) 10Aude: [C: 032 V: 032] "WikidataJenkins approves and issue on wmf jenkins is not blocker" [extensions/Wikidata] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123667 (owner: 10Aude) [17:48:21] Lydia_WMDE: what about a simple star icon for all badges [17:48:28] don't like doing that... we'll get a fix in [17:48:42] the star might contain the number of badges [17:48:57] benestar: that could work for starters [17:49:08] and when you click you see them all? [17:49:10] Lydia_WMDE: When are we finalising the 'John becomes the Supreme Master of Wikimedia' contract with Wikimedia? xD [17:49:21] Lydia_WMDE: yes, in a dropdown menu [17:49:28] just like in one of the mock us [17:49:30] *ups [17:49:37] JohnLewis: maaaaaaan! you shouldn't talk about that contract! you're getting me in all kinds of trouble here ;-) [17:49:45] benestar: ok let's try that [17:49:48] Lydia_WMDE: Fine :p [17:50:13] (03CR) 10Aude: "gah, need to click submit ;)" [extensions/Wikidata] (mw1.23-wmf21) - 10https://gerrit.wikimedia.org/r/123667 (owner: 10Aude) [17:50:20] * aude forgets how gerrit works [17:50:30] :D [17:50:42] JohnLewis: Lydia_WMDE said "benestar: ok let's try that" not "JohnLewis: ok let's try that" :P [17:50:50] haha [17:51:42] benestar: But I want to benestar :( [17:51:46] *to be [17:52:36] JohnLewis: I wanna be the master of everything [17:53:03] so you are not alone :P [17:53:15] benestar: We are different though :p [17:53:29] yes, everything is more than Wikimedia [17:53:54] rofl [17:54:18] benestar: No, I mean I am the one who has written terms already - you still have to write yours ;) [17:54:27] JohnLewis: which terms? [17:54:46] The master of everything does not need any terms [17:54:53] (and while you haggle this out i am the master already. muahahahaha) [17:54:56] :P [17:55:01] benestar: Then you have passed the test already >:D [17:55:12] Lydia_WMDE: For now... >:D [17:55:14] :P [17:55:15] ;-) [17:55:49] Also how's the spam filters been treating your inbox Lydia_WMDE? [17:55:56] ahhhhhhhhhhhhhhhhhhhhhhhh [17:56:02] :D [17:56:04] JohnLewis: delete 'em all [17:56:08] :P [17:56:10] evil JohnLewis [17:56:11] (brb - getting something to eat before WMF metrics meeting'n' crap :p) [17:56:24] me too [17:56:28] Lydia_WMDE: so please give Thiemo a trout now [17:56:44] I splitted my patch up into pieces of ~2 files... [17:56:44] benestar: can't :/ we're not in the same building atm [17:56:52] Lydia_WMDE: then asap [17:56:56] will see him again on monday ;-) [17:57:26] benestar: that helps a lot with reviewing [17:57:47] * benestar adds aude as a reviewer everywhere now :P [17:58:02] now i need to configure and add some badges, so i can try the patches [17:59:00] aude: https://gerrit.wikimedia.org/r/#/c/123441/ should fix the config problems [17:59:32] aude: and then first try this: https://gerrit.wikimedia.org/r/#/c/123447/ ;) [18:00:06] benestar: Little does she know, the Filter will self-destruct next week >:D [18:00:09] benestar: thanks :) [18:00:18] thanks too [18:00:24] away now [18:33:16] Lydia_WMDE: Are you free now, Can I ask for some help? [18:47:24] shrees: do you need Lydia_WMDE specifically? If you just ask, perhaps someone else can help you. [18:48:14] actually I wanted to know if someone can review my project proposal and suggest improvements? [18:48:37] https://www.mediawiki.org/wiki/User:Shrees1234/GSoC_2014_proposal#Project_Outreach I have applied for OPW [18:48:40] shrees: just post it here, on the mailing list, in the project chat... [18:49:23] yeah that's the link to my proposal [18:52:55] please help by suggesting improvemrnts [18:54:12] i just read the synopsis. who is the target audience of this text? [18:57:01] it seems like everythign before the word "facebook" is already known to people active on wikipedia or wikidata. in the synopsis, it's important to give the relevant "new" information quickly, so people know what *this* proposal is about, in comparison to others. [18:58:04] also... SEO? wikipedia people don't like SEO - SEO people are generally spanners trying to post links to wikipedia. [18:58:24] Google loves wikipedia. they are already indxing us as fast as they can. [18:58:45] well, maybe not wikidata. there, they are more interested in getting direct access to structured data (not web pages) to feed to Knowledge Graph. [18:58:48] DanielK_WMDE_: 4 minutes after page creation at Dutch Wikipedia article already showed up as first hit in Google [18:58:56] yea... [18:59:25] It looked like a copy and paste job so I searched for the text and ended up in this nice circle.... :P [18:59:33] hehehe... [19:01:08] shrees: i hope that helps for a start. Also, I didn't quite get the thumbnail part; but as I said, I have only read the synopsis yet. [19:06:14] thanks a lot. I will try to iprove it [19:06:23] *improve [19:06:52] good luck, and have fun :) [19:13:18] (03PS1) 10Daniel Kinzler: Don't use the API when setting up test entities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123697 [19:16:34] DanielK_WMDE_: GL HF GG ? :) [19:18:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123697 (owner: 10Daniel Kinzler) [19:18:54] DanielK_WMDE_: no reply - such BM [19:23:00] (03PS2) 10Daniel Kinzler: Don't use the API when setting up test entities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123697 [19:23:24] JeroenDeDauw: i was AFK, but I have no idea what your TLAs mean. [19:23:43] (03PS1) 10Jeroen De Dauw: Optimize imports in SnakHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123703 [19:23:50] (03CR) 10Jeroen De Dauw: [C: 032] Code Cleanup of ResultBuilder.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123534 (owner: 10Addshore) [19:25:12] DanielK_WMDE_: gaming terms - "good luck and have fun" is the typical thing to say at the start of a game [19:25:15] As GL HF [19:25:36] oh right, remember hearing that before :P [19:25:51] never was much of a gamer, much less multiplayer [19:27:03] JeroenDeDauw: feel free to merge that patch, though :) [19:28:49] (03CR) 10Aude: [C: 032] Optimize imports in SnakHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123703 (owner: 10Jeroen De Dauw) [19:29:14] (03Merged) 10jenkins-bot: Optimize imports in SnakHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123703 (owner: 10Jeroen De Dauw) [19:30:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123697 (owner: 10Daniel Kinzler) [19:31:29] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123703 (owner: 10Jeroen De Dauw) [19:51:22] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123772 (owner: 10L10n-bot) [20:18:29] anyone here? [20:19:25] Sure [20:20:11] hoo: how are hierarchies like taxonomy represented? [20:21:51] https://www.wikidata.org/wiki/Property_talk:P133#Point [20:23:29] oh, mh [20:24:09] I don't really know how that's done on Wikidata, the software itself doesn't have anything specific for tha [20:24:09] t [20:51:02] Lydia_WMDE: is there a ticket like this one for globe? https://bugzilla.wikimedia.org/show_bug.cgi?id=63476 [20:51:37] hi ajr [20:51:45] JeroenDeDauw: nope [20:52:04] Lydia_WMDE: makes little sense to only have an item for one of them ;p [20:52:45] JeroenDeDauw: i think adrian only stumbled upon this one so far so he filed it. if this is also an issue for globe then we should have that too yeah ;-) [20:53:26] s/issue/not implemented yet [20:53:44] hi [22:56:28] hi