[02:08:06] Would it be possible for someone to set up an exceptions report for me. I am looking to identify "people" who have a link to "English Wikisource" though don't have VIAF identifier data [07:48:46] (03PS1) 10Adrian Lang: Store shortcut to references listview in statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123176 [07:48:48] (03PS1) 10Adrian Lang: Correctly initialize index for new references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 [07:55:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123176 (owner: 10Adrian Lang) [07:58:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [08:26:16] (03Draft1) 10Henning Snater: Hide property label when adding additional statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123180 [08:26:21] (03Draft1) 10Henning Snater: Using new "afterdraw" event to set focus on value variation input box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123181 [08:26:49] (03Draft1) 10Henning Snater: Fixed tabbing to valueView's input from property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123182 [08:33:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123180 (owner: 10Henning Snater) [08:37:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123181 (owner: 10Henning Snater) [08:42:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123182 (owner: 10Henning Snater) [08:44:27] (03PS2) 10Henning Snater: Store shortcut to references listview in statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123176 (owner: 10Adrian Lang) [08:44:45] (03PS2) 10Henning Snater: Correctly initialize index for new references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [08:50:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123176 (owner: 10Adrian Lang) [08:54:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [08:54:40] (03PS3) 10Henning Snater: Correctly initialize index for new references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [08:55:35] [13WikibaseDatabase] 15thiemowmde comment on pull request #29 14e77d020: Well, then I guess this thing could have a more descriptive name? But to be honest, I have no suggestion.... 02http://git.io/cJyqsA [08:55:41] (03CR) 10Henning Snater: [C: 031] Correctly initialize index for new references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [08:58:52] [13AskSerialization] 15adrianlang created 06updateDeps (+1 new commit): 02http://git.io/97_FgQ [08:58:52] 13AskSerialization/06updateDeps 1474fed0f 15Adrian Lang: Update dependencies, adapt to changes in serialization [08:59:11] [13AskSerialization] 15adrianlang opened pull request #7: Update dependencies, adapt to changes in serialization (06master...06updateDeps) 02http://git.io/ov-dsA [09:01:03] [travis-ci] wmde/AskSerialization#38 (updateDeps - 74fed0f : Adrian Lang): The build passed. [09:01:03] [travis-ci] Change view : https://github.com/wmde/AskSerialization/commit/74fed0fe9065 [09:01:03] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/22087189 [09:01:32] aude: just created wikidata-builder4 instance.. [09:01:39] ok [09:01:50] but cannot ssh to it (public key denied). can you give it a try? [09:02:00] huh [09:02:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123177 (owner: 10Adrian Lang) [09:03:59] Tobi_WMDE: same thing [09:05:20] aude: that's strange.. [09:05:31] i can make builds now [09:05:36] but need to get the builder working again [09:05:49] aude: yes [09:06:28] oh, gah [09:06:31] aude: console output of wikidata-builder4 does look fine [09:06:31] give me a sec [09:06:36] no it doesn't [09:06:39] no? [09:06:45] Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class wdbuilder::builder [09:06:50] (03CR) 10Henning Snater: "The spinner is not purely cosmetic. It blocks actions as long as the JavaScript is not initialized preventing unintended user actions. The" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123092 (owner: 10Thiemo Mättig (WMDE)) [09:12:43] Tobi_WMDE: i am in to wikidata-builder5 [09:12:53] now to setup the puppet class [09:13:25] aude: yes, works for me too [09:13:31] give me 5 min [09:13:34] ok [09:16:28] (03CR) 10Henning Snater: [C: 032] Simplify CSS needed to display Properties Data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123045 (owner: 10Thiemo Mättig (WMDE)) [09:17:20] (03Merged) 10jenkins-bot: Simplify CSS needed to display Properties Data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123045 (owner: 10Thiemo Mättig (WMDE)) [09:17:22] (03CR) 10Henning Snater: [C: 031] Store shortcut to references listview in statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123176 (owner: 10Adrian Lang) [09:20:04] (03PS1) 10Aude: New Wikidata build - 02/04/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123187 [09:20:42] so many lines of code changed! [09:22:25] aude: mainly i18n ;) [09:22:31] yep [09:23:02] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata build - 02/04/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123187 (owner: 10Aude) [09:23:15] i'll make one for the branch shortly... [09:24:00] same issue we had before on jenkins (btw i can reproduce when i run core + extension tests) [09:24:13] should be found and fixed [09:24:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2195b07 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22088321 [09:27:18] aude: does it give you more information on the mystery failure if you reproduce it locally? [09:27:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=63407 [09:27:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123187 (owner: 10Aude) [09:27:48] no but i added debugging and suspect an issue with https://gerrit.wikimedia.org/r/#/c/119306/ [09:28:11] not sure yet exactly what, but would be good to find it (in case there is an actual bug somewhere) [09:45:12] (03PS2) 10Addshore: Fix misnamed member variable in SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123116 (owner: 10Aude) [09:45:21] (03CR) 10jenkins-bot: [V: 04-1] Fix misnamed member variable in SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123116 (owner: 10Aude) [09:45:38] Tobi_WMDE: Lydia_WMDE aude etc. I would join the call but http://new.tinygrab.com/1becbe2e7830f9b2d444743f3d7e2a61fda3be4df1.png [09:46:23] same as what I got in italy :/ will send a mail. [09:50:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123116 (owner: 10Aude) [10:00:30] (03PS1) 10WikidataBuilder: New Wikidata Build - 02/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123194 [10:03:31] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 02/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123194 (owner: 10WikidataBuilder) [10:08:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123194 (owner: 10WikidataBuilder) [10:10:55] addshore: narf :( [10:11:06] addshore: i will add you explicitely to the calendar entry [10:11:07] it's an addshore 1 [10:11:08] ! [10:11:14] hope that will help [10:11:22] addshore: aude had the same problem but I think she figured out what was wrong.. [10:11:27] Lydia_WMDE: I have the calander entry and the link on the entry :/ [10:11:52] mpfh [10:11:56] then no idea what is wrong [10:12:02] Tobi_WMDE: not exactly, but think i know where to look for the phpunit issue [10:12:24] just look at https://gerrit.wikimedia.org/r/#/c/119306/ and maybe you spot some obvious issue [10:12:31] aude: hehe.. I referred to the problem with the daily hangouts. [10:12:37] oh, that [10:12:41] i have to click "yes i'm going" [10:12:45] addshore had the same issue [10:12:50] then i am allowed to join [10:12:52] addshore: ^^ [10:13:13] aude: ahhhhh, maybe that is it :P [10:13:23] Abraham_WMDE: http://vimeo.com/86632001 [10:13:25] Tobi_WMDE: [10:13:26] ^ [10:13:31] * aude demands denny fixes it :) [10:16:09] [13AskSerialization] 15JeroenDeDauw 04deleted 06updateDeps at 1474fed0f: 02http://git.io/yZJM8w [10:16:27] [13AskSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/PicmGw [10:16:27] 13AskSerialization/06master 1415776bf 15Jeroen De Dauw: Update AskSerialization.php [10:16:34] [13AskSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/fH6NsQ [10:16:34] 13AskSerialization/06master 14f31c111 15Jeroen De Dauw: Update AskSerialization.php [10:17:50] i am in to wikidata-builder3! [10:17:53] [13AskSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/rtIXlA [10:17:53] 13AskSerialization/06master 146b01a99 15Jeroen De Dauw: add branch alias [10:17:54] aude: its working again! [10:17:58] problem solved, i guess [10:18:07] addshore: did you do anything with wikidata-builder3 today? [10:18:13] nope [10:18:14] no, maybe rebooted it [10:18:15] why? :O [10:18:27] no builds the past days [10:18:35] aude: I did the rebooting several times yesterday and the day before with no luck [10:18:37] not able to ssh into it until today [10:18:42] addshore: it was dead [10:18:46] but it was just revived [10:19:00] we were not able to logon the past days [10:19:18] [13AskSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/7VTigw [10:19:18] 13AskSerialization/06master 144ea340b 15Jeroen De Dauw: Update composer.json [10:19:33] interesting, no not touched it! at least it is easy to recreate right ;p [10:22:34] [13AskSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/E-a5yQ [10:22:34] 13AskSerialization/06master 145ec679b 15Jeroen De Dauw: Update README.md [10:23:41] Adrian_WMDE: looks good? https://github.com/wmde/AskSerialization/compare/74fed0fe906564e3b79f5b1845b5e91538ef40d4...5ec679b33e0ee7f817a4b505cd09c9cb9a7d6c16 [10:27:23] looks good [10:27:58] I get an error on CREATE TABLE wbq_mainsnak_string in WikibaseQuery [10:28:05] Error: 1170 BLOB/TEXT column 'value' used in key specification without a key length (localhost) [10:28:25] DanielK_WMDE: JeroenDeDauw: addshore: That this index something you worked on? [10:31:18] Adrian_WMDE: I'll check whats going on with Query now [10:32:38] Adrian_WMDE: If I'm not mistaken the issue you are running into has already been fixed https://github.com/wmde/WikibaseQueryEngine/pull/17 [10:32:42] That still needs merging though [10:32:46] addshore: ping [10:34:34] addshore: we were recreating it but suppose we can delete those now [10:35:40] (03CR) 10Hoo man: [C: 032] Fix misnamed member variable in SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123116 (owner: 10Aude) [10:36:03] (03Merged) 10jenkins-bot: Fix misnamed member variable in SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123116 (owner: 10Aude) [10:37:05] JeroenDeDauw: pong (just cooking som food) [10:37:15] aude: I guess if it isnt broken :D [10:37:29] addshore: merge merge merge, more important than food! [10:37:43] will look after I finished my food (5 mins) [10:37:58] addshore: \o/ [10:38:05] meeeeerrrrge: https://github.com/DataValues/Common/pull/7 [10:42:26] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #29 14e77d020: > However, there really should be a place in that library that strips at least 0x00 characters from all identifiers, and maybe more characters based on what the DBMS allows.... 02http://git.io/QMHbLQ [10:44:06] Adrian_WMDE: JeroenDeDauw merged [10:48:09] Hi! I was just going through this feature request on adding ctrl+midclick response to search suggestions in WikidataRepo. I could setup wikibase repo in my localhost, its in Special Pages, but can someone help me reproducing this search suggestions ? [10:48:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=57709 [10:49:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.23-wmf21/102ad65 : aude The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/22093290 [10:55:16] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata build - 02/04/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123187 (owner: 10Aude) [10:55:39] (03CR) 10Tobias Gritschacher: New Wikidata build - 02/04/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123187 (owner: 10Aude) [10:56:05] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 02/04/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123194 (owner: 10WikidataBuilder) [10:58:11] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata build - 02/04/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123187 (owner: 10Aude) [11:06:37] Tobi_WMDE: https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FWikidata.git/refs%2Fheads%2Fmw1.23-wmf21 [11:06:57] since i pushed (to create the branch), i don't know if wikidata jenkins will run [11:07:20] but is essentially the same as the previous build [11:08:14] (03Abandoned) 10Aude: New Wikidata build - 02/04/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123187 (owner: 10Aude) [11:08:21] (03PS2) 10Tobias Gritschacher: Fixed tabbing to valueView's input from property input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123182 (owner: 10Henning Snater) [11:09:24] addshore: Unexpected non-MediaWiki exception encountered, of type "Wikibase\Database\Schema\TableCreationFailedException" [11:09:26] [6c05e04e] [no req] Exception from line 79 of /home/adrian/htdocs/wikibase-repo/vendor/wikibase/database/src/MediaWiki/MediaWikiTableBuilder.php: Table already exists [11:09:46] when doing what? [11:10:27] php maintenance/update.php [11:10:38] aude: ok thx! [11:10:43] Probably since the previous update failed half-way [11:12:56] hmm, I dont appear to be able to do composer install on WikibaseQuery right now.. [11:13:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123182 (owner: 10Henning Snater) [11:13:42] addshore: That's what we are trying to fix right now [11:13:47] ahhh :P [11:14:03] well, how can you run update.php if you cant even install the stuff? :P [11:14:19] I installed it manually and have a local patch for fixing the dependencies [11:14:47] push the patch? else I cant try to reproduce :P [11:15:29] I want to test the patch :P [11:15:40] well I cant help you with the exception then ;p [11:15:45] pff [11:15:51] just put it in a branch? [11:16:02] push push push [11:25:49] (03PS1) 10Thiemo Mättig (WMDE): Set font of the wb-firstHeading toolbar back to sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 [11:26:00] [13AskSerialization] 15JeroenDeDauw tagged 061.0.1 at 06master: 02http://git.io/crPUXw [11:27:25] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/123194 (owner: 10WikidataBuilder) [11:27:42] [travis-ci] wmde/AskSerialization#46 (1.0.1 - 5ec679b : Jeroen De Dauw): The build passed. [11:27:42] [travis-ci] Change view : https://github.com/wmde/AskSerialization/compare/1.0.1 [11:27:42] [travis-ci] Build details : http://travis-ci.org/wmde/AskSerialization/builds/22095191 [11:28:01] Adrian_WMDE: did you have a patch up for Wikibase Query already? [11:28:55] wait a sec [11:29:52] [13WikibaseQuery] 15adrianlang created 06updateDeps (+1 new commit): 02http://git.io/326pJA [11:29:52] 13WikibaseQuery/06updateDeps 140f53133 15Adrian Lang: Adapt to new versions of dependencies [11:30:16] [13WikibaseQuery] 15adrianlang opened pull request #5: Adapt to new versions of dependencies (06master...06updateDeps) 02http://git.io/_dsDuw [11:30:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 (owner: 10Thiemo Mättig (WMDE)) [11:31:20] JeroenDeDauw: http://git.io/_dsDuw [11:31:42] well, it installs now :D [11:32:08] [travis-ci] wmde/WikibaseQuery/updateDeps/0f53133 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22095374 [11:33:07] Mh, Permissions [11:33:11] [13WikibaseQuery] 15JeroenDeDauw created 06upversions (+1 new commit): 02http://git.io/LdFSLg [11:33:11] 13WikibaseQuery/06upversions 149243e43 15jeroendedauw: Update versions of dependencies and update (de)serializer interface usage [11:33:17] Adrian_WMDE: this probably works https://github.com/wmde/WikibaseQuery/pull/6 [11:34:48] [travis-ci] wmde/WikibaseQuery/upversions/9243e43 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22095513 [11:38:27] we can still not access beta from within our wdjenkins.. we can ping but it seems that e.g. api-requests are not going through.. [11:38:31] not sure why. [11:38:40] it's since beta moved the datacenter [11:42:03] not sure [11:43:18] addshore: did we ever have a bug for test2 being in Special:DispatchStats [11:43:28] as stalest [11:43:33] I didnt make one, just sent the email [11:43:41] ok, made one and fixed it :) [11:46:38] GerardM-: they are too busy being pompous to listen to any opinion than their own [11:47:11] in fact they hardly have enough room in their head for their own opinions, and only let it out otherwise their ego leaks out their ears [11:50:33] Tobi_WMDE: Lydia_WMDE https://bugzilla.wikimedia.org/show_bug.cgi?id=63410 please add to sprint [11:50:40] 3 points, i guess [11:52:12] aude: Tobi_WMDE: will do [11:58:09] (03PS2) 10Addshore: Clean up Client Api Module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121705 [12:02:29] https://bugzilla.wikimedia.org/show_bug.cgi?id=63409 is fixed, maybe 1 point [12:03:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121705 (owner: 10Addshore) [12:03:29] think i'm done on bugzilla for now [12:08:23] Lydia_WMDE: http://www.economist.com/blogs/graphicdetail/2013/08/daily-chart-1 [12:11:40] Lydia_WMDE: https://en.wikipedia.org/wiki/File:AKB48_20090703_Japan_Expo_52.jpg [12:12:07] Lydia_WMDE: Q51118 [12:17:09] addshore: how do you do this release thing on gh? where you mark a tag? [12:17:27] just edit the dag and give the release a name [12:17:30] addshore: by clicking "draft a new release"? [12:17:32] *tag [12:18:04] addshore: so you go to the "tags" tab and click "add release notes"? [12:18:28] ah indeed [12:18:30] yes [12:18:32] :) [12:19:11] meh [12:19:27] addshore: sucks this is a special GH thing though [12:22:23] [13WikibaseQuery] 15JeroenDeDauw 04deleted 06upversions at 149243e43: 02http://git.io/RHYOmQ [12:23:08] [13WikibaseQuery] 15JeroenDeDauw closed pull request #5: Adapt to new versions of dependencies (06master...06updateDeps) 02http://git.io/_dsDuw [12:24:32] JeroenDeDauw: indeed, and that it doesnt do it automatically :P [12:25:13] [travis-ci] wmde/WikibaseQuery/master/fabf1d5 : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/22098517 [12:25:32] (03CR) 10Daniel Kinzler: Split Snak html formatting code from ClaimHtmlGenerator (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122852 (owner: 10Aude) [12:30:54] (03PS2) 10Thiemo Mättig (WMDE): Set font of the wb-firstHeading toolbar back to sans-serif [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 [12:36:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 (owner: 10Thiemo Mättig (WMDE)) [12:45:38] Hi! Is there something like a separate search for the wikidata repo ? Or is it same to the search on the top bar ? [13:48:54] aude: DanielK_WMDE_ Ah indeed, I incorrectly merged in my ealier list, the note about it not belonging in lib was for ChangeNotifier, not ChangeHandler [13:52:26] JeroenDeDauw: ok, makes more sense [14:03:37] (03PS1) 10Daniel Kinzler: Make Constraints on Property page experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123226 [14:04:09] aude, Tobi_WMDE: ---^ [14:04:14] just merge and backport [14:08:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123226 (owner: 10Daniel Kinzler) [14:28:54] (03PS3) 10Aude: Split Snak html formatting code from ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122852 [14:28:58] (03CR) 10Aude: Split Snak html formatting code from ClaimHtmlGenerator (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122852 (owner: 10Aude) [14:34:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122852 (owner: 10Aude) [14:34:28] (03PS3) 10Daniel Kinzler: (bug 62644) validate snaks in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [14:37:02] Thiemo_WMDE: would you review https://gerrit.wikimedia.org/r/#/c/121316 ? [14:38:04] aude, Tobi_WMDE: ---^ [14:38:28] oops, sorry aude, Thiemo_WMDE. that came from the history :P [14:40:01] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [14:40:01] heh [14:40:08] jenkins say sno [14:40:10] no* [14:45:10] (03CR) 10Aude: [C: 04-1] "per jenkins and see comments" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [15:09:59] (03CR) 10Daniel Kinzler: [C: 031] "Thanks Thiemo, looks good!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 (owner: 10Daniel Kinzler) [15:13:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] (bug 62425) Property of main Snak must not change [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 (owner: 10Daniel Kinzler) [15:14:14] (03Merged) 10jenkins-bot: (bug 62425) Property of main Snak must not change [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120537 (owner: 10Daniel Kinzler) [15:17:35] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Make Constraints on Property page experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123226 (owner: 10Daniel Kinzler) [15:17:59] (03Merged) 10jenkins-bot: Make Constraints on Property page experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123226 (owner: 10Daniel Kinzler) [15:23:54] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Hide property label when adding additional statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123180 (owner: 10Henning Snater) [15:24:19] (03Merged) 10jenkins-bot: Hide property label when adding additional statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123180 (owner: 10Henning Snater) [15:27:51] (03CR) 10Thiemo Mättig (WMDE): "Resetting the focus after every draw doesn't sound right. What if the draw is triggered from somewhere else, e.g. if the redraw of a refer" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123181 (owner: 10Henning Snater) [15:45:33] (03PS4) 10Daniel Kinzler: (bug 62644) validate snaks in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [15:45:51] (03CR) 10jenkins-bot: [V: 04-1] (bug 62644) validate snaks in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [15:49:23] (03PS6) 10Daniel Kinzler: Introduce ChangeOpFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 [15:49:25] (03PS4) 10Daniel Kinzler: Make ClaimGuidGenerator behave like a service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 [15:49:27] (03PS5) 10Daniel Kinzler: (bug 62644) validate snaks in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [15:49:47] aude, Thiemo_WMDE: mmmeeeerrrgggg! [15:49:50] +e [15:49:52] :) [15:50:08] merge: https://github.com/DataValues/Common/pull/7 [15:52:07] yea, after cleanign up this mess... why did half of my change just get reverted by a rebase? wtf? [15:52:29] * aude sees whitespace [15:52:41] (03CR) 10Aude: Make ClaimGuidGenerator behave like a service (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 (owner: 10Daniel Kinzler) [15:52:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [15:56:06] aude: addshore any idea how to access the jenkins api from within the wdjenkins instance? [15:56:24] cannot access it through the public address [15:56:37] and 127.0.0.1 does not work either [15:56:46] where is it listening? [15:56:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121317 (owner: 10Daniel Kinzler) [15:58:52] um, it worked with the job builder on the old instance [15:59:22] aude: did it really? thought you always called it from your machine [15:59:35] i did, accessing jenkins api [15:59:44] (03PS1) 10Thiemo Mättig (WMDE): Replace fade that doesn't fade with more flexible CSS class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 [15:59:44] from within, no idea [16:00:02] https://wikidata-jenkins.wmflabs.org/ci/ [16:00:08] with username and password [16:00:11] aude: from outside, no problem for me. but I would like to have jenkins update itself [16:00:48] i guess look at ci stuff in puppet and see if/how they solved it for jenkins labs instances [16:03:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121316 (owner: 10Daniel Kinzler) [16:04:15] well, you can review github stuff [16:04:23] merge: https://github.com/DataValues/Common/pull/7 [16:05:04] if anyone is bored or stuck w/o gerrit [16:05:40] (03PS6) 10Daniel Kinzler: (bug 62644) validate snaks in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 [16:08:16] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [16:09:02] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/ZpGQKg [16:09:02] 13jenkins-job-builder-config/06master 1410aa1e9 15Tobias Gritschacher: Fix browser-timeout and add jenkins job builder job [16:09:45] (03CR) 10Henning Snater: "It does not set the focus on each draw(), only once right after the variation has been drawn: http://api.jquery.com/one/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123181 (owner: 10Henning Snater) [16:15:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123292 (owner: 10Thiemo Mättig (WMDE)) [16:18:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121689 (owner: 10Daniel Kinzler) [16:22:16] [13Common] 15brightbyte comment on pull request #7 147b78d26: Please construct a meaningful $message from $expectedValueType and $dataValueType if not given (perhaps don't even allow the $mesage to be given explicitly, or just include the explicit one in the auto-generated one). 02http://git.io/4xJ3zQ [16:23:36] [13Common] 15brightbyte comment on pull request #7 147b78d26: The name should say something abotub a "type", no? BadDataValueTypeException or some such. 02http://git.io/Xt39lQ [16:26:06] [13Common] 15brightbyte comment on pull request #7 147b78d26: Also, it kind of feels like this should be an InvalidArgumentException. Not sure, just something to consider. 02http://git.io/wmrQag [16:31:08] [13Common] 15filbertkm pushed 1 new commit to 06mismatch: 02http://git.io/J-HIKQ [16:31:08] 13Common/06mismatch 146d5b477 15aude: Rename exception to DataValueTypeMismatchException [16:34:14] Tobi_WMDE: https://github.com/wmde/puppet-wikidata-test/pull/2 [16:36:03] [13puppet-wikidata-test] 15tobijat 04deleted 06updates at 143c42632: 02http://git.io/b-gIfA [16:37:28] thanks [16:41:33] (03PS1) 10Aude: Update test group for UpdateRepoOnMoveTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123297 [16:41:54] (03PS1) 10Thiemo Mättig (WMDE): Reduce loading spinner toggle to a single 'loading' CSS class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 [16:42:51] * aude thinks even lydia can review https://gerrit.wikimedia.org/r/#/c/123297/ :) [16:45:52] aude: It's not easy to review unless and I can - and that seems far too complicated :/ [16:46:24] (03CR) 10John F. Lewis: [C: 031] "Confidence boost" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123297 (owner: 10Aude) [16:46:27] :p [16:47:26] :P [16:47:39] Lydia_WMDE: Cookie pls? I did a review at least :D [16:47:57] * Lydia_WMDE hands JohnLewis a cookie [16:48:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123297 (owner: 10Aude) [16:48:15] :D Thanks Lydia_WMDE :p [16:51:48] (03CR) 10Lydia Pintscher: [C: 032] Update test group for UpdateRepoOnMoveTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123297 (owner: 10Aude) [16:51:51] yay! [16:51:57] haz chocolate [16:52:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 (owner: 10Thiemo Mättig (WMDE)) [16:53:10] (03Merged) 10jenkins-bot: Update test group for UpdateRepoOnMoveTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123297 (owner: 10Aude) [17:02:20] [13Common] 15thiemowmde comment on pull request #7 146d5b477: Looks like DataValueType is a class. 02http://git.io/HjOX2w [17:15:12] (03PS1) 10Aude: Move WikibaseExceptionLocalizer messages to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123335 [17:20:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123335 (owner: 10Aude) [17:30:44] Hi all. [17:30:53] Hi Cyberpower678 :p [17:31:02] If you are a JS expert, please raise your hand. [18:21:24] (03CR) 10Bartosz Dziewoński: Set font of the wb-firstHeading toolbar back to sans-serif (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123203 (owner: 10Thiemo Mättig (WMDE)) [18:44:25] [13Common] 15JeroenDeDauw comment on pull request #7 146d5b477: MismatchingDataValueTypeException. The current one is in the format of ArgumentInvalidException, which is odd 02http://git.io/hzFx4g [18:45:20] [13Common] 15JeroenDeDauw comment on pull request #7 146d5b477: Indeed. I'd just drop the DataValueType type part, not like repeating that is helping clarity anyway 02http://git.io/vH1-kA [18:45:35] [13Common] 15JeroenDeDauw closed pull request #4: Localizable parse exception (06master...06LocalizableParseException) 02http://git.io/senKIg [18:52:36] [13Common] 15filbertkm comment on pull request #7 146d5b477: MismatchingException? MismatchingDataValueException? BadDataValueTypeException as daniel suggests? or what? 02http://git.io/ki5UkA [19:21:07] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123412 (owner: 10L10n-bot) [19:29:19] hi [19:30:09] can someone please create items for every ISO 639-1/2/3/6 languages? [19:31:04] or would that be too hard? [19:58:05] huy [19:58:14] do we have geo in wd? [19:59:45] geo? [19:59:54] Coordinates? [20:00:22] sjoerddebruin: can you make iso 639 all languages items? [20:00:42] huh: huh, how do you mean? [20:01:25] Juandev: Coordinates? [20:01:32] yep [20:01:38] https://www.wikidata.org/wiki/Property:P625 [20:02:16] sjoerddebruin: any example? [20:02:50] or well, I wonder if there is an easier way to write a location [20:02:55] coordinate [20:03:16] It accepts various input methods I think. [20:03:17] I mean for long URLs we have tinyurl, so what about for long coordinates [20:03:43] ... [20:04:56] Juandev: tinycoordinate? [20:05:06] ??? [20:05:17] huh: yes [20:05:26] thats an answer? [20:06:01] No, why not just enter coordinates in any of the accepted forms? [20:07:37] well, I want a coordinate in the pagename. But it seems to me to difficult to have such pagename, so I am looking for something easier [20:08:00] Coordinates in the pagename?!? [20:08:46] Juandev: what are you try to doing ? [20:09:50] well, we are doing a research at wv and we needs pages for different locations - the best for us to identify such locations is by GPS [20:10:36] for Wikipedia its easy, they describe towns and villages, hills and castles. These unites has mostly name. So the page name is London or Mount Everest [20:10:59] whill we would like to describe places, which doesnt have name [20:11:24] what kind of places without names? [20:12:40] so well, we can develope our own nomenclature [20:13:42] huh: research areas [20:14:07] many earth sciences use gps to identify the place [20:14:24] Where are these places? [20:14:29] so I was wondering if there is allready something I describe above [20:14:29] Just random coordinates? [20:15:46] huh: oh ya, I would understand it as randoom coordinates. For us it is not so important if the study object is in the are of this region or that region, maybe countries or bigger geographical units might be interesting [20:16:13] not sure how this relates to wikidata [20:16:37] gps is to unique, that other geographical data could be generated from somewhere:-) [20:16:48] Juandev: you could just number them "research area 1", "research area 2", or whatever [20:17:13] huh: I was just wondering how you identify different coordinates and now I see, that you dont, they are values for you [20:17:21] yes [20:17:53] well, yes huh. We should do something like that than [20:18:19] nice nick name btw:-) [20:18:56] thank you [20:19:03] can someone please create items for every ISO 639-1/2/3/6 languages ? [20:21:27] . [20:24:50] andre__: hi [20:27:56] "Approvals: [...] Lydia Pintscher: Looks good to me, approved" oO :) [20:28:19] hoo|away: haha yes! fear me! [20:28:20] :P [20:59:12] huh: heja [20:59:49] andre__: I replied on [[w:WP:VPT]] about rsvg [21:00:31] andre__: I think it's a librsvg (upstream) bug, can you confirm it? [21:00:52] huh: context? [21:00:56] or full link please [21:01:06] https://en.wikipedia.org/wiki/Wikipedia:VPT#MW_SVG_to_PNG_conversion_issue [21:01:12] ah. https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#MW_SVG_to_PNG_conversion_issue [21:01:14] yeah [21:01:16] not wikidata related, better channel for this? [21:01:37] huh: not sure how I am supposed to confirm it's an upstream bug though [21:01:49] but feel free to upstream it. It's likely. [21:02:44] andre__: you could try testing it with the non-Wikimedia equivalent version of rsvg-convert (or I could, but I have gnome 2 still...) [21:03:27] huh: so I take https://upload.wikimedia.org/wikipedia/en/b/be/The99logo.svg and then....? [21:04:27] andre__: rsvg-convert The99logo.svg > The99logo.png [21:05:11] yay, rsvg-convert: command not found [21:05:12] wait [21:05:17] o.O [21:05:34] (03PS1) 10Bene: Add documentation or badgeItems setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 [21:10:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123441 (owner: 10Bene) [21:11:54] huh, what am I supposed to check or see? [21:12:16] andre__: did you get output svg? [21:12:19] *png [21:12:23] yes [21:12:37] Does it look like https://upload.wikimedia.org/wikipedia/en/thumb/b/be/The99logo.svg/230px-The99logo.svg.png ? [21:12:44] or http://i.imgur.com/a0PNxN1.png ? [21:13:37] huh, like http://i.imgur.com/a0PNxN1.png when using EOG to look at it [21:13:45] huh, librsvg2-tools-2.40 [21:14:16] then ... I'm not sure why it is broken on wikimedia [21:14:37] huh: because maybe it was broken in an older librsvg version [21:14:56] might be already fixed in upstream [21:15:24] thank you very much for checking this! [21:15:29] np [21:28:41] (03PS1) 10Bene: Insert css styles for badges on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 [21:29:02] (03CR) 10Bene: "See https://gerrit.wikimedia.org/r/#/c/123447/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [21:33:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123447 (owner: 10Bene) [21:36:00] (03PS1) 10Bene: Support getting single sitelinks with ClientSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 [21:37:23] (03CR) 10Bene: "See also https://gerrit.wikimedia.org/r/#/c/123449/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [21:41:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123449 (owner: 10Bene) [22:25:37] [13Common] 15JeroenDeDauw comment on pull request #7 146d5b477: Looks like you are misplacing some of your comments... 02http://git.io/fdHoSA [22:35:36] hhi [22:35:55] can someone add an item for every iso 639 language? [22:37:58] maybe linguist list too [22:40:10] anyone here??? [22:45:17] huh: sure, just ask away [22:45:37] DanielK_WMDE_: at least two questions [22:45:41] 1) can someone add an item for every ISO 639 language? [22:46:15] 2) is P361 (part of) always supposed to use the next-biggest group? [22:46:22] or can it use any superset [22:46:24] ? [22:48:07] for example https://www.wikidata.org/wiki/Q188 (German) is "part of" Indo-European languages, Germanic, West Germanic, etc., but these should be in some sort of hierarchy [22:48:26] DanielK_WMDE_: ok, ? [22:52:36] Where should I ask it? Project chat? [22:53:38] if x is part of y, and y is part of z, is x part of z ? [22:53:46] hi badon [22:54:47] !ping [22:57:29] anyone here? [23:02:49] hi huh [23:03:29] badon: can someone add an item for every ISO 639 language? [23:04:53] Not me. [23:05:06] badon: if x is part of y, and y is part of z, is x part of z ? P361 = part of [23:09:26] huh: I'd say more often than not. [23:13:18] huh: was the question whether it is part of that other thing, or was it whether it should have the attribute twice? [23:13:39] i.e. two P361 properties or one [23:13:48] Yeah. [23:14:04] I would say it should only have one P361 property, and people can follow the chain if they want [23:14:12] thanks [23:14:54] Of course, it might be under two different parts of the tree as well…so sometimes it could have two P361 properties [23:14:56] It's called inferencing in Semantic Mediawiki, which makes sense. [23:15:11] (maybe not German, but maybe some other languages) [23:15:44] I note that http://tools.wmflabs.org/wikidata-todo/tree.html?q=19860&rp=361&method=list is a pretty small tree. [23:16:15] http://tools.wmflabs.org/wikidata-todo/tree.html?q=21200&rp=361&method=list is bigger [23:16:49] so 'germanic' and 'west germanic' are probably redundant, but 'indo-european' may or may not be. [23:17:04] wait, is that phase three? [23:17:27] 'phase three'? [23:26:53] (03PS1) 10Addshore: Fix call to ItemId::newFromNumber with ID object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [23:28:15] addshore: hi [23:29:33] hi huh :P [23:29:48] ty for that hoo ! [23:30:46] addshore: You're welcome... if this passes jenkins I'll maybe merge it right ahead (looks sane) [23:31:07] yup :P not sure how it went through like that :P as soon as I saw the line it was clear what was wrong [23:31:30] We have a very weak coverage of the merge item stuffs [23:31:40] I noticed that earlier before :S [23:31:56] earlier and before... choose one :P [23:32:16] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [23:32:46] PHP Fatal error: Call to a member function equals() on a non-object [23:32:47] wtf [23:32:54] I think this term object is lying to me [23:33:13] oh, well of course it has a return null; at the bottom [23:33:14] mh [23:33:32] maybe we in fact just want new Item( $term->getEntityId() ); [23:33:38] ? [23:33:58] might be a prefixed ID / serialization format... at least that sounds sane [23:34:03] not sure what the docs say [23:34:34] * new ItemId [23:35:20] addshore: Oh I see why the phpunit tests aren't catching that: // @FIXME: This is a bad hack and should die! [23:35:25] line 243 [23:35:53] * hoo introduced that [23:35:56] * hoo runs [23:36:02] :P [23:36:13] (03PS2) 10Addshore: Fix call to ItemId::newFromNumber with ID object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 [23:36:15] well hoo this should fix it [23:36:22] just flipped what we cann equals on [23:36:28] *call [23:38:00] mh, so we call equals with something other than an ItemId (probably the serialized format),r ight? [23:38:08] If that's supported, I'm ok with that [23:38:54] I dont follow :P unless equals() is passed an ItemId object equal to the itemId equals is called from it will return false [23:39:02] hi MF-Warburg [23:39:26] problem before was it seemed to be doing null->equals( ItemId $foo :D ) [23:39:45] and ->equals( null ) is more sane? [23:40:39] return $target instanceof EntityId ... [23:40:43] so that's fine :) [23:40:50] yup :P [23:41:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [23:41:20] tach huh [23:41:24] build failed, typical :D [23:41:30] hi MF-Warburg :) [23:41:47] Call to a member function getSerialization() on a non-object interesting [23:41:47] addshore: Let's just ignore it and let someone else figure the test failures tomorrow :D [23:41:52] haha [23:42:13] PHP Fatal error: Call to a member function getSerialization() on a non-object in /var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/repo/includes/ChangeOp/ChangeOpsMerge.php on line 291 [23:42:43] I see ... [23:43:20] mh... not sure how to react upon that... depends on what $itemId in fact is (let's hope it's something meaningful and not whatever) [23:43:45] hah [23:43:47] got it [23:44:04] Term's doc. is wrong and I was indeed right earlier :P [23:44:21] it really returns string|null [23:44:31] so that we can do new ItemId( ... ) [23:44:34] addshore: ^ [23:46:19] wait what xD [23:46:34] I can amend if you prefer :P [23:47:20] yus, [23:47:20] :D [23:47:20] youve clearly already seen it :P sooo :P [23:47:20] updating the docs too I presume? :D [23:47:34] Sure :d [23:49:27] (03PS3) 10Hoo man: Fix ItemId initialization in ChangeOpsMerge::getConflictStringForTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [23:50:06] Ok, now we're both "burned" and need to wait for someone else to approve [23:50:16] :D [23:51:08] Gloria: why did you make him put it there? [23:51:39] https://en.wikipedia.org/w/load.php [23:52:06] hmm hoo return $idParser->parse( $entityId->getSerialization() ); [23:52:16] that returns an EntityId object though :/ [23:52:19] not string [23:52:35] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/78200 ??? [23:52:56] addshore: What... where? [23:53:04] oh, more wrong docs [23:53:15] hoo: in getEntityId in Term where you change the doc [23:53:18] thats what confused me :P [23:53:42] Problem is that we have docs which make assumptions on the return values of injected classes [23:53:55] and the assumptions are wrong at some point [23:54:11] but not sure they're wrong in all cases :/ [23:54:45] s/injected classes/injected objects/ [23:54:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123477 (owner: 10Addshore) [23:54:49] bah [23:56:44] heh, now InvalidArgumentException: The id serialization needs to be a string. as its being passed the object xD [23:59:14] oh well... this is one big mess