[07:50:24] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/Diff] - 10https://gerrit.wikimedia.org/r/122318 [08:15:44] [13ValueView] 15adrianlang 04force-pushed 06dontPassAutoCharacteristics from 14abdc03f to 14ab7ad75: 02http://git.io/Fcd9aQ [08:15:44] 13ValueView/06dontPassAutoCharacteristics 14ab7ad75 15Adrian Lang: Don't pass precision and calendarmodel if set to auto [08:16:25] !nyan [08:16:25] ~=[,,_,,]:3 [08:25:02] (03CR) 10Adrian Lang: "This change needs manual rebasing. Also, you might want to consider splitting it up to attract reviewers :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [08:27:55] (03CR) 10Adrian Lang: [C: 031] "Looks good, needs manual rebase, though." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119502 (owner: 10Aude) [08:29:39] (03CR) 10Adrian Lang: [C: 032] Use SummaryFormatter in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88440 (owner: 10Daniel Kinzler) [08:30:21] (03Merged) 10jenkins-bot: Use SummaryFormatter in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/88440 (owner: 10Daniel Kinzler) [08:34:56] (03CR) 10Adrian Lang: [C: 032] Use wikibase.RepoApi in lib JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120977 (owner: 10Hoo man) [08:35:25] (03Merged) 10jenkins-bot: Use wikibase.RepoApi in lib JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120977 (owner: 10Hoo man) [08:37:10] (03PS18) 10Adrian Lang: (bug 40157) store entity status in page_props [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [08:42:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [08:42:39] (03CR) 10Adrian Lang: [C: 04-1] "The template params in lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js need to be adapted, too. Do you want to do that " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 (owner: 10Aude) [08:44:00] (03PS5) 10Adrian Lang: Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [08:45:48] (03PS7) 10Henning Snater: Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 [08:49:29] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [08:50:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [08:50:51] when does WD wil be used for linking projects? [08:51:09] i.e. WP <-> Commons <-> WS [08:51:42] now I have to add templates to WP [08:52:07] and filling up the Creator template from WD would be great [08:53:16] (03CR) 10Adrian Lang: [C: 032] Handle specific parse errors returned by the API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121087 (owner: 10Henning Snater) [08:53:45] (03Merged) 10jenkins-bot: Handle specific parse errors returned by the API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121087 (owner: 10Henning Snater) [09:00:46] (03PS8) 10Adrian Lang: Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:00:48] (03PS9) 10Adrian Lang: Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:03:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:07:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:15:19] (03PS9) 10Adrian Lang: Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:16:23] (03PS10) 10Adrian Lang: Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:17:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:17:38] (03CR) 10Adrian Lang: [C: 032] Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:18:02] (03CR) 10Adrian Lang: [C: 032] Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:18:16] (03CR) 10jenkins-bot: [V: 04-1] Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:21:42] (03CR) 10Adrian Lang: [V: 032] Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:22:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:27:24] (03PS10) 10Adrian Lang: Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:27:27] (03PS11) 10Adrian Lang: Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:33:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:37:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:39:35] (03CR) 10Adrian Lang: [C: 032] Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:39:44] (03CR) 10Adrian Lang: [C: 032] Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:40:04] (03Merged) 10jenkins-bot: Counteract mw.ext.* files being removed in sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118968 (owner: 10Henning Snater) [09:40:09] (03Merged) 10jenkins-bot: Reject ApiBasedValueParser/Formatter promise with a single parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121095 (owner: 10Henning Snater) [09:45:30] Tobi_WMDE, aude: dialing in for the daily [09:49:06] DanielK_WMDE_: one sec [09:49:10] we almost forgot [09:50:11] send us email [09:52:35] DanielK_WMDE_: we failed to hangout :-( [09:52:45] o_O [09:53:04] aude: wtf? i used the link from the calendar... [09:53:06] strange. [09:53:24] can you send us a short email if you have something to share or have questions for somebody else [09:53:38] i can just tell you here & now :) [09:54:06] DanielK_WMDE_: that's ok. [09:54:09] DanielK_WMDE_: i often get the error [09:54:16] could be Thiemo_WMDE will poke you [09:54:27] aude: I tried and hangout worked.. [09:54:35] hu? [09:54:37] * aude needs to be invited on all my gmail accounts [09:54:57] i'm working on page_pürops (bug 58032) and on 62644 [09:54:58] probably or figure out how to have hangout use the right one [09:55:00] aude: should I? [09:55:09] aude: you'll have to use the wmde account, yea [09:55:23] no idea, but normally i don't do hangout [09:55:27] aude: I don't have your gmail address.. :-( [09:55:33] not important [09:55:37] ok [09:55:47] we'll use my aptop next time again [09:56:08] Tobi_WMDE: (in case this got lost in babble): i'm working on page_props (bug 58032) and on snak validation (bug 62644). [09:56:15] i have to click "yes" [09:56:23] i'mgoing then can click join [09:56:25] DanielK_WMDE_: great [09:56:56] aude, Thiemo_WMDE: let me know if you want to talk about error localization of entity info stuff [09:56:58] aude: heh [09:57:12] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/Diff] - 10https://gerrit.wikimedia.org/r/122318 (owner: 10Siebrand) [09:57:15] uh, are you still trying to get the hangout going, or is the daily over by nopw? [09:57:16] DanielK_WMDE_: i have some patches, one in data values/value formatters [09:57:19] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/Diff] - 10https://gerrit.wikimedia.org/r/122318 (owner: 10Siebrand) [09:57:20] * DanielK_WMDE_ has closed the window [09:57:26] DanielK_WMDE_: done, but for next time :) [09:57:58] DanielK_WMDE_: https://github.com/DataValues/Common/pull/7 [09:58:01] aude: yea, i'll do reviews. might need to ping me about stuff on github, i often miss it [09:58:07] * DanielK_WMDE_ wants a unified dashboard [10:15:05] when does WD wil be used for linking projects? [10:15:08] i.e. WP <-> Commons <-> WS [10:15:30] now I have to add templates and links [10:15:43] and filling up the Creator template on Commons from WD would be great [10:16:49] also I'd like to create a property for Wikisource category, similar to https://www.wikidata.org/wiki/Property:P373 [10:19:02] (03PS1) 10Henning Snater: Fix wikibase expert store registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122344 [10:22:21] [13ValueView] 15adrianlang created 06fixUnitTests (+1 new commit): 02http://git.io/q6PgRg [10:22:21] 13ValueView/06fixUnitTests 14bb0dd3b 15Adrian Lang: Fix ValueView construction in test cases [10:23:42] [13ValueView] 15adrianlang opened pull request #41: Fix ValueView construction in test cases (06master...06fixUnitTests) 02http://git.io/cJPwJQ [10:23:57] hello? anyone alive here? [10:24:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122344 (owner: 10Henning Snater) [10:25:05] (03PS3) 10Aude: Add snak variation css class in non-JS claim html [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 [10:25:12] (03CR) 10Adrian Lang: [C: 032] Fix wikibase expert store registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122344 (owner: 10Henning Snater) [10:25:54] (03CR) 10Aude: "added the parameter." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 (owner: 10Aude) [10:26:14] (03Merged) 10jenkins-bot: Fix wikibase expert store registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122344 (owner: 10Henning Snater) [10:29:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 (owner: 10Aude) [10:30:00] how do i debug broken phpunit tests in phpstorm? it keeps telling me it doesn't find files that exist. [10:33:25] (03CR) 10Adrian Lang: [C: 032] "The template is used automagically on widget initialization. The snakValue emptying needs to go away, though, in order to actually reuse t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 (owner: 10Aude) [10:33:53] (03Merged) 10jenkins-bot: Add snak variation css class in non-JS claim html [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121668 (owner: 10Aude) [10:35:05] (03PS1) 10Henning Snater: Fixed expert store reference in snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122345 [10:35:45] [13ValueView] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/DUxz7Q [10:35:45] 13ValueView/06master 14cf6141f 15snaterlicious: Merge pull request #41 from wmde/fixUnitTests... [10:37:15] [13ValueView] 15snaterlicious 04deleted 06rnexpertfactory at 14ebb2f61: 02http://git.io/AiYfaA [10:37:23] [13ValueView] 15snaterlicious 04deleted 06dvjs04 at 14a25ead0: 02http://git.io/b0mMUw [10:37:35] wtf, ValueFormatters FormattingException is in ValueParsers namespace? [10:37:46] and is in interfaces? [10:39:42] DanielK_WMDE_: where would you put FormattingException? in data values common? or in data values interfaces? [10:39:47] or JeroenDeDauw or Tobi_WMDE ? [10:40:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122345 (owner: 10Henning Snater) [10:40:26] "common" seems like a garbage bin of miscellanous [10:40:58] aude: it's on the correct place, file wise, the NS is just wrong [10:41:05] ok, interfaces [10:41:28] aude: do you find it strange it is in interfaces? [10:41:47] it's not an interface, but is a general thing [10:42:45] aude: it is an interface, or rarther part of one, though not in the sense of the language interface construct [10:43:07] ok [10:43:56] [13Interfaces] 15filbertkm created 06exception (+1 new commit): 02http://git.io/_w5ERg [10:43:56] 13Interfaces/06exception 14d28acf1 15aude: Fix namespace of FormattingException [10:44:09] [13Interfaces] 15filbertkm opened pull request #2: Fix namespace of FormattingException (06master...06exception) 02http://git.io/VgjcBw [10:44:33] [13Interfaces] 15JeroenDeDauw 04deleted 06exception at 14d28acf1: 02http://git.io/mKkuGw [10:45:02] Funnily enough this is not a breaking change... [10:45:12] suppose not [10:45:12] The class could not be loaded before, so it never worked [10:45:18] yep [10:49:03] [13Interfaces] 15filbertkm created 06throws (+1 new commit): 02http://git.io/rvIrEA [10:49:03] 13Interfaces/06throws 142561ca0 15aude: add @throws FormattingException in ValueFormatters interface [10:49:18] [13Interfaces] 15filbertkm opened pull request #3: add @throws FormattingException in ValueFormatters interface (06master...06throws) 02http://git.io/2ix3Xg [10:50:10] would we put FormattingException in the ValueFormatters\Exceptions namespace? [10:50:37] (03CR) 10Adrian Lang: [C: 032] Fixed expert store reference in snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122345 (owner: 10Henning Snater) [10:51:05] (03Merged) 10jenkins-bot: Fixed expert store reference in snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122345 (owner: 10Henning Snater) [10:51:08] aude: depends on how many exceptions there are - in this case it is good to stay consistent with ValueParsers and the like [10:51:17] ok [10:53:03] [13Common] 15filbertkm pushed 1 new commit to 06mismatch: 02http://git.io/Gdc25A [10:53:03] 13Common/06mismatch 143a95e47 15aude: extend ValueFormatters FormattingException [10:57:19] [13Interfaces] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/I2qTOQ [10:57:19] 13Interfaces/06master 140e7aa59 15Jeroen De Dauw: Merge pull request #3 from DataValues/throws... [10:57:39] [13Interfaces] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/Gztrpw [10:57:39] 13Interfaces/06master 142edcc62 15Jeroen De Dauw: Update Interfaces.php [10:59:15] [13Interfaces] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/n4_v7g [10:59:15] 13Interfaces/06master 14d1ad9c7 15Jeroen De Dauw: Update README.md [10:59:32] [13Interfaces] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/5wST7w [10:59:32] 13Interfaces/06master 14a91a4f6 15Jeroen De Dauw: Update FormattingException.php [10:59:53] aude: https://github.com/DataValues/Interfaces/commits/master you fine with a tag being created or did you spot anything else amis? [11:02:24] aude: Tobi_WMDE: are we still doing any reployment stuff that does not use the build? I'm asking since if not, we can get rid of the old repos on gerrit [11:02:36] siebrand just wasted some time on doing this https://gerrit.wikimedia.org/r/#/c/122318/ [11:02:55] Also does not merge with master on the actual repo, since they where not kept in sync [11:04:47] JeroenDeDauw: go ahead [11:05:30] and yeah, we should either keep the gerrit repos in sync (if we want translations) or not have them [11:06:29] JeroenDeDauw: we can get rid of gerrit repos if there are no translations [11:07:42] Tobi_WMDE: please put 58032 (page_props) on review [11:08:08] DanielK_WMDE_: querying? [11:08:34] or just "allow to be queried" [11:09:43] aude: hm? [11:09:55] where is the patch for 58032? [11:10:08] https://gerrit.wikimedia.org/r/#/c/122349/ [11:10:15] oh, ok [11:10:16] bugzilla links there [11:10:52] (03CR) 10Aude: [C: 04-1] "per concerns and feedback in patchset 17" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [11:14:19] JeroenDeDauw: they can go away. :) [11:15:11] [13ValueView] 15JeroenDeDauw 04deleted 06fixUnitTests at 14bb0dd3b: 02http://git.io/0tUIFA [11:15:21] Tobi_WMDE: data types, for example, has a bunch of translations [11:15:57] i suggest we keep a mirror, if we want to accept new translations and then would need to sync w/ github once in a while [11:15:58] aude: JeroenDeDauw: better keep them in sync then? [11:16:14] ones that have trivial or no translations, then no need [11:16:18] aude: hoow do we do this? [11:16:21] like Diff [11:17:09] we'd just push changes to github (translations) and maybe automatically sync to gerrit daily or something [11:17:19] they shouldn't conflict [11:17:30] jeroen does this with smw, it hink [11:18:18] Yeah... [11:18:22] Tobi_WMDE: i suppose part of https://bugzilla.wikimedia.org/show_bug.cgi?id=63113 will be to see what has i18n, if we care about it then convert [11:18:28] if not, get rid of it [11:18:33] My "git pull" command alias for SMW includes doing a sync [11:19:31] Adrian_WMDE: can https://bugzilla.wikimedia.org/show_bug.cgi?id=62822 be closed? [11:20:38] [13Interfaces] 15JeroenDeDauw tagged 060.1.3 at 06master: 02http://git.io/hpzFfQ [11:23:54] aude: are you able to ssh to the builder instance? [11:24:21] haven't tried recently [11:24:23] (03PS5) 10Thiemo Mättig (WMDE): [WIP] Properly red-link deleted properties and items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [11:24:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Properly red-link deleted properties and items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [11:24:35] aude: there was no build today [11:24:46] and I cannot connect to it [11:24:50] [13DataValuesJavascript] 15adrianlang created 06errorTypos (+1 new commit): 02http://git.io/bJUjFg [11:24:50] 13DataValuesJavascript/06errorTypos 14043d2e8 15Adrian Lang: Fix typos in Time.validate error messages [11:24:57] :( [11:25:08] aude: I restarted the instance already [11:25:11] but still no luck [11:25:22] i can try [11:25:53] aude: yes please try. perhaps I'm on the wrong bastion or something [11:26:03] [13DataValuesJavascript] 15adrianlang opened pull request #38: Fix typos in Time.validate error messages (06master...06errorTypos) 02http://git.io/jRAeDA [11:26:37] "rpcbind: Cannot open '/run/rpcbind/rpcbind.xdr' file for reading, errno 2 (No such file or directory)" [11:26:46] says console output [11:26:57] mount.nfs: Failed to resolve server labstore.svc.eqiad.wmnet: Temporary failure in name resolution [11:27:02] aude: that's more than it sais for me [11:27:16] on wikitech, you can see console output [11:27:58] Tobi_WMDE: Yes, I think so. We need https://github.com/wmde/ValueView/pull/37, though [11:27:58] aude: I see [11:28:35] Adrian_WMDE: this is minor, right? [11:28:42] I mean non-breaking [11:28:55] Yes [11:28:55] no idea if that's something we can fix [11:29:05] probably need to ask in labs channel [11:29:05] (03PS6) 10Thiemo Mättig (WMDE): [WIP] Properly red-link deleted properties and items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [11:29:16] when folks are around [11:29:28] aude: yeah, we should [11:29:29] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [11:30:08] i assume it's puppetized perfectly so last resort, make new instance [11:30:28] aude: yes. and then fingers crossed [11:34:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [11:34:49] [13ValueView] 15adrianlang created 06unitTests (+1 new commit): 02http://git.io/zptvwA [11:34:49] 13ValueView/06unitTests 1425241ec 15Adrian Lang: Add CompletenessTest to ValueView test, add ValueView tests [11:35:50] [13ValueView] 15adrianlang opened pull request #42: Add CompletenessTest to ValueView test, add ValueView tests (06master...06unitTests) 02http://git.io/mc3Nyw [12:00:43] Adrian_WMDE: please actually close the door [12:00:50] ty [12:00:57] np [12:08:48] [13ValueView] 15adrianlang 04force-pushed 06dontPassAutoCharacteristics from 14ab7ad75 to 14e52740e: 02http://git.io/Fcd9aQ [12:08:49] 13ValueView/06dontPassAutoCharacteristics 14e52740e 15Adrian Lang: Handle auto mode on listrotators in TimeInput... [12:15:56] [13ValueView] 15adrianlang 04force-pushed 06dontPassAutoCharacteristics from 14e52740e to 14442450f: 02http://git.io/Fcd9aQ [12:15:56] 13ValueView/06dontPassAutoCharacteristics 14442450f 15Adrian Lang: Handle auto mode on listrotators... [12:22:38] [13ValueView] 15adrianlang 04force-pushed 06dontPassAutoCharacteristics from 14442450f to 144bf0205: 02http://git.io/Fcd9aQ [12:22:38] 13ValueView/06dontPassAutoCharacteristics 144bf0205 15Adrian Lang: Handle auto mode on listrotators... [12:35:05] (03PS1) 10Tobias Gritschacher: Fix broken browsertest scenario [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122355 [12:36:34] (03PS2) 10Tobias Gritschacher: Fix broken browsertest scenario [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122355 [12:41:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122355 (owner: 10Tobias Gritschacher) [12:43:05] when does WD wil be used for linking projects? [12:43:09] i.e. WP <-> Commons <-> WS [12:43:18] and filling up the Creator template on Commons from WD would be great [12:43:26] also I'd like to create a property for Wikisource category, similar to https://www.wikidata.org/wiki/Property:P373 [12:45:54] Tobi_WMDE: statements_string:39 does not work for me [12:46:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122355 (owner: 10Tobias Gritschacher) [12:50:20] Adrian_WMDE: seems the div which contains the string-value does not have a class named "valueview-instaticmode" after a reload anymore [12:54:33] (03PS1) 10Tobias Gritschacher: Fix wrong xpath in browsertest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122397 [12:58:00] (03Abandoned) 10Adrian Lang: Fix wrong xpath in browsertest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122397 (owner: 10Tobias Gritschacher) [12:58:09] (03CR) 10Adrian Lang: [C: 032] Fix broken browsertest scenario [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122355 (owner: 10Tobias Gritschacher) [12:58:35] (03Merged) 10jenkins-bot: Fix broken browsertest scenario [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122355 (owner: 10Tobias Gritschacher) [12:59:38] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122397 (owner: 10Tobias Gritschacher) [12:59:43] (03PS19) 10Daniel Kinzler: (bug 40157) store entity status in page_props [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [13:05:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [13:07:28] JeroenDeDauw: when/how does packagist know about interfaces 0.1.3 ? [13:08:29] "Existing packages without auto-updating (GitHub hook) will be crawled once a day for updates" [13:09:22] Tobi_WMDE: ? [13:09:54] aude: should be immediately [13:10:00] it's not [13:10:12] https://packagist.org/packages/data-values/interfaces [13:10:16] where is 0.1.3 ? [13:10:42] aude: now. ;) [13:10:48] huh [13:10:57] what did you do? [13:11:18] pushed the button.. [13:11:28] what button? [13:11:32] aude: sometimes it does not recoognize immediately [13:11:43] can haz button? :) [13:12:10] JeroenDeDauw has credentials :P [13:12:16] :/ [13:12:23] Tobi_WMDE: https://github.com/wmde/ValueView/tree/drawValueView [13:12:26] [13ValueView] 15adrianlang created 06drawValueView (+1 new commit): 02http://git.io/o9UrDQ [13:12:26] 13ValueView/06drawValueView 142378ea3 15Adrian Lang: Correctly draw a ValueView with reused DOM [13:13:34] would be nice to be able to press wikibase button sometimes :) [13:13:54] like when we have to make a hotfix / make new build [13:14:15] annoying to wait 5+ minutes for packagist to update [13:15:03] (03PS7) 10Thiemo Mättig (WMDE): [WIP] Properly red-link deleted properties and items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [13:20:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [13:21:13] [13Common] 15filbertkm pushed 1 new commit to 06mismatch: 02http://git.io/6H_TjQ [13:21:13] 13Common/06mismatch 147b78d26 15aude: Update data-values/interfaces in composer.json [13:22:38] [13DataValuesJavascript] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/xG9Bbw [13:22:38] 13DataValuesJavascript/06master 1420bbff8 15thiemowmde: Merge pull request #38 from wmde/errorTypos... [13:23:26] aude: DanielK_WMDE_: https://bugzilla.wikimedia.org/63299 [13:25:02] Adrian_WMDE: thanks [13:25:14] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/dh4tmg [13:25:14] 13jenkins-job-builder-config/06master 144c53b21 15Tobias Gritschacher: Support BROWSER_TIMEOUT variable in browsertests [13:26:16] aude, Tobi_WMDE, Adrian_WMDE would someone be so kind to answer me? [13:27:17] yannf: i don't know more than what is in the development plan https://www.wikidata.org/wiki/Wikidata:Development_plan [13:27:39] can't answer when [13:27:47] yannf: that's something that Lydia_WMDE can answer. she will be back wednesday [13:28:10] also I'd like to create a property for Wikisource category, similar to https://www.wikidata.org/wiki/Property:P373 [13:28:48] maybe ask on project chat where more people might see the question? [13:28:49] yannf: for creating properties please refer tho the wikidata community. they have a process for requesting properties [13:29:11] hmm [13:30:17] yannf: see here: http://www.wikidata.org/wiki/Wikidata:Property_proposal [13:30:40] Tobi_WMDE, thanks [13:31:03] yannf: nP [13:32:07] https://github.com/DataValues/Common/pull/7 if anyone would like to review [13:34:07] Adrian_WMDE: want to make a pull request out of it? [13:34:25] (03PS1) 10Thiemo Mättig (WMDE): Don't check permissions twice in ApiWikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122403 [13:34:56] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/UR7Gcg [13:34:56] 13ValueView/06master 149d1a064 15Tobi Gritschacher: Merge pull request #37 from wmde/dontPassAutoCharacteristics... [13:35:18] (03CR) 10Adrian Lang: "*nudge* This still needs to get in before we branch. It's been sitting here for nearly two months :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [13:38:36] [13ValueView] 15tobijat 04deleted 06unitTests at 1425241ec: 02http://git.io/R1wsEA [13:39:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122403 (owner: 10Thiemo Mättig (WMDE)) [13:40:20] (03CR) 10Aude: [C: 04-1] "I'm not sure the spacing option is handled correctly." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [13:40:30] Adrian_WMDE: any idea ^? [13:41:25] (03CR) 10Adrian Lang: "That's exactly how the front-end worked, see https://www.wikidata.org/wiki/Q4115189." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [13:42:39] (03CR) 10Aude: "I see "52°12'29"N, 0°7'21"E" -- with a space" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [13:43:31] do we need OPT_SEPARATOR_SYMBOL ? [13:44:09] https://www.wikidata.org/wiki/Wikidata:Property_proposal/Sister_projects#Wikisource_category done [13:45:32] (03CR) 10Adrian Lang: "Ah, but not between the N and the comma, but between the comma and the following coordinate." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [13:46:29] (03CR) 10Aude: "that's what i meant :) we are missing a space and not sure where/how that should be handled" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [13:46:31] [13ValueView] 15tobijat opened pull request #43: Correctly draw a ValueView with reused DOM (06master...06drawValueView) 02http://git.io/EseKkA [13:46:55] Adrian_WMDE: done: https://github.com/wmde/ValueView/pull/43 [13:47:01] [13ValueView] 15tobijat closed pull request #43: Correctly draw a ValueView with reused DOM (06master...06drawValueView) 02http://git.io/EseKkA [13:48:53] we had latLongCombinator: ', ', [13:49:14] Adrian_WMDE: to be consistent do we do the same in php formatter? [13:52:53] (03CR) 10Aude: "js formatter has:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [13:53:13] Tobi_WMDE: is addshore around today or tomorrow? [13:53:58] aude: did not hear from him for a while.. he was in italy last week/weekend.. not sure if he's back [13:54:05] ok [13:54:17] aude: what would you need? [13:54:36] see comments https://gerrit.wikimedia.org/r/#/c/120314/ [13:54:56] i could make a follow up, but wouldn't mind feedback [13:55:37] (03CR) 10Aude: "i suppose not an issue with this patch, but an issue with the formatters in the geo component which should be addressed ideally before bra" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [14:04:33] A question to Wikibase JS devs: Has the "entityviewcreate" event been removed during the last deployment? [14:05:35] We removed one, can't exactly remember which [14:05:55] Tobi_WMDE: ^ [14:07:54] (03PS1) 10Thiemo Mättig (WMDE): Replace unclear "oops" and "can't happen" with empty LogicExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 [14:08:21] hoo: Thanks. I belive it's this one because I can't find it in the current code base. Do you know an equivalent event/hook? [14:08:40] (it's for authority-control gadget) [14:09:46] aude: merge? https://gerrit.wikimedia.org/r/#/c/120314/ [14:10:00] Tobi_WMDE: merge? https://gerrit.wikimedia.org/r/#/c/122124/1 [14:10:02] * hoo hides fast [14:10:25] Tpt: Depends on what exactly you need... for that purpose the wikibase.domready mw.hook might be enough [14:10:26] (03CR) 10Daniel Kinzler: (bug 62824) generic localization for API errors. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [14:10:37] but that one is supposed to die at some point as well [14:11:07] ... away now :P [14:11:33] hoo|away: Thanks. i'll try to see it it works with this hook [14:11:50] didn't look at the code, just guessed :P [14:12:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [14:13:32] (03PS7) 10Daniel Kinzler: (bug 62824) generic localization for API errors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 [14:13:49] (03CR) 10jenkins-bot: [V: 04-1] (bug 62824) generic localization for API errors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [14:14:24] ooorrrr! [14:14:30] uh [14:14:37] what happened to Wikibase.i18n.php? [14:15:11] :) [14:15:33] :o [14:16:24] ah, we switched to json based i18n? [14:16:27] when did that happen? [14:16:28] yes [14:16:32] this weekend for wikibase [14:17:20] apparently i didn't get the memo [14:17:20] when was this discussed? [14:17:20] there's an rfc [14:17:20] it's being done for all extensions and core [14:17:24] https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format [14:17:53] means no single giant i18n file that gerrit can't load sometimes [14:18:21] means we can push out more incremental localisation updates when rebuilding in production [14:18:37] which equals faster cache and more robust cache rebuild [14:18:37] yes, i wanted one file per language when we discussed i18n for extensions back in the day.# [14:18:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [14:18:42] :) [14:18:45] and something that can't contain `rm -rf` [14:18:48] nice to see it happening [14:18:51] yeah [14:18:53] just means tons of conflicts [14:19:02] it now takes ~10-15 minutes to rebuild cache [14:19:18] before it too more than an hour sometimes, while we sit around and wikipedia is broken [14:19:24] how long did it take before? [14:19:26] and can't make it faster [14:19:34] an hour [14:19:44] Abraham_WMDE: how are we doing the wishlist call? [14:19:51] aude: ah, nice [14:20:05] i'm sure we'll get it faster and even more incremental [14:21:10] (03PS3) 10Aude: Use correct options for GlobeCoordinateFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [14:21:24] (03PS4) 10Aude: Use correct options for GlobeCoordinateFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [14:21:26] (03PS1) 10Aude: Specify geo spacing level in value formatter builders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122416 [14:22:23] (03PS6) 10Thiemo Mättig (WMDE): General Wikibase API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [14:24:16] (03CR) 10Aude: "without this, we get:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122416 (owner: 10Aude) [14:25:05] (03PS8) 10Daniel Kinzler: (bug 62824) generic localization for API errors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 [14:25:52] (03CR) 10Siebrand: [C: 031] "Left inline comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [14:26:16] DanielK_WMDE_: see the other IRC channel… [14:26:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [14:26:34] DanielK_WMDE_: give my your phone number, we'll call you the "old" way [14:27:06] * aude knows no "old" way :) [14:30:29] (03PS9) 10Siebrand: Generic localization for API errors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [14:32:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [14:35:49] (03PS6) 10Aude: Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [14:37:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [14:40:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122416 (owner: 10Aude) [14:45:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [14:49:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [14:55:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [14:57:27] (03PS1) 10Aude: Add coverage of snak variation css in ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122421 [14:57:50] (03PS2) 10Aude: Add test coverage of snak variation css in ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122421 [14:58:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [15:04:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122421 (owner: 10Aude) [15:10:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122421 (owner: 10Aude) [15:27:51] aude: where can I fiind out the instance IP (not public) of wikidata.beta.wmflabs.org? [15:28:12] the 10.something address [15:28:49] wikitech instance config [15:29:00] errr [15:29:09] aude: is this under wikidata-dev? [15:29:12] no [15:29:12] no [15:29:14] I guess not [15:29:15] but probably somewhere [15:29:33] could not fnd it [15:29:48] but I remember I saw a list of all instance ips somewhere sometime [15:30:08] beta is not configured there [15:30:55] hashar_: do you know where I can find out the instance IP (not public) of wikidata.beta.wmflabs.org? [15:32:09] i see some natfix.pp things in puppet under beta module [15:32:21] aude? haz link? [15:32:32] http://git.wikimedia.org/tree/operations%2Fpuppet.git/b330837402dd4df6d74d67aa29df0014f07771f5/modules%2Fbeta%2Fmanifests [15:32:50] Tobi_WMDE: sure [15:32:59] deployment-cache-text02.eqiad.wmflabs [15:33:03] which is the text varnish [15:33:29] hashar_: just found it! [15:33:34] thx [15:33:39] seems like it is not very happy :/ [15:33:44] hashar_: IPs changed recently, right? [15:33:48] yeah [15:34:03] beta is now running in EQIAD [15:34:03] ok, need to apply the natfix for our jenkins [15:45:15] (03PS3) 10Daniel Kinzler: (bug 63068) Show claims on property pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119246 [15:45:27] (03CR) 10jenkins-bot: [V: 04-1] (bug 63068) Show claims on property pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119246 (owner: 10Daniel Kinzler) [15:46:09] (03CR) 10Daniel Kinzler: [C: 04-1] "Needs rebase for json based i18n" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119246 (owner: 10Daniel Kinzler) [15:50:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119246 (owner: 10Daniel Kinzler) [16:11:17] (03PS7) 10Aude: Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [16:13:10] (03PS8) 10Aude: Use DataValueMismatchException for Snak formatting [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 [16:18:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [16:21:10] <^d> JeroenDeDauw: ack on the e-mail re: repo deletions. Will get to it this afternoon. [16:21:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121678 (owner: 10Aude) [16:25:44] ^d: i think we'll keep data types, but it will be a mirror of what we have on github [16:25:53] the others for data values we don't need [16:26:22] datatypes has enough i18n that we should sync that for i18n updates [16:45:51] hello, is there a way we could retreive Images from wikidata using its api, to build something like: http://tools.wmflabs.org/reasonator/?q=Q535, although i have worked with commons api but with wikidata i was unable to figure out? [17:16:59] ^d: ty [17:22:19] (03CR) 10Aude: [C: 04-1] "looks much better but see comments" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [18:01:21] (03PS3) 10Bene: DNM create the user interface to edit badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122224 [18:03:40] (03CR) 10Aude: [C: 032] "looks good... good first step for localized messages from exception-related errors" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [18:04:12] (03Merged) 10jenkins-bot: Generic localization for API errors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler) [18:06:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122224 (owner: 10Bene) [18:14:18] hoo|away: really away? [18:17:56] (03PS7) 10Thiemo Mättig (WMDE): General Wikibase API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [18:18:09] (03CR) 10jenkins-bot: [V: 04-1] General Wikibase API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [18:22:28] (03PS2) 10Thiemo Mättig (WMDE): Replace unclear "oops" and "can't happen" with empty LogicExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 [18:22:43] (03CR) 10jenkins-bot: [V: 04-1] Replace unclear "oops" and "can't happen" with empty LogicExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [18:23:03] HelloIs there [18:23:06] Hello [18:23:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [18:23:38] Is ther a problem with wikidata query ? It seems down currently [18:24:13] Shonagon: try https://wdq.wmflabs.org [18:25:27] thanks but the only answer on web interface is "Loading..." [18:27:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [18:28:22] Shonagon: doesn't work for me neither [18:28:38] perhaps you have tu wait until Magnus fixes the tool [18:29:30] yes I will wait. Thanks benestar [18:30:07] (03PS8) 10Thiemo Mättig (WMDE): General Wikibase API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [18:32:30] (03PS3) 10Thiemo Mättig (WMDE): Replace unclear "oops" and "can't happen" with empty LogicExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 [18:33:12] [13DataTypes] 15siebrand opened pull request #13: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/tq1YBw [18:35:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [18:36:22] Lydia_WMDE: hi [18:36:35] benestar: hey [18:36:51] Lydia_WMDE: how many items will be able to become badges? [18:37:04] more than ten/fifty/hundred/...? [18:37:31] benestar: you mean how many potential badges? or how many badges a single sitelink will have? [18:37:42] [13ValueView] 15siebrand opened pull request #44: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/dG-rvQ [18:38:09] Lydia_WMDE: how many potential [18:38:26] i expect something between 100 and 200 at the moment [18:38:31] I am not sure if we should store them in a config variable or create an api module for that purpose [18:38:34] at the beginning maybe 25 to 50 [18:39:10] ok, that's more than I expected... [18:39:50] Lydia_WMDE: I am not sure if it makes sense to store 200 badgs in the config... [18:40:17] might be yeah - i can't really judge that though [18:40:47] I think more than 20 badegs are too much for the config [18:41:03] we then would rather need to store it in the items themselves [18:41:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [18:46:51] DanielK_WMDE: if you're around see benestar's comments above please [18:54:00] Lydia_WMDE: ah, and got a nother question [18:54:09] shoot [18:54:10] :D [18:54:12] should the badges go into another column in the sitelinks table? [18:54:27] or should they be integrated into the page's column [18:54:29] the table as a whole should die [18:54:56] for now adding them to the sitelink column is good i think [18:55:01] hehe, until when? [18:55:04] and we'll have to redo it with the UI redesign [18:55:18] i want something similar to what reasonator does [18:55:24] with a sidebar [18:55:43] but that isn't going to happen right now [19:05:06] Hola. [19:05:44] Any Wikidata devs still active? Please review https://github.com/wmde/ValueView/pull/44 and https://github.com/wmde/DataTypes/pull/13 [19:06:52] (03PS8) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [19:08:01] siebrand: thanks for doing that [19:09:14] (03CR) 10Thiemo Mättig (WMDE): Replace unclear "oops" and "can't happen" with empty LogicExceptions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [19:11:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [19:11:42] (03CR) 10Thiemo Mättig (WMDE): "@Adrian: You are right. I tried to split this patch, see Iff03571f5115e2f0ce8d983adafbb3a71388c27a and Ie6acf74fdb63b701054fd300bfb3ff3e4a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [19:17:23] (03CR) 10Siebrand: Replace unclear "oops" and "can't happen" with empty LogicExceptions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [19:18:23] (03CR) 10Siebrand: [C: 031] Replace unclear "oops" and "can't happen" with empty LogicExceptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [19:19:09] Lydia_WMDE: There may be more repos. I haven't looked into detail in the WIkidata repo. [19:19:44] siebrand: https://www.mediawiki.org/wiki/Wikibase/Components has a list of them all [19:20:14] Lydia_WMDE: Ah, that's what I was looking for. Thanks. [19:20:19] :) [19:26:27] [13ValueView] 15filbertkm closed pull request #44: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/dG-rvQ [19:26:28] aude: https://github.com/wmde/WikibaseQuery/pull/4 [19:26:32] ok [19:27:10] (03PS9) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [19:28:45] [13DataTypes] 15filbertkm closed pull request #13: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/tq1YBw [19:28:46] i'll let jeroen or tobi tag these with a new version [19:29:19] aude: https://github.com/DataValues/DataValues/pull/3 [19:29:26] [13DataValues] 15siebrand opened pull request #3: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/OTpywA [19:29:27] ok [19:31:18] aude: https://github.com/wmde/Ask/pull/4 [19:31:26] [13Ask] 15siebrand opened pull request #4: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/BfnVaw [19:32:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [19:33:34] aude: https://github.com/wmde/Diff/pull/6 [19:33:40] [13Diff] 15siebrand opened pull request #6: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/JEXl7A [19:34:10] Rectification : Wikidata Query as API-JSON works fine, but not the web interface. [19:34:11] waiting for the tests [19:35:16] aude: https://github.com/wmde/WikibaseDataModel/pull/33 [19:35:23] [13WikibaseDataModel] 15siebrand opened pull request #33: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/cM_gnQ [19:35:24] aude: That should take care of things. [19:36:23] thanks! :) [19:36:46] aude: I'll get to Wikibase at some point. [19:37:03] aude: I did about 130 extensions today. About 60% in in total. [19:37:08] [13Ask] 15filbertkm closed pull request #4: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/BfnVaw [19:37:48] [13DataValues] 15filbertkm closed pull request #3: Migrate to JSON i18n (06master...06json-i18n) 02http://git.io/OTpywA [19:37:50] i think you already did wikibase [19:37:57] unless i missed something [19:38:22] siebrand: Hoi! [19:38:32] multichill: Hola, Maarten. [19:38:48] Ik zie dat WMNL een nieuw bestuur heeft. [19:40:08] multichill: klopt. [19:43:28] (03CR) 10Daniel Kinzler: Check the content model of pages in EntityPerPageBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120857 (owner: 10Hoo man) [19:49:23] [13WikibaseDataModelSerialization] 15Tpt opened pull request #62: Adds hash validation to snaks and references deserialization (06master...06hashValidation) 02http://git.io/fzZJZA [19:50:26] [13Diff] 15filbertkm pushed 2 new commits to 06master: 02http://git.io/DHBotw [19:50:26] 13Diff/06master 140735e0f 15Siebrand Mazeland: Migrate to JSON i18n... [19:50:26] 13Diff/06master 14197f322 15Katie Filbert: Merge pull request #6 from siebrand/json-i18n... [19:53:49] (03PS10) 10Thiemo Mättig (WMDE): Reuse Entity info array whenever possible in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 [19:58:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (owner: 10Thiemo Mättig (WMDE)) [20:05:29] [13WikibaseDataModel] 15filbertkm pushed 2 new commits to 06master: 02http://git.io/7tJFwA [20:05:29] 13WikibaseDataModel/06master 1450c87d7 15Siebrand Mazeland: Migrate to JSON i18n... [20:05:29] 13WikibaseDataModel/06master 14a507744 15Katie Filbert: Merge pull request #33 from siebrand/json-i18n... [20:23:50] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122536 (owner: 10L10n-bot) [21:01:46] (03CR) 10Daniel Kinzler: "@Siebrand I don't know if PHPStorm has documentation on that - this is just what it does when you ask it to fill in the phpdoc comment." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [21:03:40] (03CR) 10Daniel Kinzler: Replace unclear "oops" and "can't happen" with empty LogicExceptions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122411 (owner: 10Thiemo Mättig (WMDE)) [21:05:35] (03CR) 10Daniel Kinzler: [C: 032] General Wikibase API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [21:06:19] (03Merged) 10jenkins-bot: General Wikibase API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [21:07:13] (03CR) 10Daniel Kinzler: [C: 032] Add test coverage of snak variation css in ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122421 (owner: 10Aude) [21:07:42] (03Merged) 10jenkins-bot: Add test coverage of snak variation css in ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122421 (owner: 10Aude) [21:07:57] (03CR) 10Daniel Kinzler: [C: 032] Specify geo spacing level in value formatter builders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122416 (owner: 10Aude) [21:08:41] (03CR) 10Daniel Kinzler: [C: 032] Don't check permissions twice in ApiWikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122403 (owner: 10Thiemo Mättig (WMDE)) [21:08:50] (03CR) 10jenkins-bot: [V: 04-1] Don't check permissions twice in ApiWikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122403 (owner: 10Thiemo Mättig (WMDE))