[03:45:33] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "No need to waste computing time of a free service we use. Also, more jobs is longer waiting time" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120515 (owner: 10Addshore)
[04:27:37] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] Clean up Client Api Module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121705 (owner: 10Addshore)
[04:28:26] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: Merge "Remove space thats in the wrong place" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121681 (owner: 10Christopher Johnson (WMDE))
[05:29:10] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "No obvious design issues spotted" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120775 (owner: 10Daniel Kinzler)
[08:57:35] <Glaisher2>	 admin?
[09:00:42] <sjoerddebruin>	 Yes Glaisher2, can I help you? :)
[09:00:49] <Glaisher2>	 Revi:  is on it
[09:01:03] <sjoerddebruin>	 Oh. :P
[09:01:20] <Revi>	 Glaisher2: Why it needs revdel?
[09:01:27] <Glaisher2>	 defamatory content?
[09:01:41] <Revi>	 hmm, ok.
[09:02:20] <Revi>	 All that IP?
[09:03:01] <Revi>	 Glaisher2: ^
[09:03:30] <Glaisher2>	 Revi:  not only IPs.
[09:03:34] <Glaisher2>	 there's an account edit too
[09:03:54] <Glaisher2>	 tbh. 41. doesn't look like defamatory content
[09:03:57] <Revi>	 oh....
[09:05:02] <Revi>	 revdeling all IP, Ahma-h22 , Moealmaw, Ebraheem010 Enganasr's edits
[09:05:13] <Revi>	 also Geezawy
[09:05:42] <Glaisher2>	 Revi:  some seems to be valid reverts of the edits
[09:05:48] <Revi>	 hmmmm
[09:05:55] <Glaisher2>	 but that would go away too
[09:06:06] <Glaisher2>	 when abusive edits are deleted
[09:06:46] <Revi>	 seems all done
[09:07:15] <Revi>	 total 46 revs deleted
[09:07:35] <sjoerddebruin>	 :O
[09:08:39] <Glaisher2>	 Revi:  thanks
[09:08:45] <Glaisher2>	 appears to be a cross-wiki vandal
[09:08:51] <Glaisher2>	 one account was locked yesterday
[09:08:59] <Revi>	 np
[09:09:03] <Glaisher2>	 I am checking edits to other wikis
[09:25:23] <sjoerddebruin>	 Ah, the item about Abdul Fattah Al-Sisi.
[09:26:00] <sjoerddebruin>	 I saw it in our Commonscat-tracking category. :P
[10:00:21] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 29/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121924 
[10:03:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 29/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121924 (owner: 10WikidataBuilder)
[10:08:19] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121924 (owner: 10WikidataBuilder)
[10:16:36] <grrrit-wm>	 (03CR) 10Addshore: [C: 032 V: 032] New Wikidata Build - 29/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121924 (owner: 10WikidataBuilder)
[10:19:20] <gh-wmde>	 [13WikibaseDataModelSerialization] 15addshore created 06snakDataTypeLookup (+1 new commit): 02http://git.io/Q13X7A
[10:19:20] <gh-wmde>	 13WikibaseDataModelSerialization/06snakDataTypeLookup 14bf90294 15addshore: SnakSerializer can now be passed a DataTypeLookup
[10:19:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 29/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121924 (owner: 10WikidataBuilder)
[10:20:16] <gh-wmde>	 [13WikibaseDataModelSerialization] 15addshore opened pull request #60: SnakSerializer can now be passed a DataTypeLookup (06master...06snakDataTypeLookup) 02http://git.io/HCAlfQ
[10:20:40] <travis-ci>	 [travis-ci] wmde/WikibaseDataModelSerialization/snakDataTypeLookup/bf90294 : addshore The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/21818454
[10:28:03] <gh-wmde>	 [13WikibaseDataModelSerialization] 15addshore pushed 1 new commit to 06snakDataTypeLookup: 02http://git.io/8089Mw
[10:28:03] <gh-wmde>	 13WikibaseDataModelSerialization/06snakDataTypeLookup 149057f39 15addshore: Add DataTypeLookup to SerializerFactory construction
[10:34:07] <gh-wmde>	 [13WikibaseDataModelSerialization] 15addshore pushed 1 new commit to 06snakDataTypeLookup: 02http://git.io/Vgi-BQ
[10:34:07] <gh-wmde>	 13WikibaseDataModelSerialization/06snakDataTypeLookup 14250fb6b 15addshore: Fix namespace of LookupException
[10:38:07] <Tpt>	 addshore: Ping me when you want https://github.com/wmde/WikibaseDataModelSerialization/pull/60 merged.
[10:38:22] <addshore>	 :)
[10:38:37] <addshore>	 I will probably have some more stuff to pile on, trying to integrate it with wikibase right now :p
[10:40:05] <Tpt>	 addshore: Nice :-)
[10:40:55] <Tpt>	 I love this architecture of low coupled components that makes very easy to write tools interacting with Wikibase.
[10:41:29] <addshore>	 indeed :) Did you see the start on wikibase-api I made :P soooooooo easy to play with entities now xD
[10:41:42] <Tpt>	 addshore: Yes. It's very nice.
[10:41:56] <Tpt>	 I belive that https://github.com/wmde/WikibaseDataModelSerialization/issues/39 can be closed now. snaks-order and qualifiers-order have been implemented and references-order doesn't looks to exist.
[10:42:50] <addshore>	 Tpt: yes I think so too :)
[10:43:31] <Tpt>	 addshore: I've just closed it.
[10:47:46] <addshore>	 Tpt: whats your opinion on returning the hashes of snaks?
[10:48:15] <addshore>	 currently we HAVE to for qualifiers and references in WIkibase, so I guess we might as well just always return the hash? would save some code then :)
[10:48:43] <addshore>	 this would therefore mean hashes for mainsnaks
[10:49:16] <addshore>	 meh, guess we could have an option xD
[10:51:33] <Tpt>	 addshore: I really dislike options so I think that if it is easy for bot to generate these hashs (I belive that the answer is yes as it's done automaticaly by the DataModel) we should insert them by default.
[10:54:09] <gh-wmde>	 [13WikibaseDataModelSerialization] 15addshore pushed 1 new commit to 06snakDataTypeLookup: 02http://git.io/SnieYA
[10:54:09] <gh-wmde>	 13WikibaseDataModelSerialization/06snakDataTypeLookup 14168bd62 15addshore: Always serialize snaks with a hash
[11:32:36] <JeroenDeDauw>	 addshore: duuuuuuude....
[11:32:44] <JeroenDeDauw>	 That's exactly what I told you to not do...
[11:32:49] <addshore>	 is it O_o?
[11:33:00] <JeroenDeDauw>	 yes
[11:33:02] <JeroenDeDauw>	 https://github.com/wmde/WikibaseDataModelSerialization/commit/bf9029465d401b34f5c5bc4c413e3c0647817248
[11:33:04] <JeroenDeDauw>	 ...
[11:33:39] * addshore  doesnt recall what you said now :/

[11:34:13] <JeroenDeDauw>	 addshore: the tasks of serializers is to serialize the object they get
[11:34:22] <JeroenDeDauw>	 Doing a lookup for more things there is wrong
[11:34:33] <JeroenDeDauw>	 this is the exact same mistake as done in the old code
[11:35:01] <JeroenDeDauw>	 addshore: and in trying to do this you can actually feel that it is wrong, since you need to go create yet another lookup interface
[11:35:11] <JeroenDeDauw>	 Which happens to make no sense in this component
[11:35:34] <JeroenDeDauw>	 addshore: https://github.com/wmde/WikibaseDataModelSerialization/blob/master/src/Serializers/TypedSnakSerializer.php
[11:36:24] <gh-wmde>	 [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/3QFyQA
[11:36:24] <gh-wmde>	 13WikibaseDataModelSerialization/06master 144e25a06 15Jeroen De Dauw: Update TypedSnakSerializer.php
[11:39:58] <gh-wmde>	 [13WikibaseDataModelSerialization] 15addshore created 06snakhashes (+1 new commit): 02http://git.io/05a6Qg
[11:39:58] <gh-wmde>	 13WikibaseDataModelSerialization/06snakhashes 14ad80694 15addshore: Always serialize snaks with a hash
[11:41:32] <travis-ci>	 [travis-ci] wmde/WikibaseDataModelSerialization/snakhashes/ad80694 : addshore The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/21820999
[11:47:21] <gh-wmde>	 [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/x41IkA
[11:47:21] <gh-wmde>	 13WikibaseDataModelSerialization/06master 141b1be34 15Jeroen De Dauw: Merge pull request #61 from wmde/snakhashes...
[11:47:51] <JeroenDeDauw>	 addshore: yay, one more option not implemneted! \o/
[11:48:03] * JeroenDeDauw  hopes we can get by with not implementing any option

[11:48:15] <addshore>	 removing the lib stuff is going to be interesting
[11:48:19] <addshore>	 is just friggin everywhere!
[11:48:41] <travis-ci>	 [travis-ci] wmde/WikibaseDataModelSerialization/master/1b1be34 : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/21821284
[11:48:51] <JeroenDeDauw>	 addshore: it can be done gradually
[11:49:06] <JeroenDeDauw>	 And I think it makes more sense to first do this in DataModel
[11:49:29] <JeroenDeDauw>	 Depends on when we can make the breaking change to the dump though
[11:51:26] <addshore>	 JeroenDeDauw: added you to a draft, any comments? https://gerrit.wikimedia.org/r/#/c/121706/
[11:53:35] <JeroenDeDauw>	 addshore: I do not see how this is helpfull
[11:53:47] <JeroenDeDauw>	 addshore: did you have a look at how services are handled in Wikibase Query?
[11:53:58] <addshore>	 which bit in query?
[11:54:14] <JeroenDeDauw>	 addshore: look at the API module, or the SpecialPage
[11:54:48] <addshore>	 $entityFinder = ExtensionAccess::getWikibaseQuery()->getByPropertyValueEntityFinder();
[11:55:47] <JeroenDeDauw>	 addshore: the important point there is that it breaks out of the class as soon as possible
[11:56:00] <JeroenDeDauw>	 And everything outside of it uses dependeny injection all the way
[11:56:08] <JeroenDeDauw>	 So that call is the only pull made
[11:56:16] <JeroenDeDauw>	 Only one such pull per legacy entry point
[11:56:28] <JeroenDeDauw>	 And they are made obvious by the ExtensionAccess thing
[11:56:37] <JeroenDeDauw>	 This can only be used in these legacy entry points
[11:58:26] * addshore  lets JeroenDeDauw implement this in Wikibase ;p

[12:00:59] <JeroenDeDauw>	 addshore: I hope to get to that, though fixing the issues in the lower level components first, ie DM and lib, seems like the way to go
[12:01:08] <JeroenDeDauw>	 I will however be outlining this exact point on Tuesday
[12:01:12] <JeroenDeDauw>	 In my CR presentation
[12:01:32] <addshore>	 :O youll have to link it to me :P
[12:02:15] <JeroenDeDauw>	 addshore: it will look roughly like this http://bit.ly/Pa3crj
[12:02:38] <addshore>	 heh :p
[12:03:22] <gh-wmde>	 [13WikibaseDataModelSerialization] 15addshore closed pull request #60: Add features missing needed by Wikibase (06master...06snakDataTypeLookup) 02http://git.io/HCAlfQ
[12:09:31] <JeroenDeDauw>	 oh ffs, why does the constructor of the Command class need to be "special" >_>
[12:51:17] <JeroenDeDauw>	 40 minutes of total ignornace :|
[12:54:04] <addshore>	 :O
[12:58:26] <JeroenDeDauw>	 Finally realized why this class does not support constructor injection, actually makes sense
[13:03:43] <addshore>	 what class ? :P
[13:05:15] <JeroenDeDauw>	 Symfony\Component\Console\Command\Command
[13:15:51] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/121924 (owner: 10WikidataBuilder)
[13:32:33] <gh-wmde>	 [13WikibaseDatabase] 15JeroenDeDauw created 06PDOQueryInterface (+1 new commit): 02http://git.io/DNrjZw
[13:32:33] <gh-wmde>	 13WikibaseDatabase/06PDOQueryInterface 14f2f1b97 15jeroendedauw: Get error messages from PDO in PDOQueryInterface
[13:32:40] <gh-wmde>	 [13WikibaseDatabase] 15JeroenDeDauw opened pull request #32: Get error messages from PDO in PDOQueryInterface (06master...06PDOQueryInterface) 02http://git.io/qEXC7Q
[13:34:00] <JeroenDeDauw>	 addshore: you know, if we created an SQLite implementation of the select, delete, update and insrt SQL builders, then we could test QueryEngine and the like using an in-memory SQLite db
[13:34:10] <JeroenDeDauw>	 Would make creating integration tests for those things a breeze
[13:34:36] <addshore>	 dont we already have those?
[13:34:43] <JeroenDeDauw>	 nope, just MySQL ones
[13:34:53] <travis-ci>	 [travis-ci] wmde/WikibaseDatabase/PDOQueryInterface/f2f1b97 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/21824910
[13:47:33] <gh-wmde>	 [13WikibaseDatabase] 15addshore 04deleted 06PDOQueryInterface at 14f2f1b97: 02http://git.io/voE2yA
[13:53:00] <aude>	 addshore: is it really just one person who can approve changes to qrpedia?
[13:53:01] <aude>	 https://gerrit.wikimedia.org/r/#/admin/groups/534,members
[13:53:09] <addshore>	 aude: apparently :P
[13:53:13] <aude>	 your changes will be there forever
[13:53:25] <addshore>	 hehe, maybe ;p
[13:53:45] <addshore>	 https://gerrit.wikimedia.org/r/#/c/121934/
[13:54:01] <aude>	 ah :)
[13:54:25] <aude>	 who approves kelson's changes? :)
[13:54:27] <grrrit-wm>	 (03CR) 10Addshore: Clean up Client Api Module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121705 (owner: 10Addshore)
[13:55:23] <JohnLewis>	 aude: The big commit guy in the sky? :p
[13:55:24] <addshore>	 aude: tbh no idea :D
[13:56:27] <aude>	 addshore:  btw, when i run all phpunit tests (core + wikibase etc), tests exit without any info at 97%
[13:56:32] <aude>	 like happens to the build
[13:56:45] <addshore>	 I noticed :/
[13:56:49] <aude>	 trying to debug it
[13:57:14] <aude>	 might have to do with the UpdateRepoOnMove change
[14:04:48] <aude>	 exits with just --group Wikibase
[14:14:20] <gh-wmde>	 [13WikibaseDatabase] 15JeroenDeDauw created 06PDOTableBuilder at 14bc13413 (+0 new commits): 02http://git.io/103TyA
[14:14:39] <JeroenDeDauw>	 wtf
[14:15:35] <gh-wmde>	 [13WikibaseDatabase] 15JeroenDeDauw 04deleted 06PDOTableBuilder at 14bc13413: 02http://git.io/CofYWA
[14:15:55] <gh-wmde>	 [13WikibaseDatabase] 15JeroenDeDauw 04deleted 06PDOTableBuilderr at 14bc13413: 02http://git.io/CofYWA
[14:16:10] <gh-wmde>	 [13WikibaseDatabase] 15JeroenDeDauw created 06lolwat (+1 new commit): 02http://git.io/gpTfig
[14:16:10] <gh-wmde>	 13WikibaseDatabase/06lolwat 14f7a094e 15jeroendedauw: Get error messages from PDO in PDOTableBuilder
[14:16:12] <JeroenDeDauw>	 addshore: please to merge https://github.com/wmde/WikibaseDatabase/pull/33
[14:16:49] <travis-ci>	 [travis-ci] wmde/WikibaseDatabase/PDOTableBuilder/bc13413 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDatabase/builds/21826542
[14:17:01] <addshore>	 lolwat
[14:17:04] <gh-wmde>	 [13WikibaseDatabase] 15addshore pushed 1 new commit to 06master: 02http://git.io/RD0fwg
[14:17:04] <gh-wmde>	 13WikibaseDatabase/06master 14dac34b0 15addshore: Merge pull request #33 from wmde/lolwat...
[14:17:46] <travis-ci>	 [travis-ci] wmde/WikibaseDatabase/PDOTableBuilderr/bc13413 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDatabase/builds/21826583
[14:18:41] <travis-ci>	 [travis-ci] wmde/WikibaseDatabase/lolwat/f7a094e : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDatabase/builds/21826621
[14:22:12] <JeroenDeDauw>	 addshore: uh oh BLOB/TEXT column 'value' used in key specification without a key length
[14:23:02] <addshore>	 give it a length then? :P
[14:27:53] <JeroenDeDauw>	 addshore: not possible for these fields
[14:27:59] <JeroenDeDauw>	 need new ones
[14:28:04] <addshore>	 its required for the indexes
[14:28:37] <JeroenDeDauw>	 addshore: yes, new field for index
[14:38:20] <travis-ci>	 [travis-ci] wmde/WikibaseQueryEngine/addhash/ec8635f : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21827442
[14:59:25] <travis-ci>	 [travis-ci] wmde/WikibaseQueryEngine/addhash/87df963 : jeroendedauw The build was broken. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21828228
[15:01:59] <JeroenDeDauw>	 hahahaha
[15:02:02] <JeroenDeDauw>	 faillll
[15:02:17] <JeroenDeDauw>	 nice that all other tests pass though
[15:02:23] <JeroenDeDauw>	 addshore: https://travis-ci.org/wmde/WikibaseQueryEngine/jobs/21828229
[15:02:38] <JeroenDeDauw>	 addshore: https://github.com/wmde/WikibaseQueryEngine/pull/14/files
[15:02:49] <JeroenDeDauw>	 I was to lazy to set the stuff up locally so I could run tests
[15:02:54] <JeroenDeDauw>	 And missed that obvious thing
[15:02:59] <JeroenDeDauw>	 if ( $string > $this->MAX_LENGTH ) {
[15:03:39] <JeroenDeDauw>	 oh, now the link is no longer valid
[15:06:26] <travis-ci>	 [travis-ci] wmde/WikibaseQueryEngine/addhash/9b6b75b : jeroendedauw The build was fixed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21828586
[15:06:28] <JeroenDeDauw>	 addshore: please to merge?
[15:09:07] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: Clean up Client Api Module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121705 (owner: 10Addshore)
[15:23:55] <JeroenDeDauw>	 no merge :(
[15:37:54] <addshore>	 JeroenDeDauw: done
[15:38:12] <JeroenDeDauw>	 addshore: you know, I was halfway through the command to just merge it into master locally and use that ;p
[15:38:21] <addshore>	 :P
[15:38:41] <JeroenDeDauw>	 ty for merge
[15:44:35] <JohnLewis>	 addshore: Since when did you become a hashtag? #adamshorland :p
[16:02:56] <travis-ci>	 [travis-ci] wmde/WikibaseQueryEngine/lolfail/de6170d : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/21831224
[16:20:53] <hoo>	 [2014-03-29 09:55:08] Fatal error: Call to a member function getPartialURL() on a non-object at /usr/local/apache/common-local/php-1.23wmf19/extensions/Wikidata/extensions/Wikibase/lib/includes/formatters/CommonsLinkFormatter.php on line 58
[16:22:33] <hoo>	 aude: ^
[16:22:42] <hoo>	 Lydia_WMDE: ^ known?
[16:23:34] <hoo>	 ok, pretty uncommon error
[16:30:24] <aude>	 we know
[16:31:49] <aude>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=62904
[16:32:04] <hoo>	 ah ok
[16:32:11] <hoo>	 aude: Noticed the DB probs. earlier on
[16:32:13] <hoo>	 ?
[16:32:13] <aude>	 i don't have a fix
[16:32:24] <aude>	 nope
[16:44:13] <lazowik>	 hyia people!
[16:46:12] <lazowik>	 benestar: hey :)
[16:46:24] <benestar>	 hi lazowik :)
[16:46:27] <benestar>	 what's up?
[16:46:31] <lazowik>	 damn
[16:46:37] <lazowik>	 wanted to ask that first :p
[16:46:41] <benestar>	 xD
[16:46:50] <benestar>	 Lydia_WMDE: no answer? https://twitter.com/benestar_wm/status/448172261946953728
[16:47:07] <lazowik>	 benestar: about 1,5 of month and I'm back
[16:47:11] <lazowik>	 how's badges?
[16:47:26] <benestar>	 I got no review for about a week now -.-
[16:47:45] <lazowik>	 benestar: I'd say that ui redesign should should include responsivness
[16:47:53] <lazowik>	 so not only desktop/mobile
[16:48:05] <benestar>	 I think we should support the mobile extension
[16:48:14] <lazowik>	 but large desktop/normal desktop/small desktop/tablet/phone
[16:48:41] <lazowik>	 not sure how that should then play with mediawiki
[16:48:44] <Lydia_WMDE>	 hoo: not known to me
[16:48:48] <lazowik>	 so probably only mobile
[16:48:55] <Lydia_WMDE>	 benestar: there are several aspects to it
[16:49:17] <Lydia_WMDE>	 the ui redesign should take small formfactors into account
[16:49:26] <Lydia_WMDE>	 and we need dedicated apps for specific tasks
[16:49:33] <Lydia_WMDE>	 i am working on concepts
[16:49:34] <benestar>	 Lydia_WMDE: is https://www.mediawiki.org/wiki/Extension:Wikibase_Repository/Mobilize_Wikidata still active?
[16:49:52] <Lydia_WMDE>	 not really
[16:50:55] <benestar>	 Lydia_WMDE: how far did the development go there already?
[16:51:30] <Lydia_WMDE>	 aude would be able to tell
[16:51:51] <hoo>	 aude: Giving up on the DB stuff for now... we see DB spikes again, ping me ASAP
[21:25:48] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/122077 (owner: 10L10n-bot)