[00:19:05] I want to make quick discussion like Q15958948 this item [00:19:16] It is potal subpage. Delete? or not? [08:06:43] [13WikibaseDataModelSerialization] 15Tpt opened pull request #58: qualifiers-order (de)serialization (06master...06qualifiers-order) 02http://git.io/A_L_GQ [09:43:06] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Make a wb-claim-mainsnak element have a wb-snak instead of being one itself [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119465 (owner: 10Adrian Lang) [09:43:37] (03Merged) 10jenkins-bot: Make a wb-claim-mainsnak element have a wb-snak instead of being one itself [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119465 (owner: 10Adrian Lang) [09:55:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a5c1b9e : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21307218 [10:00:20] (03PS1) 10WikidataBuilder: New Wikidata Build - 22/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120197 [10:04:14] :O [10:13:03] (03PS2) 10Addshore: New Wikidata Build - 22/03/2014 10:00 ... [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120197 (owner: 10WikidataBuilder) [11:13:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120197 (owner: 10WikidataBuilder) [11:56:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120197 (owner: 10WikidataBuilder) [12:01:44] (03PS1) 10Thiemo Mättig (WMDE): Slightly enlarge Snak type (custom/unknown/no value) icons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120201 [12:06:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120201 (owner: 10Thiemo Mättig (WMDE)) [12:47:09] (03CR) 10Addshore: [C: 032] New Wikidata Build - 22/03/2014 10:00 ... [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120197 (owner: 10WikidataBuilder) [13:04:44] There is wikidata-related OTRS channel? [13:04:49] I mean thing... [13:12:43] DangSunM: not sure :O [13:13:24] Revi 확실하지 않다는데 [13:14:16] 뭐가 [13:14:28] DangSunM: Sisterproject에 Wikidata queue 있음 [13:14:32] 아 [14:30:16] (03CR) 10Addshore: ParseValue api to return localized errors. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120007 (owner: 10Daniel Kinzler) [16:41:32] (03CR) 10Thiemo Mättig (WMDE): [C: 031 V: 032] "I tried the change in my local wiki and can confirm it works. It even fixes the issue with the new "compact" feature that was recently add" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [17:07:25] aude: around? :P [17:07:39] or hoo ? xD [17:08:30] Yeah... what's up? [17:10:51] addshore, ^ [17:11:05] i want a backport :P [17:11:07] xD [17:11:15] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 [17:11:35] would be amazing to get it backported to live tbh :P [17:12:30] Any update about this? https://bugzilla.wikimedia.org/show_bug.cgi?id=62868 [17:12:42] hoo: what do you think re the above change ? ;p [17:13:11] sjoerddebruin: looks like it just needs https://gerrit.wikimedia.org/r/#/c/119988/1 to be reviewed! [17:13:29] Okay... [17:13:57] sjoerddebruin: will see if I can take a look at it this weekend, it looks nice and small :) [17:14:28] Hence the importance of the bug. [17:14:29] addshore: mh [17:14:40] if this is how core does it might be a good idea [17:15:03] but make sure no logic relies on the param to get sanitizied over there [17:15:05] hoo: indeed :P at a hackathon and people are coming to me saying wbsearchentities doesnt work :P [17:15:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 (owner: 10Addshore) [17:16:32] addshore: The media hackathon thingy in Berlin? [17:16:42] yup :) [17:16:59] http://bit.ly/wdhackday14 [17:17:17] nice to see how many people are still loooking at the presentation :) [17:17:47] just got to see if anyone tries to make an app using our API now :) [17:18:10] would be nice :) [17:18:12] hoo: I tried lots of test queries with the continue param and everything seems nice :) [17:18:45] I actually came up with an idea that I added to the end of my presentation :) If noone makes it I might give it a shot :P [17:19:08] the hackathon is very media / news focused but Im sure all of the apps that get made have a little room for wikidata ;p [17:19:08] heh... I know that feeling... from time to time I also have nice ideas [17:19:27] Like a mobile app where you can translate labels / descriptions in a nice way [17:19:30] hehe, yup, have the idea, say youl do something, forget about it, remember it 3 years later [17:20:22] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120221 [17:21:36] addshore: You don't want this merged and deployed now, do you? [17:21:53] would be lovely, should I add it to wmf17 also? [17:21:59] just gonna make the patch for the branched build now [17:22:40] Saturday deploys are frowned upon actually... [17:22:58] but if you have people actually blocked by this... [17:23:09] :< if you dont want to then thats fine :p its not blocking anyone, just confusing everyone :P [17:24:03] Sorry... I don't like people being angry at me for deploying stuff on a Saturday... :/ [17:24:45] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120223 [17:24:48] (03CR) 10jenkins-bot: [V: 04-1] Fix ApiSandbox continue param default [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120223 (owner: 10Addshore) [17:25:00] (03PS2) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120223 [17:25:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120221 (owner: 10Addshore) [17:25:12] but it should definatly go into wmf19 ;p [17:25:41] Sure :P [17:26:10] wmf19 is on testwikidata atm [17:26:49] Ok, we can do that [17:28:29] Everything is on testwikidata somehow :p [17:30:33] (03CR) 10Hoo man: [C: 032] "addshore> hoo: I tried lots of test queries with the continue param and everything seems nice :)" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120221 (owner: 10Addshore) [17:31:00] (03Merged) 10jenkins-bot: Fix ApiSandbox continue param default [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120221 (owner: 10Addshore) [17:31:01] addshore: Want to update the core deployment branch? [17:31:08] Or do I have to? [17:32:27] We can also do that on Monday... depends on how important it is to you [17:34:09] hoo: will make a patch in a second :) [17:36:47] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120228 [17:36:49] (03CR) 10jenkins-bot: [V: 04-1] Fix ApiSandbox continue param default [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120228 (owner: 10Addshore) [17:37:09] hmm [17:37:14] just realised im stupid :D [17:37:28] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120229 [17:37:34] hoo: ^^ [17:37:41] was still submitting it to master.. [17:38:01] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120230 [17:38:24] addshore: Wait, 'just'? :p [17:38:55] (03Abandoned) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120223 (owner: 10Addshore) [17:38:55] * hoo feels like JohnLewis tries to troll us a little today :D [17:38:55] (03Abandoned) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120228 (owner: 10Addshore) [17:39:01] :P [17:39:03] hoo: I always do :D [17:39:16] Well, I try at least :) [17:39:31] addshore: which one of these is supposed to be merged? [17:39:37] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 [17:39:39] Thiemo_WMDE: Do both [17:39:42] well, Thiemo_WMDE [17:39:48] all of the ones that are currently up xD [17:39:52] Yeah [17:39:54] 5 in total :P [17:40:00] but we will at max deploy to testwikidata today [17:40:03] at least I will [17:40:13] wikibase/master wikibase/wmf17 wikibase/wmf19 wikidata/wmf17 wikidata/wmf19 [17:40:15] * Thiemo_WMDE is confused [17:41:01] Thiemo_WMDE: why? :> [17:42:42] mh... might be that our deployment system is a little complicated [17:43:11] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix ApiSandbox continue param default (031 comment) [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 (owner: 10Addshore) [17:43:51] obviously the same -1 applies to all of them, but I will not -1 all. [17:45:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 (owner: 10Addshore) [17:48:35] (03CR) 10Addshore: Fix ApiSandbox continue param default (031 comment) [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 (owner: 10Addshore) [17:49:11] (03CR) 10Addshore: [V: 032] "Jenkins has failed for the unrelated 'bot' index in MergeItems" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 (owner: 10Addshore) [17:49:38] Thiemo_WMDE: replied :) [17:49:51] addshore: I think he wanted to note on $allowedParams['continue'][ApiBase::PARAM_MAX]; [17:50:33] yes, the line below. seems i misclicked when adding the comment. [17:51:48] oh... yes... [17:51:52] * addshore hates searchentities [17:52:07] +1 [17:52:20] I think it's our oldest API which is still in service mostly uncahgned :P [17:52:43] yup [17:52:44] :P [17:53:39] hmm, do we really need && $nextContinuation <= $maxContinuation [17:53:46] guess its to keep the DB load down :/ [17:53:50] hoo: Out of interest - what is the status of https://bugzilla.wikimedia.org/show_bug.cgi?id=58247? (/me has been going through shell bugs) [17:53:54] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix ApiSandbox continue param default (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 (owner: 10Addshore) [17:53:57] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix ApiSandbox continue param default (031 comment) [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120229 (owner: 10Addshore) [17:53:59] JohnLewis, looking [17:54:02] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix ApiSandbox continue param default (031 comment) [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120230 (owner: 10Addshore) [17:55:02] JohnLewis: That file still has a ~300 line switch statement... of course on could merge that into the even bigger files, I'm not sure it's worth it, though [17:55:12] * one could [17:55:14] (03PS2) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 [17:55:22] hoo: Thiemo_WMDE well, thats fixes that :) [17:55:26] nice spot Thiemo_WMDE ! [17:55:35] hoo: I was wondering the same thing tbh [17:55:40] hu? [17:55:47] will amend all of the patches :P [17:55:51] addshore: Better delete the module for insanity now and I'll deploy that ASAP? :D [17:56:08] hehe [17:57:09] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120234 [17:58:09] JohnLewis: Note that on the bug... if one really wants to do that I can probably review, but I doubt I'll ~~waste~~ spend my own time on that [17:58:43] :p I have time but probably won't. [17:59:15] hmm actually, gonna change it even more... [17:59:27] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix ApiSandbox continue param default (031 comment) [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120234 (owner: 10Addshore) [17:59:57] addshore: seems you didn't slept well or something? ;))) [18:00:21] not slept well :P Thiemo_WMDE will ammend it to just use the MAX of limit instead of MAX of continue :P [18:00:23] brb [18:01:47] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix ApiSandbox continue param default (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 (owner: 10Addshore) [18:02:16] time for a bit ammend spree :P [18:02:24] if only gerrit had an edit interface like github! [18:02:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 (owner: 10Addshore) [18:03:12] thatll be the day [18:03:17] i feel so bad. i minused 5 patches in a row. :( [18:03:33] addshore: you are etirely free to clone a git repo and push it to a new remote [18:03:42] distributed system and open source [18:03:48] :P [18:03:59] Thiemo_WMDE: no problem :P its the same patch anyway xD [18:04:49] (03PS1) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120236 [18:05:07] (03Abandoned) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120236 (owner: 10Addshore) [18:05:14] git is confused [18:06:45] (03PS2) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120234 [18:06:50] thats better git :> [18:09:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120234 (owner: 10Addshore) [18:09:27] (03PS3) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 [18:10:29] (03PS2) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 [18:12:05] (03PS2) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120229 [18:12:57] (03PS2) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120230 [18:13:01] Thiemo_WMDE: hoo all done ;p [18:13:13] I think its beer and food time [18:13:41] addshore: If you have to much of the former, you better should stop working on deployment branches :D [18:15:25] looks good now... but I'll leave the final decision to Thiemo_WMDE [18:16:01] hoo: this hackathon is fully stocked :P so I expect lots of reviews of any patches I come up with tonight x [18:16:02] xD [18:16:36] addshore: The whole Wikidata cabal is there? :P [18:16:47] just me :P Jens was here :P [18:16:57] Thiemo_WMDE: fancy coming to a hackathon tonight? xD [18:17:16] i'm actually sitting at a hackathon! ;) [18:17:21] oO [18:17:22] Thiemo_WMDE: which? :P [18:17:29] OSM. barely doing OSM. ;) [18:17:33] Abraham said he might pop by tongiht, if not in the morning [18:17:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120236 (owner: 10Addshore) [18:17:44] Thiemo_WMDE: Is Katie around? :P [18:17:47] your doing all of the reviews! xD [18:17:56] no. [18:17:57] where is the OSM one? [18:18:22] ask google for "OSM berlin hack weekend 2014" ;) [18:19:11] * hoo feels like the only one sitting in front of a Computer alone ATM :P [18:19:27] ahh, thats quite a way away [18:19:34] naaaaw hoo , come here? :P [18:20:00] addshore: I'm still ~600km away :/ [18:20:11] :/ you can run right? ;p [18:20:16] I actually wasn't in Berlin for half a year now :( [18:20:28] :/ I leave again on monday :/ [18:20:42] Where are you going? [18:21:04] home again :P [18:21:13] I dont live in Berlin any more :/ [18:21:57] addshore: i have to go. i will try to merge your stuff later. [18:22:00] :P [18:22:03] addshore: oO didn't know that... so near Berlin or totally away? [18:22:18] totally away, back in the UK (hehe rhyme) [18:23:26] oO [18:23:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120234 (owner: 10Addshore) [18:24:28] hoo :O [18:27:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120219 (owner: 10Addshore) [18:30:08] hoo: we need an oauth web app where people pick 2 langs like en and de and then in a nice BIG js form it just asks, can you translate this? en => Barack Obama into De => ? and when you click return it saves :P [18:30:26] and does a nice quick fade into the next question :P [18:30:39] addshore: My idea was a bit more advanced :P [18:30:55] heh, so is mine, but I cant be bothered to write it all into irc right now :P [18:31:28] addshore: So the Wikidata Language Quiz? :p [18:31:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 (owner: 10Addshore) [18:31:41] JohnLewis: yes, but I was carefull not to us the word Quiz :P [18:31:52] But, it is a Quiz! :p [18:31:54] (03PS3) 10Addshore: Fix ApiSandbox continue param default [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 [18:31:56] addshore: Will you be at the Wikimania? :P [18:32:07] not a quiz JohnLewis ! people shouldnt Guess! they should Know! [18:32:09] I mean London is kind of in the UK, so should be reachable :D [18:32:20] its a Knowledgebase right, not a QuizBase ;p [18:32:23] or GuessBase xD [18:32:28] can be both [18:32:30] hoo: yup, I will be there :) [18:32:40] hoo: and at zurich? [18:32:51] We already suggested Wikidate once... pairing up people based on data! :D [18:32:57] 95% :) [18:33:03] hoo: 'London is kind of in the UK' And the best Geography quote of the year goes to... [18:33:25] JohnLewis: Don't take to serious on a Saturday evening ;) [18:33:28] + me [18:33:47] hoo: That is still a funny quote though :) [18:34:11] wonder if I can actually pull an all nighter tonight :P [18:34:13] totally unintended :D [18:34:30] With caffeine, you can [18:34:40] hoo: what do you think of my speedy revamp? :P https://www.mediawiki.org/w/index.php?title=Extension:Wikibase_Repository/API&action=history [18:35:03] actually ended up removing 10,000 bytes :P [18:35:15] and adding some nice collapses [18:35:46] that reminds me of writing up the documentation I forgot about earlier :D [18:36:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120231 (owner: 10Addshore) [18:37:22] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120223 (owner: 10Addshore) [18:38:57] also hoo maybe we should write our ideas! [18:40:06] Yeah... I actually though I could just implement it in a spare weekend [18:40:28] but well, whenever I have spare time I just look at my code review dashboard ... and it's gone [18:41:32] :P [19:00:49] (03PS8) 10Addshore: Factor EraParser out from YearTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 [19:00:51] (03PS1) 10Addshore: Add YearTimeParser exception message test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120240 [19:07:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [19:10:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120240 (owner: 10Addshore) [19:21:17] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120223 (owner: 10Addshore) [19:30:20] (03PS8) 10Addshore: Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 [19:31:23] (03CR) 10Addshore: Inject Guid Validator and Parser in ChangeOpClaim (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [19:31:44] (03CR) 10Addshore: "Comments fixed and everything rebased (sorry its all in the same patch)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [19:35:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [19:41:02] (03PS5) 10Addshore: DNM Take SpecialSetSiteLink badges out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 [19:44:27] (03Abandoned) 10Addshore: DNM Take SpecialSetSiteLink badges out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [19:46:07] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [19:48:02] (03Abandoned) 10Addshore: APIBREAK wblinktitles uses serialized entityId DNM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94755 (owner: 10Addshore) [19:49:36] (03CR) 10Addshore: "Does it really need to wait for that bug >.> ???" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [19:49:41] (03PS6) 10Addshore: Take SpecialMergeItems out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 [19:49:51] (03CR) 10Addshore: "Does it really need to wait for that bug >.> ???" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [19:50:05] (03PS7) 10Addshore: Take SpecialMergeItems out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 [19:50:10] (03CR) 10Addshore: "Does it really need to wait for that bug >.> ???" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [19:56:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [20:00:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [20:02:55] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/120228 (owner: 10Addshore) [20:23:56] Hi , for mediawiki extension Wikidata . Where are the error messages defined ? [20:24:34] All of the error messages are defined in Wikibase.i18n.oho ? [20:33:38] kushalk124: it depends [20:33:58] firstly there are 3 Wikibase.i18n.php files (one for Lib one for Repo and one for CLient) [20:34:10] kushalk124: are you talking about API error messages or some other error messages? [20:34:19] addshore, API error messages [20:34:35] currently most of these are not in the i18n files are are not localised [20:35:42] kushalk124: but see http://www.wikidata.org/w/api.php?action=paraminfo&format=jsonfm&modules=parse&querymodules=wbgetentites [20:36:02] this has a structured list of possible error messages for any module you pass in :) [20:36:35] hmm, that link is wrong, give me a few seconds [20:36:47] http://www.wikidata.org/w/api.php?action=paraminfo&format=jsonfm&modules=parse&modules=wbgetentities [20:36:49] :) [20:39:34] addshore, I can't find it in here also for one particular error message :( [20:39:47] which api modules are you using kushalk124 ? [20:40:38] addshore, MergeItems [20:41:14] addshore, the error message " wikibase-api-not-item" is not defined anywhere in the extension directory. [20:41:50] But there is a similar message in il8n file [20:41:54] wikibase-api-not-an-item [20:43:11] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 3 new commits to 06master: 02http://git.io/ZCPRbA [20:43:11] 13WikibaseDataModelSerialization/06master 145b17c70 15Tpt: Implements qualifiers-order serialization [20:43:11] 13WikibaseDataModelSerialization/06master 1473cac11 15Tpt: Implements qualifiers-order deserialization [20:43:11] 13WikibaseDataModelSerialization/06master 1476d075c 15Jeroen De Dauw: Merge pull request #58 from Tpt/qualifiers-order... [20:46:50] (03CR) 10Jeroen De Dauw: [C: 032] Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [20:47:03] addshore, ? [20:48:20] hmm kushalk124 indeed it doesnt look like it is in http://www.wikidata.org/w/api.php?action=paraminfo&format=jsonfm&modules=parse&modules=wbmergeitems [20:48:25] give me 2 seconds :)# [20:49:19] addshore, Sure :) [20:49:46] hmmm kushalk124 how odd, sure its not-an-item and not just not-item / [20:49:47] ? [20:49:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/120229 (owner: 10Addshore) [20:49:57] addshore, In the above link the error code "not-item" is there [20:50:07] addshore, Yes [20:50:20] Check erro code not-item and its info [20:50:25] well the error message for that should be 'One or more of the entities are not items' [20:51:15] give me a few more seconds ;p [20:51:19] :P [20:52:40] addshore, in il8n file it is like this 'wikibase-api-not-an-item' => 'Not an item' [20:53:01] (03PS1) 10Addshore: Fix 2 api error i18n strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120310 [20:53:02] kushalk124: ^^ [20:53:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/8d511d1 : addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21333660 [20:53:26] JeroenDeDauw ^^? :D [20:54:28] addshore, :) I was writing a fix :P [20:56:55] haha kushalk124 :D [20:57:02] feel free to review it :) [20:57:07] :) [20:57:18] kushalk124: I will add checking over them all to my TODO list, its likely some more are wrong if those two are :) [20:57:31] Yes a few more of them. [20:57:36] I was just checking them :) [20:58:01] addshore, I am a new contributor so learning things. So is there some code review guidelines ? [20:58:40] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120307 (owner: 10L10n-bot) [20:58:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/139b5b0 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21333970 [20:59:35] kushalk124: I think so :) Will take a look :) [21:00:16] kushalk124: I guess this >> https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_we_review_code :) [21:01:22] addshore, Thanks :) [21:01:27] no problem :) [21:02:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120310 (owner: 10Addshore) [21:03:28] (03CR) 10Kushal124: [C: 031] Fix 2 api error i18n strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120310 (owner: 10Addshore) [21:08:20] kushalk124: I look forward to seeing some patches from you :D [21:09:06] addshore: ? [21:10:08] JeroenDeDauw: just added you to a tiny patch! easy review is easy :> [21:11:17] JeroenDeDauw: -2 it to annoy him :D [21:11:42] * addshore -2s JohnLewis [21:11:52] addshore: How :o [21:12:03] well ;p [21:12:17] (03CR) 10Jeroen De Dauw: [C: 04-2] Fix 2 api error i18n strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120310 (owner: 10Addshore) [21:12:20] JohnLewis: done [21:12:37] :< [21:13:19] (03CR) 10Jeroen De Dauw: [C: 032] Fix 2 api error i18n strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120310 (owner: 10Addshore) [21:14:00] :> [21:14:29] * JeroenDeDauw now both trolled addshore and JohnLewis [21:14:31] JohnLewis: I was about to make a patch with the commit message JohnLewis, but I cant be bothered ;p [21:14:32] profit [21:14:53] addshore: DO IT :p [21:14:59] JohnLewis: no :P [21:15:04] my legs are tired [21:15:18] JeroenDeDauw: why you no come to hackathon? xD [21:15:29] addshore: what hackathon? [21:15:36] Well in that case - I can't administrate things cuz the air is too cold :p [21:15:38] http://mediahackday.com [21:17:06] addshore: looks like there are people over there [21:17:14] JeroenDeDauw: I am :O [21:20:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0039284 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21334888 [21:23:14] (03PS1) 10Addshore: Use correct options for GlobeCoordinateFormatter take2! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 [21:23:34] (03CR) 10Addshore: "Ready for you to fix @Adrian Lang :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [21:23:43] (03PS1) 10Kushal124: Fix error il8n string for API Modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120315 [21:23:55] addshore, here you go one patch :) [21:24:46] :D [21:25:26] (03PS2) 10Addshore: Fix error il8n string for API Modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120315 (owner: 10Kushal124) [21:25:41] changed the commit message a bit for you kushalk124 [21:26:08] addshore, Ohh there should not be a blank line [21:26:24] nope, if its in the format I just did then the bot does this at the bug >> https://bugzilla.wikimedia.org/show_bug.cgi?id=62963 [21:26:27] [= [21:26:42] (03CR) 10Addshore: [C: 031] "Will wait for WikidataJenkins to run before +2" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120315 (owner: 10Kushal124) [21:26:59] Yes , I know I was looking at it only why it didn't notify at bug [21:27:04] addshore, Thanks :) [21:27:08] np :) [21:27:10] addshore, Now you can review one for me :D [21:27:34] yup :) Will just wait for jenkins to run the tests :) Even though I am 99.9999999% sure they will pass ;p [21:27:48] :P [21:28:16] addshore, So the reason I was looking into it was [21:28:24] I wanted to fix this bug [21:28:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=61665 [21:28:35] And I couldn't find the error string to change [21:29:29] addshore, Now to fix the above bug I was about to create a new error message. That would be fine ? [21:29:30] ahhh :P [21:29:44] see https://gerrit.wikimedia.org/r/#/c/118583/ [21:30:01] someone else attempted to fix that bug but they are doing it wrong :> [21:30:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120314 (owner: 10Addshore) [21:33:27] Ahh.. [21:33:49] addshore, This error string is used in other modules [21:33:57] which? [21:34:07] :D [21:34:11] wikibase-api-not-an-item [21:34:15] ahh yes, the merge items one [21:34:31] I thought of creating wikibase-api-merge-not-an-item :P [21:34:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120315 (owner: 10Kushal124) [21:34:38] hmm, that sounds ewwy ;p [21:34:43] :P [21:34:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/120230 (owner: 10Addshore) [21:34:59] *looks at the bug again* [21:35:38] and so it can be new detailed error messages :P [21:35:51] kushalk124: I guess you could just add the string before the message [21:35:58] i.e. change [21:35:58] $this->dieUsage( 'One or more of the entities are not items', 'not-item' ); [21:36:15] to $this->dieUsage( 'What Lydia said in the bug: One or more of the entities are not items', 'not-item' ); [21:36:21] but again thats slightly ewwy [21:36:27] yes. [21:36:33] So there was another commit doing that [21:36:38] And I cannot find where it is [21:36:48] but yes so it was -1 by reviewer [21:37:03] well this sounds more like it needs to be a change in the Special page than in the Api module or error key / message [21:37:44] kushalk124: see SpecialMergeItems line 156 ish [21:37:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120315 (owner: 10Kushal124) [21:37:59] wait [21:38:01] and i guess line 177 [21:38:09] and line 187 ;p [21:38:34] the error messages that are shown on the special page dont come from the api [21:38:35] addshore, Which file ? [21:41:02] kushalk124: just updated the bug [21:41:29] so SpecialMergeItems.php and the Api both use the ChangeOpsMerge class which is where these errors appear to come from [21:42:18] i.e. the messages come from any InvalidArgumentException s or ChangeOpException s thrown in ChangeOpsMerge.php [21:42:53] Ahh [21:43:02] but again it doesnt look like anything needs to be changed in that file as those error messages look fine :P [21:43:07] so my advice would be! [21:43:39] add a new i18n key called something like special-merge-items-error-prefix with the message lydia first said in the bug [21:44:20] and then in SpecialMergeItems 158 and 161 concatinate thats string to the front of $e->getMessage() [21:44:52] and I think thats should all be nice ;p [21:45:07]