[00:13:42] "Find someone in #wikidata and ask them." [01:48:32] I am seeing a language/cache problem again. With my language set to English, on https://www.wikidata.org/wiki/Wikidata:List_of_properties/all , at the bottom I see transclusions of 'Wikidata:List of properties/Geographical feature/kk' , which doesnt exist of course [05:36:38] good morning [06:26:19] (03PS1) 10Aude: Use "self" for local static member reference in Utils [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119709 [06:26:21] (03PS1) 10Aude: Add use declarations for core classes, fix style issues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119710 [06:27:35] (03PS1) 10Aude: Use "self" for local static member reference in EntitySerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119711 [06:33:17] (03PS1) 10Aude: Remove unused use $sitesByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119712 [06:33:19] (03PS1) 10Aude: Fix style issues, wrap long lines in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119713 [06:36:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119713 (owner: 10Aude) [06:37:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119712 (owner: 10Aude) [06:39:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119713 (owner: 10Aude) [06:40:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119709 (owner: 10Aude) [06:40:25] (03PS1) 10Aude: Style fixes in EntityFactory, wrap long lines, add use declartion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119714 [06:43:49] (03PS1) 10Aude: Remove unreachable code, "break" after exception is thrown [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119715 [06:43:53] lots of easy things to review [06:46:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119711 (owner: 10Aude) [06:51:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119712 (owner: 10Aude) [06:53:50] (03PS1) 10Aude: Followup for undefined index "bot", add bot param to MergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119716 [06:54:35] (03PS2) 10Aude: Followup for undefined index "bot", add bot param to MergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119716 [06:56:17] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119713 (owner: 10Aude) [07:01:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119714 (owner: 10Aude) [07:04:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119715 (owner: 10Aude) [07:08:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119716 (owner: 10Aude) [07:13:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119716 (owner: 10Aude) [07:33:23] (03PS1) 10Aude: Reduce code duplication in ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119718 [07:34:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119718 (owner: 10Aude) [07:35:33] aude: jenkins is restarting too often.. [07:35:39] will have a look [07:35:49] I guess it restarts every hour when puppet runs [07:35:51] (03PS4) 10Aude: Remove TestSites::insertIntoDb from Lua test setup helper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119075 [07:35:55] that's bad [07:36:06] :( [07:36:24] * aude hoping jenkins wasn't busy this time of day [07:36:25] I think it's this line: notify => Service['jenkins'] [07:36:46] could be [07:36:51] it was busy with your changes.. ;) [07:37:08] heh [07:38:00] I guess we do not need to restart jenkins every time puppet runs [07:38:17] this line is in there because of jenkins plugins may have updated [07:38:40] we can live with manually restarting jenkins when we update or add plugins I guess [07:39:37] agree [07:39:51] will do when I'm at the office# [07:40:02] ok [07:41:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119075 (owner: 10Aude) [07:44:53] (03CR) 10Siebrand: [C: 032] Use "self" for local static member reference in Utils [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119709 (owner: 10Aude) [07:45:15] (03Merged) 10jenkins-bot: Use "self" for local static member reference in Utils [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119709 (owner: 10Aude) [07:48:09] Hm, I think I have a bug. When I want to select a item for a claim with my keyboard, it will always choose the first one of the list. [08:44:58] sjoerddebruin: I cannot confirm this.. can you specify what exactly you're doing with your keyboard? [08:45:29] Moving through the options. [08:45:46] But if I select the third one with the enter-button, it will select the first one. [08:46:28] sjoerddebruin: what browser (+version) and what OS are you using? [08:46:49] Safari 7.0.2 on OS X 10.9.2 [08:57:30] sjoerddebruin: ok, I still cannot confirm this but I only have chrome and firefox here. aude might try to reproduce it on her machine.. [08:58:06] Would be great, because it’s a little bit annoying. [08:59:48] sjoerddebruin: just for clarification: you choose a property, then press "tab" to get to the next input box, then start typing a label and then use your arrow-keys to scroll down the suggestions list and press enter to select an item, right? [09:00:00] Yes [09:00:24] And then it will choose always the first. [09:01:34] ok. what happens while you scroll through the list with your arrow-keys? does it show you the current highlighted label in the input box? [09:01:53] or does the content of the input box not change? [09:02:41] sjoerddebruin: and can you please give me a concrete property & label where this is happening for you please? [09:03:57] The highlighted label is displayed in the input box, but when I hit enter it will be changed to the first result. [09:04:29] And I have it with every property. [09:04:45] sjoerddebruin: hm, ok. we'll try to reproduce it.. [09:04:57] I’m going to open some other browsers.. [09:05:04] * aude check if i have safari [09:06:12] I also get it in Chrome, so I go to check my gadgets and scripts… :/ [09:07:57] well..... i am trying in chrome first to see "how it supposed to be" [09:08:11] found the issue of [09:08:12] sjoerddebruin: to exclude the possibility that is it caused by a gadget, can you go to http://wikidata.beta.wmflabs.org/wiki/Q18448 and try it there with e.g. the property "shares border with".. [09:08:26] 1) click add a statement [09:08:53] It happens there too Tobi_WMDE [09:09:09] I’ve selected the third result. :/ [09:09:15] 2) choose a property (scroll down with arrow key) [09:09:18] 3) click tab [09:09:28] 4) start typing a value [09:09:40] 5) scrolldown to the third choice [09:09:42] click enter to save [09:09:56] 6) it instead chooses the first value in the list instead of third [09:10:02] Yes. [09:10:02] sjoerddebruin: ok, got it. it changes AFTER saving.. [09:10:13] think same issue [09:10:13] thought it is on SELECTING [09:10:33] sjoerddebruin: that's indeed an issue, thx [09:10:55] users might not notice, so this is definitely not so good [09:11:24] shall make bug report [09:11:24] aude: let's make a bug for it [09:11:33] yes please [09:13:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=62868 [09:15:34] (03PS2) 10Aude: Reduce code duplication in ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119718 [09:16:16] (03PS2) 10Aude: Remove unreachable code, "break" after thrown exception [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119715 [09:21:12] Anyway Tobi_WMDE and aude, thanks for your help. Keep me updated. ;) [09:21:46] sjoerddebruin: thx for spotting and reporting the issue! [09:22:08] i can confirm the issue on my own dev wiki [09:22:09] sjoerddebruin: to keep updated, you can follow the bug on https://bugzilla.wikimedia.org/show_bug.cgi?id=62868 [09:22:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119718 (owner: 10Aude) [09:22:39] I’m on the CC-list Tobi_WMDE [09:27:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119715 (owner: 10Aude) [09:38:04] (03CR) 10Addshore: [C: 032] Followup for undefined index "bot", add bot param to MergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119716 (owner: 10Aude) [09:38:26] (03Merged) 10jenkins-bot: Followup for undefined index "bot", add bot param to MergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119716 (owner: 10Aude) [09:39:44] (03CR) 10Addshore: [C: 032] Style fixes in EntityFactory, wrap long lines, add use declartion [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119714 (owner: 10Aude) [09:40:08] (03CR) 10Addshore: [C: 032] Remove unreachable code, "break" after thrown exception [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119715 (owner: 10Aude) [09:40:50] (03CR) 10Addshore: [C: 032] Remove unused use $sitesByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119712 (owner: 10Aude) [09:41:35] (03CR) 10Addshore: [C: 032] Fix style issues, wrap long lines in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119713 (owner: 10Aude) [09:42:02] (03PS2) 10Addshore: Add use declarations for core classes, fix style issues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119710 (owner: 10Aude) [09:42:09] where is addshore [09:42:11] ? [09:42:26] (03CR) 10Addshore: [C: 032] Use "self" for local static member reference in EntitySerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119711 (owner: 10Aude) [09:43:12] (03CR) 10Addshore: [C: 032] Reduce code duplication in ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119718 (owner: 10Aude) [09:44:07] (03PS5) 10Addshore: Remove TestSites::insertIntoDb from Lua test setup helper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119075 (owner: 10Aude) [09:48:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119710 (owner: 10Aude) [09:49:15] (03PS5) 10Tobias Gritschacher: Update EntityId expert(s) to reflect changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:49:17] (03PS12) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [09:51:36] (03CR) 10Thiemo Mättig (WMDE): "Just for the record: This fixed an other, only slightly related issue in a single sub-class and reverted the actual fix in the super-class" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119716 (owner: 10Aude) [09:54:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119075 (owner: 10Aude) [09:55:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:55:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [09:57:54] (03CR) 10Tobias Gritschacher: "PS5 was a rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [09:59:35] (03CR) 10Tobias Gritschacher: "PS12 was a rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [10:00:19] (03PS1) 10WikidataBuilder: New Wikidata Build - 20/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/119728 [10:12:04] (03CR) 10Addshore: [C: 032] Add use declarations for core classes, fix style issues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119710 (owner: 10Aude) [10:18:22] (03PS1) 10Aude: Improve code for setting bot param, with isset check as added in Ie0650eb [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119729 [10:18:24] (03PS1) 10Aude: Add methods for evaluating token and base revision api params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119730 [10:20:12] Tobi_WMDE: Thiemo_WMDE hope those make the code better and more clear ^ [10:20:27] daniel's patch to eliminate entity content also will help quite a bit [10:22:08] * aude finds https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-Wikibase/code-structure/master/class/Wikibase%5CApi%5CApiWikibase sad [10:24:01] (03CR) 10Daniel Kinzler: "@Thiemo: actually, your feedback is quite helpful. And also, this way, I don't have to feel bad about being picky myself ;)" (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [10:24:15] (03PS9) 10Daniel Kinzler: (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 [10:24:37] Thiemo_WMDE: --^ [10:25:01] another review day, yea. :) [10:25:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119729 (owner: 10Aude) [10:25:41] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Improve code for setting bot param, with isset check as added in Ie0650eb [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119729 (owner: 10Aude) [10:26:03] (03Merged) 10jenkins-bot: Improve code for setting bot param, with isset check as added in Ie0650eb [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119729 (owner: 10Aude) [10:30:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119730 (owner: 10Aude) [10:34:56] (03PS5) 10Daniel Kinzler: Inject EntityPermissionChecker into EditEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 [10:35:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [10:35:14] (03CR) 10Daniel Kinzler: Inject EntityPermissionChecker into EditEntity. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [10:40:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [10:58:24] Thiemo_WMDE: so, can this be merged no? https://gerrit.wikimedia.org/r/#/c/119058/ [10:58:50] oh, needs a rebase. but review-wise, it's ok now? [11:02:37] (03PS11) 10Tobias Gritschacher: (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [11:04:01] (03PS6) 10Daniel Kinzler: Inject EntityPermissionChecker into EditEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 [11:04:03] (03PS12) 10Daniel Kinzler: (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 [11:04:05] (03PS9) 10Daniel Kinzler: (bug 62491) Service for checking permissions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 [11:05:51] ick, static, globals in PermissionsHellper [11:06:03] not introduced in the patch, though [11:06:25] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 18/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/119254 (owner: 10WikidataBuilder) [11:07:33] (03CR) 10Aude: (bug 62491) Service for checking permissions. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [11:07:42] DanielK_WMDE: not a -1 but comment https://gerrit.wikimedia.org/r/#/c/119058/ [11:09:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [11:10:02] (03CR) 10Aude: [C: 04-1] "see comment" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [11:11:07] aude: the whole PermissionHelper thing sucks, and the need to muck around with the global state sucks more. There is currently no way except to manipulate the globals if you want to set user permissions. [11:11:14] add a @todo please [11:11:16] aude: you want to block this change on fixing that? [11:11:28] i don't know WHAT to do there, exactly [11:11:40] you want the globals as reference parameters? [11:11:45] they can be at least params, maybe [11:11:48] i hate reference parameters... [11:11:49] idk [11:11:57] they need to be modified [11:12:07] @fixme a bunch of curse words :) [11:12:16] i was just going to suggest that [11:12:22] @todo fix this damn mess! [11:12:25] yeah [11:12:39] can do that ;) [11:12:41] ok [11:12:59] then , if Thiemo_WMDE has no objections, looks ok to merge [11:13:16] * aude don't want to block progress, even if things are not perfect at this point [11:14:32] (03CR) 10Thiemo Mättig (WMDE): (bug 62491) Service for checking permissions. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [11:14:52] * aude hear wtf? [11:15:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [11:16:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/119728 (owner: 10WikidataBuilder) [11:17:47] (03CR) 10Aude: "needs rebase, the undefined index should be fixed in latest master" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [11:19:37] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 20/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/119728 (owner: 10WikidataBuilder) [11:19:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [11:21:29] (03PS10) 10Daniel Kinzler: (bug 62491) Service for checking permissions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 [11:21:59] (03PS7) 10Daniel Kinzler: Inject EntityPermissionChecker into EditEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 [11:22:38] (03Merged) 10jenkins-bot: New Wikidata Build - 20/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/119728 (owner: 10WikidataBuilder) [11:22:49] (03PS10) 10Daniel Kinzler: (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 [11:24:02] (03CR) 10Thiemo Mättig (WMDE): "This is technically ok but it feels a bit unnecessary. Does this really make the code better? It's just moving very few lines around. The " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119730 (owner: 10Aude) [11:26:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [11:26:53] (03CR) 10Aude: "smaller methods are generally less complex and better." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119730 (owner: 10Aude) [11:29:00] aude, Thiemo_WMDE: yea, death to the megamoth! [11:29:14] removing entity content should help a lot [11:29:59] yes! merge mroe stuff! i decided to stop workign on that until all the relevant patches are in. [11:30:05] agree [11:30:20] once they are, i'll look at remainign uses of EntityContent, and factor out all the title-aware stuff from EntityContent. [11:30:30] i would +1 but since Thiemo_WMDE had comments, he should decide if they are addressed enough [11:31:00] (03PS23) 10Daniel Kinzler: Use BaseTemplateAfterPortlet hook to add "edit/add links" link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [11:31:08] (03PS2) 10Daniel Kinzler: Remove enableSiteLinkWidget setting in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119509 (owner: 10Aude) [11:31:38] DanielK_WMDE: the enable site link one might have issue, per tests [11:31:47] need to look [11:32:07] (03CR) 10Aude: [C: 031] "satisfied but shall let thiemo look since he had comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [11:32:16] aude: i just rebased them to re-run jenkins, now that the "missing bot" thing is fixed on master [11:32:25] ok [11:32:30] aude: "smaller methods" aren't "always" better. there's a limit where things get to small, e.g. function not($b) { return !$b; } ;-) [11:32:30] the site link one had a client test failure [11:32:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [11:33:25] Thiemo_WMDE: but often they are. [11:33:33] * aude also spend enough time around jeroen :) [11:33:35] (03CR) 10Daniel Kinzler: "Yes, if you use TestSites::insertIntoDb, you need to also use @group Database or $this->tablesUsed[] = 'sites'." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119075 (owner: 10Aude) [11:33:43] (03CR) 10Daniel Kinzler: [C: 032] Remove TestSites::insertIntoDb from Lua test setup helper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119075 (owner: 10Aude) [11:34:05] (03Merged) 10jenkins-bot: Remove TestSites::insertIntoDb from Lua test setup helper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119075 (owner: 10Aude) [11:35:50] Tobi_WMDE: so we are using the build from yesterday for deploy? [11:36:05] aude: yes [11:36:08] ok [11:37:44] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikidata/refs%2Fheads%2Fmw1.23-wmf19 [11:38:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [11:39:23] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I need to resist the need to block stuff because of not being perfect enough. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119730 (owner: 10Aude) [11:40:05] (03CR) 10Daniel Kinzler: "Looks good in general, except a few nitpicks." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [11:40:14] yay nitpicks [11:40:46] aude: could be merged as is, just a few comments. but mangeling the query conditions is kind of scarry... [11:40:51] it is [11:41:08] * aude would like a better way [11:41:14] DanielK_WMDE: I found a last thing that confuses me: https://gerrit.wikimedia.org/r/#/c/119058/9..10/repo/includes/api/ApiWikibase.php [11:41:55] next step is to consolidate this functionality with that handling recent changes query [11:42:19] (03CR) 10Daniel Kinzler: [C: 031] "needs manual verification" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119306 (owner: 10Hoo man) [11:42:20] and maybe the way the query is modified and handled could be abstracted more [11:42:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [11:45:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [11:46:03] (03CR) 10Aude: "agree with the comments generally." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [11:48:10] (03PS1) 10Aude: Update composer.json to point to Wikibase branch [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119739 [11:49:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119509 (owner: 10Aude) [11:50:47] (03CR) 10Aude: [C: 04-1] "per jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119509 (owner: 10Aude) [12:05:53] (03PS2) 10Tobias Gritschacher: Update composer.json to point to Wikibase branch [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119739 (owner: 10Aude) [12:12:00] Thiemo_WMDE: if isWriteMode() returns true, the edit permission needs to be checked, always. if it wasn#t, that was a bug. [12:12:33] if an entity is modified, isWriteMode() must return true - this is actually checked by attemptSaveEntity. [12:13:52] (03CR) 10Daniel Kinzler: (bug 62491) Service for checking permissions. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [12:16:39] aude, Thiemo_WMDE: re https://gerrit.wikimedia.org/r/#/c/118292/21..22/client/includes/hooks/BeforePageDisplayHandler.php [12:16:43] (03CR) 10Tobias Gritschacher: [C: 032] Update composer.json to point to Wikibase branch [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119739 (owner: 10Aude) [12:16:49] i'm confused why it is necessary to pass $out by reference. [12:16:52] Is it ever replaced? [12:17:55] I don't see any reason for this... [12:19:43] (03Merged) 10jenkins-bot: Update composer.json to point to Wikibase branch [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119739 (owner: 10Aude) [12:21:55] (03CR) 10Daniel Kinzler: Use BaseTemplateAfterPortlet hook to add "edit/add links" link (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [12:22:34] (03CR) 10Daniel Kinzler: [C: 04-1] "The whole "how to modify the output object" thing seems to be a misunderstanding to me. Can we sort this out quickly please?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [12:24:18] (03CR) 10Daniel Kinzler: "Looks good to me, but the test failure needs investigation" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119509 (owner: 10Aude) [12:28:35] jeremyb : Thank you, I saw the Wikidata's talk page, I wanted to implement this itself [12:32:41] (03CR) 10Daniel Kinzler: [C: 04-1] Make js config handling more robust when config is not in ParserCache (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [12:52:11] DanielK_WMDE: that's how the hook works [12:52:19] output is by reference [12:53:01] aude: so? that's the case for two reasons: a) it allows the hook to replace the OutputPage. We don't want that. abd b) tradition from the PHP4 days. We don't care. [12:53:03] do you want us to do the actual modification outside of the tested handler class? [12:53:16] no, why? [12:53:31] then we pass by reference [12:53:36] aude: you can modify objects that were passed "normally". objects do not get copied [12:53:59] hmmm [12:54:00] they are always passed by "reference" (for lack of a better word). That'S not a PHP "reference". [12:54:27] a PHP reference allows you to *replace* the object. you can always *modify* it just fine (unless you are using php4). [12:55:45] aude: https://stackoverflow.com/questions/2715026/are-php5-objects-passed-by-reference [12:55:53] ok [12:57:08] aude: note that this is not true for arrays - arrays are passed by value (implemented as copy-on-modify) [12:57:40] so, if you want to modify an arary in a function ,you indeed need to either pass it by reference, or treturn the modified version [12:58:05] (this is different from e.g. java) [12:58:10] ok [12:58:37] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/95dw7A [12:58:37] 13jenkins-job-builder-config/06master 1434212da 15Tobias Gritschacher: Fix triggers for browser-tests [13:16:01] (03CR) 10Thiemo Mättig (WMDE): "I'm so sorry but this still confuses me. Shouldn't most (if not all) of the classes return false for isReadMode? With the change they now " (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [13:34:40] (03PS2) 10Tpt: Position the otherProjects section just before language links section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119101 [13:37:28] (03PS5) 10Aude: Make js config handling more robust when config is not in ParserCache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 [13:37:30] (03CR) 10Aude: Make js config handling more robust when config is not in ParserCache (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [13:39:15] (03CR) 10Aude: "i need to try this patch again" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119101 (owner: 10Tpt) [13:41:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119101 (owner: 10Tpt) [13:41:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "We had a chat and decided: Even if the only thing an API call returns is a success flag, it still tells you something about the internal s" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [13:44:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [13:46:31] (03PS6) 10Aude: Make js config handling more robust when config is not in ParserCache [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 [13:49:29] (03PS1) 10Thiemo Mättig (WMDE): Make sure permissions aren't checked twice [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [13:53:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119311 (owner: 10Aude) [13:56:01] (03CR) 10Thiemo Mättig (WMDE): Inject EntityPermissionChecker into EditEntity. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119062 (owner: 10Daniel Kinzler) [13:56:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [14:04:05] aude: Thanks for the messages :-) [14:04:51] sure [14:05:05] important to get them in before they make the new branches today [14:05:52] aude: It may be nice to already add wikiquote (in order to don't have to make a new change in a few weeks) [14:06:27] It would also be very nice to have https://gerrit.wikimedia.org/r/#/c/119101/ in the branch [14:06:47] wikiquote, good idea [14:07:07] other i need to test again, but we could cherry pick that in after the branch is made [14:07:27] some reason, (probably caching) it didn't change the position [14:07:52] (silly question) have you tried action=purge? [14:07:56] i did [14:08:00] pretty sure [14:08:22] It remains after the language links? [14:08:35] give me a few minutes [14:26:37] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Daniel, I just realized these "&" are not part of this patch. Let's sort this out in an other patch." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [14:34:17] [13WikibaseDataModelSerialization] 15Tpt opened pull request #47: Cleaning after isDeserializerFor removal (06master...06testCoverage) 02http://git.io/0D2GRQ [14:37:59] (03PS24) 10Aude: Use BaseTemplateAfterPortlet hook to add "edit/add links" link [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 [14:38:38] (03CR) 10Aude: "i changed the output page parameter reference as Daniel suggested (removed "&") and added a note to be sure no one gets confused." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [14:43:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [14:47:16] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/bxBmRw [14:47:16] 13WikibaseDataModelSerialization/06master 1414be1ea 15Tpt: Cleaning after isDeserializerFor removal [14:47:16] 13WikibaseDataModelSerialization/06master 143387394 15Jeroen De Dauw: Merge pull request #47 from Tpt/testCoverage... [14:52:27] (03PS3) 10Aude: Remove enableSiteLinkWidget setting in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119509 [14:57:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119509 (owner: 10Aude) [15:02:22] (03PS16) 10Tobias Gritschacher: Fix watchlist hook query in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [15:04:32] Lydia_WMDE: the page thing still shows the old item http://wmde.wmflabs.org/t/wikidata-developers/2014-03-18/ [15:04:59] wrong url [15:05:01] ;-) [15:06:23] Lydia_WMDE: hax [15:06:26] Why do we have two? [15:06:30] Trolololol? [15:06:38] to troll you ;-) [15:06:39] Please to redirect the old one to the new one? [15:06:43] Or just remove it? [15:06:46] DAAAAAAAAAAAAh [15:07:02] will happen soonish [15:07:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [15:12:37] (03CR) 10Tobias Gritschacher: [C: 032] Fix watchlist hook query in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [15:13:00] (03Merged) 10jenkins-bot: Fix watchlist hook query in the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [15:44:13] (03CR) 10Thiemo Mättig (WMDE): "Just a hint to consider: In my opinion the parameter order "$db, $user" instead of "$user, $db" feels more natural." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [15:45:03] JeroenDeDauw: are you even reading emails? [15:46:07] I've sent you the new url in my direct reply to your email. [15:46:33] and the old instance will vanish when we get rid of all the old instances [15:48:08] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06TypedSnakSerializer (+1 new commit): 02http://git.io/rd68hw [15:48:08] 13WikibaseDataModelSerialization/06TypedSnakSerializer 14276dc26 15jeroendedauw: Add TypedSnakSerializer [15:48:23] [13WikibaseDataModelSerialization] 15JeroenDeDauw opened pull request #48: Add TypedSnakSerializer (06master...06TypedSnakSerializer) 02http://git.io/GhHGkQ [15:50:45] [travis-ci] wmde/WikibaseDataModelSerialization/TypedSnakSerializer/276dc26 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/21185024 [15:51:56] [13WikibaseDataModelSerialization] 15Tpt closed pull request #48: Add TypedSnakSerializer (06master...06TypedSnakSerializer) 02http://git.io/GhHGkQ [15:52:11] [13WikibaseDataModelSerialization] 15Tpt 04deleted 06TypedSnakSerializer at 14276dc26: 02http://git.io/5Yz8yA [15:52:26] [13WikibaseDataModelSerialization] 15Tpt pushed 1 new commit to 06master: 02http://git.io/T0LF1g [15:52:26] 13WikibaseDataModelSerialization/06master 142560381 15Thomas PT: Merge pull request #48 from wmde/TypedSnakSerializer... [15:57:40] Tpt_: you are now the new Tobi_WMDE [15:58:09] JeroenDeDauw: :D [15:59:03] I'm implementing snake-order for preferences [15:59:12] * references, not preferences [15:59:46] (03PS1) 10Aude: Fix watchlist hook query in the client [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119767 [16:01:29] Tpt_: ok, great! [16:01:51] Tpt_: I will not start tackling https://github.com/wmde/WikibaseDataModelSerialization/issues/39 then [16:02:00] Will instead work on adding some integration tests [16:02:02] With real items [16:02:21] JeroenDeDauw: Nice idea :-) [16:04:10] (03PS1) 10Aude: Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119768 [16:05:01] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119767 (owner: 10Aude) [16:05:04] gah [16:05:16] JeroenDeDauw: action=wbgetentities&format=json&ids=Q1752&props=sitelinks%7Csitelinks%2Furls%7Caliases%7Clabels%7Cdescriptions%7Cclaims%7Cdatatype [16:05:52] Tobi_WMDE: what's the issue? [16:06:01] aude? [16:06:02] Tpt_: shall we? or is now not good? [16:06:04] no issue [16:06:09] phew [16:06:29] Lydia_WMDE: I'm ready to start [16:06:29] cherry picking the bot param patches [16:07:21] (03PS1) 10Aude: Don't trigger warning if "bot" parameter is missing in API request [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119770 [16:12:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119768 (owner: 10Aude) [16:12:13] yeah yeah [16:14:21] (03CR) 10Thiemo Mättig (WMDE): [C: 031 V: 031] "I'm very happy with the latest changes. My new comments are mostly responses. I think this can be merged now." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [16:15:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119770 (owner: 10Aude) [16:15:44] (03CR) 10Aude: [C: 032] Don't trigger warning if "bot" parameter is missing in API request [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119770 (owner: 10Aude) [16:15:58] (03PS1) 10Aude: Followup for undefined index "bot", add bot param to MergeItems [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119772 [16:16:09] (03Merged) 10jenkins-bot: Don't trigger warning if "bot" parameter is missing in API request [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119770 (owner: 10Aude) [16:16:13] (03PS2) 10Aude: Fix watchlist hook query in the client [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119767 [16:16:33] (03PS2) 10Aude: Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119768 [16:19:25] Lydia_WMDE : I mailed you a query related to the search box on the FAQ page of Wikidata. If you get time, please have a look at my query. [16:20:22] shrees: i'd say give it a try :) [16:21:35] Should I add that search box to the actual FAQ Page of Wikidata? [16:21:57] shrees: yeah - can always be reverted if people don't like it [16:22:07] Ok [16:22:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119772 (owner: 10Aude) [16:23:02] (03CR) 10Aude: [C: 032] Followup for undefined index "bot", add bot param to MergeItems [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119772 (owner: 10Aude) [16:23:26] (03Merged) 10jenkins-bot: Followup for undefined index "bot", add bot param to MergeItems [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119772 (owner: 10Aude) [16:27:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119767 (owner: 10Aude) [16:28:00] (03PS1) 10Aude: Improve code for setting bot param, with isset check as added in Ie0650eb [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119773 [16:32:06] (03CR) 10Aude: [C: 032] Fix watchlist hook query in the client [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119767 (owner: 10Aude) [16:32:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119768 (owner: 10Aude) [16:33:49] (03PS5) 10Addshore: Support 1 2 and 3 digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 [16:34:44] (03CR) 10Addshore: Support 1 2 and 3 digit years in DateTimeParser (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [16:35:36] (03CR) 10Aude: [C: 032] Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119768 (owner: 10Aude) [16:36:12] (03Merged) 10jenkins-bot: Fix watchlist hook query in the client [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119767 (owner: 10Aude) [16:36:26] (03Merged) 10jenkins-bot: Handle InvalidArgumentException in ClaimHtmlGenerator [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119768 (owner: 10Aude) [16:37:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119773 (owner: 10Aude) [16:38:43] (03CR) 10Aude: [C: 032] Improve code for setting bot param, with isset check as added in Ie0650eb [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119773 (owner: 10Aude) [16:39:06] (03Merged) 10jenkins-bot: Improve code for setting bot param, with isset check as added in Ie0650eb [extensions/Wikibase] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119773 (owner: 10Aude) [16:41:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [16:43:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=61915 [16:44:01] Lydia_WMDE: [16:49:14] https://www.irccloud.com/pastebin/LBiewEct [16:55:19] aude: do you know if it is possible to ssh from one instance into another with the jenkins user? [16:55:28] (03PS2) 10Thiemo Mättig (WMDE): Don't check permissions twice and general API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [16:55:36] no idea [16:55:39] probably not [16:55:51] aude: sad [16:55:59] or would require ssh key setup maybe [16:56:06] then we're not able to use more nodes [16:56:10] for jenkins [16:56:16] oh, then it must be possible [16:56:50] aude: I've added the public key of the first jenkins instance to the authorized_keys file of the second jenkins, but that does not help [16:57:32] we should take a look at wmf puppet (modules/contint and modules/jenkins and manifests/roles/ci) [16:57:52] they are changing stuff to enable jenkins to run on labs [16:58:04] * aude hopes we can use that at some point [16:58:25] aude: I think that will not happen that soon [16:58:34] but at some point of course [16:58:36] if we can't easily figure out, then maybe ask ha.shar though he's too busy these days [16:58:51] probably in a few months [16:59:17] aude: setting up the slave nodes is easy. only bit missing is the ssh part [17:00:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [17:00:53] aude: https://wdjenkins-node1.wmflabs.org/ci/ [17:00:59] I've set up a new instance already. was rather easy with the puppetized stuff we already have [17:01:12] also your user should work there [17:01:13] cool [17:01:17] ok [17:01:37] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06adddep (+1 new commit): 02http://git.io/j0qJhA [17:01:37] 13WikibaseInternalSerialization/06adddep 1492440e1 15jeroendedauw: Explicitly add data-values/serialization as dependency [17:01:40] (03PS1) 10Aude: Update Wikidata, fix for watchlist, bot flag in merge items api [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 [17:01:42] (03CR) 10jenkins-bot: [V: 04-1] Update Wikidata, fix for watchlist, bot flag in merge items api [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 (owner: 10Aude) [17:01:52] rebase hell [17:01:56] and I've added the new instance as slave node to wdjenkins, you can see that there.. [17:02:16] might look tomorrow [17:02:22] also added credentials to ssh to the slave node, but that's the part which is not working [17:04:05] (03PS2) 10Aude: Update Wikidata, fix for watchlist, bot flag in merge items api [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 [17:04:16] need to go [17:04:32] k [17:04:58] (03CR) 10Addshore: Support 5+ digit years in DateTimeParser (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [17:05:10] (03PS5) 10Addshore: Support 5+ digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 [17:05:30] (03CR) 10Addshore: [C: 04-1] "-1 per on going discussion in PS4" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [17:05:48] (03PS5) 10Addshore: Factor EraParser out from YearTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 [17:05:54] (03PS2) 10Addshore: Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 [17:08:07] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06EntityDeserializationCompatibilityTest (+1 new commit): 02http://git.io/NPYRnw [17:08:07] 13WikibaseDataModelSerialization/06EntityDeserializationCompatibilityTest 1415f2bf1 15jeroendedauw: Add EntityDeserializationCompatibilityTest [17:08:27] [13WikibaseDataModelSerialization] 15JeroenDeDauw opened pull request #56: Add EntityDeserializationCompatibilityTest (06master...06EntityDeserializationCompatibilityTest) 02http://git.io/gKmhOw [17:11:47] [travis-ci] wmde/WikibaseInternalSerialization/adddep/92440e1 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/21190900 [17:13:04] waiting for jenkins [17:13:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [17:13:54] wait, we get 2 opinions on the build [17:13:57] (03CR) 10Thiemo Mättig (WMDE): [C: 032] (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [17:14:25] (03Merged) 10jenkins-bot: (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [17:14:28] (03CR) 10Aude: [C: 032] Update Wikidata, fix for watchlist, bot flag in merge items api [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 (owner: 10Aude) [17:14:32] (03Merged) 10jenkins-bot: (bug 62491) Service for checking permissions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119058 (owner: 10Daniel Kinzler) [17:15:03] and then wikidata jenkins will merge it [17:15:31] * aude thinks [17:16:05] wmfjenkins will merge [17:17:38] (03PS3) 10Thiemo Mättig (WMDE): Don't check permissions twice and general API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [17:18:08] (03Merged) 10jenkins-bot: Update Wikidata, fix for watchlist, bot flag in merge items api [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 (owner: 10Aude) [17:20:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [17:25:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [17:28:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [17:38:23] (03PS4) 10Thiemo Mättig (WMDE): Don't check permissions twice and general API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [17:40:38] (03CR) 10Aude: "there appears to be no 0.4 version of value view. is there a branch I am supposed to use instead?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [17:40:47] (03PS5) 10Thiemo Mättig (WMDE): Don't check permissions twice and general API code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 [17:41:18] (03CR) 10Aude: "seems same reason that jenkins is failing" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [17:45:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [17:48:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119745 (owner: 10Thiemo Mättig (WMDE)) [17:49:36] (03CR) 10Aude: [C: 04-1] "i still see no difference with this patch and master" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119101 (owner: 10Tpt) [17:53:59] (03CR) 10Aude: "@note: if Ib845ca2 gets merged first, then this needs to be rebased / adjusted accordingly" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119509 (owner: 10Aude) [17:55:12] (03CR) 10Aude: "if I5e143dbb (removing the enable site link widget setting) gets merged first, then this patch needs to be adjusted accordingly" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [17:56:13] (03PS6) 10Thiemo Mättig (WMDE): Support 1 2 and 3 digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [18:01:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [18:17:19] (03CR) 10Thiemo Mättig (WMDE): "More ideas to improve." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [18:18:24] (03CR) 10Thiemo Mättig (WMDE): "Wait, where did my comments go? Ah, here they are." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [18:19:00] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 (owner: 10Aude) [18:41:08] (03CR) 10Aude: "must assume browser test failure is just a temporarily unrelated glitch on beta" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 (owner: 10Aude) [19:11:32] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.23-wmf19) - 10https://gerrit.wikimedia.org/r/119778 (owner: 10Aude) [19:49:01] [travis-ci] wmde/WikibaseDataModelSerialization/EntityDeserializationCompatibilityTest/15f2bf1 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/21191348 [19:50:46] aude: Thiemo_WMDE:I assume https://bugzilla.wikimedia.org/show_bug.cgi?id=62491 can be closed as all related changes got merged.. did you leave the bug open by purpose or did you just forget to close it? [19:54:14] Tobi_WMDE: agree [19:54:25] would you like to review https://gerrit.wikimedia.org/r/#/c/119311/ ? [19:57:56] I'm not able to test it here [19:59:20] ok [20:37:36] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119865 (owner: 10L10n-bot) [20:42:03] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Support 5+ digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [20:49:30] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Factor EraParser out from YearTimeParser (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [20:50:52] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [21:03:15] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "One more case for the tests." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [21:05:02] (03CR) 10Thiemo Mättig (WMDE): "I shouldn't hide my comments in outdated patch sets, I always fail to publish them. :-( Sorry." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [21:06:44] (03PS7) 10Addshore: Support 1 2 and 3 digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 [21:06:56] (03CR) 10Addshore: Support 1 2 and 3 digit years in DateTimeParser (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [21:07:03] (03PS6) 10Addshore: Support 5+ digit years in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 [21:07:31] (03CR) 10Addshore: [C: 04-1] "-1 per PS4" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [21:08:15] (03CR) 10Aude: Support 1 2 and 3 digit years in DateTimeParser (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [21:09:46] (03CR) 10Addshore: Factor EraParser out from YearTimeParser (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [21:10:56] (03CR) 10Aude: [C: 04-1] Parse Eras in DateTimeParser (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [21:11:06] (03PS6) 10Addshore: Factor EraParser out from YearTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 [21:11:28] (03PS3) 10Addshore: Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 [21:14:19] (03PS4) 10Addshore: Parse Eras in DateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 [21:14:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119038 (owner: 10Addshore) [21:15:23] (03CR) 10Addshore: Parse Eras in DateTimeParser (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [21:20:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [21:23:06] (03CR) 10Addshore: Support 5+ digit years in DateTimeParser (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [21:26:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [21:29:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [21:33:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [21:50:35] (03CR) 10Thiemo Mättig (WMDE): "I do have the same problem as always: Is a personal preference like my "I don't like the 4242 placeholder" a good reason to block a patch " (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119040 (owner: 10Addshore) [22:00:08] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks great now. Just want an other pair of eyes to look at this and hit +2. :-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119051 (owner: 10Addshore) [22:02:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I guess hitting +2 here is delayed anyway since this has to wait for the dependency to be merged, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119057 (owner: 10Addshore) [22:29:08] (03PS1) 10Aude: Remove WBC_VERSION check and namespace from populateInterwiki.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119888 [22:29:31] +1 [22:30:25] it's not beautiful code. (written first days of wikibase) but super useful [22:30:55] wtf, gerrit doesn't get the syntax highlight right... well :/ [22:31:32] (03CR) 10Hoo man: [C: 032] "Move all the sites stuff into core \o/ !" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119888 (owner: 10Aude) [22:31:51] (03Merged) 10jenkins-bot: Remove WBC_VERSION check and namespace from populateInterwiki.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119888 (owner: 10Aude) [22:31:56] yay [22:34:38] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119888 (owner: 10Aude) [22:42:20] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/394b25c : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/21214388 [23:56:37] 1 Fatal error: Call to a member function getPartialURL() on a non-object in /usr/local/apache/common-local/php-1.23wmf18/extensions/Wikidata/extensions/Wikibase/ [23:56:37] lib/includes/formatters/CommonsLinkFormatter.php on line 58