[01:17:59] (03CR) 10Hoo man: [C: 04-1] "needs a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [01:21:45] (03CR) 10Hoo man: [C: 031] "Looks good, but I want to poke at this manually... the chances of something going horribly wrong here are IMO just to high." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [01:26:36] (03CR) 10Hoo man: [C: 04-1] "Also needs a rebase" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [03:44:15] (03CR) 10Aude: [C: 04-1] "Catchable fatal error: Argument 2 passed to Wikibase\LangLinkHandler::__construct() must be an instance of Wikibase\NamespaceChecker, arra" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [06:51:59] Hi Everyone I need some help regarding my GSoC project https://www.mediawiki.org/wiki/User:Apsdehal/GSoC2014_Proposal [06:52:25] I am not sure how I should finally publish my project as an extension or as a browser plugin [06:54:41] Because as Fedrico (nemo) says extensions are created through GSoC are not mostly deployed or used. So can anybody suggest alternatives [06:54:47] Talk Page: https://www.mediawiki.org/wiki/User_talk:Apsdehal/GSoC2014_Proposal [07:04:38] [13DataTypes] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/HOG8EA [07:04:38] 13DataTypes/06master 146789703 15snaterlicious: Bump version 0.2 [07:06:23] [13DataTypes] 15snaterlicious tagged 060.2 at 06master: 02http://git.io/z6T9ag [07:08:18] [travis-ci] wmde/DataTypes/0.2/6789703 : snaterlicious The build passed. http://travis-ci.org/wmde/DataTypes/builds/20746832 [08:45:09] (03PS1) 10Adrian Lang: Don't redraw headings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118672 [08:46:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118672 (owner: 10Adrian Lang) [08:51:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118672 (owner: 10Adrian Lang) [09:02:44] (03PS1) 10Henning Snater: Fixed check in isTitleInEntityNamespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118673 [09:04:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118673 (owner: 10Henning Snater) [09:08:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118673 (owner: 10Henning Snater) [09:16:44] (03PS7) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [09:17:51] (03PS1) 10Henning Snater: Updated DataTypes dependency to 0.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118674 [09:18:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [09:19:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118674 (owner: 10Henning Snater) [09:23:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [09:27:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118674 (owner: 10Henning Snater) [09:44:50] (03CR) 10Thiemo Mättig (WMDE): (bug 62381) Chunked ID query for JSON dumper. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [10:00:23] (03PS1) 10WikidataBuilder: New Wikidata Build - 14/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118675 [10:05:03] [13Time] 15tobijat created 06calendAr (+1 new commit): 02http://git.io/D6pG1A [10:05:03] 13Time/06calendAr 1466a5ccb 15Tobias Gritschacher: Corrected spelling error in constant and in variable name [10:05:28] [13Time] 15tobijat opened pull request #7: Corrected spelling error in constant and in variable name (06master...06calendAr) 02http://git.io/lm-pHA [10:05:38] Adrian_WMDE: https://github.com/DataValues/Time/pull/7 [10:08:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118675 (owner: 10WikidataBuilder) [10:13:38] [13Time] 15adrianlang closed pull request #7: Corrected spelling error in constant and in variable name (06master...06calendAr) 02http://git.io/lm-pHA [10:18:50] (03CR) 10Daniel Kinzler: [C: 04-1] "as per thiemo & hoo" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [10:19:58] [13ValueView] 15adrianlang 04force-pushed 06ValueFormatterForTime from 14b4b735d to 14d78763c: 02http://git.io/yI81oA [10:19:58] 13ValueView/06ValueFormatterForTime 14d78763c 15Adrian Lang: Use ValueView's formatting and parsing in TimeValue [10:21:25] [13Time] 15adrianlang 04deleted 06calendAr at 1466a5ccb: 02http://git.io/wILJww [10:24:59] (03PS1) 10Tobias Gritschacher: Don't use '-' as separator in dates in the time parser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 [10:26:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [10:29:19] (03CR) 10Adrian Lang: Don't use '-' as separator in dates in the time parser (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [10:34:36] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think I found at least one typo, therefor the -1." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118292 (owner: 10Aude) [10:34:41] :) [10:39:04] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 14/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118675 (owner: 10WikidataBuilder) [10:42:06] (03Merged) 10jenkins-bot: New Wikidata Build - 14/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118675 (owner: 10WikidataBuilder) [10:55:20] imalive! [10:57:46] [13Time] 15addshore created 06rmChangel from 06master (+0 new commits): 02http://git.io/_3wz8A [10:58:25] [13Time] 15addshore pushed 1 new commit to 06rmChangel: 02http://git.io/fGG5xg [10:58:25] 13Time/06rmChangel 14d0fd262 15addshore: Rm pointless line from ChangeLog... [10:59:14] (03CR) 10Addshore: [C: 04-1] Don't use '-' as separator in dates in the time parser (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:01:33] (03CR) 10Addshore: [C: 032] "Im fine with this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118612 (owner: 10Hoo man) [11:01:55] (03Merged) 10jenkins-bot: Fix the unit tests on MySQL by introducing a hack in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118612 (owner: 10Hoo man) [11:08:49] it's addshore :) [11:08:54] :D [11:09:08] are you looking at jenkins again? [11:09:18] will do that today yes [= [11:09:26] great [11:10:35] (03CR) 10Thiemo Mättig (WMDE): (bug 62381) Chunked ID query for JSON dumper. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [11:11:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/863d2a6 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20757619 [11:17:46] Can anyone help m with editings in Wikidata? [11:19:33] (03CR) 10Aude: [C: 032] Fixed check in isTitleInEntityNamespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118673 (owner: 10Henning Snater) [11:19:55] (03Merged) 10jenkins-bot: Fixed check in isTitleInEntityNamespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118673 (owner: 10Henning Snater) [11:20:18] (03PS2) 10Tobias Gritschacher: Don't use '-' as separator in dates in the time parser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 [11:20:45] shrees what do you want to kno? [11:21:02] *know? [11:21:44] I think even you have applied for Wikidata Outreach, so what contributions u made in the project? [11:21:48] (03PS8) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [11:21:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:21:53] (03PS3) 10Tobias Gritschacher: Don't use '-' as separator in dates in the time parser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 [11:22:01] addshore: ping [11:22:07] you're out there? [11:22:25] yes I applied [11:22:47] It depends on what is the project you applied [11:22:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [11:22:51] Like did you edit pages in Wikidata? [11:23:04] *you hope to apply [11:23:14] yes I did [11:23:36] You can contribute to random items and improve them [11:23:50] before that read the help pages [11:23:51] I want to now how you did, I am not familiar with Wikidata [11:24:11] like what ranom items [11:24:18] *random [11:24:50] https://www.wikidata.org/wiki/Help:Editing [11:25:07] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:25:20] in your left side menu you can find a link called random item] [11:25:33] click it and then random item will come [11:25:56] then you can improve the item according to given guidlines [11:26:23] before that read the help pages so you will get an understanding how to improve items [11:26:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:26:46] https://www.wikidata.org/wiki/Wikidata:Introduction [11:27:01] this will give you a basic understanding on what is wikidata [11:27:08] have you created an account yet? [11:27:16] (03PS4) 10Tobias Gritschacher: Don't use '-' as separator in dates in the time parser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 [11:27:26] (03CR) 10Karan: "Need help." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118583 (owner: 10Karan) [11:28:01] https://www.wikidata.org/wiki/Q100917 I landed in this page now what shall I do [11:28:50] Tobi_WMDE: pong [11:29:06] yeah , I do have an account [11:29:08] addshore: hey! you made it to GB? [11:29:15] of course :P [11:29:21] are you planning to finish the work on the jenkins instance? [11:29:35] yup :) will hopefully all be done today :) [11:29:48] *all* :) [11:30:05] Please guide [11:30:15] gerrit died :< [11:31:14] waiting for gerrit.... as always -.- [11:31:31] https://www.wikidata.org/wiki/Help:Label [11:31:32] :< [11:32:17] aude: Did you see that I've deployed you ContentRetriever test yesterday night? [11:32:24] s/test/patch/ [11:32:45] shrees the link I sent you contain guidlines on editing a label. as the item you landed doesn't have any label you can add a new label following these guidelines [11:33:06] okay thanks alot [11:33:53] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [11:34:22] shrees: https://www.wikidata.org/wiki/Help:Description will give you an idea on how to add a description [11:34:25] hoo: yes [11:34:26] thanks [11:34:42] shrees: like that you can improve items [11:34:45] hashar: does the jenkins module install phpunit anywhere? :P [11:35:00] * aude pretty sure i didn't install it [11:35:14] It was quite frequent, so Reed.y came here and made me do it :P [11:35:21] hoo: ok [11:35:23] shrees: https://www.wikidata.org/wiki/Category:Help-en here you can find all the help pages [11:36:49] addshore: just maybe i did "composer global require 'phpunit/phpunit=3.7.*'" [11:37:28] looks like its installed in https://github.com/wikimedia/operations-puppet/blob/2385ffbc292475fddcbf28989cc66a6a8775c591/modules/contint/manifests/slave-scripts.pp [11:37:39] makes sense [11:37:55] more likely what we used [11:38:14] (03CR) 10Hoo man: Check namespace before initializing on client. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [11:39:15] aude: what's that with LangLinkHandler? Will it fatal on master? [11:39:41] it will [11:39:52] constructor needs to be changed to match daniel's change [11:39:54] how could we not notice that [11:39:55] in his patch [11:40:02] oh, he changed it in the patch [11:40:03] right [11:40:05] * aude puzzled [11:40:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:40:23] * aude attributes it to drunk coding :) [11:44:09] (03PS1) 10Aude: Move isTitleInEntityNamespace to NamespaceUtils with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118688 [11:44:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/685d7e8 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20758473 [11:44:38] addshore: follow up this afternoon, I am heading out for lunch sorry [11:44:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [11:45:00] hashar: okay :) [11:45:13] hmm aude, I just did apt-get install phpunitbut unfortunatly PHPUnit 3.7.0 or later required, you have 3.5.5. xD [11:45:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:45:39] addshore: Try phpunit instead of phpunitbut [11:45:42] * hoo trolls [11:45:46] [13Time] 15thiemowmde closed pull request #8: Rm pointless line from ChangeLog (06master...06rmChangel) 02http://git.io/14j_2Q [11:45:46] >.> [11:45:47] :P [11:46:01] but I heard phpunitbut was better! [11:46:09] It's slower :D [11:46:22] addshore: Newer phpunit version is available in testing [11:46:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118688 (owner: 10Aude) [11:46:43] well the current stable is 3.7, no idea whay i cant install it through apt.. [11:46:48] clone timeit is! [11:46:50] (03CR) 10Adrian Lang: [C: 032] Don't use '-' as separator in dates in the time parser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:47:16] (03Merged) 10jenkins-bot: Don't use '-' as separator in dates in the time parser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118679 (owner: 10Tobias Gritschacher) [11:47:23] addshore: 3.7 is available in [debian] testing, as I said [11:47:38] meh, clone is easier ;p [11:49:43] composer! [11:50:23] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118688 (owner: 10Aude) [11:54:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [12:00:35] (03CR) 10WikidataJenkins: "Browsertests for new build on beta were successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/118675 (owner: 10WikidataBuilder) [12:00:48] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [12:07:11] [13Time] 15tobijat tagged 060.4 at 06master: 02http://git.io/sf4upg [12:08:44] (03PS9) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [12:10:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [12:13:12] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [12:14:11] hmm, now something is odd :P [12:14:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [12:17:34] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [12:19:40] require_once(PHPUnit/Runner/Version.php): failed to open stream: No such file or directory in /var/lib/jenkins/jobs/wikibase-client-tests/workspace/tests/phpunit/phpunit.php on line 107 [12:19:42] hmmm [12:19:55] aude: Tobi_WMDE ever see anything like http://wdjenkins.wmflabs.org/ci/job/wikibase-client-tests/90/console when you setup jenkins before? [12:20:12] seems very odd, if I log into the jenkins user and run the exact same command it works fine and runs the tests.... [12:21:41] o_O [12:22:39] addshore: why is there this --with-phpunitdir /var/lib/phpunit/vendor/phpunit/phpunit [12:23:15] because thats where phpunit is cloned to :P [12:23:52] äää [12:23:58] :) [12:24:12] not sure if this will work [12:24:24] should do, same way the foundation jenkins does it [12:24:34] I had similar problems with phpunit on my machine and it only worked when I installed it via pear [12:24:37] and also running the command works fine and runs the tests when i SSH to the box :P [12:24:43] hm [12:24:59] what happens if you put phpunit --version in the script [12:25:04] does this also fail? [12:25:29] root@wdjenkins:/var/lib/phpunit/vendor/phpunit/phpunit# php /var/lib/jenkins/jobs/wikibase-client-tests/workspace/tests/phpunit/phpunit.php --with-phpunitdir /var/lib/phpunit/vendor/phpunit/phpunit --group Wikibase --version [12:25:29] Will attempt loading PHPUnit from `/var/lib/phpunit/vendor/phpunit/phpunit` [12:25:29] PHPUnit 3.7.28 by Sebastian Bergmann. [12:25:55] addshore: I mean, put it into the jenkins script [12:26:03] ahhh ;p [12:26:25] addshore: and without running tests [12:26:30] just print the version [12:26:42] that SHOULD work [12:26:50] otherwise the installation is screwed up [12:26:59] running at http://wdjenkins.wmflabs.org/ci/job/wikibase-client-tests/91/console [12:28:25] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [12:28:50] wtf! [12:29:00] its something the mediawiki test runner is doing [12:29:11] and failing at [12:29:42] if ( !class_exists( 'PHPUnit_Runner_Version' ) ) { [12:29:42] require_once 'PHPUnit/Runner/Version.php'; [12:29:42] } [12:31:05] hm [12:31:06] ok [12:31:20] but why does it work then when you run it on the instance [12:31:43] no idea O_o [12:31:59] ahh the script does set_include_path( $phpunitDir [12:31:59] . PATH_SEPARATOR . get_include_path() ) [12:32:22] so should set the include path to the path we pass it in the options [12:33:03] yes.. I thought that should it doing already.. [12:33:05] no? [12:33:32] but then require_once(): Failed opening required 'PHPUnit/Runner/Version.php' (include_path='.:/usr/share/php:/usr/share/pear') [12:33:41] [13DataValuesJavascript] 15tobijat closed pull request #28: Don't register the TimeParser (06master...06dontRegisterTimeParser) 02http://git.io/t8w8bg [12:33:45] the error shows the include path not having this correct place in it [12:34:04] that's why I'm always installing via pear [12:34:07] :P [12:34:13] silly phpunit :> [12:34:26] [13DataValuesJavascript] 15tobijat 04deleted 06dontRegisterTimeParser at 14aad9c48: 02http://git.io/YIZpKA [12:36:35] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/8wAc_w [12:36:35] 13DataValuesJavascript/06master 1499caa34 15Tobi Gritschacher: Update README.md [12:53:44] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [12:54:09] >.> it also happens when composer installed phpunit ... [12:54:48] ahhh! at least I can reporduce it in the console now! [13:10:38] schnitzel! [13:10:54] aude: ? :d [13:11:01] addshore: come back :) [13:11:04] schniiitzel [13:12:02] mh, I think I'm missing out on all the fun :P [13:12:08] xD [13:12:10] hoo: you are [13:12:18] I think I am too now :/ [13:13:38] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [13:13:53] oh this is silly now... [13:14:37] phpunit is installed and in PATH so I can just do phpunit... but phpunit.php still fails bigtime! [13:15:03] can you do phpunit as jenkins user? [13:15:08] yup [13:15:28] hmmm [13:15:28] * hoo is going to have BBQ tonight anyway, so not that bad :D [13:15:32] its even on version 4.070 ;p [13:15:33] :) [13:16:01] version 4 got released last week :P [13:16:10] yay! [13:16:49] addshore said "does the jenkins module install phpunit anywhere? :P" [13:16:58] addshore: I am not sure what you mean :-] [13:17:06] I found it in the slave manifest :P [13:17:20] addshore: we deploy phpunit using the repo integration/phpunit.git and git-deploy from tin.eqiad.wmnet [13:18:14] I dont seem to be able to make the mediawiki phpunit.php find my installed phpunit.. [13:18:19] hashar: so we can have 3.7? [13:18:19] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [13:18:27] since 3.7 is not available as debian [13:18:46] aude might be an idea if you could have a look :/ as I appear to be going mad xD [13:18:55] might be something obvious im missing [13:18:56] shall look shortly [13:19:19] everything is on the eqiad branches of the job builder config and puppet-jenkins [13:19:26] ok [13:19:37] and its the wdjenkins instance ;p [13:19:49] * aude never got job builder working and then tobi setup things [13:19:56] so we used to install phpunit using pear [13:19:56] and i gave up [13:20:10] but that is not very nice to have to do that on all slaves [13:20:20] so instead phpunit is in a git repo :D [13:20:32] 3.7.28 right now [13:20:56] hashar: version 4 was released last week ;p [13:21:29] yeah and someone filled a bug a while ago saying that our phpunit.php wrapper does not work with .phar as used by phpunit 4 :D [13:21:51] link? :P [13:22:08] I tried checkout out your phpunit repo and still couldnt make it work [13:22:55] git clone integration/phpunit.git && cd tests/phpunit && php phpunit.php --with-phpunitdir /tmp/wmfphpunit/vendor/phpunit [13:22:57] or something like that [13:23:05] the .phar bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=58881 [13:23:09] basically that yes :P [13:23:29] jenkins failed to run the command and moaned, when running the same thing for me in cli it worked fine [13:23:58] keep getting the error at the bottom of http://wdjenkins.wmflabs.org/ci/job/wikibase-client-tests/94/console [13:25:31] PHP Warning: require_once(PHPUnit/Runner/Version.php): failed to open stream: No such file or directory [13:25:31] :D [13:25:54] I guess you have phpunit 4 which comes as a .phar dont you? [13:26:13] well, this was happening with the version in the integration repo also [13:26:25] but again oddly it ran in cli but jenkins failed [13:26:36] (include_path='.:/usr/share/php:/usr/share/pear) [13:26:47] wait, let me find the exact job [13:27:00] on wmf setup phpunit is somewhere under /srv/deployment/integration/phpunit/vendor/phpunit [13:27:03] or something like that [13:27:09] http://wdjenkins.wmflabs.org/ci/job/wikibase-client-tests/90/console [13:27:14] yup [13:27:22] (03PS1) 10Adrian Lang: Initialize rank selector on the right element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118695 [13:27:24] php /var/lib/jenkins/jobs/wikibase-client-tests/workspace/tests/phpunit/phpunit.php --with-phpunitdir /var/lib/phpunit/vendor/phpunit/phpunit --conf /var/lib/jenkins/jobs/wikibase-client-tests/workspace/LocalSettings.php --group WikibaseClient [13:27:26] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06dontRegisterStringFormatter: 02http://git.io/2XRcZg [13:27:26] 13DataValuesJavascript/06dontRegisterStringFormatter 14c546080 15Tobias Gritschacher: Updated README.md [13:27:33] niceee [13:27:34] using the git repo on gerrit , and it failed :P [13:27:51] but running as the jenkins user locally and it all worked ;p [13:28:10] (03CR) 10Hoo man: "Mixed static / non-static classes aren't nice... maybe deprecate the static code?" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118688 (owner: 10Aude) [13:28:19] iirc phpunit.php inject the parameter of --with-phpunitdir to the PHP include_path [13:28:43] thats what I thought, but then the error thrown just below doesnt show the path in include_path :/ [13:28:44] that is apparently not the case :-( [13:28:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118695 (owner: 10Adrian Lang) [13:28:59] well, it does set_include_path( $phpunitDir [13:28:59] . PATH_SEPARATOR . get_include_path() ); [13:29:13] where $phpunitDir is the param we pss in [13:29:43] it apparently doesn't load it properly [13:29:49] there should be a message [13:29:50] $this->output( "Will attempt loading PHPUnit from `$phpunitDir`\n" ); [13:30:06] just spotted that :P [13:30:10] --with-phpunitdir /var/lib/phpunit/vendor/phpunit/phpunit [13:30:13] maybe want a = [13:30:15] --with-phpunitdir=/var/lib/phpunit/vendor/phpunit/phpunit [13:30:31] but but...!!! I copied it from the coverage test which qorks fine ;p [13:30:38] will take a poke with the = now! [13:30:45] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06dontRegisterStringFormatter: 02http://git.io/Kb1YaA [13:30:45] 13DataValuesJavascript/06dontRegisterStringFormatter 14a494a4b 15Tobias Gritschacher: Merge branch 'master' into dontRegisterStringFormatter... [13:30:48] ahh [13:30:53] na = is not needed [13:31:11] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/BjRkqQ [13:31:11] 13DataValuesJavascript/06master 142f5d3e0 15Tobi Gritschacher: Merge pull request #32 from wmde/dontRegisterStringFormatter... [13:32:15] [travis-ci] wmde/DataValuesJavascript/dontRegisterStringFormatter/a494a4b : Tobias Gritschacher The build has errored. http://travis-ci.org/wmde/DataValuesJavascript/builds/20765915 [13:32:32] aude: https://gerrit.wikimedia.org/r/118458 should we maybe generalize RecentChangesFilterOptions and use it [13:32:47] I don't think anything but the name would need to be changed actually [13:33:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118695 (owner: 10Adrian Lang) [13:33:28] hashar: very odd how it just seems to ignore the param :/ [13:33:35] oh hideWikibase vs. hidewikidata mess :( [13:33:41] hoo: proabably [13:33:49] addshore: blame MediaWiki maintenance class :] [13:35:06] hashar: I might go and blow it up in a bit :P [13:35:56] + we should get composer on the labs instance to migrate your jobs back to the wmf jenkins hehe [13:36:06] +1 [13:36:07] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [13:36:39] hashar: +1 [13:36:39] * aude rather all our effort be put into wmf jenkins [13:37:12] (03CR) 10Hoo man: "This should probably make use of (slightly refactored/ generalized) RecentChangesFilterOptions" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [13:37:17] aude: tbh I dont think we should puppetise this any more and ill just let you and Tobi_WMDE hack it into the same shape it was before ;p [13:37:29] addshore: ok [13:37:46] as long as we document how we do the non-puppet stuff then ok [13:38:14] hashar: whats the time scale on getting the awesome labs jenkins stuff up? ;p [13:40:55] (03PS4) 10Hoo man: Only use the best Claims in mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 [13:41:19] (03CR) 10Hoo man: "Rebased to make WikidataJenkins run again *sigh*" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [13:41:33] DanielK_WMDE_: https://gerrit.wikimedia.org/r/117847 review? [13:42:04] Tobi_WMDE: Lydia_WMDE: Anyone on https://bugzilla.wikimedia.org/show_bug.cgi?id=61854 yet? [13:42:21] "Don't link deleted items in the UI", taht is [13:42:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [13:42:49] addshore: a few months? [13:43:30] addshore: I got too many parallels projects already. The trick is finding out a way to get composer installed on the instances. Ideally using a debian package, most realistically via a git repository like integration/composer.git [13:43:36] and git::clone() on all labs instance [13:44:36] hoo: https://github.com/wmde/puppet-composer [13:44:42] rather simple [13:44:56] err hashar [13:45:08] :D [13:45:32] idea is to maintain composer in one place, as we use it for many things [13:45:56] hehe [13:46:09] hashar: if you think this solution is acceptable enough for ops, i can submit it to gerrit :) [13:46:17] we could add composer.phar in integration/jenkins.git under /tools/ maybe [13:46:25] na ops will reject it [13:46:26] sure [13:46:28] heh [13:46:36] a binary file in ops/puppet is a nono [13:46:45] it was also suggested at some point to pack a phpunit with core [13:46:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [13:46:50] and they will definitely ask to use git-deploy for that [13:46:58] pack phpunit with core O_O /me dies [13:47:14] but we can get it in integration/jenkins.git under /tools/ That will end up being fetched as /srv/deployment/integration/slave-scripts/tools/composer.phar [13:47:25] works for me [13:47:53] but i guess we cant actually use it until the labs move ;p [13:48:59] (03CR) 10Aude: "we can use FormOptions, as we don't care about backwards compat (and too late in other parts of wikibase)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [13:49:23] wikibase depends on core master [13:49:59] (03CR) 10Hoo man: "mh? Commented on the wrong change?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [13:50:17] (03PS3) 10Addshore: Fix ALL of the phpdocs! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 [13:50:21] hoo: no [13:50:31] (03CR) 10jenkins-bot: [V: 04-1] Fix ALL of the phpdocs! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [13:50:33] aude: I don't get it then [13:50:42] i don't get filter options then [13:50:43] RecentchangesFilterOptions also uses FormOptions [13:50:45] is taht a class? [13:50:48] yep [13:50:51] where? [13:50:53] client/includes/recentchanges/RecentChangesFilterOptions.php [13:51:00] you wrote it, even :D [13:51:08] oh, i thought you talked about core [13:51:21] oh no [13:51:31] those options were an array [13:51:37] now they use FormOptions [13:51:55] so we can move to the class, or am I missing something? [13:52:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [13:52:32] (03CR) 10Hoo man: [C: 032] "Sane now :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [13:52:40] (03CR) 10jenkins-bot: [V: 04-1] Fix ALL of the phpdocs! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [13:52:42] (03PS4) 10Addshore: Fix ALL of the phpdocs! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 [13:52:44] rebased [13:52:50] yeah, just noticed that... [13:52:53] :P [13:53:22] waiting for the jenkins then [13:53:25] i think watchlist query hook having $opts is also new [13:53:31] yes, we can use that [13:53:32] what's the plural of jenkins, btw? [13:54:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [13:54:25] ah, Jenkinses [13:54:33] yay for wiktionary :) [13:54:34] allthejenkins [13:54:48] xD [13:54:51] https://en.wiktionary.org/wiki/Jenkins [13:55:51] is there a collective noun for Jenkinses? Like, "an interference of Jenkinses" or something? [13:55:55] * DanielK_WMDE_ loves collective nouns [13:56:35] whats the color temp of the screens in the office? :P [13:56:44] Jenki! xD [13:57:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [13:57:24] hm, according to https://en.wikipedia.org/wiki/List_of_collective_nouns, the collective noun for boys is "blush". [13:57:26] go figure :P [13:57:33] (03CR) 10Hoo man: [C: 032] "Here we go (after the last of the jenkinses ran)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [13:57:40] xD [13:58:02] I also like "a cackle of hyenas". [13:59:18] (02:42:04 PM) hoo: Tobi_WMDE: Lydia_WMDE: Anyone on https://bugzilla.wikimedia.org/show_bug.cgi?id=61854 yet? [13:59:20] and I support to change the collective noun for "quid" to "squad" http://boingboing.net/2012/11/15/a-group-of-squid-is-called-a.html [13:59:31] (03Abandoned) 10Addshore: DNM Testing new WikidataJenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118265 (owner: 10Addshore) [13:59:53] hoo: yes. tip of the ice berg. BIG mess lurking there. [14:00:23] we discussed it this morning, will try to tackle it next sprint. 3 weeks to having it live [14:00:52] mh... k [14:01:18] we could try a quick and dirty hack, but that would mean quite a bit of extra db queries (potentially, one per linked item). [14:02:06] DanielK_WMDE_: Memcached would catch most of that, but yeah [14:02:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118469 (owner: 10Addshore) [14:03:05] addshore: Don't steal my merges :D [14:03:09] :P [14:03:10] hoo: no it wouldn't. [14:03:36] well, at least not trivially. [14:04:33] DanielK_WMDE_: We could abuse LinkCache or so [14:05:21] hoo: yes. we could. [14:05:29] finding out how to do this best will take a bit of time [14:07:14] I see [14:11:46] [13ValueView] 15adrianlang 04force-pushed 06ValueFormatterForTime from 14d78763c to 142315040: 02http://git.io/yI81oA [14:11:46] 13ValueView/06ValueFormatterForTime 142315040 15Adrian Lang: Use ValueView's formatting and parsing in TimeValue [14:12:06] TitleValue needs another rebase :( [14:13:01] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4fd99dc : addshore The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20768633 [14:14:07] DanielK_WMDE_: congrats for getting shell, btw :) [14:14:19] + again [14:17:24] Tobi_WMDE: https://stackoverflow.com/questions/14849446/php-parse-date-in-iso-format [14:18:30] hoo: :) [14:18:32] yay. [14:18:35] There are several different functions for parsing different fuzzy representations of time, but not a single one to parse ISO [14:18:44] now I need to learn how to use it :) [14:19:03] DanielK_WMDE_: read puppet and wikitech.wikimedia.org [14:19:29] Tobi_WMDE: https://stackoverflow.com/questions/4411340/php-datetimecreatefromformat-doesnt-parse-iso-8601-date-time that sounds better [14:19:32] not today :) [14:21:06] DanielK_WMDE_: Do you plan to get the rights to deploy later? [14:21:22] Or just for investigation [14:21:30] hoo: just investigation for now [14:21:31] deploy is easy, except to figure out what to do when things break [14:21:39] i don't think i need deployment rights. [14:21:46] aude: :D [14:21:50] Adrian_WMDE: what about http://www.php.net/manual/de/function.date-parse-from-format.php [14:21:54] Probably... aude or I are mostly around :P [14:22:01] * and/or, even [14:22:03] and still ree.dy [14:22:04] aude: you got yourself a quib! [14:22:15] :) [14:24:47] Tobi_WMDE: Adrian_WMDE remember if you use http://www.php.net/manual/de/function.date-parse-from-format.php you can only use upto 4 digit dates and no localization ;p [14:25:37] addshore: our current problem is, how do we get the year out of this string: +00000002014-10-10T00:00:00Z [14:25:47] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Insert badges for language links on client (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [14:26:03] get the year out? why? where? :P [14:27:24] HtmlTimeFormatter::calendarNameNeeded() :-P [14:27:59] ahh [14:28:06] just explode at the first '-' [14:28:13] and then remove the first chaarcter :P [14:28:17] and then you have the year xD [14:28:47] addshore: seriously? [14:29:09] yup :P, or use the regex in the formatters to split the whole string, but thats basically what it does [14:29:15] the format is always the same so.. [14:29:45] /^(\+|\-)((\d{0,7})?(\d{4}))-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2})Z/ in MwTimeIsoFormatter.php [14:30:05] addshore, Tobi_WMDE: careful about the first "-": that might be the first character, if the years is BC. [14:30:17] HAHA DanielK_WMDE_ ! indeed :P [14:40:43] (03CR) 10Hoo man: Insert badges for language links on client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [14:49:26] [13ValueView] 15tobijat closed pull request #30: Use ValueView's formatting and parsing in TimeValue (06master...06ValueFormatterForTime) 02http://git.io/dpX_uA [14:52:13] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Only use the best Claims in mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [14:52:22] \o/ [14:52:36] (03Merged) 10jenkins-bot: Only use the best Claims in mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [14:54:04] (03CR) 10Daniel Kinzler: "Why does Jenkins say "Fatal error: Class 'Capiunto\RecursiveDirectoryIterator' not found"??" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [14:54:16] oh yikes [14:55:27] hoo: $out->addModules( 'capiunto.infobox.main' ); <--- no longer needed? [14:55:52] oh, i see. i guess. uh... [14:55:54] DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/105157/10/Capiunto.hooks.php Sadly it is [14:56:21] we could do it from Lua using wgOut or so, but that's nasty also [14:56:44] hoo: but you are removing it here? https://gerrit.wikimedia.org/r/#/c/100411/5/Capiunto.hooks.php [14:56:57] [13ValueView] 15adrianlang created 06removeBifidExpert (+1 new commit): 02http://git.io/W8ayng [14:56:57] 13ValueView/06removeBifidExpert 14de526a1 15Adrian Lang: Remove BifidExpert, make ValueView handle static mode... [14:56:59] (03CR) 10Hoo man: "This version is broken, this is being fixed in https://gerrit.wikimedia.org/r/105157 Also this is only an experiment, which we maybe want " [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [14:57:37] hoo: so, that's essentially CR-2 [14:57:43] DanielK_WMDE_: Yeah... back then I thought it might be a good idea to have all calls go through the parser function... also that change was more of an experiment [14:57:45] yep [14:57:46] will do [14:57:48] ok [14:57:57] (03CR) 10Hoo man: [C: 04-2] Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [15:01:47] (03PS1) 10Adrian Lang: Update EntityId expert(s) to reflect changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 [15:02:12] [13ValueView] 15adrianlang opened pull request #33: Remove BifidExpert, make ValueView handle static mode (06master...06removeBifidExpert) 02http://git.io/6mgWxg [15:02:13] (03CR) 10Adrian Lang: "Needs https://github.com/wmde/ValueView/pull/33" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [15:02:15] (03CR) 10Daniel Kinzler: [C: 04-1] Refactor confusing getting of IDs from Term objects (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [15:03:29] Why is Gerrit Notification Bot reopening bugs whenever we cherry pick? :/ [15:03:29] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [15:07:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [15:08:07] [13Time] 15JeroenDeDauw 04deleted 06rmChangel at 14d0fd262: 02http://git.io/YLC--Q [15:08:22] Tobi_WMDE: https://github.com/DataValues/Time [15:22:49] (03CR) 10Jeroen De Dauw: [C: 04-1] "I remember discussing this with Thiemo and concluding that making this change is not worthwhile now, and better waits until after we chang" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [15:23:00] (03PS2) 10Tobias Gritschacher: Update EntityId expert(s) to reflect changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [15:23:22] DanielK_WMDE_: addshore: this needs to move https://gerrit.wikimedia.org/r/#/c/114490/ [15:23:44] DanielK_WMDE_: you started with this in December and it is still not done [15:24:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [15:24:35] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118705 (owner: 10Adrian Lang) [15:26:07] (03PS10) 10Tobias Gritschacher: Make frontend call backend time parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [15:27:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [15:27:43] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117197 (owner: 10Addshore) [15:28:31] sandaru i have edited a page in Wikidata https://www.wikidata.org/wiki/Q100917#sitelinks-wikipedia [15:29:12] But I am unable to add wikisource to this [15:29:44] (03CR) 10Jeroen De Dauw: [C: 04-1] Fix watchlist hook query in client (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118458 (owner: 10Aude) [15:29:57] Like what should i write under Languag and code [15:30:14] (03CR) 10Jeroen De Dauw: [C: 031] Initialize rank selector on the right element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118695 (owner: 10Adrian Lang) [15:37:21] (03CR) 10Jeroen De Dauw: [C: 04-1] Move isTitleInEntityNamespace to NamespaceUtils with tests (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118688 (owner: 10Aude) [15:38:54] (03CR) 10Jeroen De Dauw: [C: 031] Updated DataTypes dependency to 0.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118674 (owner: 10Henning Snater) [15:41:21] (03CR) 10Jeroen De Dauw: [C: 031] Don't redraw headings (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118672 (owner: 10Adrian Lang) [15:45:55] shrees: You should write the id of the wikisource (under the form LANGUAGE_CODEwikisource like enwikisource or dewikisource) [15:46:38] there is a powerful autocomplete system so write "English" or "Deutsch" works too [15:48:37] (03CR) 10Jeroen De Dauw: [C: 04-1] "If I'm understanding this commit correctly, it adds generation code for "other projects" in a different place than the "main project" gene" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [16:10:16] [13WikibaseDataModel] 15JeroenDeDauw created 06deprecate (+1 new commit): 02http://git.io/rHVwWA [16:10:16] 13WikibaseDataModel/06deprecate 147c72bf6 15jeroendedauw: Deprecate Property::newEmpty [16:10:57] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #29: Deprecate Property::newEmpty (06master...06deprecate) 02http://git.io/rZ6mtQ [16:13:31] [travis-ci] wmde/WikibaseDataModel/deprecate/7c72bf6 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/20778161 [16:20:50] (03PS1) 10Tobias Gritschacher: Fix HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 [16:22:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [16:23:52] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06PropertyDeserializer (+2 new commits): 02http://git.io/L15Azw [16:23:52] 13WikibaseInternalSerialization/06PropertyDeserializer 144a17038 15jeroendedauw: Added foundation for PropertyDeserializer [16:23:52] 13WikibaseInternalSerialization/06PropertyDeserializer 149492536 15jeroendedauw: Add EntityId deserialization to PropertyDeserializer [16:24:02] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #14: Add PropertyDeserializer (06master...06PropertyDeserializer) 02http://git.io/_jYTAg [16:26:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [16:26:57] [travis-ci] wmde/WikibaseInternalSerialization/PropertyDeserializer/9492536 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/20779221 [16:28:33] (03PS2) 10Tobias Gritschacher: Fix HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 [16:29:50] (03PS3) 10Tobias Gritschacher: Fix HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 [16:30:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [16:30:36] after thinking almost half a day, it was easy in the end [16:31:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [16:35:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [16:36:43] (03CR) 10Tobias Gritschacher: [C: 032] Updated DataTypes dependency to 0.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118674 (owner: 10Henning Snater) [16:37:13] (03Merged) 10jenkins-bot: Updated DataTypes dependency to 0.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118674 (owner: 10Henning Snater) [16:39:39] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06PropertyDeserializer: 02http://git.io/R7oRYg [16:39:39] 13WikibaseInternalSerialization/06PropertyDeserializer 14f7d7f3c 15jeroendedauw: Add term deserialization to PropertyDeserializer [16:40:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [16:40:06] hoo|away: https://github.com/wmde/WikibaseInternalSerialization/blob/PropertyDeserializer/tests/unit/Deserializers/PropertyDeserializerTest.php [16:40:40] Tobi_WMDE: easy review is easy https://github.com/wmde/WikibaseInternalSerialization/pull/14 [16:41:07] (03CR) 10Addshore: [C: 04-1] Fix HtmlTimeFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [16:41:13] Tobi_WMDE: ^^ [16:41:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5cc3408 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20780083 [16:42:52] [travis-ci] wmde/WikibaseInternalSerialization/PropertyDeserializer/f7d7f3c : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/20780275 [16:47:27] addshore: this also not works in the parser.. ;) [16:48:04] Tobi_WMDE: In the parser I split the time with regex then pass a 4 digit date into the DateTime object and then glue the rest of the year onto the formatted value :P [16:48:27] wait, thats in the formatter :P [16:48:34] 12.12.12345 -> The format of the time could not be determined. Parsing failed. [16:48:57] make a bug for it! :P [16:50:06] why is this even.. [16:50:14] ??? :P [16:53:38] PHP will get MASSIVE problems when we pass the year 9999 [16:55:03] :P [16:55:11] make some bugs and CC me :P [16:55:27] iv got a few patches in progress for the TODOs and stuff [17:03:31] (03PS4) 10Tobias Gritschacher: Fix HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 [17:04:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:05:57] [13WikibaseInternalSerialization] 15tobijat closed pull request #14: Add PropertyDeserializer (06master...06PropertyDeserializer) 02http://git.io/_jYTAg [17:06:18] addshore: reused the regex from mwtimeformatter now [17:09:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:10:09] (03CR) 10Addshore: Fix HtmlTimeFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:10:11] Tobi_WMDE: ^^ [17:10:35] addshore: u still have wmde email? [17:10:41] I guess :P [17:10:53] i should keep it till end of april :P [17:11:04] ok, I've just created a bug.. [17:11:43] hmm? [17:11:49] addshore: leaving or what? [17:13:19] addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=62648 [17:13:24] was not able to add you to cc [17:13:28] (03CR) 10Tpt: "Language links generation code relies on MediaWiki core language links system. Its generation logic can't be shared because language links" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [17:13:32] lazowik: yup [17:13:40] Tobi_WMDE: added myself :) [17:13:49] yay [17:14:59] (03PS5) 10Tobias Gritschacher: Fix HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 [17:15:07] addshore: ^^ [17:15:40] addshore: thanks for the great work and support then! [17:15:45] and let the Q1093766 be with you :) [17:15:55] Tobi_WMDE: what would you say if I asked you to add a testcase with a year like 1111111? ;p [17:16:04] lazowik: I will still be around ;p [17:16:18] youll never manage to get rid of me ;p [17:16:20] sure [17:16:22] addshore: I would say: good idea!! [17:16:22] :D [17:16:24] :) [17:16:29] :D [17:16:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:16:45] emoticons war! :O \o/ [17:17:32] addshore: whats the deal with jenkins? [17:17:35] any progress? [17:18:00] dont think its worth trying to puppetise it any further, and i still cant get the dame phpunit to work, think it needs a new set of eyes on it [17:18:11] (03PS6) 10Tobias Gritschacher: Fix HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 [17:18:15] (03PS4) 10Tpt: Implements the "other project" section in sidebar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 [17:18:35] will hopefully be able to move back to the WMF jenkins again in a few months [17:19:01] (03CR) 10Tpt: "PS4: split OtherProjectSidebarGenereator::buildProjectLinkSidebar()" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [17:19:13] addshore: ok, so, is the instance final then? [17:19:35] or do we build a new one [17:19:41] I guess we should rename it :P so make a new one, but running puppet should set everything up first time without a hitch [17:19:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:19:53] then just need to run the jenkins job builder and it will add the jobs to it too! [17:20:21] addshore: ok. great. will do this on monday then, if you didn't do it first.. ;) [17:20:29] :P [17:20:44] addshore: food arrived! [17:20:48] xD [17:21:06] I'm having fish and chips tonight ;p [17:21:12] awww [17:21:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [17:21:42] reminds me that I'm hungry. will leave.. change should be fine now [17:21:53] yup, will merge it if jenkins says yes :> [17:22:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:26:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:31:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [17:50:34] (03CR) 10Addshore: [C: 032] Fix HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118711 (owner: 10Tobias Gritschacher) [17:59:18] (03CR) 10Daniel Kinzler: "I'll rebase, tweak and hint down the fatal error." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [18:01:02] DanielK_WMDE_: how do you hint down an error ? ;p [18:06:15] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/cd6c94b : Addshore The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20786276 [18:37:52] (03PS4) 10Daniel Kinzler: (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 [18:38:29] (03CR) 10Daniel Kinzler: "PS4 is a rebase. Had to manually re-apply changes in SearchEntities.php." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [18:39:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [18:41:40] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [18:53:06] (03PS5) 10Daniel Kinzler: (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 [18:53:17] (03CR) 10jenkins-bot: [V: 04-1] (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [18:54:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [18:58:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [18:58:58] (03PS5) 10Daniel Kinzler: Check namespace before initializing on client. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 [18:59:14] (03CR) 10Daniel Kinzler: "PS5 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [19:00:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [19:04:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [19:08:12] (03PS6) 10Daniel Kinzler: Check namespace before initializing on client. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 [19:09:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [19:10:45] (03CR) 10Daniel Kinzler: "@hoo: we do have tests for this, and this doesn't break MergeItems because it fixes the respective lines in ChangeItems..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [19:11:32] so... wikidatajenkins is broken. again. [19:13:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [19:15:23] (03PS6) 10Daniel Kinzler: (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 [19:15:34] (03CR) 10jenkins-bot: [V: 04-1] (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [19:17:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [19:18:15] (03PS7) 10Daniel Kinzler: (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 [19:18:58] (03CR) 10Daniel Kinzler: "PS7 is a rebase + fix; ChangeOpsMerge and ChangeOpsMergeTest needed manual fiddeling." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [19:19:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [19:20:33] (03PS6) 10Daniel Kinzler: (bug 62381) Chunked ID query for JSON dumper. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 [19:20:59] (03CR) 10Daniel Kinzler: "PS6 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [19:21:52] (03PS7) 10Daniel Kinzler: Check namespace before initializing on client. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 [19:22:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [19:22:57] (03PS7) 10Thiemo Mättig (WMDE): Refactor confusing getting of IDs from Term objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [19:23:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [19:24:14] (03PS5) 10Daniel Kinzler: (bug 62491) don't use EntityContent in API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 [19:25:14] noisy [19:25:38] :) [19:26:19] well, trying to follow up on a bunch of minor issues and running into rebase hell [19:26:25] and now gerrit is timing out [19:26:29] oh, well. time to go home i guess [19:29:16] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [19:33:58] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [19:34:42] DanielK_WMDE_: gute nacht && (de-DE)"weekend" [19:35:47] jeremyb: thanks, have a good time, too :) [19:37:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [19:43:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [19:47:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113941 (owner: 10Daniel Kinzler) [19:52:08] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [19:56:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118313 (owner: 10Daniel Kinzler) [19:57:44] (03CR) 10Thiemo Mättig (WMDE): "> this change is not worthwhile now, and better waits" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [20:30:20] (03PS8) 10Thiemo Mättig (WMDE): Refactor confusing getting of IDs from Term objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [20:31:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [20:36:10] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [20:38:55] (03CR) 10Thiemo Mättig (WMDE): (bug 62381) Chunked ID query for JSON dumper. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118277 (owner: 10Daniel Kinzler) [21:15:28] P373 is more complaining about the input then before…