[05:48:20] Lydia_WMDE : hi, I have a question about wikidata outreach project. [07:01:33] sandaru: hey :) [07:01:36] please ask [07:02:18] hi [07:02:55] you can thank people for an edit [07:03:18] there is a thanks link for that in the article history for example [07:03:41] i am also sending out t-shirts and other small things every now and then but quite rarely [07:03:46] yeha i have seen that apart from that is there any process like you get a reward or something if you excee 50 000 contributions or something similar? [07:04:22] rewars is like a badge or something that you can have on your user page [07:04:26] *reward [07:04:37] i don't think we have that yet [07:05:11] do you think it would be a good idea? [07:05:38] worth exploring [07:05:44] but also potentially dangerous [07:05:58] look into extrinsic vs. intrinsic motivation [07:06:02] oooh thanks for the feed back [07:06:13] (which doesn't mean we shouldn't look into it further) [07:06:35] I'm currently writing a draft proposal [07:07:26] I would think more on that [07:07:28] :) [07:07:32] cool :) [10:06:10] (03CR) 10Lydia Pintscher: [C: 04-1] "I think this should not go in as explained in the bug report. Sorry :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80778 (owner: 10Burthsceh) [10:10:25] thanks, Lydia_WMDE :) [10:10:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117837 (owner: 10WikidataBuilder) [10:10:38] hoo: np - should have done that earlier... [10:11:50] (03CR) 10Hoo man: [C: 032] Remove references to non-existing class IriValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117838 (owner: 10Adrian Lang) [10:12:11] (03Merged) 10jenkins-bot: Remove references to non-existing class IriValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117838 (owner: 10Adrian Lang) [10:12:31] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117838 (owner: 10Adrian Lang) [10:20:10] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/786eccb : Adrian Lang The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20443909 [10:32:54] (03CR) 10Addshore: [C: 032] New Wikidata Build - 10/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117837 (owner: 10WikidataBuilder) [10:45:11] Lydia_WMDE, Tobi_WMDE: joining the hangout now [10:57:29] (03PS1) 10Hoo man: Only use the best Claims in PropertyParserFunctionRenderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117841 [11:02:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117841 (owner: 10Hoo man) [11:04:55] addshore: hoo https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-AbuseFilter/ [11:05:34] 265 complexity, wow [11:05:40] I got a bad, bad feeling :P [11:06:04] that's like 100 more than EditEntity https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-Wikibase/code-structure/master [11:06:33] JeroenDeDauw: hoo ewwwwwwwwwwwwwwwww [11:07:46] Well :P [11:08:14] Could have been worse... eg. CentralAuth (which also is not very important for WMF) has *no* unit tests at all [11:10:52] hoo :< [11:14:06] Lydia_WMDE: DanielK_WMDE_: hey... https://bugzilla.wikimedia.org/show_bug.cgi?id=62191 [11:14:21] if we want to provide a switch to have it return everything... how should that switch look like? [11:14:50] entity:formatPropertyValues( 'P123', true ) [11:14:53] mh? [11:18:59] hoo: no, it should not be a boolean param. It should probably take a list of acceptable ranks. [11:19:06] mh [11:19:20] that would force the Lua user to know the integer values :/ [11:19:44] for the Claim::RANK_* constants, I mean [11:19:49] hoo: why? is there no way to declare clonstants in lua? [11:19:59] if all else fails, use strings [11:20:44] grr. "clonstants". [11:21:06] well, I could create mw.wikibase.entity.claimsRanks.RANK_* or os [11:22:17] DanielK_WMDE_: ^ [11:22:32] I could even make that read-only (as Lua support "constant" table via workarounds) [11:22:41] addshore: http://stackoverflow.com/questions/14950408/how-to-install-a-plugin-in-jenkins-manually [11:22:43] sounds good [11:23:01] we'd need something like this in any case, for checking/comparing ranks [11:23:34] Yeah, I guess so [11:23:51] It's fine if I hard code these RANKS in Lua, I guess, no need to fetch that from PHP?! [11:29:59] hoo: DanielK_WMDE_: But I think there should be a special argument for requesting all ranks. Otherwise, the user would need to know which ranks exist [11:30:22] Adrian_WMDE: The user can iterate over mw.wikibase.entity.claimsRanks [11:30:27] ok [11:30:36] that's a Lua table, very much like an object in JS [11:38:37] rage [11:38:40] DanielK_WMDE_: Could not update the page. It appears to have been deleted. :< [11:38:45] Special:NewItem is broken [11:38:51] and NewProperty [11:57:53] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117837 (owner: 10WikidataBuilder) [12:08:47] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/8SCqpA [12:08:47] 13scrumbugz/06master 14753a8c7 15Christopher Johnson: requirements.txt [12:08:57] DanielK_WMDE_: \o/ one less confused person I need to enlighten (re wiktionary thread) [12:09:58] Adrian_WMDE: aaaaaah https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-Wikibase/inspections/0e767d85-9d50-4bd9-b445-af71a4451942 [12:11:10] oh noooooooo [12:12:38] informmation :P [12:12:49] obvious typo is obvious [12:17:37] (03PS20) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [12:19:20] (03PS1) 10Hoo man: Only use the best Claims in mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 [12:21:52] (03PS2) 10Hoo man: Only use the best Claims in PropertyParserFunctionRenderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117841 [12:24:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [12:29:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [12:33:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117841 (owner: 10Hoo man) [12:35:24] DanielK_WMDE_: Tobi_WMDE: Anyone working on https://bugzilla.wikimedia.org/show_bug.cgi?id=62378 ? [12:35:30] If not, I'll take it [12:36:29] hoo: it is on the board in todo. but DanielK_WMDE_ might work on it.. better check with him [12:37:21] Tobi_WMDE: Ok, let's wait for him... do I have an own Pin with my face on it on the board, btw? [12:37:35] Abraham wanted to create one, never checked that I have :P [12:37:41] * he has [12:37:47] hoo: you have a colored magnet without a face.. [12:38:04] but we definitely need to get one with your face. :-P [12:40:06] heh... whenever I'm in Berlin again :P [12:40:30] hoo: or if you have a proper photo, just send it. ;) [12:42:52] you could use my Facebook profile picture, I guess :P [12:43:06] hoo: ok. we'll check that [12:43:08] ;) [12:44:06] hoo: also, SpecialNewEntity broke due to the editentity refactoring. if you want, you could have a look.. I guess no one is looking into that one at the moment.. [12:44:14] addshore: DanielK_WMDE_ aude ?? ^^ [12:44:36] I can, if aude isn't doing atm [12:44:42] I havnt looked at it yet [12:45:09] * aude assumes daniel broke it, but if he's not looking then go ahead [12:45:29] * aude assume he is away at the moment [12:46:58] aude: Ok, will fix it then... today we go for: "Enable GuidedTour on testwikidatawiki.", btw ;) [12:47:06] yay [12:47:12] wooho [12:52:37] ... and done [12:54:11] (03PS1) 10Hoo man: Fix SpecialNewEntity by specifing edit flags for SpecialWikibaseRepoPage::saveEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117851 [12:59:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117851 (owner: 10Hoo man) [13:03:25] (03CR) 10Henning Snater: [C: 032] Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:03:51] (03Merged) 10jenkins-bot: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:04:56] (03PS1) 10Hoo man: Use an uncached EntityRevisionLookup in the DumpJson maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 [13:10:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 (owner: 10Hoo man) [13:11:12] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/eb334f6 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20452538 [13:13:38] hoo: 62378 should be a one-liner. Make sure it uses getEntityRevisionLookup() and provide the "uncached" flag. that should be it. [13:13:52] DanielK_WMDE_: It's already in gerrit [13:14:24] https://gerrit.wikimedia.org/r/117853 [13:15:16] works locally, but I don't have enough data to measure the performance impact [13:17:53] (03CR) 10Daniel Kinzler: [C: 04-1] "see comments. ...or make getEntityLookup() also take an "uncached" flag (should be simple enough)." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 (owner: 10Hoo man) [13:18:05] hoo: hm, that was just too easy :P [13:19:02] hoo: there should be no impact in speed except for "machine doesn't start swapping" and "memcached isn't flooded" [13:19:15] (03CR) 10Addshore: [C: 04-1] Add optional calendar name to HTML-formatted times (0315 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [13:20:28] Well, I'm quite sure it has a performance impact to have a static array with multiple million values, even if the machine isn't swapping out :P [13:25:44] DanielK_WMDE_: So... shall I switch JsonDumpGenerator to use a EntityRevisionLookup now? [13:30:24] hoo: probably easier to make getEntityLookup accept and pass on the "uncached" flag [13:30:38] hoo: probably in both, Store and WikibaseRepo [13:30:40] DanielK_WMDE_: But that would be inconsistent with the Store interface [13:30:52] how so? [13:31:11] public function getEntityLookup(); [13:31:16] what's it currently defines [13:31:28] I could of course alter that throughout the stack [13:41:58] (03PS2) 10Hoo man: Use an uncached EntityRevisionLookup in the DumpJson maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 [13:47:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 (owner: 10Hoo man) [13:48:07] (03PS3) 10Hoo man: Use an uncached EntityLookup in the DumpJson maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 [13:53:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 (owner: 10Hoo man) [14:01:06] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/KthIWA [14:01:06] 13scrumbugz/06master 143a6c5da 15Christopher Johnson: Update requirements.txt [14:02:33] (03CR) 10Tobias Gritschacher: [C: 04-1] "Unfortunately, for me this breaks functionality:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [14:02:35] (03CR) 10Jens Ohlig: Only use the best Claims in mw.wikibase.entity.formatPropertyValues (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [14:03:18] (03PS4) 10Adrian Lang: Add optional calendar name to HTML-formatted times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 [14:04:03] (03CR) 10Jens Ohlig: [C: 032 V: 032] Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [14:04:07] (03CR) 10jenkins-bot: [V: 04-1] Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [14:05:11] (03CR) 10Jens Ohlig: [C: 031 V: 031] Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [14:05:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [14:09:04] (03CR) 10Hoo man: "re" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117847 (owner: 10Hoo man) [14:10:26] (03CR) 10Addshore: [C: 04-1] "Should have a HtmlTimeFormatterTest.php" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [14:11:41] Hi! I've just found strange thing on https://www.wikidata.org/wiki/Q35900. In display mode it shows "female" for "sex or gender", but when you try to edit it, it shows "male". Is it known bug? [14:12:02] DixonD_: purge [14:12:10] there was some vandalism on the male/female items [14:12:40] yes, it worked [14:12:44] :) [14:12:44] ok [14:16:17] (03CR) 10Addshore: Add optional calendar name to HTML-formatted times (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [14:17:32] (03PS1) 10Daniel Kinzler: (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 [14:17:58] DanielK_WMDE_: SpecialModifyŦerm :D [14:19:08] DanielK_WMDE_: https://gerrit.wikimedia.org/r/117851 please merge that one first... stuff shouldn't be broken on master [14:21:12] (03PS1) 10Daniel Kinzler: (bug 62210) Avoid EntityContent::save in lib tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117859 [14:23:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [14:23:47] (03PS1) 10Daniel Kinzler: (bug 62210) Use EntityStore for maintenance scripts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117860 [14:27:12] hoo: having a coffee, then reviewing your stuff and following up on comments [14:27:29] ok :) [14:28:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117859 (owner: 10Daniel Kinzler) [14:33:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117860 (owner: 10Daniel Kinzler) [14:48:55] nice easy one for whoever wants it >> https://gerrit.wikimedia.org/r/#/c/117863/ [14:49:46] "Parsing of nested values" huh [14:49:48] Do we have any such values anywhere? [14:49:57] (03CR) 10Tobias Gritschacher: "needs a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [14:51:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117863 (owner: 10Addshore) [14:51:25] addshore: deuglify :) [14:51:54] (03CR) 10Aude: [C: 032] Make WikibaseValueFormatterBuilders stuff more readable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117863 (owner: 10Addshore) [14:52:49] (03Merged) 10jenkins-bot: Make WikibaseValueFormatterBuilders stuff more readable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117863 (owner: 10Addshore) [14:55:35] (03PS7) 10Addshore: Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 [14:55:51] (03CR) 10Addshore: Cleanup Wikibase Permissions / Rights (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [14:58:32] (03PS5) 10Addshore: Add optional calendar name to HTML-formatted times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [15:01:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [15:02:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c7c1252 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20459588 [15:03:33] (03CR) 10Tobias Gritschacher: [C: 032] Fix SpecialNewEntity by specifing edit flags for SpecialWikibaseRepoPage::saveEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117851 (owner: 10Hoo man) [15:03:54] (03Merged) 10jenkins-bot: Fix SpecialNewEntity by specifing edit flags for SpecialWikibaseRepoPage::saveEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117851 (owner: 10Hoo man) [15:04:21] (03PS6) 10Addshore: Add optional calendar name to HTML-formatted times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [15:07:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [15:11:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [15:11:57] (03PS1) 10Addshore: Add more tests for HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117868 [15:12:27] (03PS1) 10Addshore: Fix HtmlUrlFormatterTest covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117869 [15:12:38] easy one at the end there for whoever wants it :> [15:14:53] (03CR) 10Addshore: [C: 032] Add optional calendar name to HTML-formatted times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117833 (owner: 10Adrian Lang) [15:16:57] (03CR) 10Tobias Gritschacher: [C: 032] Fix HtmlUrlFormatterTest covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117869 (owner: 10Addshore) [15:17:18] (03Merged) 10jenkins-bot: Fix HtmlUrlFormatterTest covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117869 (owner: 10Addshore) [15:18:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117868 (owner: 10Addshore) [15:18:41] (03CR) 10Daniel Kinzler: [C: 032] Use an uncached EntityLookup in the DumpJson maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 (owner: 10Hoo man) [15:19:03] (03Merged) 10jenkins-bot: Use an uncached EntityLookup in the DumpJson maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117853 (owner: 10Hoo man) [15:20:53] (03PS2) 10Daniel Kinzler: (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 [15:21:03] (03CR) 10jenkins-bot: [V: 04-1] (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [15:21:06] (03CR) 10Tobias Gritschacher: [C: 032] Add more tests for HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117868 (owner: 10Addshore) [15:22:20] (03Merged) 10jenkins-bot: Add more tests for HtmlTimeFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117868 (owner: 10Addshore) [15:23:46] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117869 (owner: 10Addshore) [15:28:00] (03CR) 10Addshore: [C: 04-1] "needs manual rebase :?//./" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [15:28:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [15:28:14] (03CR) 10Tobias Gritschacher: [C: 032] Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [15:28:36] (03Merged) 10jenkins-bot: Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [15:29:15] aude: Do we collect deployment notes for the next deploy anywhere? [15:29:46] hmm, im not entirly sure that not is appropriate any more, I guess aude would know more! [15:30:15] (03PS4) 10Aude: Remove references to Wikidata in recent changes preference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 [15:30:42] hoo: we do, although i was on holiday and didn't do it yet [15:31:02] https://www.mediawiki.org/wiki/Wikidata_deployment [15:31:16] aude: And for the next deploy0 [15:31:19] * ? [15:31:23] Like stuff we merge now [15:31:31] add a new section [15:31:45] wmf19, then, I guess [15:31:59] (these shoudl be organized better sometime (or we can archive them once we are 1.24) [15:32:02] ) [15:32:33] (03PS3) 10Daniel Kinzler: (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 [15:32:43] (03CR) 10jenkins-bot: [V: 04-1] (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [15:34:21] (03PS4) 10Daniel Kinzler: (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 [15:34:37] (03PS6) 10Addshore: Refactor confusing getting of IDs from Term objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 [15:34:47] aude: Updated [15:34:47] (03CR) 10jenkins-bot: [V: 04-1] (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [15:35:08] thanks [15:35:58] the new rights can be added anytime [15:36:02] for oauth [15:36:21] they just won't do anything yet (and we have to remove the old ones later) [15:36:25] Yeah, but we probably want to remove the old ones in the same commit :P [15:36:31] we can't [15:36:45] why not? [15:36:46] we'll have new ones on test.wikidata, old ones on wikidata [15:36:57] for a few days [15:37:05] well, ok... no need to sacrifice test for this [15:38:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 (owner: 10Aude) [15:41:30] (03CR) 10Tobias Gritschacher: "Please reference the bug number." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [15:42:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [15:43:19] (03PS4) 10Aude: Fix GetClaimsTest, datatype is expected in results [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110102 [15:44:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [15:48:05] * aude wonders why GetClaimsTest does not fail on jenkins but always fails for me [15:49:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [15:49:29] (03PS26) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [15:50:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/68b3d57 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20461452 [15:53:39] (03CR) 10Addshore: [C: 04-1] "needs an ugly rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [15:54:04] (03CR) 10Tobias Gritschacher: [C: 04-1] "needs rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [15:54:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110102 (owner: 10Aude) [15:55:37] why is datatype expected when i run GetClaimsTest but not expected by jenkins [15:55:53] ?? [15:55:59] must be evil global state [15:56:06] settings [15:57:39] (03CR) 10Aude: "I always get:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110102 (owner: 10Aude) [15:58:08] just me apparently [15:58:44] aude: and Jenkins [15:58:56] http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/816/console [15:59:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [15:59:43] it expects the opposite [16:00:28] weird [16:00:32] $wmgUseWikibaseExperimental = false; [16:01:17] (03PS27) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [16:02:59] doesn't seem to matter [16:03:14] aude: mh... ran composer update? [16:03:18] yes [16:03:28] and have had this issue for more than a month [16:03:41] * aude ignoring it, assuming it's just me and my settings [16:03:45] aude: Can I run that test in isolation to see it? [16:04:19] i get it isolated or if i run *all* tests [16:04:57] trying in my test VM with clean settings then [16:05:06] k [16:05:25] - 'datatype' => 'string' [16:05:36] for the latest patch set [16:06:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [16:08:17] its almost like you have an old version of something somewhere aude [16:08:58] I guess it broke ever since https://gerrit.wikimedia.org/r/#/c/108530/ [16:09:15] impossible [16:10:39] addshore: wow, 49 ps [16:10:47] ? [16:10:53] https://gerrit.wikimedia.org/r/#/c/111464/ [16:11:04] oh yeh >.> [16:11:12] * addshore goes to make another patchset.... [16:11:18] (03CR) 10Jeroen De Dauw: [C: 04-1] "Needs moar patchsets" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [16:11:35] (03PS50) 10Addshore: Add backend Time Parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [16:11:38] ;p rebased [16:12:01] (03CR) 10Addshore: [C: 04-1] "restoring previous -1 till i address the cmts" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [16:15:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ccc7ba8 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20461809 [16:16:03] (03PS1) 10Daniel Kinzler: (bug 62210) rm dep on EntityContent from EPPTable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117884 [16:18:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [16:18:14] (03PS5) 10Aude: Fix GetClaimsTest, datatype is expected in results [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110102 [16:18:37] (03CR) 10Aude: [C: 04-2] "needs investigation why it fails for me and not on jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110102 (owner: 10Aude) [16:19:41] addshore: solved https://bugzilla.wikimedia.org/show_bug.cgi?id=62403 [16:19:45] how? :> [16:19:54] seems we need to add yet another plugin.. -_- [16:19:58] haha [16:19:59] xD [16:20:02] what pugin? [16:20:08] I've put the solution in the bug [16:23:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117884 (owner: 10Daniel Kinzler) [16:25:42] JeroenDeDauw: addshore is going to break the patchset record from jeblad [16:26:28] Tobi_WMDE: and then like jeblad he will run away [16:26:41] :) [16:26:48] :( [16:26:50] :< [16:28:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110102 (owner: 10Aude) [16:29:33] (03PS1) 10Aude: add visibility to SerializerFactory constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117886 [16:30:07] aude: Hi! If you have time could you review https://gerrit.wikimedia.org/r/#/c/114979/ [16:30:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9c02be5 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20462246 [16:30:24] Tpt_: ok [16:30:28] thanks [16:31:29] ooooh, i guess at some point some tests leaked into my database [16:31:46] * aude has P9001 in wb_property_info table [16:32:25] if the property is not found, sucky serialization code skips adding datatype [16:32:26] "hey, dude! your tests are leaking!" [16:32:35] in the tests, those properties don't exist [16:32:54] aude: what should the serialization code do instead? [16:33:08] aude: we have to be able to serialize entities that reference non-existing properties.# [16:33:09] property not found? [16:33:14] and we can't know the datatype. [16:33:23] "property not found" where? [16:33:28] It was a mistake to add the property lookup into the serialization code [16:33:54] idk, "missing" ? [16:34:19] anyway, that solves my problem why the test failed [16:34:21] aude: special valuesa are move evil that missing fields, imho [16:34:38] it's icky either way [16:34:45] JeroenDeDauw: yes, the snak objects should have that information, always. then there would be no need for the lookup [16:34:46] aude: DanielK_WMDE_ if either of you submits a commit that changes what happens there, add me [16:34:52] JeroenDeDauw: wouldn't change the issue at hand, though [16:34:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117886 (owner: 10Aude) [16:35:01] DanielK_WMDE_: like I said before, that generalization is wrong [16:35:03] * aude waits for new serialization code [16:35:44] JeroenDeDauw: well, if we want the data type in the serialization (we do), we need to either look it up, or carry it around. [16:36:11] we should at least have it in PropertyValueSnak. Maybe in other snak types, too [16:36:24] wtf [16:36:26] DanielK_WMDE_: having an object that has the type is good, changing the current object to do that is not [16:36:26] "getEntityRevision() called with $revision = false, use 0 instead." [16:36:51] now getting entirely different error (i ran composer update) [16:36:56] aude: just ran into that. fixed it in an (unrelated?) patch set, thought i has somehow exposed it. [16:37:00] DanielK_WMDE_: anyway, this has already been fixed properly now in the new serialization code [16:37:04] DanielK_WMDE_: ok [16:37:04] let me check whether that is on gerrit... [16:37:13] JeroenDeDauw: how exactly? [16:38:16] DanielK_WMDE_: by having an object that is a snak plus a data type [16:39:24] aude: DanielK_WMDE_ yeah, saw this notice with "$revision = false, use 0" too [16:39:36] [13Time] 15addshore 04deleted 06fixCalendarTypo at 14695f5e8: 02http://git.io/C7_DWA [16:39:47] always when loading an item that uses some deleted properties/items [16:39:50] (03Abandoned) 10Aude: Fix GetClaimsTest, datatype is expected in results [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110102 (owner: 10Aude) [16:40:06] (03PS1) 10Daniel Kinzler: (bug 62210) Avoid EntityContent::save in repo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 [16:41:16] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06ItemDeserializer (+4 new commits): 02http://git.io/lmj9gA [16:41:16] 13WikibaseInternalSerialization/06ItemDeserializer 1419db76a 15jeroendedauw: Support legacy claims key in ItemDeserializer [16:41:16] 13WikibaseInternalSerialization/06ItemDeserializer 14c561ace 15jeroendedauw: Add label deserialization to ItemDeserializer [16:41:16] 13WikibaseInternalSerialization/06ItemDeserializer 14738224a 15jeroendedauw: Remove duplication in ItemDeserializer [16:41:35] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #12: Further implement ItemDeserializer (06master...06ItemDeserializer) 02http://git.io/A3M7SA [16:44:23] uh... can't find it now? what gives? it'S a bug in CachingEntityRevisionLookup [16:44:51] DanielK_WMDE_: need stack trace? [16:45:22] only fails in GetClaimsTest::testValidRequests (of all the api tests) [16:45:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 (owner: 10Daniel Kinzler) [16:46:07] aude: no, i know the bug, i just joggled too manch patches and now don't know where i put it :P [16:46:13] DanielK_WMDE_: ok [16:48:33] * DanielK_WMDE_ questions his sanity [16:49:04] :D [16:49:27] aude, Tobi_WMDE: here is the fix: https://gerrit.wikimedia.org/r/#/c/117884/1/lib/includes/store/sql/CachingEntityRevisionLookup.php [16:49:50] want me to factor it out, or can we just merge the entire change? [16:50:44] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06ItemDeserializer: 02http://git.io/zkQszQ [16:50:44] 13WikibaseInternalSerialization/06ItemDeserializer 143b37bd5 15jeroendedauw: Add alias deserialization to ItemDeserializer [16:51:29] DanielK_WMDE_: if you want or we can make a priority to review that patch [16:51:44] naw, will factor this out [16:51:49] * aude tired though, going home and probably back later [16:53:04] (03PS2) 10Daniel Kinzler: (bug 62210) Avoid EntityContent::save in repo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 [16:53:06] (03PS2) 10Daniel Kinzler: (bug 62210) rm dep on EntityContent from EPPTable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117884 [16:53:08] (03PS1) 10Daniel Kinzler: Fix revision validation on deleted entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117891 [16:55:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [16:57:07] (03PS4) 10Daniel Kinzler: (bug 61911) use localized number patterns. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 [16:57:57] revieeeeeeeeew https://github.com/wmde/WikibaseInternalSerialization/pull/12 [16:59:20] (03PS5) 10Daniel Kinzler: (bug 62210) remove EntityContent from SpecialPages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 [17:02:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117889 (owner: 10Daniel Kinzler) [17:07:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117884 (owner: 10Daniel Kinzler) [17:09:41] (03CR) 10Aude: "are we putting bug numbers in the commit message (first line) again?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117884 (owner: 10Daniel Kinzler) [17:12:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117891 (owner: 10Daniel Kinzler) [17:13:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [17:16:56] [13Time] 15addshore created 06timeOpts (+1 new commit): 02http://git.io/Yq8MbQ [17:16:56] 13Time/06timeOpts 141140753 15addshore: Add precision and claandar opts to TimeParser [17:17:26] [13Time] 15addshore opened pull request #6: Add precision and claandar opts to TimeParser (06master...06timeOpts) 02http://git.io/5ip_6w [17:17:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117858 (owner: 10Daniel Kinzler) [17:17:38] revvwveiwwiwiwiwiww ^^^^^^^^ >>>> Tobi_WMDE JeroenDeDauw Tobi_WMDE Tobi_WMDE [17:54:20] addshore: claandar? :) [17:55:43] >.> [17:56:12] im going to choose to ignore that [17:56:12] :D [17:56:17] ok [17:57:58] as long as its not actually in the code :P [18:02:00] * aude spent the whole day confused about time zones [18:05:45] aude: http://www.youtube.com/watch?v=LWTLUmUjo8A :p [18:06:15] :) [21:06:52] benestar: Hey :) You can now work with guided tours on testwikidata [21:07:10] hoo: I already saw it :) [21:07:12] thanks a lot :) [21:07:24] hoo: is it possible to import a page from betawikidata to testwikidata? [21:07:35] benestar: Sure [21:07:41] or do you mean an item? [21:07:47] * entity [21:07:52] wikitext is fine [21:08:07] hoo: I mean a page with history [21:08:18] benestar: Yes, but no entities [21:08:32] ok, so the import extension cannot deal with them yet? [21:08:44] Import isn't an extension [21:09:03] it somewhat works, but eg. the item ids don't match up etc. [21:09:27] hmm, that makes sense [21:09:28] aude and DanielK_WMDE_ worked on that and might know more [21:10:33] I actually do not need this anyway ;) [21:11:49] heh, ok :D [21:12:40] hoo: do you have any design improvments to the current version of the tour [21:13:04] it was pretty good, AFAIR [21:13:10] I created http://wikidata.beta.wmflabs.org/wiki/Wikidata:Tours [21:13:12] definitely enough for a dome [21:13:15] * demo [21:13:24] but somehow the button does not show up very nice... [21:13:43] ui classes probably need to be loaded [21:14:01] why aren't they? [21:14:18] it is very funny, if I use the preview function, everything looks nice [21:14:29] heh [21:14:45] that's probably because the preview buttons load the CSS classes for you [21:14:49] side effects, yay [21:15:32] benestar: Good start :) I guess you want to move that to testwikidata now [21:15:54] then we can throw the community at it and have a vote for the main site? Lydia_WMDE [21:17:13] hoo: I think transwiki import isn't possible though [21:17:35] benestar: No, you have to use the xml for that [21:17:44] :/ [21:17:51] if you just want to import to testwikidata that's fine, I can give you whatever rights you need there [21:17:58] (except Oversight and such) [21:18:56] ok, first transwiking the button template form Wikidata... [21:20:56] :) [21:22:34] hoo: I think simply copying the script is much easier... [21:23:02] or are there any problems doing so? [21:23:24] benestar: If you're the only author and there aren't any copyright problems, no [21:23:31] k [21:28:54] hoo: a nested div caused the problem [21:29:01] no centering of the button now :( [21:29:15] GerardM-: Is the Reasonator broken? :/ [21:29:18] oh, it is still wrong, was just for a moment ok [21:29:21] benestar: mh...
... ? [21:29:26] :P [21:29:43] hoo: still does not work, even on test.wikidata.org [21:29:55] *sigh* [21:30:35] sjoerddebruin I just had a look.. it seems so [21:30:47] The terminator is also not updating.. http://tools.wmflabs.org/wikidata-terminator/?list&lang=nl [21:30:58] I’ve edited the first one two days ago. [21:31:22] hoo: but works on wikidata.org ... [21:34:11] sjoerddebruin Firefox works for me Chrome has an issue [21:34:20] I’m on Safari [21:34:28] Also webkit [21:35:03] benestar: Can you link the code? [21:35:12] It’s broken here in my firefox GerardM- [21:35:39] https://test.wikidata.org/wiki/Wikidata:Tours [21:35:42] @hoo [21:35:42] weird now it does not work in FF for me either [21:36:01] benestar: will take a look [21:36:05] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/118000 (owner: 10L10n-bot) [21:38:12] there are some messages about proxies problems in the labs channel [21:38:19] that could affect Reasonator [21:38:20] Ah. [21:39:04] benestar: fixed [21:39:08] hoo: how? [21:39:09] see https://test.wikidata.org/w/index.php?title=MediaWiki:Common.js&action=history [21:39:22] this module probably loads through side effects on Wikidata... that's bad, actually [21:39:53] hoo: but it is also bad to load CSS using javascript [21:40:36] benestar: sure [21:40:52] hoo: so why is it done this way? [21:40:54] but there's not way to do this cleanly server side [21:41:11] because there's no other way, basically [21:41:54] hoo: a Common.lua would be nice ;) [21:42:10] benestar: what should that do? [21:42:27] it could run something serverside [21:43:13] and what? :P I mean where should the HTML go? [21:43:29] hoo: some hacky lua methods?! :P [21:44:13] I mean where should that output it's html? , the text body, a random place, ...? :D [21:44:23] Doesn't sound like a sane idea, afterall [21:44:46] hehe, maybe better than a js hack [21:45:02] don't think so [21:45:07] don't introduce more hacks :P [21:45:13] don't even think about it :D [21:45:49] hoo: some more icons/images would be nice to have for the tour [21:46:01] any cute wikidata aliens? [21:46:11] or android-like robots? [21:46:33] or cats? I think there are some in their office ;) [21:46:45] maybe also Lydia_WMDE has an idea [21:46:49] Whose office? [21:47:03] Well, nice pictures are always nice... like on github :P [22:19:32] awww [22:19:36] now bene is gone :( [22:19:43] we have lots of cats in the office [22:19:47] unfortunately no real ones [22:20:48] mh [22:21:33] Lydia_WMDE: Did the team manage to upscale the number of memes with the new office (as there's more space) [22:21:50] hoo: we have a whole cat wall! [22:22:30] * ^d lived with cats for years and decided /no more cats/ when that living situation ended [22:22:42] <^d> :) [22:22:53] ^d: but but but! cats! [22:23:36] <^d> My sister in law's cats are good cats. Just don't like having to take care of them :p [22:25:49] hehe [22:25:54] that is the point of cats [22:26:00] they mostly take care of themself [22:26:06] except for some food and petting [22:26:21] Lydia_WMDE: Got a kitten? [22:26:39] no :( [22:28:36] :( At least there are enough cats within Wikibase's unit tests :D [22:28:52] :D [22:32:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/97b343b : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20490537