[10:00:19] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 09/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117671 
[10:08:06] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117671 (owner: 10WikidataBuilder)
[13:17:57] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] New Wikidata Build - 09/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117671 (owner: 10WikidataBuilder)
[13:32:22] <benestar>	 Lydia_WMDE: "More work on badges by Bene* - most work left is now in the GUI part of it"
[13:32:32] <benestar>	 would be nice if the work could also be reviewed...
[13:32:34] <benestar>	 ;)
[14:34:38] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Browsertests for new build on beta were successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117671 (owner: 10WikidataBuilder)
[14:36:33] <gh-wmde>	 [13WikibaseInternalSerialization] 15addshore 04deleted 06ItemDeserializer at 14a342d4f: 02http://git.io/ejRoEg
[14:37:53] <gh-wmde>	 [13WikibaseInternalSerialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/BjAK_Q
[14:37:53] <gh-wmde>	 13WikibaseInternalSerialization/06master 14016b254 15addshore: Add irc notifications for travis
[14:39:31] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Created a ClientSiteLinkLookup to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene)
[14:45:31] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/79c47a1 : Addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20396857
[17:31:03] <addshore>	 hehehe JeroenDeDauw http://grab.by/uZiA
[17:32:23] <JeroenDeDauw>	 addshore: to bad the method is pointless :)
[17:32:32] <addshore>	 indeed :P
[17:33:01] <JeroenDeDauw>	 http://www.dodgycoder.net/2011/11/yoda-conditions-pokemon-exception.html
[17:35:17] <JeroenDeDauw>	 ah, this post proves I'm wrong in saying we have a pile of sp[agethi code
[17:35:21] <JeroenDeDauw>	 its Spaghetti with Meatballs Code!
[17:36:50] <addshore>	 JeroenDeDauw: now choose the one that described mediawiki ;p
[17:37:10] <hoo>	 https://en.wikipedia.org/wiki/Ravioli_code#Ravioli_code ! :D
[17:37:28] <JeroenDeDauw>	 hoo: addshore: MediaWiki is all of them, except Ravioli Code
[17:37:33] <addshore>	 xD
[17:37:56] <addshore>	 dont think it is Objectfuscated Code either
[17:38:39] <JeroenDeDauw>	 indeed
[17:39:01] <addshore>	 core might end up using the Smurf Naming Convention before using namespaces ;p
[17:39:08] <hoo>	 The sad part is, that it's still way better than AbuseFilter
[17:39:47] <hoo>	 AbuseFilter is really write only code :P Nobody dares to touch the core stuff of it anymore (not even Andrew)
[17:40:27] <JeroenDeDauw>	 You'd think WMF would have learned their lesson by now
[17:41:29] <hoo>	 It's not *this* bad anymore... if we keep improving at that pace, well :P
[17:42:37] <JeroenDeDauw>	 The mindset needs to change, if that does not happen, the code is never going to get decent
[17:42:44] <JeroenDeDauw>	 Seems like some progress has been made recently
[17:42:46] <addshore>	 :/
[17:43:31] <hoo>	 One day, I'm going to undeploy all bad extensions and just pretend they've never existed :D
[17:44:02] <addshore>	 xD
[17:44:06] <JeroenDeDauw>	 hoo: Wikibase will be lonely! (Assuming we made Wikibase sane by then)
[17:44:18] <hoo>	 Vanilla MediaWiki :D
[17:44:47] <JeroenDeDauw>	 Should use http://vanilla-js.com/
[17:45:29] <hoo>	 Final size: 0 bytes uncompressed, 25 bytes gzipped. 
[17:45:32] <hoo>	 :DDD
[17:45:57] <hoo>	 JeroenDeDauw: http://i.imgur.com/EXUmo.gif
[17:46:21] <addshore>	 lol...
[17:47:28] <JeroenDeDauw>	 ;D
[17:47:49] <JeroenDeDauw>	 hoo: where did you find that?
[17:47:58] <addshore>	 http://meta.stackoverflow.com/questions/45176/when-is-use-jquery-not-a-valid-answer-to-a-javascript-question
[17:48:06] <hoo>	 JeroenDeDauw: My bookmarks :P Don't ask me where I got it from originally
[17:53:24] <addshore>	 haha hoo I was looking at the abusefilter code, and wondering where everything that was actually doing stuff was, then I found AbuseFilter.class.php :P
[17:53:47] <hoo>	 addshore: :D
[17:53:53] <addshore>	 and the parser file xD
[17:54:03] <hoo>	 parser even has some unit tests :P
[17:54:26] <JeroenDeDauw>	 So esentially AbuseFilter failed to filter itself from being abused?
[17:54:46] <addshore>	 hoo: they are the only 'unit' tests for AbuseFIlter xd
[17:55:04] <hoo>	 JeroenDeDauw: - So essentially - to filter itself from being abused?
[17:55:09] <hoo>	 then, yes :D
[17:55:23] <JeroenDeDauw>	 https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-AbuseFilter/ ...........
[17:55:57] <addshore>	 i think we need to turn that on xD
[17:56:01] <hoo>	 JeroenDeDauw: You evil ... :D
[17:56:05] <JeroenDeDauw>	 I just did
[17:56:10] <JeroenDeDauw>	 ~2500 commits
[17:56:28] <hoo>	 h
[17:56:34] <JeroenDeDauw>	 It has a composer.json
[17:56:37] <JeroenDeDauw>	 not working for sure
[17:56:39] <hoo>	 Yeah :P
[17:56:44] <hoo>	 oh, I think it does :P
[17:56:50] <JeroenDeDauw>	 Great, broken packages on Packagist
[17:56:55] <JeroenDeDauw>	 It does not
[17:57:04] <JeroenDeDauw>	 It does not even include the entry point file
[17:57:10] <JeroenDeDauw>	 And if it did, it has global scope assumptions
[17:57:11] <hoo>	 meh... at least someone tried
[17:57:11] <addshore>	 JeroenDeDauw: scrutinizer is running over it? :>
[17:57:17] <JeroenDeDauw>	 yes
[17:57:39] <JeroenDeDauw>	 https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-AbuseFilter/inspections/7e5db004-d6e1-4da1-a613-a2fed0ee73c3
[17:57:41] <JeroenDeDauw>	 lol
[17:57:47] <JeroenDeDauw>	 its even referencing a package that does not exist
[17:58:01] <JeroenDeDauw>	 wow
[17:58:03] <JeroenDeDauw>	 2300 lines
[17:58:12] <JeroenDeDauw>	 such code, many omg
[17:58:23] <JeroenDeDauw>	 static
[17:58:34] <hoo>	 JeroenDeDauw: It's fun... static code calling itself in many weird ways
[17:58:36] <JeroenDeDauw>	 .class.php - yeah, it's class-based programming alright
[17:58:55] <JeroenDeDauw>	 Dear WMF, please fire some people
[17:59:01] <addshore>	 lol
[17:59:40] <JeroenDeDauw>	 o_O
[17:59:56] <JeroenDeDauw>	 Perhaps shooting them is more kind
[18:00:13] <JeroenDeDauw>	 arrrr
[18:00:21] <addshore>	 https://packagist.org/packages/mediawiki/anti-spoof
[18:00:24] <JeroenDeDauw>	 so the inspection is not working due to the composer file being broken
[18:00:26] <JeroenDeDauw>	 troilololol
[18:00:29] <hoo>	 and I'm maintaining that broken piece of ... because WMf's not interested
[18:00:32] <hoo>	 enough
[18:00:35] <addshore>	 i can find the versions though :P
[18:00:58] <JeroenDeDauw>	 addshore: it does not have any stable rel
[18:00:59] <addshore>	 guess in the modern day it requires dev-master instead?
[18:01:06] <JeroenDeDauw>	 and it does not specify it can get dev packages
[18:01:08] <addshore>	 and a minimum stability :P
[18:01:09] <JeroenDeDauw>	 so..
[18:02:52] <addshore>	 hoo https://gerrit.wikimedia.org/r/#/c/117695/
[18:03:21] <JeroenDeDauw>	 addshore: just kill it
[18:03:38] <addshore>	 kill it? :O
[18:03:43] <JeroenDeDauw>	 yeah
[18:03:48] <JeroenDeDauw>	 what is the point in having it
[18:03:54] <JeroenDeDauw>	 clearly no one uses it now anyway
[18:03:58] <addshore>	 xD
[18:04:01] <JeroenDeDauw>	 either have a working one or dont have one
[18:04:04] <JeroenDeDauw>	 not a half broken one
[18:04:55] <hoo>	 whatever
[18:05:00] <addshore>	 xD
[18:05:00] <hoo>	 I don't really care
[18:05:32] <addshore>	 i just want to see scrutinizer run on it now :P
[18:05:42] <JeroenDeDauw>	 dev-master of installers is also wrong
[18:05:46] <hoo>	 troll
[18:05:47] <JeroenDeDauw>	 yeah
[18:06:13] <addshore>	 meh, I replaced the incorrect non working * to incorrect working dev-master ;p
[18:08:37] <hoo>	 :P
[18:09:57] <Meiko>	 So Brickipedia (the LEGO wiki) will be making a Wikidata-like site soon (appropriately titled Brickidata), so I put my creative genius to work and am making a logo: http://i.imgur.com/VtsRLe6.png
[18:13:28] <addshore>	 :O
[18:14:48] <hoo>	 nice one... not a lawyer to talk about trademark protection stuff, though
[20:21:51] <hoo>	 addshore: https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-AbuseFilter/inspections/998a676d-416a-4654-a0f7-c272523d196b :DD
[20:23:30] <addshore>	 it died hoo ? :<
[20:25:07] <addshore>	 hoo: >> ? https://gerrit.wikimedia.org/r/#/c/117704/ :P
[20:25:32] <hoo>	 wow, that needed to come :P
[20:25:35] <hoo>	 * had
[20:25:42] <addshore>	 ? :P
[20:25:50] <hoo>	 I've read up on the last change...
[20:26:21] <addshore>	 read up on? :P
[20:27:06] <hoo>	 addshore: The change which Siebrand merged
[20:27:13] <addshore>	 ahh :P
[20:27:13] <hoo>	 the one that removed the periods :P
[20:28:41] <multichill>	 addshore: Did you guys end up talking about the coordinates?
[20:29:32] <addshore>	 its not in this sprint unfortunatly
[20:30:06] <addshore>	 see http://wmde.wmflabs.org/t/wikidata-developers/2014-03-04/ :P
[20:39:58] <multichill>	 addshore: I just want to get clear what the valid values are for the precision
[20:40:21] <addshore>	 could you link me to the bug again multichill ?
[20:40:41] <multichill>	 Or, option B is that I import 100.000+ coordinates and you end up having to clean up the precision
[20:41:03] <multichill>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=62105
[20:43:01] * addshore  wonders why we dont have the precision on https://www.wikidata.org/wiki/Special:ListDatatypes

[20:43:19] <addshore>	 *makes a bug*
[20:43:53] <multichill>	 IMHO, the precision shouldn't be restricted. You'll introduce a lot of rounding problems/errors
[20:44:22] <addshore>	 multichill: as far as I know it isnt
[20:44:54] <multichill>	 addshore: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDataValues.git/727ccd66b03f42e1f5458ea204ca15b315cf5f04/DataValues%2Fresources%2FglobeCoordinate.js%2Fsrc%2FglobeCoordinate.GlobeCoordinate.js#L180
[20:44:55] <addshore>	 ahhh! your looking at the JS serializers?
[20:45:15] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117799 (owner: 10L10n-bot)
[20:45:39] <multichill>	 addshore: https://www.wikidata.org/w/index.php?title=Q3969823&oldid=113061813
[20:45:55] <multichill>	 The value does not comply with the property's definition. The value's data value type "ununserializable" does not match the property's data type's data value type "globecoordinate".
[20:47:30] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/01aa7de : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20413180
[20:47:40] <addshore>	 "precision":2.0e-5
[20:48:00] <addshore>	 hmmm
[20:48:15] <multichill>	 addshore: So the js code restricts it, but the api code doesn't
[20:48:25] <addshore>	 apparently...
[20:49:02] <addshore>	 yes, if you turn the JS off it gets redered as 41.9689, 12.4092
[20:49:25] <multichill>	 yup
[20:52:36] <addshore>	 multichill: added another cmt to the bug
[20:54:20] <multichill>	 Maybe I should just start importing so people starting noticing it and get anoyed
[20:55:10] <addshore>	 haha :P
[20:55:48] <addshore>	 I imagine the problem will be resolved once we turn on the backend formatters instead of the frontend ones
[20:56:10] <multichill>	 https://tools.wmflabs.org/geohack/geohack.php?language=en&params=41.9689_N_12.4092_E_globe:earth <- and without the Toolserver people will get grumpy anyway
[20:56:11] <addshore>	 which is https://gerrit.wikimedia.org/r/#/c/110936/ and then 1 more small change after that
[20:56:56] <Lydia_WMDE>	 multichill: please wait until this is in. there is no rush and it's just making wikidata look bad
[20:57:09] <Lydia_WMDE>	 (and it does not help to annoy the dev team to get things done faster)
[20:57:24] <multichill>	 Being ignored isn't very nice either
[20:57:30] <Lydia_WMDE>	 you're not being ignored
[20:59:01] <multichill>	 It sure feels like it. Email not answered for over a week.
[20:59:54] <Lydia_WMDE>	 i considered the email done with the bug you opened