[08:13:06] (03CR) 10Raimond Spekking: Move Time i18n Messages to corrent i18n file (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117195 (owner: 10Addshore) [08:32:06] is someone around who I can ask a question about the upcoming query functionality ? [08:46:05] http://magnusmanske.de/wordpress/?p=178 [08:46:11] how does it compare [08:58:57] [13scrumbugz] 15ChristopherHJohnson pushed 2 new commits to 06master: 02http://git.io/vl_agw [08:58:58] 13scrumbugz/06master 14b1b0f7c 15Christopher Johnson: added to wmde_products [08:58:58] 13scrumbugz/06master 142a2408a 15Christopher Johnson: Merge branch 'master' of https://github.com/wmde/scrumbugz [09:00:41] GerardM-: I may try to help even if I'm not from the dev team. [09:01:24] do you now about the upcomming Wikidata query functionality ? [09:01:49] because I want to understand NOW what it will bring and how it compares with WDQ [09:03:21] I think that in the beginning it would only allow very simple query (i.e. claim[PROPID][VALUE]) [09:03:40] and then maybe more complicated things. [09:04:20] But I don't know so much about it. [09:04:36] (03CR) 10Thiemo Mättig (WMDE): "In short: Currently all we do is moving these messages from one place to an other. The current code depends on them so we can not delete t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117195 (owner: 10Addshore) [09:04:45] what we know is in the dev plan page [09:04:52] everything else is not set in stone [09:04:57] and Tpt is correct [09:05:07] we will start with something very basic [09:05:08] hoi Lydia_WMDE [09:05:15] one property and one value [09:05:33] so for now WDQ is the best tool to use [09:05:53] or does additional functionality rest on top of the Wikidata query ? [09:06:04] as wikidata itself has 0 query functionality right now it is of course ;-) [09:06:15] at some point surely [09:06:59] what I am trying to understand is what to promote and why ... WDQ is tangible Wikidata Query is fuzzy [09:07:34] what is the selling point ? [09:09:23] the point is that I very much want to promote it [09:10:06] one selling point will be that you will be able to use the queries on wikipedia and be able to visualize them [09:10:13] I think that the selling points are : WDE: powerful queries (qualifiers...) Wikidata query: may be used in Lua module [09:10:15] visualize the result that is [09:26:38] (03PS1) 10Aude: Fix search result display for title matches [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117392 [09:27:47] Lydia_WMDE: Could you have a look to https://www.mediawiki.org/wiki/User:Tpt/RFC , please? It's an early beginning of proposal on how software built for Wikidata may be used in Wikisource. [09:28:22] Tpt: looking [09:28:29] Thanks :-) [09:29:09] It's an early draft that haven't been discussed yet. [09:32:07] Tpt: ok i read it but i'll need more time to really say anything useful about it [09:32:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117392 (owner: 10Aude) [09:32:28] one thing i can say: you are awesome for writing understandable proposals :D [09:33:10] Lydia_WMDE: Thanks :-) I've rewritten it twice already. [09:33:34] hehe [09:33:55] maybe it would also be a good idea for Daniel to have a look at it [09:34:01] It more something designed to open discussion than a real proposal. [09:34:17] yeah [09:34:19] Ok. I'll talk to him. Thanks [09:35:04] :) [09:35:14] i'll try to have a closer look at it also over the next days [09:36:43] thanks :-) [10:00:21] (03PS1) 10WikidataBuilder: New Wikidata Build - 07/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117395 [10:08:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117395 (owner: 10WikidataBuilder) [10:14:07] (03CR) 10Siebrand: "Added L10n related comment." (031 comment) [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 (owner: 10Aude) [10:18:03] (03CR) 10Aude: new build, cherry pick I5e62345 for ClaimHtmlGenerator (031 comment) [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 (owner: 10Aude) [10:46:40] [13ValueView] 15adrianlang 04force-pushed 06ValueFormatterForTime from 146d95a7c to 1426d56d6: 02http://git.io/yI81oA [10:46:40] 13ValueView/06ValueFormatterForTime 1426d56d6 15Adrian Lang: Use ValueView's formatting and parsing in TimeValue [10:52:42] (03CR) 10Siebrand: new build, cherry pick I5e62345 for ClaimHtmlGenerator (031 comment) [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 (owner: 10Aude) [11:03:05] (03CR) 10Aude: new build, cherry pick I5e62345 for ClaimHtmlGenerator (031 comment) [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/117240 (owner: 10Aude) [11:36:46] (03CR) 10Adrian Lang: [C: 04-1] "Several usages of »Calender« (also in DataValues/Time). Also, http://localhost/api.php?action=wbparsevalue&format=json&parser=time&values=" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:44:01] [13Time] 15adrianlang created 06fixCalendarTypo (+1 new commit): 02http://git.io/k4ORmA [11:44:02] 13Time/06fixCalendarTypo 14ac5147b 15Adrian Lang: Correct multiple typos: Calend{e => a}r [11:44:21] [13Time] 15adrianlang opened pull request #5: Correct multiple typos: Calend{e => a}r (06master...06fixCalendarTypo) 02http://git.io/RD6QPg [11:51:06] [13Time] 15adrianlang 04force-pushed 06fixCalendarTypo from 14ac5147b to 14695f5e8: 02http://git.io/qN0mFw [11:51:06] 13Time/06fixCalendarTypo 14695f5e8 15Adrian Lang: Correct multiple typos: Calend{e => a}r [11:53:19] (03CR) 10Addshore: [C: 032] New Wikidata Build - 07/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117395 (owner: 10WikidataBuilder) [11:55:22] (03CR) 10Addshore: [C: 032] Fix search result display for title matches [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117392 (owner: 10Aude) [11:55:55] w00t! [12:16:21] (03PS3) 10Adrian Lang: Use correct options for GlobeCoordinateFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110936 [12:17:29] (03CR) 10Adrian Lang: "Are these used by the frontend in the current branch? If so, we should cherry-pick this." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110936 (owner: 10Adrian Lang) [12:22:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110936 (owner: 10Adrian Lang) [12:32:55] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/117395 (owner: 10WikidataBuilder) [13:22:06] (03PS19) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [13:22:08] (03PS1) 10Adrian Lang: Correctly check for missing entities in AbstractedRepoApi::getEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117408 [13:23:07] (03CR) 10Hoo man: [C: 032] "Sounds sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117408 (owner: 10Adrian Lang) [13:23:24] (03CR) 10Adrian Lang: "Deleted properties are fixed with the depending-upon change. I cannot reproduce the qualifier issue." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:23:29] (03Merged) 10jenkins-bot: Correctly check for missing entities in AbstractedRepoApi::getEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117408 (owner: 10Adrian Lang) [13:28:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:33:33] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117408 (owner: 10Adrian Lang) [13:45:23] (03PS4) 10Adrian Lang: Use correct options for GlobeCoordinateFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110936 [13:50:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110936 (owner: 10Adrian Lang) [14:20:17] (03CR) 10Adrian Lang: [C: 04-1] "There are many unrelated changes in this commit. Why did you remove the closing of the elements? As for the main change of this commit, th" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113342 (owner: 10Thiemo Mättig (WMDE)) [14:25:09] (03CR) 10Adrian Lang: Browsertests for statements with item values (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110966 (owner: 10Tobias Gritschacher) [14:28:05] (03CR) 10Adrian Lang: Browsertests: convert performance test scenario to outline (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 (owner: 10Tobias Gritschacher) [14:37:56] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #19 14bd64702: New public methods should have an @since tag. In this case @since 0.7 02http://git.io/0yOvPg [14:59:56] Thiemo_WMDE: i realize you don't like the regex stuff, but... can we get this in? https://github.com/DataValues/Number/pull/2 [15:00:22] DanielK_WMDE: I freakin' love regular expression. :-) [15:00:27] :P [15:00:47] That's why I'm so nitpickin' when talkin' about them. [15:01:22] we need a way to handle localized quantity values very soon. i think my patch achieves that in a reasonable way. [15:15:46] [13Number] 15thiemowmde 04deleted 06ParseLocalizedQuantities at 140b644b8: 02http://git.io/vXr25g [15:23:18] (03CR) 10Daniel Kinzler: [C: 031] "looks good, needs manual verification" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [15:24:00] * hoo can do that later on, if wanted [15:24:31] DanielK_WMDE: https://gerrit.wikimedia.org/r/116236 this should be unit tested well enough to go w/o manual poking ;) [15:26:21] (03CR) 10Daniel Kinzler: [C: 04-1] "Better now, but "isLegacy" is not a good name." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116236 (owner: 10Hoo man) [15:26:56] oh, yes [15:27:11] Like you didn't like my 'newFormat' flag some time back :P [15:27:26] i guess :) [15:28:12] DanielK_WMDE: Any sane idea? [15:28:29] hoo: structureVersion? [15:28:49] mh, and include it also in the new version? [15:29:16] yea, for good measure [15:29:41] not a fan of adding unrelated data to the struct. but I think it's the best way to go [15:29:49] will amend [15:33:05] (03CR) 10Daniel Kinzler: [C: 04-1] "test seems incomplete. am i missing something?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 (owner: 10Addshore) [15:34:23] (03CR) 10Addshore: Correctly Format BC dates/times (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 (owner: 10Addshore) [15:34:34] DanielK_WMDE: ^^ [15:35:18] I start counting at 1... guess that was to much Lua for me recently :D [15:35:20] addshore: oh, right >_< [15:35:51] (in that case... while BCE is politically correct, is it really the preferred suffix?...) [15:36:44] * addshore would think so :P [15:36:52] addshore: do we have localization of the "BCE" stuff in the backlog? [15:36:59] aude: I can has review? https://github.com/wmde/WikibaseInternalSerialization/pull/7 [15:36:59] not currently [15:37:06] I dont think :P [15:37:18] addshore: would you add it? I think it's important. [15:37:59] (03CR) 10Daniel Kinzler: [C: 032] Correctly Format BC dates/times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 (owner: 10Addshore) [15:38:17] (03Merged) 10jenkins-bot: Correctly Format BC dates/times [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117196 (owner: 10Addshore) [15:42:48] DanielK_WMDE: Will file a bug [15:55:57] ugh [15:56:26] Entity and derivatives are so evil [15:58:43] (03CR) 10Addshore: [C: 04-1] Use correct options for GlobeCoordinateFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110936 (owner: 10Adrian Lang) [15:58:59] (03CR) 10Hoo man: [C: 04-1] Add {{WBREPONAME}} magic word, remove references to Wikidata (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [15:59:09] argggg, I can't fix this at the same time :| [16:00:18] (03CR) 10Hoo man: "It might be worth splitting this into two changes: One for the magic word and one for all the other things" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [16:05:27] (03CR) 10Addshore: Created a SiteLinkProvider to query sitelinks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [16:06:31] [13WikibaseDataModel] 15mariushoch 04force-pushed 06getHighestRankedClaims from 14bd64702 to 14876aa7b: 02http://git.io/Xlzh9A [16:06:31] 13WikibaseDataModel/06getHighestRankedClaims 14876aa7b 15Marius Hoch: Introduce Claims::getBestClaims and Claims::getClaimsByRank [16:06:34] [13WikibaseInternalSerialization] 15filbertkm comment on pull request #7 14dbe302c: why is this public? PHPUnit_Framework_TestCase has it protected 02http://git.io/h7ziHg [16:06:49] [13WikibaseInternalSerialization] 15filbertkm comment on pull request #7 14dbe302c: no documentation for these? 02http://git.io/hxv-Vg [16:08:49] do I have to push a new commit to update the github pull request? [16:08:49] I don't think so [16:08:49] DanielK_WMDE: https://github.com/wmde/WikibaseDataModel/pull/19/files [16:12:21] [13WikibaseInternalSerialization] 15JeroenDeDauw comment on pull request #7 14dbe302c: heh. Good catch. Wonder why it does not complain about this. We have this wrong in several places now (inc all tests in this component). Will do a global fix once this is merged. 02http://git.io/B-WkiA [16:13:28] [13WikibaseInternalSerialization] 15JeroenDeDauw comment on pull request #7 14dbe302c: What documentation would be helpful here? Think it's obvious enough to a human what this is, and a decent IDE can figure out the type as well, as it is specified in the constructor. 02http://git.io/qFvIjg [16:17:09] (03PS1) 10Addshore: Remove ALL of the pointless @since tags from tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117420 [16:20:48] looks good but wait for jenkins [16:20:55] nope :P [16:21:04] (03CR) 10Aude: [C: 031] "wait for jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117420 (owner: 10Addshore) [16:21:18] (03CR) 10Hoo man: [C: 04-1] "Have another look ;)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117420 (owner: 10Addshore) [16:21:29] aaaah [16:21:57] (03CR) 10Addshore: Remove ALL of the pointless @since tags from tests (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117420 (owner: 10Addshore) [16:22:18] its a mock not a test hoo ;p [16:22:28] addshore: ewk :D [16:22:29] the since should remain, I just confused you by adding spaces around it ;p [16:22:35] Don'T touch it, then [16:22:40] xD [16:22:44] I didnt realise I had :/ [16:22:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117420 (owner: 10Addshore) [16:22:57] (03CR) 10Hoo man: [C: 032] "Ok, then :D" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117420 (owner: 10Addshore) [16:23:00] :D [16:23:05] :) [16:23:16] my hands just do stuff and then oh noes! there is a ocmmit on gerrit :P [16:23:20] *commit [16:23:40] (03Merged) 10jenkins-bot: Remove ALL of the pointless @since tags from tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117420 (owner: 10Addshore) [16:25:59] andre__: did you reactivate our bugs account? :) [16:27:22] addshore, https://bugzilla.wikimedia.org/show_bug.cgi?id=62373 ? [16:27:43] First step DONE :D [16:27:46] did not spot that [= [16:47:41] (03CR) 10Thiemo Mättig (WMDE): "It's not "many". All I did was splitting comment lines that are to long and removing very few chars that are completely meaningless." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113342 (owner: 10Thiemo Mättig (WMDE)) [16:59:19] (03CR) 10Aude: Add {{WBREPONAME}} magic word, remove references to Wikidata (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [17:00:51] aude: The newOptions maint. script from core can do that ;) [17:01:04] (03PS8) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [17:01:28] i don't see that script [17:01:46] i see convert user options [17:02:03] not that [17:02:10] $IP/maintenance/userOptions.php [17:02:19] which includes userOptions.inc [17:02:53] wait... how did I come to newOptions? :P [17:03:21] i'm not sure it does quite what we need [17:03:37] mh, it doesn't seem to be able to take a user list [17:03:46] select all users with x option = true, set y option true for them [17:04:02] the script could be improved [17:04:22] yeah [17:04:41] "The script is about to change the skin for ALL USERS in the database. " [17:04:42] for now we should probably split your patch in two, so that we can put the pref. stuff on hold [17:05:00] ok [17:05:07] that's obsolete, it's more general than that, really [17:05:25] "private function LISTER() " [17:06:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [17:10:48] let's see if this woroks [17:10:50] works* [17:10:57] (03PS9) 10Aude: Add {{WBREPONAME}} magic word [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 [17:10:59] (03PS1) 10Aude: Remove references to Wikidata in recent changes preference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 [17:11:28] nope missed something [17:11:44] I can haz omnomnomnomnomn? :( evil slow food people [17:11:54] aude: revieeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeew [17:12:08] * aude leaving soon to get food [17:12:24] <^d> Lydia_WMDE: Broken deletions in search on wikidata are broken. [17:12:36] <^d> Did you see Dan's investigations yesterday? It's totally weird. [17:12:53] ^d: i saw a bit of it, yeah [17:13:03] ^d: but it seems only this one item is borked? [17:13:42] (03PS2) 10Aude: Remove references to Wikidata in recent changes preference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 [17:13:43] <^d> This one's definitely broken. But behavior's weird in general and needs revisiting. [17:13:44] (03PS10) 10Aude: Add {{WBREPONAME}} magic word [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 [17:13:56] ok [17:14:01] JeroenDeDauw: Why u no review https://github.com/wmde/WikibaseDataModel/pull/19/files ? [17:14:04] (03PS9) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [17:15:08] aude: Thanks :) Will poke at it later (hopefully) [17:15:17] seems ok now [17:15:42] we need a script now for the preferences but that should be in separate patch [17:16:09] (03CR) 10Hoo man: [C: 04-2] "Unless we found a way to move other the preferences" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 (owner: 10Aude) [17:16:25] :/ [17:18:11] sorry [17:18:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [17:19:40] hoo: do we want more than a script? [17:20:13] (03PS3) 10Aude: Remove references to Wikidata in recent changes preference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 [17:20:15] aude: A script should be fine [17:20:15] (03PS11) 10Aude: Add {{WBREPONAME}} magic word [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 [17:20:22] if it works, of course [17:20:32] we could then run it on the cluster if greg is fine [17:20:43] post deploy [17:21:10] the patch as is now handles the old option, with backwards compat [17:21:26] Yeah, but stuff will look weird in Special:Preferences [17:21:31] no it doesn't [17:22:45] mh [17:22:50] when i change preferences with the new option (e.g. unset), then both get unset [17:23:01] * aude still wants a script [17:23:16] Yes, I fear that, if we merge this now, it will get forgotten or so [17:23:17] required [17:23:23] agree [17:23:42] anyway, time to eat [17:23:50] Yeah, same here ;) [17:25:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 (owner: 10Aude) [17:30:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 (owner: 10Aude) [17:34:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [17:36:20] isn't there a site that i can refer to with a wikidata item that redirects me the wikipedia article in my preferred language? [17:36:38] if avalible [17:39:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [17:43:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117429 (owner: 10Aude) [17:47:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116099 (owner: 10Aude) [17:53:24] (03CR) 10Addshore: [C: 031] Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [17:55:20] (03PS7) 10Thiemo Mättig (WMDE): Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 [18:00:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [18:17:51] hi Lydia_WMDE ! [18:57:42] Lydia_WMDE: hey, do we want a tour for Wikibase? https://www.mediawiki.org/wiki/Extension:GuidedTour [18:57:44] I'd like to create one but only if you like the idea. [18:59:12] benestar: Not letting Lydia respond :p - I think it is a good idea and worth it :p [18:59:35] JohnLewis: :D [18:59:46] I think it should also be included into the extension [19:00:35] benestar: Work on it first - end-term goals come at the end term :p [19:00:45] ;) [19:00:52] benestar: Lydia's not here atm... but I also like the idea of having a guided tour :) [19:01:08] ok, two supporters are quite nice to start a work :) [19:04:04] hoo, So no Lydia? :p [19:07:54] hoo: what are the steps to enable the extension on Wikidata? [19:09:35] benestar: Community consensus probably? [19:09:55] will post something on pc [19:10:15] benestar: Then if no objections after a week - ask for it to be enabled [19:10:35] JohnLewis: or enable it on my own xD [19:10:58] benestar: COI >:D [19:11:06] :P [19:11:14] Yeah, you will need consensus [19:16:52] https://en.wikipedia.org/wiki/List_of_the_most_common_U.S._place_names wow :P [19:17:15] JohnLewis: hoo posted a comment on PC [19:17:31] I think there won't be any objections, but who knows [19:17:36] for one second I thought "I did what" :P [19:17:43] hoo; Ditto :P [19:18:05] benestar: Feel free to request it on bugzilla now then so it is there for reference :p [19:18:28] JohnLewis: First we need at least one tour [19:18:29] I guess [19:18:30] I will submit a patch right now (saves someone's else time) [19:18:41] benestar: No! Bug :p [19:18:48] I'll do the patch in the a week :p [19:18:54] why? [19:19:21] * JohnLewis has no made any patches in a while - only fixing patches :p [19:19:53] that's no reason :P [19:19:59] * benestar submits a patch right now :PPP [19:20:07] benestar: No :( [19:20:18] 9_9 [19:20:29] are you so bored? [19:20:36] begging for work ... [19:20:39] Yes :P [19:20:47] Plus No Lydia = No Weekly summary for now :D [19:20:48] slow down [19:21:05] What's the purpose of enabling it w/o a tour? [19:21:21] hoo: Fool people? :p [19:21:32] :P [19:21:50] hoo: how does it make sense to create a tour without having the extension? [19:22:06] benestar: To evaluate? [19:22:10] Also hoo - When is Lydia going to be online? If not, I'll poke the two 'slaves' to do it instead. [19:23:14] JohnLewis: Frankly, I don't know... hopefully later on... maybe in half an hour? [19:23:33] FAir enough :p [19:23:55] benestar: JohnLewis: We could deploy it to test.wikidata first, if you want [19:24:01] no consensus needed for that [19:24:06] hoo: I will create a tour right now [19:24:11] hoo: that'd be great :DD [19:24:12] just create a patch and I'll approve and deploy it [19:27:12] hoo: testwikidata is the wiki name? [19:27:30] benestar: Yus [19:27:34] testwikidatawiki [19:27:40] yeah [19:30:30] hoo: https://gerrit.wikimedia.org/r/#/c/117452/ [19:31:32] hoo: I also need admin rights on testwikidatawiki then ;) [19:31:46] benestar: Ok, want that now? [19:31:49] benestar: You're too abusive :p [19:31:57] JohnLewis: ??? [19:32:01] hoo: merge ?! [19:32:07] yes please [19:32:09] benestar: Joke :p [19:32:14] ^^ [19:32:20] benestar: Ok, will need to see whether it's ok to deploy now [19:32:29] hmm? [19:33:55] benestar: Deploying to the cluster is not *this* easy [19:34:00] especially on a friday [19:34:06] hang on a bit [19:34:14] would be nice to have it though ;) [19:34:28] thanks a lot if you try it now :) [19:36:01] JohnLewis: Thunderbird hat diese Nachricht als Junk eingestuft. xD [19:37:09] hoo: do I already have admin rights on testwikidatawiki? [19:37:28] benestar: Hang on :P [19:37:37] I could already start to setup things [19:37:54] so if you could just give me them (doesn't take that long ;) ) [19:38:08] addshore: please to review https://github.com/wmde/WikibaseInternalSerialization/pull/7 [19:38:39] * JeroenDeDauw marks JohnLewis as abusive [19:39:04] [13WikibaseInternalSerialization] 15addshore 04deleted 06ClaimDeserializer at 14dbe302c: 02http://git.io/GPA4Ng [19:39:04] hoo: ok, ping me when you're ready :=) [19:39:07] and thanks a ot [19:39:10] *lot [19:40:10] benestar|afk: are you going to put another patch ontop of your sitelist thing for the client? [19:41:27] benestar|afk: Nope [19:41:54] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06protected (+1 new commit): 02http://git.io/BS8dvg [19:41:54] 13WikibaseInternalSerialization/06protected 144432ebe 15jeroendedauw: Make setUp methods protected as done in base class [19:41:57] benestar|afk: You are... now :p [19:42:06] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #8: Make setUp methods protected as done in base class (06master...06protected) 02http://git.io/_ryYWQ [19:44:16] benestar|afk: You got admin rights there, but I couldn't convince greg-g to have the deploy now [19:44:58] Next time ask stuff like this on thursday or earlier :P [19:45:03] Will push your change on Monday [19:45:19] [13WikibaseInternalSerialization] 15addshore 04deleted 06protected at 144432ebe: 02http://git.io/QI379A [19:45:38] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06rankcheck (+1 new commit): 02http://git.io/lA_Txg [19:45:38] 13WikibaseInternalSerialization/06rankcheck 149c5e14a 15jeroendedauw: Add missing test for invalid ranks [19:45:53] addshore: https://scrutinizer-ci.com/g/wmde/WikibaseInternalSerialization/code-structure/master/class/Wikibase%5CInternalSerialization%5CDeserializers%5CSnakDeserializer [19:45:54] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #9: Add missing test for invalid ranks (06master...06rankcheck) 02http://git.io/w7GYzQ [19:45:57] check the coverage [19:46:00] I feel trolled [19:46:15] It's a fucking logic exception, so ofc its not getting executed! [19:47:17] hahahaha JeroenDeDauw [19:47:37] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06coverage (+1 new commit): 02http://git.io/KiAyxQ [19:47:37] 13WikibaseInternalSerialization/06coverage 14267111b 15jeroendedauw: Ignore unreachable code in test coverage [19:48:14] [13WikibaseInternalSerialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/a_vXTA [19:48:14] 13WikibaseInternalSerialization/06master 14e56fe0a 15addshore: Merge pull request #10 from wmde/coverage... [19:51:22] JeroenDeDauw: are you ok with the function definitions in https://github.com/wmde/WikibaseDataModel/pull/19/files now? [19:51:31] I would really like to build on top of that now :) [19:54:13] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/HccaQw [19:54:13] 13WikibaseDataModel/06master 1463cdedd 15Jeroen De Dauw: Merge pull request #19 from wmde/getHighestRankedClaims... [19:54:49] hoo: done [19:54:50] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06getHighestRankedClaims at 14876aa7b: 02http://git.io/FCxMDg [19:54:57] Thanks :) [19:55:15] hoo: what do you plan to do on top? [19:55:34] JeroenDeDauw: Use that in the parserfunction / Lua [19:55:55] so that we only show the best statements in Client and not all the data [19:56:39] hoo: meh getClaimsByRank [19:56:43] That method name is odd [19:56:54] $claims->getClaimsByRank [19:57:05] $claims->getByRank [19:57:19] Wasn't happy with it [19:57:32] actually wasn't happy with both, if you got a preference, I can follow [19:57:33] hoo: how about you submit a commit to change it? [19:57:41] if you like, sure :) [19:57:50] in the other one you cannot get rid of Claimns with the current name [19:58:08] I do not like getBestClaims... no better idea though [19:58:26] I chose both by least dislike :P [20:00:04] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/A_HXzA [20:00:04] 13WikibaseDataModel/06master 1445c9ae5 15Jeroen De Dauw: Update RELEASE-NOTES.md [20:00:42] time to do a 0.7 rel \o/ [20:01:49] [13WikibaseDataModel] 15mariushoch created 06getByRank (+1 new commit): 02http://git.io/JThznA [20:01:49] 13WikibaseDataModel/06getByRank 144262ed2 15Marius Hoch: Rename Claims::getClaimsByRank to Claims::getByRank [20:02:34] [13WikibaseDataModel] 15mariushoch opened pull request #20: Rename Claims::getClaimsByRank to Claims::getByRank (06master...06getByRank) 02http://git.io/9fYP8Q [20:02:39] JeroenDeDauw: ^ :) [20:03:59] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/F0RshA [20:03:59] 13WikibaseDataModel/06master 1458a1a03 15Jeroen De Dauw: Merge pull request #20 from wmde/getByRank... [20:04:34] mhhh [20:05:23] lets stick to 0.7 for now [20:05:41] big changes comming up.... if we pick 1.0 now, it will need to go to 2.0 soon afterwards [20:07:16] [travis-ci] wmde/WikibaseDataModel/getByRank/4262ed2 : Marius Hoch The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/20309803 [20:07:27] oO [20:07:30] looking [20:07:53] the fuck [20:07:54] oh, just travis being to slow [20:08:04] it tries to test the pull request, but it's already gone [20:08:17] I ran the tests locally and they were fine [20:08:32] It reported they where fine before as well [20:08:37] [13WikibaseDataModel] 15JeroenDeDauw created 06zeroseven (+2 new commits): 02http://git.io/UGLlLg [20:08:37] 13WikibaseDataModel/06zeroseven 145479744 15jeroendedauw: Bump version number to 0.7 [20:08:37] 13WikibaseDataModel/06zeroseven 140be215f 15jeroendedauw: Add link to WikibaseInternalSerialization [20:09:00] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #21: 0.7 release (06master...06zeroseven) 02http://git.io/P_euzw [20:10:19] [13WikibaseDataModel] 15mariushoch closed pull request #21: 0.7 release (06master...06zeroseven) 02http://git.io/P_euzw [20:11:59] [13WikibaseDataModel] 15JeroenDeDauw tagged 060.7 at 06master: 02http://git.io/H_lRJg [20:12:46] [travis-ci] wmde/WikibaseDataModel/zeroseven/0be215f : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/20310229 [20:12:48] JeroenDeDauw: Update in Wikibase? Or shall I do that in my commit? [20:13:17] hoo: there should be a dedicated commit for the bump [20:13:29] ok :) [20:13:35] go ahead and make it [20:13:36] will do that first [20:13:51] Lydia_WMDE: I added a think to the weekly doc [20:13:55] *thing [20:15:44] JeroenDeDauw: thanks! [20:15:50] oh, hi Lydia_WMDE [20:16:02] JohnLewis: meep [20:16:17] Lydia_WMDE: Dev update? :p [20:16:30] benestar: definitely something to explore, yes! :) [20:16:39] Lydia_WMDE: Saw that guided tours thing? [20:17:46] JohnLewis: jep - query? [20:17:52] hoo: did! :D [20:18:01] and i'm slightly excited about the idea ;-) [20:18:14] Lydia_WMDE: Ok, greg wants us to deploy to test on Monday :) I guess that's ok with you?! [20:18:34] If so, I'll pick us a nice deploy date [20:19:23] hoo: for the tours extension? sure [20:19:30] ok :) [20:19:38] i think we should test it a bit on test though [20:19:42] before we go to the main site [20:19:45] That's why ;) [20:19:48] ;-) [20:19:48] ok [20:20:08]