[06:39:44] [13WikibaseDataModel] 15JeroenDeDauw created 06fixdoc (+1 new commit): 02http://git.io/DVlx5g [06:39:44] 13WikibaseDataModel/06fixdoc 14701809e 15jeroendedauw: Remove lying docs [06:39:55] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #14: Remove lying docs (06master...06fixdoc) 02http://git.io/M-7Nyg [06:41:05] [travis-ci] wmde/WikibaseDataModel#75 (fixdoc - 701809e : jeroendedauw): The build passed. [06:41:05] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/commit/701809e2b9a6 [06:41:05] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/20111990 [06:54:12] [13WikibaseDataModel] 15JeroenDeDauw created 06remdead (+1 new commit): 02http://git.io/IEoY-Q [06:54:12] 13WikibaseDataModel/06remdead 14411a0e2 15jeroendedauw: Remove dead code [06:55:14] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #15: Remove dead code (06master...06remdead) 02http://git.io/r02RSg [06:55:39] [travis-ci] wmde/WikibaseDataModel#77 (remdead - 411a0e2 : jeroendedauw): The build passed. [06:55:39] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/commit/411a0e2b1ec1 [06:55:39] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/20112641 [06:56:19] [13WikibaseDataModel] 15JeroenDeDauw created 06clean (+1 new commit): 02https://github.com/wmde/WikibaseDataModel/commit/9df9ab8f6b2b [06:56:19] 13WikibaseDataModel/06clean 149df9ab8 15jeroendedauw: Clean comments in Claims.php [06:56:29] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #16: Clean comments in Claims.php (06master...06clean) 02http://git.io/2hX61g [06:57:30] [travis-ci] wmde/WikibaseDataModel#79 (clean - 9df9ab8 : jeroendedauw): The build passed. [06:57:30] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/commit/9df9ab8f6b2b [06:57:30] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/20112699 [07:45:01] [13WikibaseDataModel] 15JeroenDeDauw created 06sitelinklist (+5 new commits): 02http://git.io/yP0-Bw [07:45:01] 13WikibaseDataModel/06sitelinklist 14a1fe7f9 15jeroendedauw: Add basis for SiteLinkList [07:45:01] 13WikibaseDataModel/06sitelinklist 14a200def 15jeroendedauw: Switch to IteratorAggregate, no need to implement all the Iterator stuff [07:45:01] 13WikibaseDataModel/06sitelinklist 14a8153f0 15jeroendedauw: Implement site id uniqueness constraint [07:46:01] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #17: Add SiteLinkList (06master...06sitelinklist) 02http://git.io/LIxiUQ [07:46:55] JeroenDeDauw: Hi! No need to CC me for mail to wikidata-tech. I've subscribed to it. [07:46:57] [travis-ci] wmde/WikibaseDataModel#81 (sitelinklist - 9c7c146 : jeroendedauw): The build passed. [07:46:57] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/compare/a1fe7f959f45^...9c7c14697edc [07:46:57] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/20114617 [08:42:46] Good morning #wikidata! [09:01:33] (03PS2) 10Daniel Kinzler: (bug 57741) Formatter for details of GlobeCoordinateValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 [09:01:53] DanielK_WMDE: https://travis-ci.org/wmde/WikibaseQueryEngine/builds/19209426 [09:02:06] branch: addshoreChanges [09:02:43] (03PS2) 10Daniel Kinzler: (bug 57742) Formatter for details of TimeValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 [09:07:58] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [09:12:13] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [09:16:55] (03PS7) 10Tobias Gritschacher: Browsertests: convert performance test scenario to outline [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 [09:22:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 (owner: 10Tobias Gritschacher) [10:00:27] (03PS1) 10: New Wikidata Build - 05/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116935 [10:05:45] [13DataValuesJavascript] 15snaterlicious created 06testsrefactoring (+1 new commit): 02http://git.io/-5wqjw [10:05:45] 13DataValuesJavascript/06testsrefactoring 147410b7b 15snaterlicious: Refactored test resources [10:06:51] [13DataValuesJavascript] 15snaterlicious opened pull request #31: Refactored test resources (06master...06testsrefactoring) 02http://git.io/Mt7wFA [10:08:13] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116935 [10:28:55] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06master: 02https://github.com/wmde/WikibaseDataModel/commit/865341bfbd22055be41d3cad92c7206cbeab8722 [10:28:55] 13WikibaseDataModel/06master 14865341b 15addshore: Merge pull request #14 from wmde/fixdoc... [10:30:00] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06master: 02http://git.io/zg4m9Q [10:30:00] 13WikibaseDataModel/06master 144de6694 15addshore: Update RelNotes about deprecated methods [10:30:20] [13WikibaseDataModel] 15addshore 04deleted 06clean at 149df9ab8: 02http://git.io/GcuuRQ [10:31:27] [13WikibaseDataModel] 15addshore closed pull request #17: Add SiteLinkList (06master...06sitelinklist) 02http://git.io/LIxiUQ [10:31:52] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06master: 02http://git.io/ciTQPw [10:31:52] 13WikibaseDataModel/06master 141a0e2a1 15addshore: SiteLinkList added to RelNotes [10:32:37] [13WikibaseDataModel] 15addshore 04deleted 06remdead at 14411a0e2: 02http://git.io/4knsXg [10:32:42] hah, addshore is stealing my commits! [10:32:53] Thiemo_WMDE: please go kick him or something ;p [10:33:52] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06master: 02http://git.io/Qrmr3g [10:33:52] 13WikibaseDataModel/06master 14b5140b4 15addshore: Update RELEASE-NOTES.md [10:36:46] addshore: stealing all my commits eh? ;p [10:36:52] :P [10:36:59] just cause you didnt do it right first time ;p [10:39:28] addshore: I'd have all of the merge conflicts to resolve if I put that into the PRs [10:39:52] true :P [10:40:16] I'm sure I remember you saying you loved merge conflicts once! :O [10:42:35] addshore: sure I do, though only if its on your commits [10:42:42] ;_; [10:45:18] (03PS1) 10Addshore: Fix SiteLinkTaregtProviderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116940 [10:50:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116940 (owner: 10Addshore) [11:04:48] (03CR) 10Tobias Gritschacher: [C: 032] Fix SiteLinkTaregtProviderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116940 (owner: 10Addshore) [11:05:35] (03PS3) 10Daniel Kinzler: (bug 57741) Formatter for details of GlobeCoordinateValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 [11:05:40] (03PS3) 10Daniel Kinzler: (bug 57742) Formatter for details of TimeValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 [11:05:56] (03PS8) 10Tobias Gritschacher: Browsertests: convert performance test scenario to outline [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 [11:06:19] (03PS21) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 [11:06:25] (03PS2) 10Bene: DNM Use SiteList::getSiteByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 [11:09:54] (03PS1) 10: New Wikidata Build - 05/03/2014 11:09 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116942 [11:10:51] (03Abandoned) 10Addshore: New Wikidata Build - 05/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116935 [11:11:13] hashar: if I remember there is a way to automatically add people as reviewer in certain repos? [11:11:25] addshore: yeah there is a bot for that [11:11:37] https://github.com/valhallasw/gerrit-reviewer-bot [11:11:39] where do I need to poke? [11:11:40] :) [11:11:46] the conf is done on meta https://www.mediawiki.org/wiki/Git/Reviewers [11:11:47] lovely [11:11:58] I have no clue how it works though :-] [11:12:13] you can also watch projects in Gerrit to receive email notifications on certain type of events [11:15:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [11:22:18] (03CR) 10Addshore: [C: 04-1] (bug 57741) Formatter for details of GlobeCoordinateValue (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [11:22:32] (03CR) 10Addshore: "Failing tests are totally unrelated :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [11:23:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [11:24:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116942 [11:28:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115886 (owner: 10Tobias Gritschacher) [11:31:56] [13Serialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/W4BL5A [11:31:56] 13Serialization/06master 14e534dd2 15jeroendedauw: Fix typo [11:32:17] (03CR) 10Addshore: [C: 04-1] (bug 57742) Formatter for details of TimeValue (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [11:32:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [11:33:03] (03CR) 10Addshore: [C: 032] New Wikidata Build - 05/03/2014 11:09 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116942 [11:33:54] Tobi_WMDE: branched [11:34:37] both wikibase and wikidata [11:36:29] addshore: great! [11:36:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [11:40:01] (03PS4) 10Addshore: Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 [11:40:11] (03CR) 10jenkins-bot: [V: 04-1] Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [11:41:02] (03PS5) 10Addshore: Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 [11:41:12] (03CR) 10Addshore: "PS5 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [11:41:53] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [11:45:12] addshore: heh class DispatchingDeserializer implements DispatchableDeserializer [11:46:44] (03PS4) 10Daniel Kinzler: (bug 57741) Formatter for details of GlobeCoordinateValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 [11:47:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [11:49:31] [13Serialization] 15JeroenDeDauw created 06split (+1 new commit): 02http://git.io/_1NACA [11:49:31] 13Serialization/06split 14059addd 15jeroendedauw: Split is(De)SerializerFor methods into their own interfaces [11:49:42] addshore: ^ [11:49:51] [13Serialization] 15JeroenDeDauw opened pull request #5: Split is(De)SerializerFor methods into their own interfaces (06master...06split) 02http://git.io/q29brg [11:50:00] addshore: please to not create a tag for this yet [11:51:15] [13Serialization] 15JeroenDeDauw pushed 1 new commit to 06split: 02http://git.io/WzNjDw [11:51:15] 13Serialization/06split 142046dac 15jeroendedauw: Add branch alias [11:52:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [11:52:55] (03PS6) 10Addshore: Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 [11:54:10] [13Serialization] 15addshore 04deleted 06split at 142046dac: 02http://git.io/lNCf6A [11:57:03] addshore: for this particular change, we should be happy we no longer run against master [11:57:14] Else this would have taken lots of effort to not break all of the things [11:57:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [12:02:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [12:02:30] 42 commits \o/ [12:02:35] [13Serialization] 15JeroenDeDauw pushed 4 new commits to 06master: 02http://git.io/uANX9Q [12:02:35] 13Serialization/06master 14423184c 15jeroendedauw: Fix IRC channel [12:02:35] 13Serialization/06master 14e37eacc 15jeroendedauw: Rem link to bz [12:02:35] 13Serialization/06master 14c6546f7 15jeroendedauw: Fix description capitalization [12:03:07] addshore: did you notice anything that bloks rel of this thing? [12:05:19] (03PS4) 10Thiemo Mättig (WMDE): Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 [12:05:28] (03CR) 10jenkins-bot: [V: 04-1] Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [12:06:33] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06SiteLinkListDeserializer (+2 new commits): 02http://git.io/pkua6A [12:06:33] 13WikibaseInternalSerialization/06SiteLinkListDeserializer 14ee61e96 15jeroendedauw: Added basis for SiteLinkListDeserializer [12:06:33] 13WikibaseInternalSerialization/06SiteLinkListDeserializer 144ba333b 15jeroendedauw: Implement most of the structural verification in SiteLinkListDeserializer [12:07:08] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #3: Add SiteLinkListDeserializer (06master...06SiteLinkListDeserializer) 02http://git.io/w9Xm0g [12:08:34] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/114486/ needs a rebase [12:09:10] yea, jenkins told me. :(((( [12:09:57] Tobi_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=62252 ;p [12:10:08] looks like I cant move it right now [12:10:09] (03PS5) 10Thiemo Mättig (WMDE): Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 [12:10:29] JeroenDeDauw: nope, probably worth having another pair of eyes go over it though [12:10:46] [13Serialization] 15JeroenDeDauw created 06psr4 (+1 new commit): 02http://git.io/enPI6Q [12:10:46] 13Serialization/06psr4 14bf62b32 15jeroendedauw: Use PSR-4 based loading [12:11:01] [13Serialization] 15JeroenDeDauw opened pull request #3: Use PSR-4 based loading (06master...06psr4) 02http://git.io/75ARUQ [12:11:05] addshore: I'm going to update DataValuesSerialization to use it now - if there are any problems, I will run into them [12:11:17] [= [12:11:27] heh - this GH notify thing is only showing the repo name here [12:11:30] not the org name [12:11:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [12:11:43] And we have two repos that are named Serialization ;p [12:13:25] JeroenDeDauw: we can fix that ;p [12:13:36] ill update the hooks in a bit [12:13:38] addshore: what? The message format> [12:13:41] k [12:13:45] its an option :) [12:13:53] This is so usefull https://www.versioneye.com/php/data-values:serialization/references [12:14:50] haha [12:15:20] addshore: https://github.com/addwiki/wikibase-api/blob/master/composer.json [12:15:25] Those upper bounda are risky [12:15:29] *bounds [12:15:41] indeed [12:15:45] I'd change ~0.x to ~0.x.0 [12:16:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [12:16:18] DM req is also odd, you don't want a 0.6.1? ;p [12:16:46] JeroenDeDauw: fixed ;p [12:19:07] i dont want 0.6.1 ;p [12:20:08] addshore: k, I'll sneakly delete the 0.6 tag then and recreate it ;p [12:20:40] Thought then I will be banned from all the respectable PHP events :| [12:21:24] addshore: https://github.com/DataValues/Serialization/pull/3 [12:21:51] [13Serialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/w_P5Ag [12:21:51] 13Serialization/06master 14e34818e 15addshore: Merge pull request #3 from DataValues/psr4... [12:27:19] JeroenDeDauw: the github irc hooks are set to use different users now ;p [12:29:41] addshore: DataValuesSerialization actually still worked with the new version [12:29:46] of Serialization [12:29:53] [13github-hook-updater] 15addshore pushed 1 new commit to 06master: 02http://git.io/nvkOlw [12:29:53] 13github-hook-updater/06master 14a09aeea 15addshore: Use different irc user depending on github org [12:30:05] So could have theoretically just increased the compat range [12:30:10] :O [12:30:23] we can still do that though right? :P [12:30:38] do what? [12:30:48] I moved the range now as you can see [12:31:13] will create rel of Serialization now [12:31:25] :> [12:31:54] [13Serialization] 15JeroenDeDauw tagged 063.0 at 06master: 02http://git.io/_PpcXA [12:33:04] [travis-ci] wmde/Serialization#30 (3.0 - dba84ac : jeroendedauw): The build passed. [12:33:04] [travis-ci] Change view : https://github.com/wmde/Serialization/compare/3.0 [12:33:04] [travis-ci] Build details : http://travis-ci.org/wmde/Serialization/builds/20128938 [12:33:27] [13github-hook-updater] 15addshore pushed 1 new commit to 06master: 02http://git.io/rI_dQQ [12:33:27] 13github-hook-updater/06master 14a27ed48 15addshore: Add Wikidata/easyrdf_lite [12:35:02] addshore: thanks for putting that stuff on GH and documenting it! [12:35:22] haha np! [12:35:33] saves going through each repo indiidually ;p [12:36:07] will probably make a few changes in a few weeks so it can nicely deal with hooks other than irc also!¬ [12:37:22] Lydia_WMDE: >> https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-Wikibase/ [12:39:09] https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-Wikibase/inspections/15dea892-0780-4150-88b7-7c0adaa8e38e [12:39:13] -0.02 :( [12:39:20] (03CR) 10Addshore: [C: 04-1] "-1 per ps3 comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [12:40:13] addshore: https://github.com/DataValues/Serialization/pull/4 [12:41:06] * addshore waits for travis [12:42:26] (03CR) 10Jeroen De Dauw: "More stuff in lib :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [12:43:04] [13Serialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/gtmUDQ [12:43:04] 13Serialization/06master 149f14fd9 15addshore: Change travis template [12:43:29] addshore: travis done [12:43:37] JeroenDeDauw: merged already [12:43:45] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06master: 02http://git.io/isSBZw [12:43:45] 13WikibaseDataModel/06master 14c805d7d 15addshore: Change travis template [12:44:05] [13DataValuesJavascript] 15addshore pushed 1 new commit to 06master: 02http://git.io/Li0iwA [12:44:05] 13DataValuesJavascript/06master 148066670 15addshore: Change travis template [12:44:20] [13DataTypes] 15addshore pushed 1 new commit to 06master: 02http://git.io/e7A2Lw [12:44:20] 13DataTypes/06master 14255bab5 15addshore: Change travis template [12:45:00] [13WikibaseQuery] 15addshore pushed 1 new commit to 06master: 02http://git.io/dQZdnA [12:45:00] 13WikibaseQuery/06master 1410090e7 15addshore: Change travis template [12:45:15] [13WikidataBuilder] 15addshore pushed 1 new commit to 06master: 02http://git.io/1ChyQQ [12:45:15] 13WikidataBuilder/06master 143f2662e 15addshore: Change travis template [12:45:55] [13WikibaseDatabase] 15addshore pushed 1 new commit to 06master: 02http://git.io/gp9JTQ [12:45:55] 13WikibaseDatabase/06master 147fc315f 15addshore: Add travis notifications [12:46:03] (03CR) 10Tobias Gritschacher: [C: 04-1] "This change does non-intended things with the "add qualifier" button:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [12:46:45] [13WikibaseDataModelSerialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/M1v2jQ [12:46:45] 13WikibaseDataModelSerialization/06master 1491c22a7 15addshore: Add travis notifications [12:47:03] all the bot spam :> [12:47:59] JeroenDeDauw: the bots really are taking over! [12:48:40] addshore: yes, we should just fire everyone except the bots [12:48:50] no wait [12:48:52] O_o [12:52:28] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/WcPMng [12:52:28] 13WikibaseDataModel/06master 146396dde 15jeroendedauw: Rem tailing space [12:52:43] (03CR) 10Addshore: [C: 04-1] Don't display languages based on ULS heuristics if I have a Babel box (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [12:53:48] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/VovVwg [12:53:48] 13WikibaseDataModel/06master 142250406 15jeroendedauw: Fix link in credits [12:58:10] the bots would never survive without us! \o/ [13:00:30] yee Tobi_WMDE ! they just woudlnt know what to say any more :P [13:02:12] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116942 [13:02:28] Tobi_WMDE: :< [13:09:16] (03CR) 10Tobias Gritschacher: "And, second thing: It does not handle deleted properties correctly. It does not show anything (just blank) as the label of the deleted pro" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [13:10:45] [13WikibaseDataModel] 15JeroenDeDauw created 06versions (+1 new commit): 02http://git.io/5kZvBw [13:10:45] 13WikibaseDataModel/06versions 145e8ff8a 15jeroendedauw: Use DataValues Serialization 1.x and narrow version ranges [13:11:05] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #18: Use DataValues Serialization 1.x and narrow version ranges (06master...06versions) 02http://git.io/iohIuA [13:11:35] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06versions from 145e8ff8a to 14f2b5a21: 02http://git.io/kQ1AZg [13:11:35] 13WikibaseDataModel/06versions 14f2b5a21 15jeroendedauw: Use DataValues Serialization 1.x and narrow version ranges [13:11:55] [travis-ci] wmde/WikibaseDataModel/versions/5e8ff8a : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/20130931 [13:13:18] addshore: https://github.com/wmde/WikibaseInternalSerialization/pull/3 [13:13:36] [travis-ci] wmde/WikibaseDataModel/versions/f2b5a21 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/20131044 [13:16:39] (03CR) 10Thiemo Mättig (WMDE): Don't display languages based on ULS heuristics if I have a Babel box (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [13:22:35] addshore: it's a beta issue. [13:22:40] ahh :P [13:23:03] probably related to https://bugzilla.wikimedia.org/show_bug.cgi?id=62244 but not sure [13:23:13] not able to login [13:23:39] I guess you'll see it too [13:23:53] delete all your cookies and try to login to beta then [13:32:57] (03CR) 10Tobias Gritschacher: Don't display languages based on ULS heuristics if I have a Babel box (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [13:36:08] (03CR) 10Addshore: Don't display languages based on ULS heuristics if I have a Babel box (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [13:41:38] addshore: did you address aude's comments in the rebase? https://gerrit.wikimedia.org/r/#/c/112470/ [13:41:54] Tobi_WMDE: I addressed them in the PS before the rebase [13:42:13] ahh.. missed that! confused tobi.. [13:46:03] :D [13:47:14] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06master: 02http://git.io/2XPn0A [13:47:14] 13WikibaseDataModel/06master 14dcd64b0 15addshore: Merge pull request #18 from wmde/versions... [13:51:43] addshore: do we not get IRC notifications for our components in DataValues? [13:51:51] can we have? [13:51:52] we do / should [13:52:08] DanielK_WMDE just made a pull request for Number [13:52:48] * addshore pokes it [13:53:20] hmmm [13:54:59] [13WikibaseDatabase] 15none pushed 3 new commits to 06master: 02http://git.io/CKySWQ [13:54:59] 13WikibaseDatabase/06master 140cb3601 15addshore: Update CHANGELOG and remove test @group foo [13:54:59] 13WikibaseDatabase/06master 14846137e 15Jeroen De Dauw: Merge pull request #15 from wmde/aaaaaaaaaaaahy... [13:54:59] 13WikibaseDatabase/06master 147fc315f 15addshore: Add travis notifications [13:55:12] mhhm, poking the datavalues irc hooks does nothing [13:55:18] but poking out wmde ones does.... [13:55:55] addshore: rights thing prob, will check [13:55:56] JeroenDeDauw: addshore: can we fix that? [13:56:02] thx [13:56:12] JeroenDeDauw: but the hook is there.. [13:56:41] but testing the hook doesnt seem to do anything :./ [13:57:12] the settings of the hook are identical except the nickname which is github-datavalues instead of github-wmde [13:57:39] ahhhhhhh [13:57:47] Adrian_WMDE: https://gerrit.wikimedia.org/r/#/c/115886/ is something smallish for you.. ;) [13:57:53] i think the nick is 1 char too long xD [13:57:58] makes it easier to add testcases for large items [13:58:15] haa [13:58:18] :) [13:58:21] [13Number] 15none pushed 3 new commits to 06master: 02http://git.io/3dbVYg [13:58:21] 13Number/06master 14bf7752a 15jeroendedauw: Make sure PHPUnit bootstrap commands get executed from the correct dir and from cli [13:58:21] 13Number/06master 1487bae10 15Jeroen De Dauw: Update bootstrap.php [13:58:22] 13Number/06master 14857d228 15Jeroen De Dauw: Merge pull request #1 from DataValues/bootstrap... [13:58:35] okay, will make a fix for all of the repos ;p [13:58:39] [13Number] 15none pushed 3 new commits to 06master: 02http://git.io/3dbVYg [13:58:39] 13Number/06master 14bf7752a 15jeroendedauw: Make sure PHPUnit bootstrap commands get executed from the correct dir and from cli [13:58:39] 13Number/06master 1487bae10 15Jeroen De Dauw: Update bootstrap.php [13:58:39] 13Number/06master 14857d228 15Jeroen De Dauw: Merge pull request #1 from DataValues/bootstrap... [13:58:52] flooding the channel!!! [13:59:15] :> [14:01:20] [13github-hook-updater] 15addshore pushed 1 new commit to 06master: 02http://git.io/KYsQsQ [14:01:20] 13github-hook-updater/06master 14c56d6a8 15addshore: Make irc nick shorter [14:01:23] Tobi_WMDE: JeroenDeDauw made the bot nicks shorter ;p [14:29:17] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06upvers (+1 new commit): 02http://git.io/rafFpQ [14:29:17] 13WikibaseInternalSerialization/06upvers 1403953b2 15jeroendedauw: Update serialization from v2 to v3 [14:29:32] addshore: ^ [14:29:37] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/32b2d00 : Christian Dullweber The build has errored. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20135487 [14:32:43] [13WikibaseInternalSerialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/-x8SCA [14:32:43] 13WikibaseInternalSerialization/06master 14ddc5934 15addshore: Merge pull request #4 from wmde/upvers... [14:35:30] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06remcandes (+1 new commit): 02http://git.io/JpLXBQ [14:35:30] 13WikibaseInternalSerialization/06remcandes 14c218587 15jeroendedauw: Remove not needed isDeserializerFor method [14:35:44] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #5: Remove not needed isDeserializerFor method (06master...06remcandes) 02http://git.io/lvHzqg [14:37:53] addshore: you are not the only one with a 10! https://scrutinizer-ci.com/g/wmde/WikibaseInternalSerialization/ [14:38:15] pah! :P [14:40:55] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/839d487 : Christian Dullweber The build has errored. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20136401 [14:48:16] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/d8d906d : Christian Dullweber The build passed. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20136948 [15:06:40] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/3a1be3e : Christian Dullweber The build was broken. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20138206 [15:06:45] [13WikibaseInternalSerialization] 15JeroenDeDauw 04force-pushed 06SiteLinkListDeserializer from 144ba333b to 1485fb0cd: 02http://git.io/T7vpeg [15:06:45] 13WikibaseInternalSerialization/06SiteLinkListDeserializer 141406d7a 15jeroendedauw: Added basis for SiteLinkListDeserializer [15:06:45] 13WikibaseInternalSerialization/06SiteLinkListDeserializer 14417a905 15jeroendedauw: Implement most of the structural verification in SiteLinkListDeserializer [15:06:45] 13WikibaseInternalSerialization/06SiteLinkListDeserializer 1479844d9 15jeroendedauw: Remove not needed isDeserializerFor method [15:12:52] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/GL2UOA [15:12:52] 13ValueView/06master 14988c674 15Tobi Gritschacher: Merge pull request #28 from wmde/returnNullOnEmptyValue... [15:14:25] (03CR) 10Tobias Gritschacher: [C: 032] Use user-defined animation duration instead of fixed time [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113931 (owner: 10Thiemo Mättig (WMDE)) [15:14:49] (03Merged) 10jenkins-bot: Use user-defined animation duration instead of fixed time [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113931 (owner: 10Thiemo Mättig (WMDE)) [15:20:12] (03CR) 10Tobias Gritschacher: [C: 032] Truncate search suggestions similar to mediawiki.searchSuggest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113373 (owner: 10Thiemo Mättig (WMDE)) [15:20:33] (03Merged) 10jenkins-bot: Truncate search suggestions similar to mediawiki.searchSuggest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113373 (owner: 10Thiemo Mättig (WMDE)) [15:22:12] (03CR) 10Tobias Gritschacher: [C: 04-1] "needs manual rebase :-(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113342 (owner: 10Thiemo Mättig (WMDE)) [15:22:15] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/501c34b : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20138825 [15:25:28] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/1B4sdQ [15:25:28] 13puppet-builder/06master 142d37562 15addshore: create /home/wdbuilder/.ssh if it doesnt exist [15:27:11] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/-C6Gvw [15:27:11] 13puppet-builder/06master 14e4a8489 15addshore: set permissions on .ssh dir [15:28:18] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5efd643 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20139494 [15:37:38] (03PS6) 10Thiemo Mättig (WMDE): Don't display languages based on ULS heuristics if I have a Babel box [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 [15:37:58] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/579290b : Christian Dullweber The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20140931 [15:43:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [15:54:51] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/2c786e1 : Christian Dullweber The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20142083 [15:59:02] (03PS4) 10Thiemo Mättig (WMDE): Avoid deep copy of global mediaWiki object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113342 [16:04:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113342 (owner: 10Thiemo Mättig (WMDE)) [16:05:08] hah, finally we branched :) [16:06:20] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/214d37d : Christian Dullweber The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20142873 [16:06:27] (03PS1) 10Hoo man: (Hotfix) Make mw.wikibase.getEntityObject() actually return non-Legacy data [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116980 [16:06:56] (03CR) 10Hoo man: "As the proper fix didn't yet make it into the branch" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116980 (owner: 10Hoo man) [16:07:03] [13puppet-builder] 15addshore created 06eqiad from 06master (+0 new commits): 02http://git.io/qpMuDQ [16:07:11] addshore: ^ mergeee [16:07:18] [13puppet-builder] 15addshore pushed 1 new commit to 06eqiad: 02http://git.io/G3dOxQ [16:07:18] 13puppet-builder/06eqiad 140921cd0 15addshore: use data instead of home [16:07:23] same hotfix we have deployed atm [16:11:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116980 (owner: 10Hoo man) [16:12:25] DanielK_WMDE: https://gerrit.wikimedia.org/r/116980 [16:12:36] (03CR) 10Addshore: [C: 032] (Hotfix) Make mw.wikibase.getEntityObject() actually return non-Legacy data [extensions/Wikibase] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116980 (owner: 10Hoo man) [16:12:44] thanks, addshore [16:13:09] *notes we have to make a new build* [16:13:18] addshore: Yeah, will do [16:13:24] :P [16:13:37] * addshore is currently poking eqiad [16:14:07] still upload/bits access troubles? [16:18:54] [travis-ci] Wikidata-lib/PropertySuggester/travis_config/61f719f : Christian Dullweber The build is still failing. http://travis-ci.org/Wikidata-lib/PropertySuggester/builds/20143795 [16:24:17] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.23-wmf17/69eff3f : Marius Hoch The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20143717 [16:29:12] hi, I'm trying to configure travis to test the PropertySuggester extension for Wikibase. The testcases are already running, the problem is that the test doesn't find a table that is added by the extension. https://github.com/Wikidata-lib/PropertySuggester/pull/35 [16:29:39] what is necessary to make tables available to tests? [16:30:14] I already added a hook that creates the table and added this in the setUp() method of the test: $this->tablesUsed[] = 'wbs_propertypairs'; [16:31:31] the only testcase I'm currently using tries to delete all data from user, wb_terms and wbs_propertypairs. the first 2 deletes are working, that last one doesn't. [16:33:15] (03PS3) 10Bene: Use SiteList::getSiteByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 [16:33:23] (03CR) 10jenkins-bot: [V: 04-1] Use SiteList::getSiteByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [16:35:49] [13Number] 15thiemowmde comment on pull request #2 14d47ad37: Personally, I think this is confusing. I try to avoid this when I can. I would prefer strval( ... ) in this case. 02http://git.io/JOEDqg [16:37:52] [13Number] 15thiemowmde comment on pull request #2 14d47ad37: If this isn't a general "Localizer" interface any more, shouldn't the class and file be renamed to "NumberLocalizer"? 02http://git.io/jpW4fQ [16:38:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [16:39:02] [13puppet-builder] 15addshore pushed 1 new commit to 06eqiad: 02http://git.io/bKsVdw [16:39:02] 13puppet-builder/06eqiad 14dbe306b 15addshore: Create known_hosts [16:40:02] [13puppet-builder] 15addshore pushed 1 new commit to 06eqiad: 02http://git.io/g5-jOQ [16:40:02] 13puppet-builder/06eqiad 146f03d94 15addshore: puppet create /data/wdbuilder/.ssh/known_hosts [16:40:57] [13Number] 15brightbyte pushed 1 new commit to 06ParseLocalizedQuantities: 02http://git.io/Wp1HmA [16:40:57] 13Number/06ParseLocalizedQuantities 140b644b8 15daniel: specify regex delimiter when callign unlocalizer [16:43:02] [13puppet-builder] 15addshore pushed 1 new commit to 06eqiad: 02http://git.io/x70Q1A [16:43:02] 13puppet-builder/06eqiad 14ae6c60f 15addshore: git stuff must require known_hosts [16:48:26] [13Number] 15brightbyte comment on pull request #2 140b644b8: Well, it'S in the number package. Also, it was really desigend to be a general localizer interface, with specific methods for localizing specific things. 02http://git.io/__gOqA [16:49:35] (03PS1) 10Daniel Kinzler: (bug 61911) use localized number patterns. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 [16:51:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [16:54:51] [13puppet-builder] 15addshore pushed 1 new commit to 06eqiad: 02http://git.io/-3PApQ [16:54:51] 13puppet-builder/06eqiad 140b93836 15addshore: Update README.md [16:55:26] [13puppet-builder] 15addshore pushed 1 new commit to 06eqiad: 02http://git.io/wrqK9w [16:55:26] 13puppet-builder/06eqiad 148148009 15addshore: Remove a todo that is done [16:55:46] [13puppet-builder] 15addshore opened pull request #1: Eqiad (06master...06eqiad) 02http://git.io/ixThfA [16:56:52] [13puppet-builder] 15tobijat 04deleted 06eqiad at 148148009: 02http://git.io/sfZ_Fg [16:59:07] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/g2N9CA [16:59:07] 13puppet-builder/06master 148eab4b7 15addshore: cron.sh change home > data [17:00:28] (03PS1) 10WikidataBuilder: New Wikidata Build - 05/03/2014 17:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116988 [17:00:32] success :P [17:01:07] (03PS4) 10Bene: Use SiteList::getSiteByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 [17:01:14] (03PS22) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 [17:01:32] [13Number] 15thiemowmde comment on pull request #2 140b644b8: Don't get me wrong, I'm sure you know this is far from being perfect and I know this isn't supposed to be perfect. But I really think this is bad design. Simple example: Try to parse "US$100".... 02http://git.io/K9xbIw [17:02:12] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/qYhsfA [17:02:12] 13puppet-builder/06master 149e11073 15addshore: readme use /data/wdbuilder/cron.sh [17:10:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [17:10:54] addshore: got your phone? [17:11:44] addshore: WHY NOT? [17:11:56] addshore: evil lying person! [17:11:57] because its at home charging :> [17:13:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116988 (owner: 10WikidataBuilder) [17:14:13] (03CR) 10Addshore: [C: 032] New Wikidata Build - 05/03/2014 17:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116988 (owner: 10WikidataBuilder) [17:15:07] (03PS23) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 [17:16:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [17:17:59] (03CR) 10Tobias Gritschacher: [C: 04-1] (bug 61911) use localized number patterns. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [17:21:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [17:22:35] (03PS1) 10Addshore: Make mw.wikibase.getEntityObject() actually return non-Legacydata [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116991 [17:22:37] (03CR) 10jenkins-bot: [V: 04-1] Make mw.wikibase.getEntityObject() actually return non-Legacydata [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116991 (owner: 10Addshore) [17:22:57] (03Abandoned) 10Addshore: Make mw.wikibase.getEntityObject() actually return non-Legacydata [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116991 (owner: 10Addshore) [17:24:07] (03PS1) 10Addshore: Make mw.wikibase.getEntityObject() actually return non-Legacydata [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116994 [17:30:44] (03CR) 10Daniel Kinzler: (bug 61911) use localized number patterns. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [17:31:28] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116991 (owner: 10Addshore) [17:37:24] DanielK_WMDE: --testsuite=QueryEngineIntegration [17:38:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116994 (owner: 10Addshore) [17:41:44] hoo: thanks for the merge :) [17:42:54] hoo: you therefore might also review https://gerrit.wikimedia.org/r/#/c/116746/ ;) [17:43:54] (03PS2) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [17:43:54] saw that patch earlier, looked good at first glance [17:44:37] I think I got some experience now [17:44:46] will need to take a deeper look, though (that's a vital feature and I'm not sure how well unit tested it is) [17:46:37] JeroenDeDauw: I fixed some of your complains here: https://gerrit.wikimedia.org/r/#/c/111609/ [17:46:47] not sure though if I corrected everything [17:46:57] maybe you can give me another review when you have time [17:47:59] hoo: almost 500 lines of unit tests [17:48:20] hoo: https://gerrit.wikimedia.org/r/#/c/116994/ [17:48:29] composer did some interesting removal of lines from an autoload [17:48:36] but the tests pass.... :P [17:48:58] addshore: compose update -o [17:49:00] :P [17:49:16] Autoload optimization weirdness, again :P [17:49:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [17:50:03] benestar: If that means that we have full coverage, that should be an easy review :) [17:50:08] (03PS2) 10Addshore: Make mw.wikibase.getEntityObject() actually return non-Legacydata [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116994 [17:50:14] hoo: that looks better ;p [17:51:07] (03CR) 10Hoo man: [C: 032] Make mw.wikibase.getEntityObject() actually return non-Legacydata [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116994 (owner: 10Addshore) [17:52:18] hoo: when does it have full coverage? Tests for all public methods? [17:52:42] benestar: If all code paths are run by the tests (and the results verified) [17:54:44] hoo: at least the parts changed are covered by the tests and actually verified [17:55:02] that's nice :) [17:55:02] Wikibase is tested very well anyhow [17:55:34] Indeed, but I still regularly break it without making the tests fail :/ [17:55:35] (03Merged) 10jenkins-bot: Make mw.wikibase.getEntityObject() actually return non-Legacydata [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116994 (owner: 10Addshore) [17:56:05] hoo: so the Lua parts are not tested that well? :P [17:56:44] (03PS3) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [17:56:50] benestar: No, I have full integration tests for these ;) [17:56:58] + unit tests for most of it [17:57:12] hehe, so what can you break then? [17:57:40] benestar: I'm not only working on Lua :P Did some replacing of deprecated methods etc. [17:58:03] ah, ok ;) [17:59:46] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.23-wmf17) - 10https://gerrit.wikimedia.org/r/116994 (owner: 10Addshore) [18:01:53] hoo: do you know a way against having to wait for reviews? :P [18:02:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [18:02:48] benestar: Clone yourself :P [18:02:59] hoo: clone? [18:03:16] benestar: Yeah, your clone can than review your chagens :P [18:03:19] ah, so that I can review my own work or what? [18:03:21] ^^ [18:03:32] I think I am working at the wrong times [18:04:11] benestar: Most non-trivial changes will sit in gerrit for some time, just start something new then [18:04:37] ok, that's some hope :) [18:04:37] if it's important (like a hotfix), we can do it faster though, but usually, there's just no need to hurry [18:05:39] benestar: We're still way fast than core (or most other extensions) ;) [18:05:42] * faster [18:06:13] hoo: is that an open source problem or does this happen in companies, too? [18:06:48] benestar: Companies as well [18:08:15] there was a nice article about CR of Microsoft kernel components, but I can't find it atm [18:08:43] hoo: ok, so I will start working at something else :) [18:10:26] (03CR) 10Thiemo Mättig (WMDE): (bug 61911) use localized number patterns. (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [18:21:07] [13WikibaseDatabase] 15addshore created 06sqliteIndexes (+1 new commit): 02http://git.io/Ni2L9Q [18:21:08] 13WikibaseDatabase/06sqliteIndexes 14f8a1f30 15addshore: Prepend table name to index names [18:25:08] [travis-ci] wmde/WikibaseDatabase/sqliteIndexes/f8a1f30 : addshore The build failed. http://travis-ci.org/wmde/WikibaseDatabase/builds/20153511 [18:28:50] [13WikibaseDatabase] 15addshore 04force-pushed 06sqliteIndexes from 14f8a1f30 to 14a8d7b96: 02http://git.io/tgHFgQ [18:28:50] 13WikibaseDatabase/06sqliteIndexes 14a8d7b96 15addshore: Prepend table name to index names [18:30:47] [travis-ci] wmde/WikibaseDatabase/sqliteIndexes/a8d7b96 : addshore The build was fixed. http://travis-ci.org/wmde/WikibaseDatabase/builds/20153920 [18:33:18] [13WikibaseDatabase] 15addshore opened pull request #16: Prepend table name to index names (06master...06sqliteIndexes) 02http://git.io/ivFNFw [18:38:17] [13WikibaseDatabase] 15brightbyte comment on pull request #16 14a8d7b96: Please use underscores in identifiers, not hyphens! 02http://git.io/kyfT-g [18:38:27] [13WikibaseDatabase] 15brightbyte comment on pull request #16 14a8d7b96: underscores! 02http://git.io/xxUb_w [18:39:22] [13WikibaseDatabase] 15addshore pushed 1 new commit to 06sqliteIndexes: 02http://git.io/VOWAIQ [18:39:22] 13WikibaseDatabase/06sqliteIndexes 14ea4ce5a 15addshore: Use _ instead of - in sqlite index names [18:41:36] [travis-ci] wmde/WikibaseDatabase/sqliteIndexes/ea4ce5a : addshore The build was broken. http://travis-ci.org/wmde/WikibaseDatabase/builds/20154605 [18:41:54] I dont believe you travis... [18:42:30] oh wait, yes I do [18:42:45] [13WikibaseDatabase] 15addshore 04force-pushed 06sqliteIndexes from 14ea4ce5a to 14bd47e14: 02http://git.io/tgHFgQ [18:42:45] 13WikibaseDatabase/06sqliteIndexes 14bd47e14 15addshore: Use _ instead of - in sqlite index names [18:43:24] [13WikibaseDatabase] 15addshore 04force-pushed 06sqliteIndexes from 14bd47e14 to 143c1c88e: 02http://git.io/tgHFgQ [18:43:24] 13WikibaseDatabase/06sqliteIndexes 143c1c88e 15addshore: Use _ instead of - in sqlite index names [18:45:00] [travis-ci] wmde/WikibaseDatabase/sqliteIndexes/bd47e14 : addshore The build has errored. http://travis-ci.org/wmde/WikibaseDatabase/builds/20154756 [18:45:07] erorr [18:48:03] [travis-ci] wmde/WikibaseDatabase/sqliteIndexes/3c1c88e : addshore The build was fixed. http://travis-ci.org/wmde/WikibaseDatabase/builds/20154834 [18:50:22] (03CR) 10Addshore: [C: 04-1] "needs tests!" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [18:50:30] benestar: ^^ [18:50:46] addshore: I am not sure if this makes really sense... [18:50:54] thus I did not create tests yet [18:51:20] the class has only one method, but I don't know another way to share code [18:51:26] addshore: or do you have a better idea? [18:51:59] benestar: we have somethig similar in repo https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/api/SiteLinkTargetProvider.php [18:52:09] only 1 method [18:52:25] ok, so it is nothing evil :) [18:52:30] nope =] [18:54:57] (03PS2) 10Daniel Kinzler: (bug 61911) use localized number patterns. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 [18:55:15] (03CR) 10Bene: "tests will follow in the next patch set." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [18:56:29] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116986 (owner: 10Daniel Kinzler) [19:02:24] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116988 (owner: 10WikidataBuilder) [19:19:40] (03PS4) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [19:19:57] (03CR) 10jenkins-bot: [V: 04-1] Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [19:20:18] https://github.com/wmde/WikibaseInternalSerialization/pull/5 [19:20:24] https://github.com/wmde/WikibaseInternalSerialization/pull/3 [19:20:26] addshore: ^ [19:25:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [19:30:30] (03PS5) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [19:30:53] (03CR) 10Daniel Kinzler: (bug 57742) Formatter for details of TimeValue (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [19:32:01] (03PS4) 10Daniel Kinzler: (bug 57742) Formatter for details of TimeValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 [19:37:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [19:41:17] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [19:42:07] hmm [19:42:17] i think that might be my fault [19:45:04] addshore: o_O wtf did you do? [19:51:58] (03CR) 10Daniel Kinzler: "@Jeroen: well, I see no obvious place to put this. The details formatter is useful mainly for diffs, and it uses MediaWiki localization an" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [19:52:04] (03PS5) 10Daniel Kinzler: (bug 57741) Formatter for details of GlobeCoordinateValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 [19:56:04] DanielK_WMDE: I broke all of the things ;p [19:56:47] (03PS6) 10Daniel Kinzler: (bug 57741) Formatter for details of GlobeCoordinateValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 [19:58:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [20:00:36] Lydia_WMDE: is there already a decision how the ui for badges should look like on repo? [20:01:08] addshore: stop breaking all of the things! [20:01:09] :P [20:01:16] benestar: give me a sec to get a mockup [20:01:36] thx [20:02:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [20:02:50] (03PS5) 10Daniel Kinzler: (bug 57742) Formatter for details of TimeValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 [20:02:55] (03PS7) 10Daniel Kinzler: (bug 57741) Formatter for details of GlobeCoordinateValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 [20:04:10] benestar: https://commons.wikimedia.org/wiki/File:Site_link_badges_edit_interface.png is the mockup we have but it is already a bit old [20:04:25] uh, I already know this one ;) [20:04:37] hah [20:04:38] ok [20:04:43] Lydia_WMDE: it does not work with multiple badges, though [20:04:43] i don't have anything else yet [20:04:46] yeah [20:05:24] Lydia_WMDE: maybe your design team wants to think about this again? [20:05:34] jep [20:05:42] will put it on the list [20:05:48] also who of you knows how the js interface works? [20:06:04] none of them are online anymore -.- [20:06:06] I think I'd need some advice when implementing it [20:06:11] oh definitely [20:06:25] i'm sure henning, thiemo and adrian can give that [20:06:35] ok, when are they online usually? [20:06:57] oh Thiemo_WMDE is even still here? [20:06:59] maybe [20:07:10] but anyway - "normal" business hours [20:07:15] or via the mailinglist [20:07:33] unless they're crazy like the others on the team and work at strange hours :P [20:07:59] will write to the mailing list "Please give me a tutorial how to work with Wikibase's javascript libary" [20:08:08] ^^ [20:08:53] :D [20:09:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [20:09:19] benestar: javascript "library". [20:09:19] Lydia_WMDE: ach ja, there is also https://commons.wikimedia.org/wiki/File:Site_link_badges_edit_interface_%282%29.png [20:09:34] benestar: if you rebase or poke your change enkins shouldnt complain because of me any more ;p [20:09:51] k [20:12:21] (03PS6) 10Bene: Created a SiteLinkProvider to query sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 [20:14:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [20:18:32] addshore: ^ thanks :) [20:18:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [20:18:48] --^ [20:23:31] Lydia_WMDE: I fear I have no time at normal business hours... [20:23:50] mail is quite hard for communication if I do not have a concrete question... [20:24:13] benestar: *nod* [20:24:49] benestar: let's get the mockup done first and then see how to proceed? [20:24:58] ok, that's fine [20:25:03] :) [20:25:24] (03PS14) 10Daniel Kinzler: (bug 62211) Refactoring EditEntity to use EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 [20:25:28] join #wikimedia-office [20:25:30] orr [20:27:20] DanielK_WMDE: ? [20:27:46] benestar: hm? i just missed the leading / [20:28:02] ah, k ;) [20:30:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [20:33:43] Lydia_WMDE: little thought concerning the mockup [20:33:56] you should also think about how the badges can be viewed in non-edit mode [20:34:35] *nod* [20:37:33] (03CR) 10Daniel Kinzler: "basically fine, some more suggestions. ignore them if urgent." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [20:55:36] (03CR) 10Daniel Kinzler: [C: 04-1] "looks good overall, some questions, -1 just for attention." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114486 (owner: 10Thiemo Mättig (WMDE)) [20:56:42] (03CR) 10Addshore: [C: 032] "but yes we should split lib in a sensible way at some point! :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [20:57:03] (03CR) 10Addshore: [C: 032] "but yes we should split lib in a sensible way at some point! :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [21:04:30] [13WikibaseDatabase] 15thiemowmde comment on pull request #16 143c1c88e: Call this $formattedTableName as well? 02http://git.io/ZCKPwg [21:04:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7ad9014 : daniel The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20163662 [21:06:30] [13WikibaseDatabase] 15addshore pushed 1 new commit to 06sqliteIndexes: 02http://git.io/J5b0-Q [21:06:30] 13WikibaseDatabase/06sqliteIndexes 147b67381 15addshore: rename $tableName to $formattedTableName [21:10:11] [travis-ci] wmde/WikibaseDatabase/sqliteIndexes/7b67381 : addshore The build has errored. http://travis-ci.org/wmde/WikibaseDatabase/builds/20164228 [21:16:31] (03PS1) 10Raimond Spekking: Revert "Localisation updates from https://translatewiki.net." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117085 [21:16:42] (03CR) 10Raimond Spekking: [C: 032] Revert "Localisation updates from https://translatewiki.net." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117085 (owner: 10Raimond Spekking) [21:17:07] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/bf7f112 : daniel The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20163672 [21:18:53] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117080 (owner: 10L10n-bot) [21:23:10] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117085 (owner: 10Raimond Spekking) [21:26:12] (03CR) 10Daniel Kinzler: [C: 04-1] "Please get rid of the special case when looking up sitelinks (see comment there). that wa,y badges don't need to be optional any more eith" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [21:29:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ecb954d : Translation updater bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20164705 [21:30:30] (03CR) 10Daniel Kinzler: [C: 031] "looks good, too tired for a proper review now" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [21:32:00] [13WikibaseDatabase] 15thiemowmde 04deleted 06sqliteIndexes at 147b67381: 02http://git.io/_nA5Hw [21:35:29] [travis-ci] wmde/WikibaseQueryEngine#22 (addshoreChanges - 0fb8037 : addshore): The build is still failing. [21:35:29] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/df30f3ca9c3b...0fb803743fdf [21:35:29] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19279012 [21:35:51] bad travis! [21:36:10] [travis-ci] wmde/WikibaseDatabase/master/a7fbf2b : thiemowmde The build has errored. http://travis-ci.org/wmde/WikibaseDatabase/builds/20165826 [21:37:37] * ^d fumes at the wikidata search deletion bug [21:37:53] ^d: Any news? [21:37:58] Do you need any help? [21:38:34] [travis-ci] wmde/WikibaseQueryEngine#22 (addshoreChanges - 0fb8037 : addshore): The build is still failing. [21:38:34] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/df30f3ca9c3b...0fb803743fdf [21:38:34] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19279012 [21:39:23] <^d> hoo: More examples of it being broken might be useful. Right now I'm having trouble replicating. [21:39:41] <^d> And my working theory is an earlier call to the ArticleDeleteComplete hook failed before we got to ours. [21:39:49] <^d> (But I have no logs to back this up yet) [21:40:51] ^d: mh... have you grepped through the production logs about that yet? [21:41:05] <^d> Yep, but I couldn't find anything particularly telling about that page. [21:41:16] <^d> (ie: nothing showed up when I grepped for it) [21:42:57] what'S the problem? [21:43:57] <^d> https://bugzilla.wikimedia.org/show_bug.cgi?id=61464 [21:44:06] <^d> "deleted page shows up in search results on Wikidata" [21:46:07] [travis-ci] wmde/WikibaseQueryEngine#22 (addshoreChanges - 0fb8037 : addshore): The build is still failing. [21:46:07] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/df30f3ca9c3b...0fb803743fdf [21:46:07] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19279012 [21:49:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/3079d22 : Raimond Spekking The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20164940