[03:54:05] (03PS1) 10Vikassy: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116713 [03:59:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116713 (owner: 10Vikassy) [04:49:51] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/T7H5vQ [04:49:51] 13WikibaseInternalSerialization/06master 141f17fd8 15jeroendedauw: use getcwd rather than exec( "pwd" ) [05:10:53] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 4 new commits to 06master: 02http://git.io/KkHoxg [05:10:53] 13WikibaseInternalSerialization/06master 14b411e2b 15jeroendedauw: Clean up copied code from DataModelSerialization so work on this component can start [05:10:53] 13WikibaseInternalSerialization/06master 148963b4f 15jeroendedauw: Fix links in README [05:10:53] 13WikibaseInternalSerialization/06master 14a332bfe 15jeroendedauw: Add Scrutinizer link [05:53:26] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/2w8a4g [05:53:26] 13WikibaseDataModel/06master 147f055e1 15Jeroen De Dauw: Update RELEASE-NOTES.md [05:55:31] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/maRfxA [05:55:31] 13WikibaseDataModel/06master 148bcde87 15jeroendedauw: Use PSR-4 based loading [06:22:16] [13WikibaseDataModel] 15JeroenDeDauw created 06TypedSnak (+1 new commit): 02http://git.io/LxZ77Q [06:22:16] 13WikibaseDataModel/06TypedSnak 14f91c369 15jeroendedauw: Add TypedSnak... [06:23:06] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #12: Add TypedSnak (06master...06TypedSnak) 02http://git.io/uUnhtA [06:23:36] [travis-ci] wmde/WikibaseDataModel#66 (TypedSnak - f91c369 : jeroendedauw): The build passed. [06:23:36] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/commit/f91c3698e988 [06:23:36] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/20032566 [06:28:23] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/eHnyVQ [06:28:23] 13WikibaseDataModel/06master 145751dd4 15jeroendedauw: Add branch alias [06:28:23] 13WikibaseDataModel/06master 14fd33377 15jeroendedauw: Fix typo [06:58:46] [13WikibaseDataModel] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/3uRmcA [06:58:46] 13WikibaseDataModel/06master 143db52ab 15snaterlicious: Merge pull request #12 from wmde/TypedSnak... [06:58:56] [13WikibaseDataModel] 15snaterlicious 04deleted 06TypedSnak at 14f91c369: 02http://git.io/9bP8cQ [07:04:06] [13WikibaseDataModel] 15JeroenDeDauw created 06propsnakinterface (+1 new commit): 02http://git.io/fF315g [07:04:06] 13WikibaseDataModel/06propsnakinterface 148b3b718 15jeroendedauw: Remove unused PropertySnak interface [07:04:26] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #13: Remove unused PropertySnak interface (06master...06propsnakinterface) 02http://git.io/BYVpOA [07:05:13] [travis-ci] wmde/WikibaseDataModel#70 (propsnakinterface - 8b3b718 : jeroendedauw): The build failed. [07:05:13] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/commit/8b3b718ebe1d [07:05:13] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/20033779 [07:07:21] * JeroenDeDauw failed [07:07:26] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06propsnakinterface from 148b3b718 to 149eaecc0: 02http://git.io/DN7dcg [07:07:26] 13WikibaseDataModel/06propsnakinterface 149eaecc0 15jeroendedauw: Remove unused PropertySnak interface [07:09:46] [travis-ci] wmde/WikibaseDataModel#73 (propsnakinterface - 9eaecc0 : jeroendedauw): The build was fixed. [07:09:46] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/compare/8b3b718ebe1d...9eaecc06d8b3 [07:09:46] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/20033858 [07:18:53] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06SnakDeserializer (+1 new commit): 02http://git.io/8YNlvg [07:18:53] 13WikibaseInternalSerialization/06SnakDeserializer 146161b52 15jeroendedauw: Add first degenerate test for SnakDeserializer [07:19:43] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06comvers (+1 new commit): 02http://git.io/zCjmMA [07:19:43] 13WikibaseInternalSerialization/06comvers 14fe11fce 15jeroendedauw: Update used DM version so TypedSnak is included [07:20:02] [13WikibaseInternalSerialization] 15JeroenDeDauw merged 06comvers into 06master: 02http://git.io/xwovMw [07:20:18] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #1: Add first degenerate test for SnakDeserializer (06master...06SnakDeserializer) 02http://git.io/9UdtNw [08:21:02] [13WikibaseInternalSerialization] 15JeroenDeDauw 04force-pushed 06SnakDeserializer from 146161b52 to 148e2b774: 02http://git.io/TOo3PA [08:21:02] 13WikibaseInternalSerialization/06SnakDeserializer 14cacaefb 15jeroendedauw: Add first degenerate test for SnakDeserializer [08:21:03] 13WikibaseInternalSerialization/06SnakDeserializer 1491e93c1 15jeroendedauw: Implemented SnakDeserializer->isDeserializerFor [08:21:03] 13WikibaseInternalSerialization/06SnakDeserializer 148e2b774 15jeroendedauw: Finish SnakDeserializer implementation [08:21:41] Lydia_WMDE are you around ? [08:25:23] GerardM-: hey [08:25:24] yes [08:25:55] I understand from Magnus that there are problems with replication and with backups [08:26:15] yes [08:26:16] yesterday he mentioned that several days of daily backups did not happen [08:26:31] i am writing an email to try to get it fixed by ops [08:26:47] and in the replication changes do not get from Wikidata into the replication process [08:27:17] ok [08:27:19] thx [08:27:30] yesterday they send me away stating that it must be a problem with Reasonator ... "the replicatipon indicates that it is up to the second" [08:28:07] ok [08:28:15] i can definitely confirm the dump issue [08:28:41] can you keep me in the loop so that we can get Reasonator working properly again ? [08:29:05] also I noted that changes made by Widar did not show in Wikidata but did show in the history [08:29:25] that suggests problems in Wikidata itself as well [08:30:03] if you want me to, I can probably create examples [08:30:18] that'd be good, yes [08:32:52] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06SnakDeserializer: 02http://git.io/4fmHLA [08:32:52] 13WikibaseInternalSerialization/06SnakDeserializer 149b2cfca 15jeroendedauw: Added SnakDeserializer integartion roundtrip test [08:33:45] Lydia_WMDE: quit slacking off and come to the office already! :) [08:34:36] i will [08:34:43] in an hour or 1.5 [08:35:11] Lydia_WMDE: in 1.5 you will be 5 min to late for the daily [08:35:29] nowait [08:35:33] when is it now? :D [08:35:36] 11:45? [08:35:36] math ftw [08:35:39] yes [08:35:42] k [08:46:34] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06onezero (+1 new commit): 02http://git.io/NAdkOw [08:46:34] 13WikibaseInternalSerialization/06onezero 1435be237 15jeroendedauw: Add branch alias and add since tag to public interface class [08:46:44] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #2: Add branch alias and add since tag to public interface class (06master...06onezero) 02http://git.io/RKqXBg [08:46:59] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/6Oe6YA [08:46:59] 13WikibaseInternalSerialization/06master 14420e234 15Jeroen De Dauw: Merge pull request #2 from wmde/onezero... [09:02:30] [13Common] 15JeroenDeDauw closed pull request #3: Make StringFormatter trim value (06master...06stringTrim) 02http://git.io/CMmxSw [09:14:58] (03CR) 10Tobias Gritschacher: [C: 032] Updated Ruby version from 2.1.0 to 2.1.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116713 (owner: 10Vikassy) [09:15:13] (03Merged) 10jenkins-bot: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116713 (owner: 10Vikassy) [09:29:18] (03CR) 10Jeroen De Dauw: "You rather have us not retain compatibility with SQLite?! Really?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114490 (owner: 10Jeroen De Dauw) [09:30:56] (03CR) 10Jeroen De Dauw: "> i18n messages are marked as DO NOT TRANSLATE" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [09:33:34] (03CR) 10Jeroen De Dauw: "What is the reasoning behind keeping this in lib rather than moving it to the appropriate component? What are the dependencies this code c" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [09:38:34] (03CR) 10Jeroen De Dauw: [C: 031] Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [09:38:41] (03CR) 10Jeroen De Dauw: Inject Guid Validator and Parser in ChangeOpClaim (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [09:39:24] aggg, why is the daily so late now? [10:00:26] (03PS1) 10: New Wikidata Build - 04/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116727 [10:08:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116727 [10:09:37] [13Common] 15thiemowmde reopened pull request #3: Make StringFormatter trim value (06master...06stringTrim) 02http://git.io/CMmxSw [10:18:10] (03PS1) 10Jeroen De Dauw: Add upper bound to diff version range [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116728 [10:19:12] (03PS1) 10Jeroen De Dauw: Specify version of easyrdf to use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116729 [10:20:14] (03CR) 10Hoo man: [C: 032] Add upper bound to diff version range [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116728 (owner: 10Jeroen De Dauw) [10:20:29] (03CR) 10Hoo man: [C: 032] Specify version of easyrdf to use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116729 (owner: 10Jeroen De Dauw) [10:20:35] (03Merged) 10jenkins-bot: Add upper bound to diff version range [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116728 (owner: 10Jeroen De Dauw) [10:20:37] (03CR) 10jenkins-bot: [V: 04-1] Specify version of easyrdf to use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116729 (owner: 10Jeroen De Dauw) [10:20:50] ffs [10:21:07] JeroenDeDauw: Will you rebase? Or shall I check it out and do it myself [10:21:08] ? [10:24:40] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116728 (owner: 10Jeroen De Dauw) [10:27:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/126cb52 : jeroendedauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20042598 [10:28:50] (03CR) 10Tobias Gritschacher: "Please address the comments and we can get this merged." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [10:28:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116729 (owner: 10Jeroen De Dauw) [10:30:46] (03CR) 10Tobias Gritschacher: "For this there's now bug 62183" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [10:32:23] (03Abandoned) 10Addshore: Tidy up out .travis.yml file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115668 (owner: 10Addshore) [10:39:18] (03PS2) 10Jeroen De Dauw: Specify version of easyrdf to use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116729 [10:39:40] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Specify version of easyrdf to use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116729 (owner: 10Jeroen De Dauw) [10:40:35] hoo: rebased [10:40:37] silly git [10:40:43] that should not conflict [10:41:04] *should* is the word :D [10:42:17] [13WikibaseInternalSerialization] 15addshore closed pull request #1: Add first degenerate test for SnakDeserializer (06master...06SnakDeserializer) 02http://git.io/9UdtNw [10:42:47] [13WikibaseDataModel] 15addshore closed pull request #13: Remove unused PropertySnak interface (06master...06propsnakinterface) 02http://git.io/BYVpOA [10:44:17] [13Common] 15JeroenDeDauw closed pull request #3: Make StringFormatter trim value (06master...06stringTrim) 02http://git.io/CMmxSw [10:44:40] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116729 (owner: 10Jeroen De Dauw) [10:47:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/33bb1bf : jeroendedauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20043684 [10:47:51] Lydia_WMDE: In the Lua change announces: Shall I use Lua terms or rather more general ones (which at times might not be 110% correct)... like metatable vs. object [10:48:45] hoo: use metatable ("object") [10:48:56] Lydia_WMDE: this is a blocker: https://gerrit.wikimedia.org/r/#/c/116236/ [10:49:02] we should make a bug for it [10:49:15] hoo: did the hacky version of that patch get deployed yesterday? [10:49:18] oh yes, please [10:49:22] hoo: what DanielK_WMDE said [10:49:23] DanielK_WMDE: Yep, it's live [10:49:31] DanielK_WMDE: looking [10:49:38] good. so let's not forget to fix it properly on master [10:49:38] and it broke thousands of pages on itwiki already [10:49:58] hoo: o_O they were using the new style interface with old style expectations? [10:50:37] DanielK_WMDE: Yep, they just changed all occurrences in widely used templates and after the deploy the suddenly had *a lot of* pages with script errors [10:50:46] was down to 14k last time I checked :P [10:51:09] * tehy [10:51:11] * they [10:54:41] Lydia_WMDE: When will aude be back at work? [11:03:45] Anyone around to review https://gerrit.wikimedia.org/r/#/c/116730/ ? [11:05:20] DanielK_WMDE: by the way, here you got your tests: https://gerrit.wikimedia.org/r/#/c/111159/ [11:14:33] hoo: thursday [11:15:07] ok :) [11:28:09] benestar: looking... [11:28:41] thanks :) [11:30:16] hoo: have you looked at my comments on the Capiunto patch? Improving the documentation would help me test this - which means I could at some point merge it :) [11:30:36] Yeah, will do that later on [11:30:53] although some will require a lot of changes to unit tests etc. :/ [11:31:04] hoo: most of the points are cosmetic, some are related to the actual Lua interface, and one or two things are still unclear to me (like, when am I creating and manipulating an object, when and where does it get rendered into HTML) [11:31:41] hoo: like what, chainging the order of parameters? [11:32:05] Yeah [11:32:14] as I tried to keep the order throughout the stack AFAIR [11:32:25] leave it, then. it's not a big deal [11:32:48] the way images are provided is another things that could be improved. that could be done in a follow-up though [11:32:56] the rest is just grammar/cosmetics/clarity [11:33:45] hoo: the documentation should be comprehensive enough to allow me to test the meodule - that's the ultimate test for the documentation :) [11:34:05] Yeah [11:34:45] (03CR) 10Daniel Kinzler: "found another typo" (031 comment) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [11:36:48] :P [11:52:16] (03CR) 10Addshore: [C: 04-1] (bug 61264) Refactoring EditEntity to use EntityStore (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [11:52:49] (03CR) 10Addshore: "heh, also found some comments from an old review..." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [12:14:10] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 04/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116727 [12:16:45] (03Merged) 10jenkins-bot: New Wikidata Build - 04/03/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116727 [12:18:37] Thiemo_WMDE: commented on your core patch re documentation [12:18:50] How to staert with editing wikidata? [12:19:15] How to start with editing wikidata? [12:19:38] Lekshmi: well, what do you want to edit, specifically? [12:19:54] Lekshmi: have you seen the "contribute" section on the main page? [12:21:05] ya [12:22:09] did you find anything that you would like to do? [12:25:02] "Improving a random item" and "fixing item properties violating their constriants" seem good.But I am not getting a clear idea of what they are and how to start with? [12:28:02] what constraints are mentioned to be voiated? [12:36:05] Lekshmi: i think there are lists of constraint violatiosn generated by bot. i'm not an expert on that, though... [12:36:44] an example of a "constraint" would be that the "father" of a person must be a person too (and should probably be male) [12:36:47] stuff like that [12:36:50] mistakes are made. [12:37:34] Lekshmi: "improving a random item"... wel,, the easiest way to do that is to click the "random" link in the sidebar, see what you find, and see if you can add anything - most likely, labels, descriptions and aliases in more languages. [12:38:19] or pick something/someone you know a lot about, and try to add statements (with good sources). your home town, the mayor of your home town, or something. [12:38:52] how can i pick something like that??? [12:39:31] Lekshmi: I guess you speak more languages than English? You might want to add these to your user page first? ;) [12:41:33] Lekshmi: type a name into the search box, go to the page, start editing [12:52:14] (03PS12) 10Daniel Kinzler: (bug 61264) Refactoring EditEntity to use EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 [12:52:32] (03CR) 10Daniel Kinzler: (bug 61264) Refactoring EditEntity to use EntityStore (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [12:53:18] addshore: --^ [12:57:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [13:01:50] waht is the difference btwn wikisource pages and wikivoyage pages? [13:37:34] Lekshmi: well, one points to wikisource.org (a public domain source repository), the other to wikivoyage.org (a travel guide). [13:37:51] you can read about them on wikipedia, i guess :P [13:39:35] If I edit some article ,hw can I know whthe changes are accepted or not?? [13:39:44] *whether [13:41:04] In most cases they'll show up immediately... [13:43:39] Lekshmi: all changes are accepted. you save it, it's there - that'S what "wiki" means. your changes might get reverted by someone else later, if there'S a problem with them. [13:44:42] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/116727 [13:45:49] FR? ;) [13:54:43] (03PS17) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 [14:00:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [14:03:52] Lydia_WMDE: hi, may I ask you a question atm [14:03:55] ? [14:04:11] or too busy? :P [14:04:14] in a meeting [14:04:16] but wasup? [14:06:55] Lydia_WMDE: just a question how we should get the title of a badge displayed on client [14:07:09] we could use the description of the wikidata item or an extra mediawiki message [14:07:25] imho the label of the item makes most sense [14:07:39] ok [14:07:41] :) [14:07:43] \o/ [14:19:51] (03PS18) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 [14:21:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [14:23:28] wtf happened here? http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/711/console/ [14:23:55] Could not open input file: composer.phar [14:28:57] (03PS1) 10Bene: DNM Use SiteList::getSiteByNavigationId in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 [14:29:09] hoo: but that's not my fault?! [14:30:59] don't think it's your fault, but also don't know how that jenkins is actually pulling the file... so no diea [14:31:03] * idea [14:34:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116746 (owner: 10Bene) [14:37:07] hoo: who could fix that? [14:37:45] aude or Tobi, both not around [14:38:56] mh [14:39:25] curl -sS https://getcomposer.org/installer | php [14:39:29] that looks correct [14:40:59] benestar: Should be fine again, that was a temporary network problem [14:41:09] ok [14:43:08] (03PS19) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 [14:43:49] JeroenDeDauw: hey, would be greate if you could review/merge https://gerrit.wikimedia.org/r/#/c/116730/ because some other patches rely on it [14:44:01] *great [14:45:16] benestar: He can't merge in core [14:45:33] hoo: :/ but you can, can't you? [14:45:37] :P [14:45:45] maybe :P I can :D [14:45:54] hoo: so you can also review xD [14:46:21] * benestar likes to get on hoo's nerves [14:48:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [14:48:37] benestar: Do the test sites have any navigation ids? [14:48:44] hoo: yes [14:49:16] hoo: they are simply the languages [14:49:44] @var array of integer => offset [14:49:46] hoo: https://github.com/wikimedia/mediawiki-core/blob/master/tests/phpunit/includes/site/TestSites.php [14:49:46] mh [14:50:04] better than nothing which confused me a bit [14:50:09] but I can also remove it [14:50:43] benestar: It would be nice to have one more navigation id which is != lang code or database name or so [14:51:00] ok the 'spam' test site has that [14:51:04] so nevermind [14:53:26] by the way, does WikidataJenkins use the master of mediawiki? [14:53:56] wget https://github.com/wikimedia/mediawiki-core/archive/$MW.tar.gz [14:54:02] export MW=master [14:54:11] so that's probably a few hours old [14:54:24] not sure how often these are recreated [14:59:21] benestar: can you expand the description of the patchset? where exactly is this used? is there a related bug? [14:59:38] Thiemo_WMDE: bug not, but a comment in the source [15:00:17] I have to patches where it is used: https://gerrit.wikimedia.org/r/#/c/116746/ and https://gerrit.wikimedia.org/r/#/c/111609/ [15:00:21] *two [15:00:36] reviewers (like me) will have a hard time understanding what this does and why this is needed. [15:12:39] Thiemo_WMDE: "we need to get a site based on the local navigation id" [15:12:50] what is hard to understand here? [15:13:16] hoo|away: did you review? [16:10:42] (03PS13) 10Tobias Gritschacher: (bug 62211) Refactoring EditEntity to use EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [16:12:33] (03PS1) 10Daniel Kinzler: Check leading and trailing whitespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116751 [16:15:24] addshore: please to add list of instances to https://bugzilla.wikimedia.org/show_bug.cgi?id=62213 [16:17:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [16:21:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116751 (owner: 10Daniel Kinzler) [16:24:43] Lydia_WMDE: done [16:24:56] addshore: thanks! [16:53:11] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think I found one mistake in UpdateRepoOnMoveJob.php. Please correct me if I'm wrong." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [17:15:50] (03PS1) 10Daniel Kinzler: Formatter showing details of TimeValue in diffs. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 [17:19:19] (03CR) 10Addshore: [C: 04-1] "Does this need to be in lib?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [17:20:14] (03CR) 10Addshore: [C: 032] Check leading and trailing whitespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116751 (owner: 10Daniel Kinzler) [17:21:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [17:38:01] (03CR) 10Thiemo Mättig (WMDE): Formatter showing details of TimeValue in diffs. (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116761 (owner: 10Daniel Kinzler) [17:42:11] (03PS1) 10Daniel Kinzler: Formatter showing details of GlobeCoordinateValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 [17:47:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [17:48:28] (03CR) 10Thiemo Mättig (WMDE): Formatter showing details of GlobeCoordinateValue (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116763 (owner: 10Daniel Kinzler) [17:49:30] Hi [18:20:34] addshore: And did the coordinates get into the sprint? [18:27:53] (03CR) 10Daniel Kinzler: "looks like you are right about all of these, will look into it tomorrow :)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112934 (owner: 10Daniel Kinzler) [20:06:44] hoo: what has to be done until the change is ok? [20:07:26] benestar: did you change the comments? If so, I'm ok with it [20:07:42] although I'd prefer a +1 from Jeroen (who is probably sleeping due to jetlab) [20:07:45] * jetlag [20:07:47] hoo: oh, I ought they'd be ok [20:08:03] hoo: he added a comment but did not complain [20:08:16] maybe he is ok or he did not look at the other parts [20:09:41] hoo: ok, removed the additional comments [20:10:54] benestar|afk: If you could get Daniel or so to comment, I'm fine with it... if not I might get in deeper and merge it myself [20:10:56] but not now [20:32:50] (03PS20) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 [20:38:13] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [20:52:18] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/116850 (owner: 10L10n-bot) [20:54:33] <^d> Anyone about who knows their way around Wikibase code? [20:54:58] ^d: what do you need? [20:55:27] <^d> Trying to figure out a search bug. Wondering where entity deletion is handled. [20:55:48] ^d: Hi [20:55:51] <^d> Specifically, [[Q9028640]] was deleted but not from the search index and I need to know where I need hook(s) :) [20:55:54] you mean the bug that deleted entities show in search results? [20:56:02] <^d> Yep, trying to fix that. [20:56:10] I think it isn't a wikibase bug? [20:56:24] hooks are all located in the WikibaseRepo.hooks.php file [20:56:28] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/cb41c36 : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/20083949 [20:56:50] <^d> benestar: I'm pretty sure it's a Cirrus bug but I need to understand Wikibase deletion to figure out how to fix it ;-) [20:57:06] ok [20:58:14] ^d: take a look at the onArticleDeleteComplete hook in repo/WikibaseRepo.hooks.php method [20:58:37] <^d> Yep. [20:58:43] <^d> We call the same hook.