[05:30:53] (03CR) 10Bene: "Not tested, but looks good so far." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114979 (owner: 10Tpt) [07:56:57] [13ValueView] 15adrianlang comment on pull request #27 143e11efd: This is directly modeled after [$.toggle](https://api.jquery.com/toggle/#toggle-showOrHide). I might agree to `toggleEnabled( bool )`, though, since this is not about showing and hiding. 02http://git.io/Z9sgsg [08:18:23] [13ValueView] 15adrianlang created 06returnNullOnEmptyValue (+1 new commit): 02http://git.io/dBYT1Q [08:18:23] 13ValueView/06returnNullOnEmptyValue 14612eec6 15Adrian Lang: Make StringValue expert's _getRawValue return null for empty strings... [10:00:29] (03PS1) 10: New Wikidata Build - 26/02/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115589 [10:08:23] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115589 [10:11:04] (03Merged) 10jenkins-bot: New Wikidata Build - 26/02/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115589 [10:11:32] :> [10:41:03] (03PS1) 10Adrian Lang: Correctly scrape reference and source lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115590 [10:46:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115590 (owner: 10Adrian Lang) [11:02:22] (03CR) 10Addshore: [C: 032] Correctly scrape reference and source lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115590 (owner: 10Adrian Lang) [11:02:33] (03PS1) 10Addshore: Correctly scrape reference and source lists [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115593 [11:02:45] (03Merged) 10jenkins-bot: Correctly scrape reference and source lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115590 (owner: 10Adrian Lang) [11:07:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115593 (owner: 10Addshore) [11:22:51] (03PS4) 10Thiemo Mättig (WMDE): Wikibase parsing of diff=... parameter was different from core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 [11:28:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 (owner: 10Thiemo Mättig (WMDE)) [11:33:51] Hi [11:34:03] I'd like to ask if something is in scope at Wikidata [11:36:25] https://commons.wikimedia.org/wiki/Category:Diagrams_of_warning_road_signs_of_the_United_Kingdom [11:36:53] It would be nice to convert the relevant portion of the legislation into suitable Wikidata records [11:37:01] So each diagram has a 'record' [11:37:37] Wouled such a project be in scope? [11:39:54] (03PS5) 10Thiemo Mättig (WMDE): Wikibase parsing of diff=... parameter was different from core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 [11:45:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 (owner: 10Thiemo Mättig (WMDE)) [11:56:12] (03CR) 10Addshore: [C: 04-1] "21 is apparently still formatted as 0021" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:24:56] [13DataValuesJavascript] 15adrianlang created 06moreFlexibleISO (+1 new commit): 02http://git.io/tHkYww [12:24:56] 13DataValuesJavascript/06moreFlexibleISO 14e1f53f5 15Adrian Lang: Make ISO time parsing more flexible... [12:26:15] [13DataValuesJavascript] 15adrianlang opened pull request #27: Make ISO time parsing more flexible (06master...06moreFlexibleISO) 02http://git.io/VZtQMA [12:28:16] [13DataValuesJavascript] 15adrianlang 04force-pushed 06moreFlexibleISO from 14e1f53f5 to 14d287d02: 02http://git.io/d2vzDQ [12:28:16] 13DataValuesJavascript/06moreFlexibleISO 14d287d02 15Adrian Lang: Make ISO time parsing more flexible... [12:30:31] [13ValueView] 15adrianlang opened pull request #28: Make StringValue expert's _getRawValue return null for empty strings (06master...06returnNullOnEmptyValue) 02http://git.io/OnFSqA [12:32:31] [13ValueView] 15adrianlang created 06codeStyleGlobeCoord (+1 new commit): 02http://git.io/VzcGgQ [12:32:31] 13ValueView/06codeStyleGlobeCoord 141fb0ebc 15Adrian Lang: Update imports and type annotation in GlobeCoordValue [12:32:41] [13ValueView] 15adrianlang opened pull request #29: Update imports and type annotation in GlobeCoordValue (06master...06codeStyleGlobeCoord) 02http://git.io/4ymi7A [12:43:24] (03PS36) 10Adrian Lang: Implement TimeParsers + poke TimeFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:43:26] (03CR) 10jenkins-bot: [V: 04-1] Implement TimeParsers + poke TimeFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:44:22] (03CR) 10Addshore: [C: 04-1] "REBASE YAY! :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:45:17] (03PS37) 10Adrian Lang: Implement TimeParsers + poke TimeFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:49:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:53:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:55:29] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115589 [13:22:55] [13DataValuesJavascript] 15addshore closed pull request #27: Make ISO time parsing more flexible (06master...06moreFlexibleISO) 02http://git.io/VZtQMA [13:23:25] [13ValueView] 15addshore pushed 2 new commits to 06master: 02http://git.io/n-BteQ [13:23:25] 13ValueView/06master 141fb0ebc 15Adrian Lang: Update imports and type annotation in GlobeCoordValue [13:23:25] 13ValueView/06master 14a8f3632 15addshore: Merge pull request #29 from wmde/codeStyleGlobeCoord... [13:29:00] [13DataValuesJavascript] 15adrianlang created 06dontRegisterTimeParser (+1 new commit): 02http://git.io/XdyvqQ [13:29:00] 13DataValuesJavascript/06dontRegisterTimeParser 148e1db48 15Adrian Lang: Don't register the TimeParser... [13:32:05] [13DataValuesJavascript] 15adrianlang opened pull request #28: Don't register the TimeParser (06master...06dontRegisterTimeParser) 02http://git.io/t8w8bg [13:55:03] addshore: hey... what's your take on the wbsetclaim stuff (see Markus' last mail)? I thought you fixed the "client must supply a GUID" stuff long ago? Can you clarify on the list? [13:59:39] (03PS6) 10Thiemo Mättig (WMDE): Wikibase parsing of diff=... parameter was different from core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 [14:04:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 (owner: 10Thiemo Mättig (WMDE)) [14:07:32] addshore: shouldn't we merge this? [14:07:34] https://gerrit.wikimedia.org/r/#/c/115593/ [14:08:09] (03CR) 10Tobias Gritschacher: [C: 032] Correctly scrape reference and source lists [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115593 (owner: 10Addshore) [14:08:30] (03Merged) 10jenkins-bot: Correctly scrape reference and source lists [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115593 (owner: 10Addshore) [14:22:04] (03PS7) 10Thiemo Mättig (WMDE): Wikibase parsing of diff=... parameter was different from core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 [14:24:48] Hello [14:24:51] Anyone awke? [14:26:07] yes [14:27:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 (owner: 10Thiemo Mättig (WMDE)) [14:31:05] GeradM: I was needing some jhelp [14:31:26] I want to set up a Wikidata project to help implement a catalouge of UK road signs [14:31:41] Would this be in scope? [14:32:06] In essence it would be a Transcription of the relevant Schedules of the 2002 (as ammended regulations into Wikidata [14:32:17] The schema is reasonably straightforward [14:32:59] Given that it's effectivly the table fields used in the original document... [14:34:31] DanielK_WMDE__: I honestly cant remember and would have to take another look at it [14:34:41] bit busy with other stuff today though :/ [14:36:03] [13ValueView] 15thiemowmde comment on pull request #28 14612eec6: Maybe it's me but I find this a bit confusing. With that addition it is not returning the "raw value" any more. It will be impossible to distinguish between the empty string and null. (Oracle does that and I always hated it.) Didn't we dropped exactly that from other places? 02http://git.io/NwFgYA [14:36:56] https://www.wikidata.org/wiki/Q15830829 it would need some additional field types created [14:37:08] If it's note in scope the item can be speedied [14:41:07] Where do I sugggest what fields I'd need? [14:41:52] Qcoder00: why are there underscores in the label? And what do you mean by "field types"? [14:42:00] I mean... [14:42:20] I wasn't finding property types for things like date introuduced and so on [14:42:26] You'd probably want to at least supply a value for "instance of". [14:42:30] I did [14:42:43] i see no statements at all on that item [14:42:44] instance of : roadsign isn't yet available [14:42:47] It wouldn't save [14:43:11] make an item for roadsign ;p [14:43:14] well, find the item that represents road signs. Maybe it's not caleld "roadsign"? [14:43:23] [13ValueView] 15thiemowmde comment on pull request #27 143e11efd: I don't think we should model anything after the jQuery toggle(), sorry. As said I would love setEnabled( bool ).... 02http://git.io/YxoTtA [14:44:00] we have items for "road signs in germany" and "road signs in Japan". [14:44:04] no generic road signs. [14:44:06] odd [14:44:25] [13ValueView] 15adrianlang created 06ValueFormatterForTime (+1 new commit): 02http://git.io/zeVlfQ [14:44:25] 13ValueView/06ValueFormatterForTime 1450e5de1 15Adrian Lang: Use ValueView's formatting and parsing in TimeValue [14:44:25] it's called traffic sign [14:44:41] indeed [14:45:09] https://www.wikidata.org/wiki/Q7832521 [14:45:17] Traffic sign deisgn was more appropriate [14:45:18] Qcoder00: use "traffic sign". Perhaps add "road sign" as an alias to "traffic sign". If it actually is an alias. I'm not anative speaker, but a road sign isn't the same asa traffic sign in my mind... [14:45:31] (road signs show you the way, traffic signs tell you hot to drive...) [14:45:44] DanielK_WMDE__: I just did that ;p [14:45:46] Technicaly itt's a diagram of a Traffic Sign [14:46:07] Qcoder00: https://www.wikidata.org/wiki/Wikidata:Roads_task_force might be of interest [14:46:10] Qcoder00: semantics, semantics... what's the actual sign, the symbol or the object? [14:46:14] fun with ontologies :) [14:46:20] [13ValueView] 15adrianlang comment on pull request #27 143e11efd: Since this is a jQuery UI widget, I think we should. `disable` and `enable` are declared in jQuery.ui.Widget, so we should not change their interfaces. 02http://git.io/VFaN6w [14:46:30] It's TSGRD Diagram 500. the basic Warning triangle [14:46:32] isn't it a good thing the software isn't trying to enforce any of that? that would be horrible... [14:46:36] and there are street signs ;) [14:46:39] LM find the 2002 legislations [14:46:43] Tobi_WMDE: indeed :) [14:47:07] Qcoder00: you should point to the actual diagram on commons [14:47:10] http://www.legislation.gov.uk/uksi/2002/3113/schedule/1/made [14:47:21] I am pointing to the actual legislation [14:47:27] and give the legislation as a source somehow... [14:47:30] And yes is there a way to put a Commons field/ [14:47:33] ? [14:47:48] do we have properties for "defined by" or some such? [14:48:08] Qcoder00: sure. There's a generic "image" property I think, but perhaps you can find a more appropriate one [14:48:31] It asks at the bottom if there is a linked Commons page [14:48:36] I've linked the SVG file [14:48:43] [13ValueView] 15adrianlang opened pull request #30: Use ValueView's formatting and parsing in TimeValue (06master...06ValueFormatterForTime) 02http://git.io/dpX_uA [14:48:53] Qcoder00: no, that's not good. the commons page should be a gallery or category. [14:48:59] the image should be linked using a statement [14:49:36] [13ValueView] 15adrianlang comment on pull request #28 14612eec6: We dropped it here, and it was wrong (see failing QUnit tests). Don't get confused over the method name, it's just wrong. This will all get simpler soon, hopefully :) 02http://git.io/JALhag [14:49:43] hm, we should somehow exclude the Image namespace from the sitelinks for commons :/ [14:50:02] DanielK_WMDE__: UK road signs have 2 drawings [14:50:03] addshore, aude: do you know if there's a script or bot that checks for image pages being linked via commons sitelinks? [14:50:09] One is the diagram on Commons [14:50:23] The other is the Workign Drawing , for which i can find a URL [14:51:09] no idea [14:51:14] Qcoder00: i think there's a generic "url" or "website" property. [14:51:24] OK [14:51:28] but maybe the working drawing should also be on commons, and be linekd via a second "image" statement? [14:51:36] i'll leave that to you :) [14:51:44] Maybe at the moment I prefer to link them to the offical PDF [14:52:02] Qcoder00: in any case, try to build up one or two items as an example, then ask for feedback (on the mailing list and/or the project chat) [14:52:27] Qcoder00: the official PDF should be the source reference. [14:53:30] click "add source" on the image statement, add a website or url property pointing to the official PDF or Law. [14:53:38] https://www.wikidata.org/wiki/Q15830829 [14:54:14] oh, and please no underscores in labels. labels are not page titles. [14:54:27] https://www.wikidata.org/wiki/Q15830829 [14:55:10] no bad :) [14:57:07] [13ValueView] 15tobijat closed pull request #23: Arrow images are backwards in source header (06master...06toggler-rtl) 02http://git.io/FnOXYg [14:59:05] Image should be - Diagram [14:59:20] ReferenceURL should be "Reference Drawing" [14:59:21] but [14:59:24] OK so far [15:12:01] [13ValueView] 15thiemowmde comment on pull request #28 14612eec6: Well then, click merge? 02http://git.io/OfAmNw [15:16:46] https://www.wikidata.org/wiki/Q15830845 [15:17:11] Now how do I make that entry look like the one here ? http://www.legislation.gov.uk/uksi/2002/3113/schedule/1/made [15:22:48] Qcoder00: you don't. there's no control over what a data item looks like. it's just a collection of properties. [15:23:09] on a client wiki, Lua can be used to access the information and use them in a template to make them pretty. [15:23:34] So how do I convert the properties in the legislations table into WikIData properties? [15:24:05] you find out if approprieate properties exist, and if they don't, you propose them [15:24:32] I've posted a note on the Project chat... [15:24:58] Qcoder00: if you have a good idea of what you need, put a proposal here: https://www.wikidata.org/wiki/Wikidata:Property_proposal [15:25:38] compare e.g. the stuff on https://www.wikidata.org/wiki/Wikidata:Property_proposal/Transportation [15:25:38] I'd need to have a chat about this first... [15:25:48] This is rather specfic [15:25:49] sure, see what the project chat turns up [15:25:58] as the list [15:26:06] poke people here :) [15:28:11] TO be honest I also need Wikidata to have a disscussion about short titles [15:28:16] for legislative documents [15:28:28] Currently I'm using a very complex template at Wikisource for these [15:30:56] Qcoder00: relevant legislative documents should have their own data items and should be referenced as such [15:31:04] Indeed [15:31:12] but when you got over 5000 of them [15:31:23] that way, they will have translatable labels and descriptions, and can also have aproperty given the full/abbreviated/whatever official name [15:31:48] https://en.wikisource.org/wiki/Short_Titles_Act_1896/First_Schedule/Pre_Union [15:31:51] Exists [15:31:53] well... i guess it all depends on whether there is a good "structural" reason to have these 5000 as items on wikidata [15:32:11] There is because they get crossreferenced... [15:32:20] Both in Wikisource and Wikipedia [15:32:23] if a document is useful as a source of several statements on several items, i'd say that is reason enough [15:32:57] If it's something big like say "The Scotland Act 1997" then the legislative Document should have a wikidata item... [15:32:57] if they are used just once or twice, referencing them by URL or even title might be enough [15:33:10] definitly [15:33:21] but "smaller" ones are fine too, if they are used. [15:33:24] Examining HOW that table is constructed might give some hints... [15:33:34] as to property types... [15:33:35] wikidata's granularity is finer than wikipedia's. though there are limits. [15:34:01] Qcoder00: what do you mean by "types"? [15:34:06] field types [15:34:27] Things like "Regnal Year" - which is different from a calander year etc... [15:34:52] I appreciate Wikidata isn't quite a full ontology system yet, but... [15:35:25] honestly, it's unlikely that we will support that. [15:35:45] support for different calendar systems is quite painful, and we are trying to keep it to the basics. [15:35:49] True [15:36:09] But a regnal year is typicall text of the form 4 & 5 Vict etc... [15:36:26] but is probably best as plain text given they get very complex [15:36:55] Qcoder00: the "string" type is used for identifiers of all kinds. I guess it could be used that way. [15:37:22] though it's a bit ugly. You can't use it with a properties that is otherwise used with "real" dates [15:37:31] so, maybe it's best to convert. [15:37:48] DanielK_WMDE__: The other reason for wanting to use wikidate for short-titles is that the current template for doing it... [15:38:19] https://en.wikisource.org/wiki/Template:Short-title is rather long [15:38:46] Converting it so that it's ONE reference number and a display title would be rather useful) [15:40:22] Given that the complication in the current template arises because of the need to contruct the links carefully... [15:40:45] If Wikidata has a 'definitve' link, I can simply the template considerably... [16:04:06] I don't like POKE ing [16:04:14] though [16:04:25] (in referencing to something earlier) [16:04:35] Getting appropriate handles and pointers is better.) [16:09:51] (03PS21) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [16:10:32] aude: mh... we ahve to either keep b/c this time or know about breaking things before deployment [16:10:39] parser cache related, I mean [16:10:42] yep [16:13:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [16:20:45] (03PS22) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [16:21:55] (03CR) 10Aude: [C: 04-1] "perhaps add a feature switch setting for this, so we can enable this and bump cache epoch at same time" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [16:26:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [16:26:50] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115589 [16:53:08] (03PS23) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [16:54:30] (03CR) 10Aude: [C: 04-1] "should have feature switch, so we can bump cache epoch and enable this at same time" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [16:55:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [16:55:59] [13WikidataBuilder] 15addshore pushed 1 new commit to 06master: 02http://git.io/ei9gBQ [16:55:59] 13WikidataBuilder/06master 1438c4895 15addshore: Moving section to puppet-builder [16:56:19] (03PS24) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [16:56:31] [13puppet-builder] 15addshore pushed 1 new commit to 06master: 02http://git.io/OKsJiw [16:56:31] 13puppet-builder/06master 143c55904 15addshore: Adding section from Wikidata build readme [16:57:28] addshore: not sure about that [16:57:44] for the branch, i use WikidataBuilder but not puppet currently [16:58:03] can puppet make our branch? [16:58:40] but then the part about "Automated build process" is odd in builder [17:01:04] I put the automated bit with puppet as thats the automated bit :P [17:02:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [17:03:14] (03CR) 10Aude: [C: 04-1] "should have feature switch, so we can bump cache epoch and enable this at same time" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [17:04:13] [13WikidataBuilder] 15addshore pushed 1 new commit to 06master: 02http://git.io/9lR6Jw [17:04:13] 13WikidataBuilder/06master 1467eae90 15addshore: note about Updating this README [17:11:21] [13ValueView] 15thiemowmde comment on pull request #27 143e11efd: In jQuery the three show(), hide() and toggle() go together. Since this is not about showing and hiding (as you said) neither show nor hide nor toggle should be used in my opinion.... 02http://git.io/uh1M6A [17:18:51] [13ValueView] 15thiemowmde comment on pull request #27 143e11efd: In jQuery the three functions show(), hide() and toggle() go together. Since this is not about showing and hiding - as you said - neither show nor hide nor toggle should be used.... 02http://git.io/eMoeoA [18:31:41] aude: Have you been able to solve the gerrit access problem (from production) [18:31:42] ? [18:45:00] hoo|away: yes [18:47:46] (03PS1) 10Aude: Update Wikibase, fix display of references [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115658 [18:55:49] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115658 (owner: 10Aude) [18:57:07] aude: how? [18:58:20] had to add "ForwardAgent yes" to my ssh config [18:58:34] that's super ugly [18:58:35] for tin [18:58:46] (03Merged) 10jenkins-bot: Update Wikibase, fix display of references [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115658 (owner: 10Aude) [18:59:00] if there's a better way, didn't figure that out [19:02:27] (03CR) 10Thiemo Mättig (WMDE): Implement TimeParsers + poke TimeFormatters (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [19:03:04] (03CR) 10Addshore: [C: 04-1] Implement TimeParsers + poke TimeFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [19:03:37] I'm currently thinking about it, but I couldn't come up with anything sane [19:03:54] it then uses my gerrit key, which is different than the one for tin [19:04:00] with proxycommand [19:04:27] * aude can ask andrew when he's not busy, but he is busy these days [19:07:43] Yeah... there are some security issues that come with forwarding the local ssh agent, that's why I'd rather not do it [19:07:55] best would be a read only gerrit account for such purposes [19:11:06] hoo: perhaps [19:14:26] I feel like we should nuke all api modules except wbeditentity ;p [19:14:29] xD [19:14:41] addshore: :D Could also use cors edit api [19:14:46] * core's [19:14:48] :/ [19:14:50] eww xD [19:15:05] would be quite nice actually if you could get the json correctly through it [19:15:08] addshore: content validation happens anyway :D What could possibly go wrong? [19:15:27] We tested it once and it worked, but nobody dared to enable [19:15:34] there's no use case either [19:17:43] (03PS1) 10Addshore: Enhance example in EditEntity api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115663 [19:17:46] hoo: aude ^^ easy one for you [19:18:05] needs tests :D [19:19:06] (03CR) 10Hoo man: [C: 032] Enhance example in EditEntity api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115663 (owner: 10Addshore) [19:19:23] that thing is scarily long... [19:19:23] (03Merged) 10jenkins-bot: Enhance example in EditEntity api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115663 (owner: 10Addshore) [19:19:24] :P [19:19:30] thats module? :P [19:19:35] *that [19:20:05] maybe we should at least deprecate wbsetclaim [19:20:36] too slow [19:20:47] why? you dont have to pass it the whole json [19:20:54] you can pass it exactly what you give wbsetclaim [19:21:12] just with a few extra {{ and }} :P [19:21:19] core's api edit works for wikibase! :) (if i comment out one line of wikibase) [19:21:27] just not pretty [19:22:48] addshore: you think it would be smarter to have richer clients (with an own DataModel + Serialization) rather than rich APIs? [19:23:13] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115663 (owner: 10Addshore) [19:23:20] how do you mean? [19:24:15] addshore: Have the clients just get the full json all times, do the changes and send that back, so tath we don't need a bazillion API modules [19:24:38] hoo: exactly [19:24:55] thats what I do in my new 'client' code :P [19:25:52] that's a little troublesome in JS though... and the client needs a lot of Wikibase knowledge (eg. my current bot is just a very smallish thing that just uses the setlinks API) [19:26:58] but you can set a sitelink through wbeditentity by only entering something like {"sitelinks":{"enwiki":{"site":"enwiki","title":"User:addshore"}}} [19:27:15] which isnt exactly hard even if you just json encode an array :P [19:34:40] (03Draft1) 10Addshore: General cleanup of API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115665 [19:38:49] (03PS1) 10Addshore: Tidy up out .travis.yml file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115668 [19:40:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115665 (owner: 10Addshore) [19:44:23] (03PS1) 10Addshore: Cleanup file comment blocks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115670 [19:44:57] wonder if I can go and find another file to split up in core ;p [19:45:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115668 (owner: 10Addshore) [19:50:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115670 (owner: 10Addshore) [20:12:36] When I'm searching the "normal" namespaces, how can I avoid getting all those foo/$lang results? I really do just want the original english versions. [20:15:48] I don't really benefit from N incomplete translations of the very same page tagging along just because the text that matched my query didn't actually get translated into that language yet [20:19:39] oh [20:19:56] looks like incategory:Wikidata-en should do what I want ... [20:22:42] (03PS1) 10Thiemo Mättig (WMDE): User-definable animation duration instead of constant time [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115680 [20:23:31] oh, except that's not the transitive closure ... [20:28:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115680 (owner: 10Thiemo Mättig (WMDE)) [20:32:12] [13ValueView] 15thiemowmde created 06animation_duration (+1 new commit): 02http://git.io/MCN8Cg [20:32:12] 13ValueView/06animation_duration 147b93924 15Thiemo Mättig: Remove one animation, make other durations user-definable... [20:58:05] [13ValueView] 15thiemowmde opened pull request #31: Remove one animation, make other durations user-definable (06master...06animation_duration) 02http://git.io/IZGTsw