[04:06:07] (03CR) 10Springle: [C: 04-1] "This one still seems dangerous to me :-) I understand the reason for the change, however please do also consider:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 (owner: 10Daniel Kinzler) [07:59:10] morning any admin who can modify https://www.wikidata.org/wiki/User_talk:Magnus_Manske#User:Magnus_Manske.2Fmissing_props.js.2Fhelp [08:30:14] (03CR) 10Adrian Lang: Correctly format commons links with spaces (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114746 (owner: 10Adrian Lang) [09:22:38] [13ValueView] 15adrianlang created 06inputAutoExpandResource (+3 new commits): 02http://git.io/uPBdQw [09:22:38] 13ValueView/06inputAutoExpandResource 141435cf1 15snaterlicious: Fixed letter case in experts' css definitions [09:22:38] 13ValueView/06inputAutoExpandResource 14a48aca8 15snaterlicious: Bump version 0.3 [09:22:38] 13ValueView/06inputAutoExpandResource 14fc28bc8 15Adrian Lang: Fix inputAutoExpand test resource definition [09:25:44] [13ValueView] 15adrianlang 04force-pushed 06inputAutoExpandResource from 14fc28bc8 to 14bbf846a: 02http://git.io/nu9m7A [09:25:44] 13ValueView/06inputAutoExpandResource 14bbf846a 15Adrian Lang: Fix inputAutoExpand test resource definition [09:26:02] [13ValueView] 15adrianlang opened pull request #24: Fix inputAutoExpand test resource definition (06master...06inputAutoExpandResource) 02http://git.io/cq0BWw [09:30:04] [13ValueView] 15adrianlang closed pull request #24: Fix inputAutoExpand test resource definition (06master...06inputAutoExpandResource) 02http://git.io/cq0BWw [09:47:35] (03Abandoned) 10Tobias Gritschacher: Browsertests: generate testclaims using the api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100359 (owner: 10Tobias Gritschacher) [09:47:46] (03Abandoned) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [09:47:59] (03PS3) 10Tobias Gritschacher: Correctly construct edit-links to SpecialPages in EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114751 [09:52:08] [13ValueView] 15adrianlang created 06inputAutoExpandTest (+1 new commit): 02http://git.io/uMotpQ [09:52:08] 13ValueView/06inputAutoExpandTest 14564a4c8 15Adrian Lang: Fix inputAutoExpand tests... [09:52:34] [13ValueView] 15adrianlang opened pull request #25: Fix inputAutoExpand tests (06master...06inputAutoExpandTest) 02http://git.io/6nVqng [09:53:30] (03CR) 10Tobias Gritschacher: [C: 031] "@Thiemo: the double-encoding is now fixed with your PS2. Any further complaints?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114751 (owner: 10Tobias Gritschacher) [09:55:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114751 (owner: 10Tobias Gritschacher) [10:00:29] (03PS1) 10: New Wikidata Build - 24/02/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115130 [10:04:57] (03CR) 10Aude: [C: 032] Move JsonDumpGenerator from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113350 (owner: 10Addshore) [10:05:13] (03Merged) 10jenkins-bot: Move JsonDumpGenerator from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113350 (owner: 10Addshore) [10:06:15] :) [10:08:11] apiInDebug.* didn't we want to kill those? JeroenDeDauw? [10:08:51] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115130 [10:09:19] hoo: https://gerrit.wikimedia.org/r/#/c/112479/ [10:09:37] ah [10:11:39] (03Merged) 10jenkins-bot: New Wikidata Build - 24/02/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115130 [10:12:52] (03PS4) 10Hoo man: Remove clutter unused api debug/test settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 (owner: 10Addshore) [10:14:45] * aude wait for jenkins [10:15:08] (03CR) 10Hoo man: "Got rid of the bogus dependent change, also fixed the doc" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 (owner: 10Addshore) [10:15:09] :) [10:16:00] if that one is merged, I'll go and kill as many Settings:: class usages in repo as possible :) [10:16:08] yay [10:17:38] (03CR) 10Aude: [C: 04-1] "overall looks good but see comments" (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 (owner: 10Daniel Kinzler) [10:18:24] (03PS1) 10Tobias Gritschacher: Browsertests: minor fixes to tags and sitelinks.feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115131 [10:21:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 (owner: 10Addshore) [10:22:08] there we go :) [10:22:58] (03CR) 10Aude: [C: 032] Remove clutter unused api debug/test settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 (owner: 10Addshore) [10:23:10] yay :) [10:23:12] (03Merged) 10jenkins-bot: Remove clutter unused api debug/test settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 (owner: 10Addshore) [10:27:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115131 (owner: 10Tobias Gritschacher) [11:03:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Correctly construct edit-links to SpecialPages in EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114751 (owner: 10Tobias Gritschacher) [11:03:58] (03Merged) 10jenkins-bot: Correctly construct edit-links to SpecialPages in EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114751 (owner: 10Tobias Gritschacher) [11:06:16] (03CR) 10Thiemo Mättig (WMDE): Correctly format commons links with spaces (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114746 (owner: 10Adrian Lang) [11:08:36] "// HACK: If the site ID isn't known, add "wiki" to it; this allows the wikipedia" :( [11:10:02] (03CR) 10Addshore: Correctly format commons links with spaces (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114746 (owner: 10Adrian Lang) [11:11:55] (03CR) 10Addshore: [C: 04-1] Add maintenance script for serializing items with their properties (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114139 (owner: 10Adrian Lang) [11:14:21] (03CR) 10Addshore: [C: 04-1] Created a SiteLinkProvider to query sitelinks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114983 (owner: 10Bene) [11:14:47] Meiko|Away: any joy with setting it up? [11:15:16] (03PS30) 10Addshore: Implement TimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [11:15:46] (03PS7) 10Addshore: Check for conflicts in ChangeOpsMerge preSave [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 [11:18:10] (03CR) 10WikidataJenkins: "Browsertests for new build on beta were successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115130 [11:20:23] (03PS2) 10Tobias Gritschacher: Browsertests: minor fixes to tags and sitelinks.feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115131 [11:23:49] (03PS1) 10Hoo man: Don't use the super-evil Settings singleton in client/repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 [11:24:06] (03CR) 10jenkins-bot: [V: 04-1] Don't use the super-evil Settings singleton in client/repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 (owner: 10Hoo man) [11:24:45] [13Common] 15addshore pushed 1 new commit to 06master: 02http://git.io/HpvVFA [11:24:46] 13Common/06master 147264387 15addshore: Fix how we get the cwd for tests [11:25:01] that's embarrasing :P [11:25:11] * embarrassing [11:25:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [11:25:52] [13Common] 15addshore created 06stringTrim (+1 new commit): 02http://git.io/4bRiIg [11:25:52] 13Common/06stringTrim 145f310a5 15addshore: Make StringFormatter trim value [11:26:30] (03PS2) 10Hoo man: Don't use the super-evil Settings singleton in client/repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 [11:28:22] gah [11:28:41] the way we suppress errors with @include_once is annoying [11:28:49] * aude trying to debug my wiki [11:28:58] @ is evil :P [11:29:15] Diff\Diff not found [11:30:56] somehow had wrong version of diff [11:32:49] what that means... i explicitly require WikibaseLib.php in my local settings without @ [11:34:10] we should remove the @s [11:34:15] yeah [11:34:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [11:34:54] not sure about include_once vs require_once [11:35:20] (03PS1) 10Hoo man: Don't use @include as that supresses useful error output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115138 [11:35:49] we get an excpetion if it's not there, though [11:36:13] mh... [11:36:34] include is ok [11:36:49] better an exception i suppose, than a fatal [11:36:57] both is fine IMO [11:37:00] but @ is not :P [11:37:04] exactly [11:37:21] anyway... I have to head of for now... cu later ;) Reviews appreciated... [11:37:38] i'll let jeroen look at that... not sure his reasoning for @ [11:38:13] (03CR) 10Aude: [C: 031] "not helpful to suppress errors coming from lib (and all the dependencies)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115138 (owner: 10Hoo man) [11:39:13] (03PS8) 10Addshore: Check for conflicts in ChangeOpsMerge preSave [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 [11:42:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115131 (owner: 10Tobias Gritschacher) [11:47:03] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 (owner: 10Hoo man) [11:48:49] (03PS1) 10Addshore: Cleanup wikibase-listdatatypes-* i18n keys [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 [11:54:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 (owner: 10Hoo man) [11:58:20] (03CR) 10Addshore: [C: 031] Refactor caching for EntityRevisionLookup service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 (owner: 10Daniel Kinzler) [11:59:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115138 (owner: 10Hoo man) [12:00:04] is it just me or is there an issue with saving quantities in the UI? [12:00:19] * aude try on test.wikidata [12:00:42] works on test [12:02:45] (03CR) 10Addshore: [C: 04-1] (bug 61264) Introducing WikiPageEntityStore (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102496 (owner: 10Daniel Kinzler) [12:05:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [12:10:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 (owner: 10Addshore) [12:19:53] (03PS1) 10Adrian Lang: Remove the toolbar controller's own event system [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 [12:27:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [12:49:35] (03PS3) 10Adrian Lang: Correctly format commons links with spaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114746 [12:57:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114746 (owner: 10Adrian Lang) [13:22:55] [13ValueView] 15adrianlang created 06fixInputExtenderForTime (+1 new commit): 02http://git.io/jwuoig [13:22:55] 13ValueView/06fixInputExtenderForTime 143540d74 15Adrian Lang: Fix inputextender for time values [13:23:45] [13ValueView] 15adrianlang 04force-pushed 06fixInputExtenderForTime from 143540d74 to 14e724870: 02http://git.io/SBedkA [13:23:45] 13ValueView/06fixInputExtenderForTime 14e724870 15Adrian Lang: Fix inputextender for time values [13:24:43] [13ValueView] 15adrianlang opened pull request #26: Fix inputextender for time values (06master...06fixInputExtenderForTime) 02http://git.io/EZo5EQ [13:31:54] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Correctly format commons links with spaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114746 (owner: 10Adrian Lang) [13:38:46] [13ValueView] 15adrianlang 04deleted 06previewwidget at 148b642ae: 02http://git.io/fZ91Qw [13:47:17] [13ValueView] 15addshore created 060.3.2-branch (+3 new commits): 02http://git.io/C5rFiA [13:47:17] 13ValueView/060.3.2-branch 14dd68d8e 15addshore: Revert "Removed passing globeCoordinate.GlobeCoordinate"... [13:47:17] 13ValueView/060.3.2-branch 1429b887e 15addshore: Revert "Use ViewState::getFormattedValue for Url formatting"... [13:47:17] 13ValueView/060.3.2-branch 14b63e640 15addshore: Revert "Use ViewState::getFormattedValue for GlobeCoordinate formatting"... [13:51:59] <23LAAASWU> [13ValueView] 15addshore 04force-pushed 060.3.2-branch from 14b63e640 to 14dac2609: 02http://git.io/VHx2qg [13:51:59] <23LAAASWU> 13ValueView/060.3.2-branch 14dac2609 15addshore: Revert "Use ViewState::getFormattedValue for GlobeCoordinate formatting"... [13:54:21] [13ValueView] 15addshore pushed 1 new commit to 060.3.2-branch: 02http://git.io/fRZ90Q [13:54:21] 13ValueView/060.3.2-branch 144382a60 15addshore: Update ChangeLog and version [13:55:36] [13ValueView] 15addshore pushed 1 new commit to 06master: 02http://git.io/ynhHzg [13:55:36] 13ValueView/06master 14c220cf1 15addshore: Update ChangeLog [13:56:41] [13ValueView] 15addshore tagged 060.3.2 at 060.3.2-branch: 02http://git.io/IZBJ6Q [14:00:15] [13ValueView] 15addshore pushed 1 new commit to 06master: 02http://git.io/VQjf4g [14:00:15] 13ValueView/06master 14b7622b2 15addshore: Further update ChangeLog [14:03:05] (03PS1) 10Addshore: Require at least 0.3.2 of ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 [14:05:14] (03PS2) 10Addshore: Do not use 0.3.1 of ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 [14:06:45] [13ValueView] 15adrianlang created 06ValueViewToggle (+1 new commit): 02http://git.io/fcJgqg [14:06:45] 13ValueView/06ValueViewToggle 143e11efd 15Adrian Lang: Don't redraw ValueView in {en,dis}able if nothing changed [14:07:34] [13ValueView] 15adrianlang opened pull request #27: Don't redraw ValueView in {en,dis}able if nothing changed (06master...06ValueViewToggle) 02http://git.io/p0FGuQ [14:07:45] addshore: https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase/refs%2Fheads%2Fmw1.23-wmf15 [14:11:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 (owner: 10Addshore) [14:11:48] (03PS1) 10Aude: move $wgValueParsers to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115161 [14:15:33] (03PS2) 10Aude: move $wgValueParsers to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115161 [14:20:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 (owner: 10Addshore) [14:25:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115161 (owner: 10Aude) [14:26:24] (03PS1) 10Aude: don't use backend coordinate formatter yet [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115165 [14:28:44] (03PS2) 10Aude: don't use backend coordinate formatter yet [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115165 [14:31:31] (03CR) 10Addshore: [C: 032] don't use backend coordinate formatter yet [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115165 (owner: 10Aude) [14:31:52] (03Merged) 10jenkins-bot: don't use backend coordinate formatter yet [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115165 (owner: 10Aude) [14:34:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115161 (owner: 10Aude) [14:37:45] [13ValueView] 15addshore closed pull request #26: Fix inputextender for time values (06master...06fixInputExtenderForTime) 02http://git.io/EZo5EQ [14:37:55] [13ValueView] 15addshore 04deleted 06fixInputExtenderForTime at 14e724870: 02http://git.io/JfX70Q [14:39:33] addshore: (reply to your message 3 hours ago), haven't started yet [14:40:16] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115165 (owner: 10Aude) [14:41:30] [13ValueView] 15addshore created 060.3.3-branch (+3 new commits): 02http://git.io/qHPjAg [14:41:30] 13ValueView/060.3.3-branch 1404ff4ff 15Adrian Lang: Fix inputAutoExpand tests... [14:41:30] 13ValueView/060.3.3-branch 147e2c83b 15Adrian Lang: Fix inputextender for time values [14:41:30] 13ValueView/060.3.3-branch 141382e00 15addshore: Update Release Notes and version [14:42:30] [13ValueView] 15addshore pushed 1 new commit to 06master: 02http://git.io/LgXFMA [14:42:30] 13ValueView/06master 14c43bad6 15addshore: Add 0.3.3 Release to Release notes [14:43:19] [13ValueView] 15addshore tagged 060.3.3 at 06master: 02http://git.io/1q1Q_A [14:44:06] [13ValueView] 15addshore 04deleted 060.3.2-branch at 144382a60: 02http://git.io/2WOiSg [14:44:27] (03CR) 10Aude: [C: 031] "works fine, as far as i can tell" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [14:45:54] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115165 (owner: 10Aude) [15:08:37] [13ValueView] 15addshore created 060.3.3-branch (+2 new commits): 02http://git.io/8ZEUKg [15:08:37] 13ValueView/060.3.3-branch 142178271 15addshore: Revert "Removed passing globeCoordinate.GlobeCoordinate"... [15:08:37] 13ValueView/060.3.3-branch 14d660d99 15addshore: Revert "Use ViewState::getFormattedValue for GlobeCoordinate formatting"... [15:10:27] [13ValueView] 15addshore 04deleted 060.3.3 at 14c43bad6: 02http://git.io/-gSegw [15:10:49] [13ValueView] 15addshore tagged 060.3.3 at 060.3.3-branch: 02http://git.io/1q1Q_A [15:11:22] (03PS1) 10Aude: Revert "don't use backend coordinate formatter yet" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115171 [15:11:29] [13ValueView] 15addshore 04deleted 060.3.3-branch at 14d660d99: 02http://git.io/XQXGtw [15:13:22] [13ValueView] 15thiemowmde comment on pull request #27 143e11efd: I find disabled=true odd. Inverted logic. Should be enabled=false in my opinion. But since this is not changed in this commit it should not block it, obviously. ;-) 02http://git.io/0egYpQ [15:13:54] (03PS3) 10Addshore: Do not use 0.3.1 of ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 [15:14:35] (03PS4) 10Addshore: Require 0.3.3 ValueView or higher [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 [15:18:52] [13ValueView] 15thiemowmde comment on pull request #27 143e11efd: Unfortunately it's not obvious what _toggle( value ) really does. Like "toggle but don't toggle"? I suggest setEnabled( enabled ). I got used to this in Java. I'm not sure if this is wanted here so feel free to ignore this suggestion. 02http://git.io/uDA74g [15:20:17] (03CR) 10Addshore: [C: 032] Revert "don't use backend coordinate formatter yet" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115171 (owner: 10Aude) [15:20:35] (03CR) 10Aude: [C: 032] "works for me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 (owner: 10Addshore) [15:20:38] (03Merged) 10jenkins-bot: Revert "don't use backend coordinate formatter yet" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115171 (owner: 10Aude) [15:20:51] (03Merged) 10jenkins-bot: Require 0.3.3 ValueView or higher [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 (owner: 10Addshore) [15:20:57] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115171 (owner: 10Aude) [15:22:28] (03PS1) 10Addshore: Correctly format commons links with spaces [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115172 [15:22:43] (03PS1) 10Addshore: Require 0.3.3 ValueView or higher [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115173 [15:27:09] (03CR) 10Aude: [C: 032] Don't use the super-evil Settings singleton in client/repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 (owner: 10Hoo man) [15:27:11] (03CR) 10Addshore: [C: 032] Don't use the super-evil Settings singleton in client/repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 (owner: 10Hoo man) [15:27:27] (03Merged) 10jenkins-bot: Don't use the super-evil Settings singleton in client/repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115137 (owner: 10Hoo man) [15:27:30] +4! [15:27:30] hoo, enjoy the +4 ;p [15:27:31] Double approve oO [15:27:35] \o/ [15:28:08] (03CR) 10Addshore: [C: 031] Don't use @include as that supresses useful error output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115138 (owner: 10Hoo man) [15:28:43] waiting for jenkins [15:29:11] (03CR) 10Addshore: [C: 032] move $wgValueParsers to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115161 (owner: 10Aude) [15:29:52] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 (owner: 10Addshore) [15:31:34] (03CR) 10Addshore: [V: 032] Retain compatibility with SQLite [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114490 (owner: 10Jeroen De Dauw) [15:31:47] (03CR) 10Addshore: "I have verified on sqlite [=" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114490 (owner: 10Jeroen De Dauw) [15:34:12] we must be flooding jenkins [15:35:41] Ours is rather slow... how big is the VM holding it? Upsizing might be a good idea [15:35:51] or adding a slave... jenkins does support these kind of things [15:36:17] hoo: biggest available [15:36:23] oO [15:36:24] we can add more "nodes" though [15:36:57] might be worth a shot... right now it takes more time to run the tests than the crappy VM on my 2 yr old Notebook :P [15:36:58] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115160 (owner: 10Addshore) [15:38:40] yup, we need more nodes ;p [15:38:40] 3 would be nice ;p [15:40:30] maybe when we setup in ashburn [15:41:01] "New version of Jenkins (1.532.2) is available for download" [15:42:19] (03PS2) 10Adrian Lang: Remove the toolbar controller's own event system [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 [15:42:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115172 (owner: 10Addshore) [15:42:46] (03CR) 10Aude: [C: 032] Correctly format commons links with spaces [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115172 (owner: 10Addshore) [15:43:01] (03Merged) 10jenkins-bot: Correctly format commons links with spaces [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115172 (owner: 10Addshore) [15:49:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115173 (owner: 10Addshore) [15:49:49] (03CR) 10Aude: [C: 032] Require 0.3.3 ValueView or higher [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115173 (owner: 10Addshore) [15:50:10] (03Merged) 10jenkins-bot: Require 0.3.3 ValueView or higher [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115173 (owner: 10Addshore) [15:55:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [15:57:32] (03PS3) 10Tobias Gritschacher: Remove the toolbar controller's own event system [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [15:58:02] (03PS4) 10Tobias Gritschacher: Remove the toolbar controller's own event system [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [16:06:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [16:11:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [16:12:56] gerrit slowness?! [16:22:46] Tobi_WMDE: you pinged? waaaasup? :D [16:42:56] (03PS1) 10Tobias Gritschacher: Browsertests: fix several broken tests in old-style browsertest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115190 [16:43:21] (03CR) 10Tobias Gritschacher: [C: 032] Remove the toolbar controller's own event system [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [16:43:44] (03Merged) 10jenkins-bot: Remove the toolbar controller's own event system [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115149 (owner: 10Adrian Lang) [16:44:02] aude: addshore: needs backport: https://gerrit.wikimedia.org/r/#/c/115149/ [16:44:22] :P [16:44:23] didn't we put it in [16:44:27] for ALL of the performance!! \o/ [16:44:28] <3 backports [16:44:40] nope [16:45:53] addshore: are you putting it in and making a build? [16:46:17] awww, i'll do it [16:46:28] (03PS1) 10Aude: Remove the toolbar controller's own event system [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115191 [16:46:49] shall wait for jenkins [16:48:49] (03CR) 10Addshore: [C: 032 V: 032] "Ved by tobi" [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115191 (owner: 10Aude) [16:51:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115190 (owner: 10Tobias Gritschacher) [16:56:06] (03PS1) 10Aude: Update Wikibase and ValueView [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115192 [16:56:12] no [16:56:24] need to amend it [16:56:44] (03CR) 10Aude: [C: 04-2] Update Wikibase and ValueView [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115192 (owner: 10Aude) [16:59:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115191 (owner: 10Aude) [17:00:37] (03CR) 10Thiemo Mättig (WMDE): "In my opinion the code is already good enough to merge it and fix possible issues in later patches. It's already much better then what we " (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [17:03:22] fyi https://github.com/wmde/WikidataBuilder/issues/16 [17:03:53] (03PS1) 10Aude: Update Wikibase and ValueView [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115194 [17:03:55] (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase and ValueView [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115194 (owner: 10Aude) [17:04:03] rage [17:04:35] ok, ok [17:04:55] (03Abandoned) 10Aude: Update Wikibase and ValueView [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115194 (owner: 10Aude) [17:06:22] (03PS1) 10Aude: Update Wikibase and ValueView [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115195 [17:06:22] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115192 (owner: 10Aude) [17:06:40] (03Abandoned) 10Aude: Update Wikibase and ValueView [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115192 (owner: 10Aude) [17:09:48] waiting for jenkins on https://gerrit.wikimedia.org/r/#/c/115195/ [17:14:43] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115194 (owner: 10Aude) [17:15:41] [= [17:20:33] addshore: https://github.com/wmde/WikibaseQuery/pull/2 :) [17:20:35] [13WikibaseQuery] 15filbertkm created 06whitespace (+1 new commit): 02http://git.io/h9vBcQ [17:20:35] 13WikibaseQuery/06whitespace 14e9f8f58 15aude: remove ugly whitespace [17:21:36] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115195 (owner: 10Aude) [17:24:18] (03Merged) 10jenkins-bot: Update Wikibase and ValueView [extensions/Wikidata] (mw1.23-wmf15) - 10https://gerrit.wikimedia.org/r/115195 (owner: 10Aude) [17:51:33] [13WikidataBuilder] 15filbertkm created 06updatecomposer (+1 new commit): 02http://git.io/ncuTcQ [17:51:33] 13WikidataBuilder/06updatecomposer 140c326f1 15aude: update composer.phar... [17:52:33] [13puppet-composer] 15filbertkm created 06updatecomposer (+1 new commit): 02http://git.io/DoYNTg [17:52:33] 13puppet-composer/06updatecomposer 141189860 15aude: update composer.phar... [18:06:59] (03PS2) 10Tobias Gritschacher: Cleanup wikibase-listdatatypes-* i18n keys [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 (owner: 10Addshore) [18:07:12] (03PS3) 10Addshore: Cleanup wikibase-listdatatypes-* i18n keys [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 [18:07:23] (03CR) 10Tobias Gritschacher: [C: 032] Cleanup wikibase-listdatatypes-* i18n keys [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 (owner: 10Addshore) [18:07:38] (03CR) 10Tobias Gritschacher: [C: 032] Browsertests: fix several broken tests in old-style browsertest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115190 (owner: 10Tobias Gritschacher) [18:08:08] (03Merged) 10jenkins-bot: Cleanup wikibase-listdatatypes-* i18n keys [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 (owner: 10Addshore) [18:08:16] (03Merged) 10jenkins-bot: Browsertests: fix several broken tests in old-style browsertest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115190 (owner: 10Tobias Gritschacher) [18:09:08] (03CR) 10Tobias Gritschacher: [C: 032] Don't use @include as that supresses useful error output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115138 (owner: 10Hoo man) [18:09:24] (03Merged) 10jenkins-bot: Don't use @include as that supresses useful error output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115138 (owner: 10Hoo man) [18:14:28] (03CR) 10Tobias Gritschacher: [C: 032] Browsertests: minor fixes to tags and sitelinks.feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115131 (owner: 10Tobias Gritschacher) [18:14:49] (03Merged) 10jenkins-bot: Browsertests: minor fixes to tags and sitelinks.feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115131 (owner: 10Tobias Gritschacher) [18:16:03] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 (owner: 10Addshore) [18:17:02] (03PS9) 10Henning Snater: Toolbar edit group widget optimization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 [18:23:04] (03CR) 10Tobias Gritschacher: [C: 04-1] "Needs rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [18:23:31] (03PS2) 10Tobias Gritschacher: Browsertests: make config variables environment variables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114492 [18:23:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115139 (owner: 10Addshore) [18:31:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [18:36:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114492 (owner: 10Tobias Gritschacher) [18:44:51] (03CR) 10Tobias Gritschacher: [C: 032] Toolbar edit group widget optimization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [18:45:12] (03Merged) 10jenkins-bot: Toolbar edit group widget optimization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [18:53:12] (03PS1) 10: New Wikidata Build - 24/02/2014 18:52 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115212 [19:01:40] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115212 [19:04:23] (03Merged) 10jenkins-bot: New Wikidata Build - 24/02/2014 18:52 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115212 [19:22:57] hoo|away: apiInDebug is rather evil as far as I recall - if we can get rid of such global state messing with the tests, that'd be nice [19:24:32] JeroenDeDauw: I'm ahead of you... I've amended addshore's patch earlier on and then aude merged it... so it's gone now [19:24:49] xd [19:24:49] and we only have on usage of Settings in both client and repo now! \o/ [19:24:59] * one [19:25:16] hoo deserves a pancake! [19:26:06] :) [19:32:09] hoo|away: that's fantastic :) I look foreward to being able to kill the Settings thing altogether [19:32:59] totally :) [19:36:51] [13puppet-composer] 15filbertkm opened pull request #2: update composer.phar (06master...06updatecomposer) 02http://git.io/owZVww [19:37:16] [13WikidataBuilder] 15filbertkm opened pull request #17: update composer.phar (06master...06updatecomposer) 02http://git.io/N3z-vQ [19:38:20] hmm [19:38:39] is it my internet again or don't those load for you either? [19:39:02] the pull requests? [19:39:04] --- github.com ping statistics --- [19:39:04] 7 packets transmitted, 0 received, 100% packet loss, time 6000ms [19:39:07] yeah :/ [19:39:09] * aude sure i submitted them before i left the office [19:39:11] [13puppet-composer] 15addshore closed pull request #2: update composer.phar (06master...06updatecomposer) 02http://git.io/owZVww [19:39:27] but they never appeared, and the text of them was there when i want to make a new pull request [19:39:34] never hit submit? [19:39:35] aude: see https://gerrit.wikimedia.org/r/#/c/110427/3 , indeed I am asking myself now, how does that solve the bug? :P [19:41:04] addshore: maybe that can be an additional prop that wikibase provides to the module? [19:41:15] list of sites itself should be in core, imho [19:41:47] a nasty hook? :< [19:42:54] so... is it only me or is github donw? :P [19:43:01] just you ;p [19:43:05] not down [19:43:15] ok, now it works for me either... weird [19:43:20] but odd that my requests didn't get submitted before [19:43:37] can't possibly fail to hit submit twice! [19:44:29] [13WikidataBuilder] 15JeroenDeDauw closed pull request #17: update composer.phar (06master...06updatecomposer) 02http://git.io/N3z-vQ [19:44:31] addshore: successfull trolling of aude? ;p [19:44:56] [13WikidataBuilder] 15JeroenDeDauw 04deleted 06updatecomposer at 140c326f1: 02http://git.io/XNy33w [19:45:15] i had quick submit hax turned on :> [19:45:42] addshore steal my stuff [19:46:58] https://github.com/wmde/WikidataBuilder/pull/17#issuecomment-35927020 [19:47:06] GitHub officially beats gerrit for allowing this :D [19:47:37] hah [19:47:50] :P [19:48:05] does it allow (animated) gifs? [19:48:16] that would be terrible and awesome at the same time... [19:49:36] [13ValueView] 15JeroenDeDauw comment on pull request #27 143e11efd: If this changes the enabled state, then having "enabled" in the name would definitely be good. setEnabled( bool ) works, and so does toggleEnabled(). However toggleEnabled( bool ) is odd. 02http://git.io/_ElzzQ [19:50:32] (03PS4) 10Addshore: Refactor confusing getting of IDs from Term objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 [19:50:52] hoo|away: https://github.com/wmde/WikidataBuilder/pull/17 [19:50:59] oh, I'm going to have so much fun now :D [19:51:28] oO [19:54:43] hmm, where in core do I pput exception classes xD [19:54:58] addshore: /dev/null :P [19:55:09] That doesn't really sound like a sane idea :P [19:55:28] xD [19:55:50] there's an Exception.php file in includes AFAIR [19:56:03] it's one of these messy core files with a bazillion classes in it [19:56:14] :< [19:56:24] thats just where they all go? :< [19:56:41] I dare not touch it, I might catch an Exception! [19:56:48] unless someone (you?) created or create a includes/exceptions... yes [19:56:56] xD [19:57:02] I have a habbit of doing that ;p [19:57:18] and I have a habit of merging these changes very fast [19:57:54] I merged the change which introduced specialpage within 15 min. after it was uploaded :D [19:58:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [19:58:28] give me a moment ;p [19:58:30] hoo|away: "the change which introduced specialpage"? Thta class is ancient? [19:58:44] JeroenDeDauw: /specialpage/* ;p [19:58:53] ahh [19:59:07] ;) [19:59:13] hoo|away: whats the @defgroup tag do? :> [19:59:34] it defines a group [19:59:46] you need this if you use @ingroup ;p] [19:59:49] Yeah... but that's all a big messy mess [19:59:52] If you want those to have a desc [20:00:00] xD [20:00:06] Which is why in WB we don't use @ingroup anymoar [20:00:15] I don't think that's used in a consistent way within core (or even Wikbiase) [20:00:34] we are now consistently not using it [20:00:40] +1 [20:01:04] No point in doing so if you have a sane dir and NS structure [20:01:09] Core has neither though [20:01:20] Same for Wikibase.git unfortunately, though in smaller degree [20:04:45] hoo|away: does it matter where @defgroup goes? [20:04:52] in the file block? in the class block? [20:05:00] don't think so [20:05:15] just put it in a sane place (top of the file or so) [20:06:52] ok, really away again :P [20:07:15] noo hoo|away [20:07:16] wait 5 mins ;p [20:44:14] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/115212 [20:51:26] (03PS5) 10Thiemo Mättig (WMDE): Refactor confusing getting of IDs from Term objects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [20:59:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114466 (owner: 10Addshore) [21:12:49] addshore: no food? [21:19:23] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115294 (owner: 10L10n-bot) [22:09:49] (03PS1) 10Thiemo Mättig (WMDE): Wikibase parsing of diff=... parameter was different from core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 [22:17:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 (owner: 10Thiemo Mättig (WMDE)) [23:03:17] (03PS2) 10Thiemo Mättig (WMDE): Wikibase parsing of diff=... parameter was different from core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 [23:06:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/115310 (owner: 10Thiemo Mättig (WMDE))