[04:02:32] hi, anybody here who is not a bot ? [04:02:48] hi [04:03:45] hello [04:08:14] RIP. [05:30:14] hah, Gloria [05:30:23] * jeremyb is a bot [07:53:09] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/-mgBkg [07:53:09] 13scrumbugz/06master 1498111ce 15Christopher Johnson: Delete models.pyc [07:53:19] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/fDqECA [07:53:19] 13scrumbugz/06master 1478679e8 15Christopher Johnson: Delete utils.pyc [07:54:04] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/S657Mg [07:54:04] 13scrumbugz/06master 149a63b1a 15Christopher Johnson: Delete __init__.pyc [07:56:29] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/4nMicA [07:56:29] 13scrumbugz/06master 1425c47cc 15Christopher Johnson: Delete api.pyc [07:56:39] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/p7kj9w [07:56:39] 13scrumbugz/06master 146075faf 15Christopher Johnson: Delete models.pyc [07:57:53] [13scrumbugz] 15ChristopherHJohnson pushed 1 new commit to 06master: 02http://git.io/WtyoXw [07:57:53] 13scrumbugz/06master 14dbac53e 15Christopher Johnson: Delete 0001_initial.pyc [08:00:56] good morning [09:28:01] some advance notice ... https://tools.wmflabs.org/fist/wdfist/index.html [09:28:10] this is REALLY nice [09:28:27] it makes it ever so easy to add images for list items [09:28:45] NB it is a work in progress at the moment [10:00:25] (03PS1) 10: New Wikidata Build - 19/02/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/114138 [10:03:47] Thiemo_WMDE: is christopher already in the office? [10:07:52] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/114138 [10:09:37] Lydia_WMDE: no [10:10:05] aude: thanks - can you let me know when he is [10:10:20] ok [10:10:30] didn't think he was coming today [10:10:41] (03Merged) 10jenkins-bot: New Wikidata Build - 19/02/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/114138 [10:12:23] ah possible [10:23:27] (03PS1) 10Adrian Lang: Add maintenance script for serializing items with their properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114139 [10:30:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114139 (owner: 10Adrian Lang) [10:41:06] (03CR) 10WikidataJenkins: "Browsertests for new build on beta had failures" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/114138 [10:44:48] is beta broken or is our build? [10:45:08] aude: something strange with the selenium tests.. investigating [10:45:12] ok [10:45:34] there was nothing new in the build today [10:45:58] seems the connection to saucelabs did not work [10:46:03] hmmm [10:46:28] have to check if something was changed [10:46:32] ok [11:27:01] fixed the selenium tests [11:52:22] (03CR) 10WikidataJenkins: "Browsertests for new build on beta were successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/114138 [11:54:06] (03PS26) 10Addshore: Implement TimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [11:54:33] (03CR) 10Addshore: [C: 04-1] "Still todo:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:00:08] (03CR) 10Addshore: Implement TimeParsers (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:00:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:06:04] (03PS27) 10Addshore: Implement TimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [12:06:23] (03CR) 10Addshore: [C: 04-1] "Still TODO parsing BC stuff" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:12:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:24:37] (03PS28) 10Addshore: Implement TimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [12:25:58] (03PS29) 10Addshore: Implement TimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 [12:32:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:37:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore) [12:41:32] (03PS6) 10Addshore: Check for conflicts in ChangeOpsMerge preSave [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 [12:47:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [12:53:39] How do I say that a foundation is managed by a board [13:03:07] (03CR) 10Addshore: [C: 04-1] Add maintenance script for serializing items with their properties (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114139 (owner: 10Adrian Lang) [13:33:22] (03CR) 10Thiemo Mättig (WMDE): "Looks very good so far. Looking forward to see this merged. :-)" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene) [13:42:09] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/k_9C5Q [13:42:09] 13WikibaseDataModelSerialization/06master 14c4c289a 15Tpt: Adds ItemSerializer [13:42:09] 13WikibaseDataModelSerialization/06master 140e6c18d 15Jeroen De Dauw: Merge pull request #24 from Tpt/ItemSerializer... [14:06:04] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/t9tHeQ [14:06:04] 13WikibaseDatabase/06master 14c3e81d6 15Jeroen De Dauw: Merge pull request #12 from wmde/addshoreExpansion... [14:07:19] http://osm.lyrk.de/wappen/ [14:07:45] someone used wikidata to make a coat of arms map [14:08:07] http://blog.openstreetmap.de/blog/2014/02/wochennotiz-nr-187/ [14:23:44] addshore: generally try to not make a release together with a pile of actual code changes - this causes a number of problems [14:25:41] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_iLTKQ [14:25:41] 13WikibaseDatabase/06master 140f88c38 15jeroendedauw: Update version back to 0.2 [14:33:57] [travis-ci] wmde/WikibaseQueryEngine#8 (addshoreChanges - 8cda46d : jeroendedauw): The build failed. [14:33:57] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/c5512447d7db...8cda46da9702 [14:33:57] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19186192 [14:37:20] addshore: why did you comment out the thing at the bottom here? https://github.com/wmde/WikibaseQueryEngine/pull/1/files [14:37:45] [travis-ci] wmde/WikibaseQueryEngine#8 (addshoreChanges - 8cda46d : jeroendedauw): The build failed. [14:37:45] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/c5512447d7db...8cda46da9702 [14:37:45] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19186192 [14:38:30] must have been while I was debugging something [14:38:52] addshore: thing looks good, though it fails on sqlite [14:39:03] Also added some minor commits on top[ [14:39:55] "Early users will enjoy a special first-level support" haha [14:42:21] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Remove unused js config variables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113933 (owner: 10Aude) [14:42:34] [travis-ci] wmde/WikibaseQueryEngine#10 (addshoreChanges - c339942 : jeroendedauw): The build is still failing. [14:42:34] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/8cda46da9702...c33994286436 [14:42:34] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19186625 [14:42:39] addshore: any idea why it is failing? [14:43:43] https://github.com/wmde/WikibaseQueryEngine/compare/8cda46da9702...c33994286436 [14:43:49] you remove the value-identity colum? [14:44:14] thats what https://travis-ci.org/wmde/WikibaseQueryEngine/jobs/19186627 looks like it is complaining about [14:44:59] as for sqlite Error: 1 AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY looks like something else needs poking [14:45:51] like likes in sqlite autoincremement explicity has to be INTEGER not bigint which is what I think we are currently using [14:59:08] (03CR) 10Fomafix: Remove unused js config variables (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113933 (owner: 10Aude) [15:04:05] (03CR) 10Aude: Remove unused js config variables (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113933 (owner: 10Aude) [15:04:07] (03PS3) 10Aude: Remove unused js config variable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113933 [15:10:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/113933 (owner: 10Aude) [15:30:45] addshore: oh, guess I missed a ref to that field [15:31:34] addshore: ah, I was thinking of the right solution yesterday and then forgot about it [15:32:04] addshore: will fix now [15:35:16] addshore: I'm going to hold tyou responsible if the TimeParsers code is still in lib in half a year ;p https://gerrit.wikimedia.org/r/#/c/111464/ [16:08:30] addshore: just noticed there is a mismatch between the geo and globe value stuff [16:08:40] O_O really? [16:08:50] These are not the same values [16:08:54] $tables['globecoordinate'] = new GeoCoordinateHandler( [16:09:05] And that then also contains globe fields, though calls it geo [16:09:28] Looks like this code is currently broken as well, since it now references fields that do not exist [16:09:44] addshore: will also fix that [16:13:15] meh, we don't need the globe thing yet, so no point in pinning down the schema for it yet. [16:13:24] I'll leave this thing be as a latlong value [17:25:04] addshore: same thing with number and quantity [17:25:19] we had a number implementation, and you added stuff for quantity at one place [17:25:31] This does show it is not good to have the definition split up like it is [17:31:54] oh, and this "value_identity, property_id, entity_id" index clearly makes no sense on the valueless snaks table :) [17:39:07] (03PS1) 10Thiemo Mättig (WMDE): SearchEntities API call refactored for performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114165 [17:45:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114165 (owner: 10Thiemo Mättig (WMDE)) [17:53:12] (03CR) 10Addshore: [C: 04-1] SearchEntities API call refactored for performance (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114165 (owner: 10Thiemo Mättig (WMDE)) [17:53:47] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/GTtcmg [17:53:47] 13WikibaseDatabase/06master 143f693d7 15Jeroen De Dauw: Update MediaWikiTableBuilder.php [18:25:11] addshore: Error: 1 AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY [18:25:17] I did not cause that [18:25:24] I know I said that earlier :P [18:25:49] I now got rid of the value_identity field and properly impelementated that [18:25:54] this issue is still remaining though [18:26:00] Any idea what the reason is? [18:26:19] This is not valid sql for sqlite I guess? CREATE TABLE "integrationtest_valueless_snaks" ("row_id" BIGINT NOT NULL PRIMARY KEY AUTOINCREMENT, "entity_type" VARCHAR(8) NOT NULL, "entity_id" VARCHAR(16) NOT NULL, "property_id" VARCHAR(16) NOT NULL, "statement_rank" TINYINT NOT NULL, "snak_type" INTEGER NOT NULL); [18:26:33] suspect it works if its inst rather than bigint [18:27:40] addshore: yeah, error goes away when I change it to int [18:27:49] there are a pile of errors behind it tho [18:28:01] Query: CREATE INDEX "entity_id" ON "integrationtest_mainsnak_number" ("entity_id"); [18:28:03] Function: DatabaseBase::query [18:28:05] Error: 1 index entity_id already exists [18:28:20] Been looking at those already for a bit and do not see what the issue is with the query engine code [18:28:34] since it works for mysql this seems to likely be a wb db issue [18:35:32] addshore: you hiding? :D [18:41:42] [travis-ci] wmde/WikibaseQueryEngine#12 (entropyChange - 69bd240 : jeroendedauw): The build failed. [18:41:42] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/66ba3f107f73^...69bd24094732 [18:41:42] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19202661 [18:43:13] addshore: please to merge https://github.com/wmde/WikibaseQueryEngine/pull/2 into your PR if it looks good [18:47:35] [travis-ci] wmde/WikibaseQueryEngine#14 (entropyChange - d86f425 : jeroendedauw): The build is still failing. [18:47:35] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/69bd24094732...d86f42530cfc [18:47:35] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19203047 [18:53:06] Hi. I see 2 Wikidata channels: #wikidata and #wikimedia-wikidata [18:53:19] Shouldn't one redirect to the other. [18:54:56] I hope that #wikimedia-wikidata does [18:56:34] It doesn't [18:58:54] [13WikibaseDataModelSerialization] 15Tpt opened pull request #25: Adds labels, descriptions and aliases serialization (06master...06FinishEntitySerializer) 02http://git.io/86-Uzw [19:04:41] [travis-ci] wmde/WikibaseQueryEngine#16 (addshoreChanges - 1487ccd : addshore): The build is still failing. [19:04:41] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/c33994286436...1487ccde034a [19:04:41] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/19203980 [19:44:43] addshore: nicer code is nicer https://github.com/wmde/WikibaseQueryEngine/pull/3 [19:58:04] [13WikibaseDatabase] 15JeroenDeDauw created 06doubleindex (+1 new commit): 02http://git.io/990RRg [19:58:04] 13WikibaseDatabase/06doubleindex 1449778e5 15jeroendedauw: Add guard against having an index twice in a table definition [19:58:15] addshore: this will tell us where the issue lies :) https://github.com/wmde/WikibaseDatabase/pull/13 [19:58:22] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #13: Add guard against having an index twice in a table definition (06master...06doubleindex) 02http://git.io/J_apQQ [19:59:51] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/n49Kog [19:59:51] 13WikibaseDatabase/06master 140f12178 15jeroendedauw: Style fixes [20:01:14] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/R_jXGg [20:01:14] 13WikibaseDatabase/06master 1418293c5 15jeroendedauw: Add missing @author tag [20:05:30] [13WikibaseDatabase] 15JeroenDeDauw created 06testimporve (+1 new commit): 02http://git.io/kXKtwQ [20:05:30] 13WikibaseDatabase/06testimporve 14b528fe8 15jeroendedauw: Improve FieldDefinitionTest [20:05:42] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #14: Improve FieldDefinitionTest (06master...06testimporve) 02http://git.io/XvnK8A [20:08:40] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 4 new commits to 06master: 02http://git.io/iU9Q7A [20:08:40] 13WikibaseDataModelSerialization/06master 14da5f714 15Tpt: Adds an EntityIdDeserializer as wrapper to EntityIdParser [20:08:41] 13WikibaseDataModelSerialization/06master 143dde975 15Tpt: Use the right method for Entity ids serialization [20:08:41] 13WikibaseDataModelSerialization/06master 14044c9d2 15Tpt: Makes EntityIdDeserializer::isDeserializerFor more accurate... [20:10:05] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/sMpo8g [20:10:05] 13WikibaseDataModelSerialization/06master 14ea7e6ea 15Tpt: Adds labels, descriptions and aliases serialization [20:10:05] 13WikibaseDataModelSerialization/06master 14df06a42 15Jeroen De Dauw: Merge pull request #25 from Tpt/FinishEntitySerializer... [20:14:24] [13WikibaseDatabase] 15addshore 04deleted 06testimporve at 14b528fe8: 02http://git.io/ZEdj5g [20:15:02] [13WikibaseDatabase] 15addshore closed pull request #13: Add guard against having an index twice in a table definition (06master...06doubleindex) 02http://git.io/J_apQQ [20:28:31] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/kQ9q5g [20:28:31] 13WikibaseDatabase/06master 141c35214 15Jeroen De Dauw: Update MediaWikiTableBuilder.php [20:29:09] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114321 (owner: 10L10n-bot) [20:30:40] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/WlmvsA [20:30:40] 13WikibaseDatabase/06master 146e9edf7 15Jeroen De Dauw: Update MediaWikiTableBuilder.php [20:34:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/693f2de : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/19209956 [21:21:09] [13WikibaseDatabase] 15JeroenDeDauw created 06aaaaaaaaaaaahy (+1 new commit): 02http://git.io/6YIdrQ [21:21:09] 13WikibaseDatabase/06aaaaaaaaaaaahy 14a8a660d 15jeroendedauw: Wtf sqlite! [21:21:37] JeroenDeDauw: I say wtf branch! [21:23:58] [13WikibaseDatabase] 15JeroenDeDauw 04force-pushed 06aaaaaaaaaaaahy from 14a8a660d to 149230adb: 02http://git.io/pjHgsw [21:23:58] 13WikibaseDatabase/06aaaaaaaaaaaahy 149230adb 15jeroendedauw: Wtf sqlite! [21:25:48] … [21:47:01] JeroenDeDauw: likes names such as this :P