[10:00:25] (03PS1) 10: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/112431 [10:01:11] by no one :P [10:05:54] (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/112431 [10:07:43] and beta is *not* broken :) [10:08:13] hi aude :) [10:08:30] (03Merged) 10jenkins-bot: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/112431 [10:08:47] aude: I hope it's not! [10:09:04] it's updating now I think.. [10:09:06] are selenium tests running automatically? [10:09:21] aude: not yet. did you manage to get the puppet running? [10:09:26] no [10:09:32] then not. :-( [10:09:42] :( [10:09:44] I changed the scripts in the puppet repo [10:09:51] ok [10:09:51] on friday [10:15:12] can anyone login to wikidata-jenkins? [10:18:29] might need rebooting [10:20:14] can't ssh into it... but I don't know whether I have access :P [10:20:20] rebooting [10:20:38] I think you do :> [10:20:40] hope that doesn't make it worse [10:21:01] it probably cant acces any of our ssh keys after this weekend [10:21:30] addshore: Why is that? [10:21:31] i see no console output [10:22:18] I think your part of the Wikidata project on labs right hoo? :) [10:22:20] alright, don't know if it's fixable.... [10:22:27] if not can make a new one (it's puppetized) [10:22:30] addshore: Don't think so [10:22:53] aude: Why's it broken? [10:23:07] oh no your not hoo! my mistake! [10:23:09] no idea [10:23:35] i can log in to other instances [10:30:32] Tobi_WMDE_: are all the jenkins jobs puppetized? [10:30:50] aude: no, don't think so [10:30:53] ick [10:30:54] :/ [10:31:07] where are they stored on the instance? [10:31:08] I can still access http://wikidata-jenkins.wmflabs.org/ci/ [10:31:14] hahaha! [10:31:15] Tobi_WMDE_: can you login? [10:31:17] ssh [10:31:30] aude: not via ssh [10:31:38] did you restart already? [10:31:39] can we "export" stuff [10:31:54] i tried restart but don't know if it does anythin [10:31:55] g [10:32:19] aude: I guess we can export.. I'll have a look [10:32:35] can investigate some more [10:33:18] If you messed file permissions you can also use Jenkins admin access to gain shell... just if you want to go that road [10:34:13] aude: if we get shell access to jenkins we could export all jobs to xml using get-job [10:34:26] hmmm [11:06:22] aude: addshore: hoo: can anybody of you point to the place where we can make changes to the apache-config of wikidata.org? [11:06:44] is Lydia_WMDE around ? [11:06:54] there's still this redirect-issue and DanielK_WMDE_ mentioned he could fix it once he knows where to make the change.. [11:07:12] http://git.wikimedia.org/summary/operations/apache-config.git [11:07:24] errr [11:07:49] http://git.wikimedia.org/summary/operations%2Fapache-config.git [11:07:49] hm [11:07:56] ah [11:08:47] our stuff is in main.conf and redirects.conf [11:12:38] wikidata_singlenode in puppet is heavily outdated :/ [11:12:49] it is [11:12:59] Is it still used anywhere? [11:13:20] not really.... migrating it to a test wiki farm setup [11:14:12] mh... is that one puppetized? [11:14:21] https://github.com/filbertkm/wikidata-multi [11:14:28] should put it in wmde or in gerit [11:14:56] we should tidy our puppet stuff up in general :P either have a wmde module or something to keep everything in [11:15:11] heh [11:15:18] wmde module sounds messy :P [11:15:33] we dont have that much stuff though, builder, tests system, jnekins [11:15:35] this one could potentially be used (reused) in vagrant [11:15:57] or just 3 modules :P [11:16:11] 3 modules is ok [11:16:46] and if we want to maintain singlenode still [11:17:26] aude: If not, we should probably kill it [11:17:45] kill kill kill! [11:17:48] yeah (and make sure new stuff does everything) [11:21:03] aude: betalabs seems to use wikidata_singlenode... what [11:22:14] misread the file name... doh [11:22:22] ./manifests/role/labsmediawiki.pp [11:25:18] i don't know it uses that [11:30:04] Adrian_WMDE: browser.driver.manage.timeouts.page_load = 60 [13:31:51] aude: addshore: what do you think? where should we put documentation how the automated build-test-betadeploy process currently works? [13:32:08] should we make a new section on https://www.mediawiki.org/wiki/Wikidata_build? [13:33:27] Tobi_WMDE_: sure [13:34:22] ok [13:34:29] I'll make a first version [13:34:49] thanks [13:39:32] (03PS5) 10Thiemo Mättig (WMDE): Avoid showing "null" in JavaScript tooltip for properties with no label. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 [13:39:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [13:43:15] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [13:59:35] (03PS6) 10Thiemo Mättig (WMDE): Avoid showing "null" in JavaScript tooltip for properties with no label. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 [13:59:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [14:01:58] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [14:19:42] aude: addshore: https://www.mediawiki.org/wiki/Extension:Wikidata_build#Automated_build_process [14:19:58] feel free to improve/change/update [14:20:15] ok [14:45:29] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [14:55:27] Tobi_WMDE_: we can ssh again [14:55:48] aude: yay! [14:55:51] retriggering a job to see if it works now [14:59:31] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [15:09:58] Tobi_WMDE_: and puppet runs again [15:10:11] we have various uncommitted stuff [15:10:17] yay! [15:11:32] what uncommited stuff do we have? [15:12:12] never mind [15:12:16] ok [15:14:40] aude: it seems jenkins is failing because it uses bash but should not.. I'm confused [15:17:23] don't know what it should do [15:21:25] aude: ah [15:21:30] I have a suspection [15:24:10] something changed since yesterday [15:25:41] aude: yes [15:26:34] we need to have #!/bin/bash whenever we execute a shell in one of the jenkins jobs [15:26:43] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [15:26:45] yes [15:32:58] aude: ssh is broken again [15:33:04] oh no [15:33:14] http too [15:33:18] no [15:33:19] this time [15:33:19] ! [15:33:24] :-( [15:33:49] aude: Got the thing approved now :) Mortals will take another month, but that's fine [15:33:57] hoo: \o/ [15:34:13] not that i am deploying stuff yet [15:34:26] better to have time to get used to things [15:38:59] Tobi_WMDE_, aude: SetSiteLinkTest and a few others are failing for me on master [15:39:03] any idea? [15:39:37] no idea [15:40:14] hm, sucks [15:40:26] DanielK_WMDE_: checking [15:40:37] something is wrong with storing test items in the DB again, i guess [15:40:46] rather hard to debug :/ [15:40:59] DanielK_WMDE_: confirmed [15:41:17] *sigh* at least it's not just me :) [15:41:24] so... how did that get merged?? [15:41:50] DanielK_WMDE_: sounds tastry [15:41:55] tasty >.> [15:42:51] i see nothing suspicious in the log. starting a binary search... [15:44:29] testing a version from a week ago (9ae022e27), i'm getting the same failures [15:44:41] Tobi_WMDE_: seems like this has been broken for quite a while... [15:44:48] *nobody* noticed? [15:45:05] DanielK_WMDE_: seems they are not broken on jenkins [15:45:15] but that uses sqlite [15:45:42] also seems to work on https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds [15:46:16] also with mysql on travis [15:46:18] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/18540473 [15:46:27] but yoiu can reproduce the issue locally? [15:46:29] Tobi_WMDE_: ssh works again [15:46:33] rebooted [15:46:37] hm... maybe a missing database update? let me run update.php on master [15:46:51] DanielK_WMDE_: I have 15 failures locally [15:47:06] when running just the SetSitelinkTest [15:47:14] and I did a DB update [15:47:20] still failures [15:47:22] Tobi_WMDE_: 16 failures, 1 error. one of them is caused by the site table foobar.# [15:47:35] don't have the error [15:48:36] Tobi_WMDE_: ah, sorry: 15 failures in SetSiteLinks. One error and one additional failure elsewhere [15:48:51] did something change in core that is related? [15:49:01] error in SetClaimTest, fiulure in SpecialUnconnectedPagesTest [15:49:02] ha! [15:49:21] no failures when I set experimental to true [15:49:24] aude: could be the issue, yea [15:49:26] oh [15:49:33] o_O [15:49:39] so, that's the reason it works on the CIs [15:49:39] let me check whether i have experimental on... [15:50:09] Tobi_WMDE_: oh! confirmed! [15:50:26] there were some changes last week regarding taking badges stuff out of non-experimental [15:50:29] that's good enough for me locally, but it sucks in general. make a ticket, please? [15:50:45] ah, that makes sense for the sitelinks stuff! [15:50:58] we'd like the build tests to run in non-experimental [15:51:06] definitly [15:51:18] basically, the tests need to be aware of experimental/nonexperimental [15:51:35] i think that was the issue [15:51:46] ahh yes! [15:51:50] we tried them non-experimental in the build [15:51:57] and ran into that issue (and forgot) [15:52:04] the tests are in a way that it's not easy to make those aware [15:52:10] put it on the board :) [15:52:11] indeed [15:52:16] +1 [15:52:17] I can take a look at that [15:52:30] can we please have a document/log somewhere, where we put stuff that needs further investigation [15:52:31] should be pretty simple [15:52:41] so, to just not forget such things [15:52:42] Tobi_WMDE_: bugzilla [15:52:50] hehe [15:52:53] or the board [15:52:56] for example.. [15:53:01] there's no point in having yet another place to look [15:53:04] (03PS1) 10Thiemo Mättig (WMDE): Use the watch.ajax module to update the watchlist link (a star in the Vector skin) whenever something was edited. I tried to avoid useless AJAX calls as good as I could. Note that the stopItemPageEditMode event I used is described as "to be removed or mar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112464 [15:53:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112464 (owner: 10Thiemo Mättig (WMDE)) [15:53:25] I'm talking about such things as hotfixes/issues/whatever happening during deployments [15:53:28] jenkins! [15:54:53] what is "wikibase-tests"? [15:55:09] aude: the thing that still uses zuul [15:55:13] we can get rid of that [15:55:18] :> [15:55:24] http://wikidata-jenkins.wmflabs.org/ci/job/wikibase-tests/46/console [15:55:25] it was revived somehow [15:55:32] yeah [15:55:42] just delete it [15:55:48] or switch it off [15:55:54] deleted [15:56:00] :) [15:56:01] but it might come back via puppet [15:56:14] need to find where to stop that [15:56:32] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112464 (owner: 10Thiemo Mättig (WMDE)) [15:56:49] aude: add a puppet rule that kills it :P [15:56:55] :D [16:00:26] Tobi_WMDE_: https://github.com/wmde/jenkins-puppet/pulls [16:01:14] aude: And the cron is not puppetized? [16:01:16] i don't know how the layout.yaml is generated (i think it's not using job builder) [16:02:23] hoo: not yet [16:02:31] hoo: what cron? the one making the build? [16:02:37] hm... MwTimeIsoFormatterTest is failing for me, seems like a message is missing: <wikibase-time-precision-Gannum> [16:02:43] updating wikidata-jenkins on the instance [16:02:48] O_o [16:02:58] DanielK_WMDE_: that should be in the i18n file [16:03:01] mh [16:03:07] it is [16:03:17] let me poke the l10n cache [16:03:45] addshore: any chance we move https://github.com/addshore/puppet to where the rest of our stuff is? [16:03:52] soon :) [16:03:56] ok :) [16:04:19] nope, no bananas [16:04:29] bah. ignoreing as unlreated to my change [16:04:37] hoo: documented in readme [16:04:44] (03PS5) 10Daniel Kinzler: Refactor caching for EntityRevisionLookup service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 [16:05:04] aude: That's ok for now... although there are quite some neat ways to do crons in puppet ;) [16:05:08] aude: DanielK_WMDE_ so what do you think? when should we run phpunit with experimental=false? on every patchset? [16:05:12] JeroenDeDauw: --^^ [16:05:22] that would double the time for the verification [16:05:46] Tobi_WMDE_: probably not. but we should do that every now and then. at least before deployment. perhaps daily. [16:06:06] or perhaps run that on every new build [16:06:23] DanielK_WMDE_: what we could do, is run the tests for the daily build with tru and with false [16:06:30] exactly [16:06:32] :) [16:06:38] make it so ;) [16:06:44] ok [16:08:18] hoo: Tobi_WMDE_ https://github.com/wmde/jenkins-puppet/pull/7 [16:09:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111222 (owner: 10Thiemo Mättig (WMDE)) [16:09:21] yay! [16:09:48] \o/ [16:13:34] (03PS1) 10Addshore: Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 [16:16:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112464 (owner: 10Thiemo Mättig (WMDE)) [16:16:43] (03PS2) 10Addshore: Cleanup Wikibase Permissions / Rights [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 [16:18:36] (03PS1) 10Addshore: Remove altitude from globe datatype description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112471 [16:26:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107391 (owner: 10Daniel Kinzler) [16:27:34] (03PS1) 10Addshore: Turn off translation of time precisions in backend [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112473 [16:27:47] aude: addshore: https://github.com/wmde/jenkins-puppet/pull/8 [16:29:28] aude: we need more testing nodes!! ;-) [16:30:31] aude: addshore: yay!! http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-browsertests-sauce/11/console [16:31:14] merged [16:31:33] Tobi_WMDE_: \o/ [16:34:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [16:39:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112470 (owner: 10Addshore) [16:43:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112471 (owner: 10Addshore) [16:44:46] (03PS1) 10Addshore: Add help urls to wb(parse|format) value apis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112477 [16:46:00] (03Abandoned) 10Addshore: Add wbgetsites api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [16:46:54] (03CR) 10Aude: [C: 032] Add help urls to wb(parse|format) value apis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112477 (owner: 10Addshore) [16:47:02] @todo since 1.0 [16:47:06] 0.1* [16:47:16] (03Merged) 10jenkins-bot: Add help urls to wb(parse|format) value apis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112477 (owner: 10Addshore) [16:47:36] https://github.com/wmde/jenkins-puppet/pull/9 [16:47:39] merge!! [16:47:42] :D [16:47:48] hah [16:48:09] done [16:48:10] should be the last one [16:48:11] :) [16:49:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112473 (owner: 10Addshore) [16:54:16] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112477 (owner: 10Addshore) [16:55:04] (03PS1) 10Addshore: Fix SetSiteLinkTests with Experimental = false [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112478 [16:55:08] DanielK_WMDE_: aude ** [16:55:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build failed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112478 (owner: 10Addshore) [16:55:12] ^^ [16:55:57] (03PS2) 10Addshore: Fix SetSiteLinkTests with Experimental = false [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112478 [16:56:22] how odd that wikidatajenkins found a conflict but the normal jenkins didnt, usually its the other way around! [16:58:11] woohh? [16:58:23] was there a conflict? [16:58:35] well, it said the changes cant be merged into the repo :P [16:58:39] but only 1 jenkins said it xD [16:58:43] hehe [16:58:53] and i highly doubt there was actually a conflict :P I was only off master by 1 change [17:01:15] does anyone use apiInDebug or apiDebugWithTokens or apiDebugWithPost ? [17:01:20] if not I will get rid of them [17:01:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112478 (owner: 10Addshore) [17:06:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112478 (owner: 10Addshore) [17:11:37] addshore: AFAIK Henning_WMDE used that some time ago [17:11:48] really? :O okay :P [17:11:53] but in general, we should get rid of it [17:12:04] :> well I already made the patch ;p [17:12:13] (03Draft1) 10Addshore: Remove clutter unused api debug/test settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 [17:12:18] :D [17:12:25] ::) [17:16:26] beta is extremely slow today [17:16:53] tests take double# the time to run [17:17:26] :< [17:18:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 (owner: 10Addshore) [17:18:37] but I'm not sure yet if it's really beta that is slow [17:18:55] labs is having a bad day perhaps [17:19:46] could be [17:20:17] could also be that our own saucelabs account is slower than the one connected to cloudbees [17:24:41] addshore: http://www.lieferando.de/lieferservice-world-of-pizza-berlin#!cart [17:25:55] addshore: !! [17:32:38] JeroenDeDauw: send me all the schema things!!! [17:40:03] addshore: https://www.mediawiki.org/wiki/Extension:Wikibase_QueryEngine/SQL_schema_proposal [17:41:50] addshore: https://github.com/wmde/WikibaseQueryEngine/blob/master/src/SQLStore/DataValueHandlers.php [17:53:25] Lydia_WMDE: hah... the Scribunto flaw which made users able to access foreign items has been fixed :) [17:53:58] hoo: \o/ [17:56:05] JeroenDeDauw: might have to poke a few things in WIkibaseDatabase first unless you have already done them [18:07:22] (03CR) 10Aude: [C: 032] Slim down wbCurrentSite to only hold information we need [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 (owner: 10Hoo man) [18:07:48] (03Merged) 10jenkins-bot: Slim down wbCurrentSite to only hold information we need [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 (owner: 10Hoo man) [18:07:59] (03CR) 10Aude: [C: 032] Remove altitude from globe datatype description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112471 (owner: 10Addshore) [18:08:13] aude: Thanks :) [18:08:21] (03Merged) 10jenkins-bot: Remove altitude from globe datatype description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112471 (owner: 10Addshore) [18:08:23] time to go home [18:11:14] Lydia_WMDE: irc says its time to go home :) [18:11:29] so does wikidata [18:11:30] :* [19:54:25] (03CR) 10Jeroen De Dauw: [C: 032] Fix SetSiteLinkTests with Experimental = false [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112478 (owner: 10Addshore) [19:55:20] (03CR) 10Jeroen De Dauw: [C: 031] Turn off translation of time precisions in backend [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112473 (owner: 10Addshore) [19:56:38] (03CR) 10Jeroen De Dauw: "\o/ kill all of the evil things (though not me)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112479 (owner: 10Addshore) [19:57:09] JeroenDeDauw: You had to kill my hopes then :( [19:57:32] JohnLewis: yes, your hopes are evil as well [19:57:49] >:D [19:58:13] Is that a loughing smiley or an angry one? [19:58:19] * JeroenDeDauw is not sure what the > is about [19:58:39] Angry :p [19:58:46] No, evil :p [19:59:20] :<0 <- that is my angry one [19:59:55] JohnLewis: so, did you just say not only your ideas are evil - you yourself are as well? [20:00:05] Now that is an addshore face :p [20:00:33] JeroenDeDauw: Ofc I'm evil :p Vogoninski will comment on that. [20:00:55] addshore: go kill JohnLewis please! [20:01:17] JohnLewis: hes been practicing with shooting up virtual doodes all weekend, so better watch out [20:01:19] JeroenDeDauw: He will, when he leaves Berlin and returns back to the UK :D [20:01:55] JohnLewis: oh, you are from the evil British empire. That's double evilness then! [20:03:46] JeroenDeDauw: True :p That also makes addshore evil though! [20:05:24] JohnLewis: on what? :) [20:05:40] Vogoninski: My evilness :p [20:06:49] No comment. [20:07:15] Fair enough :p [20:21:04] JohnLewis: one needs some amount of evil to combat it no? [20:49:32] JeroenDeDauw : Maybe [20:52:34] [13WikibaseDataModelSerialization] 15JeroenDeDauw closed pull request #11: Implementation of SerializerFactory and DeserializerFactory (06master...06factory) 02http://git.io/dwVbIQ [20:56:49] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/112561 (owner: 10L10n-bot) [20:57:08] addshore: https://github.com/wmde/WikibaseDataModel/pull/8 [20:59:00] JeroenDeDauw: Hi! I need a bit of help for references implementation. [20:59:02] [travis-ci] wmde/WikibaseDataModel#50 (self - 6b08cf2 : jeroendedauw): The build passed. [20:59:02] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/commit/6b08cf249023 [20:59:02] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/18607432 [20:59:16] [13WikibaseDataModelSerialization] 15JeroenDeDauw closed pull request #10: Adds beggining of Claim deserialization (06master...06claimsDeserializer) 02http://git.io/TKx6lA [20:59:18] Tpt_: one sec please, I will push some changes to this component that alter paths [20:59:28] Ok. No problem :-) [20:59:32] 01[13WikibaseDataModel01] 15addshore pushed 2 new commits to 06master: 02http://git.io/_XKbPw [20:59:32] 13WikibaseDataModel/06master 146b08cf2 15jeroendedauw: Remove refs to Statement in Statement class [20:59:32] 13WikibaseDataModel/06master 14dc46e46 15addshore: Merge pull request #8 from wmde/self... [21:01:53] 01[13WikibaseDataModelSerialization01] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/wTexyw [21:01:53] 13WikibaseDataModelSerialization/06master 146e62cc0 15jeroendedauw: Fix style issues [21:02:50] 01[13WikibaseDataModelSerialization01] 15JeroenDeDauw created 06psr4 (+1 new commit): 02http://git.io/AiJ6OA [21:02:50] 13WikibaseDataModelSerialization/06psr4 14b802808 15jeroendedauw: Use psr4 based loading [21:03:02] addshore: Tpt_ https://github.com/wmde/WikibaseDataModelSerialization/pull/12 [21:03:10] [13WikibaseDataModelSerialization] 15JeroenDeDauw opened pull request #12: Use psr4 based loading (06master...06psr4) 02http://git.io/pQSscA [21:03:17] wow this thing is spammy [21:03:38] 01[13WikibaseDataModelSerialization01] 15addshore pushed 1 new commit to 06master: 02http://git.io/p4s9qA [21:03:38] 13WikibaseDataModelSerialization/06master 14cd3c1c3 15addshore: Merge pull request #12 from wmde/psr4... [21:04:16] Tpt_: so what do you need help with? [21:05:09] With References. It use internally hash with a random part that makes unit tests very difficult. [21:06:07] assertEquals( new ReferenceList( array( new Reference() ) ), new ReferenceList( array( new Reference() ) ) ) will return false [21:11:17] JeroenDeDauw: So, is there a nice way to check if two ReferenceList are equals? [21:13:20] Tpt_: put in the same reference :) [21:13:30] Tpt_: where do you want to do this check? [21:14:17] In roundtrip tests for References(De)Serializer: https://github.com/Tpt/WikibaseDataModelSerialization/compare/references?expand=1 [21:15:32] hello, the hebrew wikiqoute would like to enable wikidata, what should be done in order to achive this? [21:16:41] Lydia_WMDE ^ [21:16:44] Tpt_: actually not sure there is much use for such a roundtrip test [21:16:56] Tpt_: if you have serialization and deserialization unit tests already... [21:17:07] matanya: its in your plan :) https://www.wikidata.org/wiki/Wikidata:Development_plan#Access_for_remaining_sister_projects [21:17:19] Tpt_: think you ncan just get by with having a roundrtip test for the top level object - ie entity [21:18:07] thanks addshore [21:18:18] Tpt_: also, you can easily get by with just constructing it once, ie as done at https://github.com/wmde/AskSerialization/blob/master/tests/Integration/Serialization/QueryRoundtripTest.php [21:18:44] matanya: its planned to give wikisource phase 2 in 2 weeks time I imagine therefor wikiquote will be in a month, or just after [21:19:06] for phase 1 that it, and then phase 2 soon after :) [21:19:34] Tpt_: can you submit the PR? Then I can add comments [21:19:35] JeroenDeDauw: Ok. But it also blocks me to unit test the deserializer because I need to check that a non-empty list is well deserialize. [21:20:49] addshore: matanya: i think it'll be a bit more than that [21:21:01] :P [21:21:07] fair enough [21:21:12] but yeah [21:21:14] it will happen next [21:21:17] Bad addshore for false guessing :p [21:21:19] * addshore is always very optimistic ;p [21:21:21] hehe [21:21:24] it is a good sign though Lydia_WMDE :) [21:21:29] :) [21:21:48]