[00:14:14] <Krinkle>	 Hey, Extension:Wikidata is doing something it shouldn't be doing and it is going to break soon
[00:14:21] <Krinkle>	 https://github.com/wikimedia/mediawiki-extensions-Wikidata/blob/5acfdd6546273e9f2c70d23f3a862cc550fb6aef/extensions/Wikibase/lib/resources/Resources.php#L352
[00:14:37] <Krinkle>	 'mediawiki.tests.qunit.testrunner' is a dynamic module provided by core and automatically added to the dependencies
[00:14:50] <Krinkle>	 this module will be renamed and anything using the proper hook will automatically use the new name
[00:15:40] <Krinkle>	 It should register that module as a test module, not a regular module, then it'll be given taht dependency automatically
[00:19:11] <hoo>	 yikes
[00:20:49] <hoo>	 Krinkle: ResourceLoaderTestModules will that hook do that for us
[00:21:09] <hoo>	 If we use it, can I just strike the dependency?
[00:23:08] <Krinkle>	 hoo: yes and yes
[00:23:27] <Krinkle>	 https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/VisualEditor.hooks.php#L501-L506
[00:23:37] <Krinkle>	 I think wikidata already uses that hook, just need to add this to it
[00:23:46] <Krinkle>	 hoo: Thanks man!
[00:28:59] <hoo>	 Krinkle: Sorry, my Pidgin crashed twice... will prepare a patch soon... just finishing my current hing
[00:31:35] <grrrit-wm>	 (03CR) 10Hoo man: Implement mw.wikibase.entity.formatPropertyValues (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 (owner: 10Hoo man)
[00:32:08] <grrrit-wm>	 (03PS20) 10Hoo man: Implement mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 
[00:33:15] <grrrit-wm>	 (03CR) 10Hoo man: "Addressed Daniel's comments (@Daniel: Please see my replies on PS19)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 (owner: 10Hoo man)
[00:33:30] <grrrit-wm>	 (03PS11) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 
[00:38:58] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 (owner: 10Hoo man)
[00:43:28] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man)
[00:51:55] <hoo>	 wtf... removing code but leaving the tests in place is very bad style
[00:51:57] <hoo>	 very bad -.-
[00:53:16] <hoo>	 Krinkle: got a core change to link?
[00:57:00] <Krinkle>	 Nope, not yet. Just enforcing something that should be enforced already
[00:57:35] <hoo>	 Krinkle: what about https://gerrit.wikimedia.org/r/111632 ? In my tests right now that already broke our Qunits
[00:58:04] <Krinkle>	 hoo: Yeah, that's where it starts.
[00:58:07] <Krinkle>	 Feel free to link that one
[00:58:45] <grrrit-wm>	 (03PS1) 10Hoo man: Fix the Qunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 
[01:04:42] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[01:06:33] <grrrit-wm>	 (03PS2) 10Hoo man: Fix the Qunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 
[01:08:03] <hoo>	 finally -.-
[01:08:11] <hoo>	 Krinkle: Thanks for letting me/us know
[01:09:20] <Krinkle>	 hoo: Hm.. interesting, I was expecting a fix where it moves the module to a different file and adds the dependency but I guess nothing was using it?
[01:09:33] <Krinkle>	 What about 'wikibase.tests.qunit.testrunner' module though
[01:09:39] <Krinkle>	 that depends on QUnit.newMwEnvironment
[01:09:52] <Krinkle>	 which is provided by core's test.mediawiki.qunit.testrunner
[01:10:04] <Krinkle>	 it should depend on it, by declaring it in the testModules instead
[01:10:08] <Krinkle>	 so it gets the dependency automatically
[01:11:10] <hoo>	 Krinkle: mh... don't know how, but that version passed, will amend though... one second
[01:12:22] <grrrit-wm>	 (03PS3) 10Hoo man: Fix the Qunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 
[01:12:27] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[01:12:43] <hoo>	 Krinkle|detached: ^
[01:14:27] <grrrit-wm>	 (03PS4) 10Hoo man: Fix the Qunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 
[01:17:56] <grrrit-wm>	 (03PS12) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 
[01:18:25] <hoo>	 enough for now :P
[01:20:11] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[01:25:26] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[01:29:59] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man)
[09:45:27] <grrrit-wm>	 (03CR) 10Raimond Spekking: Add i18n support in MwTimeIsoFormatter (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore)
[09:48:01] <grrrit-wm>	 (03CR) 10Addshore: Add i18n support in MwTimeIsoFormatter (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore)
[10:29:40] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "Will try, but we have a ton of sessions with the HPI students today..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man)
[11:58:40] <grrrit-wm>	 (03PS5) 10Henning Snater: Fix the Qunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[12:01:26] <grrrit-wm>	 (03CR) 10Hoo man: [C: 031] "I'm fine with the changes by Henning" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[12:01:36] <grrrit-wm>	 (03CR) 10Henning Snater: "Patch set 5: Moved Wikibase test runner to test resources; still needs dependency on MediaWiki test runner." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[12:02:09] <hoo>	 Henning_WMDE: The dependency is fine, as long as we have it only in the test registry and not the production one ;)
[12:02:24] <hoo>	 Not sure my commit summary is obvious is enough
[12:02:48] <hoo>	 DanielK_WMDE: got a few minutes to debug the Lua stuff?
[12:04:36] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[12:05:29] <Henning_WMDE>	 hoo: The Wikibase test runner is only used by the test resources anyway, so I moved it over. We should, in general, be more explicit about module dependencies in the future.
[12:06:20] <hoo>	 +1 :)
[12:06:29] <GerardM->	 http://ultimategerardm.blogspot.nl/2014/02/reasonator-proof-of-pudding.html
[12:12:17] <github-wmde>	 01[13DataValuesJavascript01] 15snaterlicious created 06fixqunitmodules (+1 new commit): 02http://git.io/LBBVKg
[12:12:17] <github-wmde>	 13DataValuesJavascript/06fixqunitmodules 14b609465 15snaterlicious: Fixed definitions of ResourceLoader test modules
[12:13:05] <github-wmde>	 [13DataValuesJavascript] 15snaterlicious opened pull request #26: Fixed definitions of ResourceLoader test modules (06master...06fixqunitmodules) 02http://git.io/gJzPtw
[12:13:55] <Henning_WMDE>	 hoo: ^^ another QUnit fix... ;) Tests will execute with resourceLoaderDebug = false again...
[12:14:16] <hoo>	 already looking... did you test it?
[12:14:21] <hoo>	 If so, I can approve
[12:16:33] <hoo>	 Henning_WMDE: --^
[12:16:37] <hoo>	 Looks good
[12:20:26] <Henning_WMDE>	 hoo: Yes, I did test it. Was wondering why I still received failures on your change ... boiled down to that...
[12:20:27] <github-wmde>	 [13DataValuesJavascript] 15mariushoch closed pull request #26: Fixed definitions of ResourceLoader test modules (06master...06fixqunitmodules) 02http://git.io/gJzPtw
[12:21:02] <github-wmde>	 01[13DataValuesJavascript01] 15mariushoch 04deleted 06fixqunitmodules at 14b609465: 02http://git.io/bQE1-Q
[12:21:40] <Henning_WMDE>	 hoo: Are you fine with my changes to your change. If so, I would merge it as well.
[12:21:51] <hoo>	 Henning_WMDE: I am, already +1ed :)
[12:22:01] <Henning_WMDE>	 Ah, okay, sorry! :)
[12:22:23] <grrrit-wm>	 (03CR) 10Henning Snater: [C: 032] Fix the Qunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[12:22:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix the Qunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111684 (owner: 10Hoo man)
[12:46:07] <grrrit-wm>	 (03PS1) 10Henning Snater: Updated ULS module dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111783 
[12:50:39] <Tobi_WMDE>	 JeroenDeDauw: https://github.com/wmde/Diff/pull/2
[12:50:41] <Tobi_WMDE>	 merge!
[12:50:43] <Tobi_WMDE>	 :)
[12:52:18] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111783 (owner: 10Henning Snater)
[12:53:11] <travis-ci>	 [travis-ci] wmde/Diff#7 (getcwd - 70cae67 : Tobias Gritschacher): The build passed.
[12:53:11] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Diff/commit/70cae67daba1
[12:53:11] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Diff/builds/18340169
[12:55:38] <hoo>	 Tobi_WMDE: Merged
[13:03:40] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Updated ULS module dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111783 (owner: 10Henning Snater)
[13:04:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated ULS module dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111783 (owner: 10Henning Snater)
[13:06:49] <github-wmde>	 [13WikibaseDataModelSerialization] 15Tpt opened pull request #9: Adds Reference support (06master...06reference) 02http://git.io/iWh6UA
[13:35:07] <grrrit-wm>	 (03PS1) 10Aude: Fix Wikidata extension name for Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111791 
[13:35:33] <aude>	 easy chocolate ^
[13:36:14] <grrrit-wm>	 (03PS2) 10Aude: Fix Wikidata extension name for Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111791 
[13:36:27] <travis-ci>	 [travis-ci] wmde/WikibaseQuery#24 (master - 4d60209 : addshore): The build passed.
[13:36:27] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/762aa0412fba...4d6020969ca2
[13:36:27] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/18342335
[13:43:00] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Fix Wikidata extension name for Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111791 (owner: 10Aude)
[13:43:05] <grrrit-wm>	 (03CR) 10Addshore: [V: 032] Fix Wikidata extension name for Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111791 (owner: 10Aude)
[13:43:22] <addshore>	 aude need to also merge that change into the wikidata builder repo on github
[13:45:52] <aude>	 ah yes
[13:47:57] <github-wmde>	 01[13WikidataBuilder01] 15filbertkm created 06specialversion at 1421501c8 (+0 new commits): 02http://git.io/i4eTtw
[13:48:08] <aude>	 wtf
[13:48:27] <aude>	 0 new commits?
[13:48:29] <addshore>	 xD
[13:48:40] <addshore>	 you didnt commit? :P just made a branch
[13:49:03] <aude>	 ok, i committed locally to a branch
[13:50:04] <github-wmde>	 01[13WikidataBuilder01] 15filbertkm pushed 1 new commit to 06specialversion: 02http://git.io/kjuAMw
[13:50:04] <github-wmde>	 13WikidataBuilder/06specialversion 149a34c70 15aude: Fix extension name for Special:Version...
[13:50:13] <aude>	 https://github.com/wmde/WikidataBuilder/pull/11
[13:50:15] <github-wmde>	 [13WikidataBuilder] 15filbertkm opened pull request #11: Fix extension name for Special:Version (06master...06specialversion) 02http://git.io/87OIpg
[13:50:30] <addshore>	 done
[13:50:39] <github-wmde>	 01[13WikidataBuilder01] 15addshore pushed 1 new commit to 06master: 02http://git.io/pteniA
[13:50:39] <github-wmde>	 13WikidataBuilder/06master 148d1f71b 15addshore: Merge pull request #11 from wmde/specialversion...
[13:50:49] * aude  waits for beta to update

[13:52:18] <travis-ci>	 [travis-ci] wmde/WikidataBuilder#102 (specialversion - 9a34c70 : aude): The build passed.
[13:52:19] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikidataBuilder/compare/21501c83fe8c...9a34c703e2f5
[13:52:19] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikidataBuilder/builds/18343404
[14:06:05] <github-wmde>	 01[13WikidataBuilder01] 15filbertkm created 06specialversion (+1 new commit): 02http://git.io/nfF6dA
[14:06:05] <github-wmde>	 13WikidataBuilder/06specialversion 148b78a7b 15aude: Fix extension path for Special:Version...
[14:06:24] <grrrit-wm>	 (03PS1) 10Aude: Fix extension path for Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111792 
[14:06:29] <aude>	 addshore: ^
[14:06:35] <aude>	 that should work better
[14:06:52] <grrrit-wm>	 (03CR) 10Addshore: [C: 032 V: 032] Fix extension path for Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111792 (owner: 10Aude)
[14:07:42] <github-wmde>	 [13WikidataBuilder] 15filbertkm opened pull request #12: Fix extension path for Special:Version (06master...06specialversion) 02http://git.io/H2BOsA
[14:23:52] <aude>	 Tobi_WMDE: http://wikidata.beta.wmflabs.org/wiki/Special:Version works now
[15:03:42] <github-wmde>	 01[13WikidataBuilder01] 15addshore 04deleted 06specialversion at 148b78a7b: 02http://git.io/ejsr9g
[15:06:43] <travis-ci>	 [travis-ci] wmde/WikidataBuilder#107 (master - a65143c : addshore): The build was broken.
[15:06:43] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikidataBuilder/compare/8d1f71bed164...a65143ca9808
[15:06:43] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikidataBuilder/builds/18347963
[15:09:36] * aude  didn't break anything!

[15:15:45] <Thiemo_WMDE>	 Date and times to be parsed: "Mai 750", "-5", "5 BC", "8 Jan 700", "Jan 8 701", "2 Mio. v. Chr.", ...
[15:18:12] <Thiemo_WMDE>	 ... "1/2/3" (MDY or MDY?), "1.2.3" (always German DMY?), ...
[15:19:09] <Thiemo_WMDE>	 ... "early 20th centruy", ...
[15:20:57] <aude>	 addshore: http://pastie.org/8705167
[15:21:52] <aude>	 https://fa.wikipedia.org/wiki/%D8%A8%D8%A7%D8%B1%D8%A7%DA%A9_%D8%A7%D9%88%D8%A8%D8%A7%D9%85%D8%A7
[15:22:00] <aude>	 pick any of the dates
[15:23:13] <addshore>	 :<
[15:24:27] <aude>	 number parser: ۳٬۵۳۶٬۶۴۲٬۶۴۲٬۳۶۴٬۳۶۴٬۲۶۳٬۱۲۳±۱
[15:26:00] <grrrit-wm>	 (03PS7) 10Addshore: Implement TimeParsers ... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 
[15:26:01] <Thiemo_WMDE>	 ... in German "010203" and "01022003" should become 1 Jan 2003.
[15:27:09] <grrrit-wm>	 (03PS8) 10Addshore: Implement TimeParsers ... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 
[15:29:59] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "So, here's the module code:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man)
[15:33:10] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore)
[15:37:44] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore)
[16:08:34] <legoktm>	 Thiemo_WMDE: welcome!
[16:08:55] <Thiemo_WMDE>	 thanks. :)
[16:20:51] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111811 
[16:20:57] <aude>	 \o/
[16:21:58] <grrrit-wm>	 (03CR) 10Aude: [C: 032] New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111811 (owner: 10WikidataBuilder)
[16:25:49] <github-wmde>	 01[13WikidataBuilder01] 15filbertkm created 06extensionlist (+1 new commit): 02http://git.io/p4AI2Q
[16:25:49] <github-wmde>	 13WikidataBuilder/06extensionlist 144d60d55 15aude: update extension list
[16:26:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111811 (owner: 10WikidataBuilder)
[16:26:21] <aude>	 addshore: merge it
[16:26:23] <github-wmde>	 [13WikidataBuilder] 15filbertkm opened pull request #13: update extension list (06master...06extensionlist) 02http://git.io/XYmtNg
[16:27:10] <github-wmde>	 01[13WikidataBuilder01] 15addshore pushed 1 new commit to 06master: 02http://git.io/HQurKQ
[16:27:10] <github-wmde>	 13WikidataBuilder/06master 14991b75d 15addshore: Merge pull request #13 from wmde/extensionlist...
[16:27:11] <14WAB3YR7>	 01[13WikidataBuilder01] 15addshore 04deleted 06extensionlist at 144d60d55: 02http://git.io/1NCApQ
[16:27:16] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111813 
[16:29:06] <grrrit-wm>	 (03Abandoned) 10WikidataBuilder: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111813 (owner: 10WikidataBuilder)
[16:29:10] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111815 
[16:32:39] <travis-ci>	 [travis-ci] wmde/WikidataBuilder#110 (master - 991b75d : addshore): The build was fixed.
[16:32:39] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/WikidataBuilder/compare/a65143ca9808...991b75d3acda
[16:32:39] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/WikidataBuilder/builds/18353557
[16:34:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111815 (owner: 10WikidataBuilder)
[16:34:45] <jayvdb>	 time values are displaying lots of leading zeros; e.g. https://www.wikidata.org/wiki/Q6396063
[16:35:11] <jayvdb>	 possibly this is due to my pref being ISO dates
[16:35:26] <jayvdb>	 I see "+00000001983-06-13T00:00:00Z"
[16:36:15] <grrrit-wm>	 (03PS4) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[16:36:41] <legoktm>	 jayvdb: yeah, I see human readable ones "May 30 1941"
[16:39:15] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111817 
[16:40:14] <grrrit-wm>	 (03Abandoned) 10WikidataBuilder: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111811 (owner: 10WikidataBuilder)
[16:40:21] <grrrit-wm>	 (03Abandoned) 10WikidataBuilder: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111815 (owner: 10WikidataBuilder)
[16:41:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111817 (owner: 10WikidataBuilder)
[16:42:07] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[16:42:38] <addshore>	 jayvdb: interesting :O
[16:43:14] <addshore>	 but yes, thats probably due to the pref being iso dates 
[16:59:38] <grrrit-wm>	 (03PS5) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[17:05:38] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[17:20:58] <grrrit-wm>	 (03PS6) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[17:24:05] <grrrit-wm>	 (03PS7) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[17:27:44] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[17:31:58] <aude>	 DanielK_WMDE: it says "Varnish XID 2665166859"
[17:32:04] <aude>	 tells me it probably is varnish
[17:32:13] <aude>	 need to figure out which servers these are
[17:32:27] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[17:33:32] <aude>	 it's a text varnish cache
[17:33:37] <aude>	 cp1065.eqiad.wmnet
[17:54:20] <grrrit-wm>	 (03PS1) 10: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111826 
[18:11:49] <JaimeLyn>	 Hello out there
[18:11:58] <github-wmde>	 01[13WikibaseDataModelSerialization01] 15addshore pushed 3 new commits to 06master: 02http://git.io/vSdcDQ
[18:11:58] <github-wmde>	 13WikibaseDataModelSerialization/06master 14e98aa9d 15Tpt: Adds Reference support
[18:11:58] <github-wmde>	 13WikibaseDataModelSerialization/06master 14cb8c547 15Tpt: optimize imports
[18:11:58] <github-wmde>	 13WikibaseDataModelSerialization/06master 1414c8d88 15addshore: Merge pull request #9 from Tpt/reference...
[18:15:48] <grrrit-wm>	 (03CR) 10Addshore: "Reason for failure is this this depends on stuff that is not yet merged in Data-Values/time" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111464 (owner: 10Addshore)
[18:27:20] <Tobi_WMDE>	 addshore: https://gerrit.wikimedia.org/r/#/c/111817/1/Wikidata.php,cm
[18:27:32] <Tobi_WMDE>	 even both are in there
[18:30:43] <grrrit-wm>	 (03PS1) 10: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111831 
[18:31:08] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111831 
[18:31:55] <grrrit-wm>	 (03Abandoned) 10Addshore: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111817 
[18:37:02] <grrrit-wm>	 (03PS2) 10Addshore: New Wikidata Build :D [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111831 
[18:37:26] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111831 
[18:39:37] <grrrit-wm>	 (03PS3) 10Tobias Gritschacher: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111831 
[18:41:23] <grrrit-wm>	 (03CR) 10WikidataJenkins: [C: 032 V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111831 
[18:44:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: New Wikidata Build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/111831 
[18:50:19] <github-wmde>	 [13WikibaseDataModelSerialization] 15Tpt opened pull request #10: Adds beggining of Claim deserialization (06master...06claimsDeserializer) 02http://git.io/TKx6lA
[19:08:43] <aude>	 Lydia_WMDE: https://www.kickstarter.com/projects/77145396/phpwomen-purple-elephpants ;)
[19:25:13] <apsdehal>	 Hi all, Kindly tell me, Which docs I have to refer to learn how to connect to wikidata items and properties through api, and feed data to it.
[19:31:12] <Lydia_WMDE>	 aude: :D
[19:35:52] <aude>	 yikes, something is broken
[19:36:01] <aude>	 all the wikis
[19:38:51] <addshore>	 O_o
[19:39:26] <aude>	 i don't see anythign obvious in the logs
[19:39:31] <addshore>	 well isnt -operations just a pile of fun
[19:39:45] <aude>	 not sure exactly what level this is (varnish?)
[19:40:38] <addshore>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=60970
[19:40:54] <addshore>	 https://gdash.wikimedia.org/dashboards/reqerror/ :>
[19:41:33] <aude>	 yep
[19:41:42] <aude>	 smells similar to our entity data error
[19:42:53] <addshore>	 aude: should the wikidata build show up on enwikipedia?
[19:43:02] <aude>	 it did and was fine
[19:43:09] <addshore>	 :)
[19:43:22] <aude>	 http://en.wikipedia.org/wiki/Interstate_805
[19:43:24] <aude>	 https
[19:43:38] <aude>	 that's a good item to check, since it uses lua for the infobox map
[19:43:52] <aude>	 purge the page, all good :)
[19:47:40] <aude>	 stuff is coming back, though only because we reverted to earlier versions of stuff
[20:49:48] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111882 (owner: 10L10n-bot)
[21:50:15] <grrrit-wm>	 (03PS8) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[21:56:05] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[22:05:39] <grrrit-wm>	 (03CR) 10Bene: "Maybe someone can have a look here. It seems that the Title class does not handle interwiki prefixes correctly. Eg when executing the foll" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[22:21:37] <grrrit-wm>	 (03PS9) 10Bene: Insert badges for language links on client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 
[22:24:02] <benestar>	 aude: ping :)
[22:24:17] <sjoerddebruin>	 Hello benestar. :)
[22:24:25] <aude>	 benestar: looks pretty good but need to look in more detail
[22:24:29] <benestar>	 hey sjoerddebruin :)
[22:24:38] <benestar>	 aude: the tests fail and I don't know why...
[22:26:19] <sjoerddebruin>	 benestar: What's the ETA btw?
[22:26:58] <benestar>	 sjoerddebruin: you mean for badges?
[22:27:06] <sjoerddebruin>	 Yep.
[22:27:22] <benestar>	 depends on how fast I can make the client thing working
[22:27:29] <sjoerddebruin>	 :P
[22:27:35] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/111609 (owner: 10Bene)
[22:27:35] <benestar>	 and also how fast I (or someone else) implements the repo ui
[22:27:41] <benestar>	 :(
[22:27:46] <sjoerddebruin>	 Good luck.
[22:27:55] <aude>	 hmmm
[22:28:16] <benestar>	 aude: the core title/interwiki system is quite crazy
[22:28:24] <benestar>	 and way too huge classes
[22:28:36] <aude>	 yep
[22:28:50] <benestar>	 aude: any idea why Interwiki::fetch doesn't work?
[22:29:00] <aude>	 not sure we should use that
[22:29:38] <aude>	 doubt it works on a test wiki w/o interwiki table populated
[22:30:12] <benestar>	 aude: oh, sorry
[22:30:19] <benestar>	 the interwiki::fetch isn't even reached
[22:30:19] <aude>	 why $interwiki->getWikiID()
[22:30:28] <benestar>	 the title itself does not recognize the preifx
[22:30:30] <benestar>	 *prefix
[22:30:41] <aude>	 don't assume wikiid === siteid
[22:30:47] <aude>	 usually it does, but not always
[22:31:01] <benestar>	 aude: :/ that's another issue but not the actual failing one
[22:31:24] <aude>	 ok
[22:31:51] <aude>	 probably the sites code can be improved to handle retrieving a global id from interwiki
[22:32:02] <aude>	 do that nicer
[22:32:27] <benestar>	 aude: in core?
[22:32:36] <benestar>	 or what do you mean?
[22:33:13] <aude>	 tests on your patch pass for me
[22:33:18] <aude>	 but i have interwikis populated
[22:33:30] <aude>	 benestar: maybe in core... not sure
[22:33:52] <benestar>	 aude: hmm, ok, so the tests fail because Title does not know that en and nl are interwiki prefixes
[22:34:44] <benestar>	 aude: maybe use TestSites::insertIntoDb(); ?
[22:34:55] <aude>	 sorry, i was on wrong branch
[22:35:00] <aude>	 trying patch again
[22:36:45] <aude>	 i get 3 failures http://pastie.org/8706414
[22:37:36] <benestar>	 aude: me too
[22:37:38] <benestar>	 and jenkins also
[22:43:23] <aude>	 $interwiki->getWikiID() is null for me
[22:45:51] <benestar>	 aude: yes
[22:46:07] <benestar>	 because $languageLinkTitle->getInterwiki() is ''
[22:48:43] <aude>	 how is taht supposed to work?
[22:48:44] <aude>	 that*
[22:51:34] <benestar>	 aude: it should return 'en'
[22:52:30] <aude>	 something is wrong 
[22:52:37] <benestar>	 yes
[22:52:39] <benestar>	 ;)
[22:52:42] <sjoerddebruin>	 No shit, Sherlocks.
[22:53:03] <aude>	 i think we should have a mapping of interwiki -> site id
[22:53:39] <aude>	 in memcached (maybe) and/or even cdb (like interwikis are handled now)
[22:54:03] <aude>	 and obviously need 'en'
[22:55:08] <aude>	 maybe use Title::makeTitle()
[22:57:07] <aude>	 Title::newFromText calls $title->secureAndSplit() which depends on stuff like interwiki table being populated
[22:57:58] <benestar>	 aude: ok, I got deeper
[22:58:10] <benestar>	 the problem is that the interwiki table does not contain the 'en' prefix
[22:58:26] <benestar>	 this however shouldn't be a problem on the wiki itself
[22:58:30] <benestar>	 in production
[22:58:46] <aude>	 mine does
[22:58:55] <benestar>	 isn't there a test helper class like TestSites?
[22:59:02] <benestar>	 aude: :/
[22:59:03] <aude>	 production uses cdb
[22:59:05] <benestar>	 are you sure?
[22:59:08] <James_F>	 Yes.
[22:59:18] <aude>	 use makeTitle
[22:59:35] <aude>	 it skips the lookup and assumes the interwiki is valid
[22:59:53] <aude>	 we want to minimize db lookup in tests anyway
[23:00:03] <benestar>	 aude: ok
[23:00:22] <aude>	 we can even mock title
[23:00:25] <aude>	 if you like
[23:00:41] <aude>	 makeTitle probably is ok though
[23:04:45] <benestar>	 aude: but we still call Interwiki::fetch
[23:04:54] <benestar>	 so this does not really help us
[23:09:39] <aude>	 hmmm
[23:11:05] <benestar>	 aude: ok, I found something
[23:11:18] <benestar>	 actually TestSites.php would add the interwiki links
[23:11:27] <benestar>	 but they do not get saved in the db
[23:11:48] <aude>	 $title->getInterwiki(); gives me 'en'
[23:11:52] <aude>	 all we need
[23:12:06] <benestar>	 aude: hmm, where?
[23:12:17] <aude>	 then the interwiki-siteid lookup would get enwiki
[23:12:27] <aude>	 $title = Title::makeTitle( NS_MAIN, 'Cake', $fragment = '', $interwiki = 'en' ); 
[23:12:33] <aude>	 as example
[23:12:45] <aude>	 errr
[23:13:12] <aude>	 $title = Title::makeTitle( NS_MAIN, 'Cake', '', 'en' ); 
[23:13:18] <benestar>	 aude: hmm, this does not work on my local client
[23:13:34] <aude>	 i did that in maintenance/eval.php
[23:13:35] <benestar>	 but additionally I don't know if the table is populated on jenkins?
[23:14:22] <aude>	 works with interwiki table truncated
[23:14:29] <aude>	 then it doesn't matter
[23:14:40] <benestar>	 aude: that's not possible
[23:14:43] <aude>	 table is not populated on jenkins
[23:14:51] <aude>	 why?
[23:14:55] <benestar>	 $title = Title::makeTitle( NS_MAIN, 'Cake', ”, 'en' );  of course works
[23:15:04] <benestar>	 but Interwiki::fetch( 'en' ) won't work
[23:15:06] <aude>	 $title->getInterwiki() == 'en'
[23:15:18] <aude>	 we don't need fetch
[23:15:27] <benestar>	 aude: so what to use then?
[23:15:43] <aude>	 we need the site store / site list / something to provide lookup of interwiki to site id
[23:16:21] <benestar>	 aude: is there something like that?
[23:16:22] <aude>	 (cached in memcached and/or cdb or both)
[23:16:24] <benestar>	 I fear not...
[23:16:28] <aude>	 not yet but need it
[23:16:33] <benestar>	 :/
[23:16:41] <aude>	 we can't assume site id === wiki id
[23:16:42] <benestar>	 that becomes too much for one patch
[23:16:48] <aude>	 true
[23:16:59] <benestar>	 maybe you create a bug for that so it can be discussed 
[23:17:02] <aude>	 langlinkhandler also needs that functionality and currently does evil hacks around it
[23:17:59] <benestar>	 aude: you mean getSiteByNavigationId?
[23:18:04] <aude>	 yes
[23:18:15] <aude>	 that should be moved to core probably
[23:18:32] <aude>	 and have a more efficient (cached) lookup
[23:18:36] <aude>	 especially if called often
[23:18:45] <benestar>	 aude: cached in a table?
[23:18:55] <aude>	 memcached and/or cdb
[23:19:05] <aude>	 maybe also a table
[23:19:32] <aude>	 we have site_navigation table (sp?)
[23:19:56] <benestar>	 aude: we have?
[23:20:36] <aude>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=48934
[23:20:52] <aude>	 it's site_identifiers
[23:20:54] <aude>	 (sorry)
[23:21:18] <aude>	 si_site is the db id from sites table
[23:21:31] <aude>	 could have additional column with site global id?
[23:22:58] <benestar>	 aude: this is also the table affected by the test script
[23:23:44] <benestar>	 aude: ok, so I will have a look into that tomorrow
[23:23:54] <benestar>	 perhaps making a patch for core
[23:24:11] <benestar>	 thanks for your great help :)
[23:33:41] <aude>	 back
[23:33:48] <aude>	 awww...