[00:00:19] <grrrit-wm>	 (03PS4) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[00:03:04] <hoo>	 setUpBeforeClass yikes
[00:03:40] <hoo>	 why don't you just do it in the class scope?
[00:04:09] <hoo>	 Also you should set the itemId as a non-static member in a normal setup (only once, use a static var for toggling that)
[00:04:34] <benestar>	 hoo: not I don't understand
[00:04:40] <hoo>	 which?
[00:04:45] <benestar>	 the second
[00:04:49] <benestar>	 or both
[00:05:07] <benestar>	 why does setUpBeforeClass not work?
[00:05:18] <hoo>	 function setUp() {
[00:05:19] <hoo>	 static setup= false;
[00:05:19] <hoo>	 if ( !$setup ) {
[00:05:19] <hoo>	 // Set up stuff...
[00:05:19] <hoo>	 $setup = true;
[00:05:19] <hoo>	 }
[00:05:20] <hoo>	 }
[00:05:28] <hoo>	 it does work, just not preferred
[00:05:35] <hoo>	 don't think we use it anywhere
[00:06:03] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[00:07:32] <benestar>	 hoo: is this anywhere written down?
[00:07:39] <benestar>	 I think I do everything the wrong way...
[00:07:39] <hoo>	 benestar: What?
[00:07:49] <benestar>	 when to use static vars and when not
[00:08:05] <hoo>	 Nope, you can only look at other tets
[00:09:05] <benestar>	 that's what I am trying
[00:09:13] <benestar>	 but you are telling me other ways to do it :P
[00:09:39] <hoo>	 depends on what you're looking, I guess... we're not this strong with regulating tests
[00:09:51] <hoo>	 IMO you can use static and non-static wherever you want
[00:10:38] <benestar>	 hoo: what I do not understand is why this test fails now: http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/250/console
[00:10:51] <benestar>	 anyhow the id field is wrong
[00:11:57] <hoo>	 probaby
[00:12:13] <grrrit-wm>	 (03PS5) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[00:12:22] <benestar>	 hoo: but it shouldn't ...
[00:12:31] <benestar>	 hoo: maybe the site "dewiki" is not known...
[00:12:47] <benestar>	 do you know which sites are known to jenkins?
[00:12:52] <hoo>	 TestSites::insertIntoDB
[00:12:55] <hoo>	 you do that, no?
[00:13:19] <hoo>	 * TestSites::insertIntoDb()
[00:15:04] <benestar>	 hoo: ah, that sounds good
[00:15:07] <benestar>	 thx
[00:15:15] <hoo>	 ;)
[00:17:56] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[00:18:04] <benestar>	 hoo: I hope the next patch set works so that you can +1 :)
[00:18:42] <hoo>	 I'll even merge it, if I like it :P
[00:18:54] <benestar>	 nope, doesn't work
[00:19:33] <benestar>	 hoo: how can I get more detailed information about assertTag ?
[00:20:20] <hoo>	 http://phpunit.de/manual/3.7/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.assertions.assertTag
[00:22:20] <benestar>	 hoo: I meant about the failure of assertTag...
[00:22:32] <benestar>	 it doesn't say which value failed
[00:25:08] <hoo>	 sounds like "$matchers['id']['attributes'] = array(" failed
[00:26:02] <benestar>	 hoo: maybe jenkins does not know that the page "Wikidata" exists on dewiki
[00:26:18] <benestar>	 is there another magic class for that?
[00:27:07] <hoo>	 benestar: That's not an issue, the normalization stuff is being "mocked" in tests
[00:27:27] <benestar>	 hoo: hmm? what means "mocked"?
[00:27:51] <hoo>	 It doesn't call out to external pages, it just normalizes titles locally
[00:28:01] <hoo>	 so they are being taken as valid
[00:28:02] <benestar>	 ah, ok
[00:28:30] <grrrit-wm>	 (03PS6) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[00:28:40] <benestar>	 hoo: maybe you see a bug
[00:28:43] <benestar>	 I go to bed now
[00:28:51] <benestar>	 cu and thanks for your help :)
[00:29:32] <hoo>	 benestar: Ok, maybe I'll amend it myself
[00:34:17] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[00:37:55] <grrrit-wm>	 (03CR) 10Bene: [C: 04-1] "Still fails, but don't know why." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[01:19:05] <grrrit-wm>	 (03PS7) 10Hoo man: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[01:20:00] <grrrit-wm>	 (03CR) 10Hoo man: "Amended this, passes now (also Style changes)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[01:24:35] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[02:20:50] <grrrit-wm>	 (03PS8) 10Hoo man: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[02:23:19] <grrrit-wm>	 (03CR) 10Hoo man: "Fixed the tests and other tests which had side effects on this test." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[02:26:25] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[02:48:26] <grrrit-wm>	 (03PS9) 10Hoo man: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[02:54:12] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[03:10:41] <grrrit-wm>	 (03PS10) 10Hoo man: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[03:14:53] <gangleri_back>	 Hi! https://www.wikidata.org/wiki/Q1650668 has two confirmed (sourced) birthdates
[03:14:54] <grrrit-wm>	 (03CR) 10Hoo man: "Made this work even if we have side effects now" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[03:15:51] <hoo>	 gangleri_back: Easy one... just remove one (like I just did for that item)
[03:16:25] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[07:29:11] <grrrit-wm>	 (03CR) 10Bene: [C: 04-1] "Some minor problems and one serious. Mixing string and ItemId up." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[09:09:16] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore)
[09:32:06] <sjoerddebruin>	 Morning
[16:42:52] <GerardM->	 can someone give me an example of a ranked item ?
[16:43:13] <GerardM->	 or better ... an item with a ranked statement
[17:44:58] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 86.135.251.105 link https://www.mediawiki.org/w/index.php?diff=897318 edit summary: [-134] 
[17:45:24] <wm-bot>	 Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by 86.135.251.105 link https://www.mediawiki.org/w/index.php?diff=897320 edit summary: [+8] 
[20:33:54] <JeroenDeDauw>	 DanielK_WMDE: :D You win one free interwebs
[21:04:46] <github-wmde>	 [13WikibaseDatabase] 15JeroenDeDauw opened pull request #10: Created PDO based standalone implementation of QueryInterface (06master...06standalone) 02http://git.io/4Gv8Uw
[21:07:22] <JeroenDeDauw>	 addshore: revieeeewwwwwww https://github.com/wmde/WikibaseDatabase/pull/10
[21:07:25] <JeroenDeDauw>	 :D
[21:08:32] <addshore>	 well I am definatly not looking at that right now JeroenDeDauw :P
[21:08:39] <addshore>	 tommorrww!!!!
[21:18:26] <JeroenDeDauw>	 addshore: just click merge. It' less then 2k line anyway 
[21:25:32] <JeroenDeDauw>	 addshore: ah I see, you are bussy eating cake - carry on
[21:31:19] <grrrit-wm>	 (03PS11) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[21:34:10] <benestar>	 hoo: pls merge :D
[21:36:50] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[21:36:56] <benestar>	 :O
[21:37:03] <benestar>	 this worked on my local device ...
[21:38:58] <grrrit-wm>	 (03PS12) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[21:39:11] <benestar>	 I hope Q3552127832535 will never be reached
[21:40:59] <JohnLewis>	 benestar: You could set it to Q0..
[21:41:14] <benestar>	 JohnLewis: is that a valid item id?
[21:41:16] <benestar>	 I fear not
[21:41:28] <JeroenDeDauw>	 Not allowed since a few months
[21:41:44] <JohnLewis>	 :/
[21:42:22] <benestar>	 JohnLewis: pattern: /^q[1-9][0-9]*$/i
[21:43:06] <benestar>	 JeroenDeDauw: you have to better feed WikidataJenkins :P
[21:43:19] <benestar>	 it works for 5 min
[21:44:33] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[21:49:46] <grrrit-wm>	 (03PS13) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[21:55:09] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[21:55:22] <benestar>	 hey, great :D
[21:57:38] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: Create more tests for Special:SetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[21:58:06] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "And this time no merging until the issue is fixed please" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[21:58:47] <benestar>	 JeroenDeDauw: then we have to fix ChangeOpSitelink, too
[21:58:56] <benestar>	 should I do this in the same patch ?
[21:58:59] <JeroenDeDauw>	 JohnLewis: benestar: this is dennyvrandecic_ his fault :)
[21:59:23] <JeroenDeDauw>	 benestar: if it i already merged, I suggets you create a dedicated commit
[21:59:32] <JeroenDeDauw>	 Which can then be merged right away
[21:59:36] <benestar>	 hm, ok
[22:02:33] <benestar>	 JeroenDeDauw: so you mean WikibaseRepo::getDefaultInstance()->getSettings() ?
[22:04:54] <JeroenDeDauw>	 benestar: yes
[22:05:09] <JeroenDeDauw>	 that is bad in itself, though less so then using Settings
[22:07:59] <grrrit-wm>	 (03PS1) 10Bene: Removed deprecated use of class Settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110888 
[22:08:36] <JeroenDeDauw>	 DanielK_WMDE: is ChangeNotificationJob needed by repo at all? Or just by client?
[22:08:55] <benestar>	 JeroenDeDauw: from smoke to smother ;)
[22:09:32] <benestar>	 but the other direction :)
[22:09:36] <JeroenDeDauw>	 benestar: not much you can help the issue in this case - the production code you are testing is just bad
[22:09:59] <benestar>	 JeroenDeDauw: you mean the whole repo code or what?
[22:12:32] <grrrit-wm>	 (03PS14) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[22:13:26] <Vogone>	 oha benestar
[22:13:36] <benestar>	 Vogone: hoi
[22:13:39] <benestar>	 whatsup?
[22:13:50] <Vogone>	 du hast WhatsApp?
[22:13:53] <Vogone>	 Nr?
[22:14:21] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110888 (owner: 10Bene)
[22:14:28] <benestar>	 Vogone: nein, meinte what's up :P
[22:14:33] <benestar>	 :DD
[22:14:36] <Vogone>	 s'geht jut … und mit dir?
[22:14:48] <benestar>	 endlich mal mag jenkins mich ;)
[22:15:01] <benestar>	 Vogone: jup, mir gehts auch ganz annehmbar
[22:15:04] <Vogone>	 Glückwunsch zum Build Successful, brw
[22:15:08] <Vogone>	 *btw
[22:15:13] <Vogone>	 *akzeptabel
[22:15:37] <Vogone>	 akzeptabel is das Jugendwort des Jahres 2014
[22:15:44] <benestar>	 Vogone: :O
[22:15:55] <benestar>	 wusst ich garnicht xD
[22:16:17] <benestar>	 find ich aber ganz akzeptabel :P (der ist schlecht, ich weiß)
[22:16:38] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Removed deprecated use of class Settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110888 (owner: 10Bene)
[22:16:48] <benestar>	 JeroenDeDauw: thx
[22:16:49] <JeroenDeDauw>	 benestar: thnx for fixing that
[22:16:58] <benestar>	 your welcome 
[22:17:03] <benestar>	 * you're
[22:18:56] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[22:19:02] <benestar>	 yey :D
[22:19:17] <benestar>	 JeroenDeDauw: also want to merge this one?
[22:19:32] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] Create more tests for Special:SetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[22:19:59] <hoo>	 didn't I amend that tonight? ...
[22:20:22] <benestar>	 hoo: yes, but that is not needed
[22:20:39] <benestar>	 the setting has to be changed anyways a test depends on it
[22:20:49] <benestar>	 and otherwise it can be what it is
[22:20:54] <benestar>	 as it isn't used
[22:21:02] <hoo>	 Yes, let's just do insane things ...
[22:21:03] <hoo>	 no
[22:21:15] <benestar>	 hoo: no to what?
[22:21:38] <hoo>	 don't alter settings permanently in a test. PERIOD
[22:22:13] <benestar>	 ok ok
[22:22:23] <benestar>	 hoo: and what about the other tests
[22:22:27] <benestar>	 change them, too?
[22:22:33] <benestar>	 or create a new commit for them?
[22:23:06] <hoo>	 benestar: New commit
[22:23:14] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: use getcwd rather than doing an exec of pwd [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110889 
[22:23:15] <hoo>	 Gnah
[22:24:21] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] use getcwd rather than doing an exec of pwd [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110889 (owner: 10Jeroen De Dauw)
[22:24:23] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Remove bad test case [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110890 
[22:24:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: use getcwd rather than doing an exec of pwd [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110889 (owner: 10Jeroen De Dauw)
[22:24:42] <hoo>	 getcwd acts "funny" with some permissions on parent directories...
[22:24:42] <grrrit-wm>	 (03PS15) 10Bene: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 
[22:25:24] <benestar>	 hoo: are you happy now?
[22:26:18] <hoo>	 $settings = WikibaseRepo::getDefaultInstance()->getSettings(); would ahve made it a lot more readable, but yes :)
[22:26:38] <hoo>	 If Jenkins approves, I'll go for it
[22:26:38] <benestar>	 hoo: ask JeroenDeDauw :P
[22:26:45] <hoo>	 about?
[22:26:57] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Remove unused and deprecated getEntityIdParser from LibRegistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110891 
[22:27:14] <benestar>	 <benestar>	JeroenDeDauw: so you mean WikibaseRepo::getDefaultInstance()->getSettings() ?
[22:27:16] <benestar>	 <JeroenDeDauw>	benestar: yes
[22:27:21] <benestar>	 hoo --^
[22:27:29] <hoo>	 what's what I said :P
[22:27:45] <hoo>	 Just didn't want you to use endless long lines :P
[22:28:01] <benestar>	 hoo: don't understand now ...
[22:28:17] <hoo>	 $settings = WikibaseRepo::getDefaultInstance()->getSettings(); 
[22:28:26] <benestar>	 lol, ok
[22:28:33] <hoo>	 and then you can act on $settings like you did on the WikibaseRepo::getDefaultInstance()->getSettings()
[22:29:00] <benestar>	 that's obvious
[22:29:48] <benestar>	 hoo: do you give -1 for that?
[22:30:33] <hoo>	 nope
[22:30:40] <hoo>	 As I said, just waiting for Jenkins
[22:30:43] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110889 (owner: 10Jeroen De Dauw)
[22:31:27] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Remove unused and deprecated getEntityIdParser from LibRegistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110891 (owner: 10Jeroen De Dauw)
[22:31:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused and deprecated getEntityIdParser from LibRegistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110891 (owner: 10Jeroen De Dauw)
[22:32:10] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Remove Libregistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110892 
[22:32:59] <hoo>	 JeroenDeDauw: yikes, that's ugly
[22:33:14] <sjoerddebruin>	 Help? I can’t switch to Dutch anymore.
[22:33:22] <sjoerddebruin>	 Stuck in French...
[22:33:47] <benestar>	 sjoerddebruin: https://www.wikidata.org/wiki/?setlang=nl
[22:34:01] <hoo>	 sjoerddebruin: No French teachers over here, I guess :D Tried it via your user preferences, yet?
[22:34:21] <sjoerddebruin>	 And back in Dutch again before clicking on your link benestar.
[22:34:36] <sjoerddebruin>	 I don’t know what happened… :|
[22:34:45] <hoo>	 sjoerddebruin: that bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60715 ?
[22:35:01] <benestar>	 hoo: jenkins is stuck :/
[22:35:02] <hoo>	 I hope that someone reviews my patch tomorrow, so that we can hopefully solve it soon
[22:35:08] <hoo>	 benestar: Link to the job?
[22:35:12] <sjoerddebruin>	 I think hoo...
[22:35:43] <benestar>	 hoo: hmm?
[22:35:45] <hoo>	 sjoerddebruin: I guess that tomorrow someone will have the time to review my change, and then we can deploy it ;)
[22:36:00] <hoo>	 benestar: to the jenkins job... so that I can see its state
[22:36:06] <sjoerddebruin>	 I’m already happy with the latest bug fixes btw.
[22:36:16] <sjoerddebruin>	 Oh, it’s happening again.
[22:36:18] <sjoerddebruin>	 On https://www.wikidata.org/wiki/Q6255676
[22:36:25] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110890 (owner: 10Jeroen De Dauw)
[22:36:37] <hoo>	 sjoerddebruin: Yep, that's the bug...
[22:36:37] <benestar>	 hoo: http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/264/
[22:36:48] <hoo>	 We already have the fix, just takes someone to reviewit ;)
[22:36:50] <hoo>	 * review it
[22:37:07] <sjoerddebruin>	 Damn.
[22:37:27] <benestar>	 hoo: Creating main page with default content <-- there he hangs
[22:37:48] <hoo>	 not the one you linked
[22:37:51] <benestar>	 ok, working again
[22:38:19] <JeroenDeDauw>	 hoo: why is UpdateRepoOnMoveJob in lib?
[22:38:24] <benestar>	 yes, teh link was wrong, sorry
[22:38:28] <JeroenDeDauw>	 Looks like it should be in client
[22:38:31] <benestar>	 hoo: meant http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/264/console
[22:38:34] <hoo>	 JeroenDeDauw: Because the job queue sucked (TM)
[22:38:52] <JeroenDeDauw>	 sjoerddebruin: oh, the horror! :)
[22:39:04] <JeroenDeDauw>	 hoo: is there any reason for it to be there now?
[22:39:10] <sjoerddebruin>	 I want to TERMINATE all the descriptions. :(
[22:39:16] <sjoerddebruin>	 But can’t do three of them.
[22:39:33] <hoo>	 JeroenDeDauw: Yep, that I didn't yet refactored it :P Aaron already changed the Job Queue, but that requires us to refactor
[22:39:39] <hoo>	 * refactor
[22:40:28] <JeroenDeDauw>	 hoo: please explain why it cannot be moved now
[22:40:33] <JeroenDeDauw>	 I only ee usage of it in client
[22:40:36] <hoo>	 JeroenDeDauw: Because it will break?
[22:40:42] <JeroenDeDauw>	 Why?
[22:40:44] <hoo>	 It's meant to be run on Wikidata.org
[22:40:50] <hoo>	 and Client's not installed there, right
[22:41:11] <hoo>	 Client injects it into the repo's queue, repo then run sit
[22:41:13] <hoo>	 * runs it
[22:41:32] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[22:41:40] <benestar>	 hoo: :DD
[22:42:19] <JeroenDeDauw>	 hoo: ok, thnak for explaining
[22:42:27] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[22:42:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create more tests for Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110825 (owner: 10Bene)
[22:42:48] <hoo>	 JeroenDeDauw: Maybe I can spend some time on that this week, let's see... but it's not top priority right now
[22:43:08] <benestar>	 hoo: thank you :)
[22:43:50] <hoo>	 benestar: Tests which actually set sitelinks would be awesome :) I know that writing tests for special pages can be a little icky
[22:44:16] <benestar>	 hoo: yup
[22:44:22] <hoo>	 at least that would have caught the last almost-fatal deploy
[22:44:29] <sjoerddebruin>	 Again three I can’t do: http://tools.wmflabs.org/wikidata-terminator/index.php?lang=nl&term=John+Middleton&doit=1
[22:44:41] <benestar>	 hoo: no, that would be caught be my patch, too
[22:45:24] <benestar>	 well, cu
[22:45:53] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110891 (owner: 10Jeroen De Dauw)
[22:49:06] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0cb01cd : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/18098894
[22:50:19] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110892 (owner: 10Jeroen De Dauw)
[22:54:09] <JeroenDeDauw>	 addshore: did you see my question at https://github.com/wmde/WikibaseDataModelSerialization/pull/5 ?
[23:36:13] <Lydia_WMDE>	 hoo: re talk: i think it went very well - people liked it :)
[23:36:26] <hoo>	 \o/
[23:36:38] <hoo>	 Siebrand posted a pic...
[23:36:50] <hoo>	 looks like the interest was high :)
[23:37:17] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Prevent new usage of deprecated Settings class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110893 
[23:38:18] <Lydia_WMDE>	 yeah
[23:38:32] <hoo>	 Lydia_WMDE: Will Daniel be in the office tomorrow?
[23:38:48] <hoo>	 As always I'll be around early tomorrow (unless I oversleep :P)
[23:38:56] <Lydia_WMDE>	 i think the day after tomorrow
[23:39:03] <hoo>	 Ok, good enough
[23:40:28] <JeroenDeDauw>	 he ran away :(
[23:40:42] <JeroenDeDauw>	 hoo: meeeergeeee https://gerrit.wikimedia.org/r/#/c/110893/
[23:40:49] <JeroenDeDauw>	 (and yes, you are the new benestar now)
[23:41:56] <hoo>	 JeroenDeDauw: If Jenkins likes it, I can merge it ;)
[23:42:49] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110893 (owner: 10Jeroen De Dauw)
[23:43:32] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Kill all the bogus dependencies \o/ (later on...)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110893 (owner: 10Jeroen De Dauw)
[23:43:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent new usage of deprecated Settings class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110893 (owner: 10Jeroen De Dauw)
[23:51:03] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/8eb7dcb : jeroendedauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/18101517
[23:52:28] <JeroenDeDauw>	 huh?
[23:52:49] <hoo>	 JeroenDeDauw: Don't let travis fool you :P