[00:06:42] TypeError: snak.getValue is not a function [00:06:47] dependencies again, I geuss [00:09:32] Lydia_WMDE: ceiling cat is already watching you, now answer the question! :<0 [00:11:02] " TODO: This whole file along with its resource loader module should be be removed" [00:12:04] aude: thx for putting important stuff on the deployment page for the announcement. will try to help in the future [00:13:05] I am sorry for being the first one to add a quantity value to Wikidata, but it was taking to long and I was curious if it works :) [00:13:05] aude: Around? [00:13:47] dennyvrandecic_: it's ok. you can have the honor ;-) [00:14:36] ui. why did it become a statement at the top? curious [00:14:39] Lydia_WMDE: That JS bug is a little hairy [00:14:45] Q922 [00:14:57] dennyvrandecic_: bug with ordering -.- [00:15:02] unrelated to quantities [00:15:06] oh, ok [00:15:11] we need to clean up the ordering mess [00:15:15] hoo: ? [00:15:33] Lydia_WMDE: The one dennyvrandecic_ reported earlier [00:15:51] Thought it was dependencies again, but this time it's not that easy [00:16:08] meh [00:16:18] i better stop poking around in Wikidata for now ;) [00:16:20] how widespread? [00:16:29] dennyvrandecic_: yes! all your fault ;-) [00:16:38] I know :) [00:17:09] Lydia_WMDE: I'm going to build a huge http://upload.wikimedia.org/wikipedia/commons/c/cb/Replica_catapult.jpg if you don't answe my question! [00:17:26] And I'll shoot kittens with it, which will be very angy when they land on your head [00:17:55] JeroenDeDauw: yes, you are allowed to enter over9000 as a quantity value. unfortunately, you cannot do it. [00:17:59] JeroenDeDauw: don't forget that i will see you latest on saturday in a crowd of 7000 geeks [00:18:04] :P [00:18:16] also what dennyvrandecic_ said [00:19:06] * hoo rages [00:20:09] debugging things I didn't write on the live site *check* [00:20:41] huh - what did dennyvrandecic_ say? [00:23:28] 01[13Geo01] 15JeroenDeDauw tagged 060.1.2 at 06master: 02http://git.io/AlV_JA [00:26:15] hah, got the bug! [00:27:07] JeroenDeDauw: 0:17 JeroenDeDauw: yes, you are allowed to enter over9000 as a quantity value. unfortunately, you cannot do it. [00:27:50] hoo: \o/ [00:28:12] Lydia_WMDE: Not yet the fix, though :P [00:28:24] finding it is a first step ;-) [00:28:28] an important one [00:28:31] JohnFLewis: ok, I'm blind, I thought Lydia_WMDE had typed that [00:28:37] Who invented novalue snaks in the first place? :D [00:28:50] * Lydia_WMDE hands JeroenDeDauw a pair of glasses [00:29:00] * Lydia_WMDE looks at dennyvrandecic_ and markus [00:29:04] Lydia = Denny... ofc! Succession of the position! [00:29:12] hoo: wht is the problem with thi snak? [00:29:52] yah. it was us [00:30:02] JeroenDeDauw: People assume it to have a value... [00:30:04] Lydia_WMDE: I'm to bussy constructing that catapult to read IRC you know [00:30:20] JeroenDeDauw: but but but! you have your answer [00:30:25] uhm.... it is call NoValueSnak... :D [00:30:31] hoo: its name implies it does not have one? [00:30:35] lol [00:30:38] hoo: are you complaining about the UI? [00:30:46] JeroenDeDauw: Yep :P [00:31:10] hoo: I have too in the past. Assuming Lydia_WMDE remembers what I said about the UI. [00:31:19] im away [00:31:29] lol [00:31:38] hoo: who needs the UI anyway, I suggest we ditch it and concentrate on the domain model. Much more fun [00:31:47] <3 [00:32:01] JeroenDeDauw: Agreed, get rid the UI and use api :D [00:32:06] * Lydia_WMDE points at a few thousand users who need it [00:32:42] Lydia_WMDE: And? We lose a few thousand users. As long as the devs are happy :p [00:33:44] JohnFLewis: i have slightly higher ambitions for wikidata ;-) [00:33:55] just slightly but still [00:34:01] :p [00:34:51] Lydia_WMDE: I think I have a fix, but can't tests, as my testwiki is broken :/ [00:35:12] Well I am going to get off and spam Wikidata in the morning :p cya [00:35:18] hoo: ok - great - maybe JeroenDeDauw can or wait for aude to come back? [00:35:25] night JohnFLewis [00:47:52] Lydia_WMDE: Hah :) [00:48:00] Looks like my fix is going to work [00:48:04] \o/ [00:48:09] Not having a owrking local wiki aint no fun :P [00:48:09] awesome [00:48:16] yeah :/ [00:48:41] (03PS1) 10Hoo man: Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110480 [00:48:51] JohnFLewis: to me the API is not much different from the API. Both are in the evil presentation layer [00:48:59] Lydia_WMDE: Anyone around to review etc.? [00:49:19] hoo: only aude later and JeroenDeDauw now i believe [00:49:20] I can get it deployed, but need it merged first [00:49:25] JeroenDeDauw: ^ [00:49:30] arrr [00:49:31] Hot fix... [00:51:01] (03CR) 10Jeroen De Dauw: [C: 04-1] "check that type == value. Else you have the same issue for somevalue snaks" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110480 (owner: 10Hoo man) [00:51:18] The code in that file looks suspect [00:51:24] JeroenDeDauw: Some value snaks also don#t have getValue() ? mh [00:51:28] COuld use some refactoring [00:51:42] hoo: only value snaks have a value [00:51:45] JeroenDeDauw: You're right [00:51:54] Got that wrong in my head... [00:52:24] (03PS2) 10Hoo man: Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110480 [00:53:21] JeroenDeDauw: ^ [00:55:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110480 (owner: 10Hoo man) [00:55:15] (03PS1) 10Hoo man: Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110481 [00:56:37] JeroenDeDauw: Any further concerns? [00:58:19] * hoo would like to have that merge, make the branch and deploy... [01:00:19] Lydia_WMDE: Or do you want to merge? :P [01:00:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110480 (owner: 10Hoo man) [01:00:49] hoo: i'd love to but i shouldn't merge stuff i can't really sign off on [01:01:23] Also understandable... [01:01:35] * hoo will stay around a bit more... doing some Scribunto fixes [01:03:22] :) [01:04:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110481 (owner: 10Hoo man) [01:08:16] (03CR) 10Jeroen De Dauw: [C: 032] Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110480 (owner: 10Hoo man) [01:10:50] (03CR) 10Hoo man: [C: 032 V: 032] "Already merged on master" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110481 (owner: 10Hoo man) [01:12:23] back [01:12:30] aude: :) [01:12:32] do we need a new build? [01:12:58] aude: I'm on it [01:13:23] ok [01:13:37] aude: If I run composer update it also pulls in some datavalues changes :/ [01:13:43] we need build for master and the branch (same thing) [01:13:56] i guess tomorrow we use addshore's thing for beta [01:15:54] (03PS1) 10Hoo man: Add "Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110485 [01:15:56] (03CR) 10jenkins-bot: [V: 04-1] Add "Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110485 (owner: 10Hoo man) [01:15:59] aude: ^ [01:16:40] rebase conflict... wtf [01:16:49] ooh, it submitted against amster [01:17:18] hmm [01:17:30] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e7f19ea : Marius Hoch The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17949076 [01:17:37] (03PS1) 10Hoo man: Update Wikibase [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110486 [01:17:51] aude: ^ [01:18:25] I was able to make it not pull a new datavalues ;) [01:18:34] ok [01:19:01] (03CR) 10Aude: [C: 032] Update Wikibase [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110486 (owner: 10Hoo man) [01:19:04] looks fine [01:19:55] (03PS2) 10Hoo man: Update Wikibase [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110485 [01:20:05] same against master ^ [01:20:10] k [01:20:37] (03CR) 10Aude: [C: 032] Update Wikibase [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110485 (owner: 10Hoo man) [01:22:08] * hoo waits for Jenkins... [01:22:31] ... [01:22:45] (03Merged) 10jenkins-bot: Update Wikibase [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110486 (owner: 10Hoo man) [01:22:51] ah, there we go [01:24:17] * Lydia_WMDE finally goes to bed now [01:24:21] :* [01:24:22] Lydia_WMDE: :) [01:24:26] I should so also :P [01:24:33] Awake now... yay jetlag [01:24:39] aude: https://gerrit.wikimedia.org/r/110488 [01:24:47] hoo: go to bed even if you lie there awake [01:24:50] ;-) [01:25:00] otherwise you'll not get back to normal for way too long [01:25:11] too quick [01:25:21] aude: ... [01:25:29] Sorry, didn't know you were on that also [01:25:52] :) [01:26:20] now to find someone to deploy it [01:26:25] Yep :/ [01:26:41] We really need our shell thingies sorted completely ... [01:27:54] Reedy: ^ [01:27:54] (03Merged) 10jenkins-bot: Update Wikibase [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110485 (owner: 10Hoo man) [01:34:56] aude: Reedy probably isn't around... want to poke someone else? [01:35:25] yeah [01:35:35] seems rather quiet [01:39:12] * aude goes back to reddit [01:40:35] aude: fyi, localization update also is broken [01:40:45] in what way? [01:40:46] that's why we have those broken data type string [01:40:55] VE broke it [01:41:03] submodules... [01:41:08] it's not us... but the updater can't run through atm [01:41:17] mmm [01:41:29] http://p.defau.lt/?iO7VNWKrhZmOJwAVPgi9UA [01:42:11] and translate? [01:42:17] yes [01:42:21] sorry forgot taht [01:47:15] Away for now... [01:47:35] Hope you find someone to deploy before users go crazy :P [01:48:09] ok [01:48:52] I WANT MY TRANSLATED MESSAGES FIXED [01:48:53] :P [01:49:09] :) [01:56:52] looks like the problem is with i18n json files [02:04:58] (03PS1) 10Aude: include extension entry points instead of i18n files in config [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110494 [02:08:31] (03PS1) 10Aude: include extension entry points instead of i18n files in config [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110497 [02:08:33] (03CR) 10jenkins-bot: [V: 04-1] include extension entry points instead of i18n files in config [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110497 (owner: 10Aude) [02:08:53] (03CR) 10Aude: [C: 032] "should be fine, shall try on beta" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110494 (owner: 10Aude) [02:10:07] (03PS2) 10Aude: Include extension entry points instead of i18n files in config [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110497 [02:11:28] (03Merged) 10jenkins-bot: include extension entry points instead of i18n files in config [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110494 (owner: 10Aude) [02:16:39] back [02:17:11] aude: Deployed yet? [02:18:03] no [02:18:36] but figured out that data values / types is not in the i18n files [02:18:41] aude: Shall I amend my patch to ship the above? [02:18:52] if both my patches merge, yes [02:19:20] (03CR) 10Aude: [C: 032] Include extension entry points instead of i18n files in config [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110497 (owner: 10Aude) [02:19:29] i can try localisation on beta [02:21:56] (03Merged) 10jenkins-bot: Include extension entry points instead of i18n files in config [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110497 (owner: 10Aude) [02:25:38] think the change is ok [02:25:59] aude: Tested on beta? [02:26:12] much as i can [02:26:26] caches are fresh so it's not rebuilding everything [02:26:36] but what it generates looks sane [02:28:08] aude: How do you rebuild the cache after all? Just using the maint. script? [02:28:39] sudo -u mwdeploy mw-update-l10n --verbose [02:28:41] on labs [02:28:53] ah :) [02:28:58] production might be slightly different [02:29:16] I'll check everything twice before running anything on production at first :P [02:29:24] I don't want to be that guy ... [02:29:29] it makes ExtensionMessages-master.php [02:29:57] result of mergeMessageFileList.php [02:30:13] should list everything... the one in production is missing data values, on labs it's there [02:31:09] probably because $wgExtensionEntryPointListFiles actually needs to have entry points, not just list i18n files (although sometimes that also is ok) [02:32:47] inconsistencies are fun -.- [02:32:53] yep [02:33:06] missing messages however don't break things fatally [02:33:13] messages are just missing... [02:33:33] having things listed in extension messages that actually can't be found can cause major issues [02:36:33] yep... [02:55:01] seems like no one is around :( [02:56:14] aude: I tried Tim... guess he's around... not sure about time though [02:56:25] ori maybe [02:59:56] Why not :P [03:01:50] aude: Going to bed now... would nice to get this deployed until European morning... before the majority of our users notices it :P [03:02:20] :/ [03:03:53] Sucks that even hot fixes take hours to deploy if no one is really around [03:04:23] At this time of the day probably only Tim is around, cause he's in Australia :P [03:04:51] he does it \o/ [03:05:19] yay [03:18:29] aude: Off now... you can verify the JS fix on the Item for "Germany" later on [03:18:44] if you can add a new statement we fixed it, if not *grbml* [03:19:00] ok [05:44:53] https://www.wikidata.org/wiki/Q6581072 (female) is now showing me the 'or' language label & description at the top [06:58:12] jayaway: yes - we try to offer you some more languages ULS thinks you might speak [06:58:17] add a babel box to your user page [06:58:25] then it will take those languages [06:59:23] anyone up for updating the news section on the main page? [07:11:46] Lydia_WMDE: I think it has a caching problem [07:12:11] because it was showing me someone elses prefer languages in 'In other languages' [07:12:49] I had to do a ?action=purge to get rid of the previous editors preferences [07:29:55] interesting [07:30:01] need to investigate [08:29:21] [13WikibaseDataModelSerialization] 15Tpt opened pull request #5: Adds beggining of Claim serialization (06master...06claim) 02http://git.io/F3dnuA [09:01:08] moin [09:01:16] hm, no Henning? [09:01:33] Lydia_WMDE: ich seh einen JS fehler auf https://www.wikidata.org/wiki/Q38 [09:01:48] in FF: TypeError: snak.getValue is not a function [09:02:23] Adrian_WMDE, Lydia_WMDE: is this known, or shall i file a bug? [09:10:24] Hi DanielK_WMDE [09:10:34] I'm the only one in office [09:11:12] again, im seeing the wrong language here : https://www.wikidata.org/wiki/Q36774 [09:11:30] should be English, Indonesian. Im seeing German as the default [09:12:50] Adrian_WMDE: everyone else is off to FOSDEM?... [09:12:57] Or off to bed [09:12:59] Adrian_WMDE: can you confirm the JS error? do you know about it? [09:13:21] * DanielK_WMDE wants to take a nap too - 6:30 is not a good time to get up. [09:13:25] DanielK_WMDE: I don't see a JS error in Iceweasel [09:13:33] 6:30 is the only time to get up [09:13:45] hehe. having kids is so much fun. [09:14:02] Adrian_WMDE: on Q38? [09:14:12] Chromium has an error for me [09:14:19] NoValueSnak::getType [09:15:09] Adrian_WMDE: that error is different from the one I reported, but simmilar: some code seems to assume all Snaks are Value snaks. [09:15:25] only ValueSnaks havew getValue and getType. SomeValueSnak and NoValueSnak doN#t. [09:15:55] i'll report it [09:15:56] DanielK_WMDE: Was there a deployment in the last few days? [09:16:30] AH, sure [09:16:34] It's Quantities [09:16:38] I'm still out of the loop, but since Lydia announced that we now have Quantities live, i'd say yes - yesterday. [09:16:50] right [09:18:23] DanielK_WMDE: I can fix the code, but I don't know the process works after that [09:18:36] *don't know how the process works [09:20:27] Adrian_WMDE: once the patch is merged, you backport (cherry-pick) it to the current deployment branch. Then ask Reedy or Chad to deploy it. Usually, Katie or Tobi do this after testing. [09:20:45] Ok [09:21:29] Adrian_WMDE: NoValueSnak::getType is PHP syntax - is this really a JS error? [09:22:22] DanielK_WMDE: Yeah, that's just me using a non-JS syntax [09:22:31] For talking to you [09:23:08] ah ok. [09:23:13] reproduced it now. [09:24:14] (03PS6) 10Adrian Lang: Support formatting commons media links via API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 [09:24:16] (03PS1) 10Adrian Lang: Support data types and output formats in API-based formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110521 [09:25:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=60670 [09:25:28] this is critical, as it renders the item impossible to edit. [09:26:05] I see "" on https://www.wikidata.org/wiki/Q3181407 [09:27:59] DanielK_WMDE: I'm fixing it right now [09:28:28] Reedy, aude: you around? I'm a bit out of the loop - when did we roll out new code to wikidata.org? Did wgCacheEpoch get pocked? It should have been... [09:29:25] jayvdb: quick fix is to create that message on site. but please report this on bugzilla, so we add the message for translation on translatewiki. [09:30:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 (owner: 10Adrian Lang) [09:31:08] jayvdb: hm... the message should be effectively empty, so it should probably be defined as "-" (nasty hack, that) [09:31:19] will do that now [09:33:12] hm... maybe i'm confused, and the key just changed, and it'S a parser cache issue.... grr... [09:33:19] DanielK_WMDE: there was a deployment yesterday late [09:33:32] and indeed there are some prolems with i18n cache [09:33:45] also with the parser cache, it seems [09:33:47] hm [09:34:32] jayvdb: purging the page should fix the "wrong language" issue. should only be needed once per page. would of course be better to fix it centrally. [09:35:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110521 (owner: 10Adrian Lang) [09:37:09] DanielK_WMDE: http://tools.wmflabs.org/wm-bot/logs/index.php?start=01%2F30%2F2014&end=01%2F31%2F2014&display=%23wikidata [09:37:26] starts around 2014-01-30 23:11:47 [09:38:08] lazowik: thank you [09:39:09] 2014-01-30 15:54:02 got cache epoch setting [09:39:16] so it was at least on the radar [09:39:51] jayvdb: please keep reporting issues with apges showing the wrong language [09:40:06] collect that info somewhere in addition to posing here [09:40:10] thanks! [09:40:53] afk for a bit [09:57:39] hoi has one new property for a quantity been created ? [09:57:46] just one suffices [09:58:46] addshore: JeroenDeDauw: mediawiki/core coverage is much nicer https://integration.wikimedia.org/cover/mediawiki-core/master/php/ [09:59:03] made possible by Jan Zerebecki change https://gerrit.wikimedia.org/r/#/c/90584/ [10:02:04] * hoo waves [10:06:18] hey hoo [10:06:35] hi DanielK_WMDE... just saw your bug report [10:06:47] I fixed that tonight, not sure why it's still there [10:07:22] maybe it's broken in more moduls... [10:07:38] mh [10:07:42] hoo: It's definitely broken where I'm editing now [10:07:49] scrapeFormattedValues [10:07:50] ok ok [10:08:04] 03:37 logmsgbot: tstarling started scap: mostly no-op, did a reset to revert the wikidata changes [10:08:07] what? [10:08:25] aude: ^ [10:08:27] damn [10:08:42] DanielK_WMDE: We had to wait ages for Tim to deploy and I got to bed at 4am [10:08:47] seems like something went wrong after [10:08:52] but I was no longer around [10:09:09] Adrian_WMDE: My patch isn't live [10:09:20] hoo: It's not in master, either [10:09:46] Adrian_WMDE: the patch is in master [10:09:49] or do you mean the problem? [10:10:01] hoo: The problem I'm fixing is in master [10:10:02] I fixed it in master and for the branch tonigh [10:10:06] doh [10:10:25] You didn't fix all of it :D [10:10:47] Adrian_WMDE: yikes [10:10:51] What do you think about using snak instanceof wb.PropertyValueSnak instead of getType()? [10:10:52] which file is that? [10:11:20] scrapeFormattedValues [10:11:29] instanceof in JS can be buggy in older IE depending on where the data comes from, so I rather wanted to paly safe [10:11:33] repo/resources/wikibase.ui.scrapeFormattedValues.js [10:11:36] that one I fixed [10:11:37] Yeah [10:11:45] The mainSnak on the top [10:11:50] claim.getMainSnak().getValue(), [10:11:53] ok [10:11:56] Just saw it [10:12:47] (03PS1) 10Adrian Lang: Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues once more [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110526 [10:12:59] GerardM-: yes, HDI [10:13:11] hoo: ^ [10:13:14] :) [10:13:17] What is HDI ? [10:13:23] https://www.wikidata.org/wiki/Property:P1081 [10:13:32] GerardM-: ^ [10:13:53] (03CR) 10Hoo man: [C: 032] Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues once more [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110526 (owner: 10Adrian Lang) [10:14:00] Adrian_WMDE: thinking about it, all snaks should have getType() and also something like getDataType(). Only getValue() is really problematic. [10:14:02] Human Development Index [10:14:03] (03PS1) 10Hoo man: Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues once more [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110527 [10:14:16] (03CR) 10Hoo man: [C: 032] Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues once more [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110527 (owner: 10Hoo man) [10:14:17] (03Merged) 10jenkins-bot: Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues once more [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110526 (owner: 10Adrian Lang) [10:14:22] will make a new build sonnish [10:14:24] * soonish [10:14:33] Adrian_WMDE: I also prefer instanceof checks to checks against constains. getType() is really for serialization and localization stuff. [10:14:39] (03Merged) 10jenkins-bot: Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues once more [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110527 (owner: 10Hoo man) [10:14:39] But I need to find out why tim reverted tonight [10:14:54] I wonder what exactly tim reverted, and why exactly [10:15:02] hoo: indeed [10:15:24] hoo: he should have sent mail about it :/ [10:15:30] https://gerrit.wikimedia.org/r/#/c/110507/ [10:16:00] hwo did that even happen [10:16:59] Wrong data-model version? [10:17:11] https://gerrit.wikimedia.org/r/110449 [10:17:13] doh [10:17:58] Tim is never ever going to deploy for us again :( [10:18:12] Already had to beg him hard to actually do that as he was the only one still around [10:18:45] hoo: DanielK_WMDE: again, IRC logs to the rescue [10:18:46] http://paste.tstarling.com/p/bhUBQv.html [10:18:53] http://tools.wmflabs.org/wm-bot/logs/index.php?start=01%2F30%2F2014&end=01%2F31%2F2014&display=%23wikimedia-operations [10:19:08] hoo: Did that commit just nuke the classmap? [10:19:11] @ 2014-01-31 03:31:51 [10:19:15] Adrian_WMDE: Not yours [10:19:21] Will sort this [10:19:21] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110526 (owner: 10Adrian Lang) [10:19:36] hoo: No, aude's [10:19:55] it apparently did... and addshore didn't notice [10:19:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9234c4c : Adrian Lang The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17966813 [10:20:36] oh, you got that arleady [10:20:50] ah crap [10:20:59] hoo: Well, it's just a big red bar :D [10:21:46] Adrian_WMDE: :P Didn't plan to actually do all that again today... deployment was hard enough yesterday already [10:21:58] especially as we counld hardly find someone to deploy [10:23:05] »I think every time someone asks me to deploy a really easy change because it's really really easy, it turns out to be fantastically complicated « :D [10:23:39] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110527 (owner: 10Hoo man) [10:23:48] Adrian_WMDE: that's life for you. [10:24:40] (03CR) 10Daniel Kinzler: "should there really be a composer.lock file in this commit?..." [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110449 (owner: 10Aude) [10:25:17] hoo: --^ [10:25:30] should be in gitignore i guess [10:25:51] err, or not? maybe i'm misunderstanding what this file does? [10:26:35] DanielK_WMDE: No, we actually want it [10:26:46] DanielK_WMDE: Maybe we commit that stuff on the deployment branches … [10:26:54] the whole thing is broken [10:27:01] don't use build.sh for doing builds... [10:27:04] -.- [10:27:18] You have to be very careful [10:27:42] if not for builds, what *can* it be used for?... [10:28:04] DanielK_WMDE: build.sh? for updating to a new master :P [10:28:13] but not for minor updates for deploys [10:28:29] http://ultimategerardm.blogspot.nl/2014/01/wikidata-day-pete-seeger-was-born.html calendard support using four queries happening simultaneously [10:28:32] better rename it, then [10:28:58] DanielK_WMDE: meh, we wont use that for the next branch anyway [10:29:06] and nobody except aude and /me touches it really [10:29:35] (03PS1) 10Hoo man: Fix autoloader [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110528 [10:29:39] hmhm [10:29:57] don't merge [10:30:09] will probably manually pull it onto beta [10:32:28] ah, it's not even broken on beta [10:33:18] (03Abandoned) 10Hoo man: Fix autoloader [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110528 (owner: 10Hoo man) [10:33:23]