[00:00:16] Lydia_WMDE: One empty seat? My flight back was about 30%... probably even less [00:00:23] never saw a 747 this empty [00:00:36] hmmm mine was about 75% i'd say [00:01:04] I had a row at my own and there were many rows completely empty [00:01:23] that makes traveling quite a bit more comfortable... :D [00:01:33] indeed! [00:03:36] * aude had a row to newfoundland :) [00:03:48] economy plus [00:04:06] aude: Did you book that or just took it? :P [00:04:19] got free "upgraded" [00:04:40] heh :) [00:04:46] willing to pay for it but the credit card machine was broken [00:04:48] so free [00:05:06] nice [00:05:27] and got credit for the inconvenience so could use it to upgrade the way back [00:06:08] anyway, i'm figuring out how to restructure the build so it's same as with the grunt tool [00:06:21] :) [00:06:23] mh [00:07:05] If you're stuck, you might want to push it as a draft, so that others (I) can have a look [00:07:26] might switch easyrdf to the composer version [00:07:34] then the issue is eliminated [00:07:47] we can cherry pick that one, I guess [00:07:51] shall I? [00:08:01] go ahead [00:08:17] i can't figure out how to have composer fetch the submodule [00:08:32] or if i use --prefer-source, then add all the contents of vendor etc [00:08:37] (03PS1) 10Hoo man: Handle easyrdf_lite dependency with composer [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110261 [00:08:40] :) [00:08:56] there you go [00:09:04] already merged on master, so should be good to go [00:09:15] (03CR) 10Aude: [C: 032 V: 032] "will make things much easier" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110261 (owner: 10Hoo man) [00:11:57] Lydia_WMDE: spent a coupel of days in nyc on my way back, so the löast fleight was just six and a half ours. had a row for myself, but only slept like 4. [00:12:15] my body is a bit confused. should go to sleep. [00:12:22] sounds like a good idea [00:12:38] don't make it worse by staying up [00:12:50] yeah, go to sleep! :) [00:12:56] looking at the crap i type, it would indeed ;) [00:13:03] DanielK_WMDE: :D ;) [00:13:24] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110261 (owner: 10Hoo man) [00:15:59] * Lydia_WMDE goes to bed too [00:16:02] good night folks :) [00:18:40] good night, Lydia_WMDE ;) [00:23:37] (03PS1) 10Aude: restructure to match organization of grunt build [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110269 [00:24:17] (03CR) 10jenkins-bot: [V: 04-1] restructure to match organization of grunt build [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110269 (owner: 10Aude) [00:24:30] ? [00:24:58] probably it can't find a valid entry point [00:25:01] oh, yes [00:25:29] who enabled unit tests on it? mh [00:26:38] aude: why composer update of the install? [00:26:56] (03PS1) 10Aude: restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 [00:27:14] * after [00:27:17] tired :/ [00:27:21] install doesn't update, afaik if there is a composer lock [00:27:25] (03CR) 10jenkins-bot: [V: 04-1] restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 (owner: 10Aude) [00:27:36] aude: Oh, so we no longer clean up before updating stuff? [00:27:45] * making a new build [00:28:30] i think so... don't know which is best [00:31:29] aude: Why do we even need the install then? We probably only need update after is has been installed once, or am I missing somehting [00:31:40] that diff is just to big :/ [00:31:51] it is big [00:32:07] you're probably right [00:32:50] (03CR) 10Hoo man: [C: 04-1] "Pretty nice in general" (033 comments) [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110269 (owner: 10Aude) [00:33:14] (03CR) 10Hoo man: [C: 04-1] "See comments on https://gerrit.wikimedia.org/r/110269" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 (owner: 10Aude) [00:35:07] oh, we have different Wikdiata.php in the branch and on master, yikes [00:35:20] intended? [00:35:32] i fixed for master [00:35:41] That I just noticed... [00:35:41] it's complaining about template registry [00:35:47] something is not right [00:36:16] can't exactly cherry pick this [00:36:23] Right :/ [00:36:34] but the Wikidata.php should be copyable 1:1 [00:37:09] I know why, I guess [00:37:35] it is copyable but not everything else [00:38:41] also has a missing space on line 8 :P [00:39:13] oh got it [00:39:32] aude: Why do we even set "wgEnableWikibaseRepo" and the client one? Those are only used in Wikibase.composer.php and we already have that code duplicated [00:39:39] we should probably not duplicate that code... [00:41:09] (03PS2) 10Aude: restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 [00:41:52] i i dont' think we should have that magic at all [00:42:09] One way or another, but having both isn't nice [00:42:48] mh, that way Client will be able to load repo-only classes through the common autoloader AFAIS [00:43:28] (03CR) 10jenkins-bot: [V: 04-1] restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 (owner: 10Aude) [00:43:31] not much of a problem after all, but something to watch out for [00:44:04] i'd set them to false [00:44:15] That should work [00:44:15] then use the wmf configs to handle what to load [00:44:21] to be safe... [00:44:24] +1 [00:44:46] gnah [00:44:50] badges test fails now [00:44:54] -.- [00:45:11] (03PS3) 10Aude: restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 [00:47:28] (03CR) 10Hoo man: [C: 04-1] "Nit picks..." (035 comments) [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 (owner: 10Aude) [00:47:30] (03CR) 10jenkins-bot: [V: 04-1] restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 (owner: 10Aude) [00:48:14] spaces! [00:48:33] Not only :P Spaces aren't worth a -1 in such code [00:49:04] also the badges thing... mh :/ [00:49:09] The tests should be fixed or so [00:49:28] badges are because we made them experimental [00:49:37] I know [00:49:38] tests run now as non-experimental (i think is nicer) [00:49:41] the tests should be skipped [00:49:48] if not in exp. [00:50:09] that's not nice, but better than broken builds afterall [00:50:15] true [00:51:18] ewk, we have tests for that functionality in a lot of places, so just skipping them all probably isn't an option [00:51:41] we could run tests as experimental (not ideal, not preferred) [00:52:03] scary [00:52:10] Options we have: don't run tests, run them exp., let them fail or skip everything which includes badges (a lot :/) [00:52:29] err [00:52:36] badges are now experimental?! [00:52:39] JeroenDeDauw: Yep [00:52:48] Got an idea? [00:52:50] not in the domain model I hope? [00:52:52] i think we want a ui [00:53:00] * JeroenDeDauw goes check if everything went insane [00:53:10] in the api they are experimental [00:53:11] Yep, Lydia_WMDE wants a UI first [00:53:12] afaik [00:53:20] and there's still some constraint thingy missing AFAIR [00:53:35] aude: The api was changed today AFAIR [00:53:40] not sure that's on the branch [00:53:41] yep [00:53:44] backported [00:53:47] k [00:54:12] ah, sanity retained :) [00:54:46] JeroenDeDauw: So... what would you suggest for the unit tests? :P [00:55:49] The unit tests for the badges should obviously be disabled if the badges are disabled, though I'm guessing the question is about our integration and system tests? [00:56:04] In which case idk, I'm not up to speed with what is going on there [00:56:16] JeroenDeDauw: Api tests, special pages tests, ... more than just some badge tests test for badge functionality [00:56:32] all of them fail if not in exp. mode [00:57:25] would be nice for the build (especially branch we are deploying) to run as non-experimental [00:57:43] might not be practical at the moment :/ [00:57:47] aude: That would probably mean to skip many of the API tests [00:57:53] not great [00:57:55] like probably most of getentities [00:57:59] and we don't want that... [00:58:21] for future experimental things we should be more mindful [00:58:47] beta (for example) is not going to have experimental either [00:58:55] it will use the build [00:58:56] +1... but that was rather a hotfix [00:59:06] yep [00:59:17] badges shouldn't be in the branch at all... in a perfect world, but that's not what we have [01:00:25] for now I'd say: Reenable exp. again and add a comment that this is very very bad... [01:00:45] (03PS4) 10Aude: restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 [01:01:24] we can put that on beta and then update the branch accordintly [01:01:29] accordingly* [01:01:52] aude: mh [01:02:52] If the tests pass, I can merge it [01:02:56] great [01:03:10] certainly better than what we ahve now... needs polishing, though [01:03:13] this means change the cron jobs once, not twice (e.g. again next week when we move stuff) [01:03:42] Yep :) [01:04:01] which require ops to approve [01:04:09] ... [01:04:22] There's a Reed.y for everything :P [01:05:34] (03CR) 10Hoo man: [C: 032] ":)" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 (owner: 10Aude) [01:08:07] (03Merged) 10jenkins-bot: restructure to match organization of grunt build [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110274 (owner: 10Aude) [01:08:54] (03PS2) 10Aude: restructure to match organization of grunt build [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110269 [01:09:26] aude: Is that in line with the other change (same wikidata.php/ build.sh)? [01:09:44] yep [01:10:03] (03CR) 10Hoo man: [C: 032] restructure to match organization of grunt build [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110269 (owner: 10Aude) [01:10:04] Ok [01:10:07] yay [01:10:12] jenkins should approve [01:10:30] * hoo likes gate and submit [01:10:55] +1 [01:13:12] (03Merged) 10jenkins-bot: restructure to match organization of grunt build [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110269 (owner: 10Aude) [01:14:56] aude: Guess it's time for bed... 2:15am here [01:15:03] cu tomorrow [01:19:08] good night [01:21:03] aude: Will you fix it right away? I can stay up a few more minutes to merge a follow-up [01:21:16] yeah [01:21:56] it means repo enabled on wikipedia w/o settings [01:22:04] Yep [01:22:11] not sure what caused that [01:23:33] (03PS1) 10Aude: move autoload require [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110290 [01:23:38] just a guess, likely [01:25:03] mh... how should that work? [01:25:06] * fix it [01:25:54] that fixes [01:26:17] ./autoload_files.php: $baseDir . '/extensions/Wikibase/Wikibase.composer.php', [01:26:18] ok [01:26:30] "tested" on beta [01:26:35] fixes [01:26:41] (03CR) 10Hoo man: [C: 032] move autoload require [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110290 (owner: 10Aude) [01:26:48] that magic autoloader is scary :/ [01:26:50] shall fix in branch [01:26:51] yeah [01:27:17] aude: Is it live yet? [01:27:27] ie. did you push it early? [01:27:51] (03PS1) 10Aude: fix entry point autoload [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110291 [01:28:09] briefly tested but should wait for regular code update [01:28:22] (03CR) 10Hoo man: [C: 032] fix entry point autoload [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110291 (owner: 10Aude) [01:28:25] ok [01:28:38] (03Merged) 10jenkins-bot: move autoload require [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110290 (owner: 10Aude) [01:31:52] aude: Will really go now... hope there's nothing more [01:32:00] ok [01:32:05] code is updating [01:32:19] (03Merged) 10jenkins-bot: fix entry point autoload [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110291 (owner: 10Aude) [01:33:58] I really need to get a deployment-prep test wiki for this... [01:34:04] * wikifamr [01:34:10] next week :P [01:35:01] i had those variables set to false in my settings [01:35:22] anyway, the build seems to work fine [05:00:01] (03CR) 10Legoktm: New Lua interface to create infoboxes (034 comments) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [08:47:32] Guten tag [08:51:14] the beta cluster has some exception leading to a fatal error : https://bugzilla.wikimedia.org/show_bug.cgi?id=60612 [08:51:21] caused by $wgWBRepoSettings["entityNamespaces"] not being configured :/ [09:16:49] (03CR) 10Tobias Gritschacher: Create more tests for special pages (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [09:29:10] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man) [09:31:20] (03CR) 10Tobias Gritschacher: [C: 032] Fix client selenium tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109094 (owner: 10Tobias Gritschacher) [09:31:47] (03Merged) 10jenkins-bot: Fix client selenium tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109094 (owner: 10Tobias Gritschacher) [10:03:39] 01[13ValueView01] 15snaterlicious pushed 1 new commit to 06refactoring: 02http://git.io/6gICIg [10:03:39] 13ValueView/06refactoring 140ff38c2 15snaterlicious: Restored correct indentation in jquery.valueview.valueview.js [10:35:52] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/208f579 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17895280 [10:53:51] (03PS4) 10Henning Snater: Toolbar edit group widget optimization (DO NOT MERGE) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 [10:54:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [11:02:49] (03PS5) 10Henning Snater: Toolbar edit group widget optimization (DO NOT MERGE) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 [11:04:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [11:10:57] DanielK_WMDE: ready for call in 50 mins or too jet-lagged still? :) [11:48:14] 01[13DataValuesJavascript01] 15snaterlicious created 06valueviewdependency (+5 new commits): 02http://git.io/FwjJKg [11:48:14] 13DataValuesJavascript/06valueviewdependency 14ae87de2 15snaterlicious: Renamed valueParserFactory and valueFormatterFactory modules [11:48:14] 13DataValuesJavascript/06valueviewdependency 145ab37dc 15snaterlicious: Merged resource.mw.php with resources.php files... [11:48:14] 13DataValuesJavascript/06valueviewdependency 14138a48e 15snaterlicious: Removed ValueView dependency from mw.ext.valueFormatters/Parsers modules... [11:57:06] 01[13DataValuesJavascript01] 15snaterlicious pushed 1 new commit to 06valueviewdependency: 02http://git.io/KAFhHg [11:57:06] 13DataValuesJavascript/06valueviewdependency 1416da1c3 15snaterlicious: Updated test config dependencies [12:09:34] 01[13WikidataBuilder01] 15addshore pushed 2 new commits to 06master: 02http://git.io/iNDlwQ [12:09:34] 13WikidataBuilder/06master 142688561 15jeroendedauw: Add test to see if the dir copier copies files without extensions [12:09:34] 13WikidataBuilder/06master 14ace0622 15addshore: Merge pull request #8 from wmde/addtest... [12:14:14] (03PS1) 10Zfilipin: cucumber.yml is no longer needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110357 [12:19:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110357 (owner: 10Zfilipin) [12:33:43] [13DataValuesJavascript] 15snaterlicious opened pull request #24: Removed ValueView dependency (06master...06valueviewdependency) 02http://git.io/IvMlGg [12:36:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [12:39:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man) [12:49:13] 01[13ValueView01] 15snaterlicious created 06datavaluesjs (+1 new commit): 02http://git.io/36Q4VQ [12:49:13] 13ValueView/06datavaluesjs 142159e44 15snaterlicious: Initializing all of valueview's required options in mw.ext.valueView [12:50:16] [13ValueView] 15snaterlicious opened pull request #16: Adapt changes of DataValues JavaScript version 0.2.1 (06master...06datavaluesjs) 02http://git.io/B2rhnA [13:16:09] aude: daily will be a bit late.. once Lydia_WMDE is back from the meeting [13:39:32] Tobi_WMDE: oh noes :) [13:40:53] aude: /o\ [13:41:45] aude: it seems I cannot install any new ruby gems on the wikidata-jenkins instance without sudo [13:41:49] http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-browsertests-smoke/9/console [13:41:58] any idea how to get arount that? [13:42:06] *around [13:42:11] i don't know enough about gems [13:42:28] hmm [13:42:43] if it's allowed without sudo (like python), then directory permissions? [13:43:55] it's /var/lib/gems [13:44:22] Tobi_WMDE: You should be able to override that with another path [13:44:35] Not sure how jenkins is executing things, but in theory :P [13:46:25] Tobi_WMDE: http://stackoverflow.com/a/15127289 ;) [13:48:54] hm [13:50:17] Tobi_WMDE: You can also use gem install -i /foo/bar or so... [13:50:25] * hoo hasn't used that for quite some time... [13:50:33] aude: see https://bugzilla.wikimedia.org/show_bug.cgi?id=60612 [13:50:36] hoo: I'm installing with bundler [13:51:28] addshore: mh, we had that briefly tonight [13:51:38] maybe for 15 min. but should have been fine since [13:51:46] gd gd :) [13:52:13] addshore: i don't think it's still occurring [13:52:15] Tobi_WMDE: Yikes, never used that... sorry [13:52:41] but in the end it's probably still using gem as a backend? [13:53:44] hashar: ping [13:54:24] aude> receiver connected. Negotiating language [13:54:44] looks like logging has changed on beta [13:54:47] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=60612 when did these last occur? [13:54:49] there is no fatal.log [13:54:57] is there exceptionlog? [13:55:07] how do you guys says "ping-pong" in german beside Tischtennis ? [13:55:21] aude: Will shell also give me access to beta? [13:55:33] That's a separeate thing, right?= [13:55:37] hoo: do you have shell access on labs ? [13:55:38] hoo: no [13:55:44] I mean on any projects? [13:55:59] hashar: On labs, bastion and maybe something else :P [13:56:08] But I only use tool labs [13:56:22] hoo: I am not sure when the fatal for $wgWBRepoSettings["entityNamespaces"] occurred last time. Overnight probably since I filled that bug this morning and was looking at the (then) last 12 hours of logs [13:56:35] hashar: Ok, should be fine then [13:56:42] hoo: so I can grant you access on deployment-bastion.pmtpa.wmflabs so you can look at log files under /data/project/logs [13:56:45] we had that briefly tonight as we screwed something [13:56:47] need labs account [13:56:52] hashar: "hoo" [13:56:55] quite sure https://bugzilla.wikimedia.org/show_bug.cgi?id=60606 is a duplicate [13:57:08] so it is resolved :) [13:57:11] my concern with 60612 is not that much about the exception [13:57:19] but that the exception occurs before $wgOut is initialized [13:57:23] so the error is never shown [13:57:26] yeah [13:57:42] the order we autoloaded stuff was wrong [13:57:51] instead, you have a fatal error because $wgOut as no ->disabled() method [13:57:55] ahh [13:58:39] hoo: you should have access to deployment-bastion.pmtpa.wmflabs [13:58:42] unless it occurs again, i think non-issue [13:58:47] but wonder where the logs are? [13:58:53] /data/project/logs [13:58:59] either fatal.log or exception.log [13:59:07] the files are created on the first error so might not be there [13:59:18] ok, they are in archive [13:59:19] they are archived ini the 'archive' sub directory i.e.: /data/project/logs/archive [14:27:02] aude: daily time :) [14:27:08] DanielK_WMDE: how about you? :) [14:27:24] Lydia_WMDE: It's not quite 11am :D [14:27:28] Did you move the daily? [14:27:34] yeah ;-) [14:27:37] but we will move it back [14:28:19] ah, I see [14:29:30] ok [14:33:04] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=60532 Can we close that? [14:39:00] more bugs... [14:39:15] can be closed [14:39:27] :) [15:06:38] [13ValueView] 15JeroenDeDauw comment on pull request #16 142159e44: This is not grammatically correct - will fix it myself though 02http://git.io/dXnbKA [15:15:54] DanielK_WMDE: around? [15:16:16] [13DataValuesJavascript] 15JeroenDeDauw comment on pull request #24 1416da1c3: One cannot have breaking changes in a PACTH release (MAJOR.MINOR.PATCH). This should be 0.3.... 02http://git.io/aD3lfQ [15:18:34] aude: not really, catching up with family stuff [15:18:39] send mail or catch me later.. [15:19:32] well, i need to double check the schema changes don't depend on deployment of new code and vice versa [15:19:37] big int and indexes [15:19:44] * aude thinks they don't depend [15:20:11] e.g. could have been done weeks ago or can be done later [15:37:01] [13DataValuesJavascript] 15tobijat comment on pull request #24 1416da1c3: It's not really a breaking change.. e.g. ValueView will still continue working with the 0.2.1 version of DVJS 02http://git.io/eBIa7A [15:47:26] (03PS1) 10Addshore: Check for Label/Description conflicts in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 [15:47:44] aude: yes. the schema changes that have compat issues are the oney converting term_entity_id and epp_entity_id into strings. [15:48:01] ok, with the setting [15:48:04] these were not merged when I last checked (the latter is actually just a draft, iirc) [15:48:09] hopefully that goes in the next branch [15:48:19] (03CR) 10Addshore: [C: 04-1] "need to update the recently merged specialpage also" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [15:48:22] at least for terms. maybe i get around to doing epp too [15:49:15] [13DataValuesJavascript] 15JeroenDeDauw comment on pull request #24 1416da1c3: Even if this change is not merged into ValueView? https://github.com/wmde/ValueView/pull/16/files... 02http://git.io/_1RFuQ [15:50:56] (03CR) 10Addshore: [C: 04-1] "needs manual rebase >.>" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [15:52:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [15:52:58] aude: converting the ids to strings is not urgent. it's only important for forward-compat with non-numeric entities. [15:53:25] we should get it done, sure, but nothing really depends on it [15:53:51] ok [15:54:02] got cache epoch setting [15:55:36] (03PS27) 10Addshore: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [15:59:21] 01[13DataValuesJavascript01] 15snaterlicious pushed 1 new commit to 06valueviewdependency: 02http://git.io/sjMFMQ [15:59:21] 13DataValuesJavascript/06valueviewdependency 1463d538c 15snaterlicious: Bump to version 0.3 alpha [16:00:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [16:00:40] (03CR) 10Addshore: [C: 032] Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [16:02:12] addshore: anyone https://www.mediawiki.org/wiki/Wikidata_deployment#mw1.23-wmf11.2F12 [16:02:16] Lydia_WMDE: [16:02:35] anything else worth putting in the list of things that changed or bugs fixed? [16:02:41] looking [16:02:52] seems short but then we had holidays [16:03:30] aude: seems fine to me [16:03:36] ok [16:03:57] (03PS20) 10Jeroen De Dauw: Create more tests for special pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [16:03:59] [13DataValuesJavascript] 15tobijat closed pull request #24: Removed ValueView dependency (06master...06valueviewdependency) 02http://git.io/IvMlGg [16:04:00] you can use that to help with your announcement [16:04:11] 01[13DataValuesJavascript01] 15tobijat 04deleted 06valueviewdependency at 1463d538c: 02http://git.io/1YUqDw [16:04:49] [13DataValuesJavascript] 15tobijat comment on pull request #24 1463d538c: Right. Bumping to version 0.3 is the better way.. 02http://git.io/4XaNuw [16:06:33] (03CR) 10Jeroen De Dauw: "Not a big fan of this messy special page code in general, though this commit does not seem to make things worse. +0.5 from my side" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [16:08:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [16:09:29] addshore: this commit really should not have been merged https://gerrit.wikimedia.org/r/#/c/108337/4/lib/config/WikibaseLib.default.php [16:15:51] 01[13ValueView01] 15snaterlicious pushed 1 new commit to 06datavaluesjs: 02http://git.io/H18vkw [16:15:51] 13ValueView/06datavaluesjs 14ef2a6b5 15snaterlicious: Require DataValues JavaScript version 0.3 [16:17:07] aude: DanielK_WMDE: Tobi_WMDE: addshore: is anyone of you going to do the call in 45 mins? i will try to join but i can't promise since i need to call abraham at that time [16:18:17] (03PS2) 10Addshore: Check for Label/Description conflicts in ChangeOpsMerge [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 [16:21:20] JeroenDeDauw: do we have anything to detect conflicting sitelinks? similar to the LabelDescriptionDuplicateDetector? [16:24:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [16:27:44] (03CR) 10Addshore: [C: 032] Create more tests for special pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [16:28:39] Lydia_WMDE: wasn't planning to, i'm totally out of the loop and still catching up both to porivate life and my inbox. [16:28:52] i'll try to write a summary of my visit tonight though [16:29:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110388 (owner: 10Addshore) [16:29:28] DanielK_WMDE: ok thx [16:34:54] call? [16:35:04] 01[13ValueView01] 15snaterlicious created 06datatypesdependency (+1 new commit): 02http://git.io/yV_GrQ [16:35:04] 13ValueView/06datatypesdependency 14f6e831a 15snaterlicious: Removed DataTypes dependency [16:35:11] don't have anything new to say [16:36:54] [13ValueView] 15snaterlicious opened pull request #17: Removed dependency on DataTypes library (06master...06datatypesdependency) 02http://git.io/Y_YyOw [16:39:26] aude has to be in the call :P [16:39:34] even with nothing to say :> [16:39:58] lol [16:53:06] 01[13ValueView01] 15tobijat 04deleted 06previewwidget at 148b642ae: 02http://git.io/fZ91Qw [16:54:15] (03PS8) 10Henning Snater: Implemented "eachchange" event using the jQuery.event.special API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 [16:55:32] 01[13ValueView01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/aX0U8w [16:55:32] 13ValueView/06master 1480a2185 15Tobi Gritschacher: Merge pull request #16 from wmde/datavaluesjs... [16:57:52] addshore: I don't think so [16:59:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 (owner: 10Henning Snater) [17:00:53] addshore: joining? [17:01:15] yup, never done hangout on this laptop so just got to poke everything into working :P [17:01:21] * aude waves  [17:01:30] addshore: do it on mine for now [17:01:58] come over :D [17:01:59] mine is working :) [17:04:13] 01[13ValueView01] 15snaterlicious 04force-pushed 06refactoring from 140ff38c2 to 142a577f2: 02http://git.io/N1611w [17:04:13] 13ValueView/06refactoring 149ff101d 15snaterlicious: Moved Mock expert to test resources [17:04:13] 13ValueView/06refactoring 14e8aac43 15snaterlicious: Applied camel case to all internally used expert names [17:04:13] 13ValueView/06refactoring 142a577f2 15snaterlicious: Restored correct indentation in jquery.valueview.valueview.js [17:17:38] 01[13ValueView01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/fKTg9Q [17:17:38] 13ValueView/06master 14c027c03 15Tobi Gritschacher: Merge pull request #15 from wmde/refactoring... [17:25:48] 01[13ValueView01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/p665cA [17:25:48] 13ValueView/06master 14bf3865b 15Tobi Gritschacher: Bump version 0.2.1 [17:27:59] 01[13ValueView01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/gCYDMw [17:27:59] 13ValueView/06master 14fd6f4b1 15Tobi Gritschacher: Update release notes [17:31:21] 01[13ValueView01] 15tobijat tagged 060.2.1 at 06master: 02http://git.io/JqU6fw [17:37:48] (03CR) 10Jeroen De Dauw: [C: 032] Move badgeitems config from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110388 (owner: 10Addshore) [17:39:46] 01[13DataValuesJavascript01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/Nr8rvQ [17:39:46] 13DataValuesJavascript/06master 14fd4e215 15Tobi Gritschacher: Bump version 0.3 [17:40:32] 01[13DataValuesJavascript01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/XlKWqg [17:40:32] 13DataValuesJavascript/06master 14a13f5f1 15Tobi Gritschacher: Bump version 0.3 [17:41:02] 01[13DataValuesJavascript01] 15tobijat tagged 060.3 at 06master: 02http://git.io/BPrrLQ [17:55:07] (03PS3) 10Addshore: Check for conflicts in ChangeOpsMerge preSave [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 [17:58:16] (03PS1) 10Addshore: Take SpecialMergeItems out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 [17:59:31] (03CR) 10Tobias Gritschacher: [C: 032] Tag some of browsertests as @smoke [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109305 (owner: 10Tobias Gritschacher) [17:59:47] (03Merged) 10jenkins-bot: Tag some of browsertests as @smoke [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109305 (owner: 10Tobias Gritschacher) [18:00:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [18:01:55] (03CR) 10Jeroen De Dauw: Check for conflicts in ChangeOpsMerge preSave (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [18:02:24] 01[13ValueView01] 15snaterlicious 04force-pushed 06datatypesdependency from 14f6e831a to 14886e209: 02http://git.io/-hYhCA [18:02:24] 13ValueView/06datatypesdependency 142e7bd46 15snaterlicious: Moved Mock expert to test resources [18:02:24] 13ValueView/06datatypesdependency 14886e209 15snaterlicious: Removed DataTypes dependency [18:04:03] (03PS4) 10Addshore: Check for conflicts in ChangeOpsMerge preSave [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 [18:04:13] (03PS2) 10Addshore: Take SpecialMergeItems out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 [18:04:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [18:10:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [18:13:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110401 (owner: 10Addshore) [18:24:36] aude: how much time left until deployment roughly? [18:27:42] Lydia_WMDE: ~30 min [18:28:05] aude: ok cool then i will leave the office right now and get back online in 30 to 45 mins from home [18:29:02] ok [18:29:10] https://www.mediawiki.org/wiki/MediaWiki_1.23/wmf12/Changelog [18:30:12] Reedy: looks good :) [18:30:43] Lydia_WMDE: we'll need a way to incorporate wikibase etc into the change log [18:30:45] addshore: ^ [18:31:27] 10 Wikibase* extensions and also Wikidata :/ [18:31:44] xD [18:31:53] plus datavalues/* [18:34:03] That's a lot of duplicated code when you check out all the repos [18:34:34] only Wikidata has duplicated code [18:34:36] * should have [18:35:00] i figured keep the old stuff checked out just in case we need to revert [18:35:16] next branch, can be removed [18:36:14] Doesn't help my working copy of all the extensions ;) [18:36:38] heh [18:38:54] 01[13ValueView01] 15snaterlicious 04force-pushed 06datatypesdependency from 14886e209 to 144d313dc: 02http://git.io/-hYhCA [18:38:54] 13ValueView/06datatypesdependency 144d313dc 15snaterlicious: Removed DataTypes dependency [18:42:55] 01[13WikidataBuilder01] 15filbertkm created 06extensionlist at 1435b1681 (+0 new commits): 02http://git.io/FMYc0w [18:43:09] rage [18:43:19] I like the very light gray on white... [18:46:36] 01[13WikidataBuilder01] 15filbertkm pushed 1 new commit to 06extensionlist: 02http://git.io/FuEJPQ [18:46:36] 13WikidataBuilder/06extensionlist 1421501c8 15aude: Fix extension list build resource [18:46:54] addshore: ^ [18:47:01] [13WikidataBuilder] 15filbertkm opened pull request #9: Fix extension list build resource (06master...06extensionlist) 02http://git.io/ausMvg [18:47:04] (03PS1) 10Addshore: Add wbgetsites api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 [18:47:18] also, the Wikidata.php is not exactly matching waht we are using [18:47:18] will lookk now aude [18:47:39] it would cause a fatal on beta wikipedia, as is [18:49:10] 01[13WikidataBuilder01] 15addshore pushed 2 new commits to 06master: 02http://git.io/HA6q3w [18:49:10] 13WikidataBuilder/06master 1421501c8 15aude: Fix extension list build resource [18:49:10] 13WikidataBuilder/06master 141b309ee 15addshore: Merge pull request #9 from wmde/extensionlist... [18:49:23] ah, ok new one [18:49:30] 01[13WikidataBuilder01] 15filbertkm created 06extensionlist (+1 new commit): 02http://git.io/GASfFw [18:49:30] 13WikidataBuilder/06extensionlist 140be6206 15aude: use same Wikidata.php entry point as currently used... [18:50:02] Still missing the psaces :D [18:50:14] hah [18:50:46] i am confused where it went [18:50:54] did it get deleted with the branch? [18:51:08] where what went? :> [18:51:11] nope [18:51:15] found it [18:51:21] https://github.com/wmde/WikidataBuilder/pull/10 [18:51:23] open a pul [18:51:24] l [18:51:29] [13WikidataBuilder] 15filbertkm opened pull request #10: use same Wikidata.php entry point as currently used (06master...06extensionlist) 02http://git.io/SUR-fg [18:51:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [18:51:47] there you go ;) [18:51:53] [13WikidataBuilder] 15mariushoch closed pull request #10: use same Wikidata.php entry point as currently used (06master...06extensionlist) 02http://git.io/SUR-fg [18:52:18] great [18:52:35] now the build should be ready once we're happy with wikidata on the new stuff [18:52:52] [= [18:53:21] :)) [18:55:24] (03CR) 10Legoktm: "<3" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [18:56:52] (03CR) 10Aude: [C: 04-1] "why is this in wikibase?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [18:57:08] aude: It's about sites that *can* be linked [18:57:11] not about listing all sites [18:57:44] yeah ^ [18:57:49] (03CR) 10Aude: Add wbgetsites api module (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [18:57:49] might be better of in client, though [18:58:03] (03CR) 10Addshore: "Will make a patch for core over the weekend." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [18:58:04] huh [18:58:42] i still think it can be generalised [18:58:48] (03CR) 10Jeroen De Dauw: [C: 04-1] Add wbgetsites api module (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [18:58:49] sitegroup can be an api parameter [18:58:58] (03CR) 10Addshore: [C: 04-2] Add wbgetsites api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [18:58:59] core really should have such api module [18:59:14] been meaning to do that for a while [19:00:13] (03CR) 10Addshore: Add wbgetsites api module (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [19:00:32] wonder how many more lines it will take in core xD [19:01:06] (03CR) 10Aude: Add wbgetsites api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [19:01:13] shouldn't be that bad [19:01:29] 01[13ValueView01] 15snaterlicious pushed 2 new commits to 06bug45604: 02http://git.io/NMNBmg [19:01:30] 13ValueView/06bug45604 14abfe406 15snaterlicious: Rebased to master [19:01:30] 13ValueView/06bug45604 14bd03829 15snaterlicious: Implemented "eachchange" event using the jQuery.event.special API [19:01:31] (03CR) 10Jeroen De Dauw: Add wbgetsites api module (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [19:01:55] (03CR) 10Aude: Add wbgetsites api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [19:02:04] (03CR) 10Addshore: Add wbgetsites api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110409 (owner: 10Addshore) [19:02:22] hah! I dont think a patch has ever had so much of a review so quickly before xD [19:02:27] heh [19:04:11] (03CR) 10Jeroen De Dauw: [C: 031] Check for conflicts in ChangeOpsMerge preSave [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110380 (owner: 10Addshore) [19:05:22] wonder where exactly it would fit, Query SiteInfo? [19:05:34] prop=sites [19:05:53] list sites I'd say [19:08:51] back :) [19:08:52] (03PS9) 10Henning Snater: Adapt changes of ValueView version 0.3 (DO NOT MERGE) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 [19:09:28] * hoo is still struggling with the jet lag :/ Tired all day and have to get up early... [19:09:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 (owner: 10Henning Snater) [19:09:46] hoo: force yourself to get back to "normal" rhythm [19:09:47] 01[13WikidataBuilder01] 15JeroenDeDauw 04deleted 06extensionlist at 140be6206: 02http://git.io/209KYQ [19:09:54] hoo: including lying in bed awake [19:10:04] sucks but helps [19:10:23] Lydia_WMDE: mh... I couldn't resist and slept 3 hours this afternoon :/ [19:10:34] hoo: bad idea ;-) (been there done that) [19:11:36] Yeah :/ [19:22:06] i think we have usual caching issues in js [19:22:08] https://test.wikidata.org/wiki/Q256 [19:22:11] otherwise nothing exploded [19:22:16] works in debug mode [19:24:01] \o/ [19:24:11] aude: time to go and try to break test for me? [19:24:22] seems to work now [19:24:24] go ahead [19:24:34] https://test.wikidata.org/wiki/Q22 [19:24:41] will order dinner and then poke test [19:24:44] yep, looks good :) [19:25:36] * aude removes babel boxes [19:25:58] Gaeilge! [19:26:03] why does it think i speak that [19:26:03] 01[13WikidataBuilder01] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_Sc0FA [19:26:03] 13WikidataBuilder/06master 14cee7da8 15Jeroen De Dauw: Update README.md [19:26:09] * aude not heard of it [19:26:10] lol [19:26:17] it sounds good though! [19:26:27] i think it's like catalan [19:27:10] for me it shows german [19:27:12] pretty good [19:27:14] :) [19:27:31] aved in parser cache with key testwikidatawiki:pcache:idhash:203-0!*!*!*!en!*!* and timestamp 20140130192513 [19:27:34] seems fine [19:27:57] try loggedout [19:28:26] Saved in parser cache with key testwikidatawiki:pcache:idhash:203-0!*!*!*!de!*!* and timestamp 20140130192809 [19:28:42] also german [19:28:46] when logged out [19:28:52] in incognito mode [19:29:21] firefox thinks i speak spanish (ok) and chinese [19:29:35] heh [19:29:36] shows me english logged out [19:30:24] (03PS6) 10Henning Snater: Toolbar edit group widget optimization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 [19:31:51] ok this all looks good to me [19:32:28] :) [19:32:41] people: go and test quantities some more on test.wikidata.org please [19:32:56] seems good [19:33:28] * Lydia_WMDE ^5's aude addshore and hoo [19:33:51] :) Happy that it works [19:33:58] Unknown unit: ° [19:34:11] that used to just vanish [19:34:28] mh :/ [19:34:48] works as should now [19:34:57] ok, then [19:35:10] hmm [19:35:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [19:35:36] aude: where did you see it? [19:35:38] entering -23,456,725±0.0010 when saving comes back as -23,456,725.0000±0.0010 [19:35:48] wait.. that copy and pasted wrong! [19:35:52] Lydia_WMDE: it vanished back on test.wikidata in december [19:35:54] old code [19:35:57] ah [19:36:01] now it is handled correctly [19:36:05] ok [19:36:17] we'll give you a bit of testing time and then i say wikidata can get wmf12 [19:36:25] really don't see issues [19:36:34] sounds good [19:36:46] when entering -23,456,725±0.001 and saving I seem to get -23,456,725.0000±0.0010 back [19:36:49] everyone else in the channel: go go go! test quantities on test.wikidata.org [19:36:58] not sure why that trailing 0 is there [19:37:20] addshore: will try to reproduce [19:37:56] * aude prepares patch to enable quantities [19:38:28] aude: We need to pull WD.org on the branch first [19:38:36] addshore: confirmed but not bad? [19:38:50] no, just not entirly sure why its formatted with a trailing 0 [19:39:04] hoo: yep [19:39:29] addshore: ack [19:39:47] i don't expect it to be perfect [19:40:00] Should be good enough [19:40:09] addshore: Which item is that? [19:40:14] https://test.wikidata.org/wiki/Q273 [19:40:16] good enough indeed, fixable [19:40:32] oddly if you do a precision of 0.002 it doesnt format with a trailing 0 [19:41:00] -.- [19:41:15] small oversight https://www.mediawiki.org/w/index.php?title=Wikidata_deployment&diff=895365&oldid=895339 [19:41:18] https://test.wikidata.org/wiki/Special:EntityData/Q273.xml [19:41:19] :) [19:41:20] yikes [19:41:22] blocker [19:41:37] really? [19:41:42] ok [19:41:57] aude: Doubt we should deploy that if it throws... [19:42:00] xml issue [19:42:08] addshore: "datavalue":{"value":{"amount":"+23456725.000","unit":"1","upperBound":"+23456725.001","lowerBound":"+23456724.999"},"type":"quantity"} [19:42:16] can we get the stacktrace? [19:42:19] just an UI issue, I guess... ignore that for now [19:42:26] aude can fetch it :) [19:42:32] hoo: indeed, should file a bug / write it down [19:42:55] https://bugzilla.wikimedia.org/show_bug.cgi?id=60636 [19:43:15] STUPID XML [19:43:59] i get it on master also [19:44:04] yay [19:44:11] Don't we have tests for that... [19:44:21] no >.> [19:48:22] addshore: aude: Will one hotfix that or not important today? [19:48:49] its thats borken the xml for api output is also likely broken [19:49:13] hmh, or not.. https://test.wikidata.org/w/api.php?action=wbgetentities&ids=Q273&format=xml [19:49:34] addshore: Nope [19:49:38] would have said that [19:51:44] well this is interesting [19:51:45] :D [19:52:37] "interesting"! [19:52:38] -.- [19:52:53] i don't like it when programmers say that word :P [19:53:55] well both the api and this special page / entitydatadeserializationserver use $resultBuilder->addEntityRevision [19:54:01] one is broken, one is not ;p [19:54:17] addshore: They do things quite a bit differently [19:54:38] hotifx would be good [19:55:26] addshore: do you have idea what/how to fix? [19:55:28] aude: I think I know where the problem is shall I? Or addshore? [19:55:44] go for it :> [19:55:49] hoo: +1 [19:56:19] need to reproduce first... [19:56:32] \o/ [19:56:48] hoo: remind me to get you cookies next time we meet btw [19:59:29] damn can't test -.- [19:59:38] UI is still broken for me locally [19:59:41] what did you think it was? [20:01:16] see if i reproduce it [20:02:27] * hoo rages about his test wiki [20:02:45] got it [20:03:07] "mw.Api error: " "http" [object Object] [20:03:10] * hoo cries [20:03:13] huh [20:03:21] That's what I get locally [20:03:37] but my local wiki is f... ever since I moved to a plain composer install [20:03:48] :( [20:04:56] Trying one more thing... [20:05:20] waiting for all my extensions to update [20:08:57] (03PS1) 10Hoo man: Fix Special:EntityData XML view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 [20:09:03] didn't test [20:09:08] as I can't :( [20:09:22] Need to get myself a few hours this weekend to get my wiki re-setup [20:09:47] hoo: if you can't figure it out Jeroen should help you [20:10:29] Lydia_WMDE: mh... ever since I moved over to using composer for my Wiki, it just acts weird (mostly UI) [20:10:53] yeah - probably a setup issue that jeroen can help with [20:11:19] did anyone try my fix? [20:11:45] will try it now [20:11:49] nobody did, cause it will fatal [20:11:51] sorry people [20:12:12] :P [20:12:22] Call to undefined method Wikibase\LinkedData\EntityDataSerializationService::getResult() :D [20:12:30] got it [20:12:32] patch coming [20:12:33] (03PS2) 10Hoo man: Fix Special:EntityData XML view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 [20:12:42] aude: Something else? [20:12:53] I manually changed it to $options->setIndexTags( $res->getIsRawMode() ); and it works [20:13:03] addshore: Just set it to true [20:13:10] we force raw mode above anywa [20:13:11] y [20:13:20] that's what I did in PS2 [20:13:38] exactly [20:13:58] we only for it if we need it, i.e. if the printer is xml [20:14:02] $options->setIndexTags( $res->getIsRawMode() ); [20:14:07] if you always set indexed tags they appear in json e.t.c [20:14:21] hoo: want to amend? [20:14:34] addshore: So... you want that only for XML? Can do [20:14:40] yup :) [20:14:41] it's consistent with the api [20:14:47] done for a reason, i assume [20:14:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 (owner: 10Hoo man) [20:15:11] its rather odd though, the result builder has $this->options->setIndexTags( $this->getResult()->getIsRawMode() ); in the constructor [20:15:18] (03PS3) 10Hoo man: Fix Special:EntityData XML view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 [20:16:17] (03CR) 10Addshore: [C: 04-1] Fix Special:EntityData XML view (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 (owner: 10Hoo man) [20:16:23] eww so many tabs everywhere xD [20:16:24] :/ [20:16:56] (03PS4) 10Hoo man: Fix Special:EntityData XML view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 [20:17:08] addshore: :P [20:17:19] this all still seems really odd to me, like the result builder isnt doing the serialization options the way it should.. [20:17:37] addshore: the API is doing that as well [20:17:51] AFAIR [20:18:23] all api output now goes through this class though, which is why it was rather odd that it didnt break the api >.> silly options! [20:18:26] seems to work though [20:18:33] far from ideal [20:18:38] indeed, just wait for jenkins to catchup? xD [20:18:48] addshore: The API does that, I just checked :P [20:18:50] * aude verified [20:19:01] really? [20:19:21] we really need to fix the serializers! [20:19:23] GetEntities:: $options->setIndexTags( true ); [20:19:35] GetEntities::getSerializationOptions [20:19:37] doh [20:19:43] $options->setIndexTags( $this->getResult()->getIsRawMode() ); [20:19:45] * addshore $options->setIndexTags( $this->getResult()->getIsRawMode() ); [20:19:47] :P [20:20:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 (owner: 10Hoo man) [20:22:21] addshore: That's because of the way ResultBuilder handles its options AFAIS [20:22:51] can we just go for this now, and open a bug for fixing it in a sane way later? [20:22:56] yup [20:23:29] (03CR) 10Aude: [C: 032] "verified, seems to work fine and looks reasonable" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 (owner: 10Hoo man) [20:23:46] as always, fine with improvign later [20:23:49] (03Merged) 10jenkins-bot: Fix Special:EntityData XML view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 (owner: 10Hoo man) [20:24:09] we just need to kill the serializers in their current state :P [20:24:24] :D [20:24:27] +1 [20:24:32] (03PS1) 10Addshore: Fix Special:EntityData XML view [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110445 [20:24:34] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 (owner: 10Hoo man) [20:24:37] aude ^^ [20:24:58] (03CR) 10Hoo man: [C: 032] "Fix all the test Wikis \o/" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110445 (owner: 10Addshore) [20:25:17] (03Merged) 10jenkins-bot: Fix Special:EntityData XML view [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110445 (owner: 10Addshore) [20:25:19] Sorry, couldn't resist that one :P [20:25:19] yay [20:25:21] too quick [20:25:31] ? [20:25:35] now to make the new build :P [20:25:51] yep [20:25:59] :) [20:26:07] time for a break [20:26:15] Guess the build's fine now ;) [20:26:39] I might go and write 2 really hillarious tests for this xml stuff [20:26:50] could be taking a minute for the change to propagate [20:26:56] composer update does nothing yet [20:27:20] composer update? but the change is in wikibase? :P [20:27:29] addshore: Still, we use composer [20:27:34] We changed that tonight [20:27:38] ahh! [20:27:41] that's also why we broke beta :P [20:27:45] yep [20:27:57] it occurred to me it would be bad to move things again next week [20:28:09] things like changing cron jobs is annoying! [20:28:26] update found [20:29:31] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110442 (owner: 10Hoo man) [20:29:52] (03PS1) 10Aude: update wikibase, fix entity data xml output [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110448 [20:30:49] (03CR) 10Addshore: [C: 032 V: 032] update wikibase, fix entity data xml output [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/110448 (owner: 10Aude) [20:32:05] (03PS1) 10Aude: update wikibase, fix entity data xml output [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110449 [20:32:14] (03CR) 10Addshore: [C: 032 V: 032] update wikibase, fix entity data xml output [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110449 (owner: 10Aude) [20:32:28] wait... [20:32:31] soemthign is odd [20:32:33] wait..? [20:32:44] https://gerrit.wikimedia.org/r/#/c/110449/1/vendor/composer/autoload_classmap.php [20:32:47] why did it remove all that? [20:32:56] https://gerrit.wikimedia.org/r/#/c/110448/ didn't [20:33:02] oh maybe [20:33:06] no [20:33:13] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/110445 (owner: 10Addshore) [20:33:16] O_o [20:33:53] trying agin [20:34:05] went from "installation-source": "dist", to source [20:35:19] ick [20:41:06] classmap looks same on master and branch [20:41:14] idk why datavalues etc don't get listed [20:41:30] its... very odd and slightly worrying... [20:42:04] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikidata.git/4841db5cb16a4e5542ab74e455fcd7452748f2ae/vendor%2Fcomposer%2Fautoload_namespaces.php [20:42:07] maybe [20:42:11] because those use namespaces? [20:42:37] ahh potentially! [20:42:52] maybe composer just got a little update or something? [20:45:19] * aude edit got identified as potentially harmful :( [20:45:27] ? xD [20:45:42] "Unconstructive edits will be quickly reverted" [20:45:42] aude: confess! :D [20:45:55] now what was aude adding...? :D [20:45:58] "A brief description of the abuse rule which your action matched is: www Spam" [20:46:04] * aude blames hoo :) [20:46:33] :D [20:46:45] Global AbuseFilters hitting in? [20:46:46] we can always blame hoo but that's too easy [20:46:47] ;-) [20:47:25] anyway, beta looks fine so i must assume the autoload is fine [20:47:35] hoo: on beta [20:47:59] aude: We have global filters on beta enabled for ages AFAIR [20:48:13] We used it quite a bit before hitting production :) [20:48:26] Also because Beta got hit by spam badly [20:50:33] Lydia_WMDE: addshore any other issues on test.wikidata? [20:50:44] not found any [20:50:56] ok [20:50:57] nope [20:51:03] time for https://gerrit.wikimedia.org/r/#/c/110371/ [20:51:11] after the backport is merged [20:51:18] :) [20:52:33] aude: You might already want to put in a follow-up to enable the new crons? [20:52:52] not yet [20:53:04] Afraid of a premature merge? [20:53:06] we'll poke a few minutes [20:54:01] sure the lag wont' get too bad and will quickly recover [20:55:56] I guess so [20:57:08] Blame hoo?! That's unfair! Blame Lydia_WMDE [20:57:34] JeroenDeDauw: that's no fun though [20:57:49] since i am at fault alway anyway [20:58:22] * JeroenDeDauw senses a trap [20:58:32] you sense correctly [20:58:58] JeroenDeDauw: also all good with our talk? do you want to do any parts of what i put together? [21:09:54] https://test.wikidata.org/wiki/Special:EntityData/Q273.xml works [21:11:40] \o/ [21:12:42] :) [21:14:33] now searching for ops person [21:14:44] * aude notes it's lunch time [21:15:00] Not in Europe :D [21:15:15] in sf [21:15:24] ;) [21:15:25] hoo: Maybe people like eating lunch at 22:15 though. [21:15:41] +1 [21:15:43] I don't think there's any ops in the office today anyway [21:15:53] oh? [21:16:28] mh... maybe Tim later on? [21:16:55] i think ottomata can review [21:23:08] Lydia_WMDE: I want to do as little as possible ofc, to not violate my laziness policy [21:23:25] just needs a few more kittens [21:23:35] easy [21:23:38] JeroenDeDauw: i want a copy of that policy on my desk on monday [21:23:39] ;-) [21:24:59] Lydia_WMDE: oh, you sure you want to demand that? [21:25:14] * Lydia_WMDE senses a trap [21:25:49] Lydia_WMDE: is it possible to not have all bullets appear at the same time? [21:25:58] yes [21:26:17] open animations [21:26:25] do an animation on the textbox [21:26:40] and then there is a paragraph option or something [21:29:00] Lydia_WMDE: woho, magical! [21:29:14] i no! [21:29:15] aude: this crappy thing does not allow adding animated gifs over 2MB, so its hard to add cats [21:29:21] :( [21:29:47] JeroenDeDauw: artists strive in limitations [21:29:48] ;-) [21:43:11] still waiting on ops [21:43:23] :( [21:43:52] pinged ottomata? [21:44:09] he's not comfortable enough with our stuff [21:44:20] I see [21:45:05] doesn't want to break stuff [21:52:41] "Reminder: holiday @ Fri Jan 31" :) [21:52:45] love google calendar [21:54:04] Lydia_WMDE: this ain't a flipping 64k demo! [21:55:22] aude: ;-) [21:55:25] JeroenDeDauw: but! [21:55:27] why not? [22:11:02] how about this for a demo [22:11:04] http://tools.wmflabs.org/reasonator/test/?date=1792-12-07 [22:23:28] Reedy: Still around? [22:24:00] technically i could do it, although can't merge in mediawiki-config ;) [22:24:10] wtf [22:24:33] Who do we need to bribe for that? :P [22:24:58] ^d maybe... [22:25:57] quantities are coming? [22:26:10] not yet, only updating the software today [22:26:11] Reedy: https://gerrit.wikimedia.org/r/#/c/110467/ :) [22:26:23] seriously don't know if that's helpful, but whatever [22:26:44] You tried :D [22:26:48] hoo: ? [22:26:56] rschen7754: we're trying [22:27:02] :D [22:27:03] hoo: https://gerrit.wikimedia.org/r/#/c/110433/ is last part [22:27:14] Oh, that one is for today? :P [22:27:15] no reason not to do that today [22:27:22] why not? :) [22:27:37] rschen7754: excited? :D [22:27:38] Dunno, just thought we had that scheduled for Tuesday or so [22:27:42] * hoo hides and runs [22:27:43] yup [22:27:43] nope [22:27:51] rschen7754: go and try on test.wikidata.org ;-) [22:27:57] :> [22:28:10] i just got food :D [22:28:12] yum yum [22:28:17] addshore: share! [22:28:21] :D [22:28:23] * aude hungry! [22:28:24] yum install food; [22:28:34] hoo: apt-get! [22:29:19] connection is too slow to load :( [22:29:40] Lydia_WMDE: Well, you have to admit that apt-get isn't such a sexy name :P [22:30:01] but what's behind it is what counts ;-) [22:30:15] aude: I guess you can grab food, I can stay around and point Reedy towards things in the next hour or so [22:30:28] i am around for a while [22:30:50] i assume reedy is eating or wahtever [22:30:50] Just wanted to say that you don't have to stick around, if you rather want to get food ;) [22:31:05] just incase anyone cares i probably wont be at the daily tommorw, but noone else will be so meh! :P [22:31:12] * aude has holiday [22:31:55] addshore: you already said that today... ;-) [22:32:06] addshore: i care :) [22:32:16] haha, getting forgetfulll with the lack of sleep last night :P [22:32:27] addshore: no i mean about the daily today [22:32:40] GerardM-: sweet! [22:46:54] JeroenDeDauw: https://gs1.wac.edgecastcdn.net/8019B6/data.tumblr.com/5db27db56daf62579bf442b2b933a386/tumblr_mfhg01617i1r63pb5o1_500.gif capture all the data? #catcontent [23:05:07] right, I am off [23:05:15] tata until tommmrorw!!! [23:05:18] we're waiting on starting cron job [23:05:23] and enable quantities [23:05:29] :P [23:05:30] wikidata is on wmf12 and works great [23:05:31] :) [23:05:48] and i can see suppressed content! [23:05:53] yay! [23:06:01] :D [23:06:02] :-) [23:06:02] rschen7754: Logged in, I hope? [23:06:06] xD [23:06:07] hoo: of course :P [23:06:08] lol hoo [23:06:12] * hoo just got a minor heart attack [23:06:29] But I tested that :P [23:08:30] out of bounds seems to be not occurring now [23:08:41] :) [23:08:48] logs are quiet [23:09:15] \o/ [23:11:27] aude: https://www.wikidata.org/wiki/Special:NewProperty [23:11:30] * aude has to go eat soon [23:11:46] wtf [23:11:47] localization not updated? [23:12:04] oh, i am not properyt creator [23:12:05] eww [23:12:08] looks fine [23:12:13] looks ugly [23:12:15] You do not have permission to create properties, for the following reason: [23:12:15] The action you have requested is limited to users in one of the groups: Administrators, Property creators. [23:12:20] aude: :P [23:12:29] Go there with an admin account, i18n is messed [23:13:09] mmm [23:13:27] http://grab.by/tYOI [23:13:30] looks fine [23:13:40] oh [23:14:01] addshore: That link doesn't work for me... is it a screenshot? [23:14:07] hoo: it is :P [23:14:10] it works for me :O [23:14:13] it's like it's doubld encoded [23:14:16] double* [23:14:39] aude: mh... I keep seeing in there [23:14:40] maybe this will work hoo >> http://new.tinygrab.com/1becbe2e7885cdff1cfa14272e020c1af095791b57.png :P [23:14:52] addshore: Yep ;) [23:14:55] That's what I see [23:15:08] alright, back in ~ hour [23:15:11] means the messages aren't in there [23:15:14] - in [23:15:16] things seem fine, except this issue [23:15:38] aude: mh... have someone run the localization update? [23:15:41] only think i think is maybe data types i18n is missing [23:15:47] make sure its in the build [23:16:02] if not add it, and then localisation update will run / have it run [23:16:11] mh [23:16:14] * hoo checks [23:16:23] data-values/datatypes or such [23:16:33] back later [23:16:38] after eating [23:32:25] Lydia_WMDE: Plan to announce the Quantities? [23:32:40] hoo: as soon as it is live [23:32:42] yeah [23:33:16] Lydia_WMDE: It's live :P [23:33:39] woooot? [23:33:52] https://www.wikidata.org/wiki/Special:NewProperty ;) [23:34:01] Nobody yet created one, but it's there [23:34:14] We got Chad/ demon to deploy it earlier [23:34:18] sweet [23:34:23] will go and announce then [23:34:28] \o/ [23:35:59] 01[13WikidataBuilder01] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/mHGbnA [23:35:59] 13WikidataBuilder/06master 1406f5ed3 15Jeroen De Dauw: Update README.md [23:36:07] Lydia_WMDE: Created :D [23:36:16] and we have our first Property: https://www.wikidata.org/wiki/Property:P1081 [23:36:18] hoo: ^ too :p [23:36:26] yay [23:36:29] I'm slow :P [23:36:45] hoo: Tbh, I said created before I pressed enter xD [23:36:58] oO [23:37:06] Data type <datatypes-type-quantity> [23:37:14] is that normal? [23:37:15] rschen7754: Localization update missing [23:37:31] Just a minor glitch that will heal itself ;) [23:40:22] Data type <datatypes-type-quantity> [23:40:24] is that normal? [23:40:46] rschen7754: Just a minor glitch because of an incomplete localization cache [23:40:52] I'm working on that [23:40:54] ;) [23:43:41] 01[13WikidataBuilder01] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/y8Ghnw [23:43:41] 13WikidataBuilder/06master 1439bd0f7 15Jeroen De Dauw: fix irc channel [23:44:44] Lydia_WMDE: can I enter "over9000" as a quantity? [23:44:56] JeroenDeDauw: go ask the community (TM) :P [23:45:09] <- no longer the personified community, remember? [23:45:10] ;-) [23:46:49] i was trying to add HDI to Germany, but I have no add statement link. Also the sources link look a bit broken. Is this also l12n cache? [23:47:34] dennyvrandecic_: might be, let me check [23:47:57] Not our fault VE broke the localization updater, so we're innocent on that one :P [23:48:20] puh [23:48:48] Lydia_WMDE: Well, ifixing it on our side would have probably been faster than waiting for the VE team... [23:49:12] fair [23:49:28] dennyvrandecic_: mh... want to make a screenshot? [23:49:51] sure [23:50:38] whats a trustworthy image upload page? [23:51:34] Good question, I don't really care to much :P [23:51:44] You could also open a bug and add it to BZ [23:51:52] * as an BZ attachment [23:54:11] https://docs.google.com/file/d/0B9ePxyCTySH1V3JLMXJ6R2RidTg/edit [23:55:13] ewk :S [23:55:17] Lydia_WMDE: don't dodge the question! [23:55:48] JeroenDeDauw: watch me ;-) [23:56:24] dennyvrandecic_: Confirmed [23:56:46] pity [23:57:28] JeroenDeDauw: I speak for myself, go a head :p