[00:37:32] 01[13DataValuesJavascript01] 15filbertkm created 06resources (+1 new commit): 02http://git.io/9RFU3Q [00:37:32] 13DataValuesJavascript/06resources 14d9b5b23 15aude: fix resource paths [00:58:17] 01[13DataValuesJavascript01] 15filbertkm 04deleted 06resources at 14d9b5b23: 02http://git.io/3GJmuQ [00:58:37] 01[13DataValuesJavascript01] 15filbertkm created 06resources from 060.1.1.1-mw1.23wmf11 (+0 new commits): 02http://git.io/Bz-bBw [00:59:07] 01[13DataValuesJavascript01] 15filbertkm pushed 1 new commit to 06resources: 02http://git.io/o4mWjQ [00:59:07] 13DataValuesJavascript/06resources 14d1a7daa 15aude: fix resource paths [01:00:27] [13DataValuesJavascript] 15filbertkm opened pull request #21: fix resource paths (060.1.1.1-mw1.23wmf11...06resources) 02http://git.io/hyoMbg [01:03:51] 01[13DataValuesJavascript01] 15filbertkm created 06resourcepaths (+1 new commit): 02http://git.io/oVLaGQ [01:03:51] 13DataValuesJavascript/06resourcepaths 148df5d2a 15aude: fix resource path typos [01:04:26] [13DataValuesJavascript] 15filbertkm opened pull request #22: fix resource path typos (06master...06resourcepaths) 02http://git.io/DkiLgw [01:09:38] anyone around to review js stuff? ^ [01:28:03] aude, still around? [01:30:13] yep [01:30:22] errr, in sf? no [01:30:38] no, not in SF :) i know that you all left before I came back [01:30:46] sadly [01:30:50] indeed [01:30:57] I hope you had a good time [01:31:03] short but good [01:31:10] why are you still awake? [01:31:16] in the us [01:31:21] it's early :) [01:31:49] :) [01:32:20] I have a long list of wikipedia pages that have more than one wikidata item associated with them [01:32:37] I was wondering, I thought we cleaned that up and it shouldnt be happening anymore [01:32:44] hmmmm [01:33:02] i think hoo found some anomolies in the items per site table [01:33:55] shall i try to talk to hoo tomorrow then? or do you think i should just send it to the internal list? [01:34:19] i'd do both [01:34:24] ok [01:34:31] i guess he's back in germany [01:34:51] if there is still a bug (e.g. still happening) then we should definitely look into it [01:36:05] here's an example http://www.wikidata.org/wiki/Q2592754 and https://www.wikidata.org/wiki/Q13049384 [01:37:24] or https://www.wikidata.org/wiki/Q14346975 and https://www.wikidata.org/wiki/Q14346976 [01:39:28] Q2592754 is in the items per site table [01:40:17] I'd say so, since these are the sitelinks displayed on the anwiki article [01:40:18] Q13049384 has no entries in the table [01:45:30] hmm, ok, i will try to catch some tomorrow, and write an email [01:45:40] hoo might know more [01:45:45] thx [01:45:48] sure [01:45:50] cu [03:02:17] so are numbers coming tomorrow, or was that postponed? [07:04:39] hi there what is up, how can i download wikidata [07:04:56] i want it on the phone thanks [07:25:11] http://reasonator.info/ [07:31:14] (03PS8) 10Bene: Reduce badges to items listed in config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 [07:37:04] (03CR) 10Bene: Reduce badges to items listed in config (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [07:46:17] (03PS12) 10Bene: Create more tests for special pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 [07:49:26] (03PS13) 10Bene: Create more tests for special pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 [07:50:37] (03PS14) 10Bene: Create more tests for special pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 [09:14:28] (03PS4) 10Adrian Lang: Implement rendering item links as HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 [09:15:59] (03CR) 10Adrian Lang: Implement rendering item links as HTML (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109654 (owner: 10Adrian Lang) [09:23:44] (03CR) 10Adrian Lang: Format dates with more than 4 digit years (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 (owner: 10Addshore) [09:30:53] 01[13ValueView01] 15snaterlicious created 06restructuring (+1 new commit): 02http://git.io/hBNx7A [09:30:53] 13ValueView/06restructuring 14875dae8 15snaterlicious: Restructured files and directories [09:34:53] [13ValueView] 15snaterlicious opened pull request #11: Restructured files and directories (06master...06restructuring) 02http://git.io/G3TVMg [09:43:09] 01[13DataValuesJavascript01] 15tobijat pushed 1 new commit to 060.1.1.1-mw1.23wmf11: 02http://git.io/Fs0Vdw [09:43:09] 13DataValuesJavascript/060.1.1.1-mw1.23wmf11 1470121e9 15Tobi Gritschacher: Merge pull request #21 from wmde/resources... [09:43:50] 01[13DataValuesJavascript01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/f-bcKw [09:43:50] 13DataValuesJavascript/06master 148e06b26 15Tobi Gritschacher: Merge pull request #22 from wmde/resourcepaths... [10:00:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [10:17:58] (03PS1) 10Adrian Lang: Actually remove repo class map, fix EasyRdf autoloading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109861 [10:19:25] (03CR) 10Adrian Lang: "This was forgotten in I35e5a3c68eb298488e86eda8874ed0bca4b256b6" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109861 (owner: 10Adrian Lang) [10:31:46] (03PS2) 10Lydia Pintscher: Add i18n support in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore) [10:33:05] Hi, Lua question: entity.claims[property] is a Lua sequence? [10:34:28] I mean can I get the number of statements just with #entity.claims[property] + 1 (+1 because I noticed it always starts from 0) [10:34:36] 01[13ValueView01] 15snaterlicious pushed 1 new commit to 06restructuring: 02http://git.io/ST2GWA [10:34:36] 13ValueView/06restructuring 14f788446 15snaterlicious: Fixed path to util.Notifier test [10:34:58] https://github.com/Wikidata/easyrdf_lite https://github.com/wikimedia/mediawiki-extensions-Wikibase-easyrdf [10:35:07] https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Wikibase/easyrdf [10:35:09] addshore: [10:36:53] rotpunkt: we intent to fix the 0 [10:39:22] nice, so entity.claims[property] is a Lua sequence? so I can assume it contains ALWAYS all the indexes from 1, 0 by now as you said, to the greatest index, without holes, also after editing, removal from the web interface... [10:40:35] rotpunkt: i think so but someone else should confirm [10:41:37] addshore: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Wikibase/easyrdf,n,z [10:50:07] 01[13ValueView01] 15snaterlicious created 06messageprovider (+1 new commit): 02http://git.io/7UuP7A [10:50:07] 13ValueView/06messageprovider 147bbb024 15snaterlicious: Renamed jquery.valueview.MessageProvider to util.MessageProvider [10:50:44] I will ask again later, in case [10:54:09] addshore: did you see https://gerrit.wikimedia.org/r/#/c/109861/ [10:55:39] [13ValueView] 15snaterlicious opened pull request #12: Renamed jquery.valueview.MessageProvider to util.MessageProvider (06master...06messageprovider) 02http://git.io/XNP9FQ [11:02:46] yes Tobi_WMDE just verifiying it now :) [11:03:49] can someone confirm if entity.claims[property] is a Lua sequence (also after editing/removals from the web interface) ? [11:04:15] (03CR) 10Addshore: [C: 032 V: 032] Actually remove repo class map, fix EasyRdf autoloading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109861 (owner: 10Adrian Lang) [11:04:31] (03PS1) 10Addshore: Actually remove repo class map, fix EasyRdf autoloading [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109867 [11:05:22] (03CR) 10Addshore: [C: 032 V: 032] Actually remove repo class map, fix EasyRdf autoloading [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109867 (owner: 10Addshore) [11:05:44] (03Merged) 10jenkins-bot: Actually remove repo class map, fix EasyRdf autoloading [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109867 (owner: 10Addshore) [11:08:55] 01[13DataValuesJavascript01] 15addshore 04deleted 06resources at 14d1a7daa: 02http://git.io/7bXEEw [11:09:12] 01[13DataValuesJavascript01] 15addshore 04deleted 06resourcepaths at 148df5d2a: 02http://git.io/W3SrmA [11:19:12] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore) [11:21:38] (03CR) 10Addshore: Format dates with more than 4 digit years (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 (owner: 10Addshore) [11:23:03] 01[13ValueView01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/vGvV7g [11:23:03] 13ValueView/06master 142572ee0 15Tobi Gritschacher: Merge pull request #11 from wmde/restructuring... [11:23:31] (03CR) 10Adrian Lang: Format dates with more than 4 digit years (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 (owner: 10Addshore) [11:23:33] (03CR) 10Addshore: Add i18n support in MwTimeIsoFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore) [11:25:29] 01[13ValueView01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/2YbEJA [11:25:29] 13ValueView/06master 14eb8bb73 15Tobi Gritschacher: Merge pull request #12 from wmde/messageprovider... [11:27:01] 01[13ValueView01] 15tobijat 04deleted 06restructuring at 14f788446: 02http://git.io/Yu-OKQ [11:27:35] 01[13ValueView01] 15tobijat 04deleted 06messageprovider at 147bbb024: 02http://git.io/CfLuHA [11:31:41] (03PS3) 10Addshore: Add i18n support in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 [11:31:52] (03PS2) 10Addshore: Remove space that should not be! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 [11:31:54] (03PS2) 10Addshore: Support formatting time dataType via API in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 [11:32:41] (03CR) 10Tobias Gritschacher: [C: 032] Remove space that should not be! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 (owner: 10Addshore) [11:33:16] (03CR) 10Tobias Gritschacher: [V: 032] Remove space that should not be! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 (owner: 10Addshore) [11:36:50] 01[13DataTypes01] 15addshore created 060.1.1-mw1.23wmf11-pull1 (+1 new commit): 02http://git.io/K6JWWQ [11:36:50] 13DataTypes/060.1.1-mw1.23wmf11-pull1 14d1e455f 15addshore: Fix Array to string conversion [11:37:20] [13DataTypes] 15addshore opened pull request #4: Fix Array to string conversion (060.1.1-mw1.23wmf11...060.1.1-mw1.23wmf11-pull1) 02http://git.io/RwufDw [11:37:28] Tobi_WMDE: && [11:37:33] the above please :) [11:38:12] [travis-ci] wmde/DataTypes#18 (0.1.1-mw1.23wmf11-pull1 - d1e455f : addshore): The build passed. [11:38:13] [travis-ci] Change view : https://github.com/wmde/DataTypes/commit/d1e455f74b80 [11:38:13] [travis-ci] Build details : http://travis-ci.org/wmde/DataTypes/builds/17760436 [11:38:58] 01[13DataTypes01] 15addshore created 06array2stringfix (+1 new commit): 02http://git.io/T2jbMA [11:38:58] 13DataTypes/06array2stringfix 14248e88a 15addshore: Fix Array to String conversion [11:40:26] [travis-ci] wmde/DataTypes#20 (array2stringfix - 248e88a : addshore): The build passed. [11:40:26] [travis-ci] Change view : https://github.com/wmde/DataTypes/commit/248e88a57ec2 [11:40:26] [travis-ci] Build details : http://travis-ci.org/wmde/DataTypes/builds/17760543 [11:41:03] (03CR) 10Tobias Gritschacher: [V: 04-1] "Gives me:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [11:42:41] (03CR) 10Addshore: [C: 031] "This would be insanely useful to have for our next deployment with the build" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 (owner: 10Aude) [11:49:27] (03CR) 10Addshore: [C: 04-1 V: 04-1] Special page for wbmergeitems api module (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [11:50:57] (03CR) 10Addshore: [C: 04-1] "needs a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [11:51:42] anyone feel like polishing https://www.wikidata.org/wiki/Q475430 a bit? it's the conference JeroenDeDauw and I speak at this weekend and it'd be cool to be able to show this [11:58:15] (03CR) 10Aude: "it needs to link to something that explains what the build is. that can include a list of components and whatnot." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 (owner: 10Aude) [11:58:45] Lydia_WMDE: we need to choose / make a page to link to for the build [11:59:22] * hoo waves from Germany [11:59:57] aude: where will it be used? [12:00:11] in special:version [12:00:14] hi hoo ! [12:00:27] i am copying the readme to mediawiki.org [12:00:41] JeroenDeDauw: Aroundish? [12:02:47] (03CR) 10Tobias Gritschacher: [C: 031] Support formatting commons media links via API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109638 (owner: 10Adrian Lang) [12:03:24] Lydia_WMDE: {{done}} ;) [12:03:26] aude: will figure it out with addshore when back from lunch [12:03:30] Pyb: :* [12:04:41] hi hoo, perhaps you know about this: entity.claims[property] is always a Lua sequence. also after editing/removals from the web interface) ? I mean can I get the number of statements just with #entity.claims[property] + 1 (+1 because I noticed it always starts from 0) [12:05:02] https://www.mediawiki.org/wiki/Wikidata_build [12:05:08] not super fancy but works [12:05:39] rotpunkt: You mean after calling entity = mw.wikibase.getEntity() [12:06:01] it's not guaranteed that this will return a table at all, if the current page is not linked with an item, it might also return nil [12:06:24] the new Lua-Api will have convenience functions for these kind of things [12:06:38] no, I mean the elements inside #entity.claims[property] represent a Lua sequence? [12:06:55] so ordered from 0 to N element, without holes [12:07:43] I'm pretty sure it is [12:07:49] nice [12:08:09] it's very important to know [12:08:09] I'm a bit ... today as I'm very jet lagged :/ [12:08:18] but it's not documented [12:09:02] I know... these internal structures shouldn't really be used, we should have convenience functions for everything Users need [12:09:17] but, how can I iterate over claims? [12:09:20] that's being worked on, I hope to get that live some time soon [12:10:27] [13DataTypes] 15tobijat closed pull request #4: Fix Array to string conversion (060.1.1-mw1.23wmf11...060.1.1-mw1.23wmf11-pull1) 02http://git.io/RwufDw [12:10:43] 01[13DataTypes01] 15tobijat 04deleted 06array2stringfix at 14248e88a: 02http://git.io/aGefIw [12:11:22] ok, but wikidata is /already/ exposed to all wikis, I need a way to iterate over claims... I didn't know if the correct way was pairs or a simple for [12:11:32] addshore: please update the release notes section accordingly: https://github.com/wmde/DataTypes [12:11:52] woah... new gerrit looks quite a bit different :P [12:12:30] rotpunkt: for k, v in pairs( entity.claims ) do ... [12:12:30] (03PS1) 10Aude: improve readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109873 [12:12:37] where's the issue with that? [12:12:42] the issue is: [12:13:11] aude: Do we pull easy rdf using composer now also? [12:13:15] (03PS2) 10Aude: Register Wikidata build in Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 [12:13:15] Last time I checked we didn't [12:13:28] (03CR) 10Aude: "it links to https://www.mediawiki.org/wiki/Wikidata_build" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 (owner: 10Aude) [12:13:33] if I use pairs then when I want a specific element using entity.claims[pairs][n] I get an element in a different order from pairs [12:13:46] hoo: aude: I'm implementing that right now [12:13:52] +1 [12:13:57] *entity.claims[property][n] [12:15:58] (03CR) 10Hoo man: "re check" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [12:16:26] let's say claims contains { "one", "two", "three" }, if I use pairs to build a list of claims: I can get "two, three, one" (order is not assured), then I use claims[1] and it returns "two" [12:16:48] rotpunkt: why don't you just do for ... do properties[#properties] = value [12:16:49] or so [12:17:00] sorry, I'm tired... but that should work [12:18:06] do you mean using "for i = 0, #entitiy.claims[property] do" ? [12:18:33] no, I mean iterating over it with pairs and then store stuff in a sequenced taböle [12:18:35] * table [12:18:56] (03PS1) 10Aude: improvements to resource loader module registration [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109874 [12:19:04] ok, but if #entity.claims[property] IS a sequence I don't need pairs! [12:19:19] I am here for asking that :) [12:19:33] (03CR) 10Aude: [C: 032 V: 032] improvements to resource loader module registration [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109874 (owner: 10Aude) [12:19:40] and I don't need another table [12:20:20] rotpunkt: As told, it almost certainly is... nothing really should interact with that... just a plain PHP array brought into Lua [12:20:21] (03PS1) 10Aude: improvements to resource loader module registration [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109875 [12:20:49] sorry but it's too strange this for me [12:20:53] (03CR) 10Aude: [C: 032 V: 032] improvements to resource loader module registration [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109875 (owner: 10Aude) [12:21:06] * aude waits for beta to update [12:22:27] by now the only way to interact with claims is reading #entity.claims[property] and we are saying that we can't confirm what type of data it is? [12:22:32] (03PS1) 10Adrian Lang: Handle easyrdf_lite dependency with composer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109876 [12:23:26] rotpunkt: We can... you just need to check for it to be there... might not be there in case the item has no claims (can't tell out of the head atm) [12:23:39] Adrian_WMDE: is easyrdf_lite on packagist now? [12:24:14] ok https://github.com/Wikidata/easyrdf_lite/blob/master/composer.json [12:24:16] aude: Yes it is [12:24:41] https://packagist.org/packages/wikibase/easyrdf_lite [12:24:47] no claims is not a problem, the problem woud be if tomorrow the claims { [0] = "one", [1] = "two", [2] = "three" } becomes { [0] = "one", [1] = "two", [3] = "three" } with a hole [12:24:51] i would also list daniel as a co-author [12:25:11] i don't know who did how much but he definitely contributed to it [12:25:31] i was thinking the same thing [12:25:37] he updated it to 0.8 [12:25:38] rotpunkt: wont happen [12:25:48] this is the answer!!! :)) thanks [12:26:04] the might be 1-based indexed one day, but never have a hole in there [12:26:11] perfect then [12:27:01] lua tables do too many things :( [12:27:31] (03PS7) 10Hoo man: New Lua interface to create infoboxes [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 [12:30:08] (03CR) 10Hoo man: "Merely a zero-change for having jenkins run again (after core has been fixed)" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [12:31:30] @hoo thanks a lot again, cya [12:42:09] (03PS1) 10Adrian Lang: Consider EasyRDF lite to be mandatory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109882 [12:44:07] Adrian_WMDE: Are you into autoloading with composer? [12:44:32] hoo: uhm, I don't think so [12:44:51] ewk [12:45:03] that's blocking the Lua patches and JeroenDeDauw isn't around :& [12:45:05] * :S [12:49:09] Adrian_WMDE: Any reason we use mixed tabs and spaces in the composer.json [12:49:18] indentation seems rather messy in there [12:49:22] if not, I'll fix that [12:50:56] hoo: I was wondering too [12:51:12] tabs should be fine [12:51:42] Tobi_WMDE: Yeah, both work fine... just wondered whether that is a code-style thingy by JeroenDeDauw or so... [12:51:59] (03PS2) 10Hoo man: Handle easyrdf_lite dependency with composer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109876 (owner: 10Adrian Lang) [12:52:01] no, just change it [12:52:26] (03CR) 10Hoo man: "Indent-only fixes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109876 (owner: 10Adrian Lang) [12:52:38] (03CR) 10Hoo man: [C: 032] Handle easyrdf_lite dependency with composer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109876 (owner: 10Adrian Lang) [12:52:50] (03PS2) 10Adrian Lang: Consider EasyRDF lite to be mandatory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109882 [12:52:59] (03Merged) 10jenkins-bot: Handle easyrdf_lite dependency with composer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109876 (owner: 10Adrian Lang) [12:53:26] hoo: Tobi_WMDE: It's just me being sloppy [12:53:33] or, us being sloppy [12:53:39] Also, composer init does spaces [12:54:18] where's WikidataJenkins :P [12:57:52] Ok, it's not here... meh [12:58:08] hoo: hmmm [12:58:16] it's running the jobs [12:58:27] but it's not voting [12:58:30] strange [12:58:52] Tobi_WMDE: mh... why not on https://gerrit.wikimedia.org/r/109882 ? (First patch set is a little older already) [12:59:18] maybe the new gerrit did something [12:59:32] :/ [12:59:51] We should also give it a valid email address, the server errors are annoying :P [13:00:09] hoo: it has a valid email address [13:00:36] valid, don' tknow [13:01:29] Adrian_WMDE: Want to do some easy peasy review? https://gerrit.wikimedia.org/r/106226 [13:01:41] Tobi_WMDE: are there meetings today? [13:02:02] aude: only daily at 3 [13:02:14] ok [13:02:17] * aude here early [13:03:33] aude: hoo: WikidataJenkins has the email wikidata-services@wikimedia.de - and this is valid, I verified the email [13:03:40] great [13:04:02] I don't know why we still get server errors sometimes [13:04:03] mh, ok [13:04:31] and I have no clue at the moment why it does not vote after finishing the jobs [13:06:42] I'm updating the plugins and restart it now [13:06:55] beta seems to work now [13:06:56] ok [13:07:16] aude: I backported 2 things (1 to DataTypes and one to Wikibase) [13:07:26] addshore: think we got them [13:07:35] i made a new build in the past hour [13:07:52] [= [13:08:27] (03CR) 10Addshore: [C: 032] Register Wikidata build in Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 (owner: 10Aude) [13:08:33] yay [13:08:46] shall make new build again [13:08:51] in my opinion might even be worth including that in the build yee [13:08:56] need it on the branch too? [13:09:09] the only part not automated is in Wikibase/.git/config i need to remove the submodule [13:09:23] looks like submodule will be gone soon as we swtich to master [13:09:43] addshore: special:version, yes [13:10:00] (03PS1) 10Addshore: Register Wikidata build in Special:Version [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109885 [13:10:08] (03PS2) 10Addshore: Register Wikidata build in Special:Version [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109885 [13:10:10] (03CR) 10Addshore: [C: 032 V: 032] Register Wikidata build in Special:Version [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109885 (owner: 10Addshore) [13:10:14] hah [13:10:20] hah! [13:10:25] (03Merged) 10jenkins-bot: Register Wikidata build in Special:Version [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109609 (owner: 10Aude) [13:10:29] (03CR) 10Addshore: [C: 032 V: 032] Register Wikidata build in Special:Version [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109885 (owner: 10Addshore) [13:10:34] (03CR) 10Hoo man: [C: 032] "Passes tests and works while tested per hand" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109882 (owner: 10Adrian Lang) [13:10:42] did you click cherry pick also? :P [13:10:55] yes [13:11:02] i don't think mine appeared [13:11:12] gerrit is smart enough [13:11:14] it appeard as a second patchset in my changeset :P [13:11:23] oh [13:11:39] (03CR) 10Hoo man: [V: 032] Consider EasyRDF lite to be mandatory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109882 (owner: 10Adrian Lang) [13:11:45] hoo: You're the best colleague I don't have [13:12:50] :P [13:13:35] (03PS2) 10Aude: Improve and update readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109873 [13:13:47] (03PS1) 10Hoo man: Make indentation in composer.json consistent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109886 [13:14:02] for being native english speaker(s), challenged with spelling :p [13:14:22] (03CR) 10Addshore: [C: 032 V: 032] Make indentation in composer.json consistent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109886 (owner: 10Hoo man) [13:19:54] * hoo needs caffeine [13:24:03] Tobi_WMDE: so as lydia probably mentioned, i'd like the new deployment stuff to go on test wikidata / test2 before wikidata [13:24:34] test wikidata went on wmf11 core on jan 16, so we missed that [13:27:06] aude: We could go to test today and maybe use a lightning deploy tomorrow then? [13:27:55] i was thinking thursday [13:28:10] and then if things go fine, then maybe wikidata? [13:28:32] wikidata / wikisource /commons etc get switched to wmf11 today [13:28:56] aude: So... test today and main on Thursday? [13:29:00] on https://www.mediawiki.org/wiki/Wikidata_deployment#Deployment_notes let's list everything that we need to do [13:29:20] hoo: not possible, test and wikidata run the same code today [13:29:52] i do not know if/how to have different localisation cache when we are switching to a new git repo, whilst all on the same branch [13:30:08] mh [13:30:25] so we'd have thursday - tuesday on test [13:30:28] Guess I'm to tired now to really weigh into this... [13:30:42] and if wikidata is okay, we could switch it early i suppose (i'd like) [13:30:53] +1 [13:31:18] next tuesday is travel day so i might have spotty internet access, yet might be available some [13:31:56] then we need to make sure old client works fine with new code (on repo) [13:32:54] aude: mh... did Chris yet email/ whatever you? [13:33:26] I could help out if stuff sorted till then... if you have bad internet :/ [13:35:20] hoo: would be good [13:35:47] having wikidata switched on thursday would be good, after enough time poking on test2/wikidata :) [13:36:05] As I don't even have rt access I don't know what's going on :P rt is really a kind of blackbox :/ [13:36:06] wikivoyage / source /commons should be easy as long as test2 is good [13:36:21] it's boring, nothing interesting there [13:36:34] chris who? [13:36:44] aude: Steipp [13:36:47] ok, no [13:36:54] aude: url datatype and commons media datatype values are not linked in iitems atm on wikidata. are you aware any deployment that could cause this? [13:36:59] He said he wanted to do it, but maybe he forgot [13:37:14] aude: addshore and i have been trying to find the cause in gadgets but don't seem to find anything [13:37:16] Lydia_WMDE: hmmm, think i noticed but wasn't sure [13:37:25] do you remember when? [13:37:29] and on wikidata.org? [13:37:30] sunday? [13:37:33] ok [13:38:49] https://www.wikidata.org/wiki/Q15649152 [13:38:56] i was wondering about the links in the references [13:39:21] and commons https://www.wikidata.org/wiki/Q15649147 [13:39:55] (also has a small css issue with height of valueview-expert-stringvalue-input valueview-input text input [13:39:58] ( [13:40:08] aude: yeah that is the issue [13:40:21] aude is wmf6 deployed currently? [13:40:36] addshore: yes [13:40:49] does it happen on master? [13:41:02] no [13:41:08] master is fine for me [13:41:27] ok, interesting [13:42:53] aude isnt test.wikidata and wikidata still running the same code? [13:43:32] yes [13:43:44] errr, different core [13:44:01] wmf10 on wikidata, wmf11 on test [13:44:05] heh, broken on both [13:45:24] huh, the css issue is fixed if i disable all gadgets [13:45:56] css issue? :> [13:46:02] and the link works! [13:46:06] https://www.wikidata.org/wiki/Q15649152?debug=true [13:46:15] small css issue with height of valueview-expert-stringvalue-input valueview-input text input [13:46:42] there are no urls or commons links on there .. [13:46:43] same on https://www.wikidata.org/wiki/Q15649147?debug=true [13:46:48] remove all gadgets [13:46:55] logged in [13:47:19] just from the list of gadgets "Redirect image links to Commons for files that are hosted there." sounds suspicious [13:47:24] aude: links work for me with debug and not without [13:47:37] really. maybe caching? [13:47:55] sounds like caching, but even after editing the page the link remains broken [13:48:14] odd [13:50:14] I think it's the JS minificatio [13:50:17] n [13:54:50] (03CR) 10Addshore: [C: 032 V: 032] Improve and update readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109873 (owner: 10Aude) [13:57:33] also, the reference url gets cut off in display [13:57:44] after clicking edit and cancel, i see the whole thing [13:59:44] aude: joining? [14:00:53] hangout? [14:00:59] nothing in my calendar [14:01:41] aude: sent you the link [14:02:14] guess it's same each day [14:02:19] yes [14:30:33] addshore: Try JSON.parse(wbEntity) and JSON.parse(wbUsedEntities) on https://www.wikidata.org/w/index.php?title=Q15649147&debug=false [14:31:10] Looks ok to me, but it's related to data value type property type value data type stuff [14:42:49] Lydia_WMDE: i am sending mail to greg etc. [14:44:55] aude: thx [14:45:41] rschen7754: re quantities: not today :/ we're investigating unrelated issues still and won't do a deployment tonight as planned. we're trying to go on test.wikidata.org the day after tomorrow [14:48:10] (03PS56) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [14:53:14] PS56 oO [14:58:16] can folks please check some random items on wikidata.beta.wmflabs.org [14:58:16] (03PS6) 10Tobias Gritschacher: [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 [14:58:20] do you get any js errors? [14:58:31] hmm, second day in the row I see you (team) fighting witch builds/packaging etc. [14:58:48] aude: Doing [14:59:03] http://wikidata.beta.wmflabs.org <- clickable link for lazy people [14:59:06] (like me) [14:59:40] :) [14:59:50] i get occasional "Exception thrown by wikibase.ApiBasedValueFormatter " [14:59:55] not in debug mode [15:00:03] yikes [15:00:19] i can try "touching" files [15:00:30] aude: I see 404s in debug mode... [15:01:08] huh, ok [15:01:24] mee too [15:01:28] http://bits.beta.wmflabs.org/static-master/extensions/..ter/extensions/Wikidata/Wikibase/vendor/data-values/javascript/resources/globeCoordinate.js/src/globeCoordinate.js [15:01:39] "..ter" what the... [15:01:42] http://bits.beta.wmflabs.org/static-master/extensions/..ter/extensions/Wikidata/Wikibase/vendor/data-values/javascript/resources/mw.ext.dataValues.js [15:01:51] ss [15:01:52] something is still using the old way [15:02:00] undefined is not a function [15:02:00] TypeError [15:02:10] addshore: In debug mode? [15:02:18] Probably a side effect of the 404s [15:02:20] no :P [15:02:37] :/ [15:02:40] adriaqn said he might have made 1 more patch to backport which I have not done yet [15:02:59] https://github.com/wmde/ValueView/commit/909887d51622d9707186e212160e53b3f1dff038 [15:03:17] adding statemets fails [15:03:27] Uncaught Error: No ExpertProvider set in valueview's "expertProvider" option [15:03:33] addshore: That misses spaces :P [15:03:48] it does indeed >.> [15:03:53] found it [15:04:02] mh? [15:05:35] aude: the wikibase.ApiBasedFormatter thing? [15:05:51] I have a patch for that, you can go ahead of course, if you also got one [15:06:24] 01[13DataValuesJavascript01] 15filbertkm created 06modulepath (+1 new commit): 02http://git.io/7H1Qwg [15:06:24] 13DataValuesJavascript/06modulepath 148c3581c 15aude: fix resource loader module path [15:06:40] annoying to have this code all over the place [15:06:56] * hoo can't approve [15:07:02] looks like I'm missing rights on github [15:07:15] [13DataValuesJavascript] 15filbertkm opened pull request #23: fix resource loader module path (060.1.1.1-mw1.23wmf11...06modulepath) 02http://git.io/eT15qg [15:07:16] :( [15:07:21] Tobi_WMDE: ^ [15:07:22] * addshore waves [15:07:43] aude: What about the wikibase.ApiBasedValueFormatter thingy? [15:07:48] go ahead [15:08:10] aude need to merge that into master also? [15:08:20] [13DataValuesJavascript] 15addshore closed pull request #23: fix resource loader module path (060.1.1.1-mw1.23wmf11...06modulepath) 02http://git.io/eT15qg [15:08:42] i am confused about master [15:08:46] things got moved [15:08:52] master has had a lot of stuff changed [15:08:53] yus [15:09:12] we're using the branch on beta for now... next few days [15:09:21] obviously needs fixed in master [15:09:36] (03PS1) 10Hoo man: Fix dependencies for wikibase.ApiBasedValueFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109895 [15:09:47] I love how we almost never get our dependencies right [15:10:03] :D [15:10:13] hoo: should not used mixed tabs and spaces for indent obviously - not sure why people messed it up [15:10:31] JeroenDeDauw: heh :) Already fixed [15:10:32] 01[13DataValuesJavascript01] 15addshore 04deleted 06modulepath at 148c3581c: 02http://git.io/OszrKQ [15:10:32] Guess they had spaces as the indent thing for json in their editor config [15:11:36] addshore: do we need to change the versions again? [15:11:49] just checked and all the remoteExtPaths are done on master of javascript already [15:11:50] I wonder why we use mw.Api there anyway -.- [15:11:53] aude: change the versions? no [15:11:59] That will break in client, ... :( [15:12:00] ok [15:12:00] compoer is pulling from that branch [15:12:05] *composer [15:12:18] aude: https://gerrit.wikimedia.org/r/109895 [15:12:19] so whatever you stick in there will get pulled if you do a compoer update [15:12:46] ok, since it's refering to the branch [15:12:51] yup [= [15:13:54] hoo: do we need that on the branch? [15:14:26] (03PS1) 10Aude: new build, fix data values resource path [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109898 [15:14:31] aude: I saw that error on wikidata.beta.wmflabs.org [15:14:47] So I guess so [15:14:50] ok [15:14:54] (03CR) 10Addshore: [C: 032 V: 032] new build, fix data values resource path [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109898 (owner: 10Aude) [15:15:00] i'll look in minute [15:15:14] got it on this item: http://wikidata.beta.wmflabs.org/wiki/Q2159 [15:15:51] (03PS1) 10Aude: new build, fix data values resource paths [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109899 [15:15:55] same thing [15:15:59] k [15:16:04] (03CR) 10Addshore: [C: 032 V: 032] new build, fix data values resource paths [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109899 (owner: 10Aude) [15:16:33] give us a ping once beta is updated again aude :> [15:16:40] retriggered [15:16:51] and then hoo's thing [15:18:08] its updated [15:19:07] still getting some lovely js errors [15:19:23] addshore: paste them [15:19:41] mhhm, actually after a few more refershes they are all gone :) [15:19:48] guessing it wasnt quite finished updating [15:20:06] hoo: what's your github name? [15:20:08] hopefully [15:20:12] Tobi_WMDE: mariushoch [15:22:00] hoo: added you [15:22:17] you were in the wmde developers but not in the wikidata team [15:22:20] still updating [15:22:29] Tobi_WMDE: Ah ok :) [15:22:37] done [15:24:44] still getting some "/data/project/apache/common-local/php-master/extensions/Wikidata/Wikibase/vendor/data-values/javascript/js/src/valueParsers/valueParsers.util.js" [15:24:47] trying to load that [15:24:54] when the directory is ValueParsers [15:25:15] where in particular? [15:25:52] i.e. what item, anything I load seems to be fine after initially hitting ctrl+r a few times [15:25:54] random [15:26:23] aude: did you pull the dependency path to beta yet? [15:27:01] Still seeing these occasionally [15:27:27] http://wikidata.beta.wmflabs.org/wiki/Q1639 [15:28:04] Tobi_WMDE: What's about that? [15:28:12] doesn't load for me [15:28:21] i don't see "src/valueParsers" anywhere in the build code [15:29:09] Tobi_WMDE: WORKSFORME... only the one depency error is there [15:29:40] Tobi_WMDE: You might want to review [15:29:41] for me Wikibase/vendor/data-values/javascript/js/src/ValueParsers/valueParsers.util.js [15:29:42] https://gerrit.wikimedia.org/r/109895 [15:30:01] path should be similar but not exactly the same in the build [15:30:14] think it needs "touch" again [15:30:29] it's fetching http://dpaste.com/1573822/ [15:30:34] (sorry for scroll) [15:30:48] version=20140128T114008Z [15:33:33] firefox seems totally good [15:33:58] do we have any urls or numbers properties on beta? :P [15:34:23] good question... most of them have gibberish names :P [15:34:31] im going to try and hunt some down [15:34:32] probably not numbers [15:34:40] same config as wikidata [15:34:40] got no permissions to make any either [15:34:46] awww [15:34:48] hi there! [15:34:59] we have url [15:35:02] hi hashar [15:35:07] hi hashar :) Thanks for merging that unit test patch, btw [15:35:08] I have spot a bug on beta cluster for the Wikidata extension :D [15:35:13] http://wikidata.beta.wmflabs.org/wiki/Property:P454 [15:35:16] I just renammed one String, but thats not are to find :P [15:35:18] there is no such extension in bugzilla though [15:35:30] hashar: can go in WikidataRepo [15:35:35] okk [15:35:41] we are poking at beta though [15:35:45] might already know :) [15:37:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=60532 [15:37:57] some crazy dependency is in a directory valueParsers instead of ValueParsers [15:37:59] :> [15:38:05] yep got that [15:38:05] xD [15:38:11] can't figure out why [15:38:12] good luck! [15:38:17] caching [15:38:26] ahhh [15:38:33] and I have no idea how to clear RL cache :( [15:38:52] i touched it and didn't fix [15:38:58] sop the correct dir is ValueParsers [15:39:10] version=20140128T153314Z [15:40:35] GET http://bits.beta.wmflabs.org/static-master/extensions/resources/jquery.ui/themes/default/images/ui-icons_888888_256x240.png 404 (Not Found) :> [15:41:27] (03CR) 10Henning Snater: [C: 032 V: 032] Fix dependencies for wikibase.ApiBasedValueFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109895 (owner: 10Hoo man) [15:41:56] can't possibly be related [15:42:03] hoo: does that need a backport? [15:42:04] :D [15:42:17] worth a try [15:42:27] Of course [15:42:37] unless we want to deploy broken... then it doesn't :D [15:43:27] (03PS1) 10Addshore: Fix dependencies for wikibase.ApiBasedValueFormatter [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109906 [15:44:01] (03CR) 10Hoo man: [C: 032 V: 032] Fix dependencies for wikibase.ApiBasedValueFormatter [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109906 (owner: 10Addshore) [15:52:14] (03PS1) 10Aude: new build, update wikibase resources [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109907 [15:52:35] (03CR) 10Addshore: [C: 032 V: 032] new build, update wikibase resources [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109907 (owner: 10Aude) [15:53:39] did gerrit get updated lately? [15:53:45] e.g. last night? [15:53:46] ysu, today [15:53:47] yep [15:53:48] yus [15:53:50] (03PS1) 10Aude: new build, update wikibase resources [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109908 [15:53:59] (03CR) 10Addshore: [C: 032 V: 032] new build, update wikibase resources [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109908 (owner: 10Aude) [15:54:07] ok, that could be a reason why WikidataJenkins cannot vote anymore [15:54:23] exactly [15:55:19] http://lists.wikimedia.org/pipermail/wikitech-l/2014-January/074216.html [15:55:21] maybe [15:55:34] or related [15:56:22] uhh [15:56:25] ah yeah [15:56:26] thx aude! [15:56:28] spotted that this morning [15:56:34] gerrit approve -> gerrit review [15:56:35] have to change that in jenkins [15:57:35] 01[13ValueView01] 15snaterlicious created 06previewwidget (+2 new commits): 02http://git.io/Y9ZvYw [15:57:35] 13ValueView/06previewwidget 141ad4743 15snaterlicious: Moved css files to the directories of their corresponding js file [15:57:35] 13ValueView/06previewwidget 148b642ae 15snaterlicious: Converted jQuery.valueview.preview to jQuery.ui.preview [15:57:40] (03PS7) 10Tobias Gritschacher: [browser-tests] Access claims dynamically on a specific index [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 [15:57:53] let's try [15:58:34] (03PS2) 10Addshore: Format dates with more than 4 digit years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 [15:58:40] (03PS4) 10Addshore: Also Format 10years+ precisions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 [15:58:45] (03PS4) 10Addshore: Add i18n support in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 [15:59:03] (03PS3) 10Addshore: Remove space that should not be! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 [15:59:15] (03PS3) 10Addshore: Support formatting time dataType via API in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 [15:59:27] [13ValueView] 15snaterlicious opened pull request #13: Converted jQuery.valueview.preview to jQuery.ui.preview (06master...06previewwidget) 02http://git.io/IxXqOQ [16:01:22] (03CR) 10Tobias Gritschacher: "heyy" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 (owner: 10Addshore) [16:02:18] (03PS4) 10Addshore: Remove space that should not be!! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 [16:03:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109103 (owner: 10Tobias Gritschacher) [16:04:00] yay! [16:04:05] :> [16:04:05] WikidataJenkins is back! [16:04:55] i am not getting the valueParser error now [16:04:57] :) [16:05:14] probably is/wa caching [16:05:15] s [16:06:07] addshore: so http://wikidata.beta.wmflabs.org/wiki/Q873 has a link [16:06:22] it's not linked and css chops off the bottom part fo the text [16:06:57] Lydia_WMDE: [16:07:10] aude: yeah? [16:07:34] see the issue on beta [16:07:36] (03PS5) 10Addshore: Add i18n support in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 [16:07:42] no gadgets etc [16:07:44] http://wikidata.beta.wmflabs.org/wiki/Q873 [16:08:06] (03PS4) 10Addshore: Support formatting time dataType via API in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 [16:08:08] (03PS5) 10Addshore: Remove space that should not be!! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 [16:08:17] aude: works for me :P [16:08:17] aude: linked for me on first load and now not linked on reload [16:08:18] -.- [16:08:26] odd [16:08:32] very [16:08:33] linked to me on first load [16:08:35] i got it linked once [16:08:43] hit refresh and it dies [16:08:45] not linked 10 times [16:08:57] sounds a lot like a timing issue then [16:08:58] right, gone after the first reload... ewk [16:09:13] debug=true it works [16:10:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109663 (owner: 10Addshore) [16:10:33] same here [16:10:46] adrian said this will load things in a different order though [16:11:06] so that might be part of the issue [16:11:15] yep... can be an issue if we eg. don't have our dependencies right... [16:11:16] loading dependencies at different times [16:11:27] annoying [16:11:31] ack [16:11:31] and we almost never have our dependencies right... [16:11:37] :/ [16:13:47] WMDE is looking for ambitious pepole who seek demanding and creative work [16:13:52] Dependency Manager [16:14:07] lazowik: lol [16:14:20] Your task will be to explain people why it is not possible to handle dependecies correctly [16:14:36] :p [16:15:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109664 (owner: 10Addshore) [16:15:35] we just have to do less unnecessarily complicated stuff (TM) [16:15:57] and we're getting there but it's painful [16:16:01] yep [16:16:14] is anyone working on that, or shall I try to hunt that down? [16:16:46] hoo: the dependency issue right now? addshore and Tobi_WMDE had been looking into it but not sure about the status with them [16:17:03] Lydia_WMDE: Yes, the issue we have right now [16:17:25] the dependency issue, I havnt looked at that one since the daily! [16:17:44] yikes... so is anyone doing that right now? [16:18:04] asking in the other room [16:18:05] sec [16:20:02] hoo: didn't look into that [16:20:13] so if you do, that would be great [16:20:34] alright, https://gerrit.wikimedia.org/r/#/c/106721/ is not merged yet (breaking schema thing) [16:20:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore) [16:20:54] shall check with daniel, but think the others can be done independently (before or after we deploy) [16:21:32] i am going home now - will be back online in 45 mins or so [16:21:36] ok [16:21:55] Lydia_WMDE: Tobi_WMDE: Will have a look... hopefully I can reproduce it locally [16:22:54] (03PS5) 10Addshore: Support formatting time dataType via API in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 [16:23:19] (03CR) 10Addshore: "Fixed Uncaught TypeError: Cannot call method 'getDataType' of undefined in wikibase.formatters.register.js" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [16:25:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 (owner: 10Addshore) [16:26:07] aude: hoo: is there a way to figure out what version of DataValues is currently deployed on Wikidata? [16:26:31] (03CR) 10Addshore: [C: 04-1 V: 04-1] "i need to stop thinking about numbers...." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [16:26:44] Tobi_WMDE: Sure, but not this easy [16:27:11] hoo: aude: because, if https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FDataValues/bca24942e6f5bc6225f866e707dc54993edda78b is not deployed, then that would probably explain the issue [16:27:36] and that was merged into the wmf6 branch on dec, 11th. but we deployed on dec 10th AFAIK [16:27:41] (03PS6) 10Addshore: Support formatting time dataType via API in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 [16:27:51] and we probably never updated after that [16:27:56] whatever submodules there are [16:28:24] so we need to check whether that patch is in [16:28:37] and if not, then try to get that deployed [16:28:43] that would probably fix it [16:28:51] Tobi_WMDE: problem occurs in master [16:28:53] Tobi_WMDE: mh [16:28:54] if it is included already, then the issue is a different one [16:28:56] about the links [16:28:59] on beta [16:29:32] the commit might have got lost when datavalues got all split up though? [16:29:45] everything in https://git.wikimedia.org/log/mediawiki%2Fextensions%2FDataValues.git/refs%2Fheads%2Fmw1.23-wmf6 is deployed [16:30:09] DataValues @ bca2494 [16:30:28] addshore: then why would it appear on wikidata and on beta? [16:30:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [16:35:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 (owner: 10Addshore) [16:38:05] 01[13Common01] 15addshore created 06stringFormatterTrimTest (+1 new commit): 02http://git.io/Aeva-w [16:38:05] 13Common/06stringFormatterTrimTest 14a114d2c 15addshore: Test that StringFormatter does not trim whitespace [16:38:09] "Error: Property Entity unserializer expects a "datatype" field" wtf... keep getting that locally [16:38:30] [13Common] 15addshore opened pull request #2: Test that StringFormatter does not trim whitespace (06master...06stringFormatterTrimTest) 02http://git.io/8Kudbg [16:38:31] O_o [16:39:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109685 (owner: 10Addshore) [16:39:50] aude: hoo: henning might have spotted the issue [16:40:00] Tobi_WMDE: Which one? :P [16:40:17] the issue with url and commons datatype [16:40:34] :) [16:41:28] yay [16:42:28] so, we would need to fix it in datavalues-wmf6, in valueview 0.1.1-wmf11 and on master, right? [16:42:29] :) [16:42:35] if it is simple [16:42:54] hm.. henning will explain in a moment [16:42:56] :) [16:42:57] ok [16:43:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [16:43:09] otherwise, wait until thursday [16:43:28] aude: we would need to fix it in valueview 0.1.1 anyhow [16:44:09] yes [16:44:33] Ok, yes, I will try to explain... [16:44:34] for deploying, depends if it's easy [16:44:53] Anyone got an idea about my "Error: Property Entity unserializer expects a "datatype" field" ? [16:45:14] hoo: composer update? (too easy) [16:45:53] It seems the dataTypes registered in Wikibase (Commons + URL) are registered after ValueView's expert factory is filled. [16:45:57] aude: Did that, git pull, also ran DB updates, ... [16:46:10] ok [16:46:10] O_o [16:46:21] so just changing order of dependencies? [16:46:23] The data types are registered in Wikibase/lib/resources/wikibase.dataTypes/wikibase.dataTypes.js [16:46:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109691 (owner: 10Addshore) [16:46:54] The expert factory is filled in ValueView/resources/mw.ext.valueView.js [16:47:08] ok [16:47:17] That seems a bit odd since Wikibase depends on valueview of course. [16:47:32] * aude nods [16:48:44] mw.config.get( 'wbUsedEntities' ) [16:48:44] "{"P13":{"content":{"id":"P13","type":"property","labels":{"en":{"language":"en","value":"Website"}},"descriptions":[],"datatype":null},"title":"Property:P13"}}" [16:48:49] "datatype":null << wtf [16:48:54] any ideas? :P [16:48:58] The Expert factory implementation will probably change along with my refactoring. For a quick fix, I would propose putting the expert factory registration for commons and url data type experts from mw.ext.valueView.js to wikibase.dataTypes.js [16:49:32] Makes more sense to me. [16:50:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [16:50:38] It should be enough to check in wikibase.DataTypes if the the dataType experts are already registered and register them if not. [16:51:05] No change needed to ValueView then for that fix. [16:51:30] Hello [16:52:37] hoo: want to make a patch? [16:52:40] err Henning_WMDE [16:52:44] someone :) [16:53:41] Is there a problem with the p18 ? I do not have no more link to Wikimedia Commons what is very annoying. [16:53:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109688 (owner: 10Addshore) [16:54:37] aude: we'll do it [16:54:50] ok [16:54:54] i can try the patch [16:57:41] A null-edit fixed my Property-problem, btw... weird [16:58:32] I tried but found no info about p18 and an eventual bug or change. [16:59:25] Very disappointed because I contribute on visual arts. [16:59:42] Without image it's hard, believe me [17:00:36] Shonagon: https://www.wikidata.org/wiki/MediaWiki:Gadget-CommonsMedia.js is probably broken [17:01:17] or it isnt enabled on your account [17:01:20] oh you ! here ! nice! [17:01:35] Thanks Pyb [17:01:56] why why why https://gerrit.wikimedia.org/r/#/c/109297/ :p [17:02:01] but i don't think the problem is the gadget [17:02:32] the gadget doesn't work because ther is no link on p18 value [17:04:54] the gadget needs an element [17:05:26] Tried to fork it and to (temporaly) but will not be clean and easy [17:06:29] and I would like to know first if this problem is global or just limited [17:06:38] and if there is a solution [17:08:45] Shonagon: hmm en changeant la langue, les liens s'affichent puis disparaissent dès qu'on recharge la page... [17:10:30] hah aude nice patch there! [17:10:57] Pyb: ôO Un probème niveau moteur. [17:12:36] Shonagon: peut être un conflit entre l'extension Universal Language Selector et le gadget CommonsMedia.js ça me dépasse :) [17:13:39] Shonagon: the non-linked commons file is being worked on [17:13:45] it is not an issue of the gadget [17:14:26] Pyb: moi aussi. Bien vu en tout cas [17:15:04] Lydia_WMDE:Thanks for the information [17:17:23] Lydia_WMDE:Yes it is not the gadget but I was thinking thought about finding a temporay solution, maybe with the gadget [17:17:52] Shonagon: we hopefully have a fix soon [17:17:59] so i hope it's not needed [17:21:24] Lydia_WMDE:Ok thanks ! I will be patient and find another game than reviewing p31 of visual artworks. There are still some stuff to do :) [17:21:35] Shonagon: :D [17:21:55] (03PS1) 10Tobias Gritschacher: Register experts for URL and commons in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109916 [17:22:00] Shonagon: did you check out a related task force already? [17:25:21] hoo: aude: addshore: https://gerrit.wikimedia.org/r/#/c/109916/ [17:25:35] can someone please check if that fixes the issue with commons and url? [17:26:07] Lydia_WMDE:The job is here about verifcation of data that were not imported by the bot because of conflicts. [17:26:08] i can't reproduce locally [17:26:16] but can see that it doesn't break stuff [17:26:29] Shonagon: ah ok [17:26:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109916 (owner: 10Tobias Gritschacher) [17:27:54] aude: so, we need to merge it into wmf11 then and try it on beta.. :-P [17:28:15] xD [17:28:46] cant cherry pick it [17:28:56] youll have to merge it and add a change for the branch yourself Tobi_WMDE [17:29:15] i can put it in wmf6 [17:29:24] cant put it in wmf11 apparently [17:30:03] (03PS1) 10Aude: Register experts for URL and commons in Wikibase [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/109917 [17:30:25] * aude notices submitting patches to gerrit is super quick [17:30:36] has it been faster for others recently? [17:30:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/109917 (owner: 10Aude) [17:31:20] obvious [17:31:47] (03PS15) 10Bene: Create more tests for special pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 [17:32:05] politely ignore jenkins [17:32:10] :> [17:33:39] (03CR) 10Aude: [C: 032] "seems to work fine" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109916 (owner: 10Tobias Gritschacher) [17:34:03] (03Merged) 10jenkins-bot: Register experts for URL and commons in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/109916 (owner: 10Tobias Gritschacher) [17:34:06] i'd like to do wmf6 before making patch for wmf11 [17:34:08] aude: gerrit was updated to a newer version so maybe that's why [17:34:23] it's been fast [17:34:33] Tobi_WMDE: fyi: filed bug for reviewing default gadgets for performance [17:34:34] * aude thinks being near ashburn is perhaps a reason [17:34:41] hah [17:34:44] or that [17:34:53] anyway https://gerrit.wikimedia.org/r/#/c/109917/ [17:35:18] then we can update core submodules and this can go out in a couple hours when core is updated on wikidata [17:35:42] nice [17:35:52] (03PS1) 10Tobias Gritschacher: Register experts for URL and commons in Wikibase [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109918 [17:36:00] should i just merge? i verified manually on the branch [17:36:06] addshore: https://gerrit.wikimedia.org/r/#/c/109918/ [17:36:09] for wmf11 [17:36:26] who changed mm to mmediaWiki btw?? [17:36:29] which are we going to deploy first? :P [17:36:37] to beta or to wikidata xD [17:36:37] mw to mediaWiki [17:36:38] Tobi_WMDE: no idea [17:36:49] either should be ok (i think) [17:37:14] we can deploy to beta first but i'd like to prepare core submodule while i have stuff ready [17:37:15] we should deploy it to beta and see if the issue is gone [17:37:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [17:37:41] i have not verified it because the issue was never there for me locally [17:37:48] (03CR) 10Addshore: [C: 032] Register experts for URL and commons in Wikibase (031 comment) [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109918 (owner: 10Tobias Gritschacher) [17:37:55] i verify it doesn't break anything [17:38:02] alright, let's make a new build :) [17:38:10] (03Merged) 10jenkins-bot: Register experts for URL and commons in Wikibase [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109918 (owner: 10Tobias Gritschacher) [17:39:02] silly jenkins merging before veriifying [17:39:09] is there no way to stop that hashar ? :> [17:39:58] addshore: https://gerrit.wikimedia.org/r/#/c/109918/ ? [17:40:05] Tobi_WMDE: is there a bug for this? [17:40:14] you did +2 , then 3 jenkins job were all successful and the change got merged [17:40:23] yes but hashar the wmf jenkins should never +2v now :P [17:40:31] but for some reason the "change has been merged successfully merged" can appear before the jobs results :D [17:40:35] (03PS1) 10Aude: update build, Register experts for URL and commons in Wikibase [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109919 [17:40:47] I did +2 for code review and jenkins had done +1v, bu then it does +2v based only on linting [17:41:23] and then merges it :P [17:41:39] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109918 (owner: 10Tobias Gritschacher) [17:41:41] yeah that is what is defined in Zuul configuration [17:41:52] (03CR) 10WikidataJenkins: Register experts for URL and commons in Wikibase (031 comment) [extensions/Wikibase] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109918 (owner: 10Tobias Gritschacher) [17:42:00] addshore: http://paste.debian.net/78874/ [17:42:11] or plain http://paste.debian.net/plain/78874 [17:42:16] how could we stop that then? :P [17:42:40] well check-only is meant for linting jobs only [17:42:41] wow, the bot is leaving comments [17:42:50] so it just vote +1 giving clue to people that tests should be run [17:42:54] addshore: we could remove the gate-submit, but then it wont be merged automatically [17:43:13] if you want the change to merge in on CR+2 , you must have V+2 so gate-and-submit always vote V+2 [17:43:18] Tobi_WMDE: seems like a sensible thing to do, would lead to less surprise merges before tests have been run :P [17:43:42] we would need to setup the gate-submit thing on our jenkins [17:43:43] addshore: we could run tests but you got rid of them... [17:43:47] and run the tests [17:44:02] i didnt get rid of them :P [17:44:08] but I guess for the gate-submit we need zuul, and thats not set up properly yet [17:44:09] (03PS1) 10Aude: new build, Register experts for URL and commons in Wikibase [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109920 [17:44:11] s/you/someone/ /-D [17:44:29] https://gerrit.wikimedia.org/r/#/c/109919/ is for beta [17:44:35] (03CR) 10Addshore: [C: 032 V: 032] new build, Register experts for URL and commons in Wikibase [extensions/Wikidata] (mw1.23-wmf11) - 10https://gerrit.wikimedia.org/r/109920 (owner: 10Aude) [17:44:53] beta is using master now? [17:45:05] addshore: it should yes [17:45:08] (03CR) 10Addshore: [C: 032 V: 032] update build, Register experts for URL and commons in Wikibase [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109919 (owner: 10Aude) [17:45:45] I am out for dinner … Follow up via bugzilla / email =) [17:45:45] not master wikibase [17:45:48] master wikidata [17:45:59] we'll switch on thursday to master wikibase [17:46:04] aude yes! [= [17:46:23] how's the puppet thing? (guess i should look at it) [17:47:17] well the build is done regularly, but the problem is the build script doesnt output what we are actually using yet [17:48:06] i have to understand what more it can do for us than out little build.sh script [17:48:14] sure there are advantages [17:48:39] The build script isn't like very polished yet... [17:48:46] true [17:48:54] why is it eg. recloning all the time? [17:49:48] well, im using the WikidataBuilder which is what i got told we were using [17:49:51] i guess being near ashburn, recloning is super fast [17:49:58] but if the bash script does it i see no reaosn not to use it [17:50:03] i'll see when i come back to germany :) [17:50:05] aude: How fast is super-fast? [17:50:25] seconds for cloning, instant to submit to gerrit [17:50:32] well aude in the wikidata repo atm you still have a sbumodules file right? [17:50:34] in germany, i had time to cancel if i changed my mind [17:50:44] mh... in MiB/s (for the cloning) [17:50:46] addshore: for easy rdf [17:50:53] ahh, just for easy rdf [17:50:54] hmmmm [17:51:36] see https://github.com/addshore/WikidataBuild [17:51:37] 2 mb/s [17:51:49] wont work properlly without a git submodules file i dont think :P [17:51:50] addshore: we are turning easy rdf into composer [17:51:58] aude: thats already done on master [17:51:58] aude: mh... I peaked at 1.8 or so... often the server deliver much less, though [17:52:22] ut its not easyrdf thats causing the problem [17:54:14] No submodule mapping found in .gitmodules for path 'extensions/ValueView' [17:54:28] but when you make the build in your bash script you use --no-dev [17:55:00] and prefer-dist [17:55:11] if they would be implemented in the WikidataBuilder it would be fine [17:55:15] git rm --cached extensions/ValueView [17:55:29] but your pull request did exactly the opposite as far as I can tell :P https://github.com/wmde/WikidataBuilder/pull/5 [17:55:46] either way is probably ok [17:56:14] well in that case i might patch the builder in the morning then :) [17:56:17] and then all should work [17:57:44] i suppose if we needed a security patch, then i would patch the extension and somehow make composer use that to make a new build [17:57:58] or manually patch the build (patch goes in bugzilla) [17:58:20] not exactly sure how that would end up working [17:58:25] me neither [17:58:33] you could of course apply the patch locally in production [17:58:36] that will always work [17:58:37] it would make it challenging to cherry pick additional stuff on a security patch [17:58:41] addshore: that's how it's done [17:58:47] then thats fine [17:58:51] i think :P [17:59:23] then cherry pick additional stuff in production (if needed) [18:00:24] but yes, then you would be able to make a patch on the build as a whole rather than any individual module [18:00:40] and then apply the patch to the build rather than the individual module [18:01:05] yep [18:01:09] :> [18:01:17] hopefully never needed to do that [18:01:30] indeed :p [18:02:14] addshore: in the build we have config file https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikidata/1b52a39cfe0de5a88a46b97b5572e2b4beef9e7e/extension-list-wikidata [18:02:38] can we have that managed with grunt? [18:02:47] i believe so [18:02:59] right, lets go take a stab at it now :P [18:03:01] i just grepped for all i18n files [18:03:08] k [18:06:10] Tobi_WMDE: addshore http://wikidata.beta.wmflabs.org/wiki/Q873 works! [18:06:15] [= [18:07:25] aude: hmm [18:07:29] it's not linked for me [18:07:52] * addshore hasnt checked yet [18:08:55] heh.. what?! [18:09:03] it IS on firefox [18:09:08] but not on chrome [18:10:22] linked for me in chromium [18:10:27] 01[13WikidataBuilder01] 15addshore created 06addshorePatch (+2 new commits): 02http://git.io/kuoPaA [18:10:27] 13WikidataBuilder/06addshorePatch 1466ee356 15addshore: Use --prefer-dist for composer install [18:10:27] 13WikidataBuilder/06addshorePatch 14a31d30b 15addshore: Add extension-list-wikidata to wikidata build resources [18:10:33] linked for me in chrome [18:10:39] hmmm [18:10:48] Tobi_WMDE: purge? [18:10:53] ok for me on FF, chrome and IE [18:11:11] [13WikidataBuilder] 15addshore opened pull request #6: Patch to make the output more useable (06master...06addshorePatch) 02http://git.io/lt4oIQ [18:11:16] ok, then it's probably a cache issue for me [18:11:18] aude see the pull request :) once thats merged ill poke it all to make a build for me [18:11:18] Lydia_WMDE wants to purge who? [18:11:25] JeroenDeDauw: you of course [18:11:26] ;-) [18:11:41] * JeroenDeDauw hides behind a pile of Belgian fries [18:11:48] i can still see you! [18:11:58] works [18:12:11] Lydia_WMDE stop eating the fries, hax! [18:12:18] but but but [18:12:27] nomnomnom [18:12:28] (03PS1) 10Hoo man: Make build.sh a little faster [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109929 [18:12:31] aude: ^ [18:13:07] meh [18:13:15] O_o [18:13:31] aude: ^ You'll thank me once you're on a bad connection :P [18:13:37] xD [18:14:04] ok :) [18:14:49] (03CR) 10Aude: [C: 032] Make build.sh a little faster [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109929 (owner: 10Hoo man) [18:14:52] hah! travis just randomly joins and leaves... [18:15:02] dont' know if jenkins merged [18:15:03] merges [18:15:04] addshore: It got quite shy recently [18:15:18] anyone take a speedy look at http://git.io/lt4oIQ ? :)_ [18:15:23] it will make my day! xD [18:15:35] * aude wants one review panel [18:15:36] aude if it hasnt just click submit! [18:16:52] (03Merged) 10jenkins-bot: Make build.sh a little faster [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/109929 (owner: 10Hoo man) [18:17:21] addshore: you have comments [18:17:27] [13WikidataBuilder] 15filbertkm comment on commit 14a31d30b: if the build is putting wikibase in the vendor directory then this needs to do accordingly 02http://git.io/PWvvhw [18:17:45] oh, ok [18:17:53] of course! :) [18:18:32] its actually going in the extensions directory [18:19:35] to try it, i checkout addshorePatch branch? [18:19:45] aude: yes [18:19:54] just pushed the fixes to the path [18:19:55] 01[13WikidataBuilder01] 15addshore pushed 1 new commit to 06addshorePatch: 02http://git.io/0gS2sA [18:19:55] 13WikidataBuilder/06addshorePatch 14a4562df 15addshore: Correct paths in extension-list-wikidata [18:21:22] Fatal error: Unable to find local grunt. [18:21:43] i can test it on our instance if you want? [18:21:58] i want to test! [18:22:04] i used grunt before [18:22:07] xD [18:22:28] i guess reinstall grunt-cli [18:22:53] * hoo pats travis-ci [18:22:58] haha! [18:23:13] anyone any idea off the top of their head how to git::clone in puppet a specific branch? [18:23:15] addshore: Shall I rather grunt at it :P [18:24:09] heh, just add a branhc, awesome [18:24:29] Cannot find module 'extend' [18:24:40] git clone -b [18:25:27] just done https://github.com/addshore/puppet/commit/2cbd1965b4c1b4fba1f4948e7a27473abf2e30ec [18:25:32] going to run the selenium tests on beta now. hope they pass again [18:25:35] will poke the instance and see what happens :P [18:25:50] would be the first time that they pass since jan 8th. :-D [18:26:07] date [18:26:13] opps wrong window [18:26:21] ok [18:26:42] should see a new buld at https://github.com/addshore/WikidataBuild/commits/master in 5 mins [18:30:40] [13WikidataBuilder] 15filbertkm comment on commit 14a31d30b: i don't see the file in the build :/ 02http://git.io/I9XSaQ [18:31:46] (03PS16) 10Bene: Create more tests for special pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 [18:34:23] addshore: how do i give -1 on github? [18:35:05] (03PS21) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [18:35:14] (03CR) 10jenkins-bot: [V: 04-1] Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [18:37:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102495 (owner: 10Bene) [18:38:36] (03PS22) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [18:39:49] hmm aude apparently that also leaves the .git folder in it or something odd [18:40:37] maybe I will just have to add another bit to my script to delete the .git folder we dont want... [18:40:50] I thought JeroenDeDauw added that, maybe its an option I havnt turned on! [18:41:11] https://github.com/wmde/WikidataBuilder/commit/decb48a161de08d6b493d61eacff23987d145249 [18:41:12] hmmm [18:41:27] something somewhere is slightly wrong then :D [18:42:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [18:42:31] ahh! puppet didnt pull my branch of the buildscript... [18:43:30] which means my change at https://github.com/addshore/puppet/commit/2cbd1965b4c1b4fba1f4948e7a27473abf2e30ec doesnt quite do what i expected... [18:44:17] fun [18:44:52] either the branch or ensure latest just doesnt work >.> [18:45:06] can https://gerrit.wikimedia.org/r/#/c/109917/ be merged? seems fine on beta [18:45:21] (03CR) 10Addshore: [C: 032 V: 032] Register experts for URL and commons in Wikibase [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/109917 (owner: 10Aude) [18:45:35] yay [18:45:51] Where's that wikidatabuilder-puppet supposed to run? [18:46:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [18:46:11] :( [18:46:14] hoo labs [18:47:23] mh [18:47:34] cd /home/wdbuilder/wikidata [18:47:52] git add * ... you probably want git add :/ [18:48:51] feel fre to poke it :P this is still a work in progress :P [18:49:28] Just saying :P Once we really run on that I might polish stuffs [18:49:41] :P [18:49:51] why is the puppet git::clone module silly [18:50:47] i'm sure grunt is better but the bash script is quite clear what it does [18:51:07] anyone care to merge that pull req on wikidataBuilder ? :> [18:51:08] anything we can do to improve the grunt thing, great [18:51:27] if that request gets merged i should be able to make it work [18:51:37] the only thing that is stopping me is silly puppet git clone right now [18:51:44] (03PS23) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [18:51:45] as long as there is follow up, ok [18:51:55] (03CR) 10jenkins-bot: [V: 04-1] Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [18:51:56] a follow up..? for what? [18:52:12] häää??? [18:52:18] oh, ..... [18:52:21] I did that seconds after you made the comment ;p [18:52:31] addshore: i think we went with --prefer-source also to avoid hitting the github api [18:52:43] wtf do I again have to rebase this f...... change??? [18:52:55] depends how often we make builds, but that could be issue (like we see on travis) [18:54:19] aude: not sure I follow, we hit github whatever happens [18:54:36] benestar: Yes, but hitting "rebase" withing gerrit will also do [18:54:37] hitting the api, there are limits [18:54:42] that's why travis failed [18:54:43] 01[13WikidataBuilder01] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/RMNkgQ [18:54:44] 13WikidataBuilder/06master 141e09984 15Katie Filbert: Merge pull request #6 from wmde/addshorePatch... [18:54:49] we can try this though [18:54:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1642 (mw1.23-wmf6 - 2b32fd2 : Tobias Gritschacher): The build has errored. [18:54:50] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/370421e096d4...2b32fd2748dc [18:54:50] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17785409 [18:55:01] ahh, shouldnt hit that, would only be doing hourly / daily builds i guess [18:55:16] should be okay and if it becomes issue, we can look at changing [18:55:22] aude: really? How do you figure we are running into a limit? [18:55:31] travis seems to be [18:55:42] or github is just complaining [18:55:45] aude: So this is just a guess? [18:55:56] (03PS24) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [18:56:02] JeroenDeDauw: why do you think travis complained? [18:56:05] aude: I doubt it is a limit, that is not congruent with what I have seen [18:56:07] Could be ofc [18:56:31] URL could not be accessed: HTTP/1.1 403 Forbidden [18:56:43] [Composer\Downloader\TransportException] [18:56:57] aude: general flakyness of the GH API for downloading these things is what I have been thinking [18:57:04] could be [18:57:18] anyway, we can see how it goes [18:57:37] only in 3 mins we should have a build again [18:57:40] ok [18:57:44] using the changes you just merged [18:57:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [18:57:53] \o/ [18:57:57] \o/ [18:58:08] :) [18:58:09] fingers crossed :D then I will be happy! [18:58:36] addshore: you can review :P [18:58:50] benestar: I will either tonight or tommorw :) [18:58:59] thx [18:59:12] addshore: I think you are the only person that is reviewing my changes... [18:59:19] :D [19:00:07] running :> [19:00:34] oh come on .... [19:00:56] back later [19:02:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [19:03:12] benestar: what change? [19:03:52] JeroenDeDauw: this https://gerrit.wikimedia.org/r/#/c/98281/ https://gerrit.wikimedia.org/r/#/c/102495/ [19:04:12] JeroenDeDauw: also here is an unanswered comment: https://gerrit.wikimedia.org/r/#/c/108337/ [19:05:17] benestar: will have a look after I assambled my new pc [19:05:25] great :) [19:14:24] hmm hoo, it doesnt seem to add everything in the directory.... [19:14:33] that seems to be the problem im stuck on >.> [19:15:10] i would have thought git add * would have done exactly that [19:15:29] addshore: git add * will only add the first file AFAIR [19:15:39] but don't really count on me, I haven't slept in ages [19:15:42] hmm [19:15:44] :d [19:15:52] only caffeine is keeping me alife :D [19:16:00] come here, we have more ;p [19:16:03] git add :/ will run through the whole working tree [19:16:12] thats what I want [19:16:13] but [19:16:32] wdbuilder@wikidata-builder1:~/wikidata$ git add [19:16:32] Nothing specified, nothing added. [19:16:32] Maybe you wanted to say 'git add .'? [19:16:47] addshore: the ":/" is part of that [19:17:10] addshore: what do you want to do? [19:17:26] wdbuilder@wikidata-builder1:~/wikidata$ git add :/ [19:17:26] wdbuilder@wikidata-builder1:~/wikidata$ git commit -a [19:17:26] # On branch master [19:17:26] nothing to commit (working directory clean) [19:17:26] $ git add :/ [19:17:38] ok, then there's nothing that changed :P [19:17:51] git add -A [19:18:09] wdbuilder@wikidata-builder1:~/wikidata$ git add -A [19:18:09] wdbuilder@wikidata-builder1:~/wikidata$ git commit -a [19:18:09] # On branch master [19:18:09] nothing to commit (working directory clean) [19:18:24] addshore: do touch foo or so (for testing) [19:18:25] this is silly, https://github.com/addshore/WikidataBuild [19:18:33] if nothing change, you can't commit anyhting... right [19:18:34] i don't exactly understand the problem [19:19:27] +1 [19:19:33] +2 [19:19:50] well, you can see the commits the script has pushed to https://github.com/addshore/WikidataBuild [19:19:55] but alas! where is the code! [19:20:32] addshore: :P [19:20:39] * aude eats [19:20:40] Did you remove the .git in those? [19:20:53] there are no .git folders in any of the subdirectories [19:21:08] hence my confusion [19:21:50] there is a .git folder in ~/wikidata [19:22:00] addshore: Probably there ones were some [19:22:05] * once [19:22:20] hmm maybe go around and try and make git force remove them all? [19:22:25] maybe its all confused like i am [19:22:26] and now you have to tell git that these are no longer meant to be repos [19:23:03] wdbuilder@wikidata-builder1:~/wikidata$ git rm extensions/ValueView/.git [19:23:03] fatal: pathspec 'extensions/ValueView/.git' did not match any files [19:23:06] blergh [19:23:33] try it w/o the /.git [19:23:57] wdbuilder@wikidata-builder1:~/wikidata$ git rm extensions/ValueView [19:23:58] rm 'extensions/ValueView' [19:23:58] fatal: git rm: 'extensions/ValueView': Is a directory [19:23:58] wdbuilder@wikidata-builder1:~/wikidata$ git rm extensions/ValueView/ [19:23:58] fatal: pathspec 'extensions/ValueView/' did not match any files [19:24:26] hah! [19:24:41] try git rm -r [19:24:47] https://www.irccloud.com/pastebin/gCNxlp9F [19:24:51] way ahead of you :P [19:25:18] so...? [19:25:32] https://github.com/addshore/WikidataBuild/commit/ffe47b7ea25ec13047ce76ba1d810b16b7d32d3e [19:25:43] that definatly removed all of the subprojects, so now lets try it all again xD [19:26:07] :D [19:26:13] "New code deploy for Wikidata (with dependency on schema change)" [19:26:15] Schema chnage? [19:26:17] You know you didn't have to commit taht, right [19:26:23] Reedy: That's not in there [19:26:33] Wikitech lies [19:26:33] who wrote taht *sigh* [19:26:36] hoo, wnated to make sure github wasnt confused either :> [19:27:50] hoo worked :> [19:27:51] :P [19:28:00] git must have just been confused from before [19:28:08] aude: hoo >> https://github.com/addshore/WikidataBuild [19:28:13] It wasn't confused, that's just how the index works [19:30:55] systemctl restart braind.service [19:31:06] not exactly sure where that extensions file I added has gone.. [19:34:20] JeroenDeDauw: what determines what build_resources are copied into the build? I seem to remember you saying everything there would be [19:43:23] Reedy: no schema changes needed today [19:43:44] but we have to for sean to do soon as possible [19:43:46] two* [19:43:59] addshore: https://github.com/wmde/WikidataBuilder#build-results [19:44:13] point is: Not today ;) [19:44:16] addshore: something not being copied? [19:44:16] Are they on his todo list? [19:44:23] JeroenDeDauw: indeed [19:44:26] addshore: IIRC there was something not implemented yet [19:44:27] i think [19:44:34] * aude finds the bugs [19:44:36] files without extensions or hidden files or something like that [19:45:14] file without an extension indeed [19:45:50] addshore: y u have a file without extension? ;p [19:46:03] addshore: anyway, ought to be easy enough to add that [19:46:05] cause aude want file with no extension! [19:46:22] aude: so it's your fault! [19:47:13] evil builder! [19:47:19] evil aude! [19:47:23] :) [19:48:21] aude: seriously though, why do you need a file w/o ext? [19:48:54] it's a config file [19:49:04] needs no ext [19:49:07] can we not give it an extension? :> [19:49:11] .aude [19:49:26] hahah! .aude!!! [19:49:31] :) [19:50:22] +1 [19:51:32] I can look at that later this evening, unless someone already wants to taclke it ofc [19:57:02] ideally file is automatically generated when an i18n file is created, deleted or moved [19:59:25] aude: if it just needs to list all files ending on .i18n.php, then generating the thing on every build is rather trivial right [19:59:34] yep [19:59:58] Reedy: greg-g https://bugzilla.wikimedia.org/show_bug.cgi?id=60539 and https://bugzilla.wikimedia.org/show_bug.cgi?id=60540 [20:00:13] sean knows but whatever needs to be done to make those official and on his calendar is good [20:00:48] afaik deployment does not depend on those and schema does not depend on deploying new code [20:18:34] addshore: aude: really? There is a giant TODO section in the README that has as first point files w/o extensions are not supported! wuhaaa! [20:22:00] cp * [20:58:22] (03CR) 10Aude: [C: 032] (bug 47070) No import of wikitext to entity NS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100565 (owner: 10Daniel Kinzler) [20:59:29] (03Merged) 10jenkins-bot: (bug 47070) No import of wikitext to entity NS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100565 (owner: 10Daniel Kinzler) [21:13:33] aude: that is not a valid node.js command :) [21:14:10] addshore: we should just write node.aude [21:18:21] heh [21:29:56] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/110055 (owner: 10L10n-bot) [22:49:49] 01[13WikidataBuilder01] 15JeroenDeDauw 04deleted 06addshorePatch at 14a4562df: 02http://git.io/rPbXHg [23:50:20] Abraham_WMDE: I don't get an ASCII cat back? [23:50:23] :'( [23:53:36] JeroenDeDauw: check