[02:15:53] (03PS1) 10Jeroen De Dauw: Revert "Clean up error for claim index out of bounds" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108648 [02:16:23] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] "The commit this reverts broke the tests on master. Will need to be re-submitted after the issue is fixed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108648 (owner: 10Jeroen De Dauw) [02:24:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/94b3aa7 : Jeroen De Dauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17314852 [08:18:56] (03CR) 10Adrian Lang: "Great! I wonder if this could be factored out into a function both widgets can call instead of having the code and the tests duplicated. M" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [08:20:05] (03CR) 10Adrian Lang: "Yeah, I think the issue is that we have to go through the DOM in order to start editing. We should be able to just call something like thi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108338 (owner: 10Hoo man) [08:28:05] (03PS1) 10Adrian Lang: Use shortcut references to globals [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108662 [08:53:21] is changing the order of whole statements broken only for me? tried the move statements in Q14560 but the change (visible in the UI) was not permanent. [08:54:53] hmm it is working on test.wikidata.org [09:04:05] * hoo_ waves [09:06:51] o/ [09:07:04] (03CR) 10Hoo man: "Not sure about that, as not all childs are going to support this..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [09:22:55] (03PS2) 10Hoo man: Make Wikibase Client tests pass if no ClientStore can be constructed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 [09:25:22] (03PS3) 10Hoo man: Make Wikibase Client tests pass if no ClientStore can be constructed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 [09:26:41] addshore: Can you run the tests for that? I'm on my netbook and don't have more than the code around... [09:27:14] or anyone else,,, [09:27:44] (03CR) 10Hoo man: "Don't use Wikibase\Settings, per Jeroen... untested" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 (owner: 10Hoo man) [10:13:33] cu [11:59:28] any developers around > [11:59:31] ??? [11:59:39] !admin [11:59:49] the ULS on top of the page is gone !! [11:59:53] I need that [12:10:52] what do you need uls for? [12:11:47] I cant test it right now, because its loading unbelivable slow right now [12:13:07] its gone for me too [12:13:09] GerardM-: same for me [12:13:43] I am adding information about the Telugu calendar [12:13:59] many of the items I want to refer to have articles but no item [12:14:04] ULS is installed according to Special:Version [12:14:32] so I have to add items where I know the Telugu name but not the English (or any of the other languages I know) [12:14:44] yes .. it is broken [12:14:54] I created a high priority bugzilla bug [12:18:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=60281 [12:45:41] hello? [12:45:49] If you're missing ULS, you have to re-enable it in your preferences again [12:46:08] https://www.wikidata.org/wiki/Special:Preferences#mw-input-wpuls-enable [12:52:27] Who can help if I can't add interwikis, labels and descriptions to the items? [13:07:23] (03PS4) 10Addshore: Implement hack to avoid UI throwing this error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 [13:07:25] (03PS1) 10Addshore: Clean up error for claim index out of bounds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108672 [13:09:53] (03CR) 10Adrian Lang: [C: 032] Clean up error for claim index out of bounds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108672 (owner: 10Addshore) [13:10:14] (03Merged) 10jenkins-bot: Clean up error for claim index out of bounds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108672 (owner: 10Addshore) [13:20:11] (03CR) 10Addshore: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [13:20:27] (03CR) 10Addshore: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [13:24:06] (03PS5) 10Addshore: Implement hack to avoid UI throwing this error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 [13:31:58] (03CR) 10Adrian Lang: [C: 032 V: 032] Implement hack to avoid UI throwing this error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 (owner: 10Addshore) [13:32:18] (03Merged) 10jenkins-bot: Implement hack to avoid UI throwing this error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 (owner: 10Addshore) [13:48:43] (03CR) 10Adrian Lang: "I just tried it out with addshore and we thought that the main label and description inputs (those on the top) should not use the language" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [13:48:53] (03PS4) 10Addshore: Include dataType id in API output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108530 [13:49:01] (03CR) 10jenkins-bot: [V: 04-1] Include dataType id in API output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108530 (owner: 10Addshore) [14:21:43] Adrian_WMDE: >> https://www.wikidata.org/wiki/Special:ListDatatypes [14:35:09] hi, the faq says i should just remove wrong interwiki links, but this action is not permitted. What should i do? [14:38:01] 01[13Serialization01] 15addshore created 06rmunuseduse (+1 new commit): 02http://git.io/KrVF8g [14:38:01] 13Serialization/06rmunuseduse 148784217 15addshore: Remove unused use statement [14:38:26] [13Serialization] 15addshore opened pull request #4: Remove unused use statement (06master...06rmunuseduse) 02http://git.io/EuthIA [14:39:33] I still can't add interwikis/labels/descriptions to the pages, until I log off. What happened? [15:07:39] 01[13WikibaseDataModelSerialization01] 15addshore created 06snakDeserPropIdExceptionTest (+1 new commit): 02http://git.io/Geez3Q [15:07:39] 13WikibaseDataModelSerialization/06snakDeserPropIdExceptionTest 147eb88ba 15addshore: Add test for catching EntityIdParsingExceptions [15:08:19] [13WikibaseDataModelSerialization] 15addshore opened pull request #4: Add test for catching EntityIdParsingExceptions (06master...06snakDeserPropIdExceptionTest) 02http://git.io/BkFpIg [15:09:23] (03PS50) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [15:09:27] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/4/ (1/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:09:29] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/4/ (2/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:12:28] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/4/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:15:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:21:16] (03PS51) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [15:21:20] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/5/ (1/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:21:22] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/5/ (2/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:24:25] hey guys, how do i change a permalink URL resolver for a property? [15:24:36] is that something that's hardcoded in the source or is there some way to edit it myself? [15:24:43] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/5/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:25:45] huskyr: You probably want the hack at https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js ;) [15:27:01] hoo: aha :), i thought that was something well thought out and in the database somewhere ;) [15:27:07] hoo: thanks anyway :) [15:27:18] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:27:55] huskyr: Planned to do that better in the future, but for now it's that little hack maintained by the Wikidata Community [15:28:58] hoo: oh well, better than nothing i guess. [15:33:56] (03PS52) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [15:33:59] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/6/ (1/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:34:01] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/6/ (2/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:34:40] I still can't add interwikis/labels/descriptions to the pages, until I log off. What happened? [15:35:38] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/6/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:37:03] Renessaince: Still? How long have that been? [15:39:00] since yesterday [15:40:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:40:32] I explained more on this issue here: https://www.wikidata.org/wiki/Wikidata:Project_chat#Q7697874 [15:41:10] Renessaince: Ok... which browser do you use? [15:41:29] (03PS53) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [15:41:32] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/7/ (1/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:41:34] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/7/ (2/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:41:36] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/7/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:41:37] Firefox 26.0 [15:44:32] Renessaince: Ok... please follow these steps: Press Ctrl + Shift + K in Firefox, then again visit an item page which you can't edit [15:46:43] (03PS54) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [15:46:47] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/8/ (1/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:46:49] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/8/ (2/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:47:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:47:04] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/8/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:47:09] Renessaince_: Tell me when you got that ;) [15:48:12] that happened yesterday evening first [15:48:56] Renessaince_: I was referring to this: "Ok... please follow these steps: Press Ctrl + Shift + K in Firefox, then again visit an item page which you can't edit" [15:49:08] ah, I missed that [15:50:27] hmmm... console? [15:50:53] Renessaince: Yep, it will log any JavaScript errors happening on the page [15:51:07] ok, done [15:51:31] Ok, you should uncheck all Tab in the console except of "JS" [15:51:52] did You read? https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard#Q7697874 Maybe that helps as well [15:51:54] Some orange line should be left [15:52:31] mh, sounds like an ULS failure (again :/) [15:52:47] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [15:53:05] Did you follow the steps? That way we will hopefully be able to confirm this suspicion [15:53:29] hoo: yes, once again [15:53:44] with all but JS buttons disabled [15:54:03] what does it say in there? [15:54:12] Ужыванне getPreventDefault() асуджана. Скарыстайцеся defaultPrevented замест. [15:54:17] Ужыванне getAttributeNode() асуджана. Карыстайцеся getAttribute() замест. [15:54:22] Ужыванне атрыбута specified у атрыбутах асуджана. Ён заўсёды вяртае true. [15:54:26] ReferenceError: userIsInGroup is not defined [15:55:32] Ok, the fourth one is interesting (the top ones can be ignored, those are coming from Firefox components) [15:55:36] First two are: Use of prohibited. Use instead [15:55:45] ah, ok [15:55:51] Tobi_WMDE: does that mean we can turn your jenkins on for master for now? :> [15:56:31] Renessaince: Please append ?debug=true to the URI of the item now and log what appears in the console :) [15:56:40] * look at [15:57:18] (03PS1) 10Tobias Gritschacher: Fix SpecialMyLanguageFallbackChainTest to not use hardcoded string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108683 [15:58:25] just the same, but in the different order [15:58:35] «ReferenceError: userIsInGroup is not defined index.php:308» stands 2nd now [15:59:13] ok, on the right there should be a file name (where the error appeared in), can you copy that over? [15:59:41] index.php:308 [15:59:59] wait, I reloaded page once again, something new appeared [16:00:10] TypeError: activeInstances[i].update is not a function [16:00:34] https://bits.wikimedia.org/static-1.23wmf10/extensions/Wikibase/lib/resources/jquery.wikibase/jquery.wikibase.claimgrouplabelscroll.js [16:01:04] (03CR) 10Addshore: [C: 032] Fix SpecialMyLanguageFallbackChainTest to not use hardcoded string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108683 (owner: 10Tobias Gritschacher) [16:01:25] (03Merged) 10jenkins-bot: Fix SpecialMyLanguageFallbackChainTest to not use hardcoded string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108683 (owner: 10Tobias Gritschacher) [16:01:37] Renessaince: Thanks, interesting [16:02:38] Renessaince: Which item did you see these errors on? [16:03:01] Q7697874, but I can't edit any item at all [16:03:20] ReferenceError: userIsInGroup is not defined [16:03:34] https://meta.wikimedia.org/w/index.php?title=User:PiRSquared17/twinkle.js&action=raw&ctype=text/javascript [16:03:54] ewk, that's a twinkle error [16:03:54] index.php:308 [16:04:15] Do you ahve Twinkle enabled as gadget maybe? [16:04:37] omg [16:04:48] I sent a request to add it maybe a month ago [16:05:00] do they add it without a warning? [16:05:59] Кириллица ... looks like my ibus works again :D [16:06:20] Renessaince: No, let me have a look at that [16:07:31] hoo: there is no twinkle in the gadget tab [16:08:30] Renessaince: You are importing it yourself using your common.js (https://www.wikidata.org/wiki/User:Renessaince/common.js) [16:08:34] * from https://www.wikidata.org/wiki/User:Renessaince/common.js [16:09:46] ah, so they added it calmly [16:10:00] 20:04, 20 студзеня 2014‎ Pathoschild (гутаркі | унёсак)‎ . . (117 байтаў) (+117)‎ . . (global JavaScript (requested by Renessaince)) [16:10:20] Hopefully that's it... try disabling it :) [16:13:31] can't believe it works! [16:13:47] \o/ :) Great [16:13:52] thanks hoo and whom to report about twibkle? ;) [16:14:00] *twinkle [16:14:24] !admin - can an admin please pm me for revealing private data? [16:14:33] Jurgen: pm me [16:15:00] Renessaince: Let me check that out [16:15:23] oh, I think author is [[en:Wikipedia:Twinkle]] here [16:16:02] Renessaince: No [16:16:08] the problem is the fork on meta, probably [16:16:42] ok, will You let me know when it be fixed> ;) [16:16:48] ok, will You let me know when it be fixed? ;) [16:17:21] sorry for double messaging, skype legacy [16:17:35] Renessaince: heh [16:21:06] Renessaince: I'm not going to fix that, can you please contact PiRSquared about that? [16:21:36] Looks like a simple race condition [16:26:59] (03PS55) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [16:28:45] PiRSquared17? Hmmm... so this not about twinkle? [16:29:07] Renessaince: It is... it's about this file: https://meta.wikimedia.org/w/index.php?title=User:PiRSquared17/twinkle.js [16:29:30] oops, forgot. ok, thanks [16:33:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [16:34:53] (03PS3) 10Addshore: Make label and description placeholders language aware [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [16:36:09] damn... I had a comment for that one lying around, just didn't post it [16:36:23] so did adrian :P [16:36:23] (03CR) 10Hoo man: "Lydia wont like your idea and neither do I." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [16:36:30] i think he forgot to post it :> [16:38:46] (03CR) 10Lydia Pintscher: "Yes they need to show the language. There is a real issue of people entering labels and descriptions in the wrong language that is causing" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [16:40:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [16:42:07] Lydia_WMDE: I'm not really sure what's going on with the ULS stuff right now [16:42:24] legoktm: yeah - not cool though :/ [16:42:36] are you or someone else working on it? [16:42:43] and will it be enabled by default again? [16:42:55] I'm working on fixing the integration with the translate extension [16:43:04] (03PS3) 10Addshore: Remove whitespace around content in templates.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104727 (owner: 10Gerrit Patch Uploader) [16:43:05] I think we should just enable it by default for wikidatawiki [16:43:06] (03PS2) 10Addshore: Reduce badges to items listed in config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [16:43:08] (03PS2) 10Addshore: Use automatically generated classmap rather than a manual one for Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108638 (owner: 10Jeroen De Dauw) [16:43:24] (03PS3) 10Addshore: Slim down wbCurrentSite to only hold information we need [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 (owner: 10Hoo man) [16:43:26] legoktm: yes - and ideally very soon [16:43:33] lets see :> http://wikidata-jenkins.wmflabs.org/ci/ [16:43:51] Lydia_WMDE: Have we filed the ULS bugs, btw? [16:44:06] hoo: there is a bug for the current non-existance [16:44:28] legoktm: are you going to take care of that? or should i bug someone else? [16:44:40] submitting a patch [16:44:43] thanks! [16:44:54] I think ^d can deploy it [16:44:59] cool [16:46:58] Lydia_WMDE: can you talk to greg-g about it? I guess he's the one who has to sign off on it right now [16:47:13] legoktm: if you give me a link to a patch i am happy to [16:48:55] * greg-g will ignore the ping until after, please re-ping if needed [16:50:04] I'm a bit concerned that it'll cause people to hit bits again a lot [16:50:17] Lydia_WMDE: [08:50:02 AM] (PS1) Legoktm: Enable ULS by default on Wikidata [operations/mediawiki-config] - https://gerrit.wikimedia.org/r/108691 [16:50:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104727 (owner: 10Gerrit Patch Uploader) [16:50:34] legoktm: :* [16:51:16] heh https://bugzilla.wikimedia.org/show_bug.cgi?id=46306#c97 [16:51:17] greg-g: https://gerrit.wikimedia.org/r/#/c/108691/ would need a deploy - currently people can't switch language on wikidata because it is missing and that is a pretty vital part of wikidata [16:53:12] legoktm: answered -.- [16:53:41] :D [16:54:12] hah [16:54:31] I think no one noticed it being slow on Wikidata, because a ton of JS was already being loaded for page views [16:54:40] that was a weird comma [16:54:59] being slow? :P it just vanished didnt it... ? :P [16:55:05] Lydia_WMDE: adding relevant people [16:55:16] greg-g: :* [16:55:36] :D [16:55:45] 01[13Ask01] 15addshore pushed 1 new commit to 06master: 02http://git.io/rqMFLw [16:55:45] 13Ask/06master 146a438b0 15addshore: Merge pull request #2 from wmde/psr4... [16:55:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [16:58:34] (03PS4) 10Addshore: Slim down wbCurrentSite to only hold information we need [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 (owner: 10Hoo man) [16:59:11] (03PS15) 10Addshore: Allow specifying different license for "data" namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [17:00:14] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [17:00:57] (03PS2) 10Addshore: Set the right audience in ContentRetriever::getContentForRequest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108334 (owner: 10Hoo man) [17:01:21] (03PS5) 10Addshore: (bug 47070) No import of wikitext to entity NS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100565 (owner: 10Daniel Kinzler) [17:01:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108638 (owner: 10Jeroen De Dauw) [17:08:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 (owner: 10Hoo man) [17:12:12] (03PS4) 10Addshore: Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 [17:12:21] (03CR) 10jenkins-bot: [V: 04-1] Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [17:14:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 (owner: 10Hoo man) [17:17:58] (03PS5) 10Addshore: Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 [17:18:20] addshore: Rebasing all the changes? [17:18:29] some :P [17:19:03] (03PS3) 10Addshore: DNM Take SpecialSetSiteLink badges out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 [17:19:15] we have most of a jenkins back :D [17:20:18] addshore: :) Yay [17:20:19] got 3 more changes I would like in by tommorw, but need to wait for JeroenDeDauw :> [17:20:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [17:24:03] yay, jenkins approves :) [17:24:10] :D [17:24:15] it isnt setup as a client though! [17:24:22] so dont take its word for client stuff! [17:26:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108334 (owner: 10Hoo man) [17:31:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100565 (owner: 10Daniel Kinzler) [17:31:31] addshore: will have a look later [17:31:35] :) [17:31:48] well, its not a change to the patchset, just another comment :P [17:35:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [17:40:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [17:42:14] (03PS3) 10Bene: Reduce badges to items listed in config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 [17:43:05] addshore: does jenkins merge stuff? [17:43:51] our jenkins doesnt [17:43:56] the old jenkinns still will [17:45:18] after +2 verified? [17:45:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [17:45:33] well, the old jenkins will merge even without +2v [17:45:45] if it gets +2cr it will [17:45:57] oh, ok [17:46:14] seems good enough for now then [17:48:57] :) [17:49:20] I wonder when Daniel will go online, he's in SF already AFAIK [17:49:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [17:50:13] aude: Do you think broader consensus (or contact with others at all) is needed for putting sites stuff further into core? [17:50:45] i think more thought is needed how to do it [17:50:50] mh [17:51:07] related to legoktm's thing about site configuration perhaps [17:51:10] For now I mainly want to make global site id a core setting and move the maint. scripts [17:51:18] oh that's fine [17:51:39] aude, hoo: https://www.mediawiki.org/wiki/Requests_for_comment/Configuration_database_2#Wikisets [17:51:44] yeah [17:51:57] to replace the current interwiki system, the sites stuff needs improved caching [17:52:56] aude: Ok, for now I mostly care about the points above, as those are a real pain to us [17:53:21] * aude nods [17:53:23] If this doesn't need furter consensus, I can probably prepare a patch sometime soon [17:53:54] i don't think so. we have the rfc page [17:54:29] hi Legrelle... new nick? :P [17:55:41] hey hoo :) [17:55:43] not really new, I always use that on my mobile :p [17:55:54] [hoch_m@marius-notebook Wikibase]$ netbeans [17:55:54] Cannot find java. Please use the --jdkhome switch. [17:55:55] wtf [17:56:35] $ which java [17:56:35] /usr/bin/which: no java in ... [17:57:00] lulz [17:57:58] Jan 21 00:43:47 1:java-1.7.0-openjdk-1.7.0.60-2.4.4.0.fc20.x86_64: ts_done name in te is selinux-policy-targeted should be 1:java-1.7.0-openjdk-1.7.0.60-2.4.4.0.fc20.x86_64 [17:58:01] gotta love it... [18:01:42] aude: https://www.mediawiki.org/wiki/Wikidata_deployment Do we have that more up to date anywherE? [18:01:45] selinux \o/ [18:01:51] lots of fun! :p [18:02:21] lazowik_: Yep... got the main issue resolved though (with advice from RedHat, after filling a bug) [18:02:40] so this mainly was a yum reinstall java-1.7.0-openjdk-... [18:02:49] heh [18:02:56] aude: Ah, the google calender is more up to date [18:05:31] (03PS4) 10Hoo man: Make Wikibase Client tests pass if no ClientStore can be constructed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 [18:06:40] (03CR) 10Hoo man: "Tested and fixed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 (owner: 10Hoo man) [18:06:58] JeroenDeDauw: ^ Is that bearable? [18:07:06] addshore: wrap or other thing? [18:10:16] addshore: 11 EUR, when inc the stuff from yesterday [18:11:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 (owner: 10Hoo man) [18:11:36] hoo: why are you skipping the entire test case? Is that really needed? [18:12:19] JeroenDeDauw: I could factor that out in a function and only do it for the tests that need that [18:12:38] not in WikibaseClientTest though, almost all tests need it there, that would be over the top, I guess [18:13:10] 1) Wikibase\Test\SpecialMyLanguageFallbackChainTest::testExecute Failed asserting that false is true. [18:13:18] unrelated failures, yet again? :( [18:14:29] hoo: how is this related to testing lua code? [18:15:04] JeroenDeDauw: It's not, I just came over that while working on the Lua stuffs as these are essentially the same issues (took different approaches for the Lua things, though) [18:15:47] In the Lua tests I really ahve no option other than using Wikibase\Settings [18:16:04] did we even start killing that at all? [18:18:14] (03CR) 10Jeroen De Dauw: [C: 04-2] "This is a unit test, should always be able to run. Also note how the setting originally checked for via global state is injected via the c" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 (owner: 10Hoo man) [18:18:58] hoo: there is no need to use this unless in some cases where your code is in lib [18:19:06] Though that code will be fail in itself [18:19:11] (03Abandoned) 10Hoo man: Make Wikibase Client tests pass if no ClientStore can be constructed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 (owner: 10Hoo man) [18:19:17] New code should never use it, as there are alternatives [18:19:32] JeroenDeDauw: You don't want to look at my Lua integration tests, you don't... [18:23:23] hoo: non-subtle reverse psycho? :) [18:25:12] JeroenDeDauw: I'm not sure :P I did my best to hack around both Scribunto AND our global state, but I'm still not a fan of it... https://gerrit.wikimedia.org/r/#/c/108298/7 would be cool if you find a better way to do things... but we really need this, so we have to do it somehow *sigh* [18:27:48] This also removes the broken test mode handling from 9 [18:27:50] WikibaseClient as that made it impossible to properly 10 [18:27:52] inject a ClientStore mock. [18:27:54] ? [18:28:13] Why was this not possible because of this? [18:28:27] JeroenDeDauw: Yeah, that was rather funny... especially as that used two variable names within the class [18:28:52] cause WikibaseClient thought "I'm smart, this is a unit test, so just use a new mock repo for every call!111" [18:29:16] but that doesn't work for getStore (which should return a ClientStore) [18:29:43] It returned something that did not implement the correct interface?! [18:30:14] wtf [18:30:41] no, returned interface was correct [18:31:13] hoo: was the issue that some other test expected the real one to be returned? [18:31:17] JeroenDeDauw: No, it mocked some internal calls for a EntityLookup, but getStore always was and still is broken for many cases (thus the other patch) [18:32:05] JeroenDeDauw: Nope, but that code was pointless, no test was relying upon it ... and given how broken it was etc. I killed it [18:32:18] ok [18:32:20] on top of that it made it impossible for me to inject my own store [18:32:48] that part I don't get [18:33:47] JeroenDeDauw: For my integration tests, I need to make WikibaseClient use my own ClientStore for everything, but that doesn't work if some methods magically construct a new MockRepo instead of calling getStore() [18:33:58] because they are "smart" [18:38:47] hoo: you could mock the getEntityLookup method itself [18:39:12] It's odd though you have this method on both levels though - then again, you did not introduce that [18:39:38] Anyway, if it was broken and not used, than it is obviously good to kill it [18:43:49] (03CR) 10Jeroen De Dauw: [C: 04-1] Integration tests for Client's Scribunto integration (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man) [18:46:27] JeroenDeDauw: Fair points... "one ought to be able to prevent this class from being loaded in cases where it cannot be used anyway." how should I achieve that in this case (in some way the stuff has to derive from the Scribunto classes :/) [18:47:27] (03CR) 10Jeroen De Dauw: Integration tests for Client's Scribunto integration (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man) [18:55:59] hoo: ok, lets start at step one - why is this thing deriving from Scribunto_LuaEngineTestBase? [18:56:16] JeroenDeDauw: Because we need to run Lua test cases :/ [18:59:05] hoo: well, that is not really detailed enough of an answer obviously. Anyway, looking at this again, assuming there is good reason to derive from this thing, your hack is likely the most pragmatic thing to do for now [18:59:18] This code should simply not be put in lib [18:59:32] err client [19:00:58] rather ...? [19:12:40] (03PS4) 10Bene: Reduce badges to items listed in config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 [19:18:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [19:26:31] "(07:59:18 PM) JeroenDeDauw: This code should simply not be put in lib" Where do you want it? [19:27:14] hoo: an extension to client ofc [19:27:45] JeroenDeDauw: Like WikibaseLuaClient [19:27:50] name is silly, but you get the idea [19:31:20] hoo: yes, like that [19:31:34] Which would have a hard dependency on Scribunto [19:32:10] JeroenDeDauw: Mh, I can ask Daniel about that in SF, I should have enough working time left to get that done, also [20:01:10] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108803 (owner: 10L10n-bot) [20:02:27] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/eb232c7 : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17363465 [20:18:27] someone seems to be lying! [20:18:52] legoktm: huh? [20:19:10] WikidataJenkins said it was fine, but travis-ci said it broke [20:19:39] They run different tests ... eg. WikidataJenkins doesn't run client ones yet [20:19:49] oh [20:24:16] random [20:26:21] aude: Also saw unrelated failures earlier :S [20:26:29] :( [20:27:16] * aude struggles to be in mood to do coding [20:27:20] when it's a snow day! [20:27:29] aude: don't, then :) [20:27:33] ) [20:27:34] :) [20:27:43] even the US government is closed [20:30:02] aude: mh... in 28 hours or so I'll be in San Francisco... do you have news on your arrival? [20:30:24] tomorrow evening [20:31:11] :) Also staying at Club Quarters? [20:31:24] yep [20:32:44] suppose i'll find people in the pub [20:33:23] in the Hotel itself? [20:35:48] i think so [21:13:29] addshore: look what I found. a MW 1.7 o_O http://www.werelate.org/wiki/Special:Version [21:13:45] oh dear... ! [21:14:22] With edits very recently... Wow. [21:19:17] JohnLewis: it has no RecentChanges?! LD [21:20:02] Exploit ALL the security bugs? [21:37:59] 01[13WikibaseDataModelSerialization01] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/eKxFDw [21:38:00] 13WikibaseDataModelSerialization/06master 147eb88ba 15addshore: Add test for catching EntityIdParsingExceptions [21:38:00] 13WikibaseDataModelSerialization/06master 14b17c02d 15Jeroen De Dauw: Merge pull request #4 from wmde/snakDeserPropIdExceptionTest... [21:39:14] addshore: did you have some changes you wanted me to look at? [21:39:32] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/108519/ [21:41:47] (03CR) 10Jeroen De Dauw: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [21:48:03] (03CR) 10Jeroen De Dauw: [C: 04-2] "-2'ing as this really should not go in as is, and we still do not have a sticky -1." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [21:50:36] JeroenDeDauw: how would you achieve that? [21:50:52] totally open to ideas [21:52:02] or do you prefer we re-introduce the wikidata-specific code for copyright stuff? [21:52:07] e.g. revert [21:53:30] status quo is broken? [21:53:36] hoo|away: yes [21:53:43] doh [21:53:44] it says data is cc-by-sa 3.0 [21:53:48] aude: rhetorical question? [21:54:00] JeroenDeDauw: how would you fix the bug? [21:57:07] * aude can't make a deployment branch without fixing this somehow [21:58:02] aude: looks like showCopyrightMessage is only used in repo, so it can be removed from lib [21:58:11] Then you can just have the setting in repo [21:59:03] it's needed in SpecialWikibasePage (not sure why that's in lib, though) [21:59:20] aude: nope [21:59:21] but that function could be moved to repo [21:59:25] That is where the method is defined [21:59:26] aude: Client special pages use it or at least planned to use it... [21:59:28] it is not used there [21:59:36] hoo|away: hmmm ok [22:00:32] aude: hoo|away: adding settings to lib is almost automatically wrong - if you find yourself doing that, try finding a better approach or ask someone [22:00:53] in this case, putting it in repo should work [22:00:55] never done that :) At least I thing... [22:01:35] repo should be fine, we don't really need this in client [22:01:42] yep [22:02:25] We were pretty ambitious with client editing first, but the only thing that does taht is linkItem [22:02:59] someday. [22:03:33] Hopefully :) [22:07:52] (03PS2) 10Jeroen De Dauw: DNM - run composer update in test bootstrap to rebuild classmap [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 [22:13:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 (owner: 10Jeroen De Dauw) [22:15:26] (03PS3) 10Jeroen De Dauw: Run composer update in test bootstrap to rebuild classmap [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 [22:19:03] (03PS2) 10Jeroen De Dauw: Use automatically generated classmap rather than a manual one for Wikibase Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108644 [22:19:25] "Mail Error: Server smtp.pmtpa.wmnet rejected recipient WikidataJenkins : 550 Address wikidata-services@wikimedia.org does not exist" [22:19:27] lolwat? [22:19:32] I get that when clicking rebase [22:19:34] yus, i was getting that the other day [22:19:39] and then it doesnt rebase xD [22:19:52] oh, it did for me [22:19:54] :< [22:21:15] aude: you can use this lib to not bind new classes to whole Language objects and global wf functions: https://github.com/JeroenDeDauw/i18n/blob/master/src/i18n/MessageBuilder.php [22:21:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 (owner: 10Jeroen De Dauw) [22:23:24] addshore: look, it has a comment with verified though no vote https://gerrit.wikimedia.org/r/#/c/108642/ [22:23:41] fail :> [22:23:57] addshore: anyway, meeeeeeeeeeergeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee [22:23:58] ahh, it verified PS3, your looking at PS4 [22:24:46] (03PS5) 10Jeroen De Dauw: Run composer update in test bootstrap to rebuild classmap [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 [22:25:25] mhh [22:25:28] y jenkins no run on https://gerrit.wikimedia.org/r/#/c/108638/2 [22:27:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108644 (owner: 10Jeroen De Dauw) [22:27:39] (03CR) 10Addshore: [C: 032 V: 032] Use automatically generated classmap rather than a manual one for Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108638 (owner: 10Jeroen De Dauw) [22:28:05] (03CR) 10Addshore: [C: 032] Use automatically generated classmap rather than a manual one for Wikibase Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108644 (owner: 10Jeroen De Dauw) [22:30:58] addshore: but but but you did not merge https://gerrit.wikimedia.org/r/#/c/108642/ [22:31:08] waiting for jenkins :> [22:31:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 (owner: 10Jeroen De Dauw) [22:32:05] \o/ [22:32:43] you rebased too much [22:32:47] still 1 PS to go! [22:34:01] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2f03c4a : jeroendedauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17372107 [22:37:06] addshore: L( [22:37:16] its going as fast as it can :P [22:37:50] addshore: you sure it is running something now? [22:38:06] And seriously, that last rebase does not change a thing ;p [22:39:40] (03CR) 10Jeroen De Dauw: [C: 04-1] Reduce badges to items listed in config (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108337 (owner: 10Bene) [22:40:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9f7f2ac : jeroendedauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17372125 [22:41:26] (03PS1) 10Jeroen De Dauw: Add doc to Wikibase Lib to avoid common fallacy [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108844 [22:41:37] (03CR) 10Addshore: [C: 032 V: 032] Run composer update in test bootstrap to rebuild classmap [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 (owner: 10Jeroen De Dauw) [22:41:47] Hmmm [22:41:58] (03CR) 10Addshore: [C: 032 V: 032] Add doc to Wikibase Lib to avoid common fallacy [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108844 (owner: 10Jeroen De Dauw) [22:42:01] ANybody knows of the weird bug that prevents you from adding a second value to a property is being fixed? [22:42:14] whcih bug? :> [22:42:20] addshore: The ULS one [22:42:44] (03CR) 10Jeroen De Dauw: [C: 031] Set the right audience in ContentRetriever::getContentForRequest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108334 (owner: 10Hoo man) [22:42:45] probably index out of range [22:42:56] what's the status? [22:42:59] i have a queue of 3 patches i hope to ammend tommorw [22:43:01] someting like that $.uls.ime or so [22:43:11] if it the index out of bounds that is [22:43:12] aude: Lydia_WMDE wanted to open a bug I think... [22:43:13] yes [22:43:16] Index our of bounds [22:43:20] out* [22:43:22] that one [22:43:27] yup, hopfully we will merge it tommorw [22:43:27] I hate it >.< [22:43:31] and hi addshore :D [22:43:35] ltnt [22:43:37] i guess no branch today [22:43:40] hia Hahc21 ! [22:43:41] we'll make it tomorrow [22:43:49] aude: we dont branch until tommorw do we..? [22:43:57] was going to do today [22:44:02] :> [22:44:07] copyright thing and index out of bounds are blockers [22:44:16] unless you want yto ammend it ? ;p [22:44:28] nah, i'd like both in [22:44:54] i mean ammend my patch ;p [22:45:10] i don't know which patch [22:45:16] * aude somewhat confused [22:45:57] i might be able to rebase some in thr morning so they dont all depend on each other :P [22:46:20] (03CR) 10Jeroen De Dauw: [C: 031] "Looks good, though I'm not sure these removed array elements are not used anywhere" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106226 (owner: 10Hoo man) [22:46:52] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108844 (owner: 10Jeroen De Dauw) [22:46:54] weeeeeeeee [22:49:16] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/29c980d : jeroendedauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17373071 [22:49:30] (03PS1) 10Jeroen De Dauw: Wikibase is not currently using Coveralls, so rem from Travis config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108847 [22:50:00] (03CR) 10Addshore: [C: 032 V: 032] Wikibase is not currently using Coveralls, so rem from Travis config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108847 (owner: 10Jeroen De Dauw) [22:50:38] (03PS1) 10Jeroen De Dauw: Remove clutter from Lib entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108848 [22:51:17] addshore: I replied on https://gerrit.wikimedia.org/r/#/c/108519/ [22:51:32] i know :) will folow up in the morning :) [22:52:36] (03PS1) 10Jeroen De Dauw: Remove clutter from repo entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108850 [22:55:32] (03PS1) 10Jeroen De Dauw: Remove the last manually maintained classmap of doom [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108851 [22:56:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/440afec : Addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17373091 [22:56:31] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108847 (owner: 10Jeroen De Dauw) [22:59:33] addshore: easy review is easy https://github.com/wmde/AskSerialization/pull/5 [23:00:02] 01[13AskSerialization01] 15addshore 04deleted 06opdeps at 1432c00f1: 02http://git.io/BSsqdQ [23:00:25] (03CR) 10Addshore: [C: 032 V: 032] Remove clutter from repo entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108850 (owner: 10Jeroen De Dauw) [23:00:50] (03CR) 10Addshore: [C: 032 V: 032] Remove clutter from Lib entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108848 (owner: 10Jeroen De Dauw) [23:00:52] 01[13Ask01] 15JeroenDeDauw tagged 061.0.1 at 06master: 02http://git.io/9IBGQA [23:02:08] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108848 (owner: 10Jeroen De Dauw) [23:06:42] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108850 (owner: 10Jeroen De Dauw) [23:10:16] (03PS2) 10Jeroen De Dauw: Remove the last manually maintained classmap of doom [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108851 [23:10:26] addshore: ^^^^^^^^^^^^^^^^^^^^^^^^^ [23:11:01] (03CR) 10Addshore: [C: 032 V: 032] Remove the last manually maintained classmap of doom [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108851 (owner: 10Jeroen De Dauw) [23:11:47] :> [23:12:03] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108851 (owner: 10Jeroen De Dauw) [23:16:32] addshore: https://github.com/wmde/WikibaseQuery https://github.com/wmde/WikibaseQueryEngine [23:16:35] new projects [23:16:44] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108851 (owner: 10Jeroen De Dauw) [23:17:00] :D [23:17:09] i looked over the 3 serializer repos today [23:17:52] 3? [23:18:03] [travis-ci] wmde/WikibaseQuery#1 (master - 762aa04 : jeroendedauw): The build has errored. [23:18:03] [travis-ci] Change view : https://github.com/wmde/WikibaseQuery/compare/f0f16322f423...762aa0412fba [23:18:03] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQuery/builds/17374833 [23:18:05] There are only 2 for DM [23:18:36] ask? datavalue serializer? [23:18:41] * aude thinks there are 4+ [23:18:58] internal datamode and the interfaces [23:19:35] aude: Saw my /msg? [23:19:56] too many irc windows [23:20:10] xD [23:20:32] aude: 5, though 2 are just stubs at this point [23:20:52] * aude nods [23:22:33] im willing to work on them and get all the crap out of repo :> [23:23:00] :) [23:23:39] especially if they have well defined interfaces e.t.c :D [23:28:37] addshore: once we have this we can kick out a whole load in crap in DM, lib, repo and client [23:29:00] And it also is a blocker for starting work on query entities in Wikibase Query [23:29:11] Need this stuff or we need to add new bad code [23:30:04] which repo should I look at first? :P [23:45:06] [travis-ci] wmde/WikibaseQueryEngine#2 (master - c29219e : jeroendedauw): The build was fixed. [23:45:06] [travis-ci] Change view : https://github.com/wmde/WikibaseQueryEngine/compare/5a07c32cb236...c29219ead80c [23:45:07] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseQueryEngine/builds/17376166