[07:29:06] 01[13DataValuesJavascript01] 15snaterlicious created 06restructure (+1 new commit): 02http://git.io/AArrxA [07:29:06] 13DataValuesJavascript/06restructure 149c11161 15snaterlicious: Restructured files and directories [08:58:29] I just put a composer.json which required composer/installers and wikibase/wikibase in my MediaWiki root directory and then ran `composer install --prefer-source`; worked great (cc Tobi_WMDE) [09:04:47] (03PS47) 10Tobias Gritschacher: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [09:05:36] My daily update routine now became `git pull && php composer.phar update --prefer-source -vvv -o` (beware that this can purge your extension repos) [09:08:42] https://www.mediawiki.org/wiki/Wikibase#Installation [09:14:40] (03PS7) 10Daniel Kinzler: (bug 56711) use prefixed IDs in wb_terms table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 [09:22:39] (03CR) 10Adrian Lang: "I just talked with Henning and we actually think that EntityStore (think »the store«, not »to store«) is a fitting name for the overall th" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [09:42:24] anyone know stuff about the Translate extension? I can't figure out why [Wikidata:Bureaucrats' noticeboard/Username changes/Editintro/text/en] wasn't automatically created when I marked [Wikidata:Bureaucrats' noticeboard/Username changes/Editintro/text] for translation. [10:21:02] (03CR) 10Daniel Kinzler: [C: 032 V: 032] "A regression test would be good. Don't we have selenium tests for this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108336 (owner: 10Hoo man) [10:21:24] (03Merged) 10jenkins-bot: Fix SpecialSetSiteLink Fatal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108336 (owner: 10Hoo man) [10:23:03] (03CR) 10Daniel Kinzler: "@hoo: I guess we need to filter out some special cases when validating html :/" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [10:23:20] (03PS48) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [10:23:23] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/1/ (1/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:23:25] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/1/ (2/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:23:41] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/1/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:23:58] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:25:16] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/2/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:25:48] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/2/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:26:27] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/2/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:27:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:28:35] (03PS49) 10Tobias Gritschacher: (DNM) just testing stuffs [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [10:28:39] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/3/ (1/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:28:41] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/3/ (2/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:34:42] (03CR) 10WikidataJenkins: "Build Started http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/3/ (3/3)" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:36:56] (03PS5) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [10:37:25] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [10:45:52] 01[13DataValuesJavascript01] 15snaterlicious created 06basicparsers (+1 new commit): 02http://git.io/YOkH0g [10:45:52] 13DataValuesJavascript/06basicparsers 1402193fe 15snaterlicious: Re-implemented basic JavaScript value parsers [10:51:07] (03CR) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [11:00:51] (03PS6) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [11:01:19] (03CR) 10jenkins-bot: [V: 04-1] Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [11:02:48] legoktm: ping [11:04:59] (03PS7) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [11:05:47] DanielK_WMDE: An empty string *can* actually make a valid section in wikitext [11:05:50] I kid you not [11:05:56] == == [11:06:05] that will produce you an section with id="" [11:08:21] (03PS8) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [11:12:04] 01[13DataValuesJavascript01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/GYsQyA [11:12:05] 13DataValuesJavascript/06master 144a19860 15Tobi Gritschacher: Merge pull request #9 from wmde/inheritjquerydep... [11:12:19] 01[13DataValuesJavascript01] 15tobijat pushed 1 new commit to 06master: 02http://git.io/0VmiBw [11:12:19] 13DataValuesJavascript/06master 1430a0dad 15Tobi Gritschacher: Merge pull request #10 from wmde/inheritutil... [11:14:34] hoo: pong [11:14:44] hi :) [11:15:12] Ich bin soweit durch mit den Lua-Sachen, sind jetzt alle im gerrit [11:15:32] Inklusive integration tests \o/: https://gerrit.wikimedia.org/r/108298 [11:17:26] johl: Am besten wäre es wohl, wenn man die ganzen Änderungen reviewed und dann als ganzes (mit den Integrationtests) merged [11:18:15] hoo: will do. [11:18:23] hoo: also erstmal review [11:18:31] :) [11:19:02] The integration tests were evil... it took me literally ages to hack around Scribunto and global state... [11:24:30] (03PS15) 10Addshore: Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 [11:24:32] (03PS6) 10Addshore: Create ChangeOpReferenceRemove class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 [11:24:43] (03PS2) 10Addshore: Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 [11:24:45] (03PS2) 10Addshore: Create ChangeOpClaimRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 [11:24:47] (03PS5) 10Addshore: Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 [11:36:19] Lydia_WMDE: Make DanielK_WMDE look at my integration tests... need to go now... ;) [11:36:37] * hoo|away is going to get some us $ cash [11:36:48] some more, only have like 14$ left :P [11:39:59] (03PS3) 10Addshore: Inject Guid Validator and Parser in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 [11:40:01] (03PS3) 10Addshore: Create ChangeOpClaimRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 [11:40:08] (03PS6) 10Addshore: Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 [11:42:38] (03PS9) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [11:43:32] (03PS1) 10Addshore: Add further tests for ChangeOpClaimRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108494 [11:46:18] (03PS1) 10Addshore: Add further tests for ChangeOpReferenceRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108495 [11:46:46] (03PS1) 10Adrian Lang: Ignore selenium test vendor modules in jshint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108496 [11:48:43] (03PS1) 10Addshore: Add further tests for ChangeOpQualifierRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108497 [11:50:55] (03PS2) 10Addshore: Add further tests for ChangeOpQualifierRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108497 [11:50:57] (03PS7) 10Addshore: Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 [11:54:05] Hi [11:54:46] Yo Man [11:55:00] (03PS11) 10Addshore: Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 [12:10:48] (03CR) 10Daniel Kinzler: [V: 04-1] "Please test before submitting!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:12:06] (03CR) 10Addshore: "Im fairly sure I tested everything! But perhaps this one got missed through the rebase!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:18:52] (03CR) 10Daniel Kinzler: [C: 031 V: 032] "Seems pretty good, but tests could be improved (see comment). not opposed to merging it though." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [12:26:30] (03PS16) 10Addshore: Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 [12:26:55] (03CR) 10Addshore: Create ChangeOpReferenceRemove class. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [12:27:05] (03CR) 10Addshore: [V: 031] Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [12:35:44] is there a tool that merges the dumps with history and the incremental dumps? [13:02:49] (03PS10) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 [13:04:23] (03PS1) 10Addshore: Clean up error for claim index out of bounds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108503 [13:05:18] (03PS2) 10Addshore: Clean up error for claim index out of bounds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108503 [13:08:17] (03PS3) 10Addshore: Clean up error for claim index out of bounds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108503 [13:18:21] 01[13DataValuesJavascript01] 15snaterlicious created 06removeapiparsers (+1 new commit): 02http://git.io/zdiu_A [13:18:21] 13DataValuesJavascript/06removeapiparsers 1404ac7dc 15snaterlicious: Removed API based parsers [13:30:33] (03PS2) 10Addshore: Improve tests for ChangeOpReferenceRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108495 [13:31:12] (03CR) 10Addshore: [V: 031] Improve tests for ChangeOpReferenceRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108495 (owner: 10Addshore) [13:39:00] (03PS1) 10Adrian Lang: Cleanup global injections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108505 [13:42:29] (03PS1) 10Addshore: Remove use of deprecated datamodel classes in \api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108506 [13:44:36] andre__: hey :) going to be at fosedm? [13:44:40] *fosdem [13:44:52] (03PS1) 10Tobias Gritschacher: Updated .gitignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108507 [13:44:54] (03CR) 10Adrian Lang: "Code looks good, but I don't know enough about the actual issue. You might want to add tests, though, since breaking such things is easily" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [13:45:32] (03PS1) 10Addshore: Stop marking PermissionsTests as incomplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108508 [13:46:24] (03CR) 10Adrian Lang: [C: 031] "Might wanna add tests/browser/.bundle/, too." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108507 (owner: 10Tobias Gritschacher) [13:48:50] (03CR) 10Tobias Gritschacher: [C: 04-1] "needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101198 (owner: 10Henning Snater) [13:49:28] (03PS7) 10Tobias Gritschacher: Implemented "eachchange" event using the jQuery.event.special API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 (owner: 10Henning Snater) [13:49:37] (03CR) 10jenkins-bot: [V: 04-1] Implemented "eachchange" event using the jQuery.event.special API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 (owner: 10Henning Snater) [13:49:42] (03CR) 10Tobias Gritschacher: [C: 04-1] "needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 (owner: 10Henning Snater) [13:52:14] (03CR) 10Adrian Lang: "Just to be sure: The issue is the removeFocus() call which sets focus on something and thus scrolls? And we have to removeFocus because we" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108338 (owner: 10Hoo man) [13:52:29] (03Abandoned) 10Tobias Gritschacher: Rename add_aliases method to populate_aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102124 (owner: 10Aaron1011) [13:53:22] (03PS2) 10Tobias Gritschacher: Remove whitespace around content in templates.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104727 (owner: 10Gerrit Patch Uploader) [13:53:49] (03PS9) 10Tobias Gritschacher: Browsertests: generate testclaims using the api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100359 [13:54:29] (03CR) 10Tobias Gritschacher: [C: 04-1] "needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [13:55:52] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [13:56:13] (03Merged) 10jenkins-bot: Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [13:57:03] (03PS12) 10Tobias Gritschacher: Handle copyright message in new class, with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 (owner: 10Aude) [13:59:05] Lydia_WMDE, very likely, but not 102% sure yet ("it's complicated"). [14:00:48] andre__: hehe ok [14:02:33] (03CR) 10Adrian Lang: "Aside from the architectural questions, the naming and refactoring wikibase.snakview.variations.Value.prototype.draw, I consider this to b" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (owner: 10Adrian Lang) [14:07:29] (03PS9) 10Daniel Kinzler: (bug 40157) store entity status in page_props [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [14:42:31] urgh the passing around of options in these serializers is still nasty [14:43:37] DanielK_WMDE: got a moment? [14:43:43] addshor: Lost an "e"? [14:44:10] I was making lots of commits on another project over the weekend and got bored of being pinged ever 20 seconds :> [14:44:26] heh [14:45:16] ... and I'm away again, sorting more stuffs for San Francisco... [15:20:20] (03PS1) 10Addshore: Add hashes to qualifier serilization output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 [15:23:59] Lydia_WMDE: hey, did you already discuss the badges things in your team? [15:39:10] (03PS1) 10Addshore: Expand ResultBuilder testAddEntityRevision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108525 [15:50:43] (03PS1) 10Addshore: Implement hack to avoid UI throwing this error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 [15:54:30] benestar: nope - didn't have a chance yet - will look at it in a bit [15:54:41] ok, nice :) [16:33:57] (03PS13) 10Aude: Handle copyright message in new class, with tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 [16:34:08] (03PS14) 10Aude: Allow specifying different license for "data" namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/104946 [16:34:40] Lydia_WMDE: that needs a red dot ^ [16:35:00] aude: k - thanks [16:35:31] also, any luck with the index out of bounds bug? [16:35:41] aude, there are 2 patchs up for it :) [16:35:46] ill add you :) [16:35:59] awesome [16:36:08] done [16:36:10] it would be a shame to deploy (after more than month) and still not fix that [16:36:16] * aude would rage [16:40:16] i glanced at that patch a couple of times, and always meant to ask what that is actually about [16:40:19] i didn't wuite get the point [16:40:26] the patch itsefl looks trivial enough [16:40:56] DanielK_WMDE: right now, wikibase uses $wgRightsUrl and $wgRightsText [16:41:07] which = cc-by-sa 3.0 [16:43:15] oh duh - way to think about an email for an hour, and then sending it with the silliest of typos in the summary [16:43:26] * DanielK_WMDE cringes [16:44:16] * aude wonders if i'll be able to get to sf on wednesday :/ [16:45:00] aude: why not? [16:45:03] snow! [16:45:11] DanielK_WMDE: hi :) [16:45:15] hey benestar [16:45:27] DanielK_WMDE: did you already start something for the EntityRedirects? [16:45:30] aude: ugh... i plan to fly to nyc on saturday. [16:45:39] depends how much, when, (if too much, then if they clean our streets) [16:45:44] benestar: i started work on the entitystore, which blocks work on the redirects [16:45:47] or if my flight is cancelled, then get rebooked [16:45:57] DanielK_WMDE: great, is there a patch already? [16:46:01] i wasn't able to finish it, but i can add you as a reviewer for the drafts [16:46:10] soemtimes they exaggerate and we get hardly any snow :) [16:46:16] since i'm traveling, i will probably only finish it once i [16:46:21] nice, thank you :) [16:46:30] ...once i'm back, in ten days or so [16:47:42] benestar: there you go [16:47:53] thanks [16:48:08] if i do go to the airport on wednesday, it will be -16 C! [16:49:24] aude: well, canadians manage ;) [16:50:06] heh [16:57:22] [travis-ci] addshore/TravisRunTests#18 (master - ea1ff09 : addshore): The build passed. [16:57:22] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/d56a99e6dc6e...ea1ff09e4c85 [16:57:22] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17286790 [16:57:37] [travis-ci] addshore/TravisRunTests#19 (master - 4d93c32 : addshore): The build passed. [16:57:37] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/ea1ff09e4c85...4d93c32a6278 [16:57:37] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17286808 [16:57:38] DanielK_WMDE: Leaving tomorrow? [16:57:52] heh, was meant to change that channel to something else :P [16:58:01] apparently I forgot :> [16:58:17] what no bots here? [16:58:37] O_o ? [16:58:45] oh grrrt? [16:59:02] addshore: or just for your stuff? [16:59:15] yus, just my stuff :P [16:59:21] oh, ok :) [16:59:32] [travis-ci] addshore/TravisRunTests#21 (master - 38f947b : addshore): The build passed. [16:59:32] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/3a03d05641bf...38f947b5023a [16:59:32] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17286903 [16:59:37] but actually gerrt bot didnt say anything about my last patch [16:59:57] hmmm [17:00:21] DanielK_WMDE: did you already sit together with JeroenDeDauw ? [17:01:32] [travis-ci] addshore/TravisRunTests#20 (master - 3a03d05 : addshore): The build passed. [17:01:32] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/4d93c32a6278...3a03d05641bf [17:01:32] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17286880 [17:01:49] just a few more, ignore travis, I fixed the cfg now :D [17:01:53] [travis-ci] addshore/TravisRunTests#22 (master - 816d364 : addshore): The build passed. [17:01:53] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/38f947b5023a...816d3649705c [17:01:53] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17286948 [17:03:06] [travis-ci] addshore/TravisRunTests#23 (master - 3338acc : addshore): The build passed. [17:03:06] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/816d3649705c...3338acc87c8d [17:03:06] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17286985 [17:03:27] [travis-ci] addshore/TravisRunTests#24 (master - a0b21f4 : addshore): The build passed. [17:03:27] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/3338acc87c8d...a0b21f47dfff [17:03:27] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17287061 [17:04:44] [travis-ci] addshore/TravisRunTests#25 (master - 1e1ff0b : addshore): The build passed. [17:04:44] [travis-ci] Change view : https://github.com/addshore/TravisRunTests/compare/a0b21f47dfff...1e1ff0bb4126 [17:04:44] [travis-ci] Build details : http://travis-ci.org/addshore/TravisRunTests/builds/17287080 [17:05:47] Lydia_WMDE: Bought a socket adapter today at a large electronic store which claims to not be for silly people :P [17:06:08] It was rather expensive, but I guess it's even more expensive at the airport [17:06:14] hoo: :P [17:06:16] probably [17:06:49] benestar: ? [17:07:40] JeroenDeDauw: "Well, this has several issues, both in the design and the implementation. How about we sit together and figure out how to do this afresh?" [17:07:51] @ https://gerrit.wikimedia.org/r/#/c/102496/ [17:08:12] benestar: yeah we did [17:08:28] and what was the outcome? [17:11:10] addshore: wot, they are closed?! [17:11:25] O_o [17:13:24] * hoo has to much emails [17:13:34] can't find stuff -.- [17:14:11] DELETE them :> [17:14:24] Abraham_WMDE: you want a food? [17:14:34] addshore: http://www.lieferando.de/lieferservice-pizza-jack-berlin-boelckestr-#!cart [17:15:29] Country Potatoes with Sour Cream please JeroenDeDauw :> [17:16:16] heh, great, another round of notifications soon! :d [17:16:45] [travis-ci] addshore/mediawiki-extensions-Wikibase#1 (mergerefs - 5dd92a1 : addshore): The build failed. [17:16:45] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/commit/5dd92a1566b3 [17:16:46] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287782 [17:17:54] Lydia_WMDE: Did you have your exact hotel address in your ESTA? That's not needed, is it? [17:18:15] hoo: not in esta but at the airport at checking [17:18:18] *check-in [17:18:30] ok [17:18:34] Thanks :) [17:18:39] np [17:21:26] la la la [17:23:16] [travis-ci] addshore/mediawiki-extensions-Wikibase#2 (co-qualifierremove - 5c7ae10 : addshore): The build failed. [17:23:16] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/compare/607f7b3f321b^...5c7ae1027a63 [17:23:16] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287801 [17:23:39] (03PS2) 10Addshore: Updated .gitignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108507 (owner: 10Tobias Gritschacher) [17:24:13] (03CR) 10Addshore: "Added per suggestion" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108507 (owner: 10Tobias Gritschacher) [17:25:33] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287801" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108497 (owner: 10Addshore) [17:25:34] * aude wants pizza! :) [17:25:51] aude: :D Already in SF? [17:25:55] nope [17:26:04] (03CR) 10Addshore: [V: 031] "the change above this has +2v from travis" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [17:26:18] (03CR) 10Addshore: [V: 031] "the change above this has +2v from travis" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [17:26:18] all depends on digging out of the snow tomorrow... [17:26:28] hehe [17:31:06] [travis-ci] addshore/mediawiki-extensions-Wikibase#3 (co-claimremove - 1ee922a : addshore): The build passed. [17:31:06] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/compare/08cf164a74b7^...1ee922a1488e [17:31:06] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287816 [17:32:50] (03PS1) 10Addshore: Change travis IRC template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108532 [17:33:41] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Change travis IRC template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108532 (owner: 10Addshore) [17:33:54] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287816" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108494 (owner: 10Addshore) [17:34:10] (03CR) 10Addshore: [V: 032] "the change above this has +2 from travis" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 (owner: 10Addshore) [17:34:18] [travis-ci] addshore/mediawiki-extensions-Wikibase#1 (mergerefs - 5dd92a1 : addshore): The build failed. [17:34:19] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/commit/5dd92a1566b3 [17:34:19] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287782 [17:36:21] (03CR) 10Addshore: [V: 04-1] "1) Wikibase\Test\Api\EditEntityTest::testEditEntity with data set "clear and add complex claim with qualifiers and references" (array('', " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [17:39:58] [travis-ci] addshore/mediawiki-extensions-Wikibase#4 (co-referenceremove - d357624 : addshore): The build passed. [17:39:58] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/compare/2bf867608bee...d357624ea0b9 [17:39:58] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287873 [17:40:24] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b45de6b : addshore The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17289388 [17:43:10] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287873" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108495 (owner: 10Addshore) [17:43:56] [travis-ci] addshore/mediawiki-extensions-Wikibase#6 (claimindex - c619ab1 : addshore): The build passed. [17:43:56] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/compare/d9f4a5c2663b...c619ab156d48 [17:43:56] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287907 [17:44:38] (03CR) 10Addshore: [V: 032] "change above this has +2v from travis" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108503 (owner: 10Addshore) [17:47:43] aude: Oh... snow problems as you predicted :/ [17:48:25] (03PS17) 10Addshore: Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 [17:48:27] [travis-ci] addshore/mediawiki-extensions-Wikibase#7 (resultbuildertest - 19a165c : addshore): The build failed. [17:48:27] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/compare/a513c1faed63...19a165c8e902 [17:48:27] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17287965 [17:52:54] (03CR) 10Addshore: [V: 04-1] Add hashes to qualifier serilization output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [17:54:20] * hoo loves the Deutsche Bahn ... their website gives me only insane routes towards the airport, unless I manually add immediate stops -.- [17:54:29] :> [17:54:42] i'll probably be out at 3am cleaning snow [17:55:11] [travis-ci] addshore/mediawiki-extensions-Wikibase#8 (mergerefs - 09d1872 : addshore): The build was fixed. [17:55:11] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/compare/5dd92a1566b3...09d18729e402 [17:55:11] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17290079 [17:55:41] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17290079" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [18:44:03] Lydia_WMDE: already discussed in the team? [18:52:33] (03PS2) 10Addshore: Expand ResultBuilder testAddEntityRevision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108525 [18:52:35] (03PS2) 10Addshore: Include dataType id in API output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108530 [18:52:37] (03PS2) 10Addshore: Add hashes to qualifier serilization output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 [18:53:34] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293272" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108530 (owner: 10Addshore) [18:53:41] [travis-ci] addshore/mediawiki-extensions-Wikibase#9 (resultbuildertest - a0c1f1c : addshore): The build was fixed. [18:53:41] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/compare/19a165c8e902...a0c1f1c2bc1a [18:53:41] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293272 [18:53:48] (03CR) 10Addshore: [V: 032] "commit above this has +2v from travis" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108525 (owner: 10Addshore) [18:53:56] (03CR) 10Addshore: [V: 032] "commit above this has +2v from travis" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [18:54:59] mh... I wonder how long it will take until Wikidata Jenkins does its job [18:56:38] * addshore pokes aude ^^ [18:56:39] :P [18:56:58] at this stage im sure it woud just be easier to move our remaing repos to github :O [18:58:35] basically all I am doing now is maintaining my own fork on github for developing and testing before pushing to gerrit for review xD [18:58:55] addshore: :P I got a nicer solution... [18:59:11] If I did that for my Lua integration tests I would have pushed like a bazillion things to github [18:59:49] hah! [18:59:56] whats your nicer solution? :> [19:00:24] * aude got kicked off labs on friday! [19:00:29] :O [19:00:30] addshore: A VirtualBox VM with Fedora in it... my Wikibase repo is accessible to it as a shared folder [19:00:47] than I use a customized version of the Travis script to set it up etc. [19:00:50] forget where i was with jenkins, but think trying to get zuul to work [19:00:50] * then [19:01:13] aude wouldnt it make more sense to ignore jenkins and move the repos? :P [19:01:19] sounds nice hoo :P [19:01:25] no [19:01:26] [travis-ci] addshore/mediawiki-extensions-Wikibase#10 (api-permissions - ab8ea39 : addshore): The build passed. [19:01:26] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/commit/ab8ea397977a [19:01:26] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293743 [19:01:32] I copy stuff onto a RAM disk in there so that I can keep changing stuff on my bare metal without having to worry about the tests going crazy about it [19:01:44] Don't move the repos [19:01:50] Github s... [19:01:52] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293743" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108508 (owner: 10Addshore) [19:02:42] i'd like to change https://www.wikidata.org/wiki/Template:Bot to accommodate multiple operators, like https://en.wikipedia.org/wiki/Template:Bot (e.g. https://en.wikipedia.org/wiki/User:ProteinBoxBot) [19:02:48] anyone here object to that? [19:03:20] Emw: As long as you don't break b/c that's probably fine [19:03:22] Emw: I would just got for it :) [19:03:29] b/c = backwards compatiblity [19:03:39] * compatibility [19:03:52] ok [19:07:07] [travis-ci] addshore/mediawiki-extensions-Wikibase#11 (api-datamodel - eb5d4e9 : addshore): The build passed. [19:07:07] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/commit/eb5d4e949586 [19:07:07] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293771 [19:07:16] addshore: I don't know why you people prefer github, the only real advance I see is that contributing for new developers might be easier (just open a pull request) [19:08:16] i think zuul works with a local git copy and i was making it work with that [19:08:24] i dont really have a preference :P [19:08:40] I have :P Gerrit <3 [19:08:41] :P [19:08:41] but right now it would be easier if it was in one place or the other, rather than half and half [19:08:51] if it were in either one place, we would have tests running .. [19:09:04] once we understand how to use zuul + jenkins, then we can have it do exactly waht we want [19:09:10] :P [19:09:16] and it can do gate + submit etc [19:09:28] gate and submit would be awesome [19:10:18] well, it's a holiday... i'm not supposed to work today :) [19:10:29] I guess I should enable my clean up bot for the wikisources some time soon :) [19:10:56] * aude should go outside and enjoy last day of spring :p [19:11:06] aude: Is stuff on labs? Or on cloudbees? [19:11:10] Rather supposed to be :P [19:11:18] hoo: labs [19:11:29] wikidata-jenkins.wmflabs.org/ci [19:11:53] it can do everything except checkout the patch... e.g. run tests on master [19:12:08] last piece to get working [19:12:40] check out the patch? [19:12:48] ah wikidata-jenkins, it is [19:13:43] [travis-ci] addshore/mediawiki-extensions-Wikibase#12 (co-claim - f792d5b : addshore): The build failed. [19:13:43] [travis-ci] Change view : https://github.com/addshore/mediawiki-extensions-Wikibase/commit/f792d5b74820 [19:13:43] [travis-ci] Build details : http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293810 [19:14:01] addshore: yes [19:14:13] i dont understand what you mean! :P [19:14:24] * hoo can't ssh into it :P [19:14:30] i thought I saw it checking out the patch :P [19:14:33] addshore: like git review -d [19:14:41] i dont use git review ;p [19:14:44] zuul doesnt' know the gerrit ref to get [19:14:55] ahh [19:15:01] it knows the "zuul" (local git copy) ref which i think we need ot use [19:15:16] that's what i was doing when labs / tampa data center got cut off [19:16:29] ahh :P [19:19:54] [travis-ci] addshore/mediawiki-extensions-Wikibase/master/b45de6b : addshore The build passed. http://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293898 [19:20:30] aude: Now go enjoy the weather ;) [19:25:47] later! [20:33:00] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#100 (master - f0f1632 : Translation updater bot): The build has errored. [20:33:00] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/fa7107f0e902...f0f16322f423 [20:33:00] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/17298461 [21:06:03] (03CR) 10Jeroen De Dauw: [C: 031] Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [21:30:38] addshore: did you modify this file in other commits as well? [21:30:40] https://gerrit.wikimedia.org/r/#/c/107577/6/repo/Wikibase.classes.php [21:31:11] a few but none conflict, i think they might even be stacked on top of each other [21:32:10] addshore: ok, lets get those merged then and kill the file [21:32:23] yay [21:35:12] addshore: please try to stick to Arrange, Act, Assert [21:35:39] (03CR) 10Jeroen De Dauw: [C: 032] Create ChangeOpReferenceRemove class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107577 (owner: 10Addshore) [21:35:53] which didnt I in? if it is one of the Remove tests then thats copied and pasted from the pervious test class [21:36:23] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293771" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108506 (owner: 10Addshore) [21:36:45] (03CR) 10Addshore: [V: 032] "https://travis-ci.org/addshore/mediawiki-extensions-Wikibase/builds/17293810" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [21:42:30] (03CR) 10Jeroen De Dauw: Merge References for Statements in wbmergeitems (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [21:42:37] 01[13DataValuesJavascript01] 15addshore 04deleted 06inheritjquerydep at 14c057527: 02http://git.io/8bh0kw [21:42:38] (03CR) 10Jeroen De Dauw: [C: 032] Merge References for Statements in wbmergeitems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106897 (owner: 10Addshore) [21:42:48] 01[13DataValuesJavascript01] 15addshore 04deleted 06inheritutil at 14c2652cc: 02http://git.io/JkoZVA [21:43:21] I continue finding this whole ChangeOp thing weird [21:43:25] haha ! [21:43:50] I deeply suspect that there is a much better way to model this [21:44:07] (03CR) 10Addshore: [C: 032 V: 032] Updated .gitignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108507 (owner: 10Tobias Gritschacher) [21:44:12] if there is I am all ears :) [21:46:12] (03CR) 10Jeroen De Dauw: Create ChangeOpQualifierRemove class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [21:46:17] addshore: https://gerrit.wikimedia.org/r/#/c/107836/ [21:46:58] addshore: well, that requires some thought and changeops don't seem like the most critical or strategical item to tackle at this point [21:47:27] indeed, I will make a followup for that comment you just left [21:47:40] addshore: https://gerrit.wikimedia.org/r/#/c/108495/2/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php [21:48:40] addshore: which columns on wb_items_per_site are indexed? [21:50:00] or JeroenDeDauw maybe you know [21:51:15] or hoo maybe you know :P [21:51:19] benestar: I geuss I created the table, though that is looooong ago ;p [21:51:53] CREATE UNIQUE INDEX /*i*/wb_ips_item_site_page ON /*_*/wb_items_per_site (ips_site_id, ips_site_page); [21:51:55] CREATE INDEX /*i*/wb_ips_site_page ON /*_*/wb_items_per_site (ips_site_page); [21:51:57] CREATE INDEX /*i*/wb_ips_item_id ON /*_*/wb_items_per_site (ips_item_id); [21:52:24] (03CR) 10Jeroen De Dauw: [C: 032] Improve tests for ChangeOpReferenceRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108495 (owner: 10Addshore) [21:53:07] (03CR) 10Jeroen De Dauw: [C: 032] Add further tests for ChangeOpQualifierRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108497 (owner: 10Addshore) [21:54:01] JeroenDeDauw: no index for site_id ? [21:54:03] :( [21:54:33] (03CR) 10Jeroen De Dauw: [C: 032] Clean up error for claim index out of bounds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108503 (owner: 10Addshore) [21:54:46] not sure if this is the reason but I want to know why http://tools.wmflabs.org/bene/lonelyitems is so slow for large wikis [21:55:30] JeroenDeDauw: --^ [21:55:31] (03CR) 10Jeroen De Dauw: [C: 04-1] Implement hack to avoid UI throwing this error (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 (owner: 10Addshore) [21:56:28] benestar: idk, I'm a bit out of touch with this code [21:57:06] (03CR) 10Jeroen De Dauw: "Rebase conflict" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 (owner: 10Addshore) [21:57:20] (03PS3) 10Jeroen De Dauw: Add hashes to qualifier serilization output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [21:57:25] (03PS3) 10Jeroen De Dauw: Expand ResultBuilder testAddEntityRevision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108525 (owner: 10Addshore) [21:57:30] (03PS3) 10Jeroen De Dauw: Include dataType id in API output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108530 (owner: 10Addshore) [21:58:33] (03PS4) 10Addshore: Create ChangeOpClaimRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 [21:58:45] JeroenDeDauw: rebased ^^ local git resolved them all [22:02:30] (03PS2) 10Addshore: Implement hack to avoid UI throwing this error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 [22:02:37] JeroenDeDauw: ^^ factored it out into its own method [22:03:41] (03CR) 10Jeroen De Dauw: [C: 04-1] Add hashes to qualifier serilization output (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [22:04:13] (03CR) 10Jeroen De Dauw: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [22:06:02] (03CR) 10Addshore: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [22:09:12] (03CR) 10Jeroen De Dauw: [C: 04-1] Implement hack to avoid UI throwing this error (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 (owner: 10Addshore) [22:09:30] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/99aa7f7 : Jeroen De Dauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17303546 [22:10:11] (03PS4) 10Addshore: Add hashes to qualifier serilization output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 [22:11:03] (03CR) 10Jeroen De Dauw: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [22:13:26] addshore: if you fix the tags here, I'll merge https://gerrit.wikimedia.org/r/#/c/107836/7 [22:15:00] (03PS3) 10Addshore: Implement hack to avoid UI throwing this error [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 [22:15:41] (03PS8) 10Addshore: Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 [22:15:42] JeroenDeDauw: done [22:15:52] (03CR) 10Jeroen De Dauw: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [22:16:01] (03CR) 10Jeroen De Dauw: [C: 04-1] "See comment on PS3" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [22:16:29] addshore: dude, you missed the other one! ;p [22:16:37] (03CR) 10Addshore: Implement hack to avoid UI throwing this error (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 (owner: 10Addshore) [22:16:55] (03CR) 10Jeroen De Dauw: Create ChangeOpQualifierRemove class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [22:18:29] (03CR) 10Addshore: Create ChangeOpQualifierRemove class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [22:18:52] (03PS9) 10Addshore: Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 [22:20:43] (03PS1) 10Jeroen De Dauw: Use automatically generated classmap rather than a manual one for Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108638 [22:21:11] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Create ChangeOpQualifierRemove class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107836 (owner: 10Addshore) [22:21:20] (03PS3) 10Jeroen De Dauw: Add further tests for ChangeOpQualifierRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108497 (owner: 10Addshore) [22:21:24] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Add further tests for ChangeOpQualifierRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108497 (owner: 10Addshore) [22:21:44] addshore: https://gerrit.wikimedia.org/r/108638 [22:22:28] (03CR) 10Jeroen De Dauw: [V: 032] Use automatically generated classmap rather than a manual one for Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108638 (owner: 10Jeroen De Dauw) [22:23:10] (03CR) 10Addshore: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [22:23:14] JeroenDeDauw: ^^ [22:23:22] (03CR) 10Jeroen De Dauw: [C: 032] Stop marking PermissionsTests as incomplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108508 (owner: 10Addshore) [22:23:27] (03PS2) 10Jeroen De Dauw: Add further tests for ChangeOpClaimRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108494 (owner: 10Addshore) [22:24:00] (03CR) 10Jeroen De Dauw: [C: 032] Add further tests for ChangeOpClaimRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108494 (owner: 10Addshore) [22:24:10] (03CR) 10Jeroen De Dauw: [V: 032] Add further tests for ChangeOpClaimRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108494 (owner: 10Addshore) [22:27:56] (03CR) 10Addshore: [V: 04-1] "Fatal error: Class 'Wikibase\Client\WikibaseClient' not found in C:\Users\adam\Documents\git\mediawiki\extensions\Wikibase\client\tests\ph" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108638 (owner: 10Jeroen De Dauw) [22:28:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/90408a2 : addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17304876 [22:28:07] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] "Some follow up suggestions" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108035 (owner: 10Addshore) [22:28:13] addshore: run composer update ;p [22:28:18] oh .... [22:28:38] addshore: in most of our components the test bootstrao does this automatically [22:28:48] (03Merged) 10jenkins-bot: Add further tests for ChangeOpClaimRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108494 (owner: 10Addshore) [22:29:12] i think im still using the mediawiki boostrap currently [22:29:39] (03CR) 10Addshore: [C: 031] "composer update.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108638 (owner: 10Jeroen De Dauw) [22:30:07] We apparently only have a bootstrap in repo [22:30:17] Wonder if it still works [22:30:50] how long are you staying? [22:31:04] at least one more hour [22:31:14] addshore: I haz client installed, so I can merge? :D [22:31:20] HAHA [22:31:39] maybe :P I wonder if I go downstairs will someone be there to let me out ... [22:31:55] (03CR) 10Jeroen De Dauw: "Needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [22:34:29] (03CR) 10Jeroen De Dauw: [C: 04-1] Inject Guid Validator and Parser in ChangeOpClaim (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108038 (owner: 10Addshore) [22:34:44] addshore: probably [22:34:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c745327 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17304981 [22:39:38] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b1c8f3f : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17305194 [22:40:02] (03CR) 10Jeroen De Dauw: Implement hack to avoid UI throwing this error (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108527 (owner: 10Addshore) [22:40:18] (03PS4) 10Jeroen De Dauw: Expand ResultBuilder testAddEntityRevision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108525 (owner: 10Addshore) [22:44:10] (03PS1) 10Jeroen De Dauw: DNM - run composer update in test bootstrap to rebuild classmap [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108642 [22:45:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a5acc60 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17305219 [22:48:10] (03CR) 10Jeroen De Dauw: [C: 032] Expand ResultBuilder testAddEntityRevision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108525 (owner: 10Addshore) [22:51:54] (03PS1) 10Jeroen De Dauw: Use automatically generated classmap rather than a manual one for Wikibase Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108644 [23:04:46] 01[13AskSerialization01] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/cq2oAA [23:04:46] 13AskSerialization/06master 14de5b71a 15Jeroen De Dauw: Update bootstrap.php [23:21:45] (03PS2) 10Hoo man: Make label and description placeholders language aware [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 [23:22:05] (03CR) 10Hoo man: "Added Qunit tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108471 (owner: 10Hoo man) [23:22:06] 01[13AskSerialization01] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ZvzRPw [23:22:06] 13AskSerialization/06master 1443560c1 15Jeroen De Dauw: Update .travis.yml [23:27:38] (03CR) 10Hoo man: "Well... the problem is that the triggered click sets a focus, which we then immediately remove again (sounds sane :P)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108338 (owner: 10Hoo man) [23:29:58] 01[13Ask01] 15JeroenDeDauw created 06psr4 (+1 new commit): 02http://git.io/8OjjAA [23:29:58] 13Ask/06psr4 14a3ad21b 15jeroendedauw: Use PSR-4 based class loading [23:30:39] [13Ask] 15JeroenDeDauw opened pull request #2: Use PSR-4 based class loading (06master...06psr4) 02http://git.io/G1OJVA [23:32:40] [travis-ci] wmde/Ask#17 (psr4 - a3ad21b : jeroendedauw): The build failed. [23:32:40] [travis-ci] Change view : https://github.com/wmde/Ask/commit/a3ad21ba2038 [23:32:40] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/17308287 [23:34:07] 01[13Ask01] 15JeroenDeDauw 04force-pushed 06psr4 from 14a3ad21b to 142486ed9: 02http://git.io/AdHhaw [23:34:08] 13Ask/06psr4 142486ed9 15jeroendedauw: Use PSR-4 based class loading [23:35:47] (03CR) 10Jeroen De Dauw: [C: 032] Cleanup global injections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108505 (owner: 10Adrian Lang) [23:36:06] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Ignore selenium test vendor modules in jshint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108496 (owner: 10Adrian Lang) [23:36:13] (03Merged) 10jenkins-bot: Cleanup global injections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108505 (owner: 10Adrian Lang) [23:36:57] (03CR) 10Jeroen De Dauw: [C: 032] "Awesome!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108506 (owner: 10Addshore) [23:37:03] (03CR) 10jenkins-bot: [V: 04-1] Remove use of deprecated datamodel classes in \api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108506 (owner: 10Addshore) [23:37:31] (03CR) 10Jeroen De Dauw: Add hashes to qualifier serilization output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108519 (owner: 10Addshore) [23:39:32] (03PS2) 10Jeroen De Dauw: Remove use of deprecated datamodel classes in \api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108506 (owner: 10Addshore) [23:41:08] 01[13Ask01] 15JeroenDeDauw 04force-pushed 06psr4 from 142486ed9 to 14513b3e6: 02http://git.io/AdHhaw [23:41:08] 13Ask/06psr4 14513b3e6 15jeroendedauw: Use PSR-4 based class loading [23:42:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/26a487d : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17308549 [23:43:53] [travis-ci] wmde/Ask#21 (psr4 - 513b3e6 : jeroendedauw): The build passed. [23:43:53] [travis-ci] Change view : https://github.com/wmde/Ask/compare/2486ed95cdc2...513b3e6f4d2f [23:43:53] [travis-ci] Build details : http://travis-ci.org/wmde/Ask/builds/17308762 [23:44:00] (03CR) 10Jeroen De Dauw: [C: 04-1] Make Wikibase Client tests pass if no ClientStore can be constructed (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 (owner: 10Hoo man) [23:44:19] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Remove use of deprecated datamodel classes in \api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108506 (owner: 10Addshore) [23:44:44] JeroenDeDauw: so? [23:45:16] I don't care enough about that change to actually do something fancy, but we have that problem in general [23:45:29] like in a few unit tests :/ [23:48:46] hoo: using highly deprecated global state in the tests is not a good solution in any case :) [23:49:10] JeroenDeDauw: Well, tell me how to integration test our Lua stuffs then [23:49:23] and no, do that in a few months is not an option :/ [23:51:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/7f29721 : addshore The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/17308883 [23:54:08] (03CR) 10Hoo man: "So... abandon this? (I'm not going to invest much time into this to find a fancy solution)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 (owner: 10Hoo man)