[00:00:34] he was an apple [00:14:44] Hey ajr [00:14:50] Hi [00:14:54] I got the email [00:15:05] ajr, could you check the oversight queue [01:21:46] (03CR) 10Hoo man: Introduce mw.wikibase.entity Lua library (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man) [02:45:47] Change on 12meta_wikimedia a page Wikidata was modified, changed by 74.105.121.132 link https://meta.wikimedia.org/w/index.php?diff=7139276 edit summary: [+212] [02:46:11] Change on 12meta_wikimedia a page Wikidata was modified, changed by Ajraddatz link https://meta.wikimedia.org/w/index.php?diff=7139277 edit summary: [-212] Reverted changes by [[Special:Contributions/74.105.121.132|74.105.121.132]] ([[User talk:74.105.121.132|talk]]) to last version by FDMS4 [03:08:36] Any ops around? [03:10:04] (03CR) 10Hoo man: Introduce mw.wikibase.entity Lua library (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man) [03:10:20] Hazard-SJ: mh? [03:10:33] you mean over here? [03:10:55] hoo: Yeah, the last part of the topic is outdated [03:11:24] mh... apparently I'm not an op over here either [03:11:34] OK [03:12:13] rschen7754: If you're around, could you fix that please? [03:32:40] (03PS1) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 [03:37:28] (03PS2) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 [03:45:28] (03PS12) 10Hoo man: Introduce mw.wikibase.entity Lua library [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 [03:45:42] (03CR) 10Hoo man: Introduce mw.wikibase.entity Lua library (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man) [03:46:23] (03CR) 10Hoo man: "Minor style / tag changes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man) [03:46:54] (03PS13) 10Hoo man: Implement mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 [03:48:46] (03PS14) 10Hoo man: Implement mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 [03:49:11] (03CR) 10Hoo man: "Style-only changes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 (owner: 10Hoo man) [03:49:19] (03PS3) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 [04:02:23] (03PS13) 10Hoo man: Introduce mw.wikibase.entity Lua library [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 [04:02:42] (03CR) 10Hoo man: "Fixed @covers" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107206 (owner: 10Hoo man) [04:02:58] (03PS15) 10Hoo man: Implement mw.wikibase.entity.formatPropertyValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107395 [04:03:06] (03PS4) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 [04:35:28] (03CR) 10Hoo man: [C: 04-1] Integration tests for Client's Scribunto integration (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man) [04:51:14] (03CR) 10Hoo man: Integration tests for Client's Scribunto integration (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man) [06:21:10] hoo left? :( [06:21:11] https://en.wikipedia.org/wiki/Wikipedia_talk:Lua#.22Hacking.22_into_Wikidata_to_get_properties_of_miscellaneous_articles [06:21:30] that's scary [07:15:56] good morning [07:18:14] good afternoon [11:07:13] dennyvrandecic: I think the bot finished. One error was reported, see https://www.wikidata.org/w/index.php?title=Q161279&action=history [11:46:09] Lydia_WMDE: hey :) [11:46:21] is there already somebody working on the badges api? [11:46:42] benestar: hey :) [11:47:00] benestar: hmmmm wasn't there some patchset up already? [11:47:06] i might be misremembering things though [11:47:08] sorry, * ui [11:47:15] ;) [11:47:56] benestar: not yet [11:48:21] heening did some designs [11:48:29] but no code yet afaik [11:48:43] Lydia_WMDE: do you have a link? [11:49:17] no :( i'd need to ask heening [11:49:20] *henning [11:49:54] a link in the bug report would be quite useful, too :) [11:50:14] * benestar searches on commons [11:51:07] Lydia_WMDE: maybe this one? https://commons.wikimedia.org/wiki/File:Site_link_badges_edit_interface.png [11:51:42] benestar: that looks right [11:52:42] Lydia_WMDE: but I see a problem there [11:53:01] which? [11:53:14] this either means that there might be several badges or that there can only be some kinds of badges [11:54:15] according to the current implementation a badge can be any item [11:55:11] however I am not sure if this is more useful because we have to think about where the icon is stored that should be used to display the badge on Wikipedia [11:59:22] Lydia_WMDE: maybe we need a complete rethink about badges [12:00:11] benestar: didn't we decide to configure allowed badges in the config? [12:00:16] and save the icon and item there? [12:00:45] Lydia_WMDE: this would be new to me [12:01:06] but it makes sense. However storing item ids in the config isn't the best idea [12:01:51] I think nothing of that is already implemented though [12:03:49] hmmmm [12:03:52] i thought it was [12:03:59] but not 100% sure [12:09:05] Lydia_WMDE: I am just looking at the code and as far as I can see the badges are implemented but any item can be a badge [12:09:23] ok [12:20:14] Lydia_WMDE: should the config belong to the Wikibase extension or the WikibaseDataModel extension? [12:20:54] benestar: i'd say the former but that is JeroenDeDauw's territory [12:27:51] Lydia_WMDE: damnit, he left [12:27:52] you [12:27:55] 're right [12:28:06] it is to be done in config [12:28:14] lazowik: ok cool [12:28:18] lazowik: but just not done yet? [12:28:22] yep [12:28:25] alright [12:28:32] only api is done [12:28:40] cool [12:28:56] and as far as I remember that's for starters [12:29:15] later some administration page is to be done or sth like that [12:29:15] ? [12:29:21] ah [12:29:26] instead of the config you mean? [12:29:30] mhm [12:29:35] or? [12:29:50] hmm? [12:30:15] maybe I'll write that down in the bug [12:30:16] config on-wiki: not really important imho [12:30:23] ah [12:30:25] maybe [12:30:36] hopefully those change rarely anyway [12:30:52] so i think it is better to spent time on other things tbh [12:32:06] Lydia_WMDE: hmm, should I add that to the UI bug or general one? [12:32:08] I'd say ui [12:32:21] it's actually strictly connected with ui [12:32:24] ok [12:32:26] api won't limit anything [12:32:43] if ^ that's okay [12:33:09] it shouldn't be possible to do more via the api than the UI [12:33:17] hmm [12:33:23] because we'll not have a way to display random items [12:33:30] when we don't have the icon for them [12:33:39] right [12:33:59] oh, now I remember [12:34:07] later ui was to be expanded [12:34:14] to allow for any items as badges [12:34:21] a bit like aliases [12:34:28] but later [12:34:40] well i don't think we want to allow any item [12:34:47] but any of a selected group [12:35:15] heh, it was decided quite opposite before ;) [12:35:37] even before implementing api [12:35:43] hmmm i am pretty sure we decided it that way [12:35:53] because again how do we want to set icons for example [12:36:22] pff, just no icons :p [12:36:28] heh [12:37:28] irc logs to the rescue [12:39:31] benestar: heh, you left just to skip a discussion about badges :p [12:39:39] take a look at log :p [12:40:13] sorry, lost connection [12:41:32] lazowik: I would strongly recommend to check the config in the ChangeOp [12:42:25] at least if we only want to allow specific item ids [12:42:34] which is the only thing that makes sense to me atm [12:43:09] The badges will be automatically added in front of the sitelinks so the original intention was to replace the templates in the article itself [12:43:20] *because [12:43:53] so we *need* an icon as it's the thing why badges exist originally [12:44:39] Lydia_WMDE , lazowik --^ [12:44:55] *nod* [12:45:19] okay [12:45:36] but I'm not going to code anything anyway :) [12:45:38] for now [12:45:56] lazowik: I will take care of the config variables (hope I will get enough time) [12:46:20] Lydia_WMDE: when's the branching? [12:47:42] lazowik: next one should be tuesday but we might skip that one [12:48:01] Lydia_WMDE: are the badges a repo or a lib setting? [12:48:10] but since there is still the UI part at least missing i don't think we're in a rush for the next branch [12:48:39] Lydia_WMDE: can always add stripping of non-configured badges [12:48:42] benestar: i'd say repo but JeroenDeDauw has the last word [12:48:57] gnah, why is JeroenDeDauw not here right now? [12:49:14] hmm, because it's Sunday? :p [12:49:27] I'd rather ask why we _are_ here :) [12:49:31] :D [12:49:38] :P [12:49:40] word [12:49:53] xD [12:49:58] * Lydia_WMDE goes and takes care of laundry [12:50:11] hehe :p [12:50:14] * hoo goes and takes care of Lua integration tests :P [12:50:16] that's right, but I have only time for that when they do not work... [12:50:32] it's really annoying -.- [12:50:39] benestar: wikidata-tech to the rescue [12:50:45] or whatever it's called [12:50:51] yes, but that isn [12:50:58] 't really comfortable [12:51:21] still better than nothing [12:53:47] benestar: maybe write the decision about configurable list of allowed badges in the bug? [12:54:06] k, will do now [12:54:08] decision/proposal whatever [12:54:48] also if I remember correctly the icons are to be configured in mw messages [12:54:57] so in config you have a list of ids [12:55:27] and then on wiki messages like badges-{id}-icon [12:55:44] or maybe you'll come up with something better [12:55:58] just letting you know what was discussed [12:57:39] lazowik: see my comment on the bug, I only wrote icon so how exactly it is stored is still open [12:57:53] lazowik: so the mwmessage then contains an url? [12:58:14] why can't we direclty use the url in the config variable? [12:58:52] I think this messages can contain images themselves [13:00:05] lazowik: :O how should that work? [13:00:15] not sure though [13:00:43] Lydia_WMDE: because the icon needs also to be accessed via the client, I think the config should go into the lib [13:07:04] benestar: ok true. makes sense [13:09:08] benestar: hmm, I think it's possible to pass badge is to message [13:09:17] which will include the right file [13:09:42] lazowik: might you explain this a bit further? I don't get the point [13:09:44] see https://en.wikipedia.org/wiki/MediaWiki:Fileexists-shared-forbidden [13:10:08] thought that's wikisyntax still [13:10:19] um, just ignore that :p [13:10:43] I don't think that we should use wikisyntax at that place [13:10:47] (03PS5) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 [13:11:12] because that creates some html which is unusable [13:12:48] (03CR) 10Hoo man: Integration tests for Client's Scribunto integration (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man) [13:12:52] lazowik: currently the icons are added using CSS so this cannot work using wikisyntax :P [13:19:35] (03PS6) 10Hoo man: Integration tests for Client's Scribunto integration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 [13:20:50] (03CR) 10Hoo man: "Some sanity changes to WikibaseClient, minor stuff" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man) [13:36:27] (03PS1) 10Hoo man: Make Wikibase Client tests pass if no ClientStore can be constructed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108327 [14:13:40] hoo: do you know how I can set some config variables for tests only? [14:14:07] benestar: You man in Wikibase\Settings? [14:14:13] yes [14:14:27] because the tests will fail with badges restricted to some items [14:14:49] however I think it is a bad idea to set the items used in the tests as default ones [14:16:32] benestar: In a nutshell: You can change the global singleton... it is constructed once and then set in stone (that sucks). [14:16:48] If you're able to inject an own SettingsArray, you can of course do whatever you want to that [14:16:53] * can't [14:16:58] in the first one, doh [14:19:20] hoo: isn't there anywhere a test config file? [14:19:47] no, tests shouldn't rely on config (I know they do...) [14:20:47] gnah, so how can I fix this issue? [14:21:17] I know it is even worse to store item ids in config but this is how Lydia_WMDE said to do it [14:21:25] Oh, I was wrong, didn't realize that Settings extends SettingsArray [14:21:42] so you can actually set settings, but be careful [14:22:05] Settings::singleton()->setSetting( 'foo', 'bar' ); [14:22:09] hoo: is there any global starting point? [14:22:28] Settings::singleton() [14:22:29] where the settings can be set once and then one can rely on that settings? [14:23:13] there are defaults etc... but if you need a setting for a test and can't find a way around that, the sanest is to just set it for that test [14:23:33] k, this is a bit ugly but I think we cannot change it [15:02:05] hoo: what means that? Warning: Class 'Wikibase\DataModel\Entity\Item' not found in C:\xampp\htdocs\mediawiki\w\extensions\WikibaseDataModel\WikibaseDataModel.php on line 35 [15:02:55] benestar: I think you're using an ancient version DataModel... did you get that via composer? [15:03:06] no, via git clone [15:03:12] but it should be master [15:03:24] benestar: The current DataModel is on github [15:03:32] You probably have the gerrit one [15:03:35] yes... [15:03:47] aren't they synchronized? [15:03:50] Installations without composer are deprecated [15:03:53] doubt it [15:05:06] (03CR) 10Hoo man: "Finally made this independent from Repo..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108298 (owner: 10Hoo man) [15:06:43] hoo: ok, installing composer [15:13:47] hoo: how must I call composer? [15:14:23] composer install --prefer-source [15:14:41] --prefer-source is optional, but it's the better option for developing [15:16:32] hoo: still get one error message [15:16:38] mh? [15:16:54] Fatal error: Class FakeDatabaseMysqlBase contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (DatabaseMysqlBase::mysqlFieldType) in C:\xampp\htdocs\mediawiki\w\tests\phpunit\includes\db\DatabaseMysqlBaseTest.php on line 32 [15:17:20] seems to be a mediawiki error... [15:17:53] mh... are you on MediaWiki master? [15:19:00] updating again [15:25:43] benestar: Lydia_WMDE what is the question? [15:26:18] hi JeroenDeDauw :) [15:26:26] we just had a discussion about badges [15:26:27] JeroenDeDauw: where the config for badges should be stored [15:26:31] in lib or repo [15:27:07] but this seems already to be clear as the config is also needed on the client [15:27:08] basically it would be "this badge is represented by this item and has this icon" [15:35:29] Lydia_WMDE: we also need a possibility to access this config using javascript for the ui [15:35:40] yeah [15:35:41] just noting [15:40:44] (03PS1) 10Hoo man: Set the right audience in ContentRetriever::getContentForRequest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/108334 [15:42:47] Lydia_WMDE: oh, I just realized that in the code one sitelink can contain several badges [15:43:08] benestar: that is planned for the future, yes [15:43:11] already possible? [15:45:03] Lydia_WMDE: benestar You cannot "store" config in lib, it is not an application instance [15:45:46] You could have code in there used for this functionality if you really wanted to, though that is also a bad idea [15:45:56] the representation could be different in repo and client [15:46:03] Generally putting anything in lib is a bad idea, this thing should die [15:46:42] Lydia_WMDE: where is this icon info specified? [15:47:17] JeroenDeDauw: that is what we are debating about ;-) [15:47:24] nowhere yet [16:04:09] Lydia_WMDE: ./20130722.txt:[09:30:03] there would be no set of allowed badges [16:04:10] :p [16:04:38] O [16:04:42] Oo even [16:05:07] but look at the date :) [16:05:15] yeah [16:05:33] i don't think it is a good idea to allow arbitrary badges beyond the configured ones [16:05:47] but of course any kind of badge can be added to the config [16:05:55] mhm [16:07:15] the thing is that the UI that is planned currently is sufficient for a few badges at most [16:07:47] and I think that community will request more [16:08:59] that list cannot be long -> https://commons.wikimedia.org/wiki/File:Site_link_badges_edit_interface.png [16:09:07] so probably only FA/GA [16:09:07] lazowik: i think we should plan with about 5 badges per article and optimize for that as the max [16:09:21] usually less than 5 [16:09:25] hmm [16:09:52] ok then [16:10:15] I'll generously agree :p [16:10:22] :P [16:10:44] You could have an "has n or more badges" badge for every n from 1 to 42 [16:11:00] JeroenDeDauw: !!! [16:11:01] :D [16:11:17] lol [16:11:31] MILLIONS of badges :p [16:11:36] and scrollable list [16:11:51] heh, JeroenDeDauw is here, so benestar of course isn't [16:12:07] JeroenDeDauw: benestar wanted to ask where should config for badges go [16:12:12] (repo or lib) [16:12:27] scroll up ~40 lines [16:12:41] heh [16:12:43] right [16:13:19] so much observation skills [16:13:21] wow wow [16:17:05] Lydia_WMDE: yes, api and datamodel support multiple badges per sitelink [16:17:36] also what about badge names and i18n then? [16:17:47] that is what the items are for [16:17:53] so we can use their labels [16:18:06] ah [16:18:12] of course [16:18:15] :) [16:35:20] hey, I think I again just missed a discussion, right? [16:35:21] Lydia_WMDE: JeroenDeDauw [16:35:23] ;) [16:35:49] benestar: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23wikidata [16:36:47] Lydia_WMDE: so do we want to support multiple badges? [16:36:54] if yes we must rethink the ui [16:37:06] maybe some checkboxes indicating if the badge is set... [16:37:07] yes we do but not necessarily in the first round [16:37:09] (17:09:02) Lydia_WMDE: lazowik: i think we should plan with about 5 badges per article and optimize for that as the max [16:37:25] the first round is fine with just one badge [16:37:35] however, I think checkboxes are a nice idea :) [16:37:55] why not developing a good interface from the start? [16:38:08] also it is problematic if we support multiple badges from api but only one from ui [16:38:08] changing later is more expensive [16:38:23] benestar: yes api and ui need to be the same [16:38:40] so I think we can start with multiple badges per lbenedix1 [16:38:46] benestar: checkboxes are not so good because potentially there can be like 100 or more badges in total to chose from [16:38:47] I think that changing this ui from mockup is easy [16:38:52] there is no code written yet [16:39:02] Lydia_WMDE: 100 badges??? [16:39:10] not for a single link [16:39:17] but in total i don't see why not [16:39:18] this isn't the basic idea of badges [16:39:29] people want it for things like copy editing needed [16:39:30] they should only do the things they do now [16:39:39] or sources needed [16:39:40] and s on [16:39:42] *so [16:39:53] Lydia_WMDE: I think that is a bit too much atm [16:40:07] that is why one badge is fone for the beginning ;-) [16:40:13] *fine [16:40:14] this would result in a new statement system [16:40:18] no [16:40:38] there would be no qualifiers or anything like that [16:40:52] (though someone suggested that arleady :p) [16:40:58] Lydia_WMDE: when allowing hundrets of different badges we cannot store them in config [16:41:04] *hundreds [16:41:15] the badge could be a wikidata item [16:41:25] lbenedix1: they are [16:41:26] because every time someone proposes a badge we would need to submi a patch [16:41:36] benestar: yes and that is fine [16:41:45] benestar: it shouldn't be competely arbitrary [16:41:57] and tbh i dont expect it to become more than like 20 at the beginning [16:41:59] probably less [16:42:32] Lydia_WMDE: so they really want to see an icon in every wikipedia indicating that this article needs sources? [16:42:43] no [16:42:44] I think missing sources is a very local problem [16:42:50] benestar: how this information is used is another thing [16:42:52] which has nothing to do with wikidata [16:42:57] lazowik: right [16:43:12] Imho everything local should be handled locally [16:43:25] but then badges are local :p [16:43:26] there are categories + templates for that purpose [16:43:36] lazowik: but badges show up globally [16:43:39] do you get the point? [16:43:52] benestar: they need to be available in structured form though for some of the tools people want to build for editor engagement for example [16:44:01] and i think it is fine to have those on wikidata as a badge [16:44:13] they would not show up on every wiki [16:44:37] who is making the 100 Icons? [16:44:52] :D [16:45:13] damned internet connection, sorry [16:45:50] Lydia_WMDE: why shouldn't this work using categories? [16:45:57] I really oppose making badges so broad [16:46:01] we are mixing things up here if we allow badges to show every meta information of the article [16:46:40] benestar: so you'd like to limit only to fa/ga? [16:48:18] lazowik: yes [16:48:46] only the ones that are currently supported via templates [16:49:04] we can limit it to that initially but then we will have to extend it [16:49:11] we can think about a article meta information feature later [16:49:34] but I think this requires something different than our current implementation of badges [16:50:06] Lydia_WMDE: I fully understand the intentions of editors but this needs something bigger [16:50:14] afk now, cu later [16:50:41] hmm [16:50:48] i don't see why it needs something different [16:50:57] and why we should treat those differently [16:51:03] Lydia_WMDE: do you have any thoughts on organizing ui better in general? [16:51:15] but i am open for suggestions [16:51:26] lazowik: you mean the UI redesign? [16:51:28] yes [16:51:32] and I'm not talkig about shrinking boxes 1px, but a redesign [16:51:34] yup [16:51:45] i was in San Francisco this past week [16:51:50] e.g. tabs for section or something of that sort [16:51:56] and talked to the designers of the foundation there [16:52:12] quite some ideas but nothing concrete yet [16:52:12] mhm [16:52:25] how far fetched changes? [16:52:55] also, initially the project was supposed to be led by wmde for 1 year? [16:53:03] generally less boxes, fresher colors, more visual, less information overload [16:53:31] yes and then we decided to continue because that made most sense [16:53:55] and now looks like nowhere near to end :) [16:53:59] heh, I hope it won't "stick out" [16:54:11] can't get too funky with vector [16:54:19] (vector around) [16:55:20] (all these question beacuse I hope to get back in after exams :) ) [16:55:29] sweet [16:55:39] so my plan for the near term: [16:55:56] * publish plan for 2014+ this coming week [16:56:10] * go through paper cuts [16:56:24] * get quantities into releasable state [16:56:39] * sit down with henning to get a clearer plan for UI redesign [16:56:59] mhm [16:57:03] 2014+ ? [16:57:09] how far is the "+" [16:57:25] heh [16:57:30] depends on how fast we are [16:57:41] i don't really know yet because there are a few ugly unknowns in there [16:57:56] gah, I'm asking hard questions ;) [16:58:02] you are! [16:58:03] :P [16:58:12]