[00:08:28] (03CR) 10Springle: "Is there any context besides the bug report on why this is being done?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 (owner: 10Daniel Kinzler) [00:15:32] (03CR) 10Hoo man: "@Springle: You might find more context in https://bugzilla.wikimedia.org/show_bug.cgi?id=54085" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 (owner: 10Daniel Kinzler) [00:16:27] can anyone tell me the property to use to differentiate the name of a position for different time periods [00:19:21] Lydia_WMDE: so no oldwikisource after alll? [00:19:49] rschen7754: Lydia's probably already sleeping, 1am over here [00:19:54] ok [00:20:08] rschen7754: not zet [00:20:10] yet [00:20:17] ok [00:20:30] aude: German keyboard again? :P [00:20:40] * aude rage [00:21:21] I just tried to open Q30 (USA) and now my firefox is frozen for over a minute [00:21:34] don't even have debugging console open :P [00:21:57] hoo, place is covered in snow, it is a sympathy reaction [00:22:18] * aude can't view Q9682 (queen elizabeth ii) [00:22:56] the next deploymetn will help... parser cache, and we might get new indices for the terms table sooner [00:22:58] sDrewth: :D Got it now :P [00:23:08] Regarding your question: There's start and end date [00:23:14] thaw has set in [00:23:21] I wonder what "🇺🇸" as alias for USA mean [00:23:30] * hoo only sees boxes [00:24:23] aude: Also waiting for more server side formatters... not going to happen in this deploy though, I guess [00:24:29] hoo: unicode “Regional Indicator Symbol” for U and S respectively [00:25:13] ah :) [00:26:09] https://en.wikipedia.org/wiki/Regional_Indicator_Symbol [00:26:29] hoo: it is \ud83c\uddfa\ud83c\uddf8 [00:26:34] Apparently it’s so that some programs can interpret ISO codes as flags? [00:26:36] whatever decodes to [00:27:41] hawke1: The spec. would at least allow that [00:27:49] but i doubt anyone does that (yet) [00:28:03] Yep. [00:28:26] Seems stupid. Feels too close to markup being in a character encoding. [00:29:38] I don't really see why they did that either [00:30:01] solving problems we don'T ahve :P [00:30:30] oh, it’s as an alternative to an even stupider idea [00:30:36] encoding flags as actual characters [00:32:47] fan immediately gets slower after closing Midori with Wikidata Q30 :/ [00:48:03] (03CR) 10Springle: "I don't advise modifying a normalized table for the sake of an external ID representation that looks fairly easy to convert back and forth" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 (owner: 10Daniel Kinzler) [00:57:41] (03CR) 10Springle: "s/lower selectivity string index/lower efficiency string index/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 (owner: 10Daniel Kinzler) [03:05:06] heh [03:05:10] I saw an american flag when he posted it [08:03:26] (03PS5) 10Henning Snater: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 [08:34:35] http://ultimategerardm.blogspot.nl/2014/01/wikimedia-multimedia-featuresvision-2016.html [09:26:15] * danbri waves  [09:26:26] Just noticed upcoming dbpedia meeting - http://wiki.dbpedia.org/meetings/Amsterdam2014 [09:26:36] anyone from the wikidata project / community planning to attend? [09:42:11] danbri: Hoi I am likely to speak there [10:05:35] (03PS6) 10Henning Snater: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 [10:08:34] ouh... are Wikibase changed supposed to show up in -dev? [10:08:54] blegh [10:08:55] my fault [10:11:52] ;) [10:35:48] gerardm, that's great. I was mildly concerned the word 'wikidata' didn't appear on the event page, given the importance of this project [10:39:13] danbri it is much better [10:39:31] they are considering to actively involve themselves in Wikidata [10:39:43] as far as I am concerned, that would be AWESOME [10:40:27] Lydia_WMDE: https://www.wikidata.org/wiki/Wikidata:Forum#kein_Eingabefeld_f.C3.BCr_Seitenname mh... [10:40:45] hoo: yeah just saw it... [10:46:55] (03PS7) 10Tobias Gritschacher: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 (owner: 10Henning Snater) [10:49:01] Lydia_WMDE: Do we still want https://gerrit.wikimedia.org/r/96232 ? [10:49:11] I not understand the demo at http://suggester.wmflabs.org/wiki/index.php/Spezial:PropertySuggester [10:49:27] how do I use it ? [10:49:42] GerardM-: see my comment on project chat - that should make it clearer [10:49:52] hoo: yes [10:50:09] hoo: depends on jens writing the announcement and all [10:50:46] the patch needs some love also [10:51:14] thanks Lydia_WMDE [10:51:32] np [10:52:35] (03CR) 10Hoo man: [C: 04-1] "also needs a manual rebase and an announcement" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96232 (owner: 10Jens Ohlig) [11:00:39] Lydia_WMDE: snitchen in 30 mins? [11:00:54] JeroenDeDauw: grandma has fishnchips today [11:00:55] :P [11:00:59] schnitchen [11:01:19] mmmm fish n chips [11:01:39] Lydia_WMDE: they also have non-evil food yes [11:01:53] * JeroenDeDauw wants a chipsnsalad [11:02:49] aude: https://dl.dropboxusercontent.com/u/7313450/entropy/cheat.jpg [11:03:21] you have a cat picture for everything [11:03:31] :D [11:03:58] Where's Daniel... meh [11:05:18] Lydia_WMDE: Do you want your Lua patches served with unit tests? :P [11:05:31] hoo: i loves me some tests :P [11:06:04] Ok... that will be a little tough at that thing has some bad global state in it :P [11:06:34] * aude impressed with https://en.wikipedia.org/wiki/Wikipedia:Lua_unit_testing [11:06:43] that wikipedians are encouraged to provide tests [11:07:11] aude: Wow :) [11:07:19] :) [11:07:27] in practice, no idea if anyone does that [11:07:31] :P [11:07:53] I hope that someone will contribute a patch which allows to make Template:Infobox a wrapper around Capiunto [11:08:10] would be cool [11:15:25] $ git pull [11:15:26] fatal: unable to access 'https://git.wikimedia.org/git/mediawiki/extensions/Scribunto.git/': Peer's Certificate issuer is not recognized. [11:15:27] wtf [11:15:53] ? [11:16:06] aude: Just tried to get my Scribunto up to date [11:16:56] * expire date: Aug 24 12:06:49 2015 GMT [11:16:56] * common name: *.wikimedia.org [11:17:25] * aude trying to fix beta [11:17:28] curl: (60) Peer's Certificate issuer is not recognized. [11:17:46] i have not seen certificate error [11:20:00] gerardm-: they are considering to actively involve themselves in Wikidata as far as I am concerned, that would be AWESOME [11:20:06] absolutely agree [11:20:50] * danbri might make a daytrip to amsterdam from London for it [11:21:43] [11:22:20] aude: Got the problem... I've cloned through git.wikimedia.org for some reason and not gerrit.wikimedia.org [11:23:23] * hoo needs to fix his remotes for Scribunto... but not now [11:23:25] (03PS1) 10Addshore: Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 [11:24:44] (03CR) 10Addshore: [C: 04-1] "unwanted changes got dragged into this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 (owner: 10Addshore) [11:25:43] Lydia_WMDE: omnomnom! [11:26:35] JeroenDeDauw: jep - in 5 mins with Tobi_WMDE and Henning_WMDE [11:26:40] and maybe others [11:27:46] (03PS2) 10Addshore: Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 [11:28:08] sounds like my laptop needs to be cleaned again ~:/ [11:29:08] (03CR) 10Hoo man: [C: 032] Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 (owner: 10Addshore) [11:29:24] (03Merged) 10jenkins-bot: Fix Undefined Index and array_merge warning in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106676 (owner: 10Addshore) [11:29:24] if( !array_key_exists( 'evilDataValueMap', $GLOBALS ) ) { that looks rather pythonic... if 'foo' in bar: [11:36:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1533 (master - 3142dfc : addshore): The build was broken. [11:36:24] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/fb4ef2bf3147...3142dfc6df32 [11:36:24] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16716037 [11:38:40] ewk, these are actual failures [11:38:45] not just PHP segfaulting [12:06:43] (03PS1) 10Hoo man: Use test sites in ActionTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106683 [12:08:44] (03PS2) 10Hoo man: Use test sites in ActionTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106683 [12:21:23] aude: addshore: ^ [12:21:33] This will fix the recent failures on Travis [12:31:55] we were at lunch [= [12:32:40] addshore: how dare you? :D [12:34:06] hoo: how does that fix? [12:35:00] aude: It inserts the sites into the DB :P [12:35:18] no further errors came up locally, so I guess that's it [12:35:34] hmmm [12:35:37] evil global stuff [12:35:42] hooks [12:35:44] yeah [12:39:33] aude: Any better idea to handle these? [12:39:51] no but i'd need to see the tests again [12:40:11] is this the segmentation fault? [12:40:14] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/16716040 mh? [12:40:25] aude: Nope, new failure [12:40:25] s [12:40:53] There would be way more yays from /me if I found a fix for the segfaults :P [12:41:09] why is it failing now? [12:41:20] no idea what changed [12:41:33] but we had similar stuff befroe [12:41:47] probably an execution order thing [12:41:56] test sites would work or not run the hook in client like my patch or set the hooks global [12:42:15] * aude saw that failure before [12:42:18] hence my patch [12:44:24] mh? the one we decided to abandon because it changed client? [12:44:28] aude: ^ [12:45:45] yeah [12:46:12] i don't like any of the solutions that much but okay if it helps [12:46:35] yeah :/ [12:50:29] Tobi_WMDE: re [12:51:10] gerrit down? [12:51:14] hashar: hey [12:51:26] you got my question? [12:51:31] trying to update my code, pull not returning [12:51:47] hashar: thnx for https://gerrit.wikimedia.org/r/#/c/106667/ [12:52:16] JeroenDeDauw: Like "fatal: unable to access 'https://git.wikimedia.org/git/mediawiki/extensions/Scribunto.git/': Peer's Certificate issuer is not recognized." ? [12:52:26] Tobi_WMDE: yup [12:52:57] Tobi_WMDE: so if you want to receive events from gerrit, you will need an account on wmflabs, and that account needs to be added in Gerrit to a "stream events" group [12:53:25] hashar: not getting an error, though also seems like a problem with wmf git [12:53:50] Tobi_WMDE: that would grant the user account the stream-events rights which is needed by the Gerrit event plugin. [12:54:12] Tobi_WMDE: basically, it let you ssh to gerrit and listen for events send as json blobs. [12:54:17] hashar: ok. I tried it with my labs user and that one seems to not be in that group. If I'm going to create a new one, can you then add it to the group? [12:54:30] Tobi_WMDE: possibly [12:54:41] I'll send you an email then [12:54:50] Tobi_WMDE: another solution is to use Zuul which already listen for events, then create Jenkins instances in a labs project [12:55:01] Tobi_WMDE: and we could get our Zuul system to trigger jobs in your jenkins instance :D [12:55:06] I thought about yesterday [12:55:24] would even let you get composer installed since you would have root on the instances hehe [12:55:37] hashar: that could also work, though I'd like to have as few steps involved as possible [12:56:05] in the second case, create an instance, get jenkins installed (that is class) then add that new jenkins to the Wikimedia jenkins [12:56:06] hashar: do you happen to know if making a repo that is currently deployed "hidden" (gerrit setting) would cause problems from a deployment perspective? [12:56:10] from there we can add jobs easily in Zuul [12:56:35] heck we could even restore the jobs that got disabled a few days ago, and tag them so they run on the labs instance [12:57:07] hashar: would be awesome [12:57:16] JeroenDeDauw: I have no idea what you mean by "hidden" [12:57:29] we can just have our own jenkins in labs? [12:57:59] for composer all it really needs is composer.phar [12:58:01] hashar: one can make a project on gerrit "hidden". 3 possible states: active, read only, hidden [12:58:06] no install required [12:58:39] JeroenDeDauw: I guess folks that do deployments would have to have their account allowed to see the hidden repo. Why do you want to hide a repo anyway? [12:59:01] aude: we can get Jenkins installed on a labs instance. I got a puppet class to do that already [12:59:07] hashar: \o/ [12:59:18] which labs project? integration? [12:59:24] aude: that install basic components and a user account on a labs instance. Then one (i.e. me) can register that instance in the Wikimedia Jenkins. [12:59:30] wikidata ? :D [12:59:35] wikidata is fine [12:59:49] * aude happy [13:00:19] i can poke at that in a bit [13:01:13] aude: Want to merge https://gerrit.wikimedia.org/r/#/c/106683/ first? :P [13:01:47] * aude busy [13:02:28] also hashar, i was trying to fix beta code update earlier [13:02:33] will need a bit more things to fix up though [13:02:38] a sub submodule of elastica got removed [13:02:43] oh [13:03:03] trying to figure out how to get it removed on beta and get code update working again [13:04:11] updating elastica, i kept getting "could not detach HEAD [13:04:16] bah [13:04:53] (03PS1) 10Tobias Gritschacher: Don't get extra languages for anon users [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106689 [13:04:54] probably chad can help since they had to fix this in production [13:05:36] aude: I might have fixed it [13:05:47] ok [13:05:52] basically wen to Elastica director,y deleted the submodule [13:05:57] then git reset --hard [13:06:03] you mean delete the directory? [13:06:23] (03PS8) 10Tobias Gritschacher: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 (owner: 10Henning Snater) [13:06:29] ahh my english is screwed toda [13:06:29] y [13:06:43] I deleted /home/wikipedia/common/php-master/extensions/Elastica/Elastica [13:06:46] yeah [13:06:54] DanielK_WMDE: Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/106689/ [13:06:59] that's what i was going to try next then got interrupted for lunch [13:07:40] that would have fixed it [13:07:52] yay [13:08:03] https://integration.wikimedia.org/ci/job/beta-code-update/37596/console [13:08:07] it is running [13:08:09] hopefully [13:08:10] waiting [13:08:47] also update .gitmodules to ahve it clean :P [13:09:48] another issue we have on beta is that mediawiki/extensions.git is broken and not self updating [13:13:34] hoo: [13:13:39] yes? [13:14:03] Is your -1 in https://gerrit.wikimedia.org/r/#/c/106242/1 only because of the comment in the diff or is there anything else wrong with the change? [13:14:12] * hoo looks [13:14:38] Adrian_WMDE: The module 'jquery.valueview.experts.wikibase.entityidvalue' needs wikibase.store.FetchedContent [13:14:44] unless I got something wrong [13:14:55] would be nice if you could also fix this [13:15:37] I got that; my question is: Is that the only issue or is there anything else? :) [13:16:06] Adrian_WMDE: Nope, despite it should be fine... I grepped for FetchedContent briefly and that looked good [13:16:11] if you fix this, I'll approve ;) [13:16:34] Ok, thanks [13:22:50] andre__: thanks! pain.... [13:22:57] I know... [13:23:05] lots of pain in BZ currently. No fun. :) [13:24:00] (03CR) 10Jeroen De Dauw: [C: 04-1] "return type mismatch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106689 (owner: 10Tobias Gritschacher) [13:24:19] EntityViewPlaceholderExpander? [13:24:21] yay, beta updates again [13:25:58] aude: using the build? [13:26:20] JeroenDeDauw: no [13:26:47] probably will use it early next week [13:27:07] aude: so what does it update to then? [13:27:19] JeroenDeDauw: Git master from gerrit?! [13:27:21] JeroenDeDauw: updates core and *all* the extensions to master [13:27:36] it stopped updating because of a problem in elastica [13:27:51] and there was localisation cache issue also , yesterday that i fixed [13:28:00] he, someone is finally complaining! https://bugzilla.wikimedia.org/show_bug.cgi?id=59892 [13:28:22] hah [13:28:28] hehe [13:28:40] (03PS11) 10Addshore: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 [13:29:00] (03CR) 10Addshore: "PS11 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 (owner: 10Addshore) [13:29:07] DanielK_WMDE: speaking of bugs.... we are getting quite a bit of stuff in exception logs due to api xml format [13:29:20] i would like to go ahead and deploy https://gerrit.wikimedia.org/r/#/c/106565/ (and the dependency required) [13:29:20] :O [13:29:38] would you or addshore look and make sure you don't see issue with that [13:29:41] aude, addshore: that should be fixed by my changes to ResultBuilder [13:29:46] see patch [13:29:59] * aude verified, passes tests and poked manually  [13:30:00] yes, that one :) [13:30:10] then someone +2 :) [13:31:03] i'd rather not wait 2 weeks for this since it's causing a problem (people actually use xml apparently) and polluting the logs [13:31:35] (03CR) 10Daniel Kinzler: [C: 032] Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106564 (owner: 10Aude) [13:31:39] thanks [13:31:52] (03Merged) 10jenkins-bot: Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106564 (owner: 10Aude) [13:32:13] addshore: have you looked at this patch? I'm about to give a +2, but would beel better if you had a quick look first [13:32:23] which patch? :P [13:32:25] one one that messes with ResultBuilder, not the injection one [13:32:40] addshore: https://gerrit.wikimedia.org/r/#/c/106565/2 [13:32:42] https://gerrit.wikimedia.org/r/#/c/106565/ [13:32:45] looking now [13:32:49] https://gerrit.wikimedia.org/r/#/c/106565/2/repo/includes/api/ResultBuilder.php [13:33:47] this should make sure the indexTagName stuff is always set correctly [13:36:01] (03CR) 10Addshore: [C: 04-1 V: 04-1] Make ResultBuilder's "indexed mode" work consistently. (031 comment) [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 (owner: 10Aude) [13:38:07] damn rebase! [13:38:15] [= [13:38:21] * aude fixed it [13:38:36] How do I switch over to the new DataValues in my test MediaWiki installation? Just remove the old one and git clone DataValues/DataValues? [13:38:36] (03CR) 10Daniel Kinzler: [C: 04-1] "looks sensible. didn't try. -1 for no tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [13:39:21] Adrian_WMDE: remove old then composer install in wikibase [13:39:31] * addshore needs to do that :P [13:40:03] use --prefer-source with composer, so it pulls the dependencies from git [13:40:12] +1 [13:40:27] * DanielK_WMDE still has to figure out how to make it pull master [13:40:29] There's not even a debian package for composer [13:40:53] (03PS3) 10Aude: Make ResultBuilder's "indexed mode" work consistently. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 [13:40:58] there'S a PEAR package i think [13:40:59] Adrian_WMDE: wget http://getcomposer.org/composer.phar [13:41:03] so.. I need to delete eeeveerything, then just composer install? :P [13:41:07] ...or something... [13:41:08] addshore: Yep [13:41:13] * hoo just did the same [13:41:21] Adrian_WMDE: no [13:41:24] damn it [13:41:27] addshore: everything except Wikibase proper [13:41:28] addshore: no [13:41:35] no? :P [13:41:46] okay, so delete everything except wikibase ;p [13:41:53] or just move / archive datavalues old etc [13:41:57] ok... thought that was obvious [13:42:05] in case i have a branch or something i care about there [13:42:28] good point :P [13:42:30] or have to do deployments :) [13:42:40] dont think I have any branches :P [13:42:44] ok [13:42:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1534 (mw1.23-wmf6 - 05e1852 : addshore): The build has errored. [13:42:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/97e568933e5d...05e18522593c [13:42:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16721829 [13:42:55] made sure everything was drafted in gerrit before christmas incase my laptop decided to die :D [13:43:00] mh... these are coming from github now? [13:43:12] origin git://github.com/DataValues/DataValues.git (fetch) [13:43:20] they are [13:43:25] meh :/ [13:43:33] composer defaults to github [13:44:02] run git review -s to connect to a gerrit repo, if one exists (or rather, if there is a .gitreview) [13:44:07] whatever is in packagist [13:44:15] which is github for us [13:44:20] mh... but development is still on gerrit? [13:44:31] not for data values [13:44:54] https://www.mediawiki.org/wiki/Wikibase/Components [13:45:43] addshore: fixed the rebase https://gerrit.wikimedia.org/r/#/c/106565/ [13:46:06] what a mess... luckily I hardly have to touch anything beside Wikibase [13:46:07] will take another look once i can run the tests again [13:46:11] ok [13:46:47] our collection of repos for development has turned into a puddle! [13:47:17] yeah... also I prefer gerrit over github for various reasons [13:47:22] ball of mud! [13:48:31] "Wikibase: Incomplete configuration: $wgWBRepoSettings["entityNamespaces"] has to be set to an array mapping content model IDs to namespace IDs. See ExampleSettings.php for details and examples." meh :/ [13:49:26] wtf, that's tehre [13:50:24] wait. that's a client wiki [13:50:28] * hoo sighs [13:50:52] i think stuff gets enabled by default now (i dislike that a lot) [13:51:01] really? [13:51:04] wtf [13:51:11] there's some variable to set client and/or repo [13:51:12] by stuff what do you mean? :P [13:51:15] ask JeroenDeDauw [13:51:17] or Tobi_WMDE [13:51:19] oh common [13:51:27] by default both get installed [13:51:31] I'm rebuilding my personal set up every 3 months or so... [13:51:53] * aude would much prefer both not enabled by default [13:51:56] do like before [13:52:10] hoo: to enable a repo only set the following in your localsettings: $wgEnableWikibaseRepo = true; $wgEnableWikibaseClient = false; [13:52:21] by default both are true [13:52:27] unintuative [13:52:41] yeah [13:52:51] * aude set them to false [13:52:56] then do like i did before [13:53:12] we'll do that for beta and production, to be safe [13:53:24] aude: I do not oppose to change that. it confuses me some times before already.. [13:53:34] ok [13:53:50] that sort of magic scares me (i'm easily scared) [13:54:00] I really need to redo my wiki test suite thingy... [13:54:21] * hoo goes back to working [13:55:53] Tobi_WMDE: Henning_WMDE http://www.youtube.com/watch?v=3vM5u3VT_WE [13:56:11] Is there a way to identify (for instance with a qualifier) that an identifier to an external source has been verified ? [13:56:33] Henning_WMDE: ok, I thought he said Henning :( [13:57:55] Tobi_WMDE: WikidataJenkins should be able to stream events now [13:58:14] hashar: thx! will try it in a minute [13:58:23] is that a group for us? [13:58:33] just a user [13:58:37] ok [13:58:57] Tobi would like to hook Cloudbee instance with Gerrit :-D [13:59:32] yay [14:00:01] i can poke at jenkins in lab either later today or monday [14:00:06] labs* [14:09:39] DanielK_WMDE: Around? [14:15:12] mh :( [14:15:42] busy [14:15:57] I guess so :S [14:18:45] not sure it's smart to have this much application logic in Lua [14:18:51] but wel [14:18:52] l [14:20:07] (03PS2) 10Adrian Lang: Untangle wikibase.store module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106242 [14:20:22] hoo: ^ [14:20:29] * hoo clicks [14:21:04] Ok, gotta go [14:21:30] (03CR) 10Hoo man: [C: 032] "Poked at this before (PS1)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106242 (owner: 10Adrian Lang) [14:21:46] (03Merged) 10jenkins-bot: Untangle wikibase.store module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106242 (owner: 10Adrian Lang) [14:23:54] (03PS2) 10Tobias Gritschacher: Don't get extra languages for anon users [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106689 [14:24:26] hoo: hey. [14:24:31] "this much" like what? [14:24:52] (03PS3) 10Tobias Gritschacher: Don't get extra languages for anon users [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106689 [14:24:53] DanielK_WMDE: Like getting the entity in Lua, extract the Snaks and pass them back to PHP to format them [14:25:10] not even sure that pass back and format will work in a proper way [14:26:14] hoo: conceptuaqlly, the idea is this: you have an intzerface for fetching entities, and a way to traverse the entities data structure. [14:26:36] in addition, you have a service for formatting different bits of data from that structure as wikitext [14:27:06] that lets people output any part of an entity in any way they want, without having to re-implement formatting logic for different kinds of data values etc [14:27:58] the alternative would be to have an alternative "view" on the entity's data structure, one where you can say "give me the claims for that property as wikitext, with these options". [14:28:07] mh [14:28:27] that's kind of what johl did, but it should be bound to the actual entity, to avoid loading the entity over and over for every bit of information that needs formatting [14:28:33] Jens' approach was a single function which returned a table with values and labels [14:29:07] yea, btu that doesn't really work, and means massive overhead [14:30:34] The requested package wikibase/data-model dev-mw1.23-wmf6 could not be found. [14:30:36] :/ [14:30:45] addshore: try --prefer-source [14:31:03] ahh, for update also? :) [14:31:17] yikes [14:31:17] still seem to get the same message [14:31:38] (03PS4) 10Tobias Gritschacher: (DNM) just testing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106508 [14:32:10] addshore: delete the vendor dir, then try composer update --prefer-source [14:32:12] (03CR) 10WikidataJenkins: "Build Started https://wikidata-cloudbees.ci.cloudbees.com/job/wikidata-ci/3/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106508 (owner: 10Tobias Gritschacher) [14:32:20] (or was it "sources"?) [14:32:23] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106508 (owner: 10Tobias Gritschacher) [14:32:33] DanielK_WMDE: Ok, my new approach was to get the snaks from the Entity in Lua and pass these back to PHP for formatting, not sure that's a good idea though [14:33:10] hashar: it works. :) thx [14:33:14] hoo: it's how i would have done it. converting back and forth between the lua and the php form kind of sucks though [14:33:19] Could also do that in PHP and just pass the formatted string to Lua [14:33:35] do we ahve docs anywhere for our new dev workflow? :D [14:33:36] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1535 (master - 2740025 : Adrian Lang): The build is still failing. [14:33:36] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3142dfc6df32...2740025e107f [14:33:37] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16725087 [14:33:59] Tim Starling said that the conversion is rather efficient :P [14:34:12] hoo: no, it should be possibel to inspect the raw value vith lua [14:34:16] btw, what was the consensus for Draft: namespaces? [14:34:18] Tobi_WMDE: \O/ [14:34:39] (03CR) 10Jeroen De Dauw: [C: 04-1] "$skip (nice var name btw) is computed at the wrong point. This goes to show the method can be broken up, as now levels of abstraction are " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106689 (owner: 10Tobias Gritschacher) [14:35:02] DanielK_WMDE: mh... so you want an extra getSnaks public function for lua end users? [14:35:09] or rather getProperties [14:35:33] cause in the current way that's all in the function so it doesn't really matter whether PHP or Lua do the heavy lifting [14:37:26] JeroenDeDauw: care to come and fix my composer problem? [14:38:18] hoo: we already have a function that returns a table with propertyid -> list-of-snaks. [14:38:41] (or don't we?) [14:39:37] (03PS4) 10Tobias Gritschacher: Don't get extra languages for anon users [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106689 [14:39:59] (03PS5) 10Tobias Gritschacher: Don't get extra languages for anon users [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106689 [14:40:05] DanielK_WMDE: Nope... public Lua functions we have yet: wikibase.label( EntityId) wikibase.siteLink( EntityId ) and of course getEntity which just dumps the whole Entity [14:43:39] DanielK_WMDE: So... I guess you want that? Shall the user than per hand pass the properties that should be rendered or do we want to have a function which just dumps everything rendered [14:43:56] not sure how long rendering everything eg. for the "USA" or so would take [14:45:17] hoo: i want a function that formats one snak. [14:45:34] DanielK_WMDE: Ok :) Can do that [14:45:36] using a (Dispatching)SnakFormatter on the PHP side. [14:46:24] hm, doesn't getEntity() allow the user to get the table of properties, and then the list of snaks for a property? [14:46:27] i thought it did [14:46:50] DanielK_WMDE: Sure, but you have to go through it alone [14:46:57] we could have conveniance functions like getProperty() returning a list of snaks or something [14:47:16] would probably be nice, considering that this is the primary use case [14:48:45] DanielK_WMDE: Ok... so a getProperties which returns Snak[] (as lua tables) and then a formatSnak()?! ;) [14:48:54] that sounds good to me [14:49:12] getProperty( PropertyId ) -> Snak[] [14:49:32] ok, no generic get it all? [14:49:36] should be a member of the entity. so: [14:49:54] snaks = entity:getProperty( "P23" ) [14:50:10] then call formatSnak for each. [14:50:24] That's certainly nice... but the entities yet are plain table [14:50:32] not sure what people are doing with that [14:50:33] For conveniance, we could also provide formatSnakList, which uses commaList from the Language object to make a "nice" list [14:50:57] methods on the entity would be good better [14:51:04] we can live with a top level function for now [14:51:10] accessing "the" entity [14:52:06] (03Abandoned) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106508 (owner: 10Tobias Gritschacher) [14:52:20] (03PS1) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [14:52:24] mh... I would have done stuff quite a bit different in the first place... having the entity be a metatable and only have the "real" data in a .data or so... where most data happens through getters [14:52:33] * data access [14:53:19] (03PS2) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [14:53:33] hoo: yes, the way we have it in php. [14:53:58] hoo: we can still do that. make a function getEntityObject() that returns such a metatable. [14:54:19] (03CR) 10WikidataJenkins: "Build Started https://wikidata-cloudbees.ci.cloudbees.com/job/wikidata-ci/5/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:54:19] and deprecate getEntity? [14:54:22] yea [14:54:28] +1 [14:54:42] the current approach doesn't really scale [14:55:14] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:56:28] (03PS9) 10Addshore: (bug 57231) Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 (owner: 10Daniel Kinzler) [14:56:46] (03PS3) 10Tobias Gritschacher: (DNM) just testing stuff [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 [14:57:24] (03CR) 10WikidataJenkins: "Build Started https://wikidata-cloudbees.ci.cloudbees.com/job/wikidata-ci/6/" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:57:39] (03CR) 10WikidataJenkins: [V: 031] "Build Successful" [extensions/Wikibase] (cloudbees-testing) - 10https://gerrit.wikimedia.org/r/106703 (owner: 10Tobias Gritschacher) [14:58:31] "+++ [[ Fedora release 17 (Beefy Miracle) == Fedora release 17* ]]" [14:58:44] that's ancient in Fedora time :P [14:59:06] support ran out like 8 months ago [14:59:26] addshore: I fixed up Jenkins voting +2 on Wikibase [14:59:36] :D [14:59:39] addshore: two pipelines were triggered, one voting +1 and the other voting +2 hehe [14:59:48] ahhhhhh [14:59:57] I did thinkkkk it was odd when I saw jenkins come and vote twice :) [15:00:56] yup, just does +1 now! cheers! [15:03:32] (03CR) 10Addshore: [C: 032] (bug 57231) Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 (owner: 10Daniel Kinzler) [15:03:45] (03PS12) 10Addshore: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:03:54] (03Merged) 10jenkins-bot: (bug 57231) Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 (owner: 10Daniel Kinzler) [15:04:17] (03CR) 10Daniel Kinzler: [C: 031] "backport should be good, but i'll let addshore do the honours..." [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 (owner: 10Aude) [15:05:02] addshore: \o/ good to have you back :) [15:05:07] (03CR) 10Addshore: "If anyone still has the 'old development setup' to run the tests on that would be great!" [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 (owner: 10Aude) [15:05:12] DanielK_WMDE: ^^ :P [15:05:59] -- Create new entity object from given data [15:05:59] wikibase.entityFromData [15:06:11] DanielK_WMDE: ^ or do you rather want a full blown mw.wikibase.entity [15:06:25] hashar: still here? [15:06:34] see the funky thing jenkins did on https://gerrit.wikimedia.org/r/#/c/101855/9 [15:06:59] jenkins had +1v , I gave +2CR then it ran linting get submit jobs and +2v ed and merged it :/ [15:07:11] lucky I had actually run the tests but jenkins probably shouldnt do that ;p [15:07:35] unless it got confused as jenkins +2ed then +1 ved first :P hah! [15:07:51] hoo: i know too little about Lua to have a preference there [15:08:37] DanielK_WMDE: That's rather a "do we want everything in one big thing" or do we want to split stuff question language independent [15:09:25] hoo: the answer is generally "split it if that doesn't make things to tedious" :) [15:09:31] *too [15:10:24] that's probably also going to make unit testing easier... :) [15:12:55] good then [15:12:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1537 (master - b66981d : daniel): The build was fixed. [15:12:58] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/2740025e107f...b66981d3046c [15:12:58] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16727457 [15:16:41] (03CR) 10Addshore: [V: 04-1] "When running tests with this patch I get:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:17:35] (03PS3) 10Addshore: Use test sites in ActionTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106683 (owner: 10Hoo man) [15:17:49] (03PS12) 10Addshore: Add ungrouped list api parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/96268 [15:19:10] addshore: orr, the silly sitestable stuff. will ook into it. probably not before monday though [15:19:12] (03PS11) 10Addshore: (bug 56693) special page for setting sitelinks to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [15:19:20] DanielK_WMDE: fine by me :) [15:19:36] $this->getMwGlobals( 'wgHooks', array() ); :P [15:19:41] * set, ofc. [15:19:51] where? :P [15:20:00] addshore: We should do taht everywhere :P [15:20:07] that'S actually a sane thing to do in a test case [15:20:15] don't want extensions to mess with your data [15:20:22] in a unit tests that's fine... integration test not [15:20:22] hoo: indeed! [15:22:10] hmm, indeed DanielK_WMDE I seem to get this error whenever I run all the tests now ... [15:22:33] but I wasnt a few mins ago¬! [15:22:48] addshore: We had that in travis a lot today [15:23:11] * addshore digs a bit :) [15:25:11] addshore: try what happens if you manually add an entry for that wiki to your sites table. [15:25:42] i mean, tests shouldn't require that, but whether it being there makes a difference should tell us somethign abotu the problem [15:25:53] it will make a difference [15:25:53] I changed the interwiki link for typhus [[Q160649]] in trwiki to Tifüs several months ago, however [[en:Typhus]] still shows the Türkçe link as [[tr:Tifo]], which is Typhoid, a different condition. Is there something I need to purge things? [15:26:07] oh wait after I have been using composer I guess my wiki is bot client and repo by default? [15:26:23] addshore: Yep, unless you fix things [15:26:37] lfaraone: check the wikitext on trwiki. maybe the old sitelink is still there. [15:26:42] ahh, my wiki was never setup like that before :P so thats probably the reason :P [15:26:45] but still tests and the software should work in both conditions [15:26:51] lfaraone: sitelinks/langlinks defined locally override the ones from wikidata [15:27:03] addshore: yes. [15:27:03] addshore: look at Wikibase.composer.php in the root [15:27:24] DanielK_WMDE: [[tr:Tifo]]'s interwiki link in the sidebar is [[en:Typhoid Fever]], but let me check the source. [15:27:41] addshore: $wgEnableWikibaseClient = false; [15:27:45] [= [15:27:55] *before* including the extension [15:27:59] DanielK_WMDE: there is one interwiki link on trwiki, [[la:Typhus (morbus)]] , which I think is also wrong, but nothing else [15:28:20] ohhhh enwiki has the wrong one, I see [15:28:22] too [15:28:51] heh, still get the error :/ [15:29:00] (03CR) 10Tobias Gritschacher: [C: 032] Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 (owner: 10Henning Snater) [15:29:11] removed from enwiki and now the interwiki link on enwiki for trwiki is correct, thanks DanielK_WMDE [15:29:22] (03Merged) 10jenkins-bot: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 (owner: 10Henning Snater) [15:31:23] lfaraone: np [15:31:42] Tobi_WMDE: when you get time, can you document the WikidataJenkins account at https://wikitech.wikimedia.org/wiki/User:WikidataJenkins ? :-D [15:32:38] ... and that's how I started redoing all of Wikibase client's Scribunto integration :P [15:34:07] hashar: hey, you were faster.. :-P [15:34:16] something I should add still? [15:35:17] (03PS13) 10Addshore: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:37:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1538 (master - 40f7240 : jenkins-bot): The build was broken. [15:37:34] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/b66981d3046c...40f72409180a [15:37:34] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16729030 [15:37:35] hashar: just updated it a bit.. [15:37:58] (03CR) 10Addshore: [C: 04-1 V: 04-1] "Fatal error: Class 'Wikibase\Test\DerivativeContext' not found in" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:38:26] o_O [15:38:28] wtf? [15:38:42] hehe, dont worry ill upload a fix :P just re running the tests :P [15:38:57] but why didn't jenkins report that issue? [15:39:05] jenkins only runs lint now [15:39:06] (besides me also running tests?) [15:39:18] yes, now. for two days or so. [15:39:29] it accepted this patch long before that. [15:40:03] maybe it got lost in a rebase or something? [15:40:14] yea, possible [15:40:19] actually - quite likely [15:40:34] (03PS14) 10Addshore: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:40:59] (03CR) 10Addshore: [V: 032] Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:44:06] (03CR) 10Addshore: Remove DB use from tests for EntityData (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:44:28] (03PS15) 10Addshore: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:44:34] Tobi_WMDE: danke [15:44:41] :) [15:44:47] (03CR) 10Addshore: [V: 032] Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [15:44:53] * addshore leaves that PS alone now :P [15:48:33] doesnt anyone else have JsonDumpGeneratorTest::testSharding fail for them or is it just me? [15:50:02] it's just you :) [15:50:33] :/ [15:50:37] buy wehwhwhhwhwhhhyhhyhyyyyyyy [15:50:41] *but [15:53:26] it must be because of the sort() ... [16:02:28] also me [16:02:32] since a long time [16:03:02] addshore, Tobi_WMDE: uh... you are thwe only ones using windows, right? [16:03:10] yup [16:03:11] make Henning_WMDE try :) [16:03:19] Henning_WMDE: ^^^^^^ :D [16:03:21] guess it's the same [16:03:37] why would that be different on windows?? wtf? [16:03:38] I even wrote an email about that a long time ago [16:03:49] Tobi_WMDE: i know, but at least now we have a lead [16:03:51] haha :P [16:04:04] they have failed for Henning_WMDE for a long time too :P [16:04:17] addshore: if you find out why, you get gummy bears :) [16:04:20] or jummy beers [16:04:29] haha :P im digging into it now cause its annoying! [16:04:34] jimbo bears? [16:04:37] what are jummy bears? :P [16:05:02] addshore: jummy *beers* [16:05:09] :d [16:05:11] :d [16:05:22] :D (shift key fail) [16:05:26] haha! [16:05:53] i was trying to imagine what face that would be... trying to reach your nose with your tongue?... [16:12:25] DanielK_WMDE: sorry, i got distracted by cardboard boxes, but YES! :D [16:13:41] hey brion! [16:13:48] howdy [16:13:55] addshore: you are easily entertained, it seems :P [16:15:22] http://www.quickmeme.com/img/71/710501d9e6c06effb0a63b49fa966f118c89fe1a43ddae4ae7ba675ffaa6e2fd.jpg [16:41:06] Lydia_WMDE: At any chance... is Jens around? :P [16:41:17] hoo: nope :/ [16:41:29] We even now have code for b/c in the Wikibase Lua and I doubt that's really needed [16:41:56] it sucks that we don't have all Lua modules in some git repo where one can grep for stuff :( [16:52:29] * hoo wonders whether a function which returns a snak really be called getProperty [16:52:29] meh [16:52:43] + should [17:03:53] addshore: with https://gerrit.wikimedia.org/r/#/c/106565/, i did run the tests and verify with the syntax error fixed [17:04:21] no idea why it didn't make it into gerrit before... maybe because i edited the commit message [17:05:27] (03PS1) 10Addshore: Fix JsonDumperGeneratorTest on Windows [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106733 [17:05:47] (03CR) 10Aude: [V: 032] "i ran the tests on the branch with this patch (all good) and poked around manually" [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 (owner: 10Aude) [17:09:08] (03CR) 10Addshore: [C: 032 V: 032] Fix JsonDumperGeneratorTest on Windows [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106733 (owner: 10Addshore) [17:09:14] (03CR) 10Addshore: Fix JsonDumperGeneratorTest on Windows [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106733 (owner: 10Addshore) [17:10:10] fail mouse pointer [17:14:14] (03PS16) 10Addshore: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [17:16:34] (03CR) 10Addshore: [C: 032 V: 032] Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [17:16:55] (03Merged) 10jenkins-bot: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 (owner: 10Daniel Kinzler) [17:19:30] (03PS12) 10Addshore: (bug 56693) special page for setting sitelinks to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [17:21:48] addshore: rebase all the changes!!1 (??) [17:22:57] :D [17:33:07] (03PS13) 10Addshore: (bug 56693) SetSitelink specialpage allows setting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [17:33:59] (03CR) 10Addshore: "PS13 makes the feature experimental!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [17:35:23] (03CR) 10Hoo man: [C: 04-1] (bug 56693) SetSitelink specialpage allows setting badges (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [17:37:49] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1539 (master - bb43a94 : daniel): The build is still failing. [17:37:49] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/40f72409180a...bb43a942901c [17:37:49] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16736053 [17:37:54] Lydia_WMDE: aude hoo etc thanks for the christmas card! ;) (Just got it) [17:38:31] greg-g: heh ... I'm working remote (I actually got one myself) ;) [17:38:43] oops ;) [17:38:46] + so I didn't sign [17:38:59] I didn't look at all the signatures :) [17:39:10] (03CR) 10Addshore: (bug 56693) SetSitelink specialpage allows setting badges (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [17:39:50] (03PS14) 10Addshore: SetSitelink specialpage allows setting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [17:44:28] (03PS1) 10Addshore: DNM Take SpecialSetSiteLink badges out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 [17:44:39] (03CR) 10Addshore: [C: 04-2] DNM Take SpecialSetSiteLink badges out of experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [17:46:10] (03CR) 10Addshore: [C: 032] Make ResultBuilder's "indexed mode" work consistently. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 (owner: 10Aude) [17:46:16] yay! [17:46:30] (03Merged) 10jenkins-bot: Make ResultBuilder's "indexed mode" work consistently. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 (owner: 10Aude) [17:47:56] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106735 (owner: 10Addshore) [17:49:26] (03CR) 10Addshore: [C: 032 V: 032] Use test sites in ActionTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106683 (owner: 10Hoo man) [17:49:46] (03Merged) 10jenkins-bot: Use test sites in ActionTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106683 (owner: 10Hoo man) [17:51:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [17:54:57] (03PS2) 10Addshore: Create only one rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101202 (owner: 10Henning Snater) [18:00:53] (03CR) 10Addshore: [C: 032 V: 032] Create only one rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101202 (owner: 10Henning Snater) [18:01:39] (03Merged) 10jenkins-bot: Create only one rank selector menu [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101202 (owner: 10Henning Snater) [18:03:18] (03CR) 10Addshore: [C: 04-1] "needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100565 (owner: 10Daniel Kinzler) [18:18:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1540 (mw1.23-wmf6 - cadb236 : daniel): The build has errored. [18:18:47] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/05e18522593c...cadb236b51e1 [18:18:47] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16737827 [18:22:31] hello :) [18:22:59] Lydia_WMDE: so, how is it with badges? (just asking, not pushing you :) ) [18:23:40] greg-g: you're welcome :) [18:23:51] lazowik: adam just worked on it a bit more it seems? [18:24:00] so making progress [18:24:27] great [18:24:37] not following now, that's why I'm asking [18:24:41] yay for people thinking i am stupid in bug reports \o/ [18:24:46] lazowik: np :) [18:24:51] ? [18:25:09] lazowik: oh just some random person who is unable to explain things question my knowledge about wikidata [18:25:16] lol [18:25:20] because i asked for clarification [18:25:42] Lydia_WMDE: then you should go and educate yourself! [18:25:50] maybe ask project leader? [18:25:51] clearly [18:25:53] :p [18:25:54] :P [18:26:03] i will meet denny next week [18:26:07] i should get an intro [18:26:10] :D [18:26:15] nice [18:26:17] at last [18:26:49] jep :) [18:26:57] Lydia_WMDE: bug # if you don't mind? [18:27:08] lazowik: better not.. ;-) [18:27:24] I'm not going to comment :) [18:27:27] I promise [18:27:38] but, if not then not [18:28:04] * lazowik so much logic [18:28:25] anyway [18:28:31] gone again to take care of some other things [18:28:35] need to pack and stuff [18:29:07] good luck then [18:29:18] (with closing suitcase or whatever you take) [18:35:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1541 (master - 944532c : jenkins-bot): The build was fixed. [18:35:53] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/bb43a942901c...944532cedf99 [18:35:53] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16738077 [18:46:00] Hi all…should individual architectural styles be 'instance of' or 'subclass of' architectural style (Q32880)? From what I read on https://www.wikidata.org/wiki/Property_talk:P149 it suggests they should be 'instance of', but then http://tools.wmflabs.org/wikidata-todo/tree.html?q=32880&rp=279&method=list shows a lot of 'subclass of' too. [18:51:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1542 (master - de8c8e8 : Henning Snater): The build was fixed. [18:51:43] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/944532cedf99...de8c8e8e1488 [18:51:43] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16738824 [19:05:55] wow, the interface to enter begin date qualifiers is really nice :-) [19:07:18] Yeah it is. I think we need to steal that for Musicbrainz. ;-) [19:09:57] Within the direct context of Wikidata though, the only thing I would add is the ability to add qualifiers while adding the property. [19:09:59] er, statement. [20:28:07] (03CR) 10Addshore: [C: 032 V: 032] SetSitelink specialpage allows setting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [20:28:31] (03Merged) 10jenkins-bot: SetSitelink specialpage allows setting badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [20:32:46] [02wmde/DataValuesJavascript] 07none pushed 033 commits to 03master [+2/-0/±5] 13http://git.io/soB4PA [20:32:47] [02wmde/DataValuesJavascript] 07JeroenDeDauw 03392e74c - Remove global scope assumption [20:32:48] [02wmde/DataValuesJavascript] 07snaterlicious 0305f1a64 - Added .jshint file Applies some corresponding clean-up. [20:32:49] [02wmde/DataValuesJavascript] 07tobijat 035682e4b - Merge pull request #5 from wmde/jshintfile Added .jshint file [20:32:50] :> [20:35:27] I'm 12 and what is this? [20:35:33] JeroenDeDauw: I dont appear to be able to manage the hooks of wmde/ValueView or wmde/DataTypes [20:35:43] that was a test push to the hook for github [= [20:35:55] just fixed them for all the repos I have access to [20:36:29] addshore: repos added to group [20:36:56] hooks added for those 2 also :) [20:37:06] could also add it to DataValues/* ? [20:37:31] evening DanielK_WMDE :) [20:44:25] addshore: go ahead [20:44:32] addshore: please poke me when done [20:46:07] done, gonna go through them all and turn on the pull request notifications for the hooks too [20:46:36] addshore: so you still require access to DataValues? [20:46:48] yup :P [20:46:53] and this bit might take a bit more time [21:16:58] addshore: done? [21:17:05] nope :P [21:17:13] just found the doc telling me how to ;p [21:17:23] there is no UI ;p [21:18:08] will knock together a script to itterate over them all [21:43:10] addshore: i just thought of a possibel cause for the failing sharding test: sharing is done by taking the modulo of an sha1 hash. perhaps the code doesn't work on 32bit systems. [21:43:14] if you want to dig... [21:43:36] * sharding, not sharing. [23:02:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1544 (master - e6438e4 : Translation updater bot): The build was broken. [23:02:26] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3d0d03eee3bb...e6438e416a17 [23:02:26] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16753312 [23:39:30] 99.995.000 [23:43:37] dennyvrandecic: oO [23:46:21] less than 3k to go [23:47:13] while true; do sql wikidatawiki "SELECT rev_user_text, rev_id FROM revision ORDER BY rev_id DESC LIMIT 1;"; echo "";sleep 1; done [23:47:14] :P [23:48:58] dennyvrandecic: Dare to enable an AbuseFilter which filters all bots? :P [23:49:45] i do not :) [23:49:54] community said no [23:50:19] yeah :/ [23:51:28] we're going at a bout 5 edits/second [23:51:47] should start my bot again! [23:52:14] aude: noo.... let humans have a chance [23:52:18] hah [23:52:20] now is the best time :) [23:52:32] My bot's not running :P [23:53:22] 2k left [23:57:47] less than 1k [23:57:51] 99.999.000, 1k left [23:58:01] * aude not using a bot [23:58:45] so many things still missing descriptions