[04:26:57] (03PS6) 10Legoktm: Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [04:37:37] (03CR) 10jenkins-bot: [V: 04-1] Die if wbeditentity tries to clear from old revid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98795 (owner: 10Addshore) [08:44:27] https://www.wikidata.org/wiki/Wikidata_talk:Wikisource#Notability.2C_and_other_preparations_for_Wikisource_deployment [08:44:32] are we ready are we ready? [09:05:03] (03PS2) 10Henning Snater: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 [09:05:48] (03CR) 10jenkins-bot: [V: 04-1] Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 (owner: 10Henning Snater) [09:54:12] (03PS8) 10Jeroen De Dauw: Implemented "eachchange" event using the jQuery.event.special API [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93736 (owner: 10Henning Snater) [10:10:53] (03Abandoned) 10Jeroen De Dauw: Implemented "eachchange" event using the jQuery.event.special API [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93736 (owner: 10Henning Snater) [10:15:18] (03Abandoned) 10Jeroen De Dauw: Make focus-related test cases succeed in Firefox [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/105945 (owner: 10Adrian Lang) [10:15:51] (03PS3) 10Jeroen De Dauw: Added default parser test to ValueParserFactory QUnit tests [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102092 (owner: 10Henning Snater) [10:15:53] (03PS3) 10Jeroen De Dauw: ValueParser QUnit tests: Renamed getObject to getConstructor [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102091 (owner: 10Henning Snater) [10:22:52] (03Abandoned) 10Jeroen De Dauw: Added default parser test to ValueParserFactory QUnit tests [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102092 (owner: 10Henning Snater) [10:27:52] (03Abandoned) 10Jeroen De Dauw: ValueParser QUnit tests: Renamed getObject to getConstructor [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102091 (owner: 10Henning Snater) [10:31:17] (03PS3) 10Henning Snater: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 [10:31:54] (03CR) 10jenkins-bot: [V: 04-1] Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 (owner: 10Henning Snater) [11:32:53] (03CR) 10Daniel Kinzler: [C: 04-1] "Nice improvement, some design questions." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 (owner: 10Aude) [11:34:07] JeroenDeDauw: hey! So are you getting rid of extensions/Wikibase.git entirely ? [11:34:13] I am referring to https://gerrit.wikimedia.org/r/#/c/106497/1/layout.yaml,unified [12:03:14] hashar: we are not removing the git repo... [12:03:30] hashar: though the tests can now no longer be run on Jenkins [12:03:39] hashar: basically I want everything removed except the linting [12:04:29] hashar: would be cool if this could get done today. ATM we have Jenkins -2ing everything [12:07:32] i will never understand it [12:08:17] understand what? [12:09:15] anyway, how are you testing changes now ? [12:11:09] hashar: by running the tests [12:11:19] also, we have all of the stuff run on travisci [12:11:32] still good if we could have the tests run on Jenkins [12:11:41] and do you have any clue why they suddenly started failing entirely ? [12:11:58] is that some dependency that got altered ? [12:12:12] hashar: I'm told that we cannot execute "composer install" for our build on Jenkins because nothing from outside WMF cluster can be fetched - is that correct? [12:12:24] hashar: yes, dependency change [12:12:31] hashar: we will write a mail about this soon [12:18:55] JeroenDeDauw: yup we can't really use composer on the servers running jenkins [12:19:08] JeroenDeDauw: that would be possible when one day we got slaves running in an isolated env [12:22:59] just merging the zuul part [12:23:05] then I am going to sleep [12:24:50] Zuul no more triggers the jobs [12:26:37] off to sleep sorry [12:34:13] this needs to be #over9000 https://packagist.org/packages/wikibase/data-model [12:48:38] (03PS4) 10Henning Snater: Always display "In other languages" section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106257 [13:06:22] (03PS1) 10Tobias Gritschacher: (DNM) just testing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106508 [13:08:52] Lydia_WMDE: we also have https://packagist.org/users/wmde/ [13:09:27] (03PS2) 10Tobias Gritschacher: (DNM) just testing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106508 [13:10:35] addshore: ping [13:10:54] addshore: do you remember how to make jenkins not +2 when it is only running lint? [13:18:20] Lydia_WMDE: see how your VE edits actually failed after all: https://www.mediawiki.org/w/index.php?title=Wikibase&action=edit§ion=3 [13:18:52] (03PS3) 10Tobias Gritschacher: (DNM) just testing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/106508 [13:18:56] JeroenDeDauw: pffft :P [13:22:30] oh god, now I need to create a wikitext table o_O [13:24:24] Lydia_WMDE: I cannot embed external images on MediaWiki.org right? [13:25:36] I can't do html tables in wikitext? pfft, lame software [13:26:47] JeroenDeDauw: visualeditor ftw :P [13:27:47] Lydia_WMDE: oh, it supports tables? [13:27:54] I don't see a table button... [13:28:33] JeroenDeDauw: might be that it still only allows you to edit existing tables [13:35:14] Lydia_WMDE: how about https://www.mediawiki.org/wiki/Wikibase/Components [13:35:16] ? [13:35:21] looking [13:35:59] JeroenDeDauw: looks good, yes :) [13:36:33] JeroenDeDauw: later we can have christopher add links to bug reports also for example [13:36:41] but you don't need to do this right now [13:41:57] Lydia_WMDE: aude: Do we ahve a bug tracking secondary storage (wb_items_per_site) consistency issues on Wikidata? [13:42:19] hoo: hmmmm probably [13:43:03] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=42325 maybe? [13:43:41] Lydia_WMDE: mh... I rather mean old items with inconsistency floating around [13:43:50] hmmm [13:43:52] then i don't know [13:43:54] ie. clean up the past mess [13:46:09] as you may (or may not) know, my bot does Wikidata clean up based on Database comparisons from labs... and in that process I stumbled upon thousands of items where wb_items_per_site is inconsistent/ empty [13:46:09] and we don't have even have a maintenance script to handle these :/ [13:48:54] (03PS10) 10Daniel Kinzler: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 [13:49:24] (03PS8) 10Daniel Kinzler: (bug 57231) Use ResultBuilder for EntityData. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101855 [13:49:35] (03PS11) 10Daniel Kinzler: Remove DB use from tests for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101453 [13:54:27] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Jeroen De Dauw link https://www.mediawiki.org/w/index.php?diff=880741 edit summary: [-154] /* Requirements */ [13:54:41] Lydia_WMDE: I got 32239 items which are highly likely to be inconsistent [13:55:34] hoo: hhhhmmmm ok - maybe DanielK_WMDE can say something about that [14:00:51] hoo: we do have a maintenance script for rebuilding this table [14:01:02] in fact, aude just rewote it [14:01:08] (patch pending review) [14:02:27] DanielK_WMDE: Hi! If you have time could you review again https://gerrit.wikimedia.org/r/#/c/97835/8 , please? [14:02:32] DanielK_WMDE: Ok... and what about items which have sitelinks other items already hold? [14:11:17] DanielK_WMDE: http://tools.wmflabs.org/hoo/inconsistentItems [14:11:17] These have 0 site links according to wb_items_per_site [14:11:40] but all of them probably have one, if they hadn't I'd already have them deleted [14:19:38] hoo: oh, wait, sorry - the script katie rewrote was for entity_per_page, not items_per_site [14:20:00] but there's a script for that too, i'm pretty sure. [14:20:17] anyway - these inconsistencies can't be completely avoided, but should be rather rare [14:20:30] can you find out whether there are recent edits that introduced such an inconsistency? [14:21:08] (essentially, this happens if the request dies unexpectedly before recording links to the database, but after saving the primary data blob) [14:21:36] if you have a good idea how to avoid this, let me know :) [14:22:02] :/ [14:22:02] I couldn't find one yesterday [14:22:02] these are mostly old pages, last edited in the first half of 2013 [14:23:03] DanielK_WMDE: Trying the query with edit in the last months now... doubt we will find much [14:23:45] but this is probably only a rather smal subset, as I can only use bad metrics to find these and have to have my Python bot go through all of them to check wether the JSON has sitelinks (via wbgetentities API) [14:24:27] hoo: i can't see any other way either. [14:27:43] DanielK_WMDE: Good news... looks like this isn't a problem in the recent months anymore [14:27:52] but still we have these items with inconsistencies around and should get them fixed [14:31:50] DanielK_WMDE: If I spent a few hours on that, I guess I could also touch them using python... if you trick the API it does a storage rebuild without actually changing anything (eg. pass title which normalizes back the old one) [14:39:21] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Jeroen De Dauw link https://www.mediawiki.org/w/index.php?diff=880812 edit summary: [-285] /* Download */ [14:39:48] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Jeroen De Dauw link https://www.mediawiki.org/w/index.php?diff=880813 edit summary: [-349] /* Installation */ [14:39:57] SO much cruft in the install docs... [14:56:13] Lydia_WMDE: so whats the plane for making the WB page more fluffy? [14:56:22] Add a http://cornify.com/ button ? [14:56:27] no! [14:57:31] JeroenDeDauw: Sounds like a cool gadget :P /me hides [14:57:55] hoo: http://www.mediawikiwidgets.org/Cornify [14:59:16] JeroenDeDauw: The insanity level over 9000: https://de.wikipedia.org/wiki/Benutzer:Hoo_man/insane.js [14:59:34] DanielK_WMDE: Thanks a lot :-) [14:59:48] - The [14:59:56] hoo: huh [15:01:18] hoo: ok, I approve of this [15:01:20] JeroenDeDauw: Did that with/for a Wikipedian :P You have to click "Go insane!" in the p-tb :P [15:01:22] \o/ [15:02:04] hoo: lets put this in the WB JS and have it activated with chance 1/10k every minute [15:02:47] * hoo orders popcorn for the bug reports :D [15:06:24] Henning_WMDE: if you want an example of a pull request with multiple commits and comments... https://github.com/php-fig/fig-standards/pull/244 [15:06:33] That one has a lot of comments o_O [15:13:30] Tpt: \o/ [15:26:04] (03PS4) 10Daniel Kinzler: (bug 56711) use prefixed IDs in wb_terms table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 [15:47:03] Lydia_WMDE: ok, i rememebr the problem with the entity_id change for the terms table: it makes several apparently unrelated tests fail, and i don't know why :) [15:47:11] digging, digging... [15:47:19] heh [15:47:26] don't digg yourself in too depp! [15:47:31] *deep even [15:48:39] i think "depp" is quite appropriate [15:49:43] Thinking about the unit tests: yep :P [15:51:47] I will be calling it a day soon - any questions regarding the component changes? [16:02:59] hoo: you were looking for me a few days ago? :P [16:03:25] legoktm: Yeah... about mass deletion of empty items... [16:03:28] already doing these [16:03:41] and many items turned out to be not really empty (see above) [16:03:45] as long as you don't overtake me in deletion stats! [16:04:18] hmmm [16:04:21] legoktm: mh... I'm still about 50k short or so [16:04:38] hoo: have you seen https://bugzilla.wikimedia.org/show_bug.cgi?id=48112 ? [16:05:02] ewk [16:05:05] Lydia_WMDE: the patch was trying to do address 56711 (wb_terms) and 56712 (wb_entity_per_page) at the same time. bad mistake. reduced it to wb_terms, leaving wb_entity_per_page for later. Seems good so far, waiting for tests. [16:05:09] that's the same issue other way round [16:05:24] DanielK_WMDE: cool :) [16:05:33] one thing at a time... [16:06:08] ha [16:06:14] DanielK_WMDE: ^ [16:06:25] legoktm: We don't have a maintenance script for this (yet), but I guess we start to need one [16:06:25] * hoo eyes Lydia_WMDE [16:06:49] i think we at least had a bug open for this once [16:06:54] hoo: if not, file one :) [16:07:13] yes please [16:07:33] and then we still need the community to help sort out duplicates and other messes [16:07:33] * hoo = lazy [16:07:33] ok ;) [16:07:35] (03PS5) 10Daniel Kinzler: (bug 56711) use prefixed IDs in wb_terms table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101197 [16:07:38] there we go [16:11:31] DanielK_WMDE: Lydia_WMDE: legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=59870 [16:12:22] * legoktm cc's [16:13:25] hoo: thx! [16:14:43] ;) [16:35:45] * aude would like https://gerrit.wikimedia.org/r/#/c/106528/ reviewed [16:37:10] damn, DanielK_WMDE bet me [16:37:19] :/ [16:37:29] then we can see it on our new test system [16:38:09] new test system? [16:38:28] I'm a slowpoke, I guess :P [16:38:42] not 100% ready but is fully puppetized [16:38:54] the old puppet stuff is broken and needs updating [16:39:17] hoo: jenkins/zuul got an update and got a lot faster. otoh, jenkins isn't really doing anything for wikibase at the moment, needs fixing for the composer based install- [16:39:30] oh, and the new test vm stuff, yea :) [16:39:34] where is it? [16:39:53] one sec [16:40:02] i don't have all the extnesions fully working yet [16:40:20] like no central auth yet, although that one is easy [16:43:03] aude: Is it on labs? [16:43:15] http://wikidata-dev-repo.wmflabs.org/wiki/Q2 [16:43:20] yes [16:43:27] * aude needs opinions [16:43:47] in that link, we list wikipedia, then wikivoyage then wikisource then commons [16:44:03] is that good or a different order preferred? [16:44:05] Lydia_WMDE: ^ [16:44:11] DanielK_WMDE: [16:46:17] aude: Wikisource has way more page views, more language versions and probably more pages, so I'd put it first [16:46:17] but it doesn't really matter much, I guess [16:46:52] one could eg. expect an alphabetical sorting (Wikipedia first althoug) [16:46:54] talking to lydia, we can do wikipedia (due to importance and also alphabetical order), then everything else alphabetical [16:47:08] then commons (which will be grouped with other miscellanous things at some point) [16:47:20] +1 [16:47:37] * aude does not want to judge other projects on importance [16:48:19] yeah, alphabetical order is probably the best [16:50:52] i'd just ask on project chat. don't care personally [16:51:12] if they don't like it then can be discussed [16:51:26] shoot first, ask later? [16:51:30] Yep [16:55:32] Lydia_WMDE: 5 minutes? [16:55:39] DanielK_WMDE: jep [16:55:39] to the call, i mean [16:58:43] Lydia_WMDE: there's no agenda yet, right? [16:58:52] i think so [16:59:03] well, if you didn't send one - i didn't :) [16:59:08] hehe [16:59:14] can you bring your laptop? [16:59:34] hmkay [17:00:26] :) [17:02:58] we can't hear you, Lydia_WMDE [17:45:52] Is echo broken/ known to be broken? [17:46:39] hoo: ? ask legoktm [17:46:47] it's broken? [17:47:00] legoktm: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Abuse_filer_for_merge_items this didn't ping me [17:47:17] it's the _ [17:47:28] oh [17:47:30] not even [17:47:30] https://www.wikidata.org/w/index.php?title=Wikidata%3AContact_the_development_team&diff=99665202&oldid=99532574 [17:47:37] there was no signature added in that edit [17:48:31] legoktm: mh... so the problem is that addshor.e didn't add a signature? [17:48:37] yeah [17:48:44] also I think the _ would have broken it too [17:48:57] that's like a triple fail :P [19:24:47] Hi all…should individual architectural styles be 'instance of' or 'subclass of' architectural style (Q32880)? From what I read on https://www.wikidata.org/wiki/Property_talk:P149 it suggests they should be 'instance of', but then http://tools.wmflabs.org/wikidata-todo/tree.html?q=32880&rp=279&method=list shows a lot of 'subclass of' too. [19:59:57] (03PS1) 10Aude: Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106564 [19:59:58] (03PS1) 10Aude: Make ResultBuilder's "indexed mode" work consistently. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 [20:00:54] (03CR) 10Aude: "want to get addshore and/or Daniel to review" [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106564 (owner: 10Aude) [20:02:02] (03PS2) 10Aude: Make ResultBuilder's "indexed mode" work consistently. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 [20:12:10] Lydia_WMDE: https://test.wikidata.org/wiki/Q22 has wikisource [20:12:29] aude: \o/ [20:12:30] thanks [20:12:34] will post something in a bit [20:12:38] ok [20:12:59] translators are usually great but help with translating the new message would be nice [20:14:14] aude: It's not even on TWN yet probably [20:14:47] forget that [20:14:50] it is [20:17:59] when did the messages get into GIT ? [20:18:13] typically messages are imported once even twice a day [20:18:21] this afternoon [20:18:33] it's in TWN yet [20:18:43] https://translatewiki.net/wiki/MediaWiki:Wikibase-sitelinks-wikisource << open for translation [20:19:10] (03CR) 10Aude: [V: 032] "ran tests and poked around manually on the branch" [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/106565 (owner: 10Aude) [20:19:31] i'll have daniel look at that and approve [20:19:56] will make exception log a bit quieter [20:30:57] https://translatewiki.net/w/i.php?title=MediaWiki:Wikibase-sitelinks-wikisource/en&oldid=5260588 [20:31:11] it is there [20:31:27] GerardM-: I know... "(09:14:46 PM) hoo: forget that" [20:31:32] :P [20:31:41] So... get it translated :P [20:59:17] hm wikisource