[10:02:48] (03PS2) 10Henning Snater: Display references in static HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105910 [10:04:33] Lydia_WMDE: Ist Jens heute da? ;) [10:06:05] hoo: noch nicht [10:06:13] mh, ok [10:36:32] (03PS1) 10Adrian Lang: Remove reference to removed UnserializerBaseTest class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105930 [10:39:38] (03CR) 10jenkins-bot: [V: 04-1] Remove reference to removed UnserializerBaseTest class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105930 (owner: 10Adrian Lang) [10:50:31] (03CR) 10Hoo man: [C: 032 V: 032] "(Test failures are unrelated because Jenkins is going crazy atm)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105930 (owner: 10Adrian Lang) [10:53:32] (03CR) 10Aude: [C: 032] Make ResultBuilder's "indexed mode" work consistently. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102466 (owner: 10Daniel Kinzler) [10:59:37] (03CR) 10Aude: [C: 04-1] "some weirdness in patchset 6" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101851 (owner: 10Daniel Kinzler) [11:00:39] (03Merged) 10jenkins-bot: Make ResultBuilder's "indexed mode" work consistently. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102466 (owner: 10Daniel Kinzler) [11:01:32] aude: Do you know how to set up jenkins job stuff for Capiunto or do I need to poke hasha.r? [11:01:39] we can do it [11:01:48] \o/ [11:01:52] * aude looks [11:01:59] It needs Scribunto to work [11:02:06] (03CR) 10Daniel Kinzler: "@aude: eek, looks like merge artifacts from the rebase. wow, ugly :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101851 (owner: 10Daniel Kinzler) [11:02:16] we have scribunto for wikibase client [11:03:02] Yeah... not exactly sure where that dependency is defined [11:04:44] the two places are https://git.wikimedia.org/summary/?r=integration/jenkins-job-builder-config.git [11:04:52] and [11:05:09] https://git.wikimedia.org/summary/integration%2Fzuul-config.git [11:08:17] mh [11:08:42] similar to how TranslateNotifications and such are setup with dependencies [11:10:26] I see https://git.wikimedia.org/blob/integration%2Fjenkins-job-builder-config.git/a4b45b2a3f1c5a1ad26510dc22a42b4788e86b57/mediawiki-extensions.yaml [11:10:38] line 496+ [11:11:06] yeah that's where i am putting it [11:11:10] * aude not 100% sure [11:11:25] then needs to be put in zuul [11:11:32] https://gerrit.wikimedia.org/r/#/c/105934/ [11:12:52] aude: Are you also doing zuul layout or shall I? [11:12:58] * hoo already has it open in vim [11:13:03] go ahead [11:17:42] aude: https://gerrit.wikimedia.org/r/105935 [11:18:57] looks good to me [11:19:17] now needs poking hash.ar :) [11:19:32] :) [11:21:35] aude: pong [11:21:40] ah men [11:21:45] i should have registered hash.ar [11:21:56] heh [11:22:15] heh [11:22:26] ah no it only allow third-level domains apparently :( [11:27:01] (03PS1) 10Adrian Lang: Remove reference to removed class ClaimSaver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105936 [11:27:33] (03PS1) 10Adrian Lang: Remove reference to removed PropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105937 [11:27:56] (03CR) 10Hoo man: [C: 032] Remove reference to removed class ClaimSaver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105936 (owner: 10Adrian Lang) [11:28:36] (03CR) 10Hoo man: [C: 032] Remove reference to removed PropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105937 (owner: 10Adrian Lang) [11:28:59] * hoo likes small atomic changes [11:29:04] :) [11:29:21] * Adrian_WMDE does small atomic changes [11:30:16] just gave Adrian_WMDE +2 rights, btw [11:30:57] You sure I should have them considering I don't have a clue what they are? ;) [11:32:00] Adrian_WMDE: :D Gives you the right to approve changes... don't do it if you don't know what it does, yet [11:32:03] big plus, as you are in the Wikidata group now, you will see changes the whole team should see (one can add groups as reviewers) [11:32:15] ah, cool [11:34:41] (03Merged) 10jenkins-bot: Remove reference to removed class ClaimSaver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105936 (owner: 10Adrian Lang) [11:39:35] (03Merged) 10jenkins-bot: Remove reference to removed PropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105937 (owner: 10Adrian Lang) [11:40:46] many of the years of the Solar Hijira calendar have now proper qualifiers ... it is the first time (afaik) that qualifiers have been added by a bot [11:40:57] I blogged about another aspect of it ... http://ultimategerardm.blogspot.nl/2014/01/wikidata-tir-1386-is-month.html [11:41:13] we cannot deal with the precision of other calendars [11:41:22] my question ... is there a bug for this ? [11:41:37] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1518 (master - 790d680 : jenkins-bot): The build was broken. [11:41:37] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/76275e7d62cf...790d6803494c [11:41:37] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16520104 [11:41:42] Lydia_WMDE: Jens immer noch nicht da? :/ [11:42:23] hoo: Nope [11:42:27] :/ [11:42:42] Dann schreib ich ihm nachher eine Email [11:43:02] You people should learn Lua :P [11:56:05] Adrian_WMDE: can you link your github account? [11:56:14] github.com/adrianlang [11:57:48] Adrian_WMDE: whats that symbol again? [11:58:31] JeroenDeDauw: Symbol? [11:59:18] Adrian_WMDE: avatar [11:59:23] Ah [11:59:37] It's an icon used by the CCC [12:01:19] Adrian_WMDE: what exactly is it about? it is not the ccc logo ... [12:01:35] They used it for a congress, I think 18C3 [12:02:02] Yeah: https://events.ccc.de/congress/2001/ [12:02:44] I regularly see this one in the hacker scene... [12:02:59] Adrian_WMDE: where you at the 30c3? [12:03:04] http://katjusha.spreadshirt.de/ [12:03:09] No, I wasn't [12:04:24] Haven't been there for 2 or 3 years [12:17:45] (03PS2) 10Hoo man: New Lua interface to create infoboxes [WIP] [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 [12:19:33] (03CR) 10Hoo man: "Made it possible to inject arbitrary wikitext." [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [12:24:26] (03PS2) 10Henning Snater: Make use of valueFormatterFactory in $.valueview [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102421 [12:24:36] (03PS3) 10Henning Snater: Use formatted value in QuantityType expert [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102422 [12:24:44] Adrian_WMDE: I guess Jens still isn't around? [12:25:01] hoo: He is and I told him he has been missed here [12:27:11] oh great :) [12:27:22] Send him to IRC then :) [12:35:05] wo ist jens? :) [12:35:18] Gute Frage, aude [12:36:05] aude: hoo: Limit of IRC connections from this IP reached. He'll take care of you :P [12:36:35] :P You people have to contact freenode to get a conference thingy :P [12:40:04] (03PS7) 10Daniel Kinzler: Use EntityRevision for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101851 [12:40:42] (03PS8) 10Daniel Kinzler: Use EntityRevision for EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101851 [12:40:54] * aude asking [12:41:06] hoo, aude: only works with a fixed ip [12:41:11] which we don't have, afaik [12:41:15] DanielK_WMDE_: You don't have a static IP?! [12:41:30] hoo: nope. what for? [12:41:41] Well... for these kind of things? :P [12:41:46] ick [12:41:56] then use a proxy :) [12:42:08] hey, we ran out of ipv4 addresses, remember?--- [12:42:20] * aude using same ip address for years [12:42:52] aude: And it's still fresh? [12:42:58] yes [12:44:30] VPNs and vservers with a static IP are cheap today... [12:44:39] I'd be surprised if Jens didn't have one [12:45:23] quassel ftw [12:45:25] :P [12:45:32] irccloud! :) [12:45:43] irssi! [12:46:08] Yay for irssi (although I don't think it's still maintained... I had to patch it myself :P) [12:46:22] it works perfectly [12:46:24] and I'd never give my IRC stuff away to a third party... self hosted [12:46:50] https://gist.github.com/mariushoch/6093199 [12:46:54] aude: ^ :P [12:47:26] ooh [12:48:38] I set it up according to some manual some time back and I added a passphrase... wasn't much of a intuitive thing :P [12:48:53] especially because I had to patch it... [12:49:09] well it's totally customizable :) [12:50:09] That's true, but getting it right takes some time [12:52:34] oh wow, irccloud has starting embeding content from links within chat xD [12:52:59] * Lydia_WMDE membles "quassel can do that for ages already" :P [12:53:04] *mumbles even [12:53:14] http://grab.by/tkpm [12:53:28] Lydia_WMDE: how hosts the remote part of quassel? [12:53:32] * who [12:54:00] hoo: in my case a good friend of mine [12:54:04] addshore: Wow, impressive (but could get annoying) [12:55:10] I'm trying to run the QUnit tests in Iceweasel (Firefox) and I get several errors regarding the fact that Firefox does not allow setting focus on an element which is not visible. [12:55:22] Adrian_WMDE: That's very much known [12:55:34] That's also why the tests don't pass on jenkins [12:56:20] (jenkins uses phatom-js AFAIR) [12:56:23] hoo: Thought so. I think we should fix it, but I'm wondering how: a) Accept the exception has a valid behaviour b) Always throw an exception ourself even in browsers which would happily perform the focus() [12:56:35] I think b) would be much more consistent [12:58:15] mh [12:58:48] There are also cases where »c) make sure the element is visible« is an option [12:58:56] (03CR) 10Daniel Kinzler: [C: 04-1] "Getting close. Some design question, one style issue." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [13:00:04] damn tabs! [13:00:18] heh [13:01:20] Adrian_WMDE: Haven't looked at these tests for a while... might it be possible to detect whether we can use the focus stuff and if not skip the relevant test [13:01:29] Going to get hacky, though [13:01:47] like create something very simple and try to focus it [13:01:56] (03CR) 10Aude: Store EntityView js config in parser output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [13:02:11] (03CR) 10Aude: [C: 04-1] "tabs" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [13:02:17] hoo: I think that's close to a) [13:03:02] A bit yes.. [13:03:39] I'm just wondering how useful a test is if it does not actually assert a certain behaviour [13:04:13] I mean, we would just be saying »In case it works, it actually works. Might as well not work, though« [13:04:24] Well, we do that in PHP a lot... if focus stuff just doesn't work, we can't test it... like you can't test certain stuff with MySQL in unit tests because mysql's temp. can't be joined [13:04:59] Hi Raymond__ :) [13:05:05] not really... the feature detection is something basic -> ie. does the browser/ whatever support [13:05:22] the following test is: Is our code doing the right thing [13:06:04] Of course it's not perfect, but I guess it's better than having it fail [13:06:41] hi abra [13:06:47] hi Adrian_WMDE [13:07:02] hoo: I'm preparing a patch [13:07:34] :) [13:08:30] (03PS5) 10Daniel Kinzler: (bug 58422) omit TOC with less than 3 sections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101433 [13:09:38] Lydia_WMDE: Hat Jens vllt. XMPP/Jabber oder sowas? [13:11:49] hoo: nicht sicher und er ist gerade nicht am platz [13:12:36] mh... [13:13:45] hoo: will try to grab him when he comes back [13:13:50] :) [13:14:23] (03CR) 10Hoo man: [C: 031] "Didn't test" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101433 (owner: 10Daniel Kinzler) [13:15:58] (03PS1) 10Adrian Lang: Make focus-related test cases succeed in Firefox [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/105945 [13:17:37] Warning: PhantomJS timed out, possibly due to a missing QUnit start() call. Use --force to continue. [13:17:41] Adrian_WMDE: ^ [13:17:48] humpf [13:19:14] oh and we use spaces in function calls like this( 'foo' ) [13:19:26] in both JS and PHP [13:19:38] (03CR) 10Daniel Kinzler: [C: 04-1] "I'll update the patch following springle's suggestions." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [13:19:44] Lydia_WMDE: --^ [13:20:22] mh... I have an interface like box:addRow( nil, 'data' ) [13:20:46] * hoo wonders whether he should switch the first (non mandatory) with the second (mandatory) param [13:21:20] hoo: no, please don't. also, if the first param is nill, it should generate an empty cell, i think. [13:21:26] i.e. nil should behave like '' [13:21:33] DanielK_WMDE_: Yep, it does do that [13:21:44] I just wrote a unit test for that behaviour [13:21:51] just wondered whether it is nice [13:22:18] there could also be addRow() that would insert a cell spanning all columns. hm, maybe the name isn't good for that, that's not an html table row... [13:23:36] mh [13:23:55] Also it now works with injected html... I've been able to inject a sub-infobox easily [13:24:00] and it produces fine html [13:27:42] nice [13:27:53] though sub-infoboxes should span all columns, right? [13:28:25] DanielK_WMDE_: They do... I've introduced a new :addWikitext which can be used to inject whatever html one wants [13:28:37] Eg. you could also use the old infobox template with that [13:28:57] it also have the availability to serve as a child [13:29:33] ah, nice! [13:42:29] (03PS1) 10Adrian Lang: Fix coding style in previous commit [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/105949 [13:43:36] Uhm, I guess I misunderstood git review [13:43:44] uh? [13:44:14] I hoped the above commit would make a new patchset for my previous change [13:45:48] oh, that's not a git review thing, but a git thin [13:45:48] g [13:45:55] you have to --amend changes [13:46:20] hoo: Ah, I asked Henning_WMDE and he said I should put it in a new commit [13:46:29] Anyway, I can squash them [13:46:38] yeah [13:47:14] (03PS2) 10Adrian Lang: Make focus-related test cases succeed in Firefox [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/105945 [13:49:55] (03Abandoned) 10Adrian Lang: Fix coding style in previous commit [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/105949 (owner: 10Adrian Lang) [13:50:39] Gerrit's nice [13:51:33] :) [13:57:13] DanielK_WMDE_: Still around? [13:59:26] hoo: Planning meeting [13:59:51] Ok, thought so [14:17:31] (03PS3) 10Hoo man: New Lua interface to create infoboxes [WIP] [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 [14:17:34] (03CR) 10jenkins-bot: [V: 04-1] New Lua interface to create infoboxes [WIP] [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 (owner: 10Hoo man) [14:18:27] ewk [14:20:09] (03PS4) 10Hoo man: New Lua interface to create infoboxes [WIP] [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/105157 [14:21:49] :) [14:21:54] hashar: passed now [14:22:01] hoo: you still have some strict standard issues though https://integration.wikimedia.org/ci/job/mwext-Capiunto-testextensions-master/2/console [14:22:07] not sure why jenkins doesn't die on them though [14:23:19] mh... these are in tests files [14:23:32] ohh [14:23:55] hashar: I just want to remove a default test which Scribunto adds and only run my custom ones [14:24:18] cause you are using a hook that change Scribunto behavior ? [14:25:03] No, I use its test classes for my Lua unit tests... but I also found it nice for some higher level integration testing [14:27:36] hashar: In a nutshell, I use various test classes for testing a single piece of code... so I only want to run Scribunto's generic "testLua" once [14:27:51] that's why I overwrote it with an empty function everyhwere... meh [14:42:08] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/102496/ [14:42:37] JeroenDeDauw: look at SqlStore to see where I stopped working on it. [14:42:53] it defines the different levels of lookup caching [14:43:06] also grep for FIXME in the diff, there are a few :) [14:44:27] DanielK_WMDE_: not now - will do so when I am working on WD again [14:44:40] sure [15:18:43] (03CR) 10Tobias Gritschacher: [C: 032] Display qualifiers in non-JavaScript UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102643 (owner: 10Henning Snater) [15:18:51] (03CR) 10Tobias Gritschacher: [C: 032] Display references in static HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105910 (owner: 10Henning Snater) [15:30:21] (03Merged) 10jenkins-bot: Display qualifiers in non-JavaScript UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102643 (owner: 10Henning Snater) [15:30:23] (03Merged) 10jenkins-bot: Display references in static HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/105910 (owner: 10Henning Snater) [15:50:06] (03PS7) 10Henning Snater: Implemented basic front-end value formatters [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/101876 [16:00:13] (03CR) 10Tobias Gritschacher: [C: 032] Implemented basic front-end value formatters [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/101876 (owner: 10Henning Snater) [16:01:05] (03Merged) 10jenkins-bot: Implemented basic front-end value formatters [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/101876 (owner: 10Henning Snater) [16:01:49] (03CR) 10Tobias Gritschacher: [C: 032] Implemented ApiBasedValueFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102404 (owner: 10Henning Snater) [16:02:00] (03PS15) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [16:06:56] (03Merged) 10jenkins-bot: Implemented ApiBasedValueFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102404 (owner: 10Henning Snater) [16:08:40] (03PS16) 10Aude: Store EntityView js config in parser output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 [16:08:47] (03PS3) 10Tobias Gritschacher: Implemented front-end ValueFormatterFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102089 (owner: 10Henning Snater) [16:08:55] (03PS3) 10Tobias Gritschacher: Make use of valueFormatterFactory in $.valueview [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102421 (owner: 10Henning Snater) [16:09:00] (03PS4) 10Tobias Gritschacher: Use formatted value in QuantityType expert [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102422 (owner: 10Henning Snater) [16:12:10] DanielK_WMDE_: johl: https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#Html_library [16:14:16] hoo: yay! [16:15:04] :) [16:16:00] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1521 (master - 53fef53 : jenkins-bot): The build was broken. [16:16:00] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c3b6ff4fb4eb...53fef538cf13 [16:16:00] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16533178 [16:19:05] hoo: i can see how to make child tags, but how to you make sibling tags? e.g. a sequence of

tags? [16:19:30] :done:tag? [16:19:41] you mean like

a

b

? [16:19:46] yea [16:23:37] DanielK_WMDE_: [16:23:38] mw.html.create( '' ) [16:23:38] :tag( 'p' ):wikitext( 'a'):done() [16:23:38] :tag( 'p'):wikitext( 'b' ):done() [16:24:41] That's what you need to do, when you don't want a wrapping [16:25:12] (03CR) 10Tobias Gritschacher: [C: 032] Implemented front-end ValueFormatterFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102089 (owner: 10Henning Snater) [16:25:50] see yall for now :) [16:25:55] (03Merged) 10jenkins-bot: Implemented front-end ValueFormatterFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102089 (owner: 10Henning Snater) [16:26:23] cu addshore [16:38:47] * hoo would really like to use https://gerrit.wikimedia.org/r/98853 in his integration tests [16:39:57] hoo: keep poking hashar, he said he'd review it today. [16:40:21] but i think zuul's git repo got corrupted or something, and that kept him busy [16:40:49] He helped with Capiunto earlier, so I guess that's resolved [16:41:08] what is the problem? [16:41:43] no problem, just wanting a nice way to assert valid HTML in tests [16:41:48] aude: It's not merged... if I push to gerrit now, jenkins will vote me down, cause assertValidHtmlSnippet is not yet there (on master) ;) [16:41:49] oh, yes [16:42:09] (03CR) 10Tobias Gritschacher: [C: 032] Implemented front-end QuantityFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102406 (owner: 10Henning Snater) [16:46:52] (03Merged) 10jenkins-bot: Implemented front-end QuantityFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102406 (owner: 10Henning Snater) [16:47:26] (03PS6) 10Daniel Kinzler: (bug 47135) Make row IDs use BIGINT. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99637 [16:47:26] (03PS8) 10Daniel Kinzler: (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 [16:48:19] "Failed asserting that false is true." phpunit's assertag isn't giving *this* useful error output [16:51:54] (03CR) 10jenkins-bot: [V: 04-1] (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 (owner: 10Daniel Kinzler) [16:52:16] (03CR) 10Tobias Gritschacher: [C: 032] Make use of valueFormatterFactory in $.valueview [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102421 (owner: 10Henning Snater) [16:52:25] (03CR) 10Tobias Gritschacher: [C: 032] Use formatted value in QuantityType expert [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102422 (owner: 10Henning Snater) [16:52:58] (03Merged) 10jenkins-bot: Make use of valueFormatterFactory in $.valueview [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102421 (owner: 10Henning Snater) [16:53:36] (03Merged) 10jenkins-bot: Use formatted value in QuantityType expert [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/102422 (owner: 10Henning Snater) [16:56:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1522 (master - 5fcf49c : jenkins-bot): The build was fixed. [16:56:56] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/53fef538cf13...5fcf49c5b316 [16:56:57] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/16535843 [17:00:13] hashar: can you help me debug this failure? https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/6624/console [17:00:31] that index should be there - it has been there for a long time now... [17:01:00] (also, earlier versions of this patch also tried to dropü it, and passed) [17:38:05] (03PS9) 10Daniel Kinzler: (bug 45529) use composite indexes on wb_terms. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99660 [17:56:08] (03CR) 10Daniel Kinzler: Store EntityView js config in parser output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [18:04:01] (03CR) 10Daniel Kinzler: Store EntityView js config in parser output (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [18:04:13] (03CR) 10Daniel Kinzler: [C: 04-1] "see comments on PS 15" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [18:47:21] Hi guys, I noticed https://bugzilla.wikimedia.org/show_bug.cgi?id=38962#c13 got closed today [18:47:30] do redirects work on Wikidata now? [18:48:17] twkozlowski: that "bug" is only about design/decide [18:48:29] implement would be another bug... [18:48:36] DanielK_WMDE_ would know [18:48:52] aude: Leaving tomorrow? [18:49:04] hoo: no, why? [18:49:14] aude: OK, just wondering :-) [18:49:25] we have strange bugs like that :) [18:49:38] (03CR) 10Aude: Store EntityView js config in parser output (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [18:49:54] aude: Just wondered because of your weather post :P [18:49:59] soon [18:50:24] * aude expects it to be sunny and warm when i arrive [18:50:58] wtf, 23 C on monday! [18:51:20] oO [18:52:02] * aude office will be outside :) [18:52:37] This year it's bearable in Germany even... [18:52:46] yeah quite good [18:52:46] last year (when I was in Berlin around this time) it was a little to cold [18:53:01] yep [19:29:49] Hoi Eloquence best wishes [19:30:00] hey GerardM :) happy new year! [19:31:46] what do you think, will 2014 be breakthrough year for Wikidata ? [19:33:54] GerardM, I think things will only get more exciting :) [19:34:32] Lets make it so ... my bet is firmly on it [20:00:10] pff [20:00:18] some things are difficult to trace on WikiData [20:02:51] Beetstra: mh? [20:03:35] trying to figure out the smart way to figure out which 'wikidata property' on wikidata corresponds to an 'identifier' on en.wikipedia [20:03:36] Beetstra are you Dutch, South African ? [20:03:41] Dutch [20:04:19] the identifier on a Wikipedia is on the left hand side in the toolbar ... in English "Data item" [20:04:31] am also Dutch [20:04:37] No, that is not the identifier, that is the record number [20:05:33] I mean, on [[:en:Benzene]] in the infobox, there is a KEGG listed - now go figure which P### on wikidata is the KEGG [20:05:55] I know how to find it, but it is a handful of clicks away [20:06:03] (and now do it for 20 identifiers like that) [20:07:24] what is a KEGG ... also not all data types are supported at this moment [20:07:34] Look, that is the additional problem [20:08:27] So .. click on [[:en:KEGG]], click on 'Data item', click on 'what links here', find something that has the Data item on it (click that), hover over the property -> get the P-number [20:08:38] * Beetstra runs away [20:08:55] 23:08 -> bedtime anyway [20:09:09] for those who ask -> Beetstra is programming a bot [20:09:41] Beetstra ever hear of the Wikiprotein project ? [20:09:57] it does no longer run on MediaWiki but when it did I was involved [20:10:04] Oh, and, going from [[:en:Benzene]] to the Data item does not necessarily mean that you find the KEGG-property there, it may not have been set on WikiData for Benzene, but maybe it is for Ethanol [20:10:09] Know about things like Wikiprotein [20:10:18] I am a organic/organometallic/catalysis-chemist [20:10:19] eh SwissProt [20:10:47] If you want a property to link to KEGG, you can request it [20:10:54] and it is likely to be granted [20:11:00] I know, the point is, it already exists [20:11:10] so what is the point [20:11:25] That it is friggin' impossible to find that out [20:11:39] it is hard [20:11:49] OK, I exaggerated [20:11:51] :-D [20:12:17] Beetstra: You basically want a list of stuff from Wikidata used on a client page? [20:12:22] one reason is because many of the links to KEGG do not exist in Wikidata [20:13:02] You guys give me a database of data - what I am doing is to check that backwards [20:13:56] I have, on en.wikipedia, KEGG=C01407 - is that the same as on WikiData? If yes, it is likely 'correct' (I assume your data is 'checked') [20:15:54] Beetstra the data is NOT checked [20:16:20] I know [20:16:50] For now, the bot is going to run in 'compare' mode [20:17:13] dennyvrandecic: you might want to have a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=58850 [20:38:55] hoo, addshore, reading [20:39:14] but I have a hard time remembering decisions on the merge api [20:40:48] it has nothing to do with the setsitelink module, right? [20:42:36] addshore: can you remind me of the context of the decision? i am blanked right now [20:43:24] hoo|away: can you explain what is actually wring with the merge? it looks ok to me [20:51:11] * aude waves [20:54:26] Exception from line 384 of /usr/local/apache/common-local/php-1.23wmf8/extensions/WikibaseDataModel/DataModel/ByPropertyIdArray.php: Specified index is out of bounds [20:57:32] /wiki/Special:NewItem Exception from line 117 of /usr/local/apache/common-local/php-1.23wmf9/includes/WikiPage.php: Invalid or virtual namespace -1 given. [20:57:48] on test.wikidata if you put a blacklist link in as a label [20:59:09] errr, on wikidata [21:04:56] * hoo can see hardly anything on this screen as KDE fails to turn up the screen brightness again [21:06:13] dennyvrandecic: we have instance of wikimedia category page twice with different sources [21:06:52] ok [21:07:36] the claim has to be completely identical for two sources to move to the same claim [21:07:44] i.e. also all qualifiers have to be identical [21:08:59] dennyvrandecic: mh... I can understand both points of view... the wikidata users consider our behaviour heavily broken :/ [21:09:30] Can't we merge them and let it have 2 sources? (Like the current version of https://www.wikidata.org/wiki/Q7013553 has) [21:09:44] if the qualifiers are identical too, yes [21:10:02] which is the case here [21:10:08] Ok, thought so [21:10:26] that's what I meant with " (there are quite some different examples for that, some simpler, some more complex ...)" in my reply to the bug [21:10:37] ok. i will answer the bug [21:10:50] please be as detailed as possible, it's appreciated ;) [21:11:13] the qualifiers have to be identical. i.e. if one has qualifiers, the other one doesn't, no merging. if they both have qualifiers, all of them have to be exactly identical. or else no merging. [21:11:45] Just add that to the bug and I'm happy :) [21:11:53] :) ok [21:17:36] hoo, addshore: done. I hope I am consistent with the explanation [21:18:49] dennyvrandecic: That's crystal clear :) I guess addshore can work with this [21:19:10] good [21:22:10] why don't we have the items of the colombian actors connected with the Category:Colombian actors? (since I have that example open now) [21:22:47] Sounds like a nice task for a some bot [21:23:25] this could feed back to the Wikipedias I guess, if they have pages for both the article and the category [21:25:23] this week I wondered why we still maintain software version numbers in all Wikipedias... that's like the first thing I'd import from Wikidata [21:25:37] a static string which has no context and changes often... [21:26:42] ok, i can't create any items on test.wikidata :( [21:27:02] aude: What's going on? [21:27:39] one sec [21:27:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=59797 [21:28:07] works on wikidata so something changed in either spam blacklist (kind of doubt) or core [21:28:49] aude: SpamBlacklist changed [21:29:30] https://gerrit.wikimedia.org/r/101490 [21:29:33] huh [21:30:07] i think that might have been deployed already [21:30:31] wmf/1.23wmf9 [21:30:36] mh... is that on wikidata yet? [21:30:51] nope [21:31:04] hasn't yet hit wikidata [21:31:31] ok, then that makes sense [21:32:09] uhm, I think that will hit wikidata tonight [21:32:21] https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap [21:32:24] tehre are other issues so not yet [21:32:29] hoo: agreed on software version numbers [21:32:49] aude: puh :) [21:33:03] we'll keep wikidata on wmf8 or fix it [21:34:23] aude: Ok :) [21:45:08] * aude curious how spam blacklist ever worked for wikidata? [21:45:29] Daniel hacked on that [21:45:43] it did, I think I even approved his patches [21:45:57] ok, it works on wikidata [21:47:45] entity content does "getParserOutput( Title $title" [21:47:54] never using $title but i assume it's required by parent class [21:48:26] probably [21:50:00] so if $title is Special:NewItem, then didn't matter (but stupid) [21:51:41] mh... not sure what a sane title would be [21:58:07] https://gerrit.wikimedia.org/r/#/c/106123/ for now [21:58:55] aude: Approved [21:59:04] k [21:59:13] we can hopefully find a better solution soon [21:59:18] people should really CC us on such changes [21:59:35] I mean Daniel wrote the code and I reviewed it... and neither of us got added [22:22:24] this is icky [22:22:54] if a new entity, the id is unknown in attemptSave [22:23:14] so not exactly trivial to make a title for it [22:33:44] yep :/ [22:34:52] * aude wonders if spam blacklist really needs title [22:35:13] aude: It does, but not for creations [22:35:33] right [22:35:35] Usually it does diff( oldLinks, newLinks ) and then checks that diff against its blacklist [22:35:43] it does if ( $title !== null ) [22:35:54] then makes a log entry [22:41:51] we got ten thousands of empty/ redirect-only items around which could easily be deleted :/ [22:55:11] hoo: just read dennyvrandecic's reply and will poke the module in the coming days :) [22:55:16] :) [22:55:28] addshore: I hope I am consitent with myself :) [23:18:58] legoktm: around= [23:18:59] *?