[01:48:59] Jasper_Deng there? [01:49:12] or JD|cloud [01:49:20] your network going down [02:36:58] (03PS5) 10Aude: Remove hardcoded ids from SetClaimTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102919 [02:42:27] DangsunM I warned you ahead of time, server reboot/maintenance [02:42:39] ok [02:44:45] (03CR) 10Aude: [C: 04-1] "this is leaking properties to my non-test database, probably having to do with the order that providers and setUp is executed. (properties" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102863 (owner: 10Hoo man) [02:45:27] aude: Duh... thanks! Will have a look in a minute [02:45:49] (03CR) 10Aude: "had same issue in SetClaimTest which is fixed now and jenkins is happy" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102863 (owner: 10Hoo man) [02:46:08] * aude just noticed the stuff in my db [03:23:52] (03PS6) 10Hoo man: Remove hard coded entity ids from SetQualifierTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102863 [03:27:44] aude: ^ passes now :) [03:28:24] \o/ [03:28:33] shall review when more awake [03:28:39] heh :D [03:28:52] My solution's a little hacky, but it's ok (IMO) [03:29:12] i'm not totally pleased with set claim either [03:29:19] open to suggestions [03:31:58] (03CR) 10Hoo man: [C: 032] "Looks good, passes locally and on jenkins." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102920 (owner: 10Aude) [03:36:51] (03Merged) 10jenkins-bot: Remove hardcoded ids and cleanup in RemoveClaimsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102920 (owner: 10Aude) [03:37:55] (03CR) 10Hoo man: "You could also let the providers return the snak class names and then initialize the Snaks (and their dependencies) in a helper function w" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102919 (owner: 10Aude) [03:39:46] (03CR) 10Hoo man: [C: 032] "Looks good, passes locally and on jenkins." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102917 (owner: 10Aude) [03:44:43] (03Merged) 10jenkins-bot: Remove hardcoded ids in SetReferenceTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102917 (owner: 10Aude) [03:52:27] aude: wow... 3 consecutive passes on Travis [03:52:49] \o/ I think we may got it now :) [03:56:31] yay! [03:56:47] although i still wonder about the test exiting [03:58:30] aude: mh... is that on SQLite or MariaDB [03:58:32] ? [03:58:35] or both even? [03:59:31] not sure... both probably [04:00:50] aude: Do we have a failure with --debug and enabled Xdebug, or are we clueless (more or less)? [04:01:05] I doubt I can reproduce [04:03:49] i'll have to add --debug again [04:04:05] i had it for set claim but don't think i got test exiting there [04:05:20] May I'll just run the suite in a loop until it exists with a 255 tomorrow [04:07:55] ok [04:08:07] i'm trying on travis now [04:10:04] aude: Seeing failures with the InfoActionHookHandlerTest on master [04:11:09] http://pastebin.com/hx6etFr1 [04:12:01] oh no [04:12:15] i got that on travis [04:12:33] :/ [04:12:43] before my patch [04:13:31] https://api.travis-ci.org/jobs/15803771/log.txt?deansi=true [04:13:44] be warned, it's a big page [04:14:18] [travis-ci] filbertkm/Wikibase#114 (debugmode - adfc9ab : aude): The build failed. [04:14:18] [travis-ci] Change view : https://github.com/filbertkm/Wikibase/commit/adfc9abaf5d8 [04:14:18] [travis-ci] Build details : http://travis-ci.org/filbertkm/Wikibase/builds/15803770 [04:15:10] sad [04:16:03] indeed :/ [04:16:54] got test exit and infoaction [04:18:40] I'm thinking about creating something that complains in case a tests does something bad on global state... that's going to be slow, but will force us to do better. [04:19:09] You can eg. see when MySQL tables have been changed last, that shouldn't change during unit tests (for non-mock tables) [04:19:20] Also you can compare global variables and static stuff [04:19:40] * aude nods [04:19:44] a bit like what we do with php output buffering, but on a wider scale [04:20:10] aude: I keep seeing these failures... even with a fresh DB [04:20:33] i don't know why that suddenly appeared [04:20:56] that's what prompted me to mock title, but there's another issue [04:21:15] mh... they pass isolated, so it's a state issue (yet again) [04:21:25] yep [04:23:04] * aude done for now [04:50:55] (03PS1) 10Hoo man: Fix InfoActionHookHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/103086 [09:04:19] is there a mobile view of Wikidata [09:06:31] Jianhui67: not yet, there was a GSOC project about this [09:06:51] http://wikidata-mobile-tester.instance-proxy.wmflabs.org/w/index.php?title=Main_Page&mobileaction=toggle_view_mobile works though [11:33:55] (03CR) 10Aude: [C: 032] Fix InfoActionHookHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/103086 (owner: 10Hoo man) [11:38:41] (03Merged) 10jenkins-bot: Fix InfoActionHookHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/103086 (owner: 10Hoo man) [11:57:27] [travis-ci] filbertkm/Wikibase#115 (master - 7eacbeb : aude): The build failed. [11:57:27] [travis-ci] Change view : https://github.com/filbertkm/Wikibase/compare/41561ecc5cde...7eacbeb8c9d1 [11:57:27] [travis-ci] Build details : http://travis-ci.org/filbertkm/Wikibase/builds/15813617 [12:08:13] JohnFLewis: https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/Interwiki_links_for_special_pages#Babel.3F [12:23:47] * multichill pokes legoktm [12:23:59] Does https://www.mediawiki.org/wiki/Compact_interlanguage_links_as_a_beta_feature address your concerns about recentchanges? [12:24:12] (and why the hell are you running a skin from the 1990's? :P ) [12:38:33] multichill: huh? [12:45:39] * multichill hands JohnFLewis some coffee [12:46:17] :p [12:52:51] Any clue about how to get translated the "Cannot auto-describe" message from the search results in the Wikipedias? [12:53:32] jem-: Linkie? [12:55:24] jem that is part of the functionality that Magnus wrote [12:55:59] it may need a new message [13:58:28] !team [13:58:42] DangSunM: Yes? [13:58:49] after 5 mineutes [13:58:56] large bulk will come [13:59:13] I found 100 empty items [13:59:45] DangSunM: Any reason you decided to tell us here as opposed to the admin channel? :p [13:59:56] mistake [13:59:58] Where the team command is better used :) [14:00:24] :) [14:00:38] originally I want to post admin channel but mistake:P [14:00:44] :) [14:01:15] oh, I thought that this was the admin channel :P [14:01:49] (because I didn't see any tezt from the developers) [14:01:52] text* [14:03:47] Stryn: Ah :p JeroenDeDauw - Stryn says break more things ;) [14:30:41] exactly :D [14:40:15] :ㅇ [14:58:31] anyone there? [15:00:24] I am invisible ;) [18:41:17] How this https://www.wikidata.org/w/index.php?title=Q7013553&diff=95501306&oldid=88167854 merge is done? It is not done via merge.js and is broken [18:44:46] Another incorrect merge https://www.wikidata.org/wiki/Q7966791 how users are doing it actually? [18:46:29] !admin ^ [18:46:34] ebraminio: wgmergeitems API module [18:46:40] * lazowik hides quickly [18:46:46] probably used by the linkItem widget in client [18:46:47] * SannitAway hunts down lazowik  [18:46:52] * iva [18:46:54] * via [18:46:58] damnit [18:46:59] lazowik: Yes you better. You pinged an admin to deal with a request an admin made :p [18:47:08] ups.. [18:47:16] sorry! [18:47:24] lazowik: Don't worry. [18:47:35] * JohnLewis puts a strike on lazowik's profile :p [18:48:03] * SannitAway finds lazowik and feasts upon his flesh :P [18:48:27] I see a bright light! [18:49:49] Lydia_WMDE: ^ [18:50:28] that's a tough bug actually as I'm not really sure how to do that properly w/o having to bug users with details of the merge [18:55:26] hoo: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/a835b0ab5ad348ee6d4ac969bd043b8d671ebfaa/client/resources/wikibase.client.PageConnector.js#L303 [18:55:50] ebraminio: I know that line... I wrote the entire thing [18:56:14] hoo: so you should make sure claims should be merged [18:56:17] but I have no clue how we can get that resolved w/o breaking user experience [18:56:27] hoo: just like my merge.js [18:57:02] oh... I didn't write the API part for that. [18:58:17] I'm not sure all these can be sanely merged [18:58:59] but the given cases are probably easy to resolve [18:59:16] ebraminio: Want to open a bug against Repo? [19:00:02] I hope that addshore can a have a look at that then (he wrote the API part) [19:01:57] hoo: Please do, I reported another https://bugzilla.wikimedia.org/show_bug.cgi?id=55960 but no one even looked [19:03:24] ebraminio: have to head of now... a friend's about to come... I hope I recall that later/ tomorrow, you might want to ping me again, if I forget [19:03:28] That is surprising why this not well tested API is merged and... two user requested use of merge api on merge.js https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-Merge.js#New_merge_API [19:04:00] ebraminio: mh... it's well tested, but only for basic items [19:04:45] hoo: Have a look at the bug, I couldn't even merge two simple item on test wikidata [19:05:41] ebraminio: It works rather well in production [19:05:48] not sure about testwikidata [19:08:38] how it is tested but is not working on testwikidata... [19:10:50] ebraminio: Maybe a configuration issue [19:11:19] I can have a look at that in the next couple of das [19:11:21] * days [20:49:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1465 (master - 269b1eb : Translation updater bot): The build was broken. [20:49:25] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ebd42b5c39f7...269b1eb7e303 [20:49:25] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15827596 [21:42:02] !admin https://www.wikidata.org/wiki/Special:Contributions/189.134.120.161 [21:43:11] I restored it [21:43:32] but can someone block further misschief ? [21:48:55] GerardM-: hm, not sure whether this user is going to edit again … maybe a kind notice on the IP's talk page would be appropriate? [22:40:04] (03PS8) 10Aude: Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 [23:05:50] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/15827598 :( [23:06:59] multichill: not really. It fixes my issue with it, but I still don't see any advantages to storing links to a page we know exists on every single wiki because it's provided by the software. [23:10:32] ^in fact these connections could also easily be made without Wikidata if really needed, I guess [23:49:09] can anyone tell me when Commons is planned to turn on being able to inhale #property data for use? [23:54:07] "//todo if the second result is not a success we should probably undo the first change" orly :P