[00:00:06] <aude>	 k
[00:00:28] <jem->	 Anyone in here knows about the wdsearch.js gadget?
[00:01:37] <jem->	 Hmmm, that should be, Does anyone in here know...?
[00:05:23] * hoo  starts to cry

[00:05:23] <hoo>	 https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/15679722
[00:05:25] <hoo>	 :(
[00:06:48] <hoo>	 oh, and I have new failures locally: "5) Wikibase\Test\EntityDataRequestHandlerTest::testHandleRequest" -.-
[00:06:58] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1448 (master - c6165d5 : Marius Hoch): The build is still failing.
[00:06:58] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7eec1e15d422...c6165d591a97
[00:06:58] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15679721
[00:07:37] <aude>	 hmmmm
[00:07:44] <hoo>	 aude: ^ but I think we already improved... "only" 1/6 failed
[00:08:40] <aude>	 yeah
[00:16:40] <aude>	 alright ... enough for now :/
[00:16:44] <hoo>	 aude: want to merge https://gerrit.wikimedia.org/r/102571 ?
[00:17:03] <hoo>	 Yeah, past 1am already (again)
[00:18:06] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Some sanity changes in EditEntityTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102571 (owner: 10Hoo man)
[00:18:07] <aude>	 alright
[00:18:33] <aude>	 somewhat better 
[00:20:10] <hoo>	 Yeah... tomorrow we'll hopefully manage to break through the failures
[00:22:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Some sanity changes in EditEntityTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102571 (owner: 10Hoo man)
[00:43:10] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1449 (master - 060faac : jenkins-bot): The build is still failing.
[00:43:10] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c6165d591a97...060faac9842a
[00:43:10] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15680950
[09:57:39] <Pyb>	 !admin could you replaced https://www.wikidata.org/wiki/User:Ch1902/ancestry.js with my corrected version https://www.wikidata.org/wiki/User:Pyb/ancestry.js ? The user didn't contribute since April.
[10:40:37] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "Found the bug and a bunch of design issues :)" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene)
[11:49:11] <grrrit-wm>	 (03Draft1) 10Henning Snater: Display qualifiers in non-JavaScript UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102643 
[14:02:58] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 04-1] Use snake case (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011)
[14:28:52] <travis-ci>	 [travis-ci] wmde/Wikibase#6 (fixtravis - 060faac : jenkins-bot): The build is still failing.
[14:28:52] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/c49727842fd8...060faac9842a
[14:28:52] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15709872
[14:40:15] <travis-ci>	 [travis-ci] wmde/Wikibase#7 (fixtravis - 81dc26a : daniel): The build is still failing.
[14:40:15] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/060faac9842a...81dc26a98516
[14:40:15] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15710249
[14:42:27] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-1] "Still not all files covered yet." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011)
[14:47:57] <DanielK_WMDE>	 aude: we have a lot of label conflicts. several tests using the label "Test" for de or en labels,
[14:48:08] <aude>	 :(
[14:48:46] <DanielK_WMDE>	 not so much of a problem with items, since there the description would also have to match. but for properties, it's an instant conflict
[14:48:51] <JeroenDeDauw>	 Tests should not leak state
[14:49:26] <DanielK_WMDE>	 JeroenDeDauw: oh! right! i'll just refactor half of mediawiki to make that work!
[14:49:52] <DanielK_WMDE>	 JeroenDeDauw: or reset the database after every test. that would work too.
[14:49:59] <DanielK_WMDE>	 it would just make tests a lot slower.
[14:51:45] <JeroenDeDauw>	 DanielK_WMDE: WikibaseQuery has system tests that use the db and do clean themselves up. Note how they are still way faster then the Wikibase tests
[14:52:35] <DanielK_WMDE>	 JeroenDeDauw: if you know a good way to make that work with the saving mechanism implemented by WikiPage and Revision, please let me know
[14:53:37] <travis-ci>	 [travis-ci] wmde/Wikibase#8 (master - 060faac : jenkins-bot): The build is still failing.
[14:53:38] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/c49727842fd8...060faac9842a
[14:53:38] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15710347
[14:53:41] <DanielK_WMDE>	 we could improve the current situation be encapsulating the setup, creation and deletion of entities in the database in a separate class.
[14:53:46] <DanielK_WMDE>	 and trhen be smart about when to reset.
[14:54:31] <DanielK_WMDE>	 that means refactoring quite a few tests. i'd rather implement the EntityStore abstraction layer, and get rid of db interaction entirely in many places
[14:54:38] <DanielK_WMDE>	 (next on my todo list, actually)
[14:59:36] <JeroenDeDauw>	 DanielK_WMDE: that would definitly help yes
[15:10:08] <grrrit-wm>	 (03PS1) 10Tobias Gritschacher: Update gems for browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102689 
[15:22:00] <grrrit-wm>	 (03Draft2) 10Aude: Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 
[15:23:47] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Update gems for browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102689 (owner: 10Tobias Gritschacher)
[15:28:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update gems for browser tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102689 (owner: 10Tobias Gritschacher)
[15:30:02] <grrrit-wm>	 (03Abandoned) 10Aude: move $hasProperties static variable out of SetReferenceTest setUp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101803 (owner: 10Aude)
[15:43:16] <JohnFLewis>	 Pyb: was your request dealt with earlier?
[15:43:46] <Pyb>	 JohnFLewis: no ;)
[15:44:02] <JohnFLewis>	 Pyb: Ok. I'll get it done now :)
[15:44:25] <Pyb>	 JohnFLewis: thx
[15:46:04] <JohnFLewis>	 Done.
[15:47:26] <JohnFLewis>	 Pyb: If there any more changes needed, just ping me.
[15:51:20] <JeroenDeDauw>	 Tobi_WMDE: https://github.com/travis-ci/travis-ci/issues/1606#issuecomment-30905341
[15:55:48] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1450 (master - 856c355 : Tobias Gritschacher): The build is still failing.
[15:55:48] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/060faac9842a...856c3557f637
[15:55:48] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15714265
[16:09:34] <travis-ci>	 [travis-ci] wmde/Wikibase#9 (fixtravis - ceffe64 : daniel): The build is still failing.
[16:09:34] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/81dc26a98516...ceffe6418236
[16:09:34] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15715037
[16:42:58] <grrrit-wm>	 (03PS3) 10Aude: Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 
[16:55:22] <DanielK_WMDE>	 JeroenDeDauw: found no further issues
[16:55:56] <DanielK_WMDE>	 do you have the ones we found written down somewhere? or do you already have fixes?
[16:57:55] <DanielK_WMDE>	 how do we keep track, since this is outside the regular review process?
[17:00:19] <hoo>	 wow... 6pm already :/
[17:00:33] <travis-ci>	 [travis-ci] wmde/Wikibase#10 (fixtravis - 26b6895 : daniel): The build is still failing.
[17:00:33] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/ceffe6418236...26b68959bffe
[17:00:33] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15717861
[17:00:39] <JeroenDeDauw>	 DanielK_WMDE: everything has already been fixed except this bootstrap.php issue
[17:00:59] <DanielK_WMDE>	 ok
[17:02:04] <DanielK_WMDE>	 JeroenDeDauw: btw, exec returns just the last line of the program's output. is that what you wanted?
[17:04:52] <hoo>	 Lydia_WMDE: Guess who has (literally) just migrated to KDE? :P
[17:05:12] <Lydia_WMDE>	 hoo: <3
[17:05:13] <Lydia_WMDE>	 :D
[17:05:51] <JeroenDeDauw>	 DanielK_WMDE: nope
[17:05:53] <JeroenDeDauw>	 $pwd = exec( 'pwd' );
[17:05:55] <JeroenDeDauw>	 chdir( __DIR__ . '/..' );
[17:05:57] <JeroenDeDauw>	 $output = array();
[17:05:59] <JeroenDeDauw>	 exec( 'composer update', $output );
[17:06:01] <JeroenDeDauw>	 echo  implode( $output, "\n" ) . "\n";
[17:06:03] <JeroenDeDauw>	 chdir( $pwd );
[17:06:05] <JeroenDeDauw>	 That works
[17:06:07] <JeroenDeDauw>	 Though does not guard against inclusion
[17:06:09] <JeroenDeDauw>	 http://stackoverflow.com/questions/20687545/guard-against-execution-of-phpunit-bootstrap-file
[17:06:10] <hoo>	 Lydia_WMDE: :D I've upgraded to Fedora 20 this morning and I just couldn't manage to get my stuff to work with Xfce anymore... so this really wasn't planned :D
[17:06:12] * aude  rage.... git eats my stuff

[17:10:04] <DanielK_WMDE>	 JeroenDeDauw: replied on SO :)
[17:10:50] <DanielK_WMDE>	 aude: not seeing "ranomd" failures any more on my branch.need to poke some more.
[17:11:08] <hoo>	 what did I miss?
[17:11:18] <DanielK_WMDE>	 aude: these happen when running just the Wikibase tests, right? not core tests.
[17:11:48] <DanielK_WMDE>	 aude: but then, i never saw the errors you got.
[17:12:08] <DanielK_WMDE>	 i mean, i never saw them on the branch i'm playing with
[17:12:09] <hoo>	 DanielK_WMDE: aude: Did anyone see failures in EntityDataRequestHandlerTest ?
[17:12:17] <DanielK_WMDE>	 hoo: yes
[17:12:42] <DanielK_WMDE>	 hoo: note however that there's a patch on gerrit that would make that test (and all other EntityData tests) not touch the database at all
[17:12:47] <hoo>	 ok, cause I hacked on that this morning, just before I upgraded to Fedora 20 (which killed my system)
[17:13:01] <DanielK_WMDE>	 Fedora o_O
[17:13:35] <hoo>	 actually it's Xfce's fault... the whole stuff is working like a charm with Gnome 3 and KDE
[17:14:22] <DanielK_WMDE>	 xfce! welcome to the 90s!
[17:15:06] <hoo>	 Yeah... until now I used an auot start bash script to bypass it's crappy settings manager killing my X configuration
[17:15:31] <hoo>	 but that no longer works... somehow Xfce manages to kill Xrandr (\o/)
[17:20:12] <aude>	 DanielK_WMDE: just --group Wikibase
[17:20:15] <aude>	 like travis does
[17:22:41] <DanielK_WMDE>	 aude: ok
[17:26:12] <JeroenDeDauw>	 DanielK_WMDE: https://github.com/DataValues/Number/pull/1
[17:32:46] <JeroenDeDauw>	 DanielK_WMDE: the diff for review should be updated now
[17:40:04] <DanielK_WMDE>	 JeroenDeDauw: minor issue, see comment
[18:12:25] <JeroenDeDauw>	 DanielK_WMDE: click the button! https://github.com/DataValues/Number/pull/1
[18:14:35] <travis-ci>	 [travis-ci] wmde/Wikibase#11 (fixtravis - e46484b : daniel): The build is still failing.
[18:14:35] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/26b68959bffe...e46484b25558
[18:14:35] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15722120
[18:16:24] <hoo>	 DanielK_WMDE: any reason to use " $context = new DerivativeContext( RequestContext::getMain() );" in tests?
[18:16:55] <hoo>	 I don't think using that makes any sense... except one likes a bit of global state
[18:17:37] <DanielK_WMDE>	 hoo: nope, new RequestContext() should be better
[18:17:48] <travis-ci>	 [travis-ci] wmde/DataValuesJavascript#3 (master - 8fa66a8 : jeroendedauw): The build has errored.
[18:17:48] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/DataValuesJavascript/compare/14b45244f0ad...8fa66a8f6af7
[18:17:48] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/DataValuesJavascript/builds/15722431
[18:17:50] <hoo>	 DanielK_WMDE: k :)
[18:18:15] <DanielK_WMDE>	 hoo, aude: fixing various db state issues on my "fixtravis" branch atm
[18:18:22] <aude>	 k
[18:18:45] <hoo>	 :)
[18:18:46] <DanielK_WMDE>	 there's a lot of things that "might" cause trouble. though it never does on jenkins. but it often does on travis. i wonder why.
[18:18:50] <grrrit-wm>	 (03PS1) 10Hoo man: Remove some clutter from EntityDataRequestHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102722 
[18:18:53] <aude>	 https://travis-ci.org/filbertkm/Wikibase/builds/15721312 :)
[18:18:58] <aude>	 no api tests though
[18:19:08] <DanielK_WMDE>	 btw, Jeroen asserts that there is no parallelization or randomness involved with running tests on travis
[18:19:22] <hoo>	 DanielK_WMDE: True
[18:19:30] <DanielK_WMDE>	 but *somthing* is introducing a random factor :/
[18:19:31] <aude>	 i still see tests exiting sometimes but that's all, outside of api tests
[18:19:49] <DanielK_WMDE>	 aude: yes, i'm seeing that too. quite frequently, actually. 
[18:20:03] <hoo>	 DanielK_WMDE: Yeah... don't know about that either... I'm using my own fully controlled plain VM for testing and I still have these random factors
[18:20:04] <aude>	 that is newish
[18:20:04] <DanielK_WMDE>	 any pattern to which text is the last that was executed?
[18:20:26] <aude>	 it's usually after TermSqlIndex ( i think ) or during
[18:20:40] <hoo>	 wow... KDE ist faster with desktop effects than without?! :D
[18:21:46] <aude>	 https://travis-ci.org/filbertkm/Wikibase/jobs/15679878
[18:21:55] <aude>	 exits after ".ok 2699 - Wikibase\Test\DatabaseRowEntityIdIteratorTest::testMediaWikiTestCaseParentSetupCalled"
[18:22:17] <hoo>	 aude: use --debug rather thatn the tabs format
[18:22:23] <hoo>	 more useful for that
[18:23:01] <grrrit-wm>	 (03PS1) 10Aude: Remove unused use statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102724 
[18:23:18] <aude>	 hoo: hmmm
[18:23:56] <hoo>	 https://gerrit.wikimedia.org/r/102722 stuff left over from my brief tests this morning...
[18:24:10] <DanielK_WMDE>	 hoo: could be that "without" means "no hw composition"
[18:24:31] <hoo>	 mh, it shouldn't... I chose OpenGl 3.1
[18:25:13] * hoo  likes KDE... much better than the last time I tried (late 2011)...

[18:26:41] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Remove unused use statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102724 (owner: 10Aude)
[18:29:54] <DanielK_WMDE>	 hoo: dual monitor support is a bit flaxy though - panels keep jumping around, etc
[18:30:51] <hoo>	 DanielK_WMDE: Can't be worse than with Xfce... it actually didn't manage to get them even configure properly (position and resolution)
[18:31:20] <hoo>	 It worked fine while I had two screens (counting the internal screen also), but then I bought my third one Xfce gave up
[18:31:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused use statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102724 (owner: 10Aude)
[18:33:09] <aude>	 https://travis-ci.org/filbertkm/Wikibase/builds/15721400 success :)
[18:33:15] <aude>	 no api tests
[18:33:31] <hoo>	 Still :)
[18:34:05] <aude>	 isolating things but is with https://gerrit.wikimedia.org/r/#/c/102685/
[18:34:45] <aude>	 if not addressing failures (not sure), it was one of our slowest tests 
[18:41:35] <aude>	 https://travis-ci.org/wmde/Wikibase/jobs/15723230 got the exit same place i did
[18:41:48] <aude>	 although i've seen it after TermSqlIndex also
[18:42:31] <hoo>	 mh
[18:45:49] <hoo>	 "$this->db->delete( 'page', '*' );" mh
[18:47:16] <JeroenDeDauw>	 delete ALL the pages!
[18:50:29] <travis-ci>	 [travis-ci] wmde/Wikibase#12 (fixtravis - d603acc : daniel): The build is still failing.
[18:50:29] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/e46484b25558...d603acc1dc11
[18:50:29] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15723228
[18:51:53] <travis-ci>	 [travis-ci] wmde/DataValuesJavascript#4 (master - c37365e : jeroendedauw): The build failed.
[18:51:53] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/DataValuesJavascript/compare/8fa66a8f6af7...c37365e3bd6c
[18:51:53] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/DataValuesJavascript/builds/15724336
[18:55:12] <DanielK_WMDE>	 hoo, aude: https://github.com/wmde/Wikibase/tree/fixtravis
[18:57:56] <hoo>	 DanielK_WMDE: :) I also thought about using prefixes for labels and stuff... but it somehow didn't sound sane
[18:57:58] <aude>	 hoo: using $this->tablesUsed[] it gets reset after... reset before might nto be needed
[18:58:21] <aude>	 unless someone has better idea :)
[19:00:22] <hoo>	 aude: Not really... but doing a delete from page without a where *might* have side effects :P
[19:00:37] <aude>	 it will be truncated afterwards anyway
[19:00:43] <hoo>	 yeah
[19:00:58] <hoo>	 but that might hide other problems with tests... I don't have a better idea either
[19:01:08] <hoo>	 If no one has, I'm ok with that approach
[19:01:09] <aude>	 only other thing would be just to specifically specify which things to add and then deelte
[19:01:20] <aude>	 would work
[19:01:31] * aude  might try

[19:01:38] <hoo>	 aude: mh... don't make it overly complicated
[19:01:44] <aude>	 ok
[19:01:52] <DanielK_WMDE>	 deleting just from the page table sounds evil - there's a bunch of things referencing that table (though not in a strict sense)
[19:02:07] <aude>	 they shouldn't be
[19:02:11] <DanielK_WMDE>	 but all the link tables, page_props, revision, etc all kind of rely on the page table.
[19:02:29] <DanielK_WMDE>	 aude: they shouldn't? everythign that uses a page id anywhere is relying on the page table.
[19:02:37] <hoo>	 mh
[19:02:53] <DanielK_WMDE>	 not saying that thsi is a major problem in tests
[19:02:53] <hoo>	 could you use WikiPage to delete these pages (don't have the code in front of me anymore)
[19:03:05] <DanielK_WMDE>	 just saying that it may cause confusion in obscure places
[19:03:20] <DanielK_WMDE>	 hoo: clean, but slow :)
[19:05:02] <aude>	 ok, the problem is controlling for which namespace the pages are in
[19:05:12] * aude  tries

[19:08:22] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1451 (master - ab291bf : aude): The build is still failing.
[19:08:22] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/856c3557f637...ab291bfd918a
[19:08:22] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15724830
[19:09:32] * aude  kick travis

[19:10:58] <hoo>	 oh damn
[19:11:35] <hoo>	 That's a test case I hacked on yesterday (it made bad assumptions about users in the DB)
[19:14:38] <aude>	 which one?
[19:15:40] <hoo>	 EditEntityTest::testUserWasLastToEdit
[19:15:46] <aude>	 oh, ok
[19:16:09] <DanielK_WMDE>	 hoo: i didn't fix that one, just made sure it would give more useful output
[19:17:12] <aude>	 thanks DanielK_WMDE for investigating :)
[19:17:45] <DanielK_WMDE>	 \o/
[19:18:05] <DanielK_WMDE>	 i'm officially off now until january 6th.
[19:18:10] <hoo>	 oO
[19:18:14] <hoo>	 Bye :)
[19:18:14] <DanielK_WMDE>	 but i'll probably poke at stuff every now and then
[19:18:30] <DanielK_WMDE>	 see you guys next year!
[19:18:51] <hoo>	 see you!
[19:19:13] <aude>	 ok
[19:19:22] <aude>	 enjoy holidays!
[19:19:42] <hoo>	 +1 :) Take some time off ...
[19:20:57] <hoo>	 aude: https://github.com/wmde/Wikibase/commits/fixtravis are we supposed to polish these and take them to gerrit?
[19:21:32] <hoo>	 having them only on github is a waste
[19:25:05] <aude>	 yes
[19:59:43] <grrrit-wm>	 (03CR) 10Aude: [C: 04-1] "setup and teardown could be more fine-grained" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 (owner: 10Aude)
[20:00:07] <travis-ci>	 [travis-ci] wmde/DataValuesJavascript#5 (master - 0a3a233 : jeroendedauw): The build is still failing.
[20:00:07] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/DataValuesJavascript/compare/c37365e3bd6c...0a3a2332f5da
[20:00:08] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/DataValuesJavascript/builds/15726035
[20:04:43] <travis-ci>	 [travis-ci] wmde/Wikibase#18 (fixtravis - 22b6d63 : daniel): The build was fixed.
[20:04:43] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/d603acc1dc11...22b6d6321587
[20:04:43] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15725983
[20:06:50] <aude>	 \o/
[20:08:23] <JeroenDeDauw>	 aude: can that branch be merged as far as you are concerned?
[20:08:32] <JeroenDeDauw>	 Since you where also doing some similar stuff...
[20:09:55] <aude>	 probably
[20:11:21] <grrrit-wm>	 (03PS4) 10Aude: Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 
[20:13:51] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: Remove some clutter from EntityDataRequestHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102722 (owner: 10Hoo man)
[20:14:43] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Remove some clutter from EntityDataRequestHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102722 (owner: 10Hoo man)
[20:15:34] <aude>	 JeroenDeDauw: submitting them to gerrit?
[20:18:51] <JeroenDeDauw>	 aude: already merged
[20:19:47] <aude>	 ok
[20:21:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove some clutter from EntityDataRequestHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102722 (owner: 10Hoo man)
[20:21:34] <grrrit-wm>	 (03PS5) 10Aude: Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 
[20:21:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 (owner: 10Aude)
[20:23:46] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: Display qualifiers in non-JavaScript UI (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102643 (owner: 10Henning Snater)
[20:24:32] <grrrit-wm>	 (03PS6) 10Aude: Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 
[20:40:25] <grrrit-wm>	 (03PS1) 10Aude: re-enable api tests in travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102754 
[20:40:41] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1452 (master - b1fbe6a : jeroendedauw): The build is still failing.
[20:40:41] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ab291bfd918a...b1fbe6a24740
[20:40:41] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15729968
[20:43:05] <travis-ci>	 [travis-ci] wmde/DataValuesJavascript#6 (master - 5d5d479 : jeroendedauw): The build is still failing.
[20:43:05] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/DataValuesJavascript/compare/0a3a2332f5da...5d5d479b3e47
[20:43:05] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/DataValuesJavascript/builds/15729471
[20:43:50] <travis-ci>	 [travis-ci] filbertkm/Wikibase#96 (master - 894c00d : Marius Hoch): The build was canceled.
[20:43:51] <travis-ci>	 [travis-ci] Change view : https://github.com/filbertkm/Wikibase/compare/856c3557f637...894c00dc99c9
[20:43:51] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/filbertkm/Wikibase/builds/15730526
[20:44:14] <hoo>	 heh
[20:44:24] <aude>	 damn travis.yml
[20:44:39] * aude  trying not to pollute irc

[20:48:19] <aude>	 https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15729968 excludes api tests
[20:48:28] <aude>	 so it may pass but not conclusive
[20:53:19] <hoo>	 Yeah
[20:53:40] <hoo>	 aude: Shall I merge the commit reenabling the API tests?
[20:53:48] <aude>	 sure
[20:53:58] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] re-enable api tests in travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102754 (owner: 10Aude)
[20:56:48] <aude>	 seems it will take a while for travis to run all the tests
[20:57:32] <aude>	 in other words.... good time to go eat :)
[20:57:55] <hoo>	 aude: heh
[20:58:03] <hoo>	 guten Hunger :D
[20:59:16] <addshore>	 :O
[20:59:25] <aude>	 it's addshore !
[20:59:30] <addshore>	 hallooo
[20:59:46] <travis-ci>	 [travis-ci] filbertkm/Wikibase#97 (eppbuilder - b95bf4c : aude): The build failed.
[20:59:46] <travis-ci>	 [travis-ci] Change view : https://github.com/filbertkm/Wikibase/commit/b95bf4cdc10c
[20:59:46] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/filbertkm/Wikibase/builds/15730822
[20:59:51] <addshore>	 sorry, I have been rather in contactable this past week :P
[20:59:52] <aude>	 damn it
[21:00:19] <grrrit-wm>	 (03CR) 10Hoo man: "Looks saner now (didn't really look at everything, though)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 (owner: 10Aude)
[21:00:38] <aude>	 exited with 255.
[21:00:43] <aude>	 of course
[21:06:30] <grrrit-wm>	 (03PS7) 10Aude: Refactor EntityPerPageBuilder and test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102685 
[21:09:08] <aude>	  Wikibase\Test\TermSqlIndexTest::testGetMatchingPrefixTerms
[21:09:09] <aude>	 Failed asserting that 1 matches expected 2.
[21:09:12] <aude>	 that's a new one
[21:09:48] <hoo>	 ... endless story
[21:10:15] <aude>	 :(
[21:10:20] <aude>	 got that one twice
[21:14:13] <hoo>	 at least it's reproducible then!
[21:16:13] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1455 (master - d5f34c3 : jeroendedauw): The build was fixed.
[21:16:13] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a6a7f5b33725...d5f34c3c7d48
[21:16:13] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15732686
[21:16:21] <aude>	 no api tests
[21:16:54] <hoo>	 woot, we went down two 4 tests?
[21:17:03] <hoo>	 * builds
[21:17:05] <JeroenDeDauw>	 yes
[21:17:11] <JeroenDeDauw>	 Amongst other optimization
[21:17:23] <hoo>	 well, that just hides bogus failures better, IMO
[21:17:25] <JeroenDeDauw>	 A build now takes as long as the longest job, which is sub 3 mins
[21:17:57] <aude>	 wtf https://gerrit.wikimedia.org/r/#/c/102754/
[21:17:58] <aude>	 !
[21:18:30] <hoo>	 ...
[21:19:38] <aude>	 JeroenDeDauw: can these merges please be submitted via gerrit
[21:19:52] <hoo>	 wait... you did force push?
[21:19:54] <aude>	 that we we can see the changes
[21:20:02] <aude>	 more easily
[21:20:23] <JeroenDeDauw>	 aude: gerrit does not support putting branches up for review AFAIK
[21:20:41] <aude>	 yeah it does
[21:20:45] <JeroenDeDauw>	 how?
[21:20:51] <aude>	 we did that with the content handler
[21:20:53] <hoo>	 JeroenDeDauw: Yeah... but you could have uploaded the two(?) relevant patch sets separately
[21:21:15] <JeroenDeDauw>	 aude: by squashing all commits into one? That is not submitting a branch for review, that is submitting a commit for review
[21:21:28] <aude>	 then submit the commits individually
[21:21:55] <JeroenDeDauw>	 aude: are you going to review and merge all commits individually? that is silly
[21:22:02] <JeroenDeDauw>	 Esp if they where already reviewed
[21:22:18] <aude>	 huh
[21:22:33] <aude>	 who reviewed?
[21:23:11] <JeroenDeDauw>	 me, in both cases
[21:23:22] <aude>	 if they are trivial, then easy to review/merge
[21:24:54] <hoo>	 JeroenDeDauw: You killed the travis.sh
[21:25:03] <JeroenDeDauw>	 hoo: indeed
[21:25:30] <hoo>	 ah, I see... we have a build folder now... ok
[21:25:45] <grrrit-wm>	 (03PS1) 10Aude: enable api tests on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102819 
[21:25:56] <hoo>	 aude: New change?
[21:25:58] <aude>	 hoo: ^
[21:25:59] <aude>	 yes
[21:26:06] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] enable api tests on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102819 (owner: 10Aude)
[21:26:09] <hoo>	 k
[21:26:30] <aude>	 https://travis-ci.org/filbertkm/Wikibase/builds/15732029 looks better except the term test
[21:26:38] * aude  go eat for real now :)

[21:26:45] <JeroenDeDauw>	 hoo: aude: now you are undoing a change by danielk btw
[21:26:48] <hoo>	 heh :)
[21:26:50] <JeroenDeDauw>	 No objection though
[21:27:00] <hoo>	 JeroenDeDauw: He did it for testing purposes
[21:27:12] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [V: 032] enable api tests on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102819 (owner: 10Aude)
[21:38:32] <travis-ci>	 [travis-ci] wmde/Wikibase#29 (master - d5f34c3 : jeroendedauw): The build passed.
[21:38:32] <travis-ci>	 [travis-ci] Change view : https://github.com/wmde/Wikibase/compare/a6a7f5b33725...d5f34c3c7d48
[21:38:32] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wmde/Wikibase/builds/15733947
[21:41:39] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1456 (master - 26d352f : aude): The build was broken.
[21:41:39] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/d5f34c3c7d48...26d352f466a5
[21:41:39] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15734060
[21:46:59] <grrrit-wm>	 (03PS13) 10Aaron1011: Use snake_case for methods and variables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 
[21:51:37] <grrrit-wm>	 (03PS14) 10Aaron1011: Use snake_case for methods and variables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 
[21:55:11] <grrrit-wm>	 (03PS1) 10Hoo man: Fix TermIndexTest for all database collations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102822 
[21:55:12] <hoo>	 aude: ^
[23:02:06] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] "yay, tests that depend on config :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102822 (owner: 10Hoo man)
[23:10:50] <Romaine>	 is there a special page to detect statements with an item deleted but still inserted?
[23:11:47] <hoo>	 Romaine: Sadly not, no
[23:12:31] <Romaine>	 I just noticed that the merge function doesn't change the links in statements on other items when two items are merged
[23:13:11] <hoo>	 That's true, this has to be done by hand (or using a bot)
[23:13:20] <Romaine>	 if users know about it
[23:13:30] <Romaine>	 it was a hell of a job to search for those in my last merges
[23:13:57] <Romaine>	 I can only conclude that Wikidata is far from ready
[23:14:50] <hoo>	 of course... we're a big work in progress ;)
[23:14:57] <Romaine>	 also the Commons implementation is done half
[23:15:09] <hoo>	 Yes
[23:15:14] <Romaine>	 perhaps my expectations are too high 
[23:15:19] <hoo>	 that actually reminds me that I wanted to test stuff on commons :P
[23:15:19] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1457 (master - 1e4add9 : Marius Hoch): The build is still failing.
[23:15:19] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/26d352f466a5...1e4add9690ba
[23:15:19] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15739234
[23:16:56] <hoo>	 Romaine: Well, as told Wikidata is far from being "finished"... but we're constantly improving
[23:19:00] <Romaine>	 perhaps it is me, I would consider moving links and the Commonscat a basic thing
[23:19:11] <Romaine>	 completion I do not expect
[23:19:55] <Romaine>	 so please continue, I really like the developments
[23:20:19] <hoo>	 aude: Around? ;)
[23:23:04] <aude>	 back
[23:24:05] <hoo>	 aude: :) Jeroen merged the TermIndexTest patch already
[23:24:30] <aude>	 :)
[23:25:27] <hoo>	 aude: only API failures left for me
[23:26:22] <aude>	 hmmm https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/15739237
[23:26:28] <aude>	 EditEntity... not the api one
[23:27:00] <grrrit-wm>	 (03PS1) 10Hoo man: Remove hard coded item id from ContentRetrieverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102843 
[23:27:26] <hoo>	 not sure that fixes anything, I'm just killing hard coded ids now
[23:27:41] <aude>	 k
[23:28:03] <hoo>	 and at some point that will probably help
[23:30:01] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Remove hard coded item id from ContentRetrieverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102843 (owner: 10Hoo man)
[23:32:07] <aude>	  Wikibase\Test\TermSqlIndexTest::testGetMatchingPrefixTerms
[23:32:12] <aude>	 still a problem
[23:32:22] <hoo>	 still the same?
[23:32:54] <hoo>	 then the config. value probably doesn't match the reality on travis
[23:33:39] <travis-ci>	 [travis-ci] filbertkm/Wikibase#100 (master - 1e4add9 : Marius Hoch): The build failed.
[23:33:39] <travis-ci>	 [travis-ci] Change view : https://github.com/filbertkm/Wikibase/compare/894c00dc99c9...1e4add9690ba
[23:33:39] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/filbertkm/Wikibase/builds/15740286
[23:34:10] <grrrit-wm>	 (03Abandoned) 10Jeroen De Dauw: re-enable api tests in travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102754 (owner: 10Aude)
[23:34:59] <hoo>	 SetSiteLinkTest ... goodness.... yikes
[23:35:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove hard coded item id from ContentRetrieverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102843 (owner: 10Hoo man)
[23:35:30] * JeroenDeDauw  opens SetSiteLinkTest to see the thing that can probably not be unseen

[23:35:48] <hoo>	 JeroenDeDauw: Don't if you want to sleep tonight
[23:35:54] <hoo>	 $GA = new ItemId( "Q42" );
[23:35:54] <hoo>	 		$FA = new ItemId( "Q149" );
[23:36:01] <JeroenDeDauw>	 arrrrrrr... my eyes!!
[23:36:45] <JeroenDeDauw>	 I'll just delete the file on my local box to rassur myself
[23:37:00] <JeroenDeDauw>	 rm -rf Wikibase/
[23:37:20] <JeroenDeDauw>	 cd ../.. ; rm -rf phase3
[23:37:23] <hoo>	 no mercy!
[23:40:29] <Romaine>	 I also miss a tool to easy select a group of pages on a wiki and check/show a certain parameter added on Wikidata etc
[23:45:41] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1458 (master - 088a0cd : Marius Hoch): The build was fixed.
[23:45:41] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/1e4add9690ba...088a0cd857f0
[23:45:41] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15740809
[23:45:47] <aude>	 \o/
[23:45:52] <hoo>	 wooot?
[23:46:33] <aude>	 lucky :)
[23:46:38] <hoo>	 probably
[23:53:13] <jem->	 Any clue about how to get translated the "Cannot auto-describe" from the search results in the Wikipedias?