[11:09:57] (03CR) 10Jens Ohlig: [C: 031] "Looks very good, thanks Aude! If I understand https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual correctly, we will n" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101649 (owner: 10Aude) [11:13:43] (03CR) 10Aude: "yes, we should add Scribunto in Jenkins so all the tests run" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101649 (owner: 10Aude) [11:14:11] Lydia_WMDE: soon? or shall we have a brief meeting with tobi first? [11:14:33] DanielK_WMDE: let's do quick meeting with Tobi_WMDE and then eat [11:14:37] now? [11:15:03] 5 minutes, i'd like to finish this follow-up [11:15:08] k [11:15:58] Lydia_WMDE: I've a meeting with zeljko from 1230-1330 [11:16:34] (03CR) 10Jens Ohlig: [C: 031] "Once mw.html is through review, this should be merged." [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/101882 (owner: 10Hoo man) [11:16:56] Lydia_WMDE: so either we are really quick, or we eat first and talk to tobi later? [11:17:51] (03CR) 10Aude: "https://gerrit.wikimedia.org/r/#/c/102109/ adds Scribunto for jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101649 (owner: 10Aude) [11:21:37] (03CR) 10Daniel Kinzler: (bug 58342) Inject TermBox when viewing (0314 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101064 (owner: 10Daniel Kinzler) [11:22:15] (03PS5) 10Daniel Kinzler: (bug 58342) Inject TermBox when viewing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101064 [11:24:43] zeljkof: could be a few minutes late [11:25:12] Tobi_WMDE: no problem [11:25:19] ping me when you are ready [11:34:41] is there a good example for an infobox that uses wikidata data? [11:48:05] (03Restored) 10Zfilipin: Changed Alias to use snake case [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [11:50:19] (03PS2) 10Zfilipin: Changed Alias to use snake case [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [11:51:08] (03CR) 10Zfilipin: "Rebased commit." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [11:51:46] (03PS3) 10Zfilipin: Changed Alias to use snake case [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [11:52:48] (03CR) 10Zfilipin: "Removed files that are out of scope for this Google Code-in task." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [11:54:00] (03Abandoned) 10Zfilipin: Use snake_case in Aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101054 (owner: 10Aaron1011) [12:04:00] (03CR) 10Zfilipin: "See one inline comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [12:09:26] (03CR) 10Zfilipin: [C: 04-1] Changed Alias to use snake case (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [12:18:38] (03CR) 10Tobias Gritschacher: [C: 04-1] "See my comment how to solve the problem with the require statement." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [12:26:38] Tobi_WMDE: around? [12:28:08] anyone have any idea what caused this? http://i.imgur.com/hBHeGSI.png purging fixed it, but it's very odd [12:43:20] (03PS4) 10Aaron1011: Changed Alias to use snake case [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 [12:47:27] (03PS1) 10Aaron1011: Changed aliasesTitle to aliases_title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102123 [12:47:28] (03PS1) 10Aaron1011: Rename add_aliases method to populate_aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102124 [12:49:12] (03Abandoned) 10Aaron1011: Changed aliasesTitle to aliases_title [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102123 (owner: 10Aaron1011) [12:52:22] (03PS5) 10Aaron1011: Changed Alias to use snake case [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 [12:54:11] (03CR) 10Aaron1011: "When I'm changing the other files to use snake_case, should I do it from the same branch?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [13:02:40] (03CR) 10Zfilipin: "Yes, I would suggest that you amend this commit when changing other files. Let us know if you need help with that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [13:18:28] (03CR) 10Aude: [C: 04-1] "see comment" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 (owner: 10Daniel Kinzler) [13:44:34] addshore: still around ? :-) [13:58:34] (03CR) 10Hoo man: [C: 032] "Should be safe (tested previously). Two +1 on my amend are a pretty clear sign :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101649 (owner: 10Aude) [13:59:16] \o/ [14:02:11] (03Merged) 10jenkins-bot: Add tests for scribunto integration and implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101649 (owner: 10Aude) [14:10:21] Pink|away: why bother with templates ? [14:20:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1436 (master - c497278 : jenkins-bot): The build is still failing. [14:20:31] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/614e136db456...c49727842fd8 [14:20:31] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15585744 [15:05:09] JeroenDeDauw: Hi! Could you have a look to https://github.com/wmde/WikibaseDataModelSerialization/pull/2 , please? It creates a basic framework for Serializer and Deserializer unit tests [15:09:03] (03PS10) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [15:36:37] hi [15:36:55] shouldn't this be split up: https://www.wikidata.org/wiki/Q20899 [15:37:03] in Podcast and Podcasting? [15:38:24] 'instance of podcasting' means something else than 'instance of podcast' [15:40:44] shisma: if there is use for both, it should be split [15:40:58] there's definitly use for "Podcast" as a class. What's the use of "podcasting"? [15:42:02] (03PS5) 10Daniel Kinzler: (bug 58344) use getUserLang for EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 [15:42:27] at least some of the articles are explicitly about podcasting [15:42:41] oh, the wikipedia articles [15:42:50] right... nasty :) [15:43:12] shisma: i'd ask on https://www.wikidata.org/wiki/Wikidata:Interwiki_conflicts [15:43:27] this isn't technically a conflict, rather a mismatch [15:43:28] but still [15:51:03] (03PS6) 10Daniel Kinzler: Refactor SqlStore::doSchemaUpdates. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 [15:53:13] (03CR) 10Aude: [C: 031] "looks good although i still would like to manually verify the update paths on mysql + sqlite (someone else is welcome to do so, of course)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 (owner: 10Daniel Kinzler) [16:07:44] DanielK_WMDE: import-error-bad-location ... isn't that new? [16:08:29] aude: uh... duh. i forget about that, i was just thinking of the two messages i just fixed! ugh. [16:08:49] i can't look at the diffs in gerrit, the files are too big :/ [16:09:01] easy to forget the messages.inc file [16:11:16] (03PS1) 10Aude: Eliminate need to create pages in ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 [16:11:38] (03PS6) 10Daniel Kinzler: (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [16:12:46] (03CR) 10Tobias Gritschacher: [C: 04-1] "This patch depends on an abandoned patch and cannot be merged because of that. I would suggest to make the changes directly in https://ger" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102124 (owner: 10Aaron1011) [16:13:45] (03PS2) 10Aude: Eliminate need to create pages in ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 [16:17:01] (03PS3) 10Aude: Eliminate need to create pages in ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 [16:19:37] where is jenkins? [16:20:29] looks like it's being restarted [16:21:32] aude: oO does that fix the failures? [16:21:39] i think it fixes some of them [16:21:47] will test [16:21:47] property info builder thing [16:21:55] * aude testing on travis :) [16:22:07] how do you test on travis? [16:22:08] still getting api issues though [16:22:20] * aude forked wikibase and is doing pull requests  [16:22:27] "forked" [16:22:57] waiting on --group Wikibase --exclude WikibaseAPI for my patch [16:23:05] see if we can isolate the issues [16:23:11] I'm more comfortable with my private VM, though [16:23:17] * aude nods [16:28:18] aude: Shall I test on MySQL or SQLite ... or both? [16:28:28] either / both [16:28:33] both, ok [16:29:05] johl: want? http://lua-users.org/wiki/FunctionalLibrary [16:30:05] (03CR) 10jenkins-bot: [V: 04-1] Refactor SqlStore::doSchemaUpdates. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 (owner: 10Daniel Kinzler) [16:33:02] aude: Let's see... started both suites :) ... do we have a patch for Scribunto on Travis yet, btw? [16:33:50] no scribunto on travis yet but https://gerrit.wikimedia.org/r/#/c/102109/ for jenkins [16:34:06] Is manually cloning it an option? My (modified) travis script uses git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Scribunto.git --depth 1 in $IP/extensions [16:35:14] k [16:36:15] aude: I can patch the travis one easily... if git clone is an option [16:37:23] composer would probably be nicer, but I'm not into that at all [16:38:05] go ahead [16:39:56] (03PS1) 10Hoo man: Install Scribunto on Travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102168 [16:40:09] DanielK_WMDE: now? ;) [16:40:28] aude: "OK, but incomplete or skipped tests!" \o/ [16:40:31] SQLite, that is [16:40:45] yay [16:40:45] mh, MariaDB fails :/ [16:40:55] * aude can't imagine my patch fixes the api tests, though [16:41:12] 1) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #0 (array(), array(), array(array('foo', 'foo', true), array('bar', 'bar', true), array('foo', 'Foo', true), array('bar', 'Bar', true))) [16:41:12] array ( [16:41:12] 0 => [16:41:12] array ( [16:41:12] 0 => 'edit-already-exists', [16:41:13] ), [16:41:13] ) [16:41:21] what i got on travis [16:41:26] sorry for the long paste... didn't look this much :P [16:42:24] https://travis-ci.org/filbertkm/Wikibase/builds/15592069 excludes api [16:42:36] (03CR) 10jenkins-bot: [V: 04-1] Eliminate need to create pages in ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 (owner: 10Aude) [16:42:47] https://travis-ci.org/filbertkm/Wikibase/builds/15590570 has api tests and same thing you got [16:43:19] * aude assumes jenkins is complaining because it got restarted [16:43:47] (03CR) 10jenkins-bot: [V: 04-1] (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 (owner: 10Daniel Kinzler) [16:44:50] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Install Scribunto on Travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102168 (owner: 10Hoo man) [16:45:00] (03CR) 10jenkins-bot: [V: 04-1] Eliminate need to create pages in ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 (owner: 10Aude) [16:46:19] (03CR) 10Hoo man: [C: 032] "Looks good, doesn't cause any regressions" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 (owner: 10Aude) [16:46:31] :) [16:47:57] Is jenkins good again, or shall I merge per hand? I mean, I ran the tests for both SQLite and MariaDb anyway [16:48:30] (03CR) 10jenkins-bot: [V: 04-1] Eliminate need to create pages in ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 (owner: 10Aude) [16:48:36] * aude verified myself and on travis [16:48:44] jenkins is broken at the moment :( [16:49:39] (03CR) 10Hoo man: [V: 032] Eliminate need to create pages in ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102165 (owner: 10Aude) [16:49:43] mh :/ [16:50:48] (03CR) 10Tobias Gritschacher: [C: 04-1] "Looks better already, you're improving!" (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [16:54:46] (03CR) 10Daniel Kinzler: [C: 04-1] Implementation of snakformatted property table in Lua (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101201 (owner: 10Jens Ohlig) [16:55:59] (03CR) 10Daniel Kinzler: [C: 04-1] Add mw.wikibase.formattedPropertyValues as a Lua function (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 (owner: 10Jens Ohlig) [16:57:41] (03CR) 10Daniel Kinzler: Implementation of snakformatted property table in Lua (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101201 (owner: 10Jens Ohlig) [17:04:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1437 (master - 90abfc9 : Marius Hoch): The build is still failing. [17:04:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c49727842fd8...90abfc9d13f3 [17:04:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15594470 [17:17:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1438 (master - a54d149 : Hoo man): The build is still failing. [17:17:34] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/90abfc9d13f3...a54d149ad718 [17:17:34] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15594670 [17:49:00] jo [17:49:02] hi [17:49:11] i can't use wikidate with firefox [17:49:17] Tobi_WMDE: check, now has test coverage % for each commit on Scrutinizer: https://scrutinizer-ci.com/g/DataValues/Common/inspections/d6377d8c-ebcc-45e1-8cea-f387039b44da [17:49:24] is this issue known? [17:49:36] i mean it hangs every time i switch the tab [17:51:07] "i switch the tab" is wrong, i mean i can't simply navigate in wikidata.. if an object is complex, my firefox hangs [17:51:15] m0n0g0n: yes, https://bugzilla.wikimedia.org/show_bug.cgi?id=54098 [17:51:18] "script not responding" [17:51:24] thx [18:02:17] DanielK_WMDE: http://pastebin.com/qE5dEC7c hmmm [18:35:56] Lydia_WMDE: Tobi_WMDE : the abraham is not dropping by [18:36:26] JeroenDeDauw: let's sit down together now then? [18:36:36] he comes tomorrow? [18:38:05] the joy of coding on cologneblue :) [18:38:18] oO [18:38:40] make the edit / add links work with my new hook [18:38:47] Lydia_WMDE: magic! http://lsarabia.minus.com/ljCBM2h1of0vE [18:39:25] (03CR) 10Daniel Kinzler: [C: 04-1] "Factoring the generation of the config variables into a separate class seems like a good move. But if you are already touching all that, m" (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101791 (owner: 10Aude) [18:39:29] -rw-------. 1 root root 14G Nov 20 02:27 wireshark_pcapng_usbmon1_20131120021609_2dnWQk [18:39:42] oh... so taht filed up my hdd [18:39:50] huh? [18:39:51] hoo: hehehe :) [18:43:43] (03CR) 10Daniel Kinzler: [C: 032] Improve NamespaceChecker test and class usage in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101669 (owner: 10Aude) [18:46:57] (03CR) 10Daniel Kinzler: [C: 031] "Looks good, but I'd like to see the follow up for using this to construct the JS config wars take shape." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [18:48:27] (03CR) 10Daniel Kinzler: [C: 032] Add test cases for RepoLinkerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101668 (owner: 10Aude) [18:49:14] (03Merged) 10jenkins-bot: Improve NamespaceChecker test and class usage in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101669 (owner: 10Aude) [18:49:29] (03CR) 10Daniel Kinzler: [C: 032] Improve test coverage for WikibaseClient factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101664 (owner: 10Aude) [18:50:25] (03PS7) 10Daniel Kinzler: Refactor SqlStore::doSchemaUpdates. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100361 [18:50:52] (03PS7) 10Daniel Kinzler: (bug 40157) store entity status in page_props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99385 [18:50:58] huh, cologne blue shows language links twice [18:51:13] oh really? [18:51:22] yeah, apparently [18:51:46] aude: what, even without wikivase? [18:51:56] oh. wikivase. new project idea. [18:52:01] hah [18:52:18] :D Could be a browser game... [18:52:22] * aude figuring out why there is add links twice [18:52:34] we already had someone say wikidate today... a dating platform... [18:53:09] that probably also causes weirdnesses within my client JS... -.- [18:53:48] what, the dating platform? [18:53:49] (03Merged) 10jenkins-bot: Add test cases for RepoLinkerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101668 (owner: 10Aude) [18:53:57] hoo: probably not too weird [18:54:18] it shows them in the top right adn then in the footer [18:54:22] mh... you might be able to open it twice which will then go crazy about ids [18:54:58] DanielK_WMDE: Wikidate... could be our next thing... using Wikibase for partner matching? :D [18:55:18] wbcupid [18:56:59] mh :D [18:57:34] (03Merged) 10jenkins-bot: Improve test coverage for WikibaseClient factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101664 (owner: 10Aude) [19:01:21] DanielK_WMDE: would be great if you could take a look at https://meta.wikimedia.org/wiki/Wikidata/Development/Entity_redirect_after_merge [19:01:23] mainly quoting your mail in the techical notes section but a bit more structured [19:07:14] benestar: oh, great! can you send a link to that page to the list, in reply to my mail? [19:07:21] i have added some points to the table [19:07:29] ok, I will write the mail [19:07:46] i should probably re-read it a few times, and try to include all the different aspects and issues that i have come across so far [19:07:50] thanks! [19:08:36] benestar: oh, btw: undoing a redirect should Just Work (tm), at least for #1 and #2 and probably #4. [19:08:57] Case #3 is nasty because it weould require a diff between two different kinds of Content [19:09:31] I personally tend towards solution #2 currently, especially since I plan to greatly reduce the use of EntityContent in our code base [19:09:51] so it wouldn't be many places that would have to deal with the redirect case. [19:10:12] DanielK_WMDE: I also agree that we should prefer #2 [19:10:31] maybe #4 but I am not sure if this is a reasonable change to the code base for this "little" feature [19:17:22] Tobi_WMDE: i forgot to check during the meeting but is https://wikimedia.mingle.thoughtworks.com/projects/scrum_of_scrums/cards/59 still blocked? [19:17:39] Lydia_WMDE: ^ [19:18:22] awjr: if you or jon could review https://gerrit.wikimedia.org/r/#/c/101895/ that would be helpful [19:18:52] aude: Max might be a good candidate too [19:18:54] to make our "edit link" not interfere with mobile [19:18:55] ok [19:19:03] aude: unfortunately i am slammed, but i've added jon and max to the list :) [19:19:08] thanks [19:19:20] :) [19:19:25] i don't see a solution without modifying core [19:19:32] sooner this is solved, the better :) [19:19:46] js is not a solution for this, btw [19:20:53] that's interesting aude - is this something that will likely affect MobileFrontend? [19:20:59] at quick glance it looks like it might [19:21:02] yes [19:21:09] ok [19:21:24] jon would be happy if this got resolved [19:21:26] aude would you mind sending an email to mobile-tech@? [19:21:31] totally [19:21:40] mobile-tech? [19:21:44] * aude wonder if i'm on that [19:21:57] it's our team's mailing list, but anyone with a wikimedia.org address can post [19:22:18] hmmm, then you have to approve me [19:22:23] oh [19:22:26] oh right [19:22:35] are you on mobile-l? [19:22:40] yep [19:22:41] or even better! [19:22:43] wikitech :) [19:22:45] * aude can send there [19:23:07] yeah if you sendt o wikitech it will likely get more eyes and i can point max and jon to it [19:27:12] sent [19:27:34] awjr: ^ [19:27:39] cool! [19:28:00] hopefully no trolling :) [19:29:27] DanielK_WMDE: you said you plan to reduce the use of EntityContent in the code base [19:29:49] when are you going to do this? should this be done before implementing the redirects? [19:30:21] awjr: not done yet, yeah [19:30:22] benestar: i'm getting the feeling that yes, that should be done first [19:30:36] it has been on my "do this when there is time" for like a year now... i hope i can do it soon :) [19:30:51] i think we are getting to a point where this is becoming urgent. [19:30:53] DanielK_WMDE: rofl @ gif [19:31:01] hehe :P [19:31:27] DanielK_WMDE: and when do you plan to decide the redirect discussion? [19:31:41] in january. [19:31:43] I think most of us are in favour of #2 [19:31:46] ok :) [19:32:16] Lydia_WMDE: ok are you guys still waiting for response from ops? [19:32:31] i know they have their hands full at the moment with the data center search [19:32:59] awjr: yeah - but i didn't get around to sending that other email so stil waiting for reply on my second email on that topic [19:33:07] that one would have been the third [19:33:31] sheesh [19:33:58] Lydia_WMDE: when i mail out notes i'll highlight that as still stuck [19:34:13] awjr: heh yeah - i understand of course that they are busy and all [19:34:15] thank you! [19:34:19] :) [19:38:56] (03PS11) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [19:43:21] (03PS12) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [20:28:25] (03PS12) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [20:44:20] (03PS1) 10Daniel Kinzler: Fix interface documentation for EntityIdParser [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/102296 [20:44:31] JeroenDeDauw: really quick one [20:44:32] --^ [20:45:32] (03PS13) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [20:46:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [20:48:38] Tobi_WMDE: hehe, compared to this we are perhaps not doing so bad? https://travis-ci.org/wikimedia/limn/builds :D [20:49:18] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Fix interface documentation for EntityIdParser [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/102296 (owner: 10Daniel Kinzler) [20:53:30] (03PS1) 10Daniel Kinzler: Use correct EntityIdParser interface and implementations. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102301 [20:54:35] \o/ killed 100 lines! [20:55:32] \o/ [20:55:49] We should have a leaderboard for # lines killed [20:56:08] (that is, lines killed, without breaking things) [20:56:13] (03PS14) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [20:56:19] i guess i should just stop implementing features then :) [20:56:42] xD [20:57:21] DanielK_WMDE: please to sync the fork by clicking the big green button: https://github.com/wmde/WikibaseDataModel/pull/2 [21:01:24] (03CR) 10jenkins-bot: [V: 04-1] Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [21:01:32] yes, I know :P [21:02:00] JeroenDeDauw: done [21:07:22] DanielK_WMDE: https://github.com/wmde/WikibaseDataModel/compare/0.5...master#files_bucket [21:10:13] addshore: around? [21:11:36] maybe also some other dev can help? [21:11:50] at the MergeChangeOps, exceptions are thrown when a conflict is detected [21:12:02] however, this exceptions use hardcoded strings as messages [21:12:21] so they are kind of useless when showing a message in a special page [21:12:43] (03PS15) 10Bene: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 [21:12:48] DanielK_WMDE, JeroenDeDauw --^ [21:17:09] (03CR) 10jenkins-bot: [V: 04-1] Use correct EntityIdParser interface and implementations. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102301 (owner: 10Daniel Kinzler) [21:29:15] JeroenDeDauw: http://brightbyte.de/page/Git_CR [21:30:33] benestar: yea... best invent a new exception with specific error codes. [21:30:59] could be used as message keys directly, with parameters [21:31:11] really create a new exception class? [21:31:24] ErrorPageError is actually a bit like that, but the exception *type* shouldn't be bound to how it gets displayed [21:31:30] so, at the very least, create a subclass of that [21:31:32] does ChangeOpException not support that? [21:31:41] i didn't look [21:32:23] the API's UsageException is a bit like that, actually [21:32:56] A general purpose exception class that uses string error codes and parameters, plus maybe a plain mesage, would be quite nice to have [21:33:05] (03CR) 10Bene: "Ok, I fixed the design issues in the code. However, I still get the "Your edit was ignored because no change was made to the text." error " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [21:33:10] the error codes could be, or be mapped to, message keys, for meaningful display [21:34:27] DanielK_WMDE: does that mean to create a ChangeOpMergeException ? [21:36:19] benestar: well, the type of the exception should indicate the kind of failure, so i'd probably just call it "MergeException". It could be based on a generic ExceptionWithKessageKey (with a nicer name), though subclassing isn't the best choice to achieve that. [21:36:34] maybe JeroenDeDauw has a nice idea for modelling the exception in a both machine- and human readable way :) [21:36:45] would be great [21:36:46] anyway, i need to get out of this office before i go mad [21:36:53] so, bye for now [21:36:59] however, merges are strongly related to change ops [21:37:02] ok, cu [21:37:04] bye [21:38:54] (03PS8) 10Bene: (bug 56693) special page for setting sitelinks to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 [21:38:58] benestar: as soon as I stopped bothering them (devs), you started :p [21:39:08] lazowik: xD [21:39:21] lazowik: what are you currently working on? [21:39:27] nothing :p [21:39:30] :P [21:39:47] then we'd be both bothering the team :p [21:40:01] (that's not the reason for me to not to do sth though) [22:08:56] (03PS9) 10Bene: (bug 56693) special page for setting sitelinks to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 [22:16:56] (03PS6) 10Aaron1011: Use snake case [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 [22:27:39] ^d: I'm trying to imagine the reaction if I send a mail with "Why not use Composer?" to the engineering list as reply to that last thread ;p [22:34:03] (03CR) 10Jeroen De Dauw: "Looks good in general. Did not spot any real issues. Please do fix the incorrect @since tags though" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/102301 (owner: 10Daniel Kinzler) [22:48:45] Hello all…is there a property to record previous/historical names? [22:49:58] I’d have thought 'name', but there doesn’t appear to be such a property. [22:51:10] hawke_: you probably want to add it as an alias at the top [22:51:15] look for "also known as" [22:52:46] Lydia_WMDE: Hmm, not sure that’s what I want: it implies that something is still called that (not necessarily the case), and doesn’t give any parameters about date [22:53:46] Example: https://en.wikipedia.org/wiki/Amherst_Junction,_Wisconsin [22:53:55] “Until 1875, the community was referred to as Groversburg” [22:54:02] not called that now, and not for a long time. [22:54:14] hello, somebody? [22:55:00] I would expect alias / AKA to be more for search hints than for historical names [22:55:30] Hi, Fevalentim. [22:57:19] hi [22:57:28] where u from ? [22:57:41] hawke_: but an old name can also be a search hint, no :) [22:58:26] Lydia_WMDE: Sure — I would have no problem also adding it as an alias, but without a date qualification it seems not so good. [22:58:47] Certainly not very useful in that case (no one is likely to be searching for Groversburg) [22:58:56] fair enough [22:59:15] mono-lingual text datatype will be needed for that [22:59:17] not done yet [22:59:34] and then you can also add qualifiers and so on [23:00:10] “mono-lingual text datatype”? [23:00:27] meaning that there’s no need to translate “Groversburg”? [23:00:36] yeah [23:01:14] Hmm…aren’t community names frequently translated though? e.g. Munich/München [23:02:58] hmm fair enough - then you'd need the multi-lingual text datatype [23:03:01] also not done yet though [23:03:04] Also…yeah. :-D [23:04:20] “Language” doesn’t quite seem like the right term for that, but…anyway, thanks for the advice. [23:04:35] * nikki wonders how something like that would work with the main label [23:04:56] would it involve duplicating it in order to add a date? or would it be smarter than that? [23:05:40] (I mean, “Tokyo” isn’t exactly English…even though that’s how the city is written in when referenced in English) [23:06:04] nikki: I feel Musicbrainz aliases all over again. :-) [23:06:17] there's a reason I asked :P [23:44:35] a User:Poulpy is severely flooding the Recent Changes. would a short block be appropriate in this case? [23:46:04] äh no? [23:48:38] looks like an unflagged bot being run from the user's main account [23:49:08] omg he edits [23:49:21] on wikidata, where there are 5 billion edits per minute! [23:50:11] ordinarily, bots have the bot flag set, so that they don't flood the RC [23:50:27] which makes it suuurely much more usable [23:50:42] this user has done ~1000 edits over the past 20 minutes, all without the bot flag [23:51:08] seems a bit fast [23:51:12] yes, it certainly does make it far more usable [23:51:41] blocked [23:51:51] o_O [23:51:58] okay … [23:52:27] Charleston: wie beurteilens' dies? [23:52:40] my issue is more the unapproved bot rather than the flooding [23:52:42] ich hätt dem ne TP-Nachricht hinterlassen [23:53:05] und vlt. noch nen flood-flag uffjedrückt bissas kapiert [23:53:26] aber block isja besser, weniger nützliche edits! [23:53:53] *seufz* [23:54:07] klärchen [23:54:21] un' ook die heiliche A-Probung! [23:56:06] naja; muss jeder selbst wissen wie er die Mitarbeiter vergrault [23:58:26] ja [23:58:39] kann ja nich jeda so jut suptil wie wiä