[01:00:43] @trusted [01:00:43] I trust: .*@wikimedia/IWorld (2admin), .*@wikimedia/DangSunM (2admin), .*@quassel\.jefferai\.org (2admin), .*@unaffiliated/jeroendedauw (2admin), .*@wikipedia/Liangent (2trusted), .*@wikimedia/Vogone (2admin), .*@wikipedia/rschen7754 (2admin), .*@wikimedia/Hym411 (2admin), [01:01:14] please don't do that too often, it pings all those people on the list [01:01:22] ok [01:01:54] * DangSunM|cloud suggests in @info page there are trusted list [06:43:53] any update on the performance problems ? [06:44:11] the Widar tool has been put off line, but it does not help [06:45:46] as in editing to change the order of statements is still timing out on my modern pc [09:01:00] (03CR) 10Tobias Gritschacher: [C: 04-1] Migrate simple RSpec browser tests to Cucumber. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [09:30:34] update on oauth ... the tool itself is broken at the moment [09:31:07] this is the hello world app for oauth.. https://tools.wmflabs.org/oauth-hello-world/index.php?action=edit [09:36:20] aude: are you coming in today? :) [09:36:39] aude: addshore: JeroenDeDauw: can one of you please answer https://gerrit.wikimedia.org/r/#/c/95996/ asap? thanks! [09:52:38] is there any progress in performance improvement? [10:07:00] Lydia_WMDE: ^ [10:15:31] Lydia_WMDE: hi, with sorting you mean the sorting of facts? [10:15:54] in a call [10:16:00] jorn: ordering - yes [10:17:20] jorn: why? [10:17:35] lbenedix: still working on it [10:18:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [10:32:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [10:46:13] Lydia_WMDE: done [10:46:23] addshore: thanks :) [10:50:08] addshore: do we have any clue about the still badly failing tests on travis? [10:50:23] thye might be fixed now [10:50:29] again :P# [10:50:43] addshore: ähm.. after what change? [10:50:59] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds [10:51:17] https://gerrit.wikimedia.org/r/#/c/100905/ [10:51:33] heh, okay, still not fixed :P [10:55:06] addshore: the only solution is to not use hardcoded entityids in the tests. nowhere. [10:55:32] I guess. at least I hope that would fix it. [10:57:01] Nice! https://www.mediawiki.org/wiki/Talk:Flow [10:57:21] :O [11:00:43] addshore: are you a steward in orain [11:06:31] Jianhui67: yus [11:44:30] (03CR) 10Addshore: "Selenium tests? :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [11:51:11] Lydia_WMDE: i am at home again [11:55:13] * aude might come tomorrow [11:59:55] aude: ok no problem [12:13:42] ContextSource just got even less well seggregated o_O [12:14:21] :O [12:15:10] Tobi_WMDE: http://xkcd.com/378/ [12:19:53] addshore: https://gerrit.wikimedia.org/r/#/c/95996/ hehe, no shit sherlock :) [12:20:24] haha JeroenDeDauw xD I have no idea what Reedy means if not that :P [12:20:40] yeah me neither [13:16:14] (03PS2) 10Daniel Kinzler: (bug 58344) use getUserLang for EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 [13:54:29] (03CR) 10Aude: [C: 04-1] "generally looks fine but have some nitpicks" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 (owner: 10Daniel Kinzler) [14:00:52] Lydia_WMDE: sorry for the late reply, Prof walked in with some guests that needed entertainment ^^ [14:01:14] i ask because my PhD is about sorting Linked Data Facts by relevance for humans [14:01:26] jorn: ah interesting [14:01:41] which makes me pretty interested in wikidata ;) [14:02:01] hehe right [14:02:08] sorry - need to go to our daily standup [14:02:52] k, i'll come back later [14:40:58] re [14:43:15] Tobi_WMDE, Henning_WMDE, Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=58393 [14:43:58] thx [14:51:07] (03CR) 10Jeroen De Dauw: [C: 04-1] "This brings EntityView one step closer to being sane, only over9000 more to go :)" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 (owner: 10Daniel Kinzler) [14:58:45] (03CR) 10Aude: (bug 58344) use getUserLang for EntityView (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 (owner: 10Daniel Kinzler) [15:02:22] Lydia_WMDE: DanielK_WMDE_ Tobi_WMDE what's the plan? do we have a "fix" for the js or do we switch sorting/ranks back to experimental? [15:02:44] aude: fix in progress [15:02:49] ok [15:02:50] in testing to be exact [15:02:58] like what? [15:03:01] I still dont understand the ranking [15:03:15] aude: Tobi_WMDE can add you to the review request i believe [15:03:44] link? [15:03:52] don't have one - still draft i think [15:04:11] Tobi is currently talking to Henning [15:04:20] ok [15:04:24] or maybe DanielK_WMDE_ can add you [15:08:30] aude: added you to the draft [15:08:44] I'm still testing it [15:08:46] Wikidata started with the idea of collecting the worlds knowledge. I dont see how rating this knowledge fits into this concept. [15:09:11] if I don't find other major issues with it I'm gonna merge it [15:09:26] (03CR) 10Jeroen De Dauw: (bug 58344) use getUserLang for EntityView (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 (owner: 10Daniel Kinzler) [15:09:32] trolloll..ups [15:09:45] ok [15:10:13] aude: you saw the other fix we should deploy? - the missing JS dependency? [15:12:39] (03CR) 10Aude: (bug 58344) use getUserLang for EntityView (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 (owner: 10Daniel Kinzler) [15:12:52] Lydia_WMDE: yeah [15:12:58] waiting for Reedy :) [15:13:05] cool [15:13:23] https://gerrit.wikimedia.org/r/#/c/100701/ [15:13:49] :) [15:14:03] Tobi_WMDE: thanks [15:30:59] addshore: so, if I want to add a new claim with wbsetclaim, I still have to generate a valid claim-guid locally on my client? [15:31:54] aude: Lydia_WMDE do we still have time until 18:00 for the fix to be merged? [15:32:21] yeah [15:32:24] ok [15:32:57] i'm sure it's just me but i can't save claims with items (array instead of string) [15:33:04] on master [15:46:54] Can someone replace communs by commons ? https://translatewiki.net/wiki/MediaWiki:Wikibase-sitelinks-sitename-commonswiki/fr [15:49:09] !ademin ^ [15:49:14] bah [15:49:16] !admin [15:49:20] :) [15:49:30] anyone with translate rights can [15:49:36] Yes? [15:49:41] oh [15:49:44] this is translatewiki [15:49:45] sorry [15:49:47] thought wikidata [15:49:48] * aude could but i'll let someone else [15:49:59] JFL|cloud: ignore me :P [15:50:02] * JFL|cloud trouts Lydia_WMDE [15:50:05] ;-) [15:50:10] * Lydia_WMDE hands JFL|cloud a cookie [15:50:17] :D [15:53:18] Pyb: done [15:53:22] oh [15:53:27] aude: thx ;) [15:53:28] it will take a few hours probably for it to appear [15:53:38] sorry for being faster Aude [15:53:46] heh [15:53:54] \o/ [16:02:54] addshore: Tobi_WMDE DanielK_WMDE_ am i the only person who can't save claims with wikibase-item values? [16:03:02] on mster [16:03:04] master* [16:03:43] aude: havn't tried... on test? or locally? eitehr? [16:03:50] locally [16:03:57] * aude switches back the branch [16:04:47] aude: for me it's possible. I'm on henning's performance change [16:05:03] also the tests said "yes" :) [16:05:18] (03Draft2) 10Henning Snater: Deferring toolbar controller event handler registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100984 [16:05:25] snak validator gets http://dpaste.com/1501899/ (array) [16:05:35] but it expects string (e.g. 'Q4') [16:05:39] on new items [16:05:45] odd if it's just me [16:06:17] aude: works for me. [16:06:24] but makes it tricky to test henning's patch [16:06:27] ok [16:06:38] * aude will have to trust you :p [16:07:38] Aude: Maybe they created a new feature which blocks all Aude's from adding item values? :p [16:08:14] heh [16:11:14] hmmm, if i create a fresh item property it works [16:11:21] with older property it doesn't work [16:16:33] (03CR) 10Tobias Gritschacher: [C: 032] Deferring toolbar controller event handler registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100984 (owner: 10Henning Snater) [16:17:00] \o/ [16:19:59] (03Merged) 10jenkins-bot: Deferring toolbar controller event handler registration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100984 (owner: 10Henning Snater) [16:20:24] Henning_WMDE: Lydia_WMDE aude DanielK_WMDE_ item with ~100 statements: http://wikidata.beta.wmflabs.org/wiki/Q9072 [16:20:42] fix is merged, but not deployed yet on beta I guess.. [16:22:34] doubt it [16:23:32] where can i learn about the javascript mw.config.get('wbEntityId') ? [16:24:07] jorn: what do you want to learn about it? [16:24:33] Tobi_WMDE: not cherry picked yet? [16:24:33] there's currently no diocumentation for the JS interface. [16:24:57] (03PS1) 10Aude: Deferring toolbar controller event handler registration [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101010 [16:24:58] aude: waiting for beta, so we can play with it [16:25:01] ok [16:25:01] i'm fiddling with commons.js to write a script which does label fallback… i use labelLister.js as example it gets the wbEntityId. [16:25:12] well, there it is when we want to approve [16:25:14] i assume there's something to get "the" label? [16:25:18] * aude play on the branch [16:26:04] aude: it is merged, so it show up on beta in the next minutes, right? [16:26:09] DanielK_WMDE_: essentially i'm trying to check if there already is a label. could do that via the gui checking for the span or input box but thought maybe it's there already [16:26:45] jorn: Henning_WMDE is the person to ask, but I'd guess mw.config.get('wbEntity').labels['en'] should work [16:26:48] Tobi_WMDE: yes [16:26:50] or something very much like that [16:27:04] https://integration.wikimedia.org/ci/job/beta-code-update/ [16:27:08] looks broken perhaps [16:27:58] 16:21:06 Failed to recurse into submodule path 'Elastica' [16:27:59] DanielK_WMDE_: cool, i'll just introspect the js, thanks [16:29:32] jorn: have a look at the label lister gadget as well maybe [16:29:45] DanielK_WMDE_: ouh, wbEntity always gives me the complete json for the current page? [16:30:13] Tobi_WMDE: i am asking about beta / see if we can fix [16:30:27] Lydia_WMDE: i use that as an example… as i mentioned labelLister is cool for listing, but not for quick "one-click-approve" [16:30:35] aude: beta has the new version already [16:30:37] yeah [16:30:43] see http://wikidata.beta.wmflabs.org/wiki/Special:Version [16:31:18] so clear your browser cache and try http://wikidata.beta.wmflabs.org/wiki/Q9072 [16:31:52] ok, maybe it updated despite the problem [16:32:47] DanielK_WMDE: i ask because in the labelLister.js code it seems to request the labels via the api again [16:33:05] Tobi_WMDE: i'd be happier if all the claims were wikibase-item values :) [16:33:10] but ok [16:35:24] jorn: maybe that code isn't very smart :) [16:35:47] DanielK_WMDE: well, i'm a complete noob so i'm asking ;) [16:36:48] Tobi_WMDE: works fine in chrome now, still getting timeouts in FF for large items [16:36:52] Exception Caught: Specified index is out of bounds [16:37:09] not new issue [16:39:25] aude: yes, that's another issue which has been reported already [16:40:42] aude: to test the performance issues it should not matter what values the statements are [16:41:26] Tobi_WMDE: it might, more referenced entities [16:41:58] i think that is generated in entity view (aware of, needs to be in parser cache) [16:42:42] aude: referenced entities is relevant for the tiem the backend needs to generate the page. it doesn't seem to have an impact on JS performance [16:42:49] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1409 (master - 9a8c819 : jenkins-bot): The build is still failing. [16:42:49] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/69676be54424...9a8c81983802 [16:42:49] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15350000 [16:42:49] that seems to be dominated by the number of claims [16:43:09] ok [16:43:20] * aude wsomewhat skeptical but okay [16:43:21] aude: can you please do the cherrypick of the patch [16:43:23] somewhat* [16:43:36] I have another permormance-patch which I have to test [16:43:43] (03CR) 10Aude: [C: 032] Deferring toolbar controller event handler registration [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101010 (owner: 10Aude) [16:43:45] there [16:43:46] still not snappy at all, but usable again [16:43:49] lets get that live [16:43:53] yeah [16:44:00] * Lydia_WMDE bounces [16:44:07] i can work on my store entity in parser output thing [16:44:19] and have entity view use it for all the variables [16:44:38] important to hve parser cache used for that to be effective [16:45:24] aude: i'm messing eith EntityView quite heavily atm. See the patches I have up on gerrit atm, and especially https://bugzilla.wikimedia.org/show_bug.cgi?id=58340 [16:45:35] DanielK_WMDE: i see [16:45:40] you have comments [16:46:09] DanielK_WMDE: should i give up on workign on it? [16:46:33] aude: I plan to get rid of registerJsConfigVars all together, stuff everything into the parser object, and then do the actual registration in OutputPageParserOutput [16:46:54] seems reasonable [16:47:02] (03Merged) 10jenkins-bot: Deferring toolbar controller event handler registration [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101010 (owner: 10Aude) [16:47:19] (03Draft1) 10Henning Snater: Prevent triggering 'change' event in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101015 [16:47:24] aude: it might become redundant, not sure yet. i also don't know when i'll get around to working on this, so your change may be a good first step [16:47:26] should i abandon my stuff or work on it? [16:47:40] my change needs a follow up soon to make use of it [16:48:02] aude: thx! [16:48:09] and cover all tht stuffs [16:48:14] aude: let me look at your change again... [16:48:21] it's old [16:49:05] needs rebase at minimum [16:54:30] (03CR) 10Daniel Kinzler: [C: 04-1] "This change places a serialized version of the entity in the ParserOutput object, and later passes it on to the OutputPage object. registe" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89792 (owner: 10Aude) [16:54:41] aude: i think your change is still viable, see me comment [16:55:11] but if you have other things to do, you can also wait it out - i'll get around to moving all the JSCOnfig stuff to the ParserOutput eventually [16:55:19] i didn't do the second part yet (or abandoned it i think) [16:55:30] it needs a follow up [16:55:37] the second part [16:55:41] ? [16:55:55] to use the stuff in parser output :) [16:56:01] instead of doing it again [16:56:16] ...for registering that as JSConfig? right [16:56:16] in registering js config stuff [16:56:19] yep [16:56:32] can be doen in a follow up, no problem - but then i'd want to see that change on gerrit [16:56:35] small patches, but a follow up to accompany it would be good [16:56:39] * aude too :) [16:59:13] DanielK_WMDE: are you in the office tomorrow? [16:59:19] (03CR) 10Tobias Gritschacher: [C: 032] Prevent triggering 'change' event in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101015 (owner: 10Henning Snater) [17:00:28] Tobi_WMDE: we want that also? [17:00:46] aude: yes [17:00:57] k [17:01:25] that makes moving statements wayy more performant [17:01:44] (03PS1) 10Aude: Prevent triggering 'change' event in claimview [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101017 [17:01:46] in huge items movng statements is currently almost impossible [17:01:53] ok [17:02:02] I hope that was it all [17:02:05] (03CR) 10Aude: [C: 032] Prevent triggering 'change' event in claimview [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101017 (owner: 10Aude) [17:03:10] (03Merged) 10jenkins-bot: Prevent triggering 'change' event in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101015 (owner: 10Henning Snater) [17:07:17] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1410 (mw1.23-wmf6 - be8e569 : Henning Snater): The build has errored. [17:07:17] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/54c0e0cce4f5...be8e569f1b91 [17:07:17] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15351656 [17:07:17] (03Merged) 10jenkins-bot: Prevent triggering 'change' event in claimview [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101017 (owner: 10Aude) [17:32:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1411 (master - 24f67ce : jenkins-bot): The build is still failing. [17:32:47] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/9a8c81983802...24f67ce75032 [17:32:47] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15352888 [17:46:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1412 (mw1.23-wmf6 - db2b67d : Henning Snater): The build has errored. [17:46:47] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/be8e569f1b91...db2b67d8df7d [17:46:47] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15353156 [17:54:55] DanielK_WMDE, ping [17:58:21] DanielK_WMDE, let me know when you are around, I need to figure out how to introduce "title" into the content model [18:07:38] we crossed 25M statements recently [18:19:03] aude: what's the deployment status? [18:26:35] waiting.... [18:26:49] probably have to wait until 8pm :/ [18:27:13] ok [18:28:38] then i will go home now and get back onlione there [18:33:18] ok [18:48:37] aude: i'll be around for another hour or so, but not really following the channel [18:50:39] awww, ok [18:50:55] stop playing computer games :p [18:51:12] errr, wrong daniel :) [19:00:44] aude: the game i'm playing is called "inject the term box into cached HTML". [19:05:00] ok :) [19:06:07] the template(s) should be cached [19:06:32] hm? [19:06:42] * aude wish for something like twig :) [19:07:02] i guess we don't know how many languages a user has (or none) [19:07:16] right [19:07:20] but if the templates required can be cached [19:07:27] or which languages, or in what order [19:07:28] then we can plug in the correct values later [19:08:05] the templates themselves are in APC [19:08:10] a twig template would support if / else / plug in values [19:08:17] ok [19:08:47] we could cache partially expanded templates, and pop in more values. but i don't think template expansion is actually a big problem [19:09:00] i mean henning's templates [19:09:17] especially not since we cut down on that by something like two orders of magnitude by using the parser cache [19:09:21] yea, me too [19:09:23] k [19:09:46] although remember not that many people use these other language boxes [19:10:00] only logged in users, only power useres [19:10:02] users* [19:10:10] yes. we should make it easier to use [19:10:19] if it can have a placeholder of some sort [19:10:23] but in any case, we need a mechanism to put user-specific info into the cached pages [19:10:27] which is what i just wrote [19:10:35] ok [19:10:41] yes, placeholders, expansion with callbacks, all that [19:10:56] i'll push the patch in an hour or so, still need to write tests [19:11:04] ok [19:11:07] fun1 [19:11:10] fun! [19:11:10] :P [19:11:32] * aude waits for ree*dy [19:12:00] it's kind of sille that we need to implement *two* hooks in OutputPage to allow this: one to pass the info from ParserOutput to OutputPage, and *antother* to operate on the HTML based on the placeholder info [19:12:11] quite a few extensions do something like this [19:12:19] there should be a mechanism for this in core [19:12:23] oh, well [19:12:51] aude: we are deploying two backported patches, right? [19:13:29] * aude nods [19:13:44] yes the two patches + stuff from yesterday [19:13:51] ok [19:14:07] mostly will be js go wrong if anything [19:14:13] * aude doubt it [19:14:30] is there a way to get the old JS stuff purged from the web cache? [19:14:50] otherwise, people will be using the old, slow version for a month [19:15:30] it gets a new timestamp [19:15:38] ok [19:15:40] somehow [19:15:53] also it gets cached in localstorage but gets purged the same way [19:29:26] deployed! [19:29:30] DanielK_WMDE: Lydia_WMDE ^ [19:30:09] aude: DanielK_WMDE: haha perfect. i just got in [19:30:11] \o/ [19:30:19] thanks so much folks [19:30:37] might still need to kick caches [19:30:40] loading Q64 in FF [19:30:43] .... [19:31:13] q1 was pretty fast [19:31:17] going for 64 :P [19:31:25] wait, need to purge the browser cache [19:31:47] wooo [19:31:49] that was fast :D [19:32:02] legoktm: well, try it out and let us know if it actually helped :) [19:32:16] yeah, I meant loading Q1 was fast! [19:32:30] we expect ~30 to 50% speed improvement of page initialization 8not loading). [19:32:30] we need to purge the caches [19:32:32] erp [19:32:35] so large items will probably still fail [19:32:39] but most should be usable again [19:32:44] and chrome should work better than FF [19:32:45] Q42 gave an unresponsive script error [19:32:47] makes sure it's refreshed [19:32:49] make* [19:32:55] i cleared my cache too [19:34:51] Lydia_WMDE: try Q42 and Q64 [19:35:16] k [19:36:01] both work for me in chrome, but still fail in FF [19:36:14] * aude tries q64 in firefox [19:36:31] both are big items, but not huge [19:36:47] yeah [19:36:51] so still work to do [19:37:06] still get warnings [19:37:26] http://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131212T032201Z:8 [19:37:30] so it has a new timestamp [19:37:41] Lydia_WMDE: definitly. we really don't want to initialize the widgets for all claims and links on page load. [19:37:48] yeah [19:37:49] but then loads [19:37:55] but to get rid of that, the static html needs to be improved, and the JS refactored. [19:38:00] yeah yep yep [19:38:08] do we yet use the mw.hooks? [19:38:13] i'd say that's the next thing on the list. but not until after the holidays [19:38:15] * aude can work on some of it over chrismas [19:38:24] christmas* since i'm not taking holidays [19:38:28] until january [19:39:46] https://de.wikipedia.org/wiki/Wikipedia:Wikidata/Wikidata_Spielwiese is workign correctly [19:39:59] obviously does not find the english label but finds the german one [19:40:58] :) [19:41:32] https://en.wikipedia.org/wiki/Wikipedia:Wikidata/Wikidata_Sandbox is correct [19:44:05] Lydia_WMDE: so we are okay with the js for now? until after holidays? [19:44:37] aude: i guess so, yeah [19:44:50] assuming people don't start screaming until tomorrow morning [19:44:57] but it looks good atm [19:44:59] ok [19:45:04] we'll continue workign on it [19:45:15] i posted to project chat and mailing list to let people know [19:45:28] along with the "edit links" think in the client, which i'm poking at [19:45:28] so if there are still huge issues we should hear about them [19:45:32] cool [19:45:34] thing* [19:45:45] loading Q42 still takes ~40seconds [19:45:52] did something recently change with the lua integration modules? [19:46:03] lbenedix: yes - we didn't say it was lightning fast now ;-) [19:46:12] its as slow as yesterday [19:46:27] rschen7754: can you be more specific please? [19:46:28] lbenedix: it's hopefully as slow as yesterday before the deployment [19:46:32] i.e. dog slow but usable [19:46:40] not really [19:46:57] the "the javascript is taking forever" warning does not appear [19:47:03] Lydia_WMDE: en.wikipedia had integration for one field from wikidata... and now it's gone... it happened over the last week [19:47:16] lbenedix: so, it's faster now :) [19:47:23] nope [19:47:25] 40seconds [19:47:32] maybe it was 41 yesterday [19:47:40] maybe it was 60 yesterday [19:47:46] i think the warning shows after one minute [19:47:50] rschen7754: hmm shouldn't - can you link me? [19:48:11] https://en.wikipedia.org/wiki/Interstate_805 - the infobox should have a map [19:48:19] can you expllain what the problem is? [19:48:27] or is it some kind of heisenbug? [19:48:35] https://en.wikipedia.org/wiki/Template:Infobox_road is the infobox, looking for the lua part [19:48:49] aha https://en.wikipedia.org/wiki/Module:Infobox_road/map [19:49:13] rschen7754: thx - looking [19:50:14] hm, https://simple.wikipedia.org/wiki/California_State_Route_1 still works (on simple) [19:50:18] rschen7754: the infobox is showing a map for me? [19:50:30] on https://en.wikipedia.org/wiki/Interstate_805 [19:50:36] hm [19:50:49] maybe not a lua issue then? [19:51:05] i've shift-refreshed and purged :S [19:51:11] * Lydia_WMDE does so too [19:51:24] wtf [19:51:26] now it is gone [19:51:37] gone on simple too [19:52:12] huh [19:52:58] fwiw, on firefox, dom.max_script_run_time determins when the warnign will show up (go to about:config to see it) [19:53:16] the default seems to be 10 seconds - but my feelign is the warning doesn't show up that soon... [19:53:17] oh, well [19:53:28] https://oc.wikipedia.org/wiki/Rota_78_de_l%27Estat_de_Calif%C3%B2rnia is broken too, though it never had flawless code [19:53:36] rschen7754: p15 is used for the map? [19:53:37] and that's not displaying anything [19:53:41] Lydia_WMDE: yes [19:53:43] ok [19:53:50] rschen7754: maybe hoo can help, he knows a bit about Lua. [19:54:07] DanielK_WMDE: well, it used to work about 1-2 weeks ago [19:54:44] uh [19:54:44] rschen7754: if hoo can't look at it now we will take a look tomorrow with jens [19:54:47] rschen7754: but he still may be able to pinpoint what the problem might be now. [19:54:54] ok [19:54:59] * aude copies it to tests2 [19:55:01] test2 [19:55:03] will have a look in a minute [19:55:04] i can think of two things, looking at the code - but i *though* we didn't deploy either of thse changes [19:55:30] a) is using upper case ids, so it would have to be claims.P15, not claims.p15 [19:56:05] the other is changing list indexes to start with 1 (the Lua standard) instead of 0 (the PHP standard), so mapProp[0] woudl need to change to mapProp[1]. [19:56:13] but as far as I'm aware, this has *not* been deployed yet [19:56:34] rschen7754: can you try to change that? [19:56:42] DanielK_WMDE: we should not but... [19:56:48] Lydia_WMDE: i'll try on simple.wiki so i don't break enwiki [19:56:52] k [19:57:00] the first one should be safe to change, the second one would break if the change isn't deployed yet [19:57:19] DanielK_WMDE: They're not using Lua [19:57:29] hm?? [19:57:31] but the wikitext parser function AFAIS [19:57:39] (03PS1) 10Aaron1011: Use snake_case in Aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101054 [19:57:40] {{#if:{{#property:p31}}| es un {{Wikidata|31}}}} [19:57:49] hoo: ocwiki? [19:57:51] hoo: but not for the map. https://en.wikipedia.org/wiki/Module:Infobox_road/map [19:57:52] yes they are [19:58:02] https://test2.wikipedia.org/wiki/Module:Infobox_road/map [19:58:12] ah ok, I went into Template:Info [19:58:25] uh.... [19:59:13] https://simple.wikipedia.org/w/index.php?title=Module%3AInfobox_road%2Fmap&diff=4663650&oldid=4440051 didn't resolve it on simple [19:59:41] ok that's good [19:59:49] ok, so this still works: [[Image:{{#property:P15}}]] [19:59:49] because those changes really should not be deployed [19:59:59] Lydia_WMDE: Yep [20:00:16] They've not been backported AFAIK [20:00:48] yeah [20:01:03] oh.. the exact same module locally on two wikis: This just seems so much like a good idea :P [20:01:23] yeah lol [20:01:55] hoo: in debug, do i do "= mw.wikibase.getEntity()" [20:02:02] or more that i need to do? [20:02:29] aude: If you just want the whole thing that's it, yes [20:02:47] (03PS8) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [20:03:01] hmmm [20:03:14] aude: You have to set the current title first [20:04:15] but you're not really ment to override it... [20:04:17] are there other templates that use lua to call wikidata? [20:04:25] if you could, one could access foreign entities, ewk [20:04:36] in the preview as title? [20:05:08] mw.title.getCurrentTitle() [20:05:17] but I doubt you can set that one from Lua, will check [20:05:33] ok [20:05:50] that makes debugging difficult (:/) but also save us from people accessing foreign entities in an uncontrolled manner [20:06:43] Damn, I'd like a IDE that has full support for PHP, JS and Lua :P [20:09:02] it's not finding p15 or P15 [20:09:11] mw.title.setupInterface( { thisTitle: { 0, 'foo' } } ) [20:09:13] it's apparently finding the entity and claims [20:09:17] that might about work... ewk [20:09:19] https://test2.wikipedia.org/wiki/Module:Infobox_road/map [20:09:47] i am getting "no claim p15" [20:11:08] the parser function works [20:11:29] hoo: intellij? [20:12:51] lbenedix: Does it work well with PHP? [20:12:56] jepp [20:13:11] I'm not sure about the community edition [20:14:25] I mainly use it for java and python, but when developing my little extension it worked very well with php and js [20:14:45] mh [20:15:00] I'll have a look sometime... going to stick with NetBeans for now [20:15:20] there's a (crappy) Lua plugin for it [20:16:10] jetbrains hat a 75% off when the world ended last year [20:17:33] mh, that's like phpStorm with more languages [20:17:58] php storm is intellij with only one plugin installed ;) [20:18:02] I liked kdeveloped a lot when I tried it last... but even 4.6 didn't get namespaces right :/ [20:18:18] * kdevelop [20:18:24] they have 80% for students and teachers ;) [20:18:46] and 100% for Open Source: http://www.jetbrains.com/idea/buy/choose_edition.jsp?license=OPEN_SOURCE [20:18:57] I think I could have a free phpStorm license if I wanted... [20:19:00] hoo: IntelliJ/PhpStorm is free for work on open source projects. we have a key for mediawiki [20:19:26] DanielK_WMDE: Does that version have Lua support? If yes, you have me :P [20:19:37] heh, don't know [20:19:38] you can install a lua plugin [20:20:02] there are licenses floating around for various version. probably also the all-plugins version [20:21:06] mh... I'll have a look at that someday... but not this week... enough to do without switching IDEs already [20:22:35] oO [20:22:59] aude: Did we deploy the UpdateRepoOnMove patch to the WPs today? :P Looks like it works [20:23:29] yeah [20:23:37] \o/ [20:24:31] wow... much more page moves done by it now on the RC... seems like we have many pages with spaces on the WPs [20:26:49] did you figure out what the problem is with the map? [20:27:53] npeno [20:28:22] no* [20:28:23] :) [20:28:29] hm :/ [20:29:04] but then i'm not good with lua yet [20:29:08] poking on test2 [20:30:47] http://dpaste.com/1502251/ [20:30:57] should return the entity id? [20:31:55] aude: The ifs are redundant... but yes, it should If I have the data structure right atm [20:31:56] no entity [20:32:24] it might not be finding the entity [20:32:24] ewk [20:32:28] aude: ouch [20:32:32] https://test2.wikipedia.org/wiki/Module:Infobox_road/map [20:32:44] oh [20:32:55] * aude stuggles with lua though [20:33:02] https://test2.wikipedia.org/wiki/Interstate_805 [20:33:22] what on earth... now I can't even look into the Scribunto tree with NetBeans anymore -.- [20:33:37] parsing error, it says [20:35:13] aude: odd, the parser function finds it without trouble, right? [20:35:35] right [20:35:36] (do we have selenium tests for lua integration?...( [20:35:43] no idea [20:35:49] * DanielK_WMDE hopes so [20:35:54] AFAIK not [20:36:01] just check that https://test2.wikipedia.org/wiki/Module:Infobox_road/map looks correct [20:36:44] if it gets entity it should print the id and if no entity it prints "no entity" [20:36:47] does *any* Lua integration wor *anywhere*?.... [20:37:07] copied from https://www.mediawiki.org/wiki/Extension:WikibaseClient/Lua [20:37:54] aude: Make it return tostring( mw.title.getCurrentTitle().prefixedText ) [20:38:02] I want to see whether that is correct [20:38:54] i'm about to log off, but will wonder around the office a bit before that [20:39:02] maybe some of the netzpolitik folks are still around [20:39:15] and /me is not there :/ [20:39:37] k [20:39:55] next step is to verify on my test wiki [20:42:58] https://test2.wikipedia.org/wiki/Interstate_805 is correct [20:43:36] ok, so it's our stuff that's broken [20:43:45] trying on my test wiki [20:43:52] Same here, just started mine [20:47:51] can reproduce [20:48:20] my wiki's always so slow when freshly started [20:48:29] I can tell you in a sec. [20:48:38] aude, hoo: does this mean Lua integration is *compeltely* broken? [20:48:48] In a nutshell: Yes [20:48:52] >_< [20:48:55] Lydia_WMDE: --^ [20:48:55] debugging [20:49:05] Ok, can also reproduce [20:49:06] we didn't even touch that in the last weeks, did we? [20:49:11] DanielK_WMDE: No [20:49:17] i think we did [20:49:17] odd [20:49:18] and Scribunto also didn't change much [20:49:22] aude: Not deployed [20:49:23] * aude tries revert [20:49:28] not sure [20:49:33] oh... we moved stuff around, yes [20:49:41] :/ [20:49:42] jens refactored [20:49:49] shit [20:49:59] * aude tries revert [20:50:12] if revert works then we can investigate [20:50:49] this one? https://gerrit.wikimedia.org/r/#/c/95598/ [20:51:10] yep [20:51:14] we really need better tests for this stuff :/ [20:51:45] aude: Still broken for me [20:51:56] simeplre revert does not work [20:51:59] simple* [20:52:04] git doesn't like it [20:52:42] aude: Applies clenly for me [20:54:04] ok [20:55:45] ok, confirmed locally [20:55:47] debugging [20:56:05] (damn, how did we not catch this?!) [20:56:57] nobody really knows lua? [20:57:01] DanielK_WMDE: Missing tests in a nutshell [20:57:02] except hoo [20:57:13] and *no* manual testing?? [20:57:23] hmpf [20:57:26] I wasn't even on that patch [20:57:41] nobody added me as reviewer, apparently [20:57:48] gah [20:58:07] actually, the refactoring was done exactly to make it possible to unit-test the implementation [20:58:15] but i guess we have no tests for the *integration* [20:58:17] gah [20:58:24] needs a selenium test [20:58:43] Yeah, that would be nice [20:58:54] i'm not sure how many infoboxes even use lua integration yet [20:58:56] and we should have selenium tests run on Travis, to have that more transparent [20:59:47] uh.... [20:59:54] DanielK_WMDE: That's possible [20:59:56] the getEntity() method is never hit at all [21:00:57] which one? the PHP one or the Lua one? [21:01:47] the PHP one [21:02:01] i'm struggelign to understand the module i have on my local wiki [21:02:06] copy&üastedthat here ages ago [21:02:20] DanielK_WMDE: aude: we will do a post mortem of this deployment tomorrow -.- [21:02:26] the getEntityId() method *is* hit [21:02:41] so many issues :/ [21:02:43] got it [21:02:47] patch coming [21:02:58] aude: thank you! [21:03:06] thanks for tracking it down folks [21:03:10] *cough* hi Erik [21:03:11] and rschen7754 thanks for poking [21:03:17] thanks for fixing it :D [21:03:31] aude: i'm quite curious... [21:03:32] hey daniel, why the cough? :) [21:03:58] really quite stupid [21:04:13] (03PS1) 10Aude: Fix lua constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101071 [21:04:14] Eloquence: because we just found out we broke Lua integration of Wikidata on Wikipedia. But aude apparently found it [21:04:16] Eloquence: because we were just talking about the issues of the last deployment ;-) [21:04:26] can't believe [21:04:33] https://gerrit.wikimedia.org/r/#/c/101071/ [21:04:43] (03PS1) 10Aude: Fix lua constructor [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101072 [21:04:44] all part of the fun :) [21:04:49] orr! [21:04:56] https://gerrit.wikimedia.org/r/#/c/101072/ [21:05:01] it works, verified [21:05:11] Lydia_WMDE: what I realyl find worrying is that it took two days for someone to notice... [21:05:16] doh [21:05:17] DanielK_WMDE: ack [21:05:21] (03CR) 10Hoo man: [C: 032] Fix lua constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101071 (owner: 10Aude) [21:05:32] (03CR) 10Hoo man: [C: 032] Fix lua constructor [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101072 (owner: 10Aude) [21:05:54] anyway [21:05:57] ok, mackport and make somebody deploy it? [21:05:58] post mortem tomorrow [21:06:05] let's see what we can improve [21:06:10] *backport even [21:06:12] :D [21:06:17] doing [21:06:19] i like mackport more [21:06:37] Lydia_WMDE: packmort! [21:06:42] no no no [21:06:46] hehe [21:06:47] that sounds dangerous [21:06:59] shall we try to get this deployed right now? [21:07:13] is Reedy still arouond? [21:07:16] I'd say so [21:07:18] yeah if you all think this is good to go let's do it [21:07:22] probably [21:07:30] well, that patch sure isn't going to break anything [21:07:32] as said, verified [21:07:33] even if it doesn't help [21:07:35] with the map module [21:07:40] ok [21:07:59] returns the entity id and then i assume the rest works [21:08:07] i [21:08:10] *nod* [21:08:17] well, it's definitly an improvement ;) [21:08:21] returns the full entity etc [21:08:24] hehe [21:08:49] https://gerrit.wikimedia.org/r/#/c/100577/4/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php [21:08:50] oO [21:08:57] Jens found the bug but didn't tell us :P [21:09:06] I knew I've seen that strange line before [21:09:13] bah [21:09:14] really? [21:09:29] Lydia_WMDE: Yep, that's from Dec. 10 [21:09:37] man... [21:09:49] wait for jenkins [21:10:18] I also didn't realize the importance of that line while having a quick glance :/ [21:10:30] hmhm... [21:10:42] the code is confusing, btw [21:10:51] there is getEntity() in 3 different classes [21:11:12] took me a few minutes to figure out which was the *real* one :) [21:11:13] DanielK_WMDE: Yeah [21:11:20] backport coming [21:11:27] I wish my irc client would show me notifications when tabbed out [21:11:35] Reedy: yay! please deploy a 1 line patch to fix lua integration :) [21:11:42] * aude waits impatiently for jenkins [21:11:48] public function getEntity( $prefixedEntityId = null ) { [21:11:57] (03Merged) 10jenkins-bot: Fix lua constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/101071 (owner: 10Aude) [21:12:03] Reedy: https://gerrit.wikimedia.org/r/#/c/101072/ [21:12:04] I'm pretty sure that eg. will throw up if we really pass null [21:12:08] Reedy: isn't that fun? [21:12:09] that's fo rmaster [21:12:18] other one should come soon [21:12:45] hoo: i hope not [21:12:56] hoo: yea, needs some love [21:13:41] Awesome bug [21:13:51] isn't it :) [21:13:56] heh [21:14:05] gah, why jenkins so slow! [21:14:12] we really need an integration test strategy for those [21:14:19] hoo: selenium [21:14:21] (03Merged) 10jenkins-bot: Fix lua constructor [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/101072 (owner: 10Aude) [21:14:22] shouldn't be hard [21:14:34] yay [21:14:59] Reedy: get a decent irc client, btw :) [21:15:00] Yeah... but I want tests I can also run myself :P Maybe I could hack up some phpUnit [21:15:06] I'm using Quassel... [21:15:25] hoo: well, that change that introduced the bug was made to introduce unit tests for the implementation [21:15:44] but w/o actual tests, I guess? [21:15:45] hoo: phpunit tests for the full lua integration stack... well, if you can come up with something, let me know! [21:15:46] lets turn notifications off and on again [21:15:50] actually, let everyone know [21:15:55] ok [21:16:35] Reedy: I think Lydia_WMDE as a good connection to the Quassel developer... maybe you can bribe her to convince him :) [21:16:47] Off to eat something [21:17:02] thanks hoo|away for your help :) [21:17:05] And have Lydia covince the kdevelop guys to have proper PHP namespace support :P [21:17:11] lol [21:17:14] riiiight [21:17:25] aude: I've not really been much help here... was to focused on teh actual Lua code the whole itme [21:17:40] well, at least i understand it better [21:17:44] Reedy: https://gerrit.wikimedia.org/r/#/c/101095/ [21:17:53] * aude will make a patch for wmf7 [21:18:24] we branched wmf7? [21:18:29] no, but core did [21:18:38] test2 has wmf7 [21:20:35] Reedy: hold on [21:20:58] * DanielK_WMDE holds his breath [21:21:11] * DanielK_WMDE gets another beer [21:24:35] git wouldn't liked my first patch, this one is better: https://gerrit.wikimedia.org/r/#/c/101103/ [21:24:39] Reedy: [21:27:30] Just that one? [21:27:30] wow, Reviewer-bot works well, from now on I'll get auto added on Scribunto related changes [21:28:05] second one coming [21:28:12] I'll deploy this one firs thten [21:28:26] https://gerrit.wikimedia.org/r/#/c/101104/ for wmf7 [21:28:27] ok [21:30:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1413 (master - 74fd932 : aude): The build is still failing. [21:30:41] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/24f67ce75032...74fd9328d4e8 [21:30:41] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15365935 [21:31:38] Oh, still these test failures :/ [21:31:55] map is back! [21:32:00] https://en.wikipedia.org/wiki/Interstate_805 [21:32:01] \o/ [21:32:10] thanks rschen7754 ! [21:32:15] np [21:32:25] thanks for getting it fixed so quickly [21:32:28] cool to see how lua is used there :) [21:32:38] yeah, i just wish more projects used it [21:32:41] maybe someday [21:32:43] * aude nods [21:33:09] adding more fields is on my todo list... but at least this way enwiki and simplewiki can share maps between each other [21:33:17] test2 works now [21:34:02] alright, off to get food :) [21:35:17] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1414 (mw1.23-wmf6 - 97e5689 : aude): The build has errored. [21:35:17] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/db2b67d8df7d...97e568933e5d [21:35:17] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15366039 [21:38:52] * DanielK_WMDE exhales slowly [21:40:00] thanks Reedy, aude, hoo, rschen7754! [21:40:05] ttfn! [21:40:15] gn8 Lydia_WMDE [21:40:21] cu, DanielK_WMDE ;) [21:40:30] good night DanielK_WMDE [21:47:52] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1415 (master - a22f7fb : Translation updater bot): The build is still failing. [21:47:52] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/74fd9328d4e8...a22f7fb338e4 [21:47:52] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15366220 [21:51:25] how do i reorder statements? [21:51:34] or is this switched off for now again? [22:01:32] dennyvrandecic: click edit - see arrows on the right [22:01:44] (yes bad usability and all - needs to be reworked) [22:02:28] (I am not complaining about usability, I was the one suggesting it like this...) [22:02:57] (I actually thought the arrow was disabled earlier, now it works, thanks!) [22:02:57] hehe [22:02:59] yeah [22:04:04] tbh i think we need to rethink the whole mixing of sorting and ordering wrt ranks [22:04:17] which is one of the reasons there is no automatic sorting by rank yet [22:04:51] this needs a better way to represent this in the UI [22:05:35] but i have not found a good way yet [22:07:15] just clicking on "random item" and improving it is actually lots of fun :) [22:07:23] :D [22:07:32] you're slightly biased but i'll take it anyway [22:08:19] * Lydia_WMDE goes back to the puzzle on her desk [22:12:22] [tests@localhost MediaWikiSQLite]$ php tests/phpunit/phpunit.php --group Wikibase [22:12:22] [...] [22:12:22] No tests executed! [22:15:18] ok, it was the working dir, which made the executor go insane [23:28:59] DanielK_WMDE, still there by any chance? [23:49:54] yurik: yea, but not really awake... [23:50:18] DanielK_WMDE, !!! you are alive!!! i just discovered ContentHandlerDefaultModelFor, might work for my goals, so a quick q for you :) [23:50:36] i want to make config system (half way there) [23:50:53] described in https://www.mediawiki.org/wiki/Requests_for_comment/Json_Config_pages_in_wiki [23:51:06] i need "sub-namespaces" [23:51:40] so that an extension can say that pages named Config:MyExt:* all have a custom content handler [23:51:54] notice that Config is one shared namespace for all that [23:52:18] i started pushing $title object all around, until realizing that this is not a very good approach [23:52:46] ContentHandlerDefaultModelFor is probabaly what yo uwant to use, yea [23:53:12] so i should intrtoduce some "config-json-myext" model for each extension? [23:53:32] do i need some magic override for non-default? [23:53:41] or what's the approach there? [23:54:06] you define a content model (id and class) for every "kind" of content you want to have [23:54:17] for each, you can define rendering, editing, etc [23:54:39] you'll have to override ContentHander:.getActionOverrides(), to handle the edit action etc [23:54:42] so just handle that hook, return a different ID, and specify which contentHandler class should halde each [23:54:52] yes [23:54:56] they all will be text-based, so should be ok\ [23:54:58] thx! [23:55:05] could you review it when you have a chcance? [23:55:10] at least the RFC [23:55:21] you should think about whether you want to treat the JSON as text, or as a datata structure [23:55:22] this should be an awesome config system for all to use :) [23:55:39] probably text - this way i gain the diffs and all other goodies [23:55:57] you could mal structure-based diffs [23:55:58] and storage, etc [23:56:08] mal? [23:56:09] we do that for wikidata [23:56:26] daniel, are you coming for the RFC thing in jan to SF? [23:56:26] storage Just Works, you just provide a serializer [23:56:31] yes [23:56:43] awesome, i will try to demo it then, you will have a field day reviewing :) [23:56:49] i'm getting the feeling i'll need to add a day :) [23:56:51] btw, i followed some of your advice [23:57:07] when you reviewed the zero config stuff [23:57:15] this jsonconfig stuff is based on that [23:57:23] yeah, you do that [23:57:34] i will be there for the following mon & tue [23:57:51] i'm flying out on saturday, but i'm there a day early [23:58:09] was planning to use it to cure the jet lag. west coast is tough [23:58:11] hmm... maybe i will try to come a day early [23:58:23] hehe, its ok, will start working early ;) [23:58:44] oh damn [23:59:01] o_O [23:59:12] our tests suck :P [23:59:18] hoo: don't tell me we broke more stuff with the last deployment?... [23:59:33] write better ones :) [23:59:34] DanielK_WMDE: Nah, just found more problems while trying to debug a single one [23:59:51] DanielK_WMDE, don't worry, fatalmonitor is all quiet [23:59:54] fix it or report it :)