[08:32:59] any wikidata admin here? Jasper_Deng legoktm [08:33:15] Jianhui67_busy: I am an admin [08:33:15] * Jasper_Deng is busy [08:33:18] what's the issu? [08:33:21] issue? [08:33:59] should I request IPBE for my mobile account as I am going to use outside internet connection [08:34:57] Jianhui67_busy: can you post a link to both your main and your mobile accounts for me please? [08:35:08] also, what makes you think you're going to need IPBE? [08:36:24] in my mind, IPBE should only be used if you have a need for it [08:36:25] I'm scared if I may be at a place which have their ip address blocked when I try to edit wikidata [08:37:05] giving it out willynilly opens up the door to abuse [08:37:23] willynilly? [08:38:14] I connect to outside internet connection while I'm outside [08:42:04] Sven Manguard? [08:42:39] [03:34] Sven_Manguard Jianhui67_busy: can you post a link to both your main and your mobile accounts for me please? [08:42:44] Jasper_Deng: sorry if I pinged you when you are busy. I ping people randomly [08:43:49] http://en.wikipedia.org/wiki/User:Jianhui67 http://en.wikipedia.org/wiki/User:JianhuiMobile [08:43:56] en-wiki can? [08:44:33] close enough [08:45:20] so? [08:46:20] I use the same ip for my main and mobile account at home. but I connect random internet connection outside [08:47:17] Jianhui67_busy: what country are you in? [08:47:30] PM me if you'd prefer that [09:01:03] Right, good night all [09:01:52] oh, and aude - https://en.wikipedia.org/w/index.php?title=Portal:Biography&oldid=584472484 - it's coming along! [09:23:45] hoi is there anywhere some documentation how this sorting stuff works ? [09:24:29] or can someone give me some pointers ?? [09:25:35] edit a statement, and click of the arrow [09:25:44] s/of/on [09:28:58] so it is per item ??? [09:31:36] and it is only within a statement for qualifiers ? [09:32:06] it's very time consuming [09:32:56] that is another issue [09:34:58] hmmm it crashes the window on a big item like Nelson Mandela [09:39:55] hmmm it crashes the window on a big item like Nelson Mandela [09:40:45] restarted my system to make sure it is not the software update of Ubuntu [09:43:50] it times out on my browser ... looks like a dead duck to me [09:46:03] :( [09:51:17] (03CR) 10Tobias Gritschacher: [C: 04-1] Migrate simple RSpec browser tests to Cucumber. (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [09:59:56] it has no effect on the Reasonator ... was to be expected [10:01:21] when there are qualifiers like date, should that not be the default sorting order ? [10:05:51] (03CR) 10Tobias Gritschacher: "What's with this patch? It still is tagged as work-in-progress, is this still true. It also lacks tests and needs rebase.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84187 (owner: 10Legoktm) [10:09:54] hmmm I should say it does not work for me [10:11:15] ... there are two default sorting orders .... time & alphabetical/numerical ... [10:11:35] there is always not sorting .... [10:18:27] hmmm Nelson Mandela is hard to load as it is :( [10:19:38] the sort order I saved is gone :( [10:28:34] (03CR) 10Lydia Pintscher: "Can someone please do this so we can finally get this through?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77154 (owner: 10Daniel Werner) [10:29:48] (03CR) 10Tobias Gritschacher: "@Jeroen: are you still planning to rebase this on top of (fixed) master as you mentioned in your last comment?" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/89117 (owner: 10Daniel Werner) [10:37:32] this time it DID save an item I moved to the top [10:37:44] even better, it does show in Reasonator [10:50:21] (03PS1) 10Henning Snater: (hotfix) Added missing mw.ext.valueView dependencies [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/100772 [11:08:37] (03CR) 10Tobias Gritschacher: [C: 032] Rename SpecialSetEntity to SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [11:10:25] WD is still slow... ~40 seconds to load Q42 [11:11:09] on actual hardware connected via gigabit (at a university) [11:12:19] (03Merged) 10jenkins-bot: Rename SpecialSetEntity to SpecialModifyTerm [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98198 (owner: 10Bene) [11:15:45] and I have some notes on usability of the new features [11:16:29] moving items is anoying, if you have more claims for one property its not possible to move the whole statements block [11:17:19] there should be a link back to the menu in the headlines [11:17:35] the ranks are completely confusing [11:23:51] (03Abandoned) 10Aude: Cleanup code in TermPropertyLabelResolver, split up method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100191 (owner: 10Aude) [11:27:27] (03CR) 10Tobias Gritschacher: [C: 032] (hotfix) Added missing mw.ext.valueView dependencies [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/100772 (owner: 10Henning Snater) [11:28:09] (03Merged) 10jenkins-bot: (hotfix) Added missing mw.ext.valueView dependencies [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/100772 (owner: 10Henning Snater) [11:29:03] (03PS1) 10Tobias Gritschacher: (hotfix) Added missing mw.ext.valueView dependencies [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100777 [11:30:46] (03CR) 10Tobias Gritschacher: [C: 032] (hotfix) Added missing mw.ext.valueView dependencies [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100777 (owner: 10Tobias Gritschacher) [11:31:19] (03Merged) 10jenkins-bot: (hotfix) Added missing mw.ext.valueView dependencies [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100777 (owner: 10Tobias Gritschacher) [11:33:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1404 (master - 5777e8b : jenkins-bot): The build has errored. [11:33:19] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/2c23b6a69816...5777e8bcf77f [11:33:19] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15278183 [11:40:30] Lydia_WMDE: hey. feeling a bit better, comming in for the meeting. [11:41:47] Lydia_WMDE, aude: I think I found the right way to avoid the parser cache mess: the information what options go into the cache key is itself cached. And we got old entries for that, leading to pages being cached without considering the user language in the key. [11:42:46] essentially, we need to purge that info from the cache. It should be sufficient to bump $wgCacheEpoch. needs testing though. [11:43:57] This will not however fix the problem with thw "other languages" box, i'll work on that today (can we rename that to "term translation box" or something?) [11:49:15] (03CR) 10Tobias Gritschacher: [C: 04-1] "can we please restrict these changes to /test/browser/ only and leave the old tests in /selenium/ and /repo/tests/selenium/ as they are. T" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [11:52:38] Hi all. We are discussing in ru-wp now how to simplify the editing of data in infoboxes, which are taken from Wikidata. [11:52:58] meh, DanielK_WMDE whats the class dalled that deals with id generation again? :/ [11:53:02] *called [11:53:11] But, as it turned out, the main problem is that half of users can't use Wikidata at all, because it freezes when opening. They are forced to continue the execution of scripts several times. [11:53:16] SqlIdGenerator [11:53:20] [= [11:53:21] i think [11:53:34] and there is an interface IdGenerator [11:53:59] might try and make the tests all use it and stop these random failures for once! [11:54:08] ok [11:54:35] they are just so annoying! [11:54:44] yeah! [11:54:45] Is there a issue about this? [11:55:01] putnik: we are aware [11:57:35] addshore: the problem is that you can't do anything that involved DB access in a data provider. [11:57:58] so, the data provided has to contain placeholders, which are then substituted when running the actual test [11:58:13] that's because the dummy database is set up before running the tests, not before executing the providers [11:58:31] (would be nice to do that, but i couldn't find a way to make phpunit do that) [11:59:19] aude: we may need to consider a quick fix for the JS performance issues. this is worse than I thought [11:59:21] hmmmm [12:00:00] anyway, going offline and going to the office now [12:00:15] DanielK_WMDE: i am open to backporting stuff that improves js [12:01:09] aude: yea, if we can find something nice and small... i'm afraid the only thing that will help is a partial rewrite [12:20:39] putnik: we are aware of the issue and are working on fixing it [12:46:53] (03PS4) 10Tobias Gritschacher: (bug 55740) Remove "Wikidata" specific handling of copyright message introduced in Ie7dba1130202c3c1d7dd12fc50d7ee65059d99b4 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77154 (owner: 10Daniel Werner) [12:50:37] searching for தமிழ் does not work .. extended search for தமிழ் on Wikidata does not work either [13:06:57] ergh, I have determined there is no nice way to test the xml output! [13:08:40] addshore: how about remvoing it all, and testing it is gone? :) [13:08:51] I would love to do that xD [13:09:11] it seems so pointless to support it! :D [13:09:14] Abraham_WMDE: you in teh office?! [13:10:07] (03CR) 10Jeroen De Dauw: [C: 031] (bug 55740) Remove "Wikidata" specific handling of copyright message introduced in Ie7dba1130202c3c1d7dd12fc50d7ee65059d99b4 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77154 (owner: 10Daniel Werner) [13:18:37] JeroenDeDauw: yes, abraham is here. currently in the meeting [14:51:42] (03PS4) 10Addshore: (bug 56693) special page for setting sitelinks needs to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [15:01:44] (03PS11) 10Addshore: Special page for wbmergeitems api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [15:02:06] (03CR) 10Addshore: "PS11 is a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [15:13:40] (03PS1) 10Tobias Gritschacher: Revert "Taking "movetoolbar" and "rankselector" out of experimental features" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100789 [15:13:56] (03CR) 10Tobias Gritschacher: [C: 04-2] "just a test" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100789 (owner: 10Tobias Gritschacher) [15:40:28] (03CR) 10Addshore: [C: 04-1] "When trying to set any sort of site link using the page I get the message 'The id Qbla does not belong to an item.'." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [15:47:07] (03CR) 10Addshore: [C: 04-1] "When trying to use this I only ever seem to get the message 'Your edit was ignored because no change was made to the text.'" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [15:49:31] (03CR) 10Addshore: Special page for wbmergeitems api module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98281 (owner: 10Bene) [16:04:36] (03CR) 10Legoktm: "I probably won't have time to follow it up any time soon. Anyone else is free to do so." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84187 (owner: 10Legoktm) [16:14:30] [travis-ci] wmde/WikibaseDataModel#3 (0.5 - cfef040 : jeroendedauw): The build passed. [16:14:30] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/compare/0.5 [16:14:30] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/15291871 [16:14:34] :O [16:14:56] JeroenDeDauw actually made something work :O [16:23:27] (03PS15) 10Addshore: Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [16:23:57] ! [16:25:39] (03CR) 10Zfilipin: "Aaron1011, do you know what needs to be done, or do you need help?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [16:37:54] JohnLewis: the thing with components is that they allow you to nicely seperate broken things from working ones [16:38:05] DataModel has had all its tests pass on master for quite some time [16:38:26] Failure notice here imminent though, as there now is a failing pull request [16:38:38] JeroenDeDauw: Nice :p [16:39:27] JohnLewis: also note how these notices only indicate change in state and errors. If ssomething is working the whole time, you'll not see any notice here [16:39:39] So conclusing from these notices that all our stuff is broken is not quite accurate ;p [16:39:47] JeroenDeDauw: I know because Travis is set to Change :p [16:40:04] Well, it is accurate enough. [16:40:05] :) [16:40:20] JohnLewis: in this case it notified because it was the first commit on this branch it looked at [16:42:03] Reedy: ping? [16:42:13] hi [16:42:13] greg-g: ping? [16:42:15] oh [16:42:17] hey Reedy :) [16:42:24] Reedy: any chance you can review https://gerrit.wikimedia.org/r/#/c/95996/ today? [16:42:43] hi [16:43:06] greg-g: still trying to find a reviewer for https://gerrit.wikimedia.org/r/#/c/95996/ [16:43:18] it'd be pretty important to get this done today for me [16:43:45] yeah.... [16:43:52] since it is blocking other stuff which would mean we can't deploy new features for a while in the new year [16:43:58] * greg-g nods [16:43:59] agree [16:44:00] [travis-ci] wmde/WikibaseDataModel#4 (06 - 8194922 : jeroendedauw): The build failed. [16:44:00] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/commit/81949221d0f4 [16:44:00] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/15293460 [16:45:12] (03PS16) 10Addshore: Allow id and type params in wbeditentity data! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 [16:45:15] Actually those notifications for PRs are silly... Looks like there is no per branch setting though? :( [16:48:04] * addshore cant tell if your talking about the travis notification or the gerrit one :P [16:48:17] addshore: Travis i think. [16:50:21] (03Abandoned) 10Hoo man: Fix unit tests in Travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100525 (owner: 10Hoo man) [16:52:49] DanielK_WMDE_: good news... finally brought https://gerrit.wikimedia.org/r/78640 through \o/ [16:58:09] hoo: cool! [16:58:34] hoo: btw, couldn't reproduce the issue with tests accessign the "real" database instead of the dummy database during testing... [16:58:35] odd [16:59:59] (03PS3) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [17:00:14] DanielK_WMDE_: mh [17:00:27] I can test it again on master, if you want [17:00:38] might be some artefacts from testing an older branch [17:00:52] (although that DB never did anything else than run tests) [17:01:59] hoo: basically, i patched WikiPage to fail when trying to save to a "real" database when MW_PHPUNIT_TEST is defined. [17:02:04] then i ran each test individually [17:02:06] mh [17:02:08] no issues [17:02:24] hoo: there [17:02:27] err [17:02:38] there's the possibility that stuff got injected into the database directly, bypassing WikiPage. [17:02:41] my clear script has "mysql -u root -e "DROP DATABASE its_a_mw";" [17:02:44] but that's pretty unlikely, i'd say [17:02:47] so the DB was rather fresh [17:03:00] I'll run again, on a fresh MariaDB [17:03:05] which tests did you run? [17:03:24] i only tried all tests from the Wikibase and WikibaseDatamodel extensions [17:03:33] (calling each one individually) [17:03:41] mh [17:03:51] I usually run the whole group Wikibase, like travis does [17:04:10] (not the changehandler tests) [17:05:02] MariaDB [its_a_mw]> SELECT COUNT(*) FROM page; -> 1 (fresh DB) [17:05:40] running the tests in a screen session now, let's see... I can probably debug that down further, if you want [17:07:52] DanielK_WMDE_: Just jumped up to 6 again -.- ... Wikibase master with MediaWiki master and everything -.- [17:09:37] (03PS4) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [17:10:00] (03CR) 10jenkins-bot: [V: 04-1] Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [17:12:01] hoo: can you try this in WikiPage? http://pastebin.com/Fa3uheCd [17:12:08] that should tell you where these pages come from [17:16:03] done... started the tests [17:17:08] PHP Notice: WikiPage::doEditContent: Transaction already in progress (from WikiPage::doEditContent), performing implicit commit! [Called from DatabaseBase::begin in /dev/shm/MediaWikiMySQL/includes/db/Database.php at line 3374] in /dev/shm/MediaWikiMySQL/includes/debug/Debug.php on line 301 [17:17:13] I guess we can ignore these?! [17:18:00] Ok, we can... I see the problem causing tests... we just need to wait the rest of the ~20 minutes it takes to run all tests in that VM [17:39:56] There was 1 error: [17:39:57] 1) Wikibase\Test\ReferencedPagesFinderTest::testGetPages with data set #0 (array(Berlin), array(), Wikibase\ItemChange: array ( 'id' => NULL, 'object_id' => 'q2', 'type' => 'wikibase-item~add', ), 'created item with site link to client') [17:39:57] RuntimeException: Auch! Writing to the real database! [17:39:59] DanielK_WMDE_: ^ [17:42:57] hoo: hm, nice! got a stack trace? [17:43:16] sure [17:43:29] /dev/shm/MediaWikiMySQL/includes/WikiPage.php:1230 [17:43:29] /dev/shm/MediaWikiMySQL/includes/WikiPage.php:1881 [17:43:29] /dev/shm/MediaWikiMySQL/extensions/Wikibase/client/tests/phpunit/includes/ReferencedPagesFinderTest.php:41 [17:43:29] /dev/shm/MediaWikiMySQL/tests/phpunit/MediaWikiPHPUnitCommand.php:80 [17:43:30] /dev/shm/MediaWikiMySQL/tests/phpunit/MediaWikiPHPUnitCommand.php:64 [17:43:59] hoo: ok, right [17:44:14] hoo: it's indeed missing @group Database, even though it does $page->doEditContent( $content, 'edit page' ); [17:44:29] can you add it? i'm in the middle of something [17:44:29] Yay, found something \o/ [17:44:33] Sure [17:44:46] also, this accounts for "Berlin" and "Rome", it doesn't account for the three Properties being created [17:45:00] they must be bypassing WikiPage?... [17:45:08] maybe something is writing to the page table directy? [17:45:34] * DanielK_WMDE_ has been doing stuff like this sometimes [17:46:33] mh [17:46:44] one after the other [17:46:47] :) [17:47:32] (03PS1) 10Hoo man: Add @group Database to ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100809 [17:48:31] (03PS2) 10Hoo man: Add @group Database to ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100809 [17:55:11] (03CR) 10Mayankmadan: Migrate simple RSpec browser tests to Cucumber. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [17:55:53] [travis-ci] wmde/WikibaseDataModel#6 (06 - bc998f3 : jeroendedauw): The build was fixed. [17:55:53] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/compare/81949221d0f4...bc998f327f45 [17:55:53] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/15297894 [17:57:15] (03CR) 10Jeroen De Dauw: ":'( why is this even using the database? Definitely not a unit test like this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100809 (owner: 10Hoo man) [17:59:13] (03PS5) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [17:59:23] JeroenDeDauw: Want a @FIXME? [18:00:58] [travis-ci] wmde/WikibaseDataModel#8 (06 - fd34da2 : jeroendedauw): The build was fixed. [18:00:58] [travis-ci] Change view : https://github.com/wmde/WikibaseDataModel/compare/bc998f327f45...fd34da234549 [18:00:58] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDataModel/builds/15298053 [18:09:02] hoo: I doubt that will help anything [18:09:28] hoo: I've already mentally tagged Wikibase.git as FIXME :) [18:09:45] (03PS1) 10Zfilipin: Nicer Ruby gemset name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100812 [18:09:47] :D [18:11:22] (03CR) 10Mayankmadan: Migrate simple RSpec browser tests to Cucumber. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [18:16:53] Lydia_WMDE: there is going to be UI redesign? [18:17:00] when, what, where? [18:17:19] (03CR) 10Zfilipin: [C: 04-1] "This is what I get:" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew) [18:19:43] lazowik: yes, next year - most other things still in the air [18:20:10] lazowik: there are simply too many usability/user experience issues with the current UI [18:20:13] that we need to fix [18:21:27] mhm [18:21:33] Lydia_WMDE: and what about looks? [18:21:44] a bit more cheerful? :p [18:21:49] :P [18:21:51] hope so [18:22:17] lazowik: with rainbows and kittens, yes? [18:22:27] :D [18:22:31] ofc. [18:22:38] lol [18:25:10] JeroenDeDauw: DanielK_WMDE_: https://gerrit.wikimedia.org/r/95996 <- can one of you please answer ree*dy's comment? [18:25:13] yay... composer installation broken for Wikibase -.- [18:25:18] JeroenDeDauw: ^ [18:35:10] hoo: btw i know why i didn't find the database issue you mentioend: i didn't run client tests. [18:41:40] hoo: how so? [18:48:21] JeroenDeDauw: wikibase/data-model and data-values/serialization seem to want conflicting data values versions [18:48:59] JeroenDeDauw: http://pastebin.com/HH7h3RSg [18:51:58] hoo: oh, guess I have to override some stuff to use the old data model [18:52:56] JeroenDeDauw: mh... it's what Composer is installing me... I just take Wikibase master and do a composer install in there [18:53:28] (03PS1) 10Jeroen De Dauw: Add souirce overide for WikibaseDataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100819 [18:54:41] hoo: this should fix that issue: https://gerrit.wikimedia.org/r/#/c/100819/ [18:56:32] DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/100819/ mmeeeeerggggeeeee [18:56:42] addshore: you can still be FIRST https://gerrit.wikimedia.org/r/#/c/100819/ [18:57:05] testing [18:58:21] (03CR) 10Hoo man: [C: 032] "Works like a charm again :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100819 (owner: 10Jeroen De Dauw) [18:58:32] \o/ [18:59:47] (03CR) 10Legoktm: [C: 032] Add souirce overide for WikibaseDataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100819 (owner: 10Jeroen De Dauw) [19:00:04] #second [19:01:47] (03Merged) 10jenkins-bot: Add souirce overide for WikibaseDataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100819 (owner: 10Jeroen De Dauw) [19:02:04] souirce :) [19:02:25] lets hope siebrand does not notice :0 [19:03:22] :D [19:03:36] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=57746#c3 [19:03:42] Also "overide" :P [19:04:08] DanielK_WMDE_: thanks! [19:08:08] DanielK_WMDE_: https://gerrit.wikimedia.org/r/100809 ... could you +2 that? [19:09:07] Lydia_WMDE: do share! [19:09:10] http://www.getdigital.de/Grumpy-Cat-Pluesch.html [19:09:11] :P [19:09:50] Lydia_WMDE: so many trolling opportunities *eyes glitter* [19:10:00] :P [19:10:19] Lydia_WMDE: ofc we should have one. And the NyanCat one [19:10:26] Though I want one customized, to be NyanData [19:11:48] (Meanhile at the Wikidata R&D department) [19:13:21] JeroenDeDauw: Since when did Wikidata's budget allow for a R&D department? :O [19:14:08] (03PS6) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [19:20:06] JohnLewis: we don't need funding, we do it based on pure awesomeness and suport from the community [19:20:30] Abraham_WMDE: Lydia_WMDE: DanielK_WMDE_ well, this IS a long name https://github.com/wmde/WikibaseDataModelSerialization [19:20:50] Also, 100% coverage! (don't tell anyone this is because there is no code yet) [19:20:55] (03PS7) 10Vldandrew: Migrate simple RSpec browser tests to Cucumber. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 [19:21:21] JeroenDeDauw: :D [19:22:50] Anyone object against putting the stuff for this new component in Wikibase\DataModel\[Serializers|Deserializers]? [19:22:54] JeroenDeDauw: Sure because pure awesomeness is an accepted currency in most banks :p [19:22:57] addshore: DanielK_WMDE_ ^ [19:23:31] JeroenDeDauw: as a package? no, that's a good place [19:25:40] DanielK_WMDE_: PHP namespaces [19:30:05] JeroenDeDauw: yea, that's what i meant [19:31:50] sounds good [= [19:31:54] (03PS1) 10Daniel Kinzler: (bug 58344) use getUserLang for EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 [19:35:20] (03CR) 10jenkins-bot: [V: 04-1] (bug 58344) use getUserLang for EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100829 (owner: 10Daniel Kinzler) [19:35:45] (03PS5) 10Bene: (bug 56693) special page for setting sitelinks needs to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 [19:39:11] benestar: if I'm not mistaken you based ps5 in ps3 [19:39:21] ignoring previous rebase by addshore [19:39:32] lazowik: whoops [19:39:47] gnah, sorry [19:39:55] just cherry-pick ps4 now and make ps6 on top of it [19:42:10] lazowik: don't really know how to use cherry-pick [19:42:17] what's the exact command [19:42:19] ? [19:42:46] git review -d [19:42:52] benestar: ^ easy-peasy [19:43:04] that creates new branch [19:43:07] (locally) [19:43:20] and switches to it [19:43:22] lazowik: but how to get the change set? [19:43:29] aaaah [19:43:30] right [19:44:09] git checkout branch_to_cherry_pick_on [19:44:17] git cherry-pick SHA1_of_commit [19:44:20] {{done}}! [19:44:26] the whole SHA1??? [19:44:28] :O [19:44:28] AsimovBot :( [19:44:46] benestar: 5 characters or so should do it :) [19:44:54] yeah [19:45:46] they don't ?! [19:49:01] Abraham_WMDE: https://de.wikipedia.org/wiki/Dieffenbachien [19:50:14] lazowik: what is the change id of addshore 's patch set? [19:50:25] change id !== sha1 [19:50:47] what are you trying to do? :P [19:51:07] legoktm: what is the sha1? [19:51:25] legoktm: this one? fc89d0d9a8260045bfae7755768e18ceca0d7380 [19:51:35] looks like it [19:52:56] # On branch setsitelinkbadgets [19:52:58] # You are currently cherry-picking. [19:52:59] # (all conflicts fixed: run "git commit") [19:53:01] # [19:53:03] nothing to commit, working directory clean [19:53:04] The previous cherry-pick is now empty, possibly due to conflict resolution. [19:53:06] If you wish to commit it anyway, use: [19:53:08] git commit --allow-empty [19:53:09] Otherwise, please use 'git reset' [19:53:11] ??? [19:53:15] benestar: eek, use pastbin [19:53:26] DanielK_WMDE_: oops, sorry [19:53:36] benestar: what are you trying to do? [19:53:55] addshore: I have overwritten a patchset from you at https://gerrit.wikimedia.org/r/#/c/94939/ [19:53:57] benestar: sounds like you cherry-picked twice. or on top of a branch that already head the changes [19:54:14] did not recognize that you have pushed a change to it [19:54:41] benestar: i can push my patchset again if you want? [19:54:51] then you can check it out and ammend it? [19:54:58] addshore: yes, of course [19:56:23] (03PS6) 10Addshore: (bug 56693) special page for setting sitelinks to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [19:56:24] benestar: ^^ [19:56:36] addshore: thanks :) [19:56:52] np :) [20:00:43] Hee DanielK_WMDE_, how's your Schweizerdeutsch? ;-) [20:01:43] multichill: rudimentary, i'm afraid, why? [20:01:57] https://www.mediawiki.org/wiki/Z%C3%BCrich_Hackathon_2014 [20:02:17] you'll hear SChweizerenglish there mostly, i suppose :) [20:02:28] (03PS7) 10Bene: (bug 56693) special page for setting sitelinks to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 [20:02:44] addshore: --^ now with your patch set ;) [20:02:48] Zwenglish? :P [20:03:50] multichill: Swinglish! [20:03:52] [= [20:04:03] Haha, yes, much better :-) [20:04:29] hehe, same wee as the Republica. again. [20:04:58] the hackathon always ends up very close to that, or needing to be moved because of it. republica and/or Linuxtage [20:05:06] DanielK_WMDE_: aude: https://gerrit.wikimedia.org/r/100809 could one merge that? I would like to go on with the tests (on master) [20:05:27] (03CR) 10Daniel Kinzler: [C: 032] Add @group Database to ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100809 (owner: 10Hoo man) [20:05:27] addshore: what do you mean here? https://gerrit.wikimedia.org/r/#/c/98281/11/repo/includes/specials/SpecialMergeItems.php [20:05:49] well on line 34 you define it as $fromEntityContent [20:06:04] on line 125 you do $this->fromItemContent->getItem()->getId() [20:06:20] but also on line 177 you do $this->fromEntityContent = $this->loadEntityContent( $fromId ); :P [20:06:37] gnah, I see now [20:06:43] I have to buy new glasses ;) [20:06:47] :D [20:09:13] (03CR) 10Addshore: [C: 04-1] "Fatal error: Class 'Wikibase\Repo\Specials\Revision' not found in C:\Users\adam\Documents\git\mediawiki\extensions\Wikibase\repo\includes\" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [20:10:35] (03Merged) 10jenkins-bot: Add @group Database to ReferencedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100809 (owner: 10Hoo man) [21:00:30] (03PS1) 10Hoo man: Prevent SetClaimTest from leaking state to DB [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100905 [21:00:56] (03CR) 10Aaron1011: "I know what I need to do. Thanks for the feedback!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011) [21:01:08] "$ropertyIds" ... doh [21:03:28] DanielK_WMDE_: Found what leaked DB state \o/ https://gerrit.wikimedia.org/r/100905 [21:07:55] Lydia_WMDE: >> http://www.getdigital.eu/Narwhalicorn.html [21:10:52] [travis-ci] wmde/Serialization#19 (2.2 - 56fe0ba : jeroendedauw): The build passed. [21:10:52] [travis-ci] Change view : https://github.com/wmde/Serialization/compare/2.2 [21:10:52] [travis-ci] Build details : http://travis-ci.org/wmde/Serialization/builds/15305699 [21:13:20] addshore: https://gerrit.wikimedia.org/r/100905 [21:13:59] (03CR) 10Jeroen De Dauw: [C: 032] Prevent SetClaimTest from leaking state to DB [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100905 (owner: 10Hoo man) [21:17:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1406 (master - b2ce8a5 : jenkins-bot): The build is still failing. [21:17:04] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/680f86cec6ea...b2ce8a5754f0 [21:17:04] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15304629 [21:35:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1407 (master - 437381a : Translation updater bot): The build is still failing. [21:35:56] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/b2ce8a5754f0...437381a751a6 [21:35:56] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15305427 [21:56:12] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1408 (master - 69676be : Jeroen De Dauw): The build is still failing. [21:56:12] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/437381a751a6...69676be54424 [21:56:12] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15307256 [21:56:28] anyone have any tips on how to get an item to load without the browser crashing? [21:58:28] YairRand: disable javascript! [21:58:59] legoktm: editing statements is impossible without javascript. any other ways? [21:59:11] I think there are specialpages for that [21:59:33] if there are, the edit links don't lead to them [21:59:45] oh, there isnt [22:00:08] rage [22:00:26]