[00:19:04] <Bsadowski1>	 Is there an RC to this channel?
[00:19:11] <Bsadowski1>	 I mean here on freenode
[00:20:16] <hoo>	 Bsadowski1: we have #cvn-wikidata
[00:20:20] <hoo>	 but no full RC
[00:20:23] <hoo>	 AFAIK
[00:22:08] <legoktm>	 #wikidata.wikipedia on irc.wikimedia.org!
[00:22:13] <legoktm>	 the best Wikipedia!
[00:24:31] <hoo>	 legoktm: "I mean here on freenode" :D
[00:24:43] <legoktm>	 freenode is overrated
[01:16:23] <grrrit-wm>	 (03PS1) 10Hoo man: Add @group Wikibase to all tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100514 
[02:26:35] <grrrit-wm>	 (03PS1) 10Hoo man: Fix unit tests in Travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100525 
[06:01:16] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Add @group Wikibase to all tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100514 (owner: 10Hoo man)
[06:04:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add @group Wikibase to all tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100514 (owner: 10Hoo man)
[06:18:08] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1377 (master - f210c72 : Marius Hoch): The build is still failing.
[06:18:08] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/466214ad4263...f210c726c8bc
[06:18:09] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15209233
[10:14:41] <grrrit-wm>	 (03PS6) 10Tobias Gritschacher: Implemented "eachchange" event using the jQuery.event.special API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 (owner: 10Henning Snater)
[10:15:56] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-1] "* needs manual rebase" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93736 (owner: 10Henning Snater)
[10:31:31] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Add test for EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 (owner: 10Aude)
[10:37:49] <Lydia_WMDE>	 Reedy: https://gerrit.wikimedia.org/r/#/c/95996/ <- pretty please to review  today or tomorrow (or at least give me a life-sign) - this is pretty important for us to get done before thursday :)
[11:01:56] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99653 (owner: 10Aude)
[11:04:38] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: Add test for EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 (owner: 10Aude)
[11:05:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix order of parameters for PropertyLabelNotResolvedException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99653 (owner: 10Aude)
[11:05:20] <grrrit-wm>	 (03PS7) 10Henning Snater: Implemented "eachchange" event using the jQuery.event.special API [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93736 
[11:05:44] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Add test for EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 (owner: 10Aude)
[11:10:04] <grrrit-wm>	 (03CR) 10Daniel Kinzler: Remove unused params in EntityView::getHtmlForEditSection (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99545 (owner: 10Aude)
[11:18:51] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "introducing MockTermCache should not be done in this change (added accidentally?)" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100186 (owner: 10Aude)
[11:20:59] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-2] "This seems like a bad idea to me. The key provided to the constructor should be the key that is actually used - if the key is provided, th" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100187 (owner: 10Aude)
[11:22:04] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1378 (master - da66894 : jenkins-bot): The build has errored.
[11:22:05] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/f210c726c8bc...da668946b94f
[11:22:05] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15219480
[11:22:08] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 (owner: 10Aude)
[11:24:15] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "See comment on the patch against master." [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100487 (owner: 10Aude)
[11:25:17] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "o_O" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100525 (owner: 10Hoo man)
[11:26:17] <Lydia_WMDE>	 aude: hey :)  are you feeling better today? or staying at home still?
[11:26:37] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Cleanup in action tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100178 (owner: 10Aude)
[11:27:59] <Lydia_WMDE>	 addshore_: \o/ @ bene*'s new tools page design
[11:28:08] <addshore_>	 havnt looked let
[11:28:15] <addshore_>	 didnt managed to dig through all my emails last night!
[11:28:20] <Lydia_WMDE>	 hehe
[11:28:22] <Lydia_WMDE>	 np
[11:28:22] <aude>	 Lydia_WMDE: at home
[11:28:33] <Lydia_WMDE>	 aude: ok :)  
[11:28:49] <addshore>	 oh my Lydia_WMDE that does look nice :P
[11:28:53] <Lydia_WMDE>	 aude: then let's discuss an issue here that Henning_WMDE is trying to investigate and getting no-where so far it seems
[11:29:20] <Lydia_WMDE>	 aude: the issue is that on test.wikidata.org moving down a claim does not save
[11:29:25] <Lydia_WMDE>	 moving it up does
[11:29:33] <Lydia_WMDE>	 it is not reproducible locally
[11:29:47] <Lydia_WMDE>	 can you think of anything that is special on test that could cause this?
[11:29:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup in action tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100178 (owner: 10Aude)
[11:30:58] <Lydia_WMDE>	 addshore: told you so :P
[11:33:05] <aude>	 nothing special
[11:33:41] <Lydia_WMDE>	 aude: do you have the hash of the last commit in the deployed branch there?
[11:34:02] <addshore>	 when do we branch?
[11:34:23] <Lydia_WMDE>	 addshore: no branch until new year
[11:34:30] <addshore>	 ahh
[11:34:35] <addshore>	 just we deploy today? :P
[11:34:40] <Lydia_WMDE>	 yes
[11:34:43] <addshore>	 okay :)
[11:36:04] <grrrit-wm>	 (03CR) 10Aude: "mock term cache is not being introduced. it was buried within some test file in repo. it is generic and belongs in lib, imho. i can put i" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100186 (owner: 10Aude)
[11:38:43] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "@aude: if it's just moved, that's ok - but i didn't see where it was moved from?..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100186 (owner: 10Aude)
[11:39:34] <DanielK_WMDE>	 aude: i saw you moved MockTermIndex in another patch... I don't quite understand how that relates to MochTermCache... should be the same thing, right?
[11:39:42] <aude>	 Lydia_WMDE: probably https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FWikibase.git/6845dc43be595686b99527f843b06fd7928aa5be
[11:39:51] <aude>	 DanielK_WMDE: they don't relate
[11:39:58] <aude>	 we have two mock term things apparently!
[11:40:06] <DanielK_WMDE>	 eek
[11:40:15] * aude  just found it 

[11:40:16] <DanielK_WMDE>	 do we *need* two?
[11:40:20] <aude>	 probably not
[11:40:24] <DanielK_WMDE>	 right
[11:40:36] <aude>	 would be nice if someone combined them
[11:40:47] <DanielK_WMDE>	 anway - can you point me where that class came from? 
[11:41:14] <DanielK_WMDE>	 aude: i didn't see it being deleted. and there'S no change to a classes file.
[11:41:32] <DanielK_WMDE>	 something seems to be missing wrt that. may be a reason to do this in a follow up.
[11:41:48] <aude>	 LabelDescriptionDuplicateDetectorTest
[11:42:31] <aude>	 that's why putting extra classes in a file like that is a bad idea
[11:42:32] <DanielK_WMDE>	 aude: but it's still in there, the change doesn't remove it
[11:42:39] <aude>	 huh?
[11:42:49] <DanielK_WMDE>	 https://gerrit.wikimedia.org/r/#/c/100186/4/repo/tests/phpunit/includes/LabelDescriptionDuplicateDetectorTest.php
[11:42:51] <DanielK_WMDE>	 still there
[11:42:54] <aude>	 ok
[11:43:08] <DanielK_WMDE>	 ...and the new location of the class isn't registered in .classes.php
[11:43:13] <aude>	 ok
[11:43:19] <aude>	 easy to fix :)
[11:43:19] <DanielK_WMDE>	 i'd still prefer to have that move in a follow-up
[11:43:26] <DanielK_WMDE>	 sure :)
[11:43:34] <aude>	 nah, then people will forget about it
[11:43:39] <aude>	 lost forever
[11:43:55] <DanielK_WMDE>	 hm?
[11:44:27] <aude>	 i could at least keep in repo if you prefer
[11:44:36] <aude>	 but needs to be split into own file
[11:45:55] <DanielK_WMDE>	 aude: you can move it to lib, that seems sensible - just do it in a separate change
[11:46:18] <aude>	 nah
[11:46:42] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1379 (master - 0df7215 : jenkins-bot): The build failed.
[11:46:43] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/da668946b94f...0df7215f9018
[11:46:43] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15220520
[11:46:46] <Lydia_WMDE>	 aude: thx!
[11:47:04] <aude>	 anything found buried in another class should be split in cleanup
[11:47:38] <aude>	 otherewise, will i really go back and find it again
[11:47:41] <aude>	 otherwise*
[11:48:27] <DanielK_WMDE>	 aude: how does relate to the question whether it should be done in the same change?
[11:49:12] <aude>	 cleanup is about going through all the tests and finding such issues
[11:50:12] <aude>	 anything beyond moving it means removing the duplicate mock term stuff which should be done in another patch
[11:54:08] <grrrit-wm>	 (03PS1) 10Henning Snater: Update claim indices when saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100553 
[11:54:28] <GerardM>	 Lydia_WMDE:  just to understand ... why no branch this year ... all because of the Christmas season ?
[11:54:38] <grrrit-wm>	 (03PS3) 10Aude: Remove unused params in EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99545 
[11:57:49] <Lydia_WMDE>	 GerardM: yes
[11:58:05] <Lydia_WMDE>	 today is the last deployment on wikidata.org for this year
[11:58:35] <GerardM>	 will it include the Ottoman Turkish ?
[11:59:24] <Lydia_WMDE>	 that change is not merged yet so unfortunately no
[12:00:24] <GerardM>	 .. sad .. it would have been the argument for PanLex to give us data
[12:00:29] <grrrit-wm>	 (03PS5) 10Aude: Cleanup WikibaseRepo tests and add covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100186 
[12:00:35] <aude>	 DanielK_WMDE: ^
[12:00:35] <GerardM>	 would have like the momentum
[12:00:53] <aude>	 if anyone wants to bother with the mock term stuff, that would be nice
[12:00:56] <GerardM>	 is it now accepted ?
[12:01:08] <GerardM>	 (testable in test.wikidata.org ?
[12:01:08] * aude  not bothering with it for now

[12:02:03] <GerardM>	 could serve as an ersatz
[12:02:26] <DanielK_WMDE>	 aude: oh, you just left it. well, ok.
[12:02:56] <aude>	 it's just that it will likely be forgotten
[12:03:06] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Cleanup WikibaseRepo tests and add covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100186 (owner: 10Aude)
[12:03:27] <aude>	 as long as no one creates yet another MockTermCache, then okay :)
[12:06:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup WikibaseRepo tests and add covers tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100186 (owner: 10Aude)
[12:08:26] <grrrit-wm>	 (03PS3) 10Aude: Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100187 
[12:08:52] <aude>	 DanielK_WMDE: please reconsider ^
[12:12:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100187 (owner: 10Aude)
[12:21:19] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1380 (master - 7f1b81d : jenkins-bot): The build is still failing.
[12:21:19] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/0df7215f9018...7f1b81d2949e
[12:21:19] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15221762
[12:34:08] <grrrit-wm>	 (03PS4) 10Aude: Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100187 
[12:43:40] <grrrit-wm>	 (03PS1) 10Tobias Gritschacher: Update gitignore after test files moved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100557 
[12:44:01] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Update gitignore after test files moved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100557 (owner: 10Tobias Gritschacher)
[12:50:13] <JeroenDeDauw>	     /me kicks addshore 
[12:50:25] <addshore>	    /me jabs JeroenDeDauw 
[12:50:43] <JeroenDeDauw>	 jabs? what kind of British jibberish is that?
[12:51:12] <addshore>	 its like a poke, but slightly more violent :D
[12:51:30] <JeroenDeDauw>	 addshore: `what is  the deal with the gh irc notification stuff?
[12:51:54] <addshore>	 I think the service that does it is broken
[12:51:57] <JeroenDeDauw>	 addshore: ok, in that case...
[12:51:58] <addshore>	 :D
[12:52:20] * JeroenDeDauw  buys a LRBM on the bacl market to have a tennis ball dropped from very nhigh on addshore his head

[12:53:11] <JeroenDeDauw>	 addshore: what service? The one you showed me?
[12:53:22] <JeroenDeDauw>	 the cia replacement?
[12:53:41] * aude  jabs JeroenDeDauw :)

[12:54:20] * JeroenDeDauw  decides to next time invest in a missle with multi warhead capability

[13:01:00] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[13:01:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[13:02:04] <grrrit-wm>	 (03CR) 10Addshore: Cleanup code in TermPropertyLabelResolver, split up method (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100191 (owner: 10Aude)
[13:02:10] <addshore>	 aude: ^^
[13:03:29] <aude>	 gah tabs!
[13:03:33] <addshore>	 :P
[13:05:16] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1381 (master - 598bb0e : Addshore): The build is still failing.
[13:05:16] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7f1b81d2949e...598bb0e02958
[13:05:16] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15223690
[13:06:05] <grrrit-wm>	 (03PS4) 10Addshore: Fix ResultBuilderTest fail when items in ns 0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 
[13:06:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix ResultBuilderTest fail when items in ns 0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 (owner: 10Addshore)
[13:06:26] <grrrit-wm>	 (03PS5) 10Addshore: Fix ResultBuilderTest fail when items in ns 0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 
[13:07:06] <addshore>	 wahahaha the build had been failing for a rather long time :P
[13:07:33] <aude>	 https://gerrit.wikimedia.org/r/#/c/100175/ is easy chocoloate
[13:07:47] <aude>	 chocolate*
[13:08:41] <addshore>	 ChangeLineFormatterTest::testFormat is failing :/
[13:10:52] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Fix invalid covers tags and cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100175 (owner: 10Aude)
[13:11:51] <aude>	 whatt
[13:13:14] <grrrit-wm>	 (03Abandoned) 10Addshore: Set self::$hasSetup = true earlier during EditEntityTest setUp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99371 (owner: 10Aude)
[13:13:43] <addshore>	 aude: see travis :P
[13:14:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix invalid covers tags and cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100175 (owner: 10Aude)
[13:14:31] <aude>	 oh
[13:15:28] <grrrit-wm>	 (03PS3) 10Addshore: Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 
[13:15:40] * aude  thinks it doesn't like $wgLang = 'de' :)

[13:18:18] <grrrit-wm>	 (03PS3) 10Aude: Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 
[13:18:19] <grrrit-wm>	 (03PS3) 10Aude: Require cache key and duration constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100188 
[13:18:20] <grrrit-wm>	 (03PS3) 10Aude: Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 
[13:18:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[13:18:30] <aude>	 gah
[13:18:39] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "Looks good except for the evil new global" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 (owner: 10Addshore)
[13:19:41] * aude  waits for the stuff that depends on to be merged, and then can rebase

[13:21:19] <grrrit-wm>	 (03PS4) 10Aude: Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 
[13:21:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[13:23:26] <grrrit-wm>	 (03PS4) 10Addshore: Add basic readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 
[13:24:47] <grrrit-wm>	 (03PS1) 10Aude: Fix ChangeLineFormatterTest for non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100560 
[13:31:37] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1382 (master - 64f90e7 : jenkins-bot): The build is still failing.
[13:31:37] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/598bb0e02958...64f90e7993bc
[13:31:37] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15224614
[13:33:03] <grrrit-wm>	 (03CR) 10Aude: "needs rebase once all the stuff this depends on gets merged" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[13:43:15] <grrrit-wm>	 (03CR) 10Aude: [C: 04-1] "http://dpaste.com/1499003/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 (owner: 10Addshore)
[13:44:20] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: (bug 47070) No import of wikitext to entity NS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100565 
[13:45:51] <grrrit-wm>	 (03CR) 10Addshore: "Would be nice as currently I am just stabbing in the dark as my setup uses the Item namespace!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 (owner: 10Addshore)
[13:47:52] * aude  should have jenkins use main namespace

[13:50:54] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Update claim indices when saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100553 (owner: 10Henning Snater)
[13:50:59] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Add basic readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore)
[13:55:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update claim indices when saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100553 (owner: 10Henning Snater)
[13:55:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add basic readme [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/95387 (owner: 10Addshore)
[13:59:07] <DanielK_WMDE>	 addshore: daily?
[13:59:44] <grrrit-wm>	 (03PS1) 10Aude: Update claim indices when saving [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100566 
[13:59:58] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Update claim indices when saving [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100566 (owner: 10Aude)
[14:00:06] <aude>	 can haz megabytes? :)
[14:00:17] <Tobi_WMDE>	 aude ;)
[14:04:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update claim indices when saving [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100566 (owner: 10Aude)
[14:10:36] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1383 (master - 96f0f06 : jenkins-bot): The build is still failing.
[14:10:36] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/64f90e7993bc...96f0f065ba97
[14:10:36] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15226468
[14:11:27] <hoo>	 wow... all failing
[14:19:18] <grrrit-wm>	 (03Abandoned) 10Hoo man: Fix unit tests in Travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100525 (owner: 10Hoo man)
[14:20:46] <aude>	 hoo: https://gerrit.wikimedia.org/r/#/c/100560/
[14:20:51] <aude>	 addshore: ^
[14:21:12] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Fix ChangeLineFormatterTest for non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100560 (owner: 10Aude)
[14:21:26] * aude  though wonders why now it's failing

[14:21:32] <addshore>	 heh, I have had that open for ages :P Was waiting for jenkins to finish running tests, apparently I missed it!
[14:21:33] <aude>	 the thing has been merged for a week
[14:21:41] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1384 (mw1.23-wmf6 - f302961 : Henning Snater): The build has errored.
[14:21:41] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/00cd7f2db2e4...f302961b6ca2
[14:21:41] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15226952
[14:21:52] <aude>	 maybe something changed in core
[14:23:48] <hoo>	 mh
[14:23:58] <hoo>	 Is it working in jenkins?
[14:24:16] <hoo>	 Maybe the new tests I've added to travis tonight have side effects (although it worked locally...)
[14:24:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix ChangeLineFormatterTest for non-english [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100560 (owner: 10Aude)
[14:24:46] <hoo>	 our unit tests still are anything but stable :/
[14:26:33] <aude>	 hoo: it works in jenkins but jenkins has everything set to english
[14:26:40] <aude>	 we set travis to german :P
[14:26:50] <hoo>	 smart move :)
[14:27:24] <hoo>	 I wonder why we do EXTENSION=client and EXTENSION=repo in travis... when in fact it's just the same anyway (AFAIS)
[14:27:37] <aude>	 yeah
[14:27:49] <aude>	 client tests run on repo and repo tests on client
[14:27:54] <hoo>	 Would be more useful to eg. change the lang
[14:28:14] <hoo>	 So that we run the tests for en and maybe de... makes it easier to find the cause ;)
[14:28:30] <addshore>	 +1
[14:28:45] <hoo>	 I'll prepare a patch :D
[14:29:04] <aude>	 good idea
[14:31:57] <Tobi_WMDE>	 DanielK_WMDE: Lydia_WMDE https://bugzilla.wikimedia.org/show_bug.cgi?id=58274
[14:33:55] <grrrit-wm>	 (03PS1) 10Hoo man: Run unit tests on travis in both English and German [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100568 
[14:35:24] <hoo>	 addshore: aude: ^
[14:38:43] <grrrit-wm>	 (03PS2) 10Hoo man: Run unit tests on travis in both English and German [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100568 
[14:41:42] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1385 (master - 15da127 : jenkins-bot): The build is still failing.
[14:41:42] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/96f0f065ba97...15da1275e0dd
[14:41:42] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15228001
[14:42:30] <hoo>	 1) Wikibase\Test\Api\GetEntitiesTest::testGetEntities with data set #0 (array(array('Berlin'), 'info', 'de', 'sitelinks', 'descending'), array(1))UsageException: Could not create a new page.It already exists.
[14:42:36] <hoo>	 ... -.-
[14:43:10] * addshore  grumbles

[14:44:39] * addshore  goes to huntdown what broke it again ...

[14:46:00] <hoo>	 :) addshore: https://gerrit.wikimedia.org/r/100568 Shall I start adding reviewers or will you "shoot it"
[14:46:43] <addshore>	 hoo, I would add reviewers :)
[14:47:29] <hoo>	 done ;)
[14:48:11] <aude>	 addshore: get entities failure is not new
[14:49:13] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Run unit tests on travis in both English and German [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100568 (owner: 10Hoo man)
[14:49:34] <aude>	 \o/
[14:49:35] <grrrit-wm>	 (03PS1) 10Addshore: Fix ResultBuilder test on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100572 
[14:49:43] <addshore>	 aude: ^^
[14:50:54] <addshore>	 aude: mayeb we should also make jenkins run in 2 languages ?
[14:56:49] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Wont harm" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100572 (owner: 10Addshore)
[14:56:56] <addshore>	 [=
[14:57:50] <addshore>	 aude: I thought I fixed the gtentities test the other day...
[14:58:10] <hoo>	 We've fixed that one like a billion times before...
[14:59:36] <addshore>	 getentities? :P
[14:59:46] <hoo>	 Yep :P
[14:59:48] <addshore>	 annoyingly now the test itself isnt the problem, its other things breaking it :P
[15:00:06] <addshore>	 i.e. my last fix was this https://gerrit.wikimedia.org/r/#/c/99399/1/repo/tests/phpunit/includes/api/SetReferenceTest.php
[15:00:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix ResultBuilder test on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100572 (owner: 10Addshore)
[15:00:55] <hoo>	 1) Wikibase\Test\PropertyContentTest::testSaveFlagsP10Failed asserting that false is true.
[15:01:05] <hoo>	 ...
[15:01:29] <addshore>	 link ? :P
[15:06:40] <aude>	 DanielK_WMDE: poke
[15:07:39] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1386 (master - c2143f1 : Marius Hoch): The build is still failing.
[15:07:39] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/15da1275e0dd...c2143f1ab55f
[15:07:39] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15229205
[15:07:44] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] "Much better!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100187 (owner: 10Aude)
[15:08:06] <DanielK_WMDE>	 aude: that? --^
[15:08:41] <hoo>	 funny that random all de tests failed :P
[15:09:06] <DanielK_WMDE>	 hoo: well, they leak state, and travis executes them in parallel, so...
[15:09:40] <hoo>	 the failures I saw myself yesterday were weird either
[15:11:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100187 (owner: 10Aude)
[15:12:12] <reimann>	 ☝
[15:15:12] <aude>	 DanielK_WMDE: not sure i totally like the approach, but can work for now
[15:15:38] <aude>	 it's more difficult to test
[15:17:22] <GerardM>	 I am more and more convinced that we should consider not having manual descriptions. They are typically of poor quality and, the automatically generated descriptions are typically more informative .. 
[15:17:27] <GerardM>	 what do you think ?
[15:17:33] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Ensure entityselector's suggestion list is assigned absolute position [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99368 (owner: 10Henning Snater)
[15:17:40] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] $.ui.suggester: Added functionality to flip horizontal offset [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/99367 (owner: 10Henning Snater)
[15:17:42] <grrrit-wm>	 (03Abandoned) 10Aude: Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100487 (owner: 10Aude)
[15:18:00] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 (owner: 10Addshore)
[15:18:24] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1387 (master - 6ca2e35 : jenkins-bot): The build is still failing.
[15:18:24] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c2143f1ab55f...6ca2e35533d1
[15:18:24] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15229775
[15:18:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: $.ui.suggester: Added functionality to flip horizontal offset [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/99367 (owner: 10Henning Snater)
[15:18:39] <addshore>	 oh heh aude https://gerrit.wikimedia.org/r/#/c/98099/3/repo/tests/phpunit/includes/api/ResultBuilderTest.php
[15:18:50] <addshore>	 that should fix the result builder tests for you xD I forgot about that patch though!
[15:19:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 (owner: 10Addshore)
[15:19:05] <addshore>	 :P
[15:19:08] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 (owner: 10Aude)
[15:19:11] <addshore>	 which means I just conflicted myself! :D
[15:19:36] <aude>	 addshore: really?
[15:20:11] <addshore>	 yup
[15:21:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ensure entityselector's suggestion list is assigned absolute position [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99368 (owner: 10Henning Snater)
[15:21:08] <grrrit-wm>	 (03PS4) 10Addshore: Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 
[15:22:18] <grrrit-wm>	 (03Draft10) 10Henning Snater: Implemented ValueParserFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98164 
[15:22:29] <grrrit-wm>	 (03Draft5) 10Henning Snater: Adjustments due to implementation of ValueParserFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98165 
[15:22:39] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 031] Implemented ValueParserFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98164 (owner: 10Henning Snater)
[15:22:44] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-2] "https://gerrit.wikimedia.org/r/#/c/98099/ should fix the issue" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 (owner: 10Addshore)
[15:23:44] <Tobi_WMDE>	 Lydia_WMDE: aude: Henning_WMDE: do we want to backport the fix for the search-box issue (https://bugzilla.wikimedia.org/show_bug.cgi?id=57817) ?
[15:23:53] <Henning_WMDE>	 yes
[15:24:13] <grrrit-wm>	 (03CR) 10Aude: [C: 032] "it works! :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 (owner: 10Addshore)
[15:24:20] <Lydia_WMDE>	 Tobi_WMDE: yes
[15:24:41] <aude>	 Tobi_WMDE: let's not wait until after holidays, so yes
[15:25:02] <Tobi_WMDE>	 ok, then I'm gonna do it
[15:25:09] <aude>	 k
[15:26:30] <grrrit-wm>	 (03Abandoned) 10Addshore: Fix ResultBuilderTest fail when items in ns 0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99363 (owner: 10Addshore)
[15:27:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Inject EntityTitleLookup to ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98099 (owner: 10Addshore)
[15:28:49] <grrrit-wm>	 (03PS1) 10Tobias Gritschacher: Ensure entityselector's suggestion list is assigned absolute position [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100575 
[15:29:03] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1388 (master - 7fb512d : jenkins-bot): The build is still failing.
[15:29:03] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/6ca2e35533d1...7fb512db9566
[15:29:03] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15230320
[15:29:42] <grrrit-wm>	 (03PS1) 10Tobias Gritschacher: $.ui.suggester: Added functionality to flip horizontal offset [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100576 
[15:30:00] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Ensure entityselector's suggestion list is assigned absolute position [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100575 (owner: 10Tobias Gritschacher)
[15:30:15] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] $.ui.suggester: Added functionality to flip horizontal offset [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100576 (owner: 10Tobias Gritschacher)
[15:31:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: $.ui.suggester: Added functionality to flip horizontal offset [extensions/DataValues] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100576 (owner: 10Tobias Gritschacher)
[15:34:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ensure entityselector's suggestion list is assigned absolute position [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100575 (owner: 10Tobias Gritschacher)
[15:40:39] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] Require cache key and duration constructor params (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100188 (owner: 10Aude)
[15:42:06] <grrrit-wm>	 (03PS1) 10Jens Ohlig: Add mw.wikibase.properties as a Lua function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 
[15:44:00] <grrrit-wm>	 (03PS2) 10Jens Ohlig: Add mw.wikibase.properties as a Lua function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 
[15:44:20] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1389 (master - 0d58dc6 : jenkins-bot): The build was fixed.
[15:44:20] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7fb512db9566...0d58dc60bb14
[15:44:21] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15230893
[15:46:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add mw.wikibase.properties as a Lua function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 (owner: 10Jens Ohlig)
[15:47:09] <grrrit-wm>	 (03PS4) 10Aude: Require cache key and duration constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100188 
[15:47:28] <aude>	 addshore: ^
[15:48:20] <addshore>	 [=
[15:48:39] <aude>	 has dependency
[15:49:23] <aude>	 fun working on long chain of stuff :)
[15:49:48] <addshore>	 the dependancy is merged ;p
[15:50:06] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Require cache key and duration constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100188 (owner: 10Aude)
[15:50:23] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] "Needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 (owner: 10Aude)
[15:51:19] * addshore  wait for the next bit of the chain to be ready :D

[15:53:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Require cache key and duration constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100188 (owner: 10Aude)
[15:54:35] <aude>	 :)
[15:55:22] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1390 (master - 44b2c17 : jenkins-bot): The build is still failing.
[15:55:22] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/0d58dc60bb14...44b2c177d830
[15:55:22] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15231265
[15:56:11] <grrrit-wm>	 (03PS3) 10Jens Ohlig: Add mw.wikibase.properties as a Lua function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 
[15:58:56] <grrrit-wm>	 (03PS11) 10Henning Snater: Implemented ValueParserFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98164 
[15:59:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add mw.wikibase.properties as a Lua function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 (owner: 10Jens Ohlig)
[16:06:46] <grrrit-wm>	 (03PS1) 10Aude: Merge "Require cache key and duration constructor params" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100580 
[16:07:33] <aude>	 gah
[16:08:50] <addshore>	 :D
[16:12:03] <grrrit-wm>	 (03PS4) 10Aude: Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 
[16:12:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 (owner: 10Aude)
[16:12:32] <aude>	 nope
[16:13:59] <physikerwelt>	 Hi, I was considering to add custom annotations for units to the math extension. For example one could cosider to add a special command called \sec that links to https://www.wikidata.org/wiki/Q11574
[16:14:18] <physikerwelt>	 do you know if there is preliminary work concerning that
[16:15:26] <grrrit-wm>	 (03PS5) 10Aude: Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 
[16:16:34] <hoo>	 physikerwelt: I doubt there is... you should probably write up more exactly what you want to do and what you need Wikidata for in that... Lydia_WMDE is the right person to talk to, probably
[16:17:18] <physikerwelt>	 hoo: thank you
[16:20:39] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 (owner: 10Aude)
[16:21:00] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] "can now be manually rebased!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[16:22:08] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1392 (master - df91104 : jenkins-bot): The build was broken.
[16:22:08] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/44b2c177d830...df91104bdf69
[16:22:08] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15233051
[16:24:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move MockTermIndex to separate file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100189 (owner: 10Aude)
[16:24:46] <grrrit-wm>	 (03Abandoned) 10Aude: Merge "Require cache key and duration constructor params" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100580 (owner: 10Aude)
[16:27:29] <aude>	 next....
[16:27:57] <aude>	 gerrit says no
[16:29:47] <addshore>	 :D
[16:35:45] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Implemented ValueParserFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98164 (owner: 10Henning Snater)
[16:36:01] <grrrit-wm>	 (03PS5) 10Aude: Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 
[16:36:05] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Adjustments due to implementation of ValueParserFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98165 (owner: 10Henning Snater)
[16:36:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[16:36:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implemented ValueParserFactory [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/98164 (owner: 10Henning Snater)
[16:39:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adjustments due to implementation of ValueParserFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/98165 (owner: 10Henning Snater)
[16:42:28] <grrrit-wm>	 (03PS6) 10Aude: Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 
[16:42:32] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1393 (master - ce11cef : aude): The build is still failing.
[16:42:32] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/df91104bdf69...ce11cef18cc1
[16:42:32] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15234790
[16:43:46] <grrrit-wm>	 (03PS4) 10Jens Ohlig: Add mw.wikibase.properties as a Lua function Patch set 4: Make tests run under Jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 
[16:44:18] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[16:44:33] <addshore>	 mhhhm, my internet feels like its grinding to a halt :D
[16:44:42] <aude>	 yay!
[16:44:46] <aude>	 what???
[16:45:57] <aude>	 no meetings tomorrow?
[16:45:59] <aude>	 Tobi_WMDE: ?
[16:46:47] <Tobi_WMDE>	 aude: no weekly tomorrow but demotime tomorrow! yay! ;)
[16:47:35] <aude>	 oh, ok
[16:47:41] * aude  will probably miss, but who knows

[16:50:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove subclassing in TermPropertyLabelResolverTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100190 (owner: 10Aude)
[16:50:46] <aude>	 next...
[16:51:35] <Tobi_WMDE>	 aude: better stay at home if you dont feel well
[16:52:04] <aude>	 if someone wants to review https://gerrit.wikimedia.org/r/#/c/99545/ again that would be nice :)
[16:52:11] <aude>	 i simplified it
[16:52:43] <aude>	 DanielK_WMDE: ^
[16:53:11] <aude>	 if we want to do "caching" stuff there, it can be done later
[16:59:30] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1394 (master - 3120e6f : jenkins-bot): The build is still failing.
[16:59:30] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ce11cef18cc1...3120e6f18421
[16:59:30] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15235644
[17:00:13] <addshore>	 1) Wikibase\Test\PropertyInfoTableBuilderTest::testRebuildPropertyInfo
[17:00:13] <addshore>	 MWContentSerializationException: failed to deserialize
[17:00:14] <addshore>	 ;_;
[17:00:52] <aude>	 odd
[17:01:57] <hoo>	 I still couldn't figure out why the unit tests are so slow for me (with MySQL) :/
[17:02:31] * aude  doesn't get that failure

[17:03:11] <addshore>	 hoo, its because of the api tetss probably
[17:03:22] <hoo>	 addshore: Yeah... getItem is the slowest
[17:03:33] <addshore>	 I remember when I used to run them with mysql :P painfull times!
[17:04:53] <hoo>	 On SQLite they're still rather slow
[17:05:01] <hoo>	 but it's bearable (less than 15 minutes)
[17:05:07] <addshore>	 hmmmm
[17:05:39] <addshore>	 gimmie a sec, I will run mine and see how fast they are :)
[17:06:11] <addshore>	 which tests do you run? 
[17:06:28] <hoo>	 addshore: All with group Wikibase usually
[17:06:45] <hoo>	 now trying with --exclude-group=GetEntitiesTest
[17:06:58] <hoo>	 let's see
[17:09:07] <DanielK_WMDE>	 aude: you left the now unused $messages member in EntityView
[17:10:16] <Tobi_WMDE>	 aude: when will there be deployment today?
[17:10:53] <aude>	 DanielK_WMDE: ok
[17:11:06] <grrrit-wm>	 (03PS3) 10Aude: Cleanup code in TermPropertyLabelResolver, split up method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100191 
[17:11:39] <aude>	 Tobi_WMDE: in about 2 hours
[17:11:51] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: Fix conflict resolution when the patch is empty. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100586 
[17:12:16] <DanielK_WMDE>	 Tobi_WMDE: --^
[17:12:31] <grrrit-wm>	 (03CR) 10Aude: [C: 04-2] "way the cache key is handled now, the tests here may need some rework" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100192 (owner: 10Aude)
[17:12:50] <hoo>	 Is there a way to search gerrit for patches whcih can/can't be merged
[17:12:54] <hoo>	 like canmerge:yes
[17:13:11] <Tobi_WMDE>	 aude: ok. we have one big issue left regarding the ordering of claims but DanielK_WMDE has a fix for it. I would need about 30 mins to run relevant tests on it and would then backport it so that it can go in before deployment. that would work out I think..
[17:13:27] <aude>	 ok
[17:13:57] <DanielK_WMDE>	 that's actually a rather emberrassing bug in my code, that went unnoticed for more than a year :)
[17:14:02] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1395 (master - 0681be4 : jenkins-bot): The build has errored.
[17:14:02] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3120e6f18421...0681be4f26fb
[17:14:02] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15236275
[17:14:10] <DanielK_WMDE>	 i guess we don't often have empty patches in conflict resolution
[17:14:11] <addshore>	 hoo, everything in wikibase group for me takes 6 mins 15 seconds :)
[17:14:12] <hoo>	 "Time: 7.31 minutes, Memory: 271.75Mb" wow...
[17:14:33] <hoo>	 So it spends almost half of the time in getentities
[17:15:01] <grrrit-wm>	 (03PS4) 10Aude: Remove unused params in EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99545 
[17:15:13] * aude  has a spreadsheet with all the test times

[17:15:19] <addshore>	 I tend not to run all of the tests together though
[17:15:21] <addshore>	 aude, really?
[17:15:22] <aude>	 should make a report out of it :)
[17:15:24] <aude>	 yeah
[17:15:26] <aude>	 repo only
[17:15:30] <addshore>	 where? :O
[17:15:36] <Tobi_WMDE>	 https://gerrit.wikimedia.org/r/#/c/100000 :-D
[17:15:46] <aude>	 on my computer :)
[17:15:49] <hoo>	 addshore: Yes, unless I'm working on something specific
[17:15:51] <aude>	 maybe can put on labs
[17:16:06] <hoo>	 then I don't have the time to wait 14 minutes
[17:16:10] <addshore>	 aude: or good docs ;p
[17:18:24] <aude>	 http://tools.wmflabs.org/audetools/wikibase.csv
[17:18:35] <aude>	 gdocs good idea
[17:19:44] * aude  doing

[17:22:38] <DanielK_WMDE>	 hey Abraham_WMDE
[17:22:40] <hoo>	 "Time: 7.18 minutes, Memory: 214.50Mb" ... these are only the getentities tests
[17:22:45] <hoo>	 (SQLite)
[17:23:07] <DanielK_WMDE>	 hoo: kill it! kill it!
[17:25:05] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Remove unused params in EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99545 (owner: 10Aude)
[17:26:35] <aude>	 addshore: import to gdocs fail
[17:26:55] <aude>	 anyone can use my csv ( really is tab separated) and make a gdoc or whatever
[17:27:29] <aude>	 gdocs doesn't like this many rows (e.g. so many tests)
[17:27:51] <aude>	 thanks hoo
[17:28:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused params in EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99545 (owner: 10Aude)
[17:39:40] <grrrit-wm>	 (03PS1) 10Vldandrew: Merge "Remove unused params in EntityView::getHtmlForEditSection" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 
[17:39:44] <Abraham_WMDE>	 DanielK_WMDE: hi
[17:40:04] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Fix conflict resolution when the patch is empty. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100586 (owner: 10Daniel Kinzler)
[17:40:56] <grrrit-wm>	 (03PS2) 10Vldandrew: Merge "Remove unused params in EntityView::getHtmlForEditSection" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 
[17:41:52] <hoo>	 DanielK_WMDE: wtf https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/15236276
[17:42:03] <hoo>	 das war das Ding, für das ich einen Patch hatte :/
[17:42:32] <hoo>	 https://gerrit.wikimedia.org/r/100525 fixes that
[17:42:34] <hoo>	 ewk
[17:43:19] <grrrit-wm>	 (03Restored) 10Hoo man: Fix unit tests in Travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100525 (owner: 10Hoo man)
[17:43:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix conflict resolution when the patch is empty. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100586 (owner: 10Daniel Kinzler)
[17:45:31] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 04-1] Migrate simple RSpec browser tests to Cucumber. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100591 (owner: 10Vldandrew)
[17:45:58] <Lydia_WMDE>	 !admin https://www.wikidata.org/wiki/Special:Contributions/Kalabarian
[17:46:09] <Lydia_WMDE>	 already fixed the edits he made
[17:46:15] <Lydia_WMDE>	 might want to block
[17:46:34] * aude  sighs

[17:47:00] <SannitAway>	 Lydia_WMDE: yellow card for now, but at the next edit I'll block him/her
[17:47:05] <Lydia_WMDE>	 k
[17:47:06] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1396 (master - cee28b2 : jenkins-bot): The build failed.
[17:47:07] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/0681be4f26fb...cee28b23fe33
[17:47:07] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15238104
[17:47:21] <hoo>	 probably still some kind of good faith... the user is active on enwiki a bit
[17:48:13] <grrrit-wm>	 (03PS1) 10Tobias Gritschacher: Fix conflict resolution when the patch is empty. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100593 
[17:48:27] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Fix conflict resolution when the patch is empty. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100593 (owner: 10Tobias Gritschacher)
[17:48:31] <hoo>	 Either some of our tests miss a @group Database or that simply is broken
[17:48:54] <DanielK_WMDE>	 addshore: any idea what the status of this one is? https://bugzilla.wikimedia.org/show_bug.cgi?id=47213
[17:49:10] <hoo>	 I still have several pages in my DB after a test run
[17:49:17] <DanielK_WMDE>	 hoo: tests using hardcoded entity ids cause these failures
[17:49:33] <DanielK_WMDE>	 ...and cause them in random *other* tests
[17:49:54] <DanielK_WMDE>	 hoo: after the test run, you should have the same pages as before
[17:50:02] <hoo>	 that's not the case
[17:50:04] <DanielK_WMDE>	 if that is not the case, we are missing a @group Database indeed.
[17:50:13] <Tobi_WMDE>	 Lydia_WMDE: DanielK_WMDE fixed the problem with those ordering-edits which undid previous edits
[17:50:14] <hoo>	 the tests created 5 pages on my test wiki
[17:50:25] <DanielK_WMDE>	 hoo: cxan you find out the ids and contents of the "extra" pages?
[17:50:31] <hoo>	 which was completely new empty installation
[17:50:33] <Lydia_WMDE>	 DanielK_WMDE: you deserve cookies!
[17:50:34] <Lydia_WMDE>	 :D
[17:50:37] <Lydia_WMDE>	 thanks a lot
[17:50:38] <Tobi_WMDE>	 I've now backported it and that should be fine for deployment now
[17:50:42] <Lydia_WMDE>	 awesome
[17:50:43] <DanielK_WMDE>	 Lydia_WMDE: \o/
[17:50:49] <Lydia_WMDE>	 you're the best
[17:50:59] <Tobi_WMDE>	 giant cookies
[17:51:00] <Tobi_WMDE>	 :)
[17:51:00] <hoo>	 |              0 | Berlin     |
[17:51:01] <hoo>	 |              0 | Main_Page  |
[17:51:01] <hoo>	 |              0 | Rome       |
[17:51:01] <hoo>	 |            122 | P42        |
[17:51:01] <hoo>	 |            122 | P7201010   |
[17:51:01] <hoo>	 |            122 | P9001    
[17:51:03] <Lydia_WMDE>	 haha
[17:51:19] * hoo  feels cokieless

[17:51:20] <DanielK_WMDE>	 hoo: can you mail me that and the json of these pages?
[17:51:29] * Lydia_WMDE  hands hoo a small cookie

[17:51:32] <DanielK_WMDE>	 from special:export
[17:51:49] <hoo>	 DanielK_WMDE: Will do
[17:51:52] <DanielK_WMDE>	 thanks
[17:54:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix conflict resolution when the patch is empty. [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100593 (owner: 10Tobias Gritschacher)
[17:55:09] <Tobi_WMDE>	 aude: backport is done, should be fine from my side now
[18:03:05] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1397 (master - e85e455 : jenkins-bot): The build failed.
[18:03:05] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/cee28b23fe33...e85e45557fba
[18:03:05] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15238907
[18:03:30] <hoo>	 that one's getting old, travis-ci
[18:04:06] <aude>	 Tobi_WMDE: yay
[18:06:53] <grrrit-wm>	 (03CR) 10Aude: Improve function documentation in LanguageFallbackChain (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99556 (owner: 10Aude)
[18:06:57] <grrrit-wm>	 (03PS3) 10Aude: Improve function documentation in LanguageFallbackChain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99556 
[18:07:09] <grrrit-wm>	 (03PS5) 10Aude: Add test for EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 
[18:07:46] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Improve function documentation in LanguageFallbackChain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99556 (owner: 10Aude)
[18:08:12] <hoo>	 I like such small changes :P Easy to understand, easy to review
[18:08:20] <aude>	 :)
[18:08:52] <hoo>	 Sadly that's not really possible if you have such a mess like in ChangesList.php
[18:09:13] <aude>	 yeah
[18:09:44] <aude>	 or no tests for it
[18:14:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve function documentation in LanguageFallbackChain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99556 (owner: 10Aude)
[18:16:11] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Trivial test change (already +2ed twice before...)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 (owner: 10Aude)
[18:18:20] <aude>	 yay, gerrit dashboard is smaller :)
[18:19:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add test for EntityView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/99557 (owner: 10Aude)
[18:23:40] <hoo>	 aude: Is it "tabslist" or "tabs list"?
[18:24:27] <aude>	 what context?
[18:24:39] <hoo>	 'Tip: You can use the left and right arrow keys to navigate between the tabs in the tabs list.'
[18:25:01] <aude>	 two words
[18:25:09] <hoo>	 Ok, thanks :)
[18:37:58] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1399 (master - b4fd666 : aude): The build is still failing.
[18:37:58] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/e85e45557fba...b4fd6667d9c9
[18:37:58] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15240600
[18:40:12] <benestar>	 Having a new 'crat
[18:48:49] <aude>	 hmmm capiunto changes should be reported here
[18:49:01] <hoo>	 Yeah
[18:49:08] <hoo>	 There can I change that?
[18:49:10] * aude  making patch

[18:49:13] <hoo>	 * where
[18:49:15] <hoo>	 Thanks :)
[18:51:41] <aude>	 https://gerrit.wikimedia.org/r/#/c/100607/
[18:52:08] <aude>	 legoktm: want to approve? ^
[18:52:51] <aude>	 yay
[18:53:03] <hoo>	 aude: Already +2ed ... not controversial
[18:53:45] * aude  can deploy the change

[18:53:49] <aude>	 when done eating 
[18:53:54] <hoo>	 :)
[18:54:32] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1400 (master - c5d9750 : aude): The build is still failing.
[18:54:32] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/b4fd6667d9c9...c5d97500c061
[18:54:32] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15240905
[19:04:52] <grrrit-wm>	 (03CR) 10Hoo man: "I think we should use a coding style in Lua which is more bold and easier to read (see also inline comments)." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 (owner: 10Jens Ohlig)
[19:05:07] <grrrit-wm>	 (03CR) 10Hoo man: [C: 04-1] Add mw.wikibase.properties as a Lua function Patch set 4: Make tests run under Jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100577 (owner: 10Jens Ohlig)
[19:27:17] <aude>	 hoo:  can i edit the commit message in https://gerrit.wikimedia.org/r/#/c/100411/ ?
[19:27:30] <DanielK_WMDE>	 hey
[19:27:41] <hoo>	 aude: Sure, go ahead ;)
[19:27:45] <aude>	 ok
[19:28:05] <aude>	 darn
[19:30:07] <grrrit-wm>	 (03PS4) 10Aude: Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man)
[19:30:24] <grrrit-wm>	 (03PS5) 10Aude: Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man)
[19:30:29] <aude>	 there 
[19:30:32] <hoo>	 :))
[19:32:34] <hoo>	 DanielK_WMDE: merge https://gerrit.wikimedia.org/r/100411 :D
[19:32:40] <hoo>	 or aude
[19:33:40] <aude>	 i have to install the extension
[19:33:46] <hoo>	 aude: :)
[19:34:03] * aude  just notes scap trap when we do deploy... with new magic word

[19:34:09] <aude>	 but assume we'll have it on test2 first
[19:34:14] <hoo>	 You can use the examples from https://en.wikipedia.org/wiki/Template:Infobox, you just have to make the {{infobox {{#infobox: ;)
[19:34:18] <aude>	 ok
[19:34:54] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 04-1] Changed Alias to use snake case (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011)
[19:44:41] <aude>	 Lydia_WMDE: https://www.wikidata.org/w/index.php?title=Q607&diff=92619580&oldid=91766650
[19:44:46] <grrrit-wm>	 (03CR) 10Zfilipin: "Tobi, is there anything else that needs to be done or did this commit cover everything? Can you test if this commit breaks anything?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/100209 (owner: 10Aaron1011)
[19:44:48] <aude>	 it it supposed to show as no difference?
[19:44:52] <aude>	 DanielK_WMDE: Tobi_WMDE 
[19:45:15] <Lydia_WMDE>	 aude: sort order change?
[19:45:16] <Lydia_WMDE>	 yes
[19:45:30] <Lydia_WMDE>	 needs to be fixed but for now it does not show a diff
[19:45:35] <aude>	 hmmm, ok then known issue
[19:45:47] <Lydia_WMDE>	 yeah
[19:45:57] <Lydia_WMDE>	 aude: all good then with deployment?
[19:46:09] <aude>	 seems so
[19:46:13] <aude>	 please poke around
[19:46:19] <Lydia_WMDE>	 ok - doing now
[19:46:25] <DanielK_WMDE>	 aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=58274
[19:46:30] <aude>	 k
[19:46:36] <aude>	 there might be some caching too
[19:46:40] <aude>	 e.g. refresh js
[19:46:48] <Lydia_WMDE>	 aude: hmm i have a toc but no ranks and sorting
[19:46:51] <Lydia_WMDE>	 refreshing now
[19:47:33] <aude>	 refreshing worked for me
[19:48:28] <Lydia_WMDE>	 ewww
[19:48:31] <Lydia_WMDE>	 in one browser it worked
[19:48:38] <DanielK_WMDE>	 Lydia_WMDE: discussed JS speed improvements with henning earlier. we have a plan, sort of. poke me about it tomorrow
[19:48:40] <Lydia_WMDE>	 but https://www.wikidata.org/wiki/Q6581097 for example shows in hrebrew in the other partly
[19:48:44] <DanielK_WMDE>	 if i come in. not feeling to well.
[19:48:53] <Lydia_WMDE>	 DanielK_WMDE: ok - get well soon :)
[19:49:07] <Lydia_WMDE>	 and no ranks and sorting in that either
[19:49:10] <Lydia_WMDE>	 strange
[19:49:11] <DanielK_WMDE>	 doing my best :)
[19:49:34] <Lydia_WMDE>	 aude: and now another property in the other browser in japanese
[19:49:40] <Lydia_WMDE>	 something with cashing is very very wrong
[19:49:46] <DanielK_WMDE>	 eek.
[19:49:56] <DanielK_WMDE>	 i thought we fixed that?!
[19:50:00] <Lydia_WMDE>	 seeing it too?
[19:50:08] <Lydia_WMDE>	 seems not
[19:51:17] <DanielK_WMDE>	 fighting script timeouts :/
[19:51:17] <aude>	 ick
[19:51:19] <addshore>	 oh wow, nice caching there!"
[19:51:21] <aude>	 link?
[19:51:38] <aude>	 for js improvements, i have ideas
[19:51:41] <DanielK_WMDE>	 but... labels in *different* languages? wtf?
[19:51:42] <aude>	 can discuss later
[19:51:43] <Lydia_WMDE>	 https://www.wikidata.org/wiki/Property:P442
[19:51:56] <DanielK_WMDE>	 if anything, labels should be consistently cached in one (possibly wrong) language
[19:51:56] <Lydia_WMDE>	 let's first fix this
[19:51:58] <Lydia_WMDE>	 this is bad
[19:52:06] <aude>	 ewww
[19:52:07] * addshore  goes eww

[19:52:09] <Lydia_WMDE>	 indeed
[19:52:10] <Lydia_WMDE>	 ;-)
[19:52:12] <rschen7754>	 eww
[19:52:16] <Lydia_WMDE>	 at least only on properties it seems....
[19:52:31] <aude>	 how is this possible?
[19:52:37] * aude  gets german

[19:52:49] <Lydia_WMDE>	 i get something similar to german
[19:53:02] <Lydia_WMDE>	 for the above link
[19:53:09] <hoo>	 aude: Yeah... that's not German
[19:53:11] <DanielK_WMDE>	 aude, Lydia_WMDE: hypothesis: you are seeing the page for a different language from the parser cache
[19:53:12] <hoo>	 probably bar
[19:53:20] <Lydia_WMDE>	 DanielK_WMDE: might be
[19:53:29] <aude>	 looks like german to me 
[19:53:30] <aude>	 :)
[19:53:32] <Lydia_WMDE>	 hehe
[19:53:38] <DanielK_WMDE>	 Saved in parser cache with key wikidatawiki:pcache:idhash:6406677-0!*!*!*!*!*!*
[19:53:40] <hoo>	 <!-- Saved in parser cache with key wikidatawiki:pcache:idhash:12660802-0!*!*!*!*!*!* and timestamp 20131205103339
[19:53:44] <DanielK_WMDE>	 see all the * back there?
[19:53:52] <DanielK_WMDE>	 one of them should be your user language
[19:53:59] <DanielK_WMDE>	 i don't understand why that is not the case...
[19:53:59] <Lydia_WMDE>	 that should be fixed though no?
[19:54:00] <hoo>	 damn, Daniel bet me :P
[19:54:01] <aude>	 no lang
[19:54:03] <Lydia_WMDE>	 only fixed it for items?
[19:54:17] <Lydia_WMDE>	 items seem to be fine
[19:54:20] <Lydia_WMDE>	 at least here
[19:54:29] <DanielK_WMDE>	 Lydia_WMDE: well, we are using the parser cache now, which may be the cause of the problem, if the wrong keys are used
[19:54:35] <DanielK_WMDE>	 and it does look like they are wrong
[19:54:42] <Lydia_WMDE>	 yeah
[19:54:44] <addshore>	 indeed for items it is  Saved in parser cache with key wikidatawiki:pcache:idhash:11603417-0!*!*!*!en!*!* and timestamp 20131210195416 :P
[19:54:52] <DanielK_WMDE>	 Lydia_WMDE: i'm seeing full pages in hebrew...
[19:54:58] <Lydia_WMDE>	 wtf
[19:55:24] <DanielK_WMDE>	 it might be that we are seeing stuff cached before the new code was deployed
[19:55:28] <DanielK_WMDE>	 using the wrong cache key
[19:55:38] <Lydia_WMDE>	 :/
[19:55:46] <Lydia_WMDE>	 so we need to empty the cache?
[19:56:02] <DanielK_WMDE>	 quite possibly
[19:56:29] <DanielK_WMDE>	 might also be the cache of parser cache keys (confusing, i know - i don't really understand that bit myself)
[19:56:32] <Lydia_WMDE>	 i am seeing things in the in other languages box that are not for my language
[19:56:33] <aude>	 if it's only properties they can be purged
[19:56:34] <hoo>	 EntityView::makeParserOptions should do ParserOptions::getUserLangObj AFAIS 
[19:56:45] <Lydia_WMDE>	 on an item
[19:56:52] <DanielK_WMDE>	 aude: i'm seeing https://www.wikidata.org/wiki/Q6581097 in hebrew
[19:57:04] <Lydia_WMDE>	 so it is not just properties
[19:57:07] <Lydia_WMDE>	 -.-
[19:57:40] <DanielK_WMDE>	 we can turn off the parser cache again easily enough
[19:57:56] <DanielK_WMDE>	 would be a shame, but should instantly fix this.
[19:57:58] <aude>	 ick
[19:58:01] <aude>	 let's do that
[19:58:04] <Lydia_WMDE>	 let's do that if we can't fix it otherwise in the next 30 mins?
[19:58:04] <DanielK_WMDE>	 going back to "slow as before, maybe slower"
[19:58:10] <Lydia_WMDE>	 yeah
[19:58:45] <DanielK_WMDE>	 it's frustrating to be blind - i can't see what's going on. just strange symptoms
[19:58:51] <DanielK_WMDE>	 where is House when you need him?
[19:58:56] <Lydia_WMDE>	 rofl
[19:59:06] * lbenedix  wanted to ask, if wd is only slow for him

[19:59:11] <aude>	 if it's simplet o fix, we can backport and deploy it like on thursday
[19:59:41] <Lydia_WMDE>	 aude: so turn off now and investigate then?
[20:00:26] <DanielK_WMDE>	 aude, Lydia_WMDE: i purged https://www.wikidata.org/wiki/Q6581097, and it seems fine now
[20:00:43] <DanielK_WMDE>	 (showing content in the appropriate language in two  browsers)
[20:00:59] <Lydia_WMDE>	 DanielK_WMDE: shows only one language though for me in the in other languages box
[20:01:04] <Lydia_WMDE>	 should be 3
[20:01:14] <DanielK_WMDE>	 please check whether you can fix all the issues you are seeing using action=purge, and check whether you see the correct language via uselang=xx
[20:01:29] <Lydia_WMDE>	 k
[20:01:47] <aude>	 https://www.wikidata.org/wiki/Property:P442 looks okay now
[20:01:49] <Lydia_WMDE>	 no
[20:01:55] <Lydia_WMDE>	 now it shows no language box 
[20:01:57] <Lydia_WMDE>	 :D
[20:02:07] <DanielK_WMDE>	 Lydia_WMDE: ...oh. the "other languages" box. err... that's per user info. that's not cachable. i completely forgot about that
[20:02:17] <Lydia_WMDE>	 ok
[20:02:25] <Lydia_WMDE>	 so let's turn it off and try again later?
[20:02:25] <DanielK_WMDE>	 i thought that was JS generated, though?
[20:02:31] <Lydia_WMDE>	 i think not
[20:02:34] <Lydia_WMDE>	 but not sure
[20:02:36] <DanielK_WMDE>	 guh
[20:02:57] <DanielK_WMDE>	 then we need to inject it into the cached content when pushing the page out
[20:03:01] <DanielK_WMDE>	 doable tomorrow
[20:03:03] <DanielK_WMDE>	 not today
[20:03:11] <Lydia_WMDE>	 right
[20:03:11] <hoo>	 It's not JS, no
[20:03:13] <lbenedix>	 something is very broken in wikidata right now
[20:03:18] <Lydia_WMDE>	 lbenedix: we know ;-)
[20:03:21] <Lydia_WMDE>	 working on it
[20:03:25] <DanielK_WMDE>	 lbenedix: try purging the page and tell us whether that fixes it
[20:03:43] <Lydia_WMDE>	 ok folks, let's turn it off for today
[20:03:45] <lbenedix>	 but I see ranks 
[20:03:48] <DanielK_WMDE>	 Lydia_WMDE: not sure though how to address the "old stuff in the parser cache" issue, though.
[20:03:53] <DanielK_WMDE>	 may need an evil hack.
[20:03:55] <aude>	 patch coming
[20:03:56] <Lydia_WMDE>	 k
[20:04:00] <Lydia_WMDE>	 aude: <3
[20:04:08] <aude>	 DanielK_WMDE: we'll have parser cache not supported
[20:04:08] <grrrit-wm>	 (03PS1) 10Aude: Disable parser cache [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100621 
[20:04:10] <lbenedix>	 the load time is extremely bad
[20:04:50] <lbenedix>	 purge helps with all the russian string
[20:05:07] <hoo>	 aude: Testing
[20:05:26] <aude>	 it's a revert of https://gerrit.wikimedia.org/r/#/c/98511/3
[20:05:36] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] ">_<" [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100621 (owner: 10Aude)
[20:05:38] <aude>	 but gerrit didn't like simple git revert
[20:05:39] * Lydia_WMDE  prepares message for mailing list and project chat

[20:05:42] <aude>	 commit hash
[20:06:03] <aude>	 sorting seems nice 
[20:06:06] <aude>	 and ranks
[20:06:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Disable parser cache [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100621 (owner: 10Aude)
[20:06:23] <aude>	 huh
[20:06:30] <DanielK_WMDE>	 guh
[20:06:30] <aude>	 maybe i didn't update tests
[20:06:44] <Stryn>	 why https://www.wikidata.org/wiki/Q6581097#claims does not work... nothing happens if I click "Statements"
[20:06:46] <aude>	 but your patch didn't change tests
[20:07:02] <DanielK_WMDE>	 aude: branch has already diverged
[20:07:11] <DanielK_WMDE>	 aude: please run the tests manually
[20:07:13] <DanielK_WMDE>	 let#s skip jenkins
[20:07:20] <aude>	 PropertyView::getFlag()
[20:07:26] <aude>	 wtf
[20:07:36] <hoo>	 on master it works, duh
[20:07:36] <aude>	 ok
[20:07:42] * aude  testing

[20:08:28] <aude>	 if someoen could see what this get flag thing is
[20:09:40] <aude>	 fails for me
[20:11:46] <hoo>	 aude: I don't see this function anywhere in any of the parent classes
[20:11:52] <aude>	 it's in wiki page
[20:12:12] <aude>	 WikiPage.php on line 2081
[20:13:15] <DanielK_WMDE>	 aude: yes. and it makes no sense
[20:13:20] <DanielK_WMDE>	 can repoduce, will debug
[20:13:26] <DanielK_WMDE>	 wow, that's an odd one. wtf?
[20:13:35] <DanielK_WMDE>	 why didn#t this show up earlier?
[20:13:43] <DanielK_WMDE>	 aude: core is also on wmf6, right?
[20:13:50] <aude>	 yes
[20:14:13] <hoo>	 WikiPage has no getFlag for me... wtf?
[20:14:34] <aude>	 i might have made a mistake
[20:14:36] <hoo>	 ah, I see what meant
[20:14:37] <aude>	 it's in parser output
[20:15:16] <aude>	 probably is a mistake
[20:15:22] <aude>	 current branch passes
[20:15:51] <DanielK_WMDE>	 aude: mPreparedEdit->output should be a ParserOutput object, but it's an PropertyView object - wtf?
[20:16:19] <aude>	 yeah stupid
[20:16:20] <DanielK_WMDE>	 aude: aaaahhh!
[20:16:21] * aude  fixing

[20:16:37] <DanielK_WMDE>	 how did i not see that? grr, reviewing in a hurry.
[20:16:39] <DanielK_WMDE>	 not good.
[20:16:50] <DanielK_WMDE>	 thanks, jenkins, for catching that one
[20:18:15] <aude>	 hurray for jenkins
[20:18:26] <grrrit-wm>	 (03PS2) 10Aude: Disable parser cache [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100621 
[20:18:27] * aude  fixing in hurry

[20:18:56] <DanielK_WMDE>	 aude: actually, the change to Entityhandler would be sufficient
[20:19:08] <DanielK_WMDE>	 if we say we don't use the cache, we can do whatever to the cache key
[20:19:14] <DanielK_WMDE>	 anyway
[20:19:26] <aude>	 i thought perhaps but not sure
[20:19:34] * aude  waits for jenkins

[20:20:35] <DanielK_WMDE>	 running tests locally too
[20:21:20] <aude>	 k
[20:21:58] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Disable parser cache [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100621 (owner: 10Aude)
[20:22:11] <aude>	 test wiki is fine also
[20:23:04] <DanielK_WMDE>	 aude, Lydia_WMDE: to actually figure out what's going on with the parser cache, i'd urgently need someone who actually understands it
[20:23:05] <Lydia_WMDE>	 aude: DanielK_WMDE: why didn't this kick our ass on test.wikidata.org?
[20:23:20] <Lydia_WMDE>	 DanielK_WMDE: any idea who that could be?
[20:23:20] <DanielK_WMDE>	 not sure how to find someone like this, without invading tim#s home...
[20:23:24] <Lydia_WMDE>	 haha
[20:23:35] <Lydia_WMDE>	 no home invasions please
[20:23:36] <aude>	 Lydia_WMDE: no idea
[20:23:36] <Lydia_WMDE>	 :P
[20:24:05] <DanielK_WMDE>	 Lydia_WMDE: the default parser caching mechanism worked fine. i tested it. i suspect the foundation is doing something special
[20:24:15] <Lydia_WMDE>	 ok
[20:24:20] <aude>	 maybe Reedy knows 
[20:24:34] <hoo>	 DanielK_WMDE: Yep, it also worked for me locally
[20:24:36] <hoo>	 all the time
[20:24:44] <DanielK_WMDE>	 there's some code there that didn't seem to get used - if it *is* used on the wmf cluster, it may cause the issue
[20:25:17] <Lydia_WMDE>	 got it
[20:25:20] <hoo>	 DanielK_WMDE: In InputBox I've made use of ParserOptions::getUserLangObj for this purpose (that also struggled on Wikidata)
[20:25:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable parser cache [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100621 (owner: 10Aude)
[20:25:34] <hoo>	 on project pages, not Entity NS, of course
[20:26:12] <Lydia_WMDE>	 DanielK_WMDE: want me to send an email to wikitech?
[20:26:33] <DanielK_WMDE>	 Lydia_WMDE, aude: specifically, I want to know what the intention is behind the following line in ParserCache::getKey: $optionsKey = $this->mMemc->get( $this->getOptionsKey( $article ) );
[20:26:42] <DanielK_WMDE>	 this gets a cache key from the cache. 
[20:26:47] <DanielK_WMDE>	 o_O
[20:26:54] <DanielK_WMDE>	 it would be the same for all users, then. 
[20:27:14] <DanielK_WMDE>	 why? how? when? what for?...
[20:27:33] <DanielK_WMDE>	 this always came back empty when i testewd caching
[20:27:43] * aude  is unfamiliar with that

[20:27:47] <aude>	 would need to poke
[20:28:22] <Lydia_WMDE>	 aude: please let me know when the cache fix is live - will be back in 5
[20:28:24] <aude>	 Aaron might also know something
[20:28:31] <DanielK_WMDE>	 yea.
[20:29:09] <DanielK_WMDE>	 what is happening there does not make any sense to me at all.
[20:29:46] <DanielK_WMDE>	 it would if getOptionsKey() would actually look at what options are relevant for caching
[20:29:49] <DanielK_WMDE>	 but it doesn't!
[20:30:33] <DanielK_WMDE>	 i'm confused as to why this didn't hit me during testing - i see no reason in the code
[20:34:12] <DanielK_WMDE>	 hm... i smell a core patch coming up
[20:34:23] <aude>	 huh, ok
[20:34:34] <DanielK_WMDE>	 getOptionsKey (and maybe also getOptionshash) may need to be handled via Contenthandler
[20:34:40] <DanielK_WMDE>	 so we can override it
[20:36:33] <Lydia_WMDE>	 re
[20:38:38] <aude>	 being deployed
[20:39:57] <Lydia_WMDE>	 \o/
[20:40:20] <aude>	 waiting for jenkins etc
[20:40:27] <Lydia_WMDE>	 cool
[20:40:46] <aude>	 ok, no wait for jenkins :)
[20:40:49] <Lydia_WMDE>	 DanielK_WMDE: aude: let's write an email to wikitech tomorrow asking for advice - reenabling isn't super urgent after all
[20:40:53] <Lydia_WMDE>	 heh
[20:41:10] <aude>	 sure, though also directly asking tim maybe
[20:41:16] <Lydia_WMDE>	 yeah
[20:41:19] <aude>	 try wikitech first
[20:41:36] <Lydia_WMDE>	 we can put him in cc
[20:41:48] <aude>	 meanwhile lets' talk sometime about the js and the way the dom is generated 
[20:41:55] <Lydia_WMDE>	 jep
[20:42:07] <aude>	 if entity view handled more in php, etc....
[20:42:13] <Lydia_WMDE>	 we talked about initialising some of the widgets only when needed
[20:42:15] <aude>	 the non-js version is very inferior
[20:42:22] <Lydia_WMDE>	 yeah that is the other thing to do
[20:42:27] <Lydia_WMDE>	 jep
[20:42:28] <aude>	 well that requires the non-js version to be equal
[20:42:37] <Lydia_WMDE>	 and doing more in php is now possible 
[20:42:40] <Lydia_WMDE>	 so we should do it
[20:42:42] <aude>	 yes
[20:43:21] <aude>	 deployed
[20:43:33] <Lydia_WMDE>	 sweet
[20:43:41] <Lydia_WMDE>	 i will email and post to project chat
[20:43:48] <aude>	 if anything looks wrong then just purge the page
[20:43:57] <aude>	 i dont' think that many item are affected
[20:43:57] <Lydia_WMDE>	 will add that to the note
[20:44:01] <Lydia_WMDE>	 yeah
[20:46:33] <DanielK_WMDE>	 Lydia_WMDE, aude: i was already typing the mail. sent now.
[20:46:40] <DanielK_WMDE>	 writing it tomorrow sucks, time-zone wise
[20:46:46] <DanielK_WMDE>	 costs a day
[20:46:50] <Lydia_WMDE>	 DanielK_WMDE: cool :P
[20:46:51] <aude>	 k
[20:46:51] <Lydia_WMDE>	 thx
[20:46:55] <Lydia_WMDE>	 true
[20:50:48] <Lydia_WMDE>	 peeps: anyone up for updating the news section on the frontpage?
[20:51:08] <DanielK_WMDE>	 Lydia_WMDE, aude: i take it the fix actually fixed the issue?
[20:51:20] <Lydia_WMDE>	 DanielK_WMDE: seems so here at least
[20:51:49] * aude  thinks so

[20:51:51] <DanielK_WMDE>	 btw: this is adding database load. we are no longer taking full entities from memcached, but hitting the DB with queries for labels, data types, etc. saves memory, not time.
[20:52:06] <DanielK_WMDE>	 the idea was to make this irrelevant by using the parser cache
[20:52:09] <DanielK_WMDE>	 now we don't.
[20:52:12] <Lydia_WMDE>	 k
[20:52:22] <Lydia_WMDE>	 so we should fix this soon after all
[20:52:27] <DanielK_WMDE>	 yea
[20:52:32] <aude>	 we can look at fixes
[20:52:50] <aude>	 if there are isolated changes that can help, i'd be open to backporting them
[20:53:05] <aude>	 or we can figure otu the parser cache
[20:54:23] * Lydia_WMDE  is unreasonably happy about the little legend on the watchlist :D

[20:54:36] <Lydia_WMDE>	 and wohoooooooo for ranks, ordering and a toc \o/
[20:55:42] <aude>	 :)
[20:56:32] <multichill>	 Lydia_WMDE: coordinate location is empty after the update
[20:56:44] <Lydia_WMDE>	 multichill: woah woah woah
[20:56:46] <Lydia_WMDE>	 link?
[20:56:52] <aude>	 wtf?
[20:56:56] <benestar>	 :O
[20:56:57] <multichill>	 https://www.wikidata.org/wiki/Q3969608
[20:57:02] <multichill>	 [url <nothing>]
[20:57:18] <multichill>	 So I guess it might be the script rewriting things
[20:57:24] <Lydia_WMDE>	 multichill: looks fine here
[20:57:31] <Lydia_WMDE>	 can you purge?
[20:57:34] <aude>	 loosk ok
[20:57:35] <aude>	 looks*
[20:57:48] <lbenedix>	 is there an introduction for this rank thingy?
[20:58:05] <aude>	 benestar's map things are on the left of coordinates now
[20:58:10] <aude>	 not a problem
[20:59:07] <benestar>	 aude: seems that the change has broken the gadget
[20:59:08] <Pyb>	 I have the same problem of multichill on FF but not on Chrome
[20:59:15] <aude>	 be	hmm
[20:59:19] <aude>	 hmm*
[20:59:29] <multichill>	 FF it's gone, IE it's there. You should really set the expire times of this js things to something short if you plan updates
[20:59:53] <aude>	 also the coordinates are reversed for me (btw, if coordinates are west)
[21:00:17] <aude>	 in the map
[21:03:13] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1402 (master - 2c23b6a : Translation updater bot): The build is still failing.
[21:03:13] <travis-ci>	 [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c5d97500c061...2c23b6a69816
[21:03:13] <travis-ci>	 [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/15248572
[21:07:16] <aude>	 also, fyi https://gerrit.wikimedia.org/r/#/c/98002/ is being deployed for abuse filter on wikidata
[21:07:49] <benestar>	 aude: is any fix needed for the maps gadget?
[21:08:15] <JL|cloud>	 Aude: Love emails :p Just beat you.
[21:08:53] <aude>	 benestar: probably but can't look right now
[21:10:15] <aude>	 stuff in nyc appears in kyrgyzstan
[21:10:31] <Raymond_>	 hmmmm coordinates are invisible now: https://www.wikidata.org/wiki/Q1246781
[21:11:55] <aude>	 oh, can reproduce
[21:11:57] <aude>	 in ff
[21:12:08] <lbenedix>	 I see coordinates in chrome
[21:12:16] <aude>	 they were there briefly then disappeard
[21:12:20] <aude>	 *
[21:12:30] <Lydia_WMDE>	 probably a script issue then
[21:12:39] <Lydia_WMDE>	 can we turn off maps gadget for testing?
[21:13:07] <aude>	 i am logged out in firefox
[21:13:24] <aude>	 unless it's a default gadget... it's making a geohack link
[21:13:30] <Lydia_WMDE>	 authority control gadget then?
[21:13:37] <Lydia_WMDE>	 that is default
[21:13:47] <aude>	 no idea
[21:13:53] <benestar>	 Lydia_WMDE: or my maps script
[21:13:53] * Lydia_WMDE  logs in in firefox to test

[21:13:59] <benestar>	 just testing
[21:14:00] <aude>	 bene's thing is not a gadget, afaik
[21:14:07] <Lydia_WMDE>	 benestar: ok
[21:14:47] <benestar>	 Lydia_WMDE: no, it must be authority control 
[21:14:54] <aude>	 yeah
[21:14:55] * Lydia_WMDE  is testing

[21:14:58] <aude>	 can someone disable it
[21:15:15] <Lydia_WMDE>	 doing that right now
[21:15:19] <aude>	 k
[21:15:25] <JL|cloud>	 Hm?
[21:15:31] <Lydia_WMDE>	 bingo
[21:15:32] * aude  not comfortable using staff rights :)

[21:15:40] <Lydia_WMDE>	 so it is the authority control gadget
[21:15:49] <Lydia_WMDE>	 anyone got time and script foo to look into it?
[21:15:56] <Lydia_WMDE>	 otherwise i will ask henning tomorrow
[21:16:05] <Lydia_WMDE>	 and it'll be broken in FF until then
[21:16:09] <Lydia_WMDE>	 chrome seems to work
[21:16:49] * Lydia_WMDE  puts it on todo for tomorrow

[21:16:56] <Lydia_WMDE>	 Raymond_: multichill: thanks for poking about it
[21:17:40] <Raymond_>	 Lydia_WMDE: yeah thanks fro your work :)
[21:17:41] <JL|cloud>	 Aude: Howcome? WMF seem to enjoy using it :p Is it a WMDE thing where staff dislike using them? :p
[21:18:34] <aude>	 heh
[21:20:08] <Tpt_>	 Lydia_WMDE: I think I've solve the issue with AuthorityControl: https://www.wikidata.org/w/index.php?title=MediaWiki%3AGadget-AuthorityControl.js&diff=92632710&oldid=92607026
[21:20:20] <Lydia_WMDE>	 Tpt_: you're the best :P
[21:21:06] * Lydia_WMDE  tests

[21:21:43] <Lydia_WMDE>	 ewww
[21:21:49] <Lydia_WMDE>	 now item pages do something weird
[21:21:59] <Lydia_WMDE>	 the first statement is attached to the in other languages box
[21:22:03] <Lydia_WMDE>	 Tpt_: ^ 
[21:22:05] <JeroenDeDauw>	 !nyan | Lydia_WMDE 
[21:22:05] <wm-bot>	 Lydia_WMDE: ~=[,,_,,]:3
[21:22:15] <Lydia_WMDE>	 in chrome
[21:22:24] * Lydia_WMDE  purges page

[21:22:35] <benestar>	 lol
[21:22:37] <benestar>	 xD
[21:22:38] <JeroenDeDauw>	 ~=[,,_,,]:3 purges Lydia_WMDE 
[21:22:46] <benestar>	 xxxDDDDDDD
[21:23:01] <Lydia_WMDE>	 -.-
[21:23:56] <Lydia_WMDE>	 Tpt_: hmm no - purge does not fix that issue - do you see it?
[21:24:03] <JeroenDeDauw>	 Lydia_WMDE: oh, BTC went up 50 EUR since you refused to be paid in it earlier today ;p
[21:24:12] <Lydia_WMDE>	 JeroenDeDauw: -.-
[21:24:33] <Lydia_WMDE>	 more important things right now
[21:25:06] * JeroenDeDauw  goes annoy some other people somewhere else then

[21:25:31] <Lydia_WMDE>	 ;-)
[21:26:43] <aude>	 Lydia_WMDE: Tpt_ seems okay to me
[21:26:56] <Lydia_WMDE>	 aude: can you look at berlin
[21:27:02] <Lydia_WMDE>	 in chrome
[21:27:05] <hoo>	 DanielK_WMDE: uhm... there?
[21:27:06] <aude>	 what number?
[21:27:08] <Tpt_>	 https://www.wikidata.org/wiki/Q4115189 works for me
[21:27:09] <Lydia_WMDE>	 64
[21:27:10] <aude>	 k
[21:27:21] <DanielK_WMDE>	 hoo: yea, but not really awake
[21:27:42] <Lydia_WMDE>	 Tpt_: same issue there for me
[21:27:47] * aude  waits...

[21:27:52] <Lydia_WMDE>	 Tpt_: do you have the "in other languages box"?
[21:28:03] <Tpt_>	 yes
[21:28:07] <Lydia_WMDE>	 with how many languages?
[21:28:10] <aude>	 and waits
[21:28:15] <Lydia_WMDE>	 aude: :P
[21:28:18] <Tpt_>	 Lydia_WMDE: 3
[21:28:18] <aude>	 there
[21:28:23] <Lydia_WMDE>	 Tpt_: hmmm me too
[21:28:34] <aude>	 looksk fine
[21:28:37] <aude>	 looks
[21:28:42] <Tpt_>	 I use the interface in French
[21:28:47] * aude  has other languages

[21:29:10] <Lydia_WMDE>	 Tpt_: hmmm in one chrome profile it is fine but not in the other
[21:29:18] <Lydia_WMDE>	 for the same item
[21:29:23] <Lydia_WMDE>	 different accounts logged in
[21:29:36] * Lydia_WMDE  tries reload

[21:29:40] * aude  cant' look at Q64 in firefox

[21:29:54] <Lydia_WMDE>	 aude: no :(
[21:29:59] <hoo>	 DanielK_WMDE: maybe I'm to tired to get you're email, but you realize we have to Memcached vars for parser cache?
[21:30:03] <aude>	 my usb stick is too slow
[21:30:04] <hoo>	 That's what I tried to tell you earlier
[21:30:10] <hoo>	 			// Save the parser output
[21:30:11] <hoo>	 			$this->mMemc->set( $parserOutputKey, $parserOutput, $expire );
[21:30:11] <hoo>	 			// ...and its pointer
[21:30:11] <hoo>	 			$this->mMemc->set( $this->getOptionsKey( $article ), $optionsKey, $expire );
[21:30:17] <Tpt_>	 Q4115189 works for me in Chrome logout
[21:30:29] <Lydia_WMDE>	 reload does not help
[21:30:30] <hoo>	 ParserOptions::optionsHash does the distinction based on all the magic
[21:30:53] <hoo>	 * two
[21:31:04] <Lydia_WMDE>	 purge also not
[21:31:28] <DanielK_WMDE>	 hoo: yes, i saw that code. and yes, that's what i thought. and it worked when testing. 
[21:31:33] <benestar>	 Lydia_WMDE: what item are you testing right now?
[21:31:34] <DanielK_WMDE>	 but not on the live site
[21:31:41] <DanielK_WMDE>	 an don't quite understand why and how
[21:31:50] <Lydia_WMDE>	 benestar: berlin and sandbox
[21:32:12] <DanielK_WMDE>	 hoo: perhaps reply to my mail, explaining how you understand how it works.
[21:32:42] <hoo>	 DanielK_WMDE: mh... to tired right now, but I already worked with these user lang. distinction f... up and it worked out of the box
[21:32:56] <hoo>	 on WMF, of course
[21:33:07] <DanielK_WMDE>	 send a link to that code, then :)
[21:33:27] <hoo>	 uh
[21:34:17] <DanielK_WMDE>	 hm... i think i'm beginning to see... the "options key" is an object that contains the list of options to consider
[21:34:30] <DanielK_WMDE>	 if we hit an *old* cached object key, it would have the wrong info in there
[21:34:43] <DanielK_WMDE>	 causing everyone to use the (obsolete) generic key.
[21:35:04] <DanielK_WMDE>	 still doesn't fully explain what we saw, but i guess it's something like that
[21:35:14] <DanielK_WMDE>	 maybe we need a way to bump some version id on these cache keys
[21:36:16] <hoo>	 mh
[21:37:14] <hoo>	 Strictly speaking: In theory this all works with just $wgParser->getOptions()->getUserLangObj(); that's how various deployed extensions basically do it (boiled down)
[21:37:27] <hoo>	 so there is something awry below the lines
[21:38:09] <hoo>	 maybe our ParserOptions get lost somewhere so taht they default to generic ones?
[21:39:07] <hoo>	 I don't see how old cache keys could cause this, these are simply ignored AFAIS
[21:39:43] <benestar>	 Lydia_WMDE: what's the exact problem atm?
[21:40:16] <Lydia_WMDE>	 benestar: the top-most statement is attached to the in other languages box without the statement heading in between
[21:40:24] <Lydia_WMDE>	 but only in one of my two chrome profiles
[21:40:25] <benestar>	 not in FF for me
[21:40:47] <Lydia_WMDE>	 if no-one else is seeing it then we can discard this i guess
[21:41:51] * aude  thinks Lydia_WMDE is crazy :P

[21:42:07] <aude>	 probably no one has other languages except a few of us
[21:42:10] <Lydia_WMDE>	 whaaaaaaaaaaat? :D
[21:42:15] <Lydia_WMDE>	 hehe 
[21:42:16] <Lydia_WMDE>	 well
[21:42:19] <aude>	 :)
[21:42:21] <Lydia_WMDE>	 i would hope not
[21:42:26] <Lydia_WMDE>	 but i fear you are right
[21:42:42] <Lydia_WMDE>	 we really need to show the box by default
[21:42:43] <aude>	 but i still don't see the issue
[21:42:54] <benestar>	 Lydia_WMDE: can not confirm it in my chrome
[21:42:59] <Lydia_WMDE>	 hah!
[21:43:03] <Lydia_WMDE>	 benestar: thanks! :P
[21:43:07] <Lydia_WMDE>	 you're my hero
[21:43:11] <benestar>	 :D
[21:43:21] * Lydia_WMDE  is not crazy \o/

[21:43:30] <aude>	 heh
[21:43:31] * benestar  is not sure about that

[21:43:36] <Lydia_WMDE>	 lol
[21:43:50] <Lydia_WMDE>	 benestar: careful! you might lose hero status quickly again :P
[21:44:31] <Lydia_WMDE>	 benestar: also clicking on statements in the ToC doesn't take me anywhere
[21:44:37] <hoo>	 DanielK_WMDE: I may found something .... do you think $this->mMemc->get( $this->getOptionsKey( $article ) ); returned false initially?
[21:44:38] <Lydia_WMDE>	 so it seems that heading is gone completely
[21:44:46] <hoo>	 because the article wasn't in cache ever before?
[21:44:57] <hoo>	 If that's true, the whole thing makes sense
[21:46:05] <Lydia_WMDE>	 ok folks - i need a break now
[21:46:11] <Lydia_WMDE>	 <3
[21:46:17] <aude>	 k
[21:47:41] <benestar>	 Lydia_WMDE: I thought you're working 24 hours a day :o
[21:48:31] <legoktm>	 the TOC looks very similar to how categorylinks look at the bottom of a page imo
[21:55:30] <multichill>	 Lydia_WMDE: Ok. I got the occasional index out of bounds errors when trying to add a cliam. Known problem?
[21:55:46] <Lydia_WMDE>	 benestar|afk: i try not to :P
[21:55:54] <Lydia_WMDE>	 multichill: no - can you file a report please?
[21:57:38] <hoo>	 DanielK_WMDE: Sent a mail... hopefully that one is clear
[22:21:43] <multichill>	 Lydia_WMDE: Will do later. Replag for wikidata seems a bit high
[22:37:19] <grrrit-wm>	 (03PS1) 10Aude: Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100697 
[22:37:39] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100697 (owner: 10Aude)
[22:42:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ensure TermPropertyLabelResolve memcached is per language [extensions/Wikibase] (mw1.23-wmf6) - 10https://gerrit.wikimedia.org/r/100697 (owner: 10Aude)